mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/hexdump: Inline g_string_append_printf "%02x"

Browse Source 
Trivial arithmetic can be used for emitting the nibbles,
rather than full-blown printf formatting.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20240412073346.458116-6-richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2024-04-12 00:33:24 -07:00
parent c49d1c37d8
commit 10e4927bc4
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
util/hexdump.c
View File

@ -16,6 +16,11 @@
#include "qemu/osdep.h" #include "qemu/osdep.h"
#include "qemu/cutils.h" #include "qemu/cutils.h"
static inline char hexdump_nibble(unsigned x)
{
return (x < 10 ? '0' : 'a' - 10) + x;
}
GString *qemu_hexdump_line(GString *str, const void *vbuf, size_t len, GString *qemu_hexdump_line(GString *str, const void *vbuf, size_t len,
size_t unit_len, size_t block_len) size_t unit_len, size_t block_len)
{ {
@ -35,6 +40,8 @@ GString *qemu_hexdump_line(GString *str, const void *vbuf, size_t len,
} }
for (u = 0, b = 0; len; u++, b++, len--, buf++) { for (u = 0, b = 0; len; u++, b++, len--, buf++) {
uint8_t c;
if (unit_len && u == unit_len) { if (unit_len && u == unit_len) {
g_string_append_c(str, ' '); g_string_append_c(str, ' ');
u = 0; u = 0;
@ -43,7 +50,10 @@ GString *qemu_hexdump_line(GString *str, const void *vbuf, size_t len,
g_string_append_c(str, ' '); g_string_append_c(str, ' ');
b = 0; b = 0;
} }
g_string_append_printf(str, "%02x", *buf);
c = *buf;
g_string_append_c(str, hexdump_nibble(c / 16));
g_string_append_c(str, hexdump_nibble(c % 16));
} }
return str; return str;