Fix Coverity CID 1412799 (Error handling issues)

-----BEGIN PGP SIGNATURE-----
 
 iQJGBAABCAAwFiEEzS913cjjpNwuT1Fz8ww4vT8vvjwFAl5qUfUSHGxhdXJlbnRA
 dml2aWVyLmV1AAoJEPMMOL0/L748HSEP/1Amg4MciUCxGB7SpwS48gGvyJOh+voW
 l6iHB0PZfqhBNhGQdDO/ZzzWH1ASK++7hocCE5aHG/PfvOxhncaMMETeBdPyTaKD
 QaUC94SexQRYROqn0JiJX6czPbOx4sDs/mzO7dnMFx7VVWGOku6U2poClltf052E
 4lWBwWyjllRBitTEjP+4iQBD6DvurJR03zTbKx7EACn4sbJSQvMpR5T2IXffqKDO
 Qj0RXDbQF0lQfE1FacJmG5/OBtJ62f2TCJgvVew2zU0jZz6IGXYjbTgQstb6SN8q
 nEBisGeArHLMFJP2hjkAW9AIqyJdaZkHCnt4dCqTUdkDTfpwpeP0OxxWfmi/wPeD
 Rs31TY3L0AdEMI3VLgKUlCrHVk4Qc8LEO7vbvdtdSIE6Kk3RtWI9tQCP+XQZOjH1
 qKqwrUQXCc9Ox2wXZxdlDbgmmemRE7P7eGHPWuMAk4X82nbBORnKbMqhG2bK5Ail
 axmE2VtM+jtAkfq4MIe53ket2iH0XYsTLWETUGdbZDxybop7+5jPrBxZ5K+9gvNx
 jObKDOhnZfPelW3l8MSLQN54ViStyfDSHonHE/p1SHWuv2rmyDW0/+SaUIE5XtI4
 IoWWin9s+ZF0OdXgOuIzT71jhA12iyHDBqUs9lqS9GUsbFRIARucPX8cQS1xsXsh
 UZ5ugLBNr9ge
 =p/xu
 -----END PGP SIGNATURE-----

Merge remote-tracking branch 'remotes/vivier/tags/q800-for-5.0-pull-request' into staging

Fix Coverity CID 1412799 (Error handling issues)

# gpg: Signature made Thu 12 Mar 2020 15:15:01 GMT
# gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg:                issuer "laurent@vivier.eu"
# gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full]
# gpg:                 aka "Laurent Vivier <laurent@vivier.eu>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>" [full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier/tags/q800-for-5.0-pull-request:
  q800: fix coverity warning CID 1412799

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Peter Maydell 2020-03-12 16:00:31 +00:00
commit 10b114008a

View File

@ -30,6 +30,7 @@
#include "hw/qdev-properties.h"
#include "sysemu/block-backend.h"
#include "trace.h"
#include "qemu/log.h"
/*
* VIAs: There are two in every machine,
@ -381,8 +382,10 @@ static void via2_irq_request(void *opaque, int irq, int level)
static void pram_update(MacVIAState *m)
{
if (m->blk) {
blk_pwrite(m->blk, 0, m->mos6522_via1.PRAM,
sizeof(m->mos6522_via1.PRAM), 0);
if (blk_pwrite(m->blk, 0, m->mos6522_via1.PRAM,
sizeof(m->mos6522_via1.PRAM), 0) < 0) {
qemu_log("pram_update: cannot write to file\n");
}
}
}