mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tcg: Put target helper data into an array.

Browse Source 
One call inside of a loop to tcg_register_helper instead of hundreds
of sequential calls.

Presumably more icache and branch prediction friendly; resulting binary
size mostly unchanged on x86_64, as we're trading 32-bit rip-relative
references in .text for full 64-bit pointers in .rodata.

Signed-off-by: Richard Henderson <rth@twiddle.net>
This commit is contained in:
Richard Henderson 2013-09-14 15:57:22 -07:00
parent f5daeec412
commit 100b5e0170
2 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/exec/def-helper.h
View File

@ -240,8 +240,7 @@ static inline void glue(gen_helper_, name)(dh_retvar_decl(ret) \
#elif GEN_HELPER == 2
/* Register helpers. */
#define DEF_HELPER_FLAGS_0(name, flags, ret) \
tcg_register_helper(HELPER(name), #name);
#define DEF_HELPER_FLAGS_0(name, flags, ret) { HELPER(name), #name },
#define DEF_HELPER_FLAGS_1(name, flags, ret, t1) \
DEF_HELPER_FLAGS_0(name, flags, ret)

17
tcg/tcg.c
View File

@ -256,9 +256,19 @@ void tcg_pool_reset(TCGContext *s)
#include "helper.h"
typedef struct TCGHelperInfo {
void *func;
const char *name;
} TCGHelperInfo;
static const TCGHelperInfo all_helpers[] = {
#define GEN_HELPER 2
#include "helper.h"
};
void tcg_context_init(TCGContext *s)
{
int op, total_args, n;
int op, total_args, n, i;
TCGOpDef *def;
TCGArgConstraint *args_ct;
int *sorted_args;
@ -288,8 +298,9 @@ void tcg_context_init(TCGContext *s)
}
/* Register helpers. */
#define GEN_HELPER 2
#include "helper.h"
for (i = 0; i < ARRAY_SIZE(all_helpers); ++i) {
tcg_register_helper(all_helpers[i].func, all_helpers[i].name);
}
tcg_target_init(s);
}