mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

target/arm: Set S and PTW in 64-bit PAR format

Browse Source 
In do_ats_write() we construct a PAR value based on the result
of the translation.  A comment says "S2WLK and FSTAGE are always
zero, because we don't implement virtualization".
Since we do in fact now implement virtualization, add the missing
code that sets these bits based on the reported ARMMMUFaultInfo.

(These bits are named PTW and S in ARMv8, so we follow that
convention in the new comments in this patch.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 20181016093703.10637-2-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2018-11-06 11:32:14 +00:00
parent 76a82ced11
commit 0f7b791b35
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
target/arm/helper.c
View File

@ -2347,10 +2347,12 @@ static uint64_t do_ats_write(CPUARMState *env, uint64_t value,
par64 |= 1; /* F */ par64 |= 1; /* F */
par64 |= (fsr & 0x3f) << 1; /* FS */ par64 |= (fsr & 0x3f) << 1; /* FS */
/* Note that S2WLK and FSTAGE are always zero, because we don't if (fi.stage2) {
* implement virtualization and therefore there can't be a stage 2 par64 |= (1 << 9); /* S */
* fault. }
*/ if (fi.s1ptw) {
par64 |= (1 << 8); /* PTW */
}
} }
} else { } else {
/* fsr is a DFSR/IFSR value for the short descriptor /* fsr is a DFSR/IFSR value for the short descriptor