mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

block: Improve errors about block sizes

Browse Source 
Block sizes need to be a power of two between 512 and an arbitrary
limit, currently 2MiB.

Commit 5937835ac4 factored block size checking out of set_blocksize()
into new check_block_size(), for reuse in block/export/.

Its two error messages are okay for the original purpose:

    $ qemu-system-x86_64 -device ide-hd,physical_block_size=1
    qemu-system-x86_64: -device ide-hd,physical_block_size=1: Property .physical_block_size doesn't take value 1 (minimum: 512, maximum: 2097152)
    $ qemu-system-x86_64 -device ide-hd,physical_block_size=513
    qemu-system-x86_64: -device ide-hd,physical_block_size=513: Property .physical_block_size doesn't take value '513', it's not a power of 2

They're mildly off for block exports:

    $ qemu-storage-daemon --blockdev node-name=nod0,driver=file,filename=foo.img --export type=vduse-blk,id=exp0,node-name=nod0,name=foo,logical-block-size=1
    qemu-storage-daemon: --export type=vduse-blk,id=exp0,node-name=nod0,name=foo,logical-block-size=1: Property exp0.logical-block-size doesn't take value 1 (minimum: 512, maximum: 2097152)

The error message talks about a property.  CLI options like --export
don't have properties, they have parameters.

Replace the two error messages by a single one that's okay for both
purposes.  Looks like this:

    qemu-storage-daemon: --export type=vduse-blk,id=exp0,node-name=nod0,name=foo,logical-block-size=1: parameter logical-block-size must be a power of 2 between 512 and 2097152

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20241010150144.986655-3-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Markus Armbruster 2024-10-10 17:01:39 +02:00
parent fd1d47740d
commit 0f799b83bd
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
util/block-helpers.c
View File

@ -10,7 +10,6 @@
#include "qemu/osdep.h" #include "qemu/osdep.h"
#include "qapi/error.h" #include "qapi/error.h"
#include "qapi/qmp/qerror.h"
#include "block-helpers.h" #include "block-helpers.h"
/** /**
@ -28,19 +27,16 @@
void check_block_size(const char *id, const char *name, int64_t value, void check_block_size(const char *id, const char *name, int64_t value,
Error **errp) Error **errp)
{ {
/* value of 0 means "unset" */ if (!value) {
if (value && (value < MIN_BLOCK_SIZE || value > MAX_BLOCK_SIZE)) { /* unset */
error_setg(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
id, name, value, MIN_BLOCK_SIZE, MAX_BLOCK_SIZE);
return; return;
} }
/* We rely on power-of-2 blocksizes for bitmasks */ if (value < MIN_BLOCK_SIZE || value > MAX_BLOCK_SIZE
if ((value & (value - 1)) != 0) { || (value & (value - 1))) {
error_setg(errp, error_setg(errp,
"Property %s.%s doesn't take value '%" PRId64 "parameter %s must be a power of 2 between %" PRId64
"', it's not a power of 2", " and %" PRId64,
id, name, value); name, MIN_BLOCK_SIZE, MAX_BLOCK_SIZE);
return;
} }
} }