mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vhost-scsi: fix k->set_guest_notifiers() NULL dereference

Browse Source 
Coverity picked up a copy-paste bug.  In vhost_scsi_start() we check for
!k->set_guest_notifiers and error out.  The check probably got copied
but instead of erroring we actually use the function pointer!

Cc: Nicholas Bellinger <nab@linux-iscsi.org>
Cc: Asias He <asias@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Stefan Hajnoczi 2013-05-30 16:14:44 +02:00 committed by Paolo Bonzini
parent 18e673b8f3
commit 0e22a2d189
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/scsi/vhost-scsi.c
View File

@ -123,7 +123,7 @@ static void vhost_scsi_stop(VHostSCSI *s)
VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
int ret = 0; int ret = 0;
if (!k->set_guest_notifiers) { if (k->set_guest_notifiers) {
ret = k->set_guest_notifiers(qbus->parent, s->dev.nvqs, false); ret = k->set_guest_notifiers(qbus->parent, s->dev.nvqs, false);
if (ret < 0) { if (ret < 0) {
error_report("vhost guest notifier cleanup failed: %d\n", ret); error_report("vhost guest notifier cleanup failed: %d\n", ret);