From 0ce9b08c10d043307d125709032a897d05c80bdd Mon Sep 17 00:00:00 2001 From: Thomas Huth Date: Fri, 13 May 2022 08:39:58 +0200 Subject: [PATCH] docs/about: Update the support statement for Windows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Our support statement for Windows currently talks about "Vista / Server 2008" - which is related to the API of Windows, and this is not easy to understand for the non-technical users. Additionally, glib sets the _WIN32_WINNT macro to 0x0601 already, which indicates the Windows 7 API, so QEMU effectively depends on the Windows 7 API, too. Thus let's bump the _WIN32_WINNT setting in QEMU to the same level as glib uses and adjust our support statement in the documentation to something similar that we're using for Linux and the *BSD systems (i.e. only the two most recent versions), which should hopefully be easier to understand for the users now. And since we're nowadays also compile-testing QEMU with MSYS2 on Windows itself, I think we could mention this build environment here, too. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/880 Reviewed-by: Daniel P. Berrangé Reviewed-by: Stefan Weil Message-Id: <20220513063958.1181443-1-thuth@redhat.com> Signed-off-by: Thomas Huth --- configure | 2 ++ docs/about/build-platforms.rst | 12 ++++++++---- include/qemu/osdep.h | 2 +- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 0cc8c876f7..103a7b02e8 100755 --- a/configure +++ b/configure @@ -1486,6 +1486,8 @@ fi ########################################## # glib support probe +# When bumping glib_req_ver, please check also whether we should increase +# the _WIN32_WINNT setting in osdep.h according to the value from glib glib_req_ver=2.56 glib_modules=gthread-2.0 if test "$modules" = yes; then diff --git a/docs/about/build-platforms.rst b/docs/about/build-platforms.rst index e9163ba556..1958edb430 100644 --- a/docs/about/build-platforms.rst +++ b/docs/about/build-platforms.rst @@ -86,11 +86,15 @@ similar versions. Windows ------- -The project supports building with current versions of the MinGW toolchain, -hosted on Linux (Debian/Fedora). +The project aims to support the two most recent versions of Windows that are +still supported by the vendor. The minimum Windows API that is currently +targeted is "Windows 7", so theoretically the QEMU binaries can still be run +on older versions of Windows, too. However, such old versions of Windows are +not tested anymore, so it is recommended to use one of the latest versions of +Windows instead. -The version of the Windows API that's currently targeted is Vista / Server -2008. +The project supports building QEMU with current versions of the MinGW +toolchain, either hosted on Linux (Debian/Fedora) or via MSYS2 on Windows. .. _Homebrew: https://brew.sh/ .. _MacPorts: https://www.macports.org/ diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 1c1e7eca98..a72e99db85 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -75,7 +75,7 @@ QEMU_EXTERN_C int daemon(int, int); #ifdef _WIN32 /* as defined in sdkddkver.h */ #ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x0600 /* Vista */ +#define _WIN32_WINNT 0x0601 /* Windows 7 API (should be in sync with glib) */ #endif /* reduces the number of implicitly included headers */ #ifndef WIN32_LEAN_AND_MEAN