mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hw/i2c/aspeed: Fix MASTER_EN missing error message

Browse Source 
aspeed_i2c_bus_is_master is checking if master mode is enabled in the I2C
bus controller's function-control register, not that slave mode is enabled
or something.  The error here is that the guest is trying to trigger an I2C
master mode command while master mode is not enabled.

Fixes: ba2cccd64e ("aspeed: i2c: Add new mode support")
Signed-off-by: Peter Delevoryas <pdel@fb.com>
Message-Id: <20220630045133.32251-4-me@pjd.dev>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
This commit is contained in:
Peter Delevoryas 2022-06-30 09:21:14 +02:00 committed by Cédric Le Goater
parent b582b7a191
commit 0c0f1bee6a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/i2c/aspeed_i2c.c
View File

@ -601,7 +601,7 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus, hwaddr offset,
} }
if (!aspeed_i2c_bus_is_master(bus)) { if (!aspeed_i2c_bus_is_master(bus)) {
qemu_log_mask(LOG_UNIMP, "%s: slave mode not implemented\n", qemu_log_mask(LOG_GUEST_ERROR, "%s: Master mode is not enabled\n",
__func__); __func__);
break; break;
} }
@ -744,7 +744,7 @@ static void aspeed_i2c_bus_old_write(AspeedI2CBus *bus, hwaddr offset,
} }
if (!aspeed_i2c_bus_is_master(bus)) { if (!aspeed_i2c_bus_is_master(bus)) {
qemu_log_mask(LOG_UNIMP, "%s: slave mode not implemented\n", qemu_log_mask(LOG_GUEST_ERROR, "%s: Master mode is not enabled\n",
__func__); __func__);
break; break;
} }