mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

target/arm/monitor: query-cpu-model-expansion crashed qemu when using machine type none

Browse Source 
Commit e19afd5667 mentioned that target-arm only supports queryable
cpu models 'max', 'host', and the current type when KVM is in use.
The logic works well until using machine type none.

For machine type none, cpu_type will be null if cpu option is not
set by command line, strlen(cpu_type) will terminate process.
So We add a check above it.

This won't affect i386 and s390x since they do not use current_cpu.

Signed-off-by: Liang Yan <lyan@suse.com>
Message-id: 20200203134251.12986-1-lyan@suse.com
Reviewed-by: Andrew Jones <drjones@redhat.com>
Tested-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Liang Yan 2020-02-07 14:04:21 +00:00 committed by Peter Maydell
parent 346ed3151f
commit 0999a4ba87
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
target/arm/monitor.c
View File

@ -137,17 +137,20 @@ CpuModelExpansionInfo *qmp_query_cpu_model_expansion(CpuModelExpansionType type,
} }
if (kvm_enabled()) { if (kvm_enabled()) {
const char *cpu_type = current_machine->cpu_type;
int len = strlen(cpu_type) - strlen(ARM_CPU_TYPE_SUFFIX);
bool supported = false; bool supported = false;
if (!strcmp(model->name, "host") || !strcmp(model->name, "max")) { if (!strcmp(model->name, "host") || !strcmp(model->name, "max")) {
/* These are kvmarm's recommended cpu types */ /* These are kvmarm's recommended cpu types */
supported = true; supported = true;
} else if (strlen(model->name) == len && } else if (current_machine->cpu_type) {
!strncmp(model->name, cpu_type, len)) { const char *cpu_type = current_machine->cpu_type;
/* KVM is enabled and we're using this type, so it works. */ int len = strlen(cpu_type) - strlen(ARM_CPU_TYPE_SUFFIX);
supported = true;
if (strlen(model->name) == len &&
!strncmp(model->name, cpu_type, len)) {
/* KVM is enabled and we're using this type, so it works. */
supported = true;
}
} }
if (!supported) { if (!supported) {
error_setg(errp, "We cannot guarantee the CPU type '%s' works " error_setg(errp, "We cannot guarantee the CPU type '%s' works "