tracetool: also strip %l and %ll from systemtap format strings
All variables are 64-bit and so %l / %ll are not required, and the latter is actually invalid: $ sudo stap -e 'probe begin{printf ("BEGIN")}' -I . parse error: invalid or missing conversion specifier saw: operator ',' at ./qemu-system-x86_64-log.stp:15118:101 source: printf("%d@%d vhost_vdpa_set_log_base dev: %p base: 0x%x size: %llu refcnt: %d fd: %d log: %p\n", pid(), gettimeofday_ns(), dev, base, size, refcnt, fd, log) ^ Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Laurent Vivier <lvivier@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Laurent Vivier <lvivier@redhat.com> Message-id: 20210106130239.1004729-1-berrange@redhat.com [Fixed "simiarly" typo found by Laurent Vivier <lvivier@redhat.com> --Stefan] Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
parent
9f4e519fd7
commit
09612de7e9
@ -78,7 +78,12 @@ def c_fmt_to_stap(fmt):
|
|||||||
elif state == STATE_LITERAL:
|
elif state == STATE_LITERAL:
|
||||||
bits.append(literal)
|
bits.append(literal)
|
||||||
|
|
||||||
fmt = re.sub("%(\d*)z(x|u|d)", "%\\1\\2", "".join(bits))
|
# All variables in systemtap are 64-bit in size
|
||||||
|
# The "%l" integer size qualifier is thus redundant
|
||||||
|
# and "%ll" is not valid at all. Similarly the size_t
|
||||||
|
# based "%z" size qualifier is not valid. We just
|
||||||
|
# strip all size qualifiers for sanity.
|
||||||
|
fmt = re.sub("%(\d*)(l+|z)(x|u|d)", "%\\1\\3", "".join(bits))
|
||||||
return fmt
|
return fmt
|
||||||
|
|
||||||
def generate(events, backend, group):
|
def generate(events, backend, group):
|
||||||
|
Loading…
Reference in New Issue
Block a user