mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix and improve qint_from_int64_test

Browse Source 
Use a long long integer constant to fix a compilation error (integer
constant is too large for 'long' type).

Use a better value for testing, as -1 makes the test pass even if
qi->value is of type uint32_t, float or double. This was suggested by
Reimar Döffinger <Reimar.Doeffinger@gmx.de>.

Also, make the test fail when qi->value is of type double or float by
casting qi->value to int64_t, to avoid value being promoted to the type
of qi->value.

Signed-off-by: Pierre Riteau <Pierre.Riteau@irisa.fr>
Acked-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
This commit is contained in:
Pierre Riteau 2009-09-08 11:53:37 +02:00 committed by Aurelien Jarno
parent e0fed6cca7
commit 02c068c3ae
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
check-qint.c
View File

@ -43,10 +43,10 @@ END_TEST
START_TEST(qint_from_int64_test)
{
QInt *qi;
const int64_t value = 0xffffffffffffffff;
const int64_t value = 0x1234567890abcdefLL;
qi = qint_from_int(value);
fail_unless(qi->value == value);
fail_unless((int64_t) qi->value == value);
QDECREF(qi);
}