mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net/filter-rewriter.c: Fix coverity static analysis issue

Browse Source 
The original code just follow the TCP state diagram,
but in this case, we can skip the TCPS_TIME_WAIT state to simplify
the implementation.

Signed-off-by: Zhang Chen <zhangckid@gmail.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
This commit is contained in:
Zhang Chen 2018-10-31 08:50:15 +08:00 committed by Jason Wang
parent d835c61924
commit 013a62020a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/filter-rewriter.c
View File

@ -155,12 +155,13 @@ static int handle_primary_tcp_pkt(RewriterState *rf,
* Active close step 2. * Active close step 2.
*/ */
if (conn->tcp_state == TCPS_FIN_WAIT_1) { if (conn->tcp_state == TCPS_FIN_WAIT_1) {
conn->tcp_state = TCPS_TIME_WAIT;
/* /*
* For simplify implementation, we needn't wait 2MSL time * For simplify implementation, we needn't wait 2MSL time
* in filter rewriter. Because guest kernel will track the * in filter rewriter. Because guest kernel will track the
* TCP status and wait 2MSL time, if client resend the FIN * TCP status and wait 2MSL time, if client resend the FIN
* packet, guest will apply the last ACK too. * packet, guest will apply the last ACK too.
* So, we skip the TCPS_TIME_WAIT state here and go straight
* to TCPS_CLOSED state.
*/ */
conn->tcp_state = TCPS_CLOSED; conn->tcp_state = TCPS_CLOSED;
g_hash_table_remove(rf->connection_track_table, key); g_hash_table_remove(rf->connection_track_table, key);