2019-09-17 13:43:42 +03:00
|
|
|
QA output created by 267
|
|
|
|
|
|
|
|
|
|
=== No block devices at all ===
|
|
|
|
|
|
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
|
|
|
Testing:
|
|
|
|
|
QEMU X.Y.Z monitor - type 'help' for more information
|
|
|
|
|
(qemu) savevm snap0
|
|
|
|
|
Error: No block device can accept snapshots
|
|
|
|
|
(qemu) info snapshots
|
|
|
|
|
No available block device supports snapshots
|
|
|
|
|
(qemu) loadvm snap0
|
|
|
|
|
Error: No block device supports snapshots
|
|
|
|
|
(qemu) quit
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
=== -drive if=none ===
|
|
|
|
|
|
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
|
|
|
Testing: -drive driver=file,file=TEST_DIR/t.IMGFMT,if=none
|
|
|
|
|
QEMU X.Y.Z monitor - type 'help' for more information
|
|
|
|
|
(qemu) savevm snap0
|
|
|
|
|
Error: Device 'none0' is writable but does not support snapshots
|
|
|
|
|
(qemu) info snapshots
|
|
|
|
|
No available block device supports snapshots
|
|
|
|
|
(qemu) loadvm snap0
|
|
|
|
|
Error: Device 'none0' is writable but does not support snapshots
|
|
|
|
|
(qemu) quit
|
|
|
|
|
|
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
|
|
|
Testing: -drive driver=IMGFMT,file=TEST_DIR/t.IMGFMT,if=none
|
|
|
|
|
QEMU X.Y.Z monitor - type 'help' for more information
|
|
|
|
|
(qemu) savevm snap0
|
|
|
|
|
(qemu) info snapshots
|
|
|
|
|
List of snapshots present on all disks:
|
|
|
|
|
ID TAG VM SIZE DATE VM CLOCK
|
|
|
|
|
-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
|
|
|
|
|
(qemu) loadvm snap0
|
|
|
|
|
(qemu) quit
|
|
|
|
|
|
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
|
|
|
Testing: -drive driver=IMGFMT,file=TEST_DIR/t.IMGFMT,if=none -device virtio-blk,drive=none0
|
|
|
|
|
QEMU X.Y.Z monitor - type 'help' for more information
|
|
|
|
|
(qemu) savevm snap0
|
|
|
|
|
(qemu) info snapshots
|
|
|
|
|
List of snapshots present on all disks:
|
|
|
|
|
ID TAG VM SIZE DATE VM CLOCK
|
|
|
|
|
-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
|
|
|
|
|
(qemu) loadvm snap0
|
|
|
|
|
(qemu) quit
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
=== -drive if=virtio ===
|
|
|
|
|
|
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
|
|
|
Testing: -drive driver=file,file=TEST_DIR/t.IMGFMT,if=virtio
|
|
|
|
|
QEMU X.Y.Z monitor - type 'help' for more information
|
|
|
|
|
(qemu) savevm snap0
|
|
|
|
|
Error: Device 'virtio0' is writable but does not support snapshots
|
|
|
|
|
(qemu) info snapshots
|
|
|
|
|
No available block device supports snapshots
|
|
|
|
|
(qemu) loadvm snap0
|
|
|
|
|
Error: Device 'virtio0' is writable but does not support snapshots
|
|
|
|
|
(qemu) quit
|
|
|
|
|
|
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
|
|
|
Testing: -drive driver=IMGFMT,file=TEST_DIR/t.IMGFMT,if=virtio
|
|
|
|
|
QEMU X.Y.Z monitor - type 'help' for more information
|
|
|
|
|
(qemu) savevm snap0
|
|
|
|
|
(qemu) info snapshots
|
|
|
|
|
List of snapshots present on all disks:
|
|
|
|
|
ID TAG VM SIZE DATE VM CLOCK
|
|
|
|
|
-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
|
|
|
|
|
(qemu) loadvm snap0
|
|
|
|
|
(qemu) quit
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
=== Simple -blockdev ===
|
|
|
|
|
|
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
|
|
|
Testing: -blockdev driver=file,filename=TEST_DIR/t.IMGFMT,node-name=file
|
|
|
|
|
QEMU X.Y.Z monitor - type 'help' for more information
|
|
|
|
|
(qemu) savevm snap0
|
|
|
|
|
Error: Device '' is writable but does not support snapshots
|
|
|
|
|
(qemu) info snapshots
|
|
|
|
|
No available block device supports snapshots
|
|
|
|
|
(qemu) loadvm snap0
|
|
|
|
|
Error: Device '' is writable but does not support snapshots
|
|
|
|
|
(qemu) quit
|
|
|
|
|
|
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
|
|
|
Testing: -blockdev driver=file,filename=TEST_DIR/t.IMGFMT,node-name=file -blockdev driver=IMGFMT,file=file,node-name=fmt
|
|
|
|
|
QEMU X.Y.Z monitor - type 'help' for more information
|
|
|
|
|
(qemu) savevm snap0
|
|
|
|
|
(qemu) info snapshots
|
|
|
|
|
List of snapshots present on all disks:
|
|
|
|
|
ID TAG VM SIZE DATE VM CLOCK
|
|
|
|
|
-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
|
|
|
|
|
(qemu) loadvm snap0
|
|
|
|
|
(qemu) quit
|
|
|
|
|
|
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
|
|
|
Testing: -blockdev driver=file,filename=TEST_DIR/t.IMGFMT,node-name=file -blockdev driver=raw,file=file,node-name=raw -blockdev driver=IMGFMT,file=raw,node-name=fmt
|
|
|
|
|
QEMU X.Y.Z monitor - type 'help' for more information
|
|
|
|
|
(qemu) savevm snap0
|
|
|
|
|
(qemu) info snapshots
|
|
|
|
|
List of snapshots present on all disks:
|
|
|
|
|
ID TAG VM SIZE DATE VM CLOCK
|
|
|
|
|
-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
|
|
|
|
|
(qemu) loadvm snap0
|
|
|
|
|
(qemu) quit
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
=== -blockdev with a filter on top ===
|
|
|
|
|
|
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
|
|
|
Testing: -blockdev driver=file,filename=TEST_DIR/t.IMGFMT,node-name=file -blockdev driver=IMGFMT,file=file,node-name=fmt -blockdev driver=copy-on-read,file=fmt,node-name=filter
|
|
|
|
|
QEMU X.Y.Z monitor - type 'help' for more information
|
|
|
|
|
(qemu) savevm snap0
|
|
|
|
|
(qemu) info snapshots
|
|
|
|
|
List of snapshots present on all disks:
|
|
|
|
|
ID TAG VM SIZE DATE VM CLOCK
|
|
|
|
|
-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
|
|
|
|
|
(qemu) loadvm snap0
|
|
|
|
|
(qemu) quit
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
=== -blockdev with a backing file ===
|
|
|
|
|
|
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=134217728
|
iotests: Specify explicit backing format where sensible
There are many existing qcow2 images that specify a backing file but
no format. This has been the source of CVEs in the past, but has
become more prominent of a problem now that libvirt has switched to
-blockdev. With older -drive, at least the probing was always done by
qemu (so the only risk of a changed format between successive boots of
a guest was if qemu was upgraded and probed differently). But with
newer -blockdev, libvirt must specify a format; if libvirt guesses raw
where the image was formatted, this results in data corruption visible
to the guest; conversely, if libvirt guesses qcow2 where qemu was
using raw, this can result in potential security holes, so modern
libvirt instead refuses to use images without explicit backing format.
The change in libvirt to reject images without explicit backing format
has pointed out that a number of tools have been far too reliant on
probing in the past. It's time to set a better example in our own
iotests of properly setting this parameter.
iotest calls to create, rebase, and convert are all impacted to some
degree. It's a bit annoying that we are inconsistent on command line
- while all of those accept -o backing_file=...,backing_fmt=..., the
shortcuts are different: create and rebase have -b and -F, while
convert has -B but no -F. (amend has no shortcuts, but the previous
patch just deprecated the use of amend to change backing chains).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200706203954.341758-9-eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-07-06 23:39:52 +03:00
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
|
2019-09-17 13:43:42 +03:00
|
|
|
Testing: -blockdev driver=file,filename=TEST_DIR/t.IMGFMT.base,node-name=backing-file -blockdev driver=file,filename=TEST_DIR/t.IMGFMT,node-name=file -blockdev driver=IMGFMT,file=file,backing=backing-file,node-name=fmt
|
|
|
|
|
QEMU X.Y.Z monitor - type 'help' for more information
|
|
|
|
|
(qemu) savevm snap0
|
|
|
|
|
(qemu) info snapshots
|
|
|
|
|
List of snapshots present on all disks:
|
|
|
|
|
ID TAG VM SIZE DATE VM CLOCK
|
|
|
|
|
-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
|
|
|
|
|
(qemu) loadvm snap0
|
|
|
|
|
(qemu) quit
|
|
|
|
|
|
iotests: Specify explicit backing format where sensible
There are many existing qcow2 images that specify a backing file but
no format. This has been the source of CVEs in the past, but has
become more prominent of a problem now that libvirt has switched to
-blockdev. With older -drive, at least the probing was always done by
qemu (so the only risk of a changed format between successive boots of
a guest was if qemu was upgraded and probed differently). But with
newer -blockdev, libvirt must specify a format; if libvirt guesses raw
where the image was formatted, this results in data corruption visible
to the guest; conversely, if libvirt guesses qcow2 where qemu was
using raw, this can result in potential security holes, so modern
libvirt instead refuses to use images without explicit backing format.
The change in libvirt to reject images without explicit backing format
has pointed out that a number of tools have been far too reliant on
probing in the past. It's time to set a better example in our own
iotests of properly setting this parameter.
iotest calls to create, rebase, and convert are all impacted to some
degree. It's a bit annoying that we are inconsistent on command line
- while all of those accept -o backing_file=...,backing_fmt=..., the
shortcuts are different: create and rebase have -b and -F, while
convert has -B but no -F. (amend has no shortcuts, but the previous
patch just deprecated the use of amend to change backing chains).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200706203954.341758-9-eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-07-06 23:39:52 +03:00
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
|
2019-09-17 13:43:42 +03:00
|
|
|
Testing: -blockdev driver=file,filename=TEST_DIR/t.IMGFMT.base,node-name=backing-file -blockdev driver=IMGFMT,file=backing-file,node-name=backing-fmt -blockdev driver=file,filename=TEST_DIR/t.IMGFMT,node-name=file -blockdev driver=IMGFMT,file=file,backing=backing-fmt,node-name=fmt
|
|
|
|
|
QEMU X.Y.Z monitor - type 'help' for more information
|
|
|
|
|
(qemu) savevm snap0
|
|
|
|
|
(qemu) info snapshots
|
|
|
|
|
List of snapshots present on all disks:
|
|
|
|
|
ID TAG VM SIZE DATE VM CLOCK
|
|
|
|
|
-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
|
|
|
|
|
(qemu) loadvm snap0
|
|
|
|
|
(qemu) quit
|
|
|
|
|
|
|
|
|
|
Internal snapshots on overlay:
|
|
|
|
|
Snapshot list:
|
|
|
|
|
ID TAG VM SIZE DATE VM CLOCK
|
|
|
|
|
1 snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
|
|
|
|
|
Internal snapshots on backing file:
|
|
|
|
|
|
|
|
|
|
=== -blockdev with NBD server on the backing file ===
|
|
|
|
|
|
iotests: Specify explicit backing format where sensible
There are many existing qcow2 images that specify a backing file but
no format. This has been the source of CVEs in the past, but has
become more prominent of a problem now that libvirt has switched to
-blockdev. With older -drive, at least the probing was always done by
qemu (so the only risk of a changed format between successive boots of
a guest was if qemu was upgraded and probed differently). But with
newer -blockdev, libvirt must specify a format; if libvirt guesses raw
where the image was formatted, this results in data corruption visible
to the guest; conversely, if libvirt guesses qcow2 where qemu was
using raw, this can result in potential security holes, so modern
libvirt instead refuses to use images without explicit backing format.
The change in libvirt to reject images without explicit backing format
has pointed out that a number of tools have been far too reliant on
probing in the past. It's time to set a better example in our own
iotests of properly setting this parameter.
iotest calls to create, rebase, and convert are all impacted to some
degree. It's a bit annoying that we are inconsistent on command line
- while all of those accept -o backing_file=...,backing_fmt=..., the
shortcuts are different: create and rebase have -b and -F, while
convert has -B but no -F. (amend has no shortcuts, but the previous
patch just deprecated the use of amend to change backing chains).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200706203954.341758-9-eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-07-06 23:39:52 +03:00
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
|
2019-09-17 13:43:42 +03:00
|
|
|
Testing: -blockdev driver=file,filename=TEST_DIR/t.IMGFMT.base,node-name=backing-file -blockdev driver=IMGFMT,file=backing-file,node-name=backing-fmt -blockdev driver=file,filename=TEST_DIR/t.IMGFMT,node-name=file -blockdev driver=IMGFMT,file=file,backing=backing-fmt,node-name=fmt
|
|
|
|
|
QEMU X.Y.Z monitor - type 'help' for more information
|
2019-10-17 16:31:54 +03:00
|
|
|
(qemu) nbd_server_start unix:SOCK_DIR/nbd
|
2019-09-17 13:43:42 +03:00
|
|
|
(qemu) nbd_server_add -w backing-fmt
|
|
|
|
|
(qemu) savevm snap0
|
|
|
|
|
(qemu) info snapshots
|
|
|
|
|
List of snapshots present on all disks:
|
|
|
|
|
ID TAG VM SIZE DATE VM CLOCK
|
|
|
|
|
-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
|
|
|
|
|
(qemu) loadvm snap0
|
|
|
|
|
(qemu) quit
|
|
|
|
|
|
|
|
|
|
Internal snapshots on overlay:
|
|
|
|
|
Snapshot list:
|
|
|
|
|
ID TAG VM SIZE DATE VM CLOCK
|
|
|
|
|
1 snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
|
|
|
|
|
Internal snapshots on backing file:
|
|
|
|
|
Snapshot list:
|
|
|
|
|
ID TAG VM SIZE DATE VM CLOCK
|
|
|
|
|
1 snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
|
|
|
|
|
*** done
|