2019-03-07 17:58:38 +03:00
|
|
|
#!/usr/bin/env bash
|
2016-01-29 18:36:16 +03:00
|
|
|
#
|
|
|
|
# Test case for ejecting BDSs with block jobs still running on them
|
|
|
|
#
|
|
|
|
# Copyright (C) 2016 Red Hat, Inc.
|
|
|
|
#
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
|
|
# it under the terms of the GNU General Public License as published by
|
|
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
|
|
# (at your option) any later version.
|
|
|
|
#
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
# GNU General Public License for more details.
|
|
|
|
#
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
#
|
|
|
|
|
|
|
|
# creator
|
|
|
|
owner=mreitz@redhat.com
|
|
|
|
|
|
|
|
seq="$(basename $0)"
|
|
|
|
echo "QA output created by $seq"
|
|
|
|
|
|
|
|
status=1 # failure is the default!
|
|
|
|
|
|
|
|
_cleanup()
|
|
|
|
{
|
2017-04-18 22:42:41 +03:00
|
|
|
_cleanup_qemu
|
2016-01-29 18:36:16 +03:00
|
|
|
_cleanup_test_img
|
2019-11-07 19:37:01 +03:00
|
|
|
for img in "$TEST_DIR"/{b,m,o}.$IMGFMT; do
|
|
|
|
_rm_test_img "$img"
|
|
|
|
done
|
2016-01-29 18:36:16 +03:00
|
|
|
}
|
|
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
|
|
|
|
# get standard environment, filters and checks
|
|
|
|
. ./common.rc
|
|
|
|
. ./common.filter
|
|
|
|
. ./common.qemu
|
|
|
|
|
|
|
|
# Needs backing file and backing format support
|
|
|
|
_supported_fmt qcow2 qed
|
|
|
|
_supported_proto file
|
|
|
|
_supported_os Linux
|
|
|
|
|
|
|
|
|
|
|
|
test_blockjob()
|
|
|
|
{
|
|
|
|
_send_qemu_cmd $QEMU_HANDLE \
|
|
|
|
"{'execute': 'blockdev-add',
|
|
|
|
'arguments': {
|
2016-10-07 18:05:04 +03:00
|
|
|
'node-name': 'drv0',
|
|
|
|
'driver': '$IMGFMT',
|
|
|
|
'file': {
|
|
|
|
'driver': 'file',
|
|
|
|
'filename': '$TEST_IMG'
|
|
|
|
}}}" \
|
2016-01-29 18:36:16 +03:00
|
|
|
'return'
|
|
|
|
|
2019-08-09 21:52:53 +03:00
|
|
|
# If "$2" is an event, we may or may not see it before the
|
|
|
|
# {"return": {}}. Therefore, filter the {"return": {}} out both
|
|
|
|
# here and in the next command. (Naturally, if we do not see it
|
|
|
|
# here, we will see it before the next command can be executed,
|
|
|
|
# so it will appear in the next _send_qemu_cmd's output.)
|
2016-01-29 18:36:16 +03:00
|
|
|
_send_qemu_cmd $QEMU_HANDLE \
|
|
|
|
"$1" \
|
|
|
|
"$2" \
|
2020-07-09 14:02:05 +03:00
|
|
|
| _filter_img_create | _filter_qmp_empty_return
|
2016-01-29 18:36:16 +03:00
|
|
|
|
|
|
|
# We want this to return an error because the block job is still running
|
|
|
|
_send_qemu_cmd $QEMU_HANDLE \
|
2017-03-21 19:53:28 +03:00
|
|
|
"{'execute': 'blockdev-del',
|
2016-09-21 15:56:10 +03:00
|
|
|
'arguments': {'node-name': 'drv0'}}" \
|
2019-08-09 21:52:53 +03:00
|
|
|
'error' | _filter_generated_node_ids | _filter_qmp_empty_return
|
2016-01-29 18:36:16 +03:00
|
|
|
|
|
|
|
_send_qemu_cmd $QEMU_HANDLE \
|
|
|
|
"{'execute': 'block-job-cancel',
|
2016-09-21 15:56:10 +03:00
|
|
|
'arguments': {'device': 'job0'}}" \
|
2016-01-29 18:36:16 +03:00
|
|
|
"$3"
|
|
|
|
|
|
|
|
_send_qemu_cmd $QEMU_HANDLE \
|
2017-03-21 19:53:28 +03:00
|
|
|
"{'execute': 'blockdev-del',
|
2016-09-21 15:56:10 +03:00
|
|
|
'arguments': {'node-name': 'drv0'}}" \
|
2016-01-29 18:36:16 +03:00
|
|
|
'return'
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TEST_IMG="$TEST_DIR/b.$IMGFMT" _make_test_img 1M
|
iotests: Specify explicit backing format where sensible
There are many existing qcow2 images that specify a backing file but
no format. This has been the source of CVEs in the past, but has
become more prominent of a problem now that libvirt has switched to
-blockdev. With older -drive, at least the probing was always done by
qemu (so the only risk of a changed format between successive boots of
a guest was if qemu was upgraded and probed differently). But with
newer -blockdev, libvirt must specify a format; if libvirt guesses raw
where the image was formatted, this results in data corruption visible
to the guest; conversely, if libvirt guesses qcow2 where qemu was
using raw, this can result in potential security holes, so modern
libvirt instead refuses to use images without explicit backing format.
The change in libvirt to reject images without explicit backing format
has pointed out that a number of tools have been far too reliant on
probing in the past. It's time to set a better example in our own
iotests of properly setting this parameter.
iotest calls to create, rebase, and convert are all impacted to some
degree. It's a bit annoying that we are inconsistent on command line
- while all of those accept -o backing_file=...,backing_fmt=..., the
shortcuts are different: create and rebase have -b and -F, while
convert has -B but no -F. (amend has no shortcuts, but the previous
patch just deprecated the use of amend to change backing chains).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200706203954.341758-9-eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-07-06 23:39:52 +03:00
|
|
|
TEST_IMG="$TEST_DIR/m.$IMGFMT" _make_test_img -b "$TEST_DIR/b.$IMGFMT" -F $IMGFMT 1M
|
|
|
|
_make_test_img -b "$TEST_DIR/m.$IMGFMT" 1M -F $IMGFMT
|
2016-01-29 18:36:16 +03:00
|
|
|
|
|
|
|
_launch_qemu -nodefaults
|
|
|
|
|
|
|
|
_send_qemu_cmd $QEMU_HANDLE \
|
|
|
|
"{'execute': 'qmp_capabilities'}" \
|
|
|
|
'return'
|
|
|
|
|
|
|
|
echo
|
|
|
|
echo '=== Testing drive-backup ==='
|
|
|
|
echo
|
|
|
|
|
|
|
|
# drive-backup will not send BLOCK_JOB_READY by itself, and cancelling the job
|
|
|
|
# will consequently result in BLOCK_JOB_CANCELLED being emitted.
|
|
|
|
|
|
|
|
test_blockjob \
|
|
|
|
"{'execute': 'drive-backup',
|
2016-09-21 15:56:10 +03:00
|
|
|
'arguments': {'job-id': 'job0',
|
|
|
|
'device': 'drv0',
|
2016-01-29 18:36:16 +03:00
|
|
|
'target': '$TEST_DIR/o.$IMGFMT',
|
|
|
|
'format': '$IMGFMT',
|
|
|
|
'sync': 'none'}}" \
|
|
|
|
'return' \
|
2018-04-30 20:09:46 +03:00
|
|
|
'"status": "null"'
|
2016-01-29 18:36:16 +03:00
|
|
|
|
|
|
|
echo
|
|
|
|
echo '=== Testing drive-mirror ==='
|
|
|
|
echo
|
|
|
|
|
|
|
|
# drive-mirror will send BLOCK_JOB_READY basically immediately, and cancelling
|
|
|
|
# the job will consequently result in BLOCK_JOB_COMPLETED being emitted.
|
|
|
|
|
|
|
|
test_blockjob \
|
|
|
|
"{'execute': 'drive-mirror',
|
2016-09-21 15:56:10 +03:00
|
|
|
'arguments': {'job-id': 'job0',
|
|
|
|
'device': 'drv0',
|
2016-01-29 18:36:16 +03:00
|
|
|
'target': '$TEST_DIR/o.$IMGFMT',
|
|
|
|
'format': '$IMGFMT',
|
|
|
|
'sync': 'none'}}" \
|
|
|
|
'BLOCK_JOB_READY' \
|
2018-04-30 20:09:46 +03:00
|
|
|
'"status": "null"'
|
2016-01-29 18:36:16 +03:00
|
|
|
|
|
|
|
echo
|
|
|
|
echo '=== Testing active block-commit ==='
|
|
|
|
echo
|
|
|
|
|
|
|
|
# An active block-commit will send BLOCK_JOB_READY basically immediately, and
|
|
|
|
# cancelling the job will consequently result in BLOCK_JOB_COMPLETED being
|
|
|
|
# emitted.
|
|
|
|
|
|
|
|
test_blockjob \
|
|
|
|
"{'execute': 'block-commit',
|
2016-09-21 15:56:10 +03:00
|
|
|
'arguments': {'job-id': 'job0', 'device': 'drv0'}}" \
|
2016-01-29 18:36:16 +03:00
|
|
|
'BLOCK_JOB_READY' \
|
2018-04-30 20:09:46 +03:00
|
|
|
'"status": "null"'
|
2016-01-29 18:36:16 +03:00
|
|
|
|
|
|
|
echo
|
|
|
|
echo '=== Testing non-active block-commit ==='
|
|
|
|
echo
|
|
|
|
|
|
|
|
# Give block-commit something to work on, otherwise it would be done
|
|
|
|
# immediately, send a BLOCK_JOB_COMPLETED and ejecting the BDS would work just
|
|
|
|
# fine without the block job still running.
|
|
|
|
|
|
|
|
$QEMU_IO -c 'write 0 1M' "$TEST_DIR/m.$IMGFMT" | _filter_qemu_io
|
|
|
|
|
|
|
|
test_blockjob \
|
|
|
|
"{'execute': 'block-commit',
|
2016-09-21 15:56:10 +03:00
|
|
|
'arguments': {'job-id': 'job0',
|
|
|
|
'device': 'drv0',
|
2016-01-29 18:36:16 +03:00
|
|
|
'top': '$TEST_DIR/m.$IMGFMT',
|
|
|
|
'speed': 1}}" \
|
|
|
|
'return' \
|
2018-04-30 20:09:46 +03:00
|
|
|
'"status": "null"'
|
2016-01-29 18:36:16 +03:00
|
|
|
|
|
|
|
echo
|
|
|
|
echo '=== Testing block-stream ==='
|
|
|
|
echo
|
|
|
|
|
|
|
|
# Give block-stream something to work on, otherwise it would be done
|
|
|
|
# immediately, send a BLOCK_JOB_COMPLETED and ejecting the BDS would work just
|
|
|
|
# fine without the block job still running.
|
|
|
|
|
|
|
|
$QEMU_IO -c 'write 0 1M' "$TEST_DIR/b.$IMGFMT" | _filter_qemu_io
|
|
|
|
|
|
|
|
# With some data to stream (and @speed set to 1), block-stream will not complete
|
2018-04-30 20:09:46 +03:00
|
|
|
# until we send the block-job-cancel command.
|
2016-01-29 18:36:16 +03:00
|
|
|
|
|
|
|
test_blockjob \
|
|
|
|
"{'execute': 'block-stream',
|
2016-09-21 15:56:10 +03:00
|
|
|
'arguments': {'job-id': 'job0',
|
|
|
|
'device': 'drv0',
|
2016-01-29 18:36:16 +03:00
|
|
|
'speed': 1}}" \
|
|
|
|
'return' \
|
2018-04-30 20:09:46 +03:00
|
|
|
'"status": "null"'
|
2016-01-29 18:36:16 +03:00
|
|
|
|
|
|
|
_cleanup_qemu
|
|
|
|
|
|
|
|
# success, all done
|
|
|
|
echo "*** done"
|
|
|
|
rm -f $seq.full
|
|
|
|
status=0
|