qemu/stubs/fdset.c

#include "qemu/osdep.h"
#include "monitor/monitor.h"

int monitor_fdset_dup_fd_add(int64_t fdset_id, int flags)
{
    errno = ENOSYS;
    return -1;
}

int64_t monitor_fdset_dup_fd_find(int dup_fd)
{
    return -1;
}

void monitor_fdset_dup_fd_remove(int dupfd)
{
}
stubs: group all monitor_fdset_* functions in a single file It makes little sense to implement only one of them, so avoid proliferation of stubs files. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> 2016-10-24 11:52:35 +03:00			`#include "qemu/osdep.h"`
			`#include "monitor/monitor.h"`

monitor: simplify functions for getting a dup'd fdset entry Currently code has to call monitor_fdset_get_fd, then dup the return fd, and then add the duplicate FD back into the fdset. This dance is overly verbose for the caller and introduces extra failure modes which can be avoided by folding all the logic into monitor_fdset_dup_fd_add and removing monitor_fdset_get_fd entirely. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> 2020-08-27 15:27:00 +03:00			`int monitor_fdset_dup_fd_add(int64_t fdset_id, int flags)`
stubs: group all monitor_fdset_* functions in a single file It makes little sense to implement only one of them, so avoid proliferation of stubs files. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> 2016-10-24 11:52:35 +03:00			`{`
monitor: simplify functions for getting a dup'd fdset entry Currently code has to call monitor_fdset_get_fd, then dup the return fd, and then add the duplicate FD back into the fdset. This dance is overly verbose for the caller and introduces extra failure modes which can be avoided by folding all the logic into monitor_fdset_dup_fd_add and removing monitor_fdset_get_fd entirely. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> 2020-08-27 15:27:00 +03:00			`errno = ENOSYS;`
stubs: group all monitor_fdset_* functions in a single file It makes little sense to implement only one of them, so avoid proliferation of stubs files. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> 2016-10-24 11:52:35 +03:00			`return -1;`
			`}`

monitor: Fix return type of monitor_fdset_dup_fd_find monitor_fdset_dup_fd_find_remove() and monitor_fdset_dup_fd_find() return mon_fdset->id which is int64_t. Downcasting from int64_t to int leads to a bug with removing fd from fdset with id >= 2^32. So, fix return types for these function. Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru> Reviewed-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20190523094433.30297-1-yury-kotov@yandex-team.ru> Signed-off-by: Markus Armbruster <armbru@redhat.com> 2019-05-23 12:44:33 +03:00			`int64_t monitor_fdset_dup_fd_find(int dup_fd)`
stubs: group all monitor_fdset_* functions in a single file It makes little sense to implement only one of them, so avoid proliferation of stubs files. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> 2016-10-24 11:52:35 +03:00			`{`
			`return -1;`
			`}`

			`void monitor_fdset_dup_fd_remove(int dupfd)`
			`{`
			`}`