2020-10-26 12:36:14 +03:00
|
|
|
/*
|
|
|
|
* Migration support for VFIO devices
|
|
|
|
*
|
|
|
|
* Copyright NVIDIA, Inc. 2020
|
|
|
|
*
|
|
|
|
* This work is licensed under the terms of the GNU GPL, version 2. See
|
|
|
|
* the COPYING file in the top-level directory.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "qemu/osdep.h"
|
2020-10-26 12:36:17 +03:00
|
|
|
#include "qemu/main-loop.h"
|
|
|
|
#include "qemu/cutils.h"
|
2023-02-16 17:36:27 +03:00
|
|
|
#include "qemu/units.h"
|
2023-03-15 20:43:13 +03:00
|
|
|
#include "qemu/error-report.h"
|
2020-10-26 12:36:14 +03:00
|
|
|
#include <linux/vfio.h>
|
2020-10-26 12:36:22 +03:00
|
|
|
#include <sys/ioctl.h>
|
2020-10-26 12:36:14 +03:00
|
|
|
|
2020-10-26 12:36:15 +03:00
|
|
|
#include "sysemu/runstate.h"
|
2020-10-26 12:36:14 +03:00
|
|
|
#include "hw/vfio/vfio-common.h"
|
2024-03-11 20:48:55 +03:00
|
|
|
#include "migration/misc.h"
|
2023-06-21 14:12:01 +03:00
|
|
|
#include "migration/savevm.h"
|
2020-10-26 12:36:17 +03:00
|
|
|
#include "migration/vmstate.h"
|
2020-10-26 12:36:14 +03:00
|
|
|
#include "migration/qemu-file.h"
|
|
|
|
#include "migration/register.h"
|
|
|
|
#include "migration/blocker.h"
|
|
|
|
#include "qapi/error.h"
|
2024-05-15 16:21:36 +03:00
|
|
|
#include "qapi/qapi-events-vfio.h"
|
2020-10-26 12:36:14 +03:00
|
|
|
#include "exec/ramlist.h"
|
|
|
|
#include "exec/ram_addr.h"
|
|
|
|
#include "pci.h"
|
|
|
|
#include "trace.h"
|
2020-10-26 12:36:15 +03:00
|
|
|
#include "hw/hw.h"
|
|
|
|
|
2020-10-26 12:36:17 +03:00
|
|
|
/*
|
|
|
|
* Flags to be used as unique delimiters for VFIO devices in the migration
|
|
|
|
* stream. These flags are composed as:
|
|
|
|
* 0xffffffff => MSB 32-bit all 1s
|
|
|
|
* 0xef10 => Magic ID, represents emulated (virtual) function IO
|
|
|
|
* 0x0000 => 16-bits reserved for flags
|
|
|
|
*
|
|
|
|
* The beginning of state information is marked by _DEV_CONFIG_STATE,
|
|
|
|
* _DEV_SETUP_STATE, or _DEV_DATA_STATE, respectively. The end of a
|
|
|
|
* certain state information is marked by _END_OF_STATE.
|
|
|
|
*/
|
|
|
|
#define VFIO_MIG_FLAG_END_OF_STATE (0xffffffffef100001ULL)
|
|
|
|
#define VFIO_MIG_FLAG_DEV_CONFIG_STATE (0xffffffffef100002ULL)
|
|
|
|
#define VFIO_MIG_FLAG_DEV_SETUP_STATE (0xffffffffef100003ULL)
|
|
|
|
#define VFIO_MIG_FLAG_DEV_DATA_STATE (0xffffffffef100004ULL)
|
2023-06-21 14:12:01 +03:00
|
|
|
#define VFIO_MIG_FLAG_DEV_INIT_DATA_SENT (0xffffffffef100005ULL)
|
2020-10-26 12:36:17 +03:00
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
/*
|
|
|
|
* This is an arbitrary size based on migration of mlx5 devices, where typically
|
|
|
|
* total device migration size is on the order of 100s of MB. Testing with
|
|
|
|
* larger values, e.g. 128MB and 1GB, did not show a performance improvement.
|
|
|
|
*/
|
|
|
|
#define VFIO_MIG_DEFAULT_DATA_BUFFER_SIZE (1 * MiB)
|
|
|
|
|
2020-10-26 12:36:27 +03:00
|
|
|
static int64_t bytes_transferred;
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
static const char *mig_state_to_str(enum vfio_device_mig_state state)
|
|
|
|
{
|
|
|
|
switch (state) {
|
|
|
|
case VFIO_DEVICE_STATE_ERROR:
|
|
|
|
return "ERROR";
|
|
|
|
case VFIO_DEVICE_STATE_STOP:
|
|
|
|
return "STOP";
|
|
|
|
case VFIO_DEVICE_STATE_RUNNING:
|
|
|
|
return "RUNNING";
|
|
|
|
case VFIO_DEVICE_STATE_STOP_COPY:
|
|
|
|
return "STOP_COPY";
|
|
|
|
case VFIO_DEVICE_STATE_RESUMING:
|
|
|
|
return "RESUMING";
|
2023-08-02 11:14:48 +03:00
|
|
|
case VFIO_DEVICE_STATE_RUNNING_P2P:
|
|
|
|
return "RUNNING_P2P";
|
2023-06-21 14:12:00 +03:00
|
|
|
case VFIO_DEVICE_STATE_PRE_COPY:
|
|
|
|
return "PRE_COPY";
|
2023-08-02 11:14:48 +03:00
|
|
|
case VFIO_DEVICE_STATE_PRE_COPY_P2P:
|
|
|
|
return "PRE_COPY_P2P";
|
2023-02-16 17:36:27 +03:00
|
|
|
default:
|
|
|
|
return "UNKNOWN STATE";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-05-15 16:21:36 +03:00
|
|
|
static VfioMigrationState
|
|
|
|
mig_state_to_qapi_state(enum vfio_device_mig_state state)
|
|
|
|
{
|
|
|
|
switch (state) {
|
|
|
|
case VFIO_DEVICE_STATE_STOP:
|
|
|
|
return QAPI_VFIO_MIGRATION_STATE_STOP;
|
|
|
|
case VFIO_DEVICE_STATE_RUNNING:
|
|
|
|
return QAPI_VFIO_MIGRATION_STATE_RUNNING;
|
|
|
|
case VFIO_DEVICE_STATE_STOP_COPY:
|
|
|
|
return QAPI_VFIO_MIGRATION_STATE_STOP_COPY;
|
|
|
|
case VFIO_DEVICE_STATE_RESUMING:
|
|
|
|
return QAPI_VFIO_MIGRATION_STATE_RESUMING;
|
|
|
|
case VFIO_DEVICE_STATE_RUNNING_P2P:
|
|
|
|
return QAPI_VFIO_MIGRATION_STATE_RUNNING_P2P;
|
|
|
|
case VFIO_DEVICE_STATE_PRE_COPY:
|
|
|
|
return QAPI_VFIO_MIGRATION_STATE_PRE_COPY;
|
|
|
|
case VFIO_DEVICE_STATE_PRE_COPY_P2P:
|
|
|
|
return QAPI_VFIO_MIGRATION_STATE_PRE_COPY_P2P;
|
|
|
|
default:
|
|
|
|
g_assert_not_reached();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void vfio_migration_send_event(VFIODevice *vbasedev)
|
|
|
|
{
|
|
|
|
VFIOMigration *migration = vbasedev->migration;
|
|
|
|
DeviceState *dev = vbasedev->dev;
|
|
|
|
g_autofree char *qom_path = NULL;
|
|
|
|
Object *obj;
|
|
|
|
|
|
|
|
if (!vbasedev->migration_events) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
g_assert(vbasedev->ops->vfio_get_object);
|
|
|
|
obj = vbasedev->ops->vfio_get_object(vbasedev);
|
|
|
|
g_assert(obj);
|
|
|
|
qom_path = object_get_canonical_path(obj);
|
|
|
|
|
|
|
|
qapi_event_send_vfio_migration(
|
|
|
|
dev->id, qom_path, mig_state_to_qapi_state(migration->device_state));
|
|
|
|
}
|
|
|
|
|
|
|
|
static void vfio_migration_set_device_state(VFIODevice *vbasedev,
|
|
|
|
enum vfio_device_mig_state state)
|
|
|
|
{
|
|
|
|
VFIOMigration *migration = vbasedev->migration;
|
|
|
|
|
2024-05-15 16:21:38 +03:00
|
|
|
trace_vfio_migration_set_device_state(vbasedev->name,
|
|
|
|
mig_state_to_str(state));
|
|
|
|
|
2024-05-15 16:21:36 +03:00
|
|
|
migration->device_state = state;
|
|
|
|
vfio_migration_send_event(vbasedev);
|
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
static int vfio_migration_set_state(VFIODevice *vbasedev,
|
|
|
|
enum vfio_device_mig_state new_state,
|
2024-05-16 15:46:53 +03:00
|
|
|
enum vfio_device_mig_state recover_state,
|
|
|
|
Error **errp)
|
2023-02-16 17:36:27 +03:00
|
|
|
{
|
|
|
|
VFIOMigration *migration = vbasedev->migration;
|
|
|
|
uint64_t buf[DIV_ROUND_UP(sizeof(struct vfio_device_feature) +
|
|
|
|
sizeof(struct vfio_device_feature_mig_state),
|
|
|
|
sizeof(uint64_t))] = {};
|
|
|
|
struct vfio_device_feature *feature = (struct vfio_device_feature *)buf;
|
|
|
|
struct vfio_device_feature_mig_state *mig_state =
|
|
|
|
(struct vfio_device_feature_mig_state *)feature->data;
|
|
|
|
int ret;
|
2024-05-16 15:46:53 +03:00
|
|
|
g_autofree char *error_prefix =
|
|
|
|
g_strdup_printf("%s: Failed setting device state to %s.",
|
|
|
|
vbasedev->name, mig_state_to_str(new_state));
|
2023-02-16 17:36:27 +03:00
|
|
|
|
2024-05-15 16:21:38 +03:00
|
|
|
trace_vfio_migration_set_state(vbasedev->name, mig_state_to_str(new_state),
|
|
|
|
mig_state_to_str(recover_state));
|
|
|
|
|
2024-05-15 16:21:37 +03:00
|
|
|
if (new_state == migration->device_state) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
feature->argsz = sizeof(buf);
|
|
|
|
feature->flags =
|
|
|
|
VFIO_DEVICE_FEATURE_SET | VFIO_DEVICE_FEATURE_MIG_DEVICE_STATE;
|
|
|
|
mig_state->device_state = new_state;
|
|
|
|
if (ioctl(vbasedev->fd, VFIO_DEVICE_FEATURE, feature)) {
|
|
|
|
/* Try to set the device in some good state */
|
|
|
|
ret = -errno;
|
|
|
|
|
|
|
|
if (recover_state == VFIO_DEVICE_STATE_ERROR) {
|
2024-05-16 15:46:53 +03:00
|
|
|
error_setg_errno(errp, errno,
|
|
|
|
"%s Recover state is ERROR. Resetting device",
|
|
|
|
error_prefix);
|
2023-02-16 17:36:27 +03:00
|
|
|
|
|
|
|
goto reset_device;
|
|
|
|
}
|
|
|
|
|
2024-05-16 15:46:53 +03:00
|
|
|
error_setg_errno(errp, errno,
|
|
|
|
"%s Setting device in recover state %s",
|
|
|
|
error_prefix, mig_state_to_str(recover_state));
|
2023-02-16 17:36:27 +03:00
|
|
|
|
|
|
|
mig_state->device_state = recover_state;
|
|
|
|
if (ioctl(vbasedev->fd, VFIO_DEVICE_FEATURE, feature)) {
|
|
|
|
ret = -errno;
|
2024-05-16 15:46:53 +03:00
|
|
|
/*
|
|
|
|
* If setting the device in recover state fails, report
|
|
|
|
* the error here and propagate the first error.
|
|
|
|
*/
|
2023-02-16 17:36:27 +03:00
|
|
|
error_report(
|
|
|
|
"%s: Failed setting device in recover state, err: %s. Resetting device",
|
|
|
|
vbasedev->name, strerror(errno));
|
|
|
|
|
|
|
|
goto reset_device;
|
|
|
|
}
|
|
|
|
|
2024-05-15 16:21:36 +03:00
|
|
|
vfio_migration_set_device_state(vbasedev, recover_state);
|
2023-02-16 17:36:27 +03:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2024-05-15 16:21:36 +03:00
|
|
|
vfio_migration_set_device_state(vbasedev, new_state);
|
2023-02-16 17:36:27 +03:00
|
|
|
if (mig_state->data_fd != -1) {
|
|
|
|
if (migration->data_fd != -1) {
|
|
|
|
/*
|
|
|
|
* This can happen if the device is asynchronously reset and
|
|
|
|
* terminates a data transfer.
|
|
|
|
*/
|
2024-05-16 15:46:53 +03:00
|
|
|
error_setg(errp, "%s: data_fd out of sync", vbasedev->name);
|
2023-02-16 17:36:27 +03:00
|
|
|
close(mig_state->data_fd);
|
|
|
|
|
|
|
|
return -EBADF;
|
|
|
|
}
|
|
|
|
|
|
|
|
migration->data_fd = mig_state->data_fd;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
reset_device:
|
|
|
|
if (ioctl(vbasedev->fd, VFIO_DEVICE_RESET)) {
|
|
|
|
hw_error("%s: Failed resetting device, err: %s", vbasedev->name,
|
|
|
|
strerror(errno));
|
|
|
|
}
|
|
|
|
|
2024-05-15 16:21:36 +03:00
|
|
|
vfio_migration_set_device_state(vbasedev, VFIO_DEVICE_STATE_RUNNING);
|
2023-02-16 17:36:27 +03:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2023-12-31 13:48:18 +03:00
|
|
|
/*
|
|
|
|
* Some device state transitions require resetting the device if they fail.
|
|
|
|
* This function sets the device in new_state and resets the device if that
|
|
|
|
* fails. Reset is done by using ERROR as the recover state.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
vfio_migration_set_state_or_reset(VFIODevice *vbasedev,
|
2024-05-16 15:46:53 +03:00
|
|
|
enum vfio_device_mig_state new_state,
|
|
|
|
Error **errp)
|
2023-12-31 13:48:18 +03:00
|
|
|
{
|
|
|
|
return vfio_migration_set_state(vbasedev, new_state,
|
2024-05-16 15:46:53 +03:00
|
|
|
VFIO_DEVICE_STATE_ERROR, errp);
|
2023-12-31 13:48:18 +03:00
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
static int vfio_load_buffer(QEMUFile *f, VFIODevice *vbasedev,
|
|
|
|
uint64_t data_size)
|
|
|
|
{
|
|
|
|
VFIOMigration *migration = vbasedev->migration;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = qemu_file_get_to_fd(f, migration->data_fd, data_size);
|
|
|
|
trace_vfio_load_state_device_data(vbasedev->name, data_size, ret);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2024-05-16 15:46:54 +03:00
|
|
|
static int vfio_save_device_config_state(QEMUFile *f, void *opaque,
|
|
|
|
Error **errp)
|
2020-10-26 12:36:18 +03:00
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
2024-05-16 15:46:54 +03:00
|
|
|
int ret;
|
2020-10-26 12:36:18 +03:00
|
|
|
|
|
|
|
qemu_put_be64(f, VFIO_MIG_FLAG_DEV_CONFIG_STATE);
|
|
|
|
|
|
|
|
if (vbasedev->ops && vbasedev->ops->vfio_save_config) {
|
2024-05-16 15:46:54 +03:00
|
|
|
ret = vbasedev->ops->vfio_save_config(vbasedev, f, errp);
|
|
|
|
if (ret) {
|
|
|
|
return ret;
|
|
|
|
}
|
2020-10-26 12:36:18 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
qemu_put_be64(f, VFIO_MIG_FLAG_END_OF_STATE);
|
|
|
|
|
|
|
|
trace_vfio_save_device_config_state(vbasedev->name);
|
|
|
|
|
2024-05-16 15:46:54 +03:00
|
|
|
ret = qemu_file_get_error(f);
|
|
|
|
if (ret < 0) {
|
|
|
|
error_setg_errno(errp, -ret, "Failed to save state");
|
|
|
|
}
|
|
|
|
return ret;
|
2020-10-26 12:36:18 +03:00
|
|
|
}
|
|
|
|
|
2020-10-26 12:36:19 +03:00
|
|
|
static int vfio_load_device_config_state(QEMUFile *f, void *opaque)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
|
|
|
uint64_t data;
|
|
|
|
|
|
|
|
if (vbasedev->ops && vbasedev->ops->vfio_load_config) {
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = vbasedev->ops->vfio_load_config(vbasedev, f);
|
|
|
|
if (ret) {
|
|
|
|
error_report("%s: Failed to load device config space",
|
|
|
|
vbasedev->name);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
data = qemu_get_be64(f);
|
|
|
|
if (data != VFIO_MIG_FLAG_END_OF_STATE) {
|
|
|
|
error_report("%s: Failed loading device config space, "
|
|
|
|
"end flag incorrect 0x%"PRIx64, vbasedev->name, data);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
trace_vfio_load_device_config_state(vbasedev->name);
|
|
|
|
return qemu_file_get_error(f);
|
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
static void vfio_migration_cleanup(VFIODevice *vbasedev)
|
|
|
|
{
|
|
|
|
VFIOMigration *migration = vbasedev->migration;
|
|
|
|
|
|
|
|
close(migration->data_fd);
|
|
|
|
migration->data_fd = -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int vfio_query_stop_copy_size(VFIODevice *vbasedev,
|
|
|
|
uint64_t *stop_copy_size)
|
|
|
|
{
|
|
|
|
uint64_t buf[DIV_ROUND_UP(sizeof(struct vfio_device_feature) +
|
|
|
|
sizeof(struct vfio_device_feature_mig_data_size),
|
|
|
|
sizeof(uint64_t))] = {};
|
|
|
|
struct vfio_device_feature *feature = (struct vfio_device_feature *)buf;
|
|
|
|
struct vfio_device_feature_mig_data_size *mig_data_size =
|
|
|
|
(struct vfio_device_feature_mig_data_size *)feature->data;
|
|
|
|
|
|
|
|
feature->argsz = sizeof(buf);
|
|
|
|
feature->flags =
|
|
|
|
VFIO_DEVICE_FEATURE_GET | VFIO_DEVICE_FEATURE_MIG_DATA_SIZE;
|
|
|
|
|
|
|
|
if (ioctl(vbasedev->fd, VFIO_DEVICE_FEATURE, feature)) {
|
|
|
|
return -errno;
|
|
|
|
}
|
|
|
|
|
|
|
|
*stop_copy_size = mig_data_size->stop_copy_length;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2023-06-21 14:12:00 +03:00
|
|
|
static int vfio_query_precopy_size(VFIOMigration *migration)
|
|
|
|
{
|
|
|
|
struct vfio_precopy_info precopy = {
|
|
|
|
.argsz = sizeof(precopy),
|
|
|
|
};
|
|
|
|
|
|
|
|
migration->precopy_init_size = 0;
|
|
|
|
migration->precopy_dirty_size = 0;
|
|
|
|
|
|
|
|
if (ioctl(migration->data_fd, VFIO_MIG_GET_PRECOPY_INFO, &precopy)) {
|
|
|
|
return -errno;
|
|
|
|
}
|
|
|
|
|
|
|
|
migration->precopy_init_size = precopy.initial_bytes;
|
|
|
|
migration->precopy_dirty_size = precopy.dirty_bytes;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2023-06-21 14:11:58 +03:00
|
|
|
/* Returns the size of saved data on success and -errno on error */
|
|
|
|
static ssize_t vfio_save_block(QEMUFile *f, VFIOMigration *migration)
|
2023-02-16 17:36:27 +03:00
|
|
|
{
|
|
|
|
ssize_t data_size;
|
|
|
|
|
|
|
|
data_size = read(migration->data_fd, migration->data_buffer,
|
|
|
|
migration->data_buffer_size);
|
|
|
|
if (data_size < 0) {
|
2023-06-21 14:12:00 +03:00
|
|
|
/*
|
|
|
|
* Pre-copy emptied all the device state for now. For more information,
|
|
|
|
* please refer to the Linux kernel VFIO uAPI.
|
|
|
|
*/
|
|
|
|
if (errno == ENOMSG) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
return -errno;
|
|
|
|
}
|
|
|
|
if (data_size == 0) {
|
2023-06-21 14:11:58 +03:00
|
|
|
return 0;
|
2023-02-16 17:36:27 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
qemu_put_be64(f, VFIO_MIG_FLAG_DEV_DATA_STATE);
|
|
|
|
qemu_put_be64(f, data_size);
|
|
|
|
qemu_put_buffer(f, migration->data_buffer, data_size);
|
|
|
|
bytes_transferred += data_size;
|
|
|
|
|
|
|
|
trace_vfio_save_block(migration->vbasedev->name, data_size);
|
|
|
|
|
2023-06-21 14:11:58 +03:00
|
|
|
return qemu_file_get_error(f) ?: data_size;
|
2023-02-16 17:36:27 +03:00
|
|
|
}
|
|
|
|
|
2023-06-21 14:12:00 +03:00
|
|
|
static void vfio_update_estimated_pending_data(VFIOMigration *migration,
|
|
|
|
uint64_t data_size)
|
|
|
|
{
|
|
|
|
if (!data_size) {
|
|
|
|
/*
|
|
|
|
* Pre-copy emptied all the device state for now, update estimated sizes
|
|
|
|
* accordingly.
|
|
|
|
*/
|
|
|
|
migration->precopy_init_size = 0;
|
|
|
|
migration->precopy_dirty_size = 0;
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (migration->precopy_init_size) {
|
|
|
|
uint64_t init_size = MIN(migration->precopy_init_size, data_size);
|
|
|
|
|
|
|
|
migration->precopy_init_size -= init_size;
|
|
|
|
data_size -= init_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
migration->precopy_dirty_size -= MIN(migration->precopy_dirty_size,
|
|
|
|
data_size);
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool vfio_precopy_supported(VFIODevice *vbasedev)
|
|
|
|
{
|
|
|
|
VFIOMigration *migration = vbasedev->migration;
|
|
|
|
|
|
|
|
return migration->mig_flags & VFIO_MIGRATION_PRE_COPY;
|
|
|
|
}
|
|
|
|
|
2020-10-26 12:36:17 +03:00
|
|
|
/* ---------------------------------------------------------------------- */
|
|
|
|
|
2023-09-06 18:08:52 +03:00
|
|
|
static int vfio_save_prepare(void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
|
|
|
|
|
|
|
/*
|
2023-09-06 18:08:53 +03:00
|
|
|
* Snapshot doesn't use postcopy nor background snapshot, so allow snapshot
|
|
|
|
* even if they are on.
|
2023-09-06 18:08:52 +03:00
|
|
|
*/
|
|
|
|
if (runstate_check(RUN_STATE_SAVE_VM)) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (migrate_postcopy_ram()) {
|
|
|
|
error_setg(
|
|
|
|
errp, "%s: VFIO migration is not supported with postcopy migration",
|
|
|
|
vbasedev->name);
|
|
|
|
return -EOPNOTSUPP;
|
|
|
|
}
|
|
|
|
|
2023-09-06 18:08:53 +03:00
|
|
|
if (migrate_background_snapshot()) {
|
|
|
|
error_setg(
|
|
|
|
errp,
|
|
|
|
"%s: VFIO migration is not supported with background snapshot",
|
|
|
|
vbasedev->name);
|
|
|
|
return -EOPNOTSUPP;
|
|
|
|
}
|
|
|
|
|
2023-09-06 18:08:52 +03:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2024-03-20 09:49:03 +03:00
|
|
|
static int vfio_save_setup(QEMUFile *f, void *opaque, Error **errp)
|
2023-02-16 17:36:27 +03:00
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
|
|
|
VFIOMigration *migration = vbasedev->migration;
|
|
|
|
uint64_t stop_copy_size = VFIO_MIG_DEFAULT_DATA_BUFFER_SIZE;
|
2024-03-20 09:48:58 +03:00
|
|
|
int ret;
|
2023-02-16 17:36:27 +03:00
|
|
|
|
|
|
|
qemu_put_be64(f, VFIO_MIG_FLAG_DEV_SETUP_STATE);
|
|
|
|
|
|
|
|
vfio_query_stop_copy_size(vbasedev, &stop_copy_size);
|
|
|
|
migration->data_buffer_size = MIN(VFIO_MIG_DEFAULT_DATA_BUFFER_SIZE,
|
|
|
|
stop_copy_size);
|
|
|
|
migration->data_buffer = g_try_malloc0(migration->data_buffer_size);
|
|
|
|
if (!migration->data_buffer) {
|
2024-03-20 09:49:03 +03:00
|
|
|
error_setg(errp, "%s: Failed to allocate migration data buffer",
|
|
|
|
vbasedev->name);
|
2023-02-16 17:36:27 +03:00
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
2023-06-21 14:12:00 +03:00
|
|
|
if (vfio_precopy_supported(vbasedev)) {
|
|
|
|
switch (migration->device_state) {
|
|
|
|
case VFIO_DEVICE_STATE_RUNNING:
|
|
|
|
ret = vfio_migration_set_state(vbasedev, VFIO_DEVICE_STATE_PRE_COPY,
|
2024-05-16 15:46:53 +03:00
|
|
|
VFIO_DEVICE_STATE_RUNNING, errp);
|
2023-06-21 14:12:00 +03:00
|
|
|
if (ret) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
vfio_query_precopy_size(migration);
|
|
|
|
|
|
|
|
break;
|
|
|
|
case VFIO_DEVICE_STATE_STOP:
|
|
|
|
/* vfio_save_complete_precopy() will go to STOP_COPY */
|
|
|
|
break;
|
|
|
|
default:
|
2024-03-20 09:49:03 +03:00
|
|
|
error_setg(errp, "%s: Invalid device state %d", vbasedev->name,
|
|
|
|
migration->device_state);
|
2023-06-21 14:12:00 +03:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
trace_vfio_save_setup(vbasedev->name, migration->data_buffer_size);
|
|
|
|
|
|
|
|
qemu_put_be64(f, VFIO_MIG_FLAG_END_OF_STATE);
|
|
|
|
|
2024-03-20 09:48:58 +03:00
|
|
|
ret = qemu_file_get_error(f);
|
|
|
|
if (ret < 0) {
|
2024-03-20 09:49:03 +03:00
|
|
|
error_setg_errno(errp, -ret, "%s: save setup failed", vbasedev->name);
|
2024-03-20 09:48:58 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
2023-02-16 17:36:27 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static void vfio_save_cleanup(void *opaque)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
|
|
|
VFIOMigration *migration = vbasedev->migration;
|
2024-05-16 15:46:53 +03:00
|
|
|
Error *local_err = NULL;
|
|
|
|
int ret;
|
2023-02-16 17:36:27 +03:00
|
|
|
|
2023-08-02 11:14:44 +03:00
|
|
|
/*
|
|
|
|
* Changing device state from STOP_COPY to STOP can take time. Do it here,
|
|
|
|
* after migration has completed, so it won't increase downtime.
|
|
|
|
*/
|
|
|
|
if (migration->device_state == VFIO_DEVICE_STATE_STOP_COPY) {
|
2024-05-16 15:46:53 +03:00
|
|
|
ret = vfio_migration_set_state_or_reset(vbasedev,
|
|
|
|
VFIO_DEVICE_STATE_STOP,
|
|
|
|
&local_err);
|
|
|
|
if (ret) {
|
|
|
|
error_report_err(local_err);
|
|
|
|
}
|
2023-08-02 11:14:44 +03:00
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
g_free(migration->data_buffer);
|
|
|
|
migration->data_buffer = NULL;
|
2023-06-21 14:12:00 +03:00
|
|
|
migration->precopy_init_size = 0;
|
|
|
|
migration->precopy_dirty_size = 0;
|
2023-06-21 14:12:01 +03:00
|
|
|
migration->initial_data_sent = false;
|
2023-02-16 17:36:27 +03:00
|
|
|
vfio_migration_cleanup(vbasedev);
|
|
|
|
trace_vfio_save_cleanup(vbasedev->name);
|
|
|
|
}
|
|
|
|
|
2023-06-21 14:12:00 +03:00
|
|
|
static void vfio_state_pending_estimate(void *opaque, uint64_t *must_precopy,
|
|
|
|
uint64_t *can_postcopy)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
|
|
|
VFIOMigration *migration = vbasedev->migration;
|
|
|
|
|
2023-08-02 11:14:47 +03:00
|
|
|
if (!vfio_device_state_is_precopy(vbasedev)) {
|
2023-06-21 14:12:00 +03:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
*must_precopy +=
|
|
|
|
migration->precopy_init_size + migration->precopy_dirty_size;
|
|
|
|
|
|
|
|
trace_vfio_state_pending_estimate(vbasedev->name, *must_precopy,
|
|
|
|
*can_postcopy,
|
|
|
|
migration->precopy_init_size,
|
|
|
|
migration->precopy_dirty_size);
|
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
/*
|
|
|
|
* Migration size of VFIO devices can be as little as a few KBs or as big as
|
|
|
|
* many GBs. This value should be big enough to cover the worst case.
|
|
|
|
*/
|
|
|
|
#define VFIO_MIG_STOP_COPY_SIZE (100 * GiB)
|
|
|
|
|
|
|
|
static void vfio_state_pending_exact(void *opaque, uint64_t *must_precopy,
|
|
|
|
uint64_t *can_postcopy)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
2023-06-21 14:12:00 +03:00
|
|
|
VFIOMigration *migration = vbasedev->migration;
|
2023-02-16 17:36:27 +03:00
|
|
|
uint64_t stop_copy_size = VFIO_MIG_STOP_COPY_SIZE;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If getting pending migration size fails, VFIO_MIG_STOP_COPY_SIZE is
|
|
|
|
* reported so downtime limit won't be violated.
|
|
|
|
*/
|
|
|
|
vfio_query_stop_copy_size(vbasedev, &stop_copy_size);
|
|
|
|
*must_precopy += stop_copy_size;
|
|
|
|
|
2023-08-02 11:14:47 +03:00
|
|
|
if (vfio_device_state_is_precopy(vbasedev)) {
|
2023-06-21 14:12:00 +03:00
|
|
|
vfio_query_precopy_size(migration);
|
|
|
|
|
|
|
|
*must_precopy +=
|
|
|
|
migration->precopy_init_size + migration->precopy_dirty_size;
|
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
trace_vfio_state_pending_exact(vbasedev->name, *must_precopy, *can_postcopy,
|
2023-06-21 14:12:00 +03:00
|
|
|
stop_copy_size, migration->precopy_init_size,
|
|
|
|
migration->precopy_dirty_size);
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool vfio_is_active_iterate(void *opaque)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
|
|
|
|
2023-08-02 11:14:47 +03:00
|
|
|
return vfio_device_state_is_precopy(vbasedev);
|
2023-06-21 14:12:00 +03:00
|
|
|
}
|
|
|
|
|
2024-03-04 13:53:39 +03:00
|
|
|
/*
|
|
|
|
* Note about migration rate limiting: VFIO migration buffer size is currently
|
|
|
|
* limited to 1MB, so there is no need to check if migration rate exceeded (as
|
|
|
|
* in the worst case it will exceed by 1MB). However, if the buffer size is
|
|
|
|
* later changed to a bigger value, migration rate should be enforced here.
|
|
|
|
*/
|
2023-06-21 14:12:00 +03:00
|
|
|
static int vfio_save_iterate(QEMUFile *f, void *opaque)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
|
|
|
VFIOMigration *migration = vbasedev->migration;
|
|
|
|
ssize_t data_size;
|
|
|
|
|
|
|
|
data_size = vfio_save_block(f, migration);
|
|
|
|
if (data_size < 0) {
|
|
|
|
return data_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
vfio_update_estimated_pending_data(migration, data_size);
|
|
|
|
|
2023-06-21 14:12:01 +03:00
|
|
|
if (migrate_switchover_ack() && !migration->precopy_init_size &&
|
|
|
|
!migration->initial_data_sent) {
|
|
|
|
qemu_put_be64(f, VFIO_MIG_FLAG_DEV_INIT_DATA_SENT);
|
|
|
|
migration->initial_data_sent = true;
|
|
|
|
} else {
|
|
|
|
qemu_put_be64(f, VFIO_MIG_FLAG_END_OF_STATE);
|
|
|
|
}
|
|
|
|
|
2023-06-21 14:12:00 +03:00
|
|
|
trace_vfio_save_iterate(vbasedev->name, migration->precopy_init_size,
|
|
|
|
migration->precopy_dirty_size);
|
|
|
|
|
2024-03-04 13:53:38 +03:00
|
|
|
return !migration->precopy_init_size && !migration->precopy_dirty_size;
|
2023-02-16 17:36:27 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static int vfio_save_complete_precopy(QEMUFile *f, void *opaque)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
2023-06-21 14:11:58 +03:00
|
|
|
ssize_t data_size;
|
2023-02-16 17:36:27 +03:00
|
|
|
int ret;
|
2024-05-16 15:46:53 +03:00
|
|
|
Error *local_err = NULL;
|
2023-02-16 17:36:27 +03:00
|
|
|
|
2023-06-21 14:12:00 +03:00
|
|
|
/* We reach here with device state STOP or STOP_COPY only */
|
2023-02-16 17:36:27 +03:00
|
|
|
ret = vfio_migration_set_state(vbasedev, VFIO_DEVICE_STATE_STOP_COPY,
|
2024-05-16 15:46:53 +03:00
|
|
|
VFIO_DEVICE_STATE_STOP, &local_err);
|
2023-02-16 17:36:27 +03:00
|
|
|
if (ret) {
|
2024-05-16 15:46:53 +03:00
|
|
|
error_report_err(local_err);
|
2023-02-16 17:36:27 +03:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
do {
|
2023-06-21 14:11:58 +03:00
|
|
|
data_size = vfio_save_block(f, vbasedev->migration);
|
|
|
|
if (data_size < 0) {
|
|
|
|
return data_size;
|
2023-02-16 17:36:27 +03:00
|
|
|
}
|
2023-06-21 14:11:58 +03:00
|
|
|
} while (data_size);
|
2023-02-16 17:36:27 +03:00
|
|
|
|
|
|
|
qemu_put_be64(f, VFIO_MIG_FLAG_END_OF_STATE);
|
|
|
|
ret = qemu_file_get_error(f);
|
|
|
|
|
|
|
|
trace_vfio_save_complete_precopy(vbasedev->name, ret);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2021-03-10 06:02:31 +03:00
|
|
|
static void vfio_save_state(QEMUFile *f, void *opaque)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
2024-05-16 15:46:54 +03:00
|
|
|
Error *local_err = NULL;
|
2021-03-10 06:02:31 +03:00
|
|
|
int ret;
|
|
|
|
|
2024-05-16 15:46:54 +03:00
|
|
|
ret = vfio_save_device_config_state(f, opaque, &local_err);
|
2021-03-10 06:02:31 +03:00
|
|
|
if (ret) {
|
2024-05-16 15:46:54 +03:00
|
|
|
error_prepend(&local_err,
|
|
|
|
"vfio: Failed to save device config space of %s - ",
|
|
|
|
vbasedev->name);
|
|
|
|
qemu_file_set_error_obj(f, ret, local_err);
|
2021-03-10 06:02:31 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-03-20 09:49:04 +03:00
|
|
|
static int vfio_load_setup(QEMUFile *f, void *opaque, Error **errp)
|
2023-02-16 17:36:27 +03:00
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
|
|
|
|
2024-05-16 15:46:53 +03:00
|
|
|
return vfio_migration_set_state(vbasedev, VFIO_DEVICE_STATE_RESUMING,
|
|
|
|
vbasedev->migration->device_state, errp);
|
2023-02-16 17:36:27 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static int vfio_load_cleanup(void *opaque)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
|
|
|
|
|
|
|
vfio_migration_cleanup(vbasedev);
|
|
|
|
trace_vfio_load_cleanup(vbasedev->name);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-10-26 12:36:19 +03:00
|
|
|
static int vfio_load_state(QEMUFile *f, void *opaque, int version_id)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
|
|
|
int ret = 0;
|
|
|
|
uint64_t data;
|
|
|
|
|
|
|
|
data = qemu_get_be64(f);
|
|
|
|
while (data != VFIO_MIG_FLAG_END_OF_STATE) {
|
|
|
|
|
|
|
|
trace_vfio_load_state(vbasedev->name, data);
|
|
|
|
|
|
|
|
switch (data) {
|
|
|
|
case VFIO_MIG_FLAG_DEV_CONFIG_STATE:
|
|
|
|
{
|
2021-03-10 06:02:31 +03:00
|
|
|
return vfio_load_device_config_state(f, opaque);
|
2020-10-26 12:36:19 +03:00
|
|
|
}
|
|
|
|
case VFIO_MIG_FLAG_DEV_SETUP_STATE:
|
|
|
|
{
|
|
|
|
data = qemu_get_be64(f);
|
|
|
|
if (data == VFIO_MIG_FLAG_END_OF_STATE) {
|
|
|
|
return ret;
|
|
|
|
} else {
|
|
|
|
error_report("%s: SETUP STATE: EOS not found 0x%"PRIx64,
|
|
|
|
vbasedev->name, data);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case VFIO_MIG_FLAG_DEV_DATA_STATE:
|
|
|
|
{
|
|
|
|
uint64_t data_size = qemu_get_be64(f);
|
|
|
|
|
|
|
|
if (data_size) {
|
2023-02-16 17:36:28 +03:00
|
|
|
ret = vfio_load_buffer(f, vbasedev, data_size);
|
2020-10-26 12:36:19 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
2023-06-21 14:12:01 +03:00
|
|
|
case VFIO_MIG_FLAG_DEV_INIT_DATA_SENT:
|
|
|
|
{
|
|
|
|
if (!vfio_precopy_supported(vbasedev) ||
|
|
|
|
!migrate_switchover_ack()) {
|
|
|
|
error_report("%s: Received INIT_DATA_SENT but switchover ack "
|
|
|
|
"is not used", vbasedev->name);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = qemu_loadvm_approve_switchover();
|
|
|
|
if (ret) {
|
|
|
|
error_report(
|
|
|
|
"%s: qemu_loadvm_approve_switchover failed, err=%d (%s)",
|
|
|
|
vbasedev->name, ret, strerror(-ret));
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
2020-10-26 12:36:19 +03:00
|
|
|
default:
|
|
|
|
error_report("%s: Unknown tag 0x%"PRIx64, vbasedev->name, data);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
data = qemu_get_be64(f);
|
|
|
|
ret = qemu_file_get_error(f);
|
|
|
|
if (ret) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2023-06-21 14:12:01 +03:00
|
|
|
static bool vfio_switchover_ack_needed(void *opaque)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
|
|
|
|
|
|
|
return vfio_precopy_supported(vbasedev);
|
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
static const SaveVMHandlers savevm_vfio_handlers = {
|
2023-09-06 18:08:52 +03:00
|
|
|
.save_prepare = vfio_save_prepare,
|
2023-02-16 17:36:27 +03:00
|
|
|
.save_setup = vfio_save_setup,
|
|
|
|
.save_cleanup = vfio_save_cleanup,
|
2023-06-21 14:12:00 +03:00
|
|
|
.state_pending_estimate = vfio_state_pending_estimate,
|
2023-02-16 17:36:27 +03:00
|
|
|
.state_pending_exact = vfio_state_pending_exact,
|
2023-06-21 14:12:00 +03:00
|
|
|
.is_active_iterate = vfio_is_active_iterate,
|
|
|
|
.save_live_iterate = vfio_save_iterate,
|
2023-02-16 17:36:27 +03:00
|
|
|
.save_live_complete_precopy = vfio_save_complete_precopy,
|
|
|
|
.save_state = vfio_save_state,
|
|
|
|
.load_setup = vfio_load_setup,
|
|
|
|
.load_cleanup = vfio_load_cleanup,
|
|
|
|
.load_state = vfio_load_state,
|
2023-06-21 14:12:01 +03:00
|
|
|
.switchover_ack_needed = vfio_switchover_ack_needed,
|
2023-02-16 17:36:27 +03:00
|
|
|
};
|
|
|
|
|
2020-10-26 12:36:17 +03:00
|
|
|
/* ---------------------------------------------------------------------- */
|
|
|
|
|
2023-08-02 11:14:48 +03:00
|
|
|
static void vfio_vmstate_change_prepare(void *opaque, bool running,
|
|
|
|
RunState state)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
|
|
|
VFIOMigration *migration = vbasedev->migration;
|
|
|
|
enum vfio_device_mig_state new_state;
|
2024-05-16 15:46:53 +03:00
|
|
|
Error *local_err = NULL;
|
2023-08-02 11:14:48 +03:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
new_state = migration->device_state == VFIO_DEVICE_STATE_PRE_COPY ?
|
|
|
|
VFIO_DEVICE_STATE_PRE_COPY_P2P :
|
|
|
|
VFIO_DEVICE_STATE_RUNNING_P2P;
|
|
|
|
|
2024-05-16 15:46:53 +03:00
|
|
|
ret = vfio_migration_set_state_or_reset(vbasedev, new_state, &local_err);
|
2023-08-02 11:14:48 +03:00
|
|
|
if (ret) {
|
|
|
|
/*
|
|
|
|
* Migration should be aborted in this case, but vm_state_notify()
|
|
|
|
* currently does not support reporting failures.
|
|
|
|
*/
|
2024-05-16 15:46:53 +03:00
|
|
|
migration_file_set_error(ret, local_err);
|
2023-08-02 11:14:48 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
trace_vfio_vmstate_change_prepare(vbasedev->name, running,
|
|
|
|
RunState_str(state),
|
|
|
|
mig_state_to_str(new_state));
|
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
static void vfio_vmstate_change(void *opaque, bool running, RunState state)
|
|
|
|
{
|
|
|
|
VFIODevice *vbasedev = opaque;
|
|
|
|
enum vfio_device_mig_state new_state;
|
2024-05-16 15:46:53 +03:00
|
|
|
Error *local_err = NULL;
|
2023-02-16 17:36:27 +03:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (running) {
|
|
|
|
new_state = VFIO_DEVICE_STATE_RUNNING;
|
|
|
|
} else {
|
2023-06-21 14:12:00 +03:00
|
|
|
new_state =
|
2023-08-02 11:14:47 +03:00
|
|
|
(vfio_device_state_is_precopy(vbasedev) &&
|
2023-06-21 14:12:00 +03:00
|
|
|
(state == RUN_STATE_FINISH_MIGRATE || state == RUN_STATE_PAUSED)) ?
|
|
|
|
VFIO_DEVICE_STATE_STOP_COPY :
|
|
|
|
VFIO_DEVICE_STATE_STOP;
|
2023-02-16 17:36:27 +03:00
|
|
|
}
|
|
|
|
|
2024-05-16 15:46:53 +03:00
|
|
|
ret = vfio_migration_set_state_or_reset(vbasedev, new_state, &local_err);
|
2023-02-16 17:36:27 +03:00
|
|
|
if (ret) {
|
|
|
|
/*
|
|
|
|
* Migration should be aborted in this case, but vm_state_notify()
|
|
|
|
* currently does not support reporting failures.
|
|
|
|
*/
|
2024-05-16 15:46:53 +03:00
|
|
|
migration_file_set_error(ret, local_err);
|
2023-02-16 17:36:27 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
trace_vfio_vmstate_change(vbasedev->name, running, RunState_str(state),
|
|
|
|
mig_state_to_str(new_state));
|
|
|
|
}
|
|
|
|
|
2024-02-22 20:28:29 +03:00
|
|
|
static int vfio_migration_state_notifier(NotifierWithReturn *notifier,
|
2024-02-22 20:28:32 +03:00
|
|
|
MigrationEvent *e, Error **errp)
|
2020-10-26 12:36:16 +03:00
|
|
|
{
|
|
|
|
VFIOMigration *migration = container_of(notifier, VFIOMigration,
|
|
|
|
migration_state);
|
|
|
|
VFIODevice *vbasedev = migration->vbasedev;
|
2024-05-16 15:46:53 +03:00
|
|
|
Error *local_err = NULL;
|
|
|
|
int ret;
|
2020-10-26 12:36:16 +03:00
|
|
|
|
2024-02-22 20:28:30 +03:00
|
|
|
trace_vfio_migration_state_notifier(vbasedev->name, e->type);
|
2020-10-26 12:36:16 +03:00
|
|
|
|
2024-02-22 20:28:30 +03:00
|
|
|
if (e->type == MIG_EVENT_PRECOPY_FAILED) {
|
2024-05-16 15:46:53 +03:00
|
|
|
/*
|
|
|
|
* MigrationNotifyFunc may not return an error code and an Error
|
|
|
|
* object for MIG_EVENT_PRECOPY_FAILED. Hence, report the error
|
|
|
|
* locally and ignore the errp argument.
|
|
|
|
*/
|
|
|
|
ret = vfio_migration_set_state_or_reset(vbasedev,
|
|
|
|
VFIO_DEVICE_STATE_RUNNING,
|
|
|
|
&local_err);
|
|
|
|
if (ret) {
|
|
|
|
error_report_err(local_err);
|
|
|
|
}
|
2020-10-26 12:36:16 +03:00
|
|
|
}
|
2024-02-22 20:28:29 +03:00
|
|
|
return 0;
|
2020-10-26 12:36:16 +03:00
|
|
|
}
|
|
|
|
|
2023-03-07 19:53:46 +03:00
|
|
|
static void vfio_migration_free(VFIODevice *vbasedev)
|
2020-10-26 12:36:14 +03:00
|
|
|
{
|
|
|
|
g_free(vbasedev->migration);
|
|
|
|
vbasedev->migration = NULL;
|
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
static int vfio_migration_query_flags(VFIODevice *vbasedev, uint64_t *mig_flags)
|
|
|
|
{
|
|
|
|
uint64_t buf[DIV_ROUND_UP(sizeof(struct vfio_device_feature) +
|
|
|
|
sizeof(struct vfio_device_feature_migration),
|
|
|
|
sizeof(uint64_t))] = {};
|
|
|
|
struct vfio_device_feature *feature = (struct vfio_device_feature *)buf;
|
|
|
|
struct vfio_device_feature_migration *mig =
|
|
|
|
(struct vfio_device_feature_migration *)feature->data;
|
|
|
|
|
|
|
|
feature->argsz = sizeof(buf);
|
|
|
|
feature->flags = VFIO_DEVICE_FEATURE_GET | VFIO_DEVICE_FEATURE_MIGRATION;
|
|
|
|
if (ioctl(vbasedev->fd, VFIO_DEVICE_FEATURE, feature)) {
|
|
|
|
return -errno;
|
|
|
|
}
|
|
|
|
|
|
|
|
*mig_flags = mig->flags;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2023-03-07 15:54:49 +03:00
|
|
|
static bool vfio_dma_logging_supported(VFIODevice *vbasedev)
|
|
|
|
{
|
|
|
|
uint64_t buf[DIV_ROUND_UP(sizeof(struct vfio_device_feature),
|
|
|
|
sizeof(uint64_t))] = {};
|
|
|
|
struct vfio_device_feature *feature = (struct vfio_device_feature *)buf;
|
|
|
|
|
|
|
|
feature->argsz = sizeof(buf);
|
|
|
|
feature->flags = VFIO_DEVICE_FEATURE_PROBE |
|
|
|
|
VFIO_DEVICE_FEATURE_DMA_LOGGING_START;
|
|
|
|
|
|
|
|
return !ioctl(vbasedev->fd, VFIO_DEVICE_FEATURE, feature);
|
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:25 +03:00
|
|
|
static int vfio_migration_init(VFIODevice *vbasedev)
|
2020-10-26 12:36:14 +03:00
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
Object *obj;
|
2020-10-26 12:36:15 +03:00
|
|
|
VFIOMigration *migration;
|
2020-10-26 12:36:17 +03:00
|
|
|
char id[256] = "";
|
|
|
|
g_autofree char *path = NULL, *oid = NULL;
|
2023-02-16 17:36:27 +03:00
|
|
|
uint64_t mig_flags = 0;
|
2023-08-02 11:14:48 +03:00
|
|
|
VMChangeStateHandler *prepare_cb;
|
2020-10-26 12:36:14 +03:00
|
|
|
|
|
|
|
if (!vbasedev->ops->vfio_get_object) {
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
obj = vbasedev->ops->vfio_get_object(vbasedev);
|
|
|
|
if (!obj) {
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2023-02-16 17:36:27 +03:00
|
|
|
ret = vfio_migration_query_flags(vbasedev, &mig_flags);
|
2023-02-16 17:36:28 +03:00
|
|
|
if (ret) {
|
2023-02-16 17:36:27 +03:00
|
|
|
return ret;
|
|
|
|
}
|
2023-02-16 17:36:25 +03:00
|
|
|
|
2023-02-16 17:36:28 +03:00
|
|
|
/* Basic migration functionality must be supported */
|
|
|
|
if (!(mig_flags & VFIO_MIGRATION_STOP_COPY)) {
|
|
|
|
return -EOPNOTSUPP;
|
|
|
|
}
|
|
|
|
|
|
|
|
vbasedev->migration = g_new0(VFIOMigration, 1);
|
2020-10-26 12:36:15 +03:00
|
|
|
migration = vbasedev->migration;
|
2020-10-26 12:36:16 +03:00
|
|
|
migration->vbasedev = vbasedev;
|
2023-02-16 17:36:28 +03:00
|
|
|
migration->device_state = VFIO_DEVICE_STATE_RUNNING;
|
|
|
|
migration->data_fd = -1;
|
2023-06-21 14:11:59 +03:00
|
|
|
migration->mig_flags = mig_flags;
|
2020-10-26 12:36:17 +03:00
|
|
|
|
2023-03-07 15:54:49 +03:00
|
|
|
vbasedev->dirty_pages_supported = vfio_dma_logging_supported(vbasedev);
|
|
|
|
|
2020-10-26 12:36:17 +03:00
|
|
|
oid = vmstate_if_get_id(VMSTATE_IF(DEVICE(obj)));
|
|
|
|
if (oid) {
|
|
|
|
path = g_strdup_printf("%s/vfio", oid);
|
|
|
|
} else {
|
|
|
|
path = g_strdup("vfio");
|
|
|
|
}
|
|
|
|
strpadcpy(id, sizeof(id), path, '\0');
|
|
|
|
|
2023-02-16 17:36:28 +03:00
|
|
|
register_savevm_live(id, VMSTATE_INSTANCE_ID_ANY, 1, &savevm_vfio_handlers,
|
|
|
|
vbasedev);
|
2020-10-26 12:36:17 +03:00
|
|
|
|
2023-08-02 11:14:48 +03:00
|
|
|
prepare_cb = migration->mig_flags & VFIO_MIGRATION_P2P ?
|
|
|
|
vfio_vmstate_change_prepare :
|
|
|
|
NULL;
|
|
|
|
migration->vm_state = qdev_add_vm_change_state_handler_full(
|
|
|
|
vbasedev->dev, vfio_vmstate_change, prepare_cb, vbasedev);
|
2023-06-07 17:42:34 +03:00
|
|
|
migration_add_notifier(&migration->migration_state,
|
|
|
|
vfio_migration_state_notifier);
|
2020-10-26 12:36:14 +03:00
|
|
|
|
2023-02-16 17:36:28 +03:00
|
|
|
return 0;
|
2020-10-26 12:36:14 +03:00
|
|
|
}
|
|
|
|
|
vfio/migration: Free resources when vfio_migration_realize fails
When vfio_realize() succeeds, hot unplug will call vfio_exitfn()
to free resources allocated in vfio_realize(); when vfio_realize()
fails, vfio_exitfn() is never called and we need to free resources
in vfio_realize().
In the case that vfio_migration_realize() fails,
e.g: with -only-migratable & enable-migration=off, we see below:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
0000:81:11.1: Migration disabled
Error: disallowing migration blocker (--only-migratable) for: 0000:81:11.1: Migration is disabled for VFIO device
If we hotplug again we should see same log as above, but we see:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
Error: vfio 0000:81:11.1: device is already attached
That's because some references to VFIO device isn't released.
For resources allocated in vfio_migration_realize(), free them by
jumping to out_deinit path with calling a new function
vfio_migration_deinit(). For resources allocated in vfio_realize(),
free them by jumping to de-register path in vfio_realize().
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Fixes: a22651053b59 ("vfio: Make vfio-pci device migration capable")
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
2023-07-03 10:15:08 +03:00
|
|
|
static void vfio_migration_deinit(VFIODevice *vbasedev)
|
|
|
|
{
|
|
|
|
VFIOMigration *migration = vbasedev->migration;
|
|
|
|
|
2023-06-07 17:42:34 +03:00
|
|
|
migration_remove_notifier(&migration->migration_state);
|
vfio/migration: Free resources when vfio_migration_realize fails
When vfio_realize() succeeds, hot unplug will call vfio_exitfn()
to free resources allocated in vfio_realize(); when vfio_realize()
fails, vfio_exitfn() is never called and we need to free resources
in vfio_realize().
In the case that vfio_migration_realize() fails,
e.g: with -only-migratable & enable-migration=off, we see below:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
0000:81:11.1: Migration disabled
Error: disallowing migration blocker (--only-migratable) for: 0000:81:11.1: Migration is disabled for VFIO device
If we hotplug again we should see same log as above, but we see:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
Error: vfio 0000:81:11.1: device is already attached
That's because some references to VFIO device isn't released.
For resources allocated in vfio_migration_realize(), free them by
jumping to out_deinit path with calling a new function
vfio_migration_deinit(). For resources allocated in vfio_realize(),
free them by jumping to de-register path in vfio_realize().
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Fixes: a22651053b59 ("vfio: Make vfio-pci device migration capable")
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
2023-07-03 10:15:08 +03:00
|
|
|
qemu_del_vm_change_state_handler(migration->vm_state);
|
|
|
|
unregister_savevm(VMSTATE_IF(vbasedev->dev), "vfio", vbasedev);
|
|
|
|
vfio_migration_free(vbasedev);
|
|
|
|
vfio_unblock_multiple_devices_migration();
|
|
|
|
}
|
|
|
|
|
2023-06-28 10:31:12 +03:00
|
|
|
static int vfio_block_migration(VFIODevice *vbasedev, Error *err, Error **errp)
|
|
|
|
{
|
|
|
|
if (vbasedev->enable_migration == ON_OFF_AUTO_ON) {
|
|
|
|
error_propagate(errp, err);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
vbasedev->migration_blocker = error_copy(err);
|
|
|
|
error_free(err);
|
|
|
|
|
2024-02-22 20:28:38 +03:00
|
|
|
return migrate_add_blocker_normal(&vbasedev->migration_blocker, errp);
|
2023-06-28 10:31:12 +03:00
|
|
|
}
|
|
|
|
|
2020-10-26 12:36:14 +03:00
|
|
|
/* ---------------------------------------------------------------------- */
|
|
|
|
|
2020-10-26 12:36:27 +03:00
|
|
|
int64_t vfio_mig_bytes_transferred(void)
|
|
|
|
{
|
|
|
|
return bytes_transferred;
|
|
|
|
}
|
|
|
|
|
2023-06-28 10:31:11 +03:00
|
|
|
void vfio_reset_bytes_transferred(void)
|
|
|
|
{
|
|
|
|
bytes_transferred = 0;
|
|
|
|
}
|
|
|
|
|
2023-07-03 10:15:10 +03:00
|
|
|
/*
|
|
|
|
* Return true when either migration initialized or blocker registered.
|
|
|
|
* Currently only return false when adding blocker fails which will
|
|
|
|
* de-register vfio device.
|
|
|
|
*/
|
|
|
|
bool vfio_migration_realize(VFIODevice *vbasedev, Error **errp)
|
2020-10-26 12:36:14 +03:00
|
|
|
{
|
2023-06-28 10:31:12 +03:00
|
|
|
Error *err = NULL;
|
|
|
|
int ret;
|
2020-10-26 12:36:21 +03:00
|
|
|
|
2023-06-28 10:31:12 +03:00
|
|
|
if (vbasedev->enable_migration == ON_OFF_AUTO_OFF) {
|
|
|
|
error_setg(&err, "%s: Migration is disabled for VFIO device",
|
|
|
|
vbasedev->name);
|
2023-07-03 10:15:10 +03:00
|
|
|
return !vfio_block_migration(vbasedev, err, errp);
|
2020-10-26 12:36:21 +03:00
|
|
|
}
|
2020-10-26 12:36:14 +03:00
|
|
|
|
2023-02-16 17:36:25 +03:00
|
|
|
ret = vfio_migration_init(vbasedev);
|
2020-10-26 12:36:14 +03:00
|
|
|
if (ret) {
|
2023-06-28 10:31:12 +03:00
|
|
|
if (ret == -ENOTTY) {
|
|
|
|
error_setg(&err, "%s: VFIO migration is not supported in kernel",
|
|
|
|
vbasedev->name);
|
|
|
|
} else {
|
|
|
|
error_setg(&err,
|
|
|
|
"%s: Migration couldn't be initialized for VFIO device, "
|
|
|
|
"err: %d (%s)",
|
|
|
|
vbasedev->name, ret, strerror(-ret));
|
|
|
|
}
|
|
|
|
|
2023-07-03 10:15:10 +03:00
|
|
|
return !vfio_block_migration(vbasedev, err, errp);
|
2023-06-28 10:31:12 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!vbasedev->dirty_pages_supported) {
|
|
|
|
if (vbasedev->enable_migration == ON_OFF_AUTO_AUTO) {
|
|
|
|
error_setg(&err,
|
|
|
|
"%s: VFIO device doesn't support device dirty tracking",
|
|
|
|
vbasedev->name);
|
vfio/migration: Free resources when vfio_migration_realize fails
When vfio_realize() succeeds, hot unplug will call vfio_exitfn()
to free resources allocated in vfio_realize(); when vfio_realize()
fails, vfio_exitfn() is never called and we need to free resources
in vfio_realize().
In the case that vfio_migration_realize() fails,
e.g: with -only-migratable & enable-migration=off, we see below:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
0000:81:11.1: Migration disabled
Error: disallowing migration blocker (--only-migratable) for: 0000:81:11.1: Migration is disabled for VFIO device
If we hotplug again we should see same log as above, but we see:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
Error: vfio 0000:81:11.1: device is already attached
That's because some references to VFIO device isn't released.
For resources allocated in vfio_migration_realize(), free them by
jumping to out_deinit path with calling a new function
vfio_migration_deinit(). For resources allocated in vfio_realize(),
free them by jumping to de-register path in vfio_realize().
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Fixes: a22651053b59 ("vfio: Make vfio-pci device migration capable")
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
2023-07-03 10:15:08 +03:00
|
|
|
goto add_blocker;
|
2023-06-28 10:31:12 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
warn_report("%s: VFIO device doesn't support device dirty tracking",
|
|
|
|
vbasedev->name);
|
2020-10-26 12:36:14 +03:00
|
|
|
}
|
|
|
|
|
2023-06-28 10:31:12 +03:00
|
|
|
ret = vfio_block_multiple_devices_migration(vbasedev, errp);
|
2023-02-16 17:36:24 +03:00
|
|
|
if (ret) {
|
vfio/migration: Free resources when vfio_migration_realize fails
When vfio_realize() succeeds, hot unplug will call vfio_exitfn()
to free resources allocated in vfio_realize(); when vfio_realize()
fails, vfio_exitfn() is never called and we need to free resources
in vfio_realize().
In the case that vfio_migration_realize() fails,
e.g: with -only-migratable & enable-migration=off, we see below:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
0000:81:11.1: Migration disabled
Error: disallowing migration blocker (--only-migratable) for: 0000:81:11.1: Migration is disabled for VFIO device
If we hotplug again we should see same log as above, but we see:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
Error: vfio 0000:81:11.1: device is already attached
That's because some references to VFIO device isn't released.
For resources allocated in vfio_migration_realize(), free them by
jumping to out_deinit path with calling a new function
vfio_migration_deinit(). For resources allocated in vfio_realize(),
free them by jumping to de-register path in vfio_realize().
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Fixes: a22651053b59 ("vfio: Make vfio-pci device migration capable")
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
2023-07-03 10:15:08 +03:00
|
|
|
goto out_deinit;
|
2023-02-16 17:36:24 +03:00
|
|
|
}
|
|
|
|
|
2023-07-03 10:15:07 +03:00
|
|
|
if (vfio_viommu_preset(vbasedev)) {
|
|
|
|
error_setg(&err, "%s: Migration is currently not supported "
|
|
|
|
"with vIOMMU enabled", vbasedev->name);
|
vfio/migration: Free resources when vfio_migration_realize fails
When vfio_realize() succeeds, hot unplug will call vfio_exitfn()
to free resources allocated in vfio_realize(); when vfio_realize()
fails, vfio_exitfn() is never called and we need to free resources
in vfio_realize().
In the case that vfio_migration_realize() fails,
e.g: with -only-migratable & enable-migration=off, we see below:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
0000:81:11.1: Migration disabled
Error: disallowing migration blocker (--only-migratable) for: 0000:81:11.1: Migration is disabled for VFIO device
If we hotplug again we should see same log as above, but we see:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
Error: vfio 0000:81:11.1: device is already attached
That's because some references to VFIO device isn't released.
For resources allocated in vfio_migration_realize(), free them by
jumping to out_deinit path with calling a new function
vfio_migration_deinit(). For resources allocated in vfio_realize(),
free them by jumping to de-register path in vfio_realize().
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Fixes: a22651053b59 ("vfio: Make vfio-pci device migration capable")
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
2023-07-03 10:15:08 +03:00
|
|
|
goto add_blocker;
|
2023-03-07 15:54:48 +03:00
|
|
|
}
|
|
|
|
|
2023-06-28 10:31:12 +03:00
|
|
|
trace_vfio_migration_realize(vbasedev->name);
|
2023-07-03 10:15:10 +03:00
|
|
|
return true;
|
vfio/migration: Free resources when vfio_migration_realize fails
When vfio_realize() succeeds, hot unplug will call vfio_exitfn()
to free resources allocated in vfio_realize(); when vfio_realize()
fails, vfio_exitfn() is never called and we need to free resources
in vfio_realize().
In the case that vfio_migration_realize() fails,
e.g: with -only-migratable & enable-migration=off, we see below:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
0000:81:11.1: Migration disabled
Error: disallowing migration blocker (--only-migratable) for: 0000:81:11.1: Migration is disabled for VFIO device
If we hotplug again we should see same log as above, but we see:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
Error: vfio 0000:81:11.1: device is already attached
That's because some references to VFIO device isn't released.
For resources allocated in vfio_migration_realize(), free them by
jumping to out_deinit path with calling a new function
vfio_migration_deinit(). For resources allocated in vfio_realize(),
free them by jumping to de-register path in vfio_realize().
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Fixes: a22651053b59 ("vfio: Make vfio-pci device migration capable")
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
2023-07-03 10:15:08 +03:00
|
|
|
|
|
|
|
add_blocker:
|
|
|
|
ret = vfio_block_migration(vbasedev, err, errp);
|
|
|
|
out_deinit:
|
|
|
|
if (ret) {
|
|
|
|
vfio_migration_deinit(vbasedev);
|
|
|
|
}
|
2023-07-03 10:15:10 +03:00
|
|
|
return !ret;
|
2020-10-26 12:36:14 +03:00
|
|
|
}
|
|
|
|
|
2023-03-07 19:53:46 +03:00
|
|
|
void vfio_migration_exit(VFIODevice *vbasedev)
|
2020-10-26 12:36:14 +03:00
|
|
|
{
|
|
|
|
if (vbasedev->migration) {
|
vfio/migration: Free resources when vfio_migration_realize fails
When vfio_realize() succeeds, hot unplug will call vfio_exitfn()
to free resources allocated in vfio_realize(); when vfio_realize()
fails, vfio_exitfn() is never called and we need to free resources
in vfio_realize().
In the case that vfio_migration_realize() fails,
e.g: with -only-migratable & enable-migration=off, we see below:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
0000:81:11.1: Migration disabled
Error: disallowing migration blocker (--only-migratable) for: 0000:81:11.1: Migration is disabled for VFIO device
If we hotplug again we should see same log as above, but we see:
(qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,enable-migration=off
Error: vfio 0000:81:11.1: device is already attached
That's because some references to VFIO device isn't released.
For resources allocated in vfio_migration_realize(), free them by
jumping to out_deinit path with calling a new function
vfio_migration_deinit(). For resources allocated in vfio_realize(),
free them by jumping to de-register path in vfio_realize().
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Fixes: a22651053b59 ("vfio: Make vfio-pci device migration capable")
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
2023-07-03 10:15:08 +03:00
|
|
|
vfio_migration_deinit(vbasedev);
|
2020-10-26 12:36:14 +03:00
|
|
|
}
|
|
|
|
|
2023-10-18 16:03:36 +03:00
|
|
|
migrate_del_blocker(&vbasedev->migration_blocker);
|
2020-10-26 12:36:14 +03:00
|
|
|
}
|