2014-09-10 16:20:34 +04:00
|
|
|
/*
|
|
|
|
* Virtio video device
|
|
|
|
*
|
|
|
|
* Copyright Red Hat
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Dave Airlie
|
|
|
|
*
|
2015-09-16 10:15:15 +03:00
|
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
|
|
* See the COPYING file in the top-level directory.
|
2014-09-10 16:20:34 +04:00
|
|
|
*
|
|
|
|
*/
|
2018-02-01 14:18:31 +03:00
|
|
|
|
2016-01-26 21:17:07 +03:00
|
|
|
#include "qemu/osdep.h"
|
2018-02-01 14:18:31 +03:00
|
|
|
#include "qapi/error.h"
|
2019-05-23 17:35:07 +03:00
|
|
|
#include "qemu/module.h"
|
2014-09-10 16:20:34 +04:00
|
|
|
#include "hw/pci/pci.h"
|
2019-08-12 08:23:51 +03:00
|
|
|
#include "hw/qdev-properties.h"
|
2014-09-10 16:20:34 +04:00
|
|
|
#include "hw/virtio/virtio.h"
|
|
|
|
#include "hw/virtio/virtio-bus.h"
|
2019-05-24 16:09:46 +03:00
|
|
|
#include "hw/virtio/virtio-gpu-pci.h"
|
2020-09-03 23:43:22 +03:00
|
|
|
#include "qom/object.h"
|
2019-01-03 17:10:11 +03:00
|
|
|
|
2019-05-24 16:09:45 +03:00
|
|
|
static Property virtio_gpu_pci_base_properties[] = {
|
2014-09-10 16:20:34 +04:00
|
|
|
DEFINE_VIRTIO_GPU_PCI_PROPERTIES(VirtIOPCIProxy),
|
|
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
|
|
};
|
|
|
|
|
2019-05-24 16:09:45 +03:00
|
|
|
static void virtio_gpu_pci_base_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
|
2014-09-10 16:20:34 +04:00
|
|
|
{
|
2019-05-24 16:09:45 +03:00
|
|
|
VirtIOGPUPCIBase *vgpu = VIRTIO_GPU_PCI_BASE(vpci_dev);
|
|
|
|
VirtIOGPUBase *g = vgpu->vgpu;
|
|
|
|
DeviceState *vdev = DEVICE(g);
|
2015-06-24 13:19:42 +03:00
|
|
|
int i;
|
2014-09-10 16:20:34 +04:00
|
|
|
|
2019-07-29 19:29:03 +03:00
|
|
|
virtio_pci_force_virtio_1(vpci_dev);
|
error: Eliminate error_propagate() with Coccinelle, part 1
When all we do with an Error we receive into a local variable is
propagating to somewhere else, we can just as well receive it there
right away. Convert
if (!foo(..., &err)) {
...
error_propagate(errp, err);
...
return ...
}
to
if (!foo(..., errp)) {
...
...
return ...
}
where nothing else needs @err. Coccinelle script:
@rule1 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
binary operator op;
constant c1, c2;
symbol false;
@@
if (
(
- fun(args, &err, args2)
+ fun(args, errp, args2)
|
- !fun(args, &err, args2)
+ !fun(args, errp, args2)
|
- fun(args, &err, args2) op c1
+ fun(args, errp, args2) op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
)
}
@rule2 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
expression var;
binary operator op;
constant c1, c2;
symbol false;
@@
- var = fun(args, &err, args2);
+ var = fun(args, errp, args2);
... when != err
if (
(
var
|
!var
|
var op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
|
return var;
)
}
@depends on rule1 || rule2@
identifier err;
@@
- Error *err = NULL;
... when != err
Not exactly elegant, I'm afraid.
The "when != lbl:" is necessary to avoid transforming
if (fun(args, &err)) {
goto out
}
...
out:
error_propagate(errp, err);
even though other paths to label out still need the error_propagate().
For an actual example, see sclp_realize().
Without the "when strict", Coccinelle transforms vfio_msix_setup(),
incorrectly. I don't know what exactly "when strict" does, only that
it helps here.
The match of return is narrower than what I want, but I can't figure
out how to express "return where the operand doesn't use @err". For
an example where it's too narrow, see vfio_intx_enable().
Silently fails to convert hw/arm/armsse.c, because Coccinelle gets
confused by ARMSSE being used both as typedef and function-like macro
there. Converted manually.
Line breaks tidied up manually. One nested declaration of @local_err
deleted manually. Preexisting unwanted blank line dropped in
hw/riscv/sifive_e.c.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-35-armbru@redhat.com>
2020-07-07 19:06:02 +03:00
|
|
|
if (!qdev_realize(vdev, BUS(&vpci_dev->bus), errp)) {
|
2018-01-31 07:04:01 +03:00
|
|
|
return;
|
|
|
|
}
|
2015-06-24 13:19:42 +03:00
|
|
|
|
|
|
|
for (i = 0; i < g->conf.max_outputs; i++) {
|
qom: Put name parameter before value / visitor parameter
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
2020-07-07 19:05:54 +03:00
|
|
|
object_property_set_link(OBJECT(g->scanout[i].con), "device",
|
|
|
|
OBJECT(vpci_dev), &error_abort);
|
2015-06-24 13:19:42 +03:00
|
|
|
}
|
2014-09-10 16:20:34 +04:00
|
|
|
}
|
|
|
|
|
2019-05-24 16:09:45 +03:00
|
|
|
static void virtio_gpu_pci_base_class_init(ObjectClass *klass, void *data)
|
2014-09-10 16:20:34 +04:00
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
|
|
VirtioPCIClass *k = VIRTIO_PCI_CLASS(klass);
|
|
|
|
PCIDeviceClass *pcidev_k = PCI_DEVICE_CLASS(klass);
|
|
|
|
|
|
|
|
set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
|
2020-01-10 18:30:32 +03:00
|
|
|
device_class_set_props(dc, virtio_gpu_pci_base_properties);
|
2016-09-08 10:17:17 +03:00
|
|
|
dc->hotpluggable = false;
|
2019-05-24 16:09:45 +03:00
|
|
|
k->realize = virtio_gpu_pci_base_realize;
|
2014-09-10 16:20:34 +04:00
|
|
|
pcidev_k->class_id = PCI_CLASS_DISPLAY_OTHER;
|
|
|
|
}
|
|
|
|
|
2019-05-24 16:09:45 +03:00
|
|
|
static const TypeInfo virtio_gpu_pci_base_info = {
|
|
|
|
.name = TYPE_VIRTIO_GPU_PCI_BASE,
|
|
|
|
.parent = TYPE_VIRTIO_PCI,
|
|
|
|
.instance_size = sizeof(VirtIOGPUPCIBase),
|
|
|
|
.class_init = virtio_gpu_pci_base_class_init,
|
|
|
|
.abstract = true
|
|
|
|
};
|
|
|
|
|
|
|
|
#define TYPE_VIRTIO_GPU_PCI "virtio-gpu-pci"
|
2020-09-03 23:43:22 +03:00
|
|
|
typedef struct VirtIOGPUPCI VirtIOGPUPCI;
|
2019-05-24 16:09:45 +03:00
|
|
|
#define VIRTIO_GPU_PCI(obj) \
|
|
|
|
OBJECT_CHECK(VirtIOGPUPCI, (obj), TYPE_VIRTIO_GPU_PCI)
|
|
|
|
|
2020-09-03 23:43:22 +03:00
|
|
|
struct VirtIOGPUPCI {
|
2019-05-24 16:09:45 +03:00
|
|
|
VirtIOGPUPCIBase parent_obj;
|
|
|
|
VirtIOGPU vdev;
|
2020-09-03 23:43:22 +03:00
|
|
|
};
|
2019-05-24 16:09:45 +03:00
|
|
|
|
2014-09-10 16:20:34 +04:00
|
|
|
static void virtio_gpu_initfn(Object *obj)
|
|
|
|
{
|
|
|
|
VirtIOGPUPCI *dev = VIRTIO_GPU_PCI(obj);
|
2015-06-24 13:22:09 +03:00
|
|
|
|
|
|
|
virtio_instance_init_common(obj, &dev->vdev, sizeof(dev->vdev),
|
|
|
|
TYPE_VIRTIO_GPU);
|
2019-05-24 16:09:45 +03:00
|
|
|
VIRTIO_GPU_PCI_BASE(obj)->vgpu = VIRTIO_GPU_BASE(&dev->vdev);
|
2014-09-10 16:20:34 +04:00
|
|
|
}
|
|
|
|
|
2018-12-05 22:57:03 +03:00
|
|
|
static const VirtioPCIDeviceTypeInfo virtio_gpu_pci_info = {
|
|
|
|
.generic_name = TYPE_VIRTIO_GPU_PCI,
|
2019-05-24 16:09:45 +03:00
|
|
|
.parent = TYPE_VIRTIO_GPU_PCI_BASE,
|
2014-09-10 16:20:34 +04:00
|
|
|
.instance_size = sizeof(VirtIOGPUPCI),
|
|
|
|
.instance_init = virtio_gpu_initfn,
|
|
|
|
};
|
|
|
|
|
|
|
|
static void virtio_gpu_pci_register_types(void)
|
|
|
|
{
|
2019-05-24 16:09:45 +03:00
|
|
|
type_register_static(&virtio_gpu_pci_base_info);
|
2018-12-05 22:57:03 +03:00
|
|
|
virtio_pci_types_register(&virtio_gpu_pci_info);
|
2014-09-10 16:20:34 +04:00
|
|
|
}
|
2019-05-24 16:09:45 +03:00
|
|
|
|
2014-09-10 16:20:34 +04:00
|
|
|
type_init(virtio_gpu_pci_register_types)
|