2010-03-17 14:08:17 +03:00
|
|
|
/*
|
|
|
|
* vhost-net support
|
|
|
|
*
|
|
|
|
* Copyright Red Hat, Inc. 2010
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Michael S. Tsirkin <mst@redhat.com>
|
|
|
|
*
|
|
|
|
* This work is licensed under the terms of the GNU GPL, version 2. See
|
|
|
|
* the COPYING file in the top-level directory.
|
2012-01-13 20:44:23 +04:00
|
|
|
*
|
|
|
|
* Contributions after 2012-01-13 are licensed under the terms of the
|
|
|
|
* GNU GPL, version 2 or (at your option) any later version.
|
2010-03-17 14:08:17 +03:00
|
|
|
*/
|
|
|
|
|
2016-01-26 21:17:11 +03:00
|
|
|
#include "qemu/osdep.h"
|
2012-10-24 10:43:34 +04:00
|
|
|
#include "net/net.h"
|
2010-03-17 14:08:17 +03:00
|
|
|
#include "net/tap.h"
|
2014-06-10 14:02:16 +04:00
|
|
|
#include "net/vhost-user.h"
|
2010-03-17 14:08:17 +03:00
|
|
|
|
2019-02-14 20:35:50 +03:00
|
|
|
#include "standard-headers/linux/vhost_types.h"
|
2013-02-05 20:06:20 +04:00
|
|
|
#include "hw/virtio/virtio-net.h"
|
|
|
|
#include "net/vhost_net.h"
|
2012-12-17 21:20:00 +04:00
|
|
|
#include "qemu/error-report.h"
|
2010-03-17 14:08:17 +03:00
|
|
|
|
|
|
|
|
|
|
|
#include <sys/socket.h>
|
|
|
|
#include <net/if.h>
|
|
|
|
#include <netinet/in.h>
|
|
|
|
|
|
|
|
|
2015-02-17 00:35:40 +03:00
|
|
|
#include "standard-headers/linux/virtio_ring.h"
|
2013-02-05 20:06:20 +04:00
|
|
|
#include "hw/virtio/vhost.h"
|
2013-04-24 12:21:21 +04:00
|
|
|
#include "hw/virtio/virtio-bus.h"
|
2010-03-17 14:08:17 +03:00
|
|
|
|
|
|
|
struct vhost_net {
|
|
|
|
struct vhost_dev dev;
|
|
|
|
struct vhost_virtqueue vqs[2];
|
|
|
|
int backend;
|
2012-07-24 19:35:14 +04:00
|
|
|
NetClientState *nc;
|
2010-03-17 14:08:17 +03:00
|
|
|
};
|
|
|
|
|
2014-05-27 16:04:42 +04:00
|
|
|
/* Features supported by host kernel. */
|
|
|
|
static const int kernel_feature_bits[] = {
|
|
|
|
VIRTIO_F_NOTIFY_ON_EMPTY,
|
|
|
|
VIRTIO_RING_F_INDIRECT_DESC,
|
|
|
|
VIRTIO_RING_F_EVENT_IDX,
|
|
|
|
VIRTIO_NET_F_MRG_RXBUF,
|
2015-06-04 13:34:19 +03:00
|
|
|
VIRTIO_F_VERSION_1,
|
2016-12-10 18:30:37 +03:00
|
|
|
VIRTIO_NET_F_MTU,
|
2017-01-11 07:32:12 +03:00
|
|
|
VIRTIO_F_IOMMU_PLATFORM,
|
2014-05-27 16:04:42 +04:00
|
|
|
VHOST_INVALID_FEATURE_BIT
|
|
|
|
};
|
|
|
|
|
2014-05-27 16:06:16 +04:00
|
|
|
/* Features supported by others. */
|
2015-02-28 21:19:17 +03:00
|
|
|
static const int user_feature_bits[] = {
|
2014-05-27 16:06:16 +04:00
|
|
|
VIRTIO_F_NOTIFY_ON_EMPTY,
|
|
|
|
VIRTIO_RING_F_INDIRECT_DESC,
|
|
|
|
VIRTIO_RING_F_EVENT_IDX,
|
|
|
|
|
|
|
|
VIRTIO_F_ANY_LAYOUT,
|
2015-06-04 13:34:19 +03:00
|
|
|
VIRTIO_F_VERSION_1,
|
2014-05-27 16:06:16 +04:00
|
|
|
VIRTIO_NET_F_CSUM,
|
|
|
|
VIRTIO_NET_F_GUEST_CSUM,
|
|
|
|
VIRTIO_NET_F_GSO,
|
|
|
|
VIRTIO_NET_F_GUEST_TSO4,
|
|
|
|
VIRTIO_NET_F_GUEST_TSO6,
|
|
|
|
VIRTIO_NET_F_GUEST_ECN,
|
|
|
|
VIRTIO_NET_F_GUEST_UFO,
|
|
|
|
VIRTIO_NET_F_HOST_TSO4,
|
|
|
|
VIRTIO_NET_F_HOST_TSO6,
|
|
|
|
VIRTIO_NET_F_HOST_ECN,
|
|
|
|
VIRTIO_NET_F_HOST_UFO,
|
|
|
|
VIRTIO_NET_F_MRG_RXBUF,
|
2016-12-10 18:30:37 +03:00
|
|
|
VIRTIO_NET_F_MTU,
|
2017-06-02 13:18:31 +03:00
|
|
|
VIRTIO_F_IOMMU_PLATFORM,
|
2014-05-27 16:06:16 +04:00
|
|
|
|
2015-11-17 17:55:17 +03:00
|
|
|
/* This bit implies RARP isn't sent by QEMU out of band */
|
2015-10-09 18:17:31 +03:00
|
|
|
VIRTIO_NET_F_GUEST_ANNOUNCE,
|
|
|
|
|
2014-05-27 16:06:16 +04:00
|
|
|
VIRTIO_NET_F_MQ,
|
|
|
|
|
|
|
|
VHOST_INVALID_FEATURE_BIT
|
|
|
|
};
|
|
|
|
|
2014-05-27 16:04:42 +04:00
|
|
|
static const int *vhost_net_get_feature_bits(struct vhost_net *net)
|
2010-03-17 14:08:17 +03:00
|
|
|
{
|
2014-05-27 16:04:42 +04:00
|
|
|
const int *feature_bits = 0;
|
|
|
|
|
|
|
|
switch (net->nc->info->type) {
|
qapi: Change Netdev into a flat union
This is a mostly-mechanical conversion that creates a new flat
union 'Netdev' QAPI type that covers all the branches of the
former 'NetClientOptions' simple union, where the branches are
now listed in a new 'NetClientDriver' enum rather than generated
from the simple union. The existence of a flat union has no
change to the command line syntax accepted for new code, and
will make it possible for a future patch to switch the QMP
command to parse a boxed union for no change to valid QMP; but
it does have some ripple effect on the C code when dealing with
the new types.
While making the conversion, note that the 'NetLegacy' type
remains unchanged: it applies only to legacy command line options,
and will not be ported to QMP, so it should remain a wrapper
around a simple union; to avoid confusion, the type named
'NetClientOptions' is now gone, and we introduce 'NetLegacyOptions'
in its place. Then, in the C code, we convert from NetLegacy to
Netdev as soon as possible, so that the bulk of the net stack
only has to deal with one QAPI type, not two. Note that since
the old legacy code always rejected 'hubport', we can just omit
that branch from the new 'NetLegacyOptions' simple union.
Based on an idea originally by Zoltán Kővágó <DirtY.iCE.hu@gmail.com>:
Message-Id: <01a527fbf1a5de880091f98cf011616a78adeeee.1441627176.git.DirtY.iCE.hu@gmail.com>
although the sed script in that patch no longer applies due to
other changes in the tree since then, and I also did some manual
cleanups (such as fixing whitespace to keep checkpatch happy).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1468468228-27827-13-git-send-email-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Fixup from Eric squashed in]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2016-07-14 06:50:23 +03:00
|
|
|
case NET_CLIENT_DRIVER_TAP:
|
2014-05-27 16:04:42 +04:00
|
|
|
feature_bits = kernel_feature_bits;
|
|
|
|
break;
|
qapi: Change Netdev into a flat union
This is a mostly-mechanical conversion that creates a new flat
union 'Netdev' QAPI type that covers all the branches of the
former 'NetClientOptions' simple union, where the branches are
now listed in a new 'NetClientDriver' enum rather than generated
from the simple union. The existence of a flat union has no
change to the command line syntax accepted for new code, and
will make it possible for a future patch to switch the QMP
command to parse a boxed union for no change to valid QMP; but
it does have some ripple effect on the C code when dealing with
the new types.
While making the conversion, note that the 'NetLegacy' type
remains unchanged: it applies only to legacy command line options,
and will not be ported to QMP, so it should remain a wrapper
around a simple union; to avoid confusion, the type named
'NetClientOptions' is now gone, and we introduce 'NetLegacyOptions'
in its place. Then, in the C code, we convert from NetLegacy to
Netdev as soon as possible, so that the bulk of the net stack
only has to deal with one QAPI type, not two. Note that since
the old legacy code always rejected 'hubport', we can just omit
that branch from the new 'NetLegacyOptions' simple union.
Based on an idea originally by Zoltán Kővágó <DirtY.iCE.hu@gmail.com>:
Message-Id: <01a527fbf1a5de880091f98cf011616a78adeeee.1441627176.git.DirtY.iCE.hu@gmail.com>
although the sed script in that patch no longer applies due to
other changes in the tree since then, and I also did some manual
cleanups (such as fixing whitespace to keep checkpatch happy).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1468468228-27827-13-git-send-email-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Fixup from Eric squashed in]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2016-07-14 06:50:23 +03:00
|
|
|
case NET_CLIENT_DRIVER_VHOST_USER:
|
2014-05-27 16:06:16 +04:00
|
|
|
feature_bits = user_feature_bits;
|
|
|
|
break;
|
2014-05-27 16:04:42 +04:00
|
|
|
default:
|
|
|
|
error_report("Feature bits not defined for this type: %d",
|
|
|
|
net->nc->info->type);
|
|
|
|
break;
|
2010-07-16 12:43:43 +04:00
|
|
|
}
|
2014-05-27 16:04:42 +04:00
|
|
|
|
|
|
|
return feature_bits;
|
|
|
|
}
|
|
|
|
|
2015-06-04 13:34:20 +03:00
|
|
|
uint64_t vhost_net_get_features(struct vhost_net *net, uint64_t features)
|
2014-05-27 16:04:42 +04:00
|
|
|
{
|
|
|
|
return vhost_get_features(&net->dev, vhost_net_get_feature_bits(net),
|
|
|
|
features);
|
2010-03-17 14:08:17 +03:00
|
|
|
}
|
|
|
|
|
2015-06-04 13:34:20 +03:00
|
|
|
void vhost_net_ack_features(struct vhost_net *net, uint64_t features)
|
2010-03-17 14:08:17 +03:00
|
|
|
{
|
2014-09-03 10:25:30 +04:00
|
|
|
net->dev.acked_features = net->dev.backend_features;
|
2014-05-27 16:04:42 +04:00
|
|
|
vhost_ack_features(&net->dev, vhost_net_get_feature_bits(net), features);
|
2010-03-17 14:08:17 +03:00
|
|
|
}
|
|
|
|
|
2015-09-23 07:19:58 +03:00
|
|
|
uint64_t vhost_net_get_max_queues(VHostNetState *net)
|
|
|
|
{
|
|
|
|
return net->dev.max_queues;
|
|
|
|
}
|
|
|
|
|
2016-06-06 19:45:05 +03:00
|
|
|
uint64_t vhost_net_get_acked_features(VHostNetState *net)
|
|
|
|
{
|
|
|
|
return net->dev.acked_features;
|
|
|
|
}
|
|
|
|
|
2012-07-24 19:35:13 +04:00
|
|
|
static int vhost_net_get_fd(NetClientState *backend)
|
2010-03-17 14:08:17 +03:00
|
|
|
{
|
|
|
|
switch (backend->info->type) {
|
qapi: Change Netdev into a flat union
This is a mostly-mechanical conversion that creates a new flat
union 'Netdev' QAPI type that covers all the branches of the
former 'NetClientOptions' simple union, where the branches are
now listed in a new 'NetClientDriver' enum rather than generated
from the simple union. The existence of a flat union has no
change to the command line syntax accepted for new code, and
will make it possible for a future patch to switch the QMP
command to parse a boxed union for no change to valid QMP; but
it does have some ripple effect on the C code when dealing with
the new types.
While making the conversion, note that the 'NetLegacy' type
remains unchanged: it applies only to legacy command line options,
and will not be ported to QMP, so it should remain a wrapper
around a simple union; to avoid confusion, the type named
'NetClientOptions' is now gone, and we introduce 'NetLegacyOptions'
in its place. Then, in the C code, we convert from NetLegacy to
Netdev as soon as possible, so that the bulk of the net stack
only has to deal with one QAPI type, not two. Note that since
the old legacy code always rejected 'hubport', we can just omit
that branch from the new 'NetLegacyOptions' simple union.
Based on an idea originally by Zoltán Kővágó <DirtY.iCE.hu@gmail.com>:
Message-Id: <01a527fbf1a5de880091f98cf011616a78adeeee.1441627176.git.DirtY.iCE.hu@gmail.com>
although the sed script in that patch no longer applies due to
other changes in the tree since then, and I also did some manual
cleanups (such as fixing whitespace to keep checkpatch happy).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1468468228-27827-13-git-send-email-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Fixup from Eric squashed in]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2016-07-14 06:50:23 +03:00
|
|
|
case NET_CLIENT_DRIVER_TAP:
|
2010-03-17 14:08:17 +03:00
|
|
|
return tap_get_fd(backend);
|
|
|
|
default:
|
|
|
|
fprintf(stderr, "vhost-net requires tap backend\n");
|
2019-02-14 20:35:52 +03:00
|
|
|
return -ENOSYS;
|
2010-03-17 14:08:17 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-05-27 16:05:22 +04:00
|
|
|
struct vhost_net *vhost_net_init(VhostNetOptions *options)
|
2010-03-17 14:08:17 +03:00
|
|
|
{
|
|
|
|
int r;
|
2014-05-27 16:05:49 +04:00
|
|
|
bool backend_kernel = options->backend_type == VHOST_BACKEND_TYPE_KERNEL;
|
2016-07-27 00:15:03 +03:00
|
|
|
struct vhost_net *net = g_new0(struct vhost_net, 1);
|
2016-06-06 19:45:05 +03:00
|
|
|
uint64_t features = 0;
|
2014-05-27 16:05:22 +04:00
|
|
|
|
|
|
|
if (!options->net_backend) {
|
|
|
|
fprintf(stderr, "vhost-net requires net backend to be setup\n");
|
2010-03-17 14:08:17 +03:00
|
|
|
goto fail;
|
|
|
|
}
|
vhost-user: add multiple queue support
This patch is initially based a patch from Nikolay Nikolaev.
This patch adds vhost-user multiple queue support, by creating a nc
and vhost_net pair for each queue.
Qemu exits if find that the backend can't support the number of requested
queues (by providing queues=# option). The max number is queried by a
new message, VHOST_USER_GET_QUEUE_NUM, and is sent only when protocol
feature VHOST_USER_PROTOCOL_F_MQ is present first.
The max queue check is done at vhost-user initiation stage. We initiate
one queue first, which, in the meantime, also gets the max_queues the
backend supports.
In older version, it was reported that some messages are sent more times
than necessary. Here we came an agreement with Michael that we could
categorize vhost user messages to 2 types: non-vring specific messages,
which should be sent only once, and vring specific messages, which should
be sent per queue.
Here I introduced a helper function vhost_user_one_time_request(), which
lists following messages as non-vring specific messages:
VHOST_USER_SET_OWNER
VHOST_USER_RESET_DEVICE
VHOST_USER_SET_MEM_TABLE
VHOST_USER_GET_QUEUE_NUM
For above messages, we simply ignore them when they are not sent the first
time.
Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Reviewed-by: Jason Wang <jasowang@redhat.com>
Tested-by: Marcel Apfelbaum <marcel@redhat.com>
2015-09-23 07:20:00 +03:00
|
|
|
net->nc = options->net_backend;
|
2014-05-27 16:05:22 +04:00
|
|
|
|
2015-09-23 07:19:58 +03:00
|
|
|
net->dev.max_queues = 1;
|
vhost-user: add multiple queue support
This patch is initially based a patch from Nikolay Nikolaev.
This patch adds vhost-user multiple queue support, by creating a nc
and vhost_net pair for each queue.
Qemu exits if find that the backend can't support the number of requested
queues (by providing queues=# option). The max number is queried by a
new message, VHOST_USER_GET_QUEUE_NUM, and is sent only when protocol
feature VHOST_USER_PROTOCOL_F_MQ is present first.
The max queue check is done at vhost-user initiation stage. We initiate
one queue first, which, in the meantime, also gets the max_queues the
backend supports.
In older version, it was reported that some messages are sent more times
than necessary. Here we came an agreement with Michael that we could
categorize vhost user messages to 2 types: non-vring specific messages,
which should be sent only once, and vring specific messages, which should
be sent per queue.
Here I introduced a helper function vhost_user_one_time_request(), which
lists following messages as non-vring specific messages:
VHOST_USER_SET_OWNER
VHOST_USER_RESET_DEVICE
VHOST_USER_SET_MEM_TABLE
VHOST_USER_GET_QUEUE_NUM
For above messages, we simply ignore them when they are not sent the first
time.
Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Reviewed-by: Jason Wang <jasowang@redhat.com>
Tested-by: Marcel Apfelbaum <marcel@redhat.com>
2015-09-23 07:20:00 +03:00
|
|
|
net->dev.nvqs = 2;
|
|
|
|
net->dev.vqs = net->vqs;
|
2015-09-23 07:19:58 +03:00
|
|
|
|
2014-05-27 16:05:49 +04:00
|
|
|
if (backend_kernel) {
|
|
|
|
r = vhost_net_get_fd(options->net_backend);
|
|
|
|
if (r < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
net->dev.backend_features = qemu_has_vnet_hdr(options->net_backend)
|
2015-06-04 13:34:20 +03:00
|
|
|
? 0 : (1ULL << VHOST_NET_F_VIRTIO_NET_HDR);
|
2014-05-27 16:05:49 +04:00
|
|
|
net->backend = r;
|
2015-09-23 07:19:56 +03:00
|
|
|
net->dev.protocol_features = 0;
|
2014-05-27 16:05:49 +04:00
|
|
|
} else {
|
|
|
|
net->dev.backend_features = 0;
|
2015-09-23 07:19:56 +03:00
|
|
|
net->dev.protocol_features = 0;
|
2014-05-27 16:05:49 +04:00
|
|
|
net->backend = -1;
|
2010-03-17 14:08:17 +03:00
|
|
|
|
vhost-user: add multiple queue support
This patch is initially based a patch from Nikolay Nikolaev.
This patch adds vhost-user multiple queue support, by creating a nc
and vhost_net pair for each queue.
Qemu exits if find that the backend can't support the number of requested
queues (by providing queues=# option). The max number is queried by a
new message, VHOST_USER_GET_QUEUE_NUM, and is sent only when protocol
feature VHOST_USER_PROTOCOL_F_MQ is present first.
The max queue check is done at vhost-user initiation stage. We initiate
one queue first, which, in the meantime, also gets the max_queues the
backend supports.
In older version, it was reported that some messages are sent more times
than necessary. Here we came an agreement with Michael that we could
categorize vhost user messages to 2 types: non-vring specific messages,
which should be sent only once, and vring specific messages, which should
be sent per queue.
Here I introduced a helper function vhost_user_one_time_request(), which
lists following messages as non-vring specific messages:
VHOST_USER_SET_OWNER
VHOST_USER_RESET_DEVICE
VHOST_USER_SET_MEM_TABLE
VHOST_USER_GET_QUEUE_NUM
For above messages, we simply ignore them when they are not sent the first
time.
Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Reviewed-by: Jason Wang <jasowang@redhat.com>
Tested-by: Marcel Apfelbaum <marcel@redhat.com>
2015-09-23 07:20:00 +03:00
|
|
|
/* vhost-user needs vq_index to initiate a specific queue pair */
|
|
|
|
net->dev.vq_index = net->nc->queue_index * net->dev.nvqs;
|
|
|
|
}
|
2012-12-24 19:37:01 +04:00
|
|
|
|
2014-05-27 16:05:22 +04:00
|
|
|
r = vhost_dev_init(&net->dev, options->opaque,
|
2016-07-06 04:57:55 +03:00
|
|
|
options->backend_type, options->busyloop_timeout);
|
2010-03-17 14:08:17 +03:00
|
|
|
if (r < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
2014-05-27 16:05:49 +04:00
|
|
|
if (backend_kernel) {
|
2014-09-12 01:55:48 +04:00
|
|
|
if (!qemu_has_vnet_hdr_len(options->net_backend,
|
|
|
|
sizeof(struct virtio_net_hdr_mrg_rxbuf))) {
|
2015-06-04 13:34:20 +03:00
|
|
|
net->dev.features &= ~(1ULL << VIRTIO_NET_F_MRG_RXBUF);
|
2014-09-12 01:55:48 +04:00
|
|
|
}
|
2014-05-27 16:05:49 +04:00
|
|
|
if (~net->dev.features & net->dev.backend_features) {
|
|
|
|
fprintf(stderr, "vhost lacks feature mask %" PRIu64
|
|
|
|
" for backend\n",
|
|
|
|
(uint64_t)(~net->dev.features & net->dev.backend_features));
|
|
|
|
goto fail;
|
|
|
|
}
|
2010-03-17 14:08:17 +03:00
|
|
|
}
|
2016-06-06 19:45:05 +03:00
|
|
|
|
2010-03-17 14:08:17 +03:00
|
|
|
/* Set sane init value. Override when guest acks. */
|
2019-02-14 20:35:49 +03:00
|
|
|
#ifdef CONFIG_VHOST_NET_USER
|
qapi: Change Netdev into a flat union
This is a mostly-mechanical conversion that creates a new flat
union 'Netdev' QAPI type that covers all the branches of the
former 'NetClientOptions' simple union, where the branches are
now listed in a new 'NetClientDriver' enum rather than generated
from the simple union. The existence of a flat union has no
change to the command line syntax accepted for new code, and
will make it possible for a future patch to switch the QMP
command to parse a boxed union for no change to valid QMP; but
it does have some ripple effect on the C code when dealing with
the new types.
While making the conversion, note that the 'NetLegacy' type
remains unchanged: it applies only to legacy command line options,
and will not be ported to QMP, so it should remain a wrapper
around a simple union; to avoid confusion, the type named
'NetClientOptions' is now gone, and we introduce 'NetLegacyOptions'
in its place. Then, in the C code, we convert from NetLegacy to
Netdev as soon as possible, so that the bulk of the net stack
only has to deal with one QAPI type, not two. Note that since
the old legacy code always rejected 'hubport', we can just omit
that branch from the new 'NetLegacyOptions' simple union.
Based on an idea originally by Zoltán Kővágó <DirtY.iCE.hu@gmail.com>:
Message-Id: <01a527fbf1a5de880091f98cf011616a78adeeee.1441627176.git.DirtY.iCE.hu@gmail.com>
although the sed script in that patch no longer applies due to
other changes in the tree since then, and I also did some manual
cleanups (such as fixing whitespace to keep checkpatch happy).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1468468228-27827-13-git-send-email-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Fixup from Eric squashed in]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2016-07-14 06:50:23 +03:00
|
|
|
if (net->nc->info->type == NET_CLIENT_DRIVER_VHOST_USER) {
|
2016-06-06 19:45:05 +03:00
|
|
|
features = vhost_user_get_acked_features(net->nc);
|
|
|
|
if (~net->dev.features & features) {
|
|
|
|
fprintf(stderr, "vhost lacks feature mask %" PRIu64
|
|
|
|
" for backend\n",
|
|
|
|
(uint64_t)(~net->dev.features & features));
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
2019-02-14 20:35:49 +03:00
|
|
|
#endif
|
2016-06-06 19:45:05 +03:00
|
|
|
|
|
|
|
vhost_net_ack_features(net, features);
|
|
|
|
|
2010-03-17 14:08:17 +03:00
|
|
|
return net;
|
2016-07-27 00:15:03 +03:00
|
|
|
|
2010-03-17 14:08:17 +03:00
|
|
|
fail:
|
2016-07-27 00:15:03 +03:00
|
|
|
vhost_dev_cleanup(&net->dev);
|
2011-08-21 07:09:37 +04:00
|
|
|
g_free(net);
|
2010-03-17 14:08:17 +03:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2014-08-19 08:56:29 +04:00
|
|
|
static void vhost_net_set_vq_index(struct vhost_net *net, int vq_index)
|
|
|
|
{
|
|
|
|
net->dev.vq_index = vq_index;
|
|
|
|
}
|
|
|
|
|
2013-01-30 15:12:35 +04:00
|
|
|
static int vhost_net_start_one(struct vhost_net *net,
|
2014-08-19 08:56:29 +04:00
|
|
|
VirtIODevice *dev)
|
2010-03-17 14:08:17 +03:00
|
|
|
{
|
|
|
|
struct vhost_vring_file file = { };
|
|
|
|
int r;
|
2011-08-11 11:21:18 +04:00
|
|
|
|
2013-01-30 15:12:35 +04:00
|
|
|
net->dev.nvqs = 2;
|
|
|
|
net->dev.vqs = net->vqs;
|
|
|
|
|
2011-08-11 11:21:18 +04:00
|
|
|
r = vhost_dev_enable_notifiers(&net->dev, dev);
|
|
|
|
if (r < 0) {
|
|
|
|
goto fail_notifiers;
|
|
|
|
}
|
2010-03-17 14:08:17 +03:00
|
|
|
|
|
|
|
r = vhost_dev_start(&net->dev, dev);
|
|
|
|
if (r < 0) {
|
2011-08-11 11:21:18 +04:00
|
|
|
goto fail_start;
|
2010-03-17 14:08:17 +03:00
|
|
|
}
|
|
|
|
|
2014-05-27 16:04:55 +04:00
|
|
|
if (net->nc->info->poll) {
|
|
|
|
net->nc->info->poll(net->nc, false);
|
|
|
|
}
|
|
|
|
|
qapi: Change Netdev into a flat union
This is a mostly-mechanical conversion that creates a new flat
union 'Netdev' QAPI type that covers all the branches of the
former 'NetClientOptions' simple union, where the branches are
now listed in a new 'NetClientDriver' enum rather than generated
from the simple union. The existence of a flat union has no
change to the command line syntax accepted for new code, and
will make it possible for a future patch to switch the QMP
command to parse a boxed union for no change to valid QMP; but
it does have some ripple effect on the C code when dealing with
the new types.
While making the conversion, note that the 'NetLegacy' type
remains unchanged: it applies only to legacy command line options,
and will not be ported to QMP, so it should remain a wrapper
around a simple union; to avoid confusion, the type named
'NetClientOptions' is now gone, and we introduce 'NetLegacyOptions'
in its place. Then, in the C code, we convert from NetLegacy to
Netdev as soon as possible, so that the bulk of the net stack
only has to deal with one QAPI type, not two. Note that since
the old legacy code always rejected 'hubport', we can just omit
that branch from the new 'NetLegacyOptions' simple union.
Based on an idea originally by Zoltán Kővágó <DirtY.iCE.hu@gmail.com>:
Message-Id: <01a527fbf1a5de880091f98cf011616a78adeeee.1441627176.git.DirtY.iCE.hu@gmail.com>
although the sed script in that patch no longer applies due to
other changes in the tree since then, and I also did some manual
cleanups (such as fixing whitespace to keep checkpatch happy).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1468468228-27827-13-git-send-email-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Fixup from Eric squashed in]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2016-07-14 06:50:23 +03:00
|
|
|
if (net->nc->info->type == NET_CLIENT_DRIVER_TAP) {
|
2014-05-27 16:05:49 +04:00
|
|
|
qemu_set_fd_handler(net->backend, NULL, NULL, NULL);
|
|
|
|
file.fd = net->backend;
|
|
|
|
for (file.index = 0; file.index < net->dev.nvqs; ++file.index) {
|
2016-07-27 00:15:25 +03:00
|
|
|
r = vhost_net_set_backend(&net->dev, &file);
|
2014-05-27 16:05:49 +04:00
|
|
|
if (r < 0) {
|
|
|
|
r = -errno;
|
|
|
|
goto fail;
|
|
|
|
}
|
2010-03-17 14:08:17 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
fail:
|
|
|
|
file.fd = -1;
|
qapi: Change Netdev into a flat union
This is a mostly-mechanical conversion that creates a new flat
union 'Netdev' QAPI type that covers all the branches of the
former 'NetClientOptions' simple union, where the branches are
now listed in a new 'NetClientDriver' enum rather than generated
from the simple union. The existence of a flat union has no
change to the command line syntax accepted for new code, and
will make it possible for a future patch to switch the QMP
command to parse a boxed union for no change to valid QMP; but
it does have some ripple effect on the C code when dealing with
the new types.
While making the conversion, note that the 'NetLegacy' type
remains unchanged: it applies only to legacy command line options,
and will not be ported to QMP, so it should remain a wrapper
around a simple union; to avoid confusion, the type named
'NetClientOptions' is now gone, and we introduce 'NetLegacyOptions'
in its place. Then, in the C code, we convert from NetLegacy to
Netdev as soon as possible, so that the bulk of the net stack
only has to deal with one QAPI type, not two. Note that since
the old legacy code always rejected 'hubport', we can just omit
that branch from the new 'NetLegacyOptions' simple union.
Based on an idea originally by Zoltán Kővágó <DirtY.iCE.hu@gmail.com>:
Message-Id: <01a527fbf1a5de880091f98cf011616a78adeeee.1441627176.git.DirtY.iCE.hu@gmail.com>
although the sed script in that patch no longer applies due to
other changes in the tree since then, and I also did some manual
cleanups (such as fixing whitespace to keep checkpatch happy).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1468468228-27827-13-git-send-email-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Fixup from Eric squashed in]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2016-07-14 06:50:23 +03:00
|
|
|
if (net->nc->info->type == NET_CLIENT_DRIVER_TAP) {
|
2014-05-27 16:05:49 +04:00
|
|
|
while (file.index-- > 0) {
|
2016-07-27 00:15:25 +03:00
|
|
|
int r = vhost_net_set_backend(&net->dev, &file);
|
2014-05-27 16:05:49 +04:00
|
|
|
assert(r >= 0);
|
|
|
|
}
|
2010-03-17 14:08:17 +03:00
|
|
|
}
|
2014-05-27 16:04:55 +04:00
|
|
|
if (net->nc->info->poll) {
|
|
|
|
net->nc->info->poll(net->nc, true);
|
|
|
|
}
|
2010-03-17 14:08:17 +03:00
|
|
|
vhost_dev_stop(&net->dev, dev);
|
2011-08-11 11:21:18 +04:00
|
|
|
fail_start:
|
|
|
|
vhost_dev_disable_notifiers(&net->dev, dev);
|
|
|
|
fail_notifiers:
|
2010-03-17 14:08:17 +03:00
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
2013-01-30 15:12:35 +04:00
|
|
|
static void vhost_net_stop_one(struct vhost_net *net,
|
|
|
|
VirtIODevice *dev)
|
2010-03-17 14:08:17 +03:00
|
|
|
{
|
|
|
|
struct vhost_vring_file file = { .fd = -1 };
|
|
|
|
|
qapi: Change Netdev into a flat union
This is a mostly-mechanical conversion that creates a new flat
union 'Netdev' QAPI type that covers all the branches of the
former 'NetClientOptions' simple union, where the branches are
now listed in a new 'NetClientDriver' enum rather than generated
from the simple union. The existence of a flat union has no
change to the command line syntax accepted for new code, and
will make it possible for a future patch to switch the QMP
command to parse a boxed union for no change to valid QMP; but
it does have some ripple effect on the C code when dealing with
the new types.
While making the conversion, note that the 'NetLegacy' type
remains unchanged: it applies only to legacy command line options,
and will not be ported to QMP, so it should remain a wrapper
around a simple union; to avoid confusion, the type named
'NetClientOptions' is now gone, and we introduce 'NetLegacyOptions'
in its place. Then, in the C code, we convert from NetLegacy to
Netdev as soon as possible, so that the bulk of the net stack
only has to deal with one QAPI type, not two. Note that since
the old legacy code always rejected 'hubport', we can just omit
that branch from the new 'NetLegacyOptions' simple union.
Based on an idea originally by Zoltán Kővágó <DirtY.iCE.hu@gmail.com>:
Message-Id: <01a527fbf1a5de880091f98cf011616a78adeeee.1441627176.git.DirtY.iCE.hu@gmail.com>
although the sed script in that patch no longer applies due to
other changes in the tree since then, and I also did some manual
cleanups (such as fixing whitespace to keep checkpatch happy).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1468468228-27827-13-git-send-email-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Fixup from Eric squashed in]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2016-07-14 06:50:23 +03:00
|
|
|
if (net->nc->info->type == NET_CLIENT_DRIVER_TAP) {
|
2014-05-27 16:05:49 +04:00
|
|
|
for (file.index = 0; file.index < net->dev.nvqs; ++file.index) {
|
2016-07-27 00:15:25 +03:00
|
|
|
int r = vhost_net_set_backend(&net->dev, &file);
|
2014-05-27 16:05:49 +04:00
|
|
|
assert(r >= 0);
|
|
|
|
}
|
2010-03-17 14:08:17 +03:00
|
|
|
}
|
2014-05-27 16:04:55 +04:00
|
|
|
if (net->nc->info->poll) {
|
|
|
|
net->nc->info->poll(net->nc, true);
|
|
|
|
}
|
2010-03-17 14:08:17 +03:00
|
|
|
vhost_dev_stop(&net->dev, dev);
|
2011-08-11 11:21:18 +04:00
|
|
|
vhost_dev_disable_notifiers(&net->dev, dev);
|
2010-03-17 14:08:17 +03:00
|
|
|
}
|
|
|
|
|
2013-01-30 15:12:35 +04:00
|
|
|
int vhost_net_start(VirtIODevice *dev, NetClientState *ncs,
|
|
|
|
int total_queues)
|
|
|
|
{
|
2013-04-24 12:21:21 +04:00
|
|
|
BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(dev)));
|
|
|
|
VirtioBusState *vbus = VIRTIO_BUS(qbus);
|
|
|
|
VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(vbus);
|
2016-02-05 13:45:26 +03:00
|
|
|
int r, e, i;
|
2013-01-30 15:12:35 +04:00
|
|
|
|
2013-04-24 12:21:21 +04:00
|
|
|
if (!k->set_guest_notifiers) {
|
error: Strip trailing '\n' from error string arguments (again)
Commit 6daf194d and be62a2eb got rid of a bunch, but they keep coming
back. Tracked down with this Coccinelle semantic patch:
@r@
expression err, eno, cls, fmt;
position p;
@@
(
error_report(fmt, ...)@p
|
error_set(err, cls, fmt, ...)@p
|
error_set_errno(err, eno, cls, fmt, ...)@p
|
error_setg(err, fmt, ...)@p
|
error_setg_errno(err, eno, fmt, ...)@p
)
@script:python@
fmt << r.fmt;
p << r.p;
@@
if "\\n" in str(fmt):
print "%s:%s:%s:%s" % (p[0].file, p[0].line, p[0].column, fmt)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1360354939-10994-4-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2013-02-09 00:22:16 +04:00
|
|
|
error_report("binding does not support guest notifiers");
|
2016-01-13 22:26:25 +03:00
|
|
|
return -ENOSYS;
|
2013-01-30 15:12:35 +04:00
|
|
|
}
|
|
|
|
|
2016-02-05 13:45:26 +03:00
|
|
|
for (i = 0; i < total_queues; i++) {
|
2016-02-18 17:12:23 +03:00
|
|
|
struct vhost_net *net;
|
|
|
|
|
|
|
|
net = get_vhost_net(ncs[i].peer);
|
|
|
|
vhost_net_set_vq_index(net, i * 2);
|
|
|
|
|
|
|
|
/* Suppress the masking guest notifiers on vhost user
|
|
|
|
* because vhost user doesn't interrupt masking/unmasking
|
|
|
|
* properly.
|
|
|
|
*/
|
qapi: Change Netdev into a flat union
This is a mostly-mechanical conversion that creates a new flat
union 'Netdev' QAPI type that covers all the branches of the
former 'NetClientOptions' simple union, where the branches are
now listed in a new 'NetClientDriver' enum rather than generated
from the simple union. The existence of a flat union has no
change to the command line syntax accepted for new code, and
will make it possible for a future patch to switch the QMP
command to parse a boxed union for no change to valid QMP; but
it does have some ripple effect on the C code when dealing with
the new types.
While making the conversion, note that the 'NetLegacy' type
remains unchanged: it applies only to legacy command line options,
and will not be ported to QMP, so it should remain a wrapper
around a simple union; to avoid confusion, the type named
'NetClientOptions' is now gone, and we introduce 'NetLegacyOptions'
in its place. Then, in the C code, we convert from NetLegacy to
Netdev as soon as possible, so that the bulk of the net stack
only has to deal with one QAPI type, not two. Note that since
the old legacy code always rejected 'hubport', we can just omit
that branch from the new 'NetLegacyOptions' simple union.
Based on an idea originally by Zoltán Kővágó <DirtY.iCE.hu@gmail.com>:
Message-Id: <01a527fbf1a5de880091f98cf011616a78adeeee.1441627176.git.DirtY.iCE.hu@gmail.com>
although the sed script in that patch no longer applies due to
other changes in the tree since then, and I also did some manual
cleanups (such as fixing whitespace to keep checkpatch happy).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1468468228-27827-13-git-send-email-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Fixup from Eric squashed in]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2016-07-14 06:50:23 +03:00
|
|
|
if (net->nc->info->type == NET_CLIENT_DRIVER_VHOST_USER) {
|
2016-07-27 00:14:55 +03:00
|
|
|
dev->use_guest_notifier_mask = false;
|
2016-02-18 17:12:23 +03:00
|
|
|
}
|
|
|
|
}
|
2013-01-30 15:12:35 +04:00
|
|
|
|
2013-04-24 12:21:21 +04:00
|
|
|
r = k->set_guest_notifiers(qbus->parent, total_queues * 2, true);
|
2013-01-30 15:12:35 +04:00
|
|
|
if (r < 0) {
|
error: Strip trailing '\n' from error string arguments (again)
Commit 6daf194d and be62a2eb got rid of a bunch, but they keep coming
back. Tracked down with this Coccinelle semantic patch:
@r@
expression err, eno, cls, fmt;
position p;
@@
(
error_report(fmt, ...)@p
|
error_set(err, cls, fmt, ...)@p
|
error_set_errno(err, eno, cls, fmt, ...)@p
|
error_setg(err, fmt, ...)@p
|
error_setg_errno(err, eno, fmt, ...)@p
)
@script:python@
fmt << r.fmt;
p << r.p;
@@
if "\\n" in str(fmt):
print "%s:%s:%s:%s" % (p[0].file, p[0].line, p[0].column, fmt)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1360354939-10994-4-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2013-02-09 00:22:16 +04:00
|
|
|
error_report("Error binding guest notifier: %d", -r);
|
2016-02-05 13:45:26 +03:00
|
|
|
goto err;
|
2013-01-30 15:12:35 +04:00
|
|
|
}
|
|
|
|
|
2014-08-19 08:56:29 +04:00
|
|
|
for (i = 0; i < total_queues; i++) {
|
|
|
|
r = vhost_net_start_one(get_vhost_net(ncs[i].peer), dev);
|
|
|
|
|
|
|
|
if (r < 0) {
|
|
|
|
goto err_start;
|
|
|
|
}
|
2016-06-06 19:45:06 +03:00
|
|
|
|
|
|
|
if (ncs[i].peer->vring_enable) {
|
|
|
|
/* restore vring enable state */
|
|
|
|
r = vhost_set_vring_enable(ncs[i].peer, ncs[i].peer->vring_enable);
|
|
|
|
|
|
|
|
if (r < 0) {
|
|
|
|
goto err_start;
|
|
|
|
}
|
|
|
|
}
|
2014-08-19 08:56:29 +04:00
|
|
|
}
|
|
|
|
|
2013-01-30 15:12:35 +04:00
|
|
|
return 0;
|
|
|
|
|
2014-08-19 08:56:29 +04:00
|
|
|
err_start:
|
2013-01-30 15:12:35 +04:00
|
|
|
while (--i >= 0) {
|
2014-05-27 16:05:08 +04:00
|
|
|
vhost_net_stop_one(get_vhost_net(ncs[i].peer), dev);
|
2013-01-30 15:12:35 +04:00
|
|
|
}
|
2014-08-19 08:56:29 +04:00
|
|
|
e = k->set_guest_notifiers(qbus->parent, total_queues * 2, false);
|
|
|
|
if (e < 0) {
|
|
|
|
fprintf(stderr, "vhost guest notifier cleanup failed: %d\n", e);
|
|
|
|
fflush(stderr);
|
|
|
|
}
|
2016-02-05 13:45:26 +03:00
|
|
|
err:
|
2013-01-30 15:12:35 +04:00
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
void vhost_net_stop(VirtIODevice *dev, NetClientState *ncs,
|
|
|
|
int total_queues)
|
|
|
|
{
|
2013-04-24 12:21:21 +04:00
|
|
|
BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(dev)));
|
|
|
|
VirtioBusState *vbus = VIRTIO_BUS(qbus);
|
|
|
|
VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(vbus);
|
2013-01-30 15:12:35 +04:00
|
|
|
int i, r;
|
|
|
|
|
2014-08-19 08:56:29 +04:00
|
|
|
for (i = 0; i < total_queues; i++) {
|
|
|
|
vhost_net_stop_one(get_vhost_net(ncs[i].peer), dev);
|
|
|
|
}
|
|
|
|
|
2013-04-24 12:21:21 +04:00
|
|
|
r = k->set_guest_notifiers(qbus->parent, total_queues * 2, false);
|
2013-01-30 15:12:35 +04:00
|
|
|
if (r < 0) {
|
|
|
|
fprintf(stderr, "vhost guest notifier cleanup failed: %d\n", r);
|
|
|
|
fflush(stderr);
|
|
|
|
}
|
|
|
|
assert(r >= 0);
|
|
|
|
}
|
|
|
|
|
2010-03-17 14:08:17 +03:00
|
|
|
void vhost_net_cleanup(struct vhost_net *net)
|
|
|
|
{
|
|
|
|
vhost_dev_cleanup(&net->dev);
|
|
|
|
}
|
2012-12-24 19:37:01 +04:00
|
|
|
|
2015-10-09 18:17:32 +03:00
|
|
|
int vhost_net_notify_migration_done(struct vhost_net *net, char* mac_addr)
|
|
|
|
{
|
|
|
|
const VhostOps *vhost_ops = net->dev.vhost_ops;
|
|
|
|
|
2016-07-27 00:15:15 +03:00
|
|
|
assert(vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER);
|
|
|
|
assert(vhost_ops->vhost_migration_done);
|
2015-10-09 18:17:32 +03:00
|
|
|
|
2016-07-27 00:15:15 +03:00
|
|
|
return vhost_ops->vhost_migration_done(&net->dev, mac_addr);
|
2015-10-09 18:17:32 +03:00
|
|
|
}
|
|
|
|
|
2012-12-24 19:37:01 +04:00
|
|
|
bool vhost_net_virtqueue_pending(VHostNetState *net, int idx)
|
|
|
|
{
|
|
|
|
return vhost_virtqueue_pending(&net->dev, idx);
|
|
|
|
}
|
|
|
|
|
|
|
|
void vhost_net_virtqueue_mask(VHostNetState *net, VirtIODevice *dev,
|
|
|
|
int idx, bool mask)
|
|
|
|
{
|
|
|
|
vhost_virtqueue_mask(&net->dev, dev, idx, mask);
|
|
|
|
}
|
2014-05-27 16:05:08 +04:00
|
|
|
|
|
|
|
VHostNetState *get_vhost_net(NetClientState *nc)
|
|
|
|
{
|
|
|
|
VHostNetState *vhost_net = 0;
|
|
|
|
|
|
|
|
if (!nc) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (nc->info->type) {
|
qapi: Change Netdev into a flat union
This is a mostly-mechanical conversion that creates a new flat
union 'Netdev' QAPI type that covers all the branches of the
former 'NetClientOptions' simple union, where the branches are
now listed in a new 'NetClientDriver' enum rather than generated
from the simple union. The existence of a flat union has no
change to the command line syntax accepted for new code, and
will make it possible for a future patch to switch the QMP
command to parse a boxed union for no change to valid QMP; but
it does have some ripple effect on the C code when dealing with
the new types.
While making the conversion, note that the 'NetLegacy' type
remains unchanged: it applies only to legacy command line options,
and will not be ported to QMP, so it should remain a wrapper
around a simple union; to avoid confusion, the type named
'NetClientOptions' is now gone, and we introduce 'NetLegacyOptions'
in its place. Then, in the C code, we convert from NetLegacy to
Netdev as soon as possible, so that the bulk of the net stack
only has to deal with one QAPI type, not two. Note that since
the old legacy code always rejected 'hubport', we can just omit
that branch from the new 'NetLegacyOptions' simple union.
Based on an idea originally by Zoltán Kővágó <DirtY.iCE.hu@gmail.com>:
Message-Id: <01a527fbf1a5de880091f98cf011616a78adeeee.1441627176.git.DirtY.iCE.hu@gmail.com>
although the sed script in that patch no longer applies due to
other changes in the tree since then, and I also did some manual
cleanups (such as fixing whitespace to keep checkpatch happy).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1468468228-27827-13-git-send-email-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Fixup from Eric squashed in]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2016-07-14 06:50:23 +03:00
|
|
|
case NET_CLIENT_DRIVER_TAP:
|
2014-05-27 16:05:08 +04:00
|
|
|
vhost_net = tap_get_vhost_net(nc);
|
|
|
|
break;
|
2019-02-14 20:35:49 +03:00
|
|
|
#ifdef CONFIG_VHOST_NET_USER
|
qapi: Change Netdev into a flat union
This is a mostly-mechanical conversion that creates a new flat
union 'Netdev' QAPI type that covers all the branches of the
former 'NetClientOptions' simple union, where the branches are
now listed in a new 'NetClientDriver' enum rather than generated
from the simple union. The existence of a flat union has no
change to the command line syntax accepted for new code, and
will make it possible for a future patch to switch the QMP
command to parse a boxed union for no change to valid QMP; but
it does have some ripple effect on the C code when dealing with
the new types.
While making the conversion, note that the 'NetLegacy' type
remains unchanged: it applies only to legacy command line options,
and will not be ported to QMP, so it should remain a wrapper
around a simple union; to avoid confusion, the type named
'NetClientOptions' is now gone, and we introduce 'NetLegacyOptions'
in its place. Then, in the C code, we convert from NetLegacy to
Netdev as soon as possible, so that the bulk of the net stack
only has to deal with one QAPI type, not two. Note that since
the old legacy code always rejected 'hubport', we can just omit
that branch from the new 'NetLegacyOptions' simple union.
Based on an idea originally by Zoltán Kővágó <DirtY.iCE.hu@gmail.com>:
Message-Id: <01a527fbf1a5de880091f98cf011616a78adeeee.1441627176.git.DirtY.iCE.hu@gmail.com>
although the sed script in that patch no longer applies due to
other changes in the tree since then, and I also did some manual
cleanups (such as fixing whitespace to keep checkpatch happy).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1468468228-27827-13-git-send-email-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Fixup from Eric squashed in]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2016-07-14 06:50:23 +03:00
|
|
|
case NET_CLIENT_DRIVER_VHOST_USER:
|
2014-06-10 14:02:16 +04:00
|
|
|
vhost_net = vhost_user_get_vhost_net(nc);
|
2016-07-27 00:15:13 +03:00
|
|
|
assert(vhost_net);
|
2014-06-10 14:02:16 +04:00
|
|
|
break;
|
2019-02-14 20:35:49 +03:00
|
|
|
#endif
|
2014-05-27 16:05:08 +04:00
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return vhost_net;
|
|
|
|
}
|
2015-09-23 07:20:01 +03:00
|
|
|
|
|
|
|
int vhost_set_vring_enable(NetClientState *nc, int enable)
|
|
|
|
{
|
|
|
|
VHostNetState *net = get_vhost_net(nc);
|
2016-07-27 00:15:14 +03:00
|
|
|
const VhostOps *vhost_ops = net->dev.vhost_ops;
|
2016-06-06 19:45:04 +03:00
|
|
|
|
2016-06-06 19:45:06 +03:00
|
|
|
nc->vring_enable = enable;
|
|
|
|
|
2016-08-03 08:22:49 +03:00
|
|
|
if (vhost_ops && vhost_ops->vhost_set_vring_enable) {
|
2015-10-09 18:17:28 +03:00
|
|
|
return vhost_ops->vhost_set_vring_enable(&net->dev, enable);
|
2015-09-23 07:20:01 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-12-10 18:30:37 +03:00
|
|
|
int vhost_net_set_mtu(struct vhost_net *net, uint16_t mtu)
|
|
|
|
{
|
|
|
|
const VhostOps *vhost_ops = net->dev.vhost_ops;
|
|
|
|
|
|
|
|
if (!vhost_ops->vhost_net_set_mtu) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
return vhost_ops->vhost_net_set_mtu(&net->dev, mtu);
|
|
|
|
}
|