2008-12-04 22:52:44 +03:00
|
|
|
/*
|
|
|
|
* Virtio Block Device
|
|
|
|
*
|
|
|
|
* Copyright IBM, Corp. 2007
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Anthony Liguori <aliguori@us.ibm.com>
|
|
|
|
*
|
|
|
|
* This work is licensed under the terms of the GNU GPL, version 2. See
|
|
|
|
* the COPYING file in the top-level directory.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
2011-09-08 19:55:32 +04:00
|
|
|
#include "qemu-common.h"
|
2014-06-11 08:11:48 +04:00
|
|
|
#include "qemu/iov.h"
|
2012-12-17 21:20:00 +04:00
|
|
|
#include "qemu/error-report.h"
|
2010-05-22 21:15:08 +04:00
|
|
|
#include "trace.h"
|
2013-02-05 20:06:20 +04:00
|
|
|
#include "hw/block/block.h"
|
2012-12-17 21:20:04 +04:00
|
|
|
#include "sysemu/blockdev.h"
|
2013-02-05 20:06:20 +04:00
|
|
|
#include "hw/virtio/virtio-blk.h"
|
2014-09-10 10:17:51 +04:00
|
|
|
#include "dataplane/virtio-blk.h"
|
|
|
|
#include "migration/migration.h"
|
2013-02-05 20:06:20 +04:00
|
|
|
#include "block/scsi.h"
|
2009-04-27 12:29:14 +04:00
|
|
|
#ifdef __linux__
|
|
|
|
# include <scsi/sg.h>
|
|
|
|
#endif
|
2013-02-05 20:06:20 +04:00
|
|
|
#include "hw/virtio/virtio-bus.h"
|
2014-06-24 21:43:44 +04:00
|
|
|
#include "hw/virtio/virtio-access.h"
|
2008-12-04 22:52:44 +03:00
|
|
|
|
2014-07-09 12:05:49 +04:00
|
|
|
VirtIOBlockReq *virtio_blk_alloc_request(VirtIOBlock *s)
|
2014-06-11 08:11:43 +04:00
|
|
|
{
|
2014-07-09 12:05:48 +04:00
|
|
|
VirtIOBlockReq *req = g_slice_new(VirtIOBlockReq);
|
2014-06-11 08:11:43 +04:00
|
|
|
req->dev = s;
|
2014-07-09 12:05:48 +04:00
|
|
|
req->qiov.size = 0;
|
|
|
|
req->next = NULL;
|
2014-06-11 08:11:43 +04:00
|
|
|
return req;
|
|
|
|
}
|
|
|
|
|
2014-07-09 12:05:49 +04:00
|
|
|
void virtio_blk_free_request(VirtIOBlockReq *req)
|
2014-06-11 08:11:43 +04:00
|
|
|
{
|
|
|
|
if (req) {
|
|
|
|
g_slice_free(VirtIOBlockReq, req);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-06-17 10:32:06 +04:00
|
|
|
static void virtio_blk_complete_request(VirtIOBlockReq *req,
|
|
|
|
unsigned char status)
|
2009-01-22 22:52:25 +03:00
|
|
|
{
|
|
|
|
VirtIOBlock *s = req->dev;
|
2013-03-18 20:37:27 +04:00
|
|
|
VirtIODevice *vdev = VIRTIO_DEVICE(s);
|
2009-01-22 22:52:25 +03:00
|
|
|
|
2010-05-22 21:15:08 +04:00
|
|
|
trace_virtio_blk_req_complete(req, status);
|
|
|
|
|
2011-01-25 13:55:14 +03:00
|
|
|
stb_p(&req->in->status, status);
|
2014-07-09 12:05:49 +04:00
|
|
|
virtqueue_push(s->vq, &req->elem, req->qiov.size + sizeof(*req->in));
|
2013-03-18 20:37:27 +04:00
|
|
|
virtio_notify(vdev, s->vq);
|
2009-01-22 22:52:25 +03:00
|
|
|
}
|
|
|
|
|
2014-06-17 10:32:06 +04:00
|
|
|
static void virtio_blk_req_complete(VirtIOBlockReq *req, unsigned char status)
|
|
|
|
{
|
|
|
|
req->dev->complete_request(req, status);
|
|
|
|
}
|
|
|
|
|
2009-11-27 15:25:39 +03:00
|
|
|
static int virtio_blk_handle_rw_error(VirtIOBlockReq *req, int error,
|
2012-09-28 19:22:56 +04:00
|
|
|
bool is_read)
|
2009-01-22 22:52:25 +03:00
|
|
|
{
|
2012-09-28 19:22:57 +04:00
|
|
|
BlockErrorAction action = bdrv_get_error_action(req->dev->bs, is_read, error);
|
2009-01-22 22:52:25 +03:00
|
|
|
VirtIOBlock *s = req->dev;
|
|
|
|
|
2014-06-18 10:43:30 +04:00
|
|
|
if (action == BLOCK_ERROR_ACTION_STOP) {
|
2009-01-22 22:52:25 +03:00
|
|
|
req->next = s->rq;
|
|
|
|
s->rq = req;
|
2014-06-18 10:43:30 +04:00
|
|
|
} else if (action == BLOCK_ERROR_ACTION_REPORT) {
|
2009-01-22 22:52:25 +03:00
|
|
|
virtio_blk_req_complete(req, VIRTIO_BLK_S_IOERR);
|
2014-09-05 17:46:18 +04:00
|
|
|
block_acct_done(bdrv_get_stats(s->bs), &req->acct);
|
2014-06-11 08:11:43 +04:00
|
|
|
virtio_blk_free_request(req);
|
2009-01-22 22:52:25 +03:00
|
|
|
}
|
|
|
|
|
2012-09-28 19:22:57 +04:00
|
|
|
bdrv_error_action(s->bs, action, is_read, error);
|
2014-06-18 10:43:30 +04:00
|
|
|
return action != BLOCK_ERROR_ACTION_IGNORE;
|
2009-01-22 22:52:25 +03:00
|
|
|
}
|
|
|
|
|
2008-12-04 22:52:44 +03:00
|
|
|
static void virtio_blk_rw_complete(void *opaque, int ret)
|
|
|
|
{
|
|
|
|
VirtIOBlockReq *req = opaque;
|
|
|
|
|
2010-05-22 21:15:08 +04:00
|
|
|
trace_virtio_blk_rw_complete(req, ret);
|
|
|
|
|
2009-11-27 15:25:39 +03:00
|
|
|
if (ret) {
|
2014-06-24 21:43:44 +04:00
|
|
|
int p = virtio_ldl_p(VIRTIO_DEVICE(req->dev), &req->out.type);
|
|
|
|
bool is_read = !(p & VIRTIO_BLK_T_OUT);
|
2009-11-27 15:25:39 +03:00
|
|
|
if (virtio_blk_handle_rw_error(req, -ret, is_read))
|
2009-01-22 22:52:25 +03:00
|
|
|
return;
|
2008-12-04 22:52:44 +03:00
|
|
|
}
|
|
|
|
|
2009-11-27 15:25:39 +03:00
|
|
|
virtio_blk_req_complete(req, VIRTIO_BLK_S_OK);
|
2014-09-05 17:46:18 +04:00
|
|
|
block_acct_done(bdrv_get_stats(req->dev->bs), &req->acct);
|
2014-06-11 08:11:43 +04:00
|
|
|
virtio_blk_free_request(req);
|
2009-01-22 22:52:25 +03:00
|
|
|
}
|
2008-12-04 22:52:44 +03:00
|
|
|
|
2009-09-04 21:02:23 +04:00
|
|
|
static void virtio_blk_flush_complete(void *opaque, int ret)
|
|
|
|
{
|
|
|
|
VirtIOBlockReq *req = opaque;
|
|
|
|
|
2010-10-20 15:17:30 +04:00
|
|
|
if (ret) {
|
|
|
|
if (virtio_blk_handle_rw_error(req, -ret, 0)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
virtio_blk_req_complete(req, VIRTIO_BLK_S_OK);
|
2014-09-05 17:46:18 +04:00
|
|
|
block_acct_done(bdrv_get_stats(req->dev->bs), &req->acct);
|
2014-06-11 08:11:43 +04:00
|
|
|
virtio_blk_free_request(req);
|
2008-12-04 22:52:44 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static VirtIOBlockReq *virtio_blk_get_request(VirtIOBlock *s)
|
|
|
|
{
|
2009-01-22 22:52:25 +03:00
|
|
|
VirtIOBlockReq *req = virtio_blk_alloc_request(s);
|
2008-12-04 22:52:44 +03:00
|
|
|
|
2014-07-09 12:05:49 +04:00
|
|
|
if (!virtqueue_pop(s->vq, &req->elem)) {
|
2014-06-11 08:11:43 +04:00
|
|
|
virtio_blk_free_request(req);
|
|
|
|
return NULL;
|
2008-12-04 22:52:44 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
return req;
|
|
|
|
}
|
|
|
|
|
2014-05-22 12:22:42 +04:00
|
|
|
int virtio_blk_handle_scsi_req(VirtIOBlock *blk,
|
|
|
|
VirtQueueElement *elem)
|
2009-04-27 12:29:14 +04:00
|
|
|
{
|
2014-05-22 12:22:42 +04:00
|
|
|
int status = VIRTIO_BLK_S_OK;
|
|
|
|
struct virtio_scsi_inhdr *scsi = NULL;
|
2014-06-24 21:43:44 +04:00
|
|
|
VirtIODevice *vdev = VIRTIO_DEVICE(blk);
|
|
|
|
|
2012-05-23 01:23:32 +04:00
|
|
|
#ifdef __linux__
|
2009-04-27 12:29:14 +04:00
|
|
|
int i;
|
2014-05-22 12:22:42 +04:00
|
|
|
struct sg_io_hdr hdr;
|
2012-05-23 01:23:32 +04:00
|
|
|
#endif
|
2009-04-27 12:29:14 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We require at least one output segment each for the virtio_blk_outhdr
|
|
|
|
* and the SCSI command block.
|
|
|
|
*
|
|
|
|
* We also at least require the virtio_blk_inhdr, the virtio_scsi_inhdr
|
|
|
|
* and the sense buffer pointer in the input segments.
|
|
|
|
*/
|
2014-05-22 12:22:42 +04:00
|
|
|
if (elem->out_num < 2 || elem->in_num < 3) {
|
|
|
|
status = VIRTIO_BLK_S_IOERR;
|
|
|
|
goto fail;
|
2009-04-27 12:29:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2012-05-16 14:54:03 +04:00
|
|
|
* The scsi inhdr is placed in the second-to-last input segment, just
|
|
|
|
* before the regular inhdr.
|
2009-04-27 12:29:14 +04:00
|
|
|
*/
|
2014-05-22 12:22:42 +04:00
|
|
|
scsi = (void *)elem->in_sg[elem->in_num - 2].iov_base;
|
2012-05-16 14:54:03 +04:00
|
|
|
|
2014-05-22 12:22:42 +04:00
|
|
|
if (!blk->blk.scsi) {
|
2012-05-16 14:54:03 +04:00
|
|
|
status = VIRTIO_BLK_S_UNSUPP;
|
|
|
|
goto fail;
|
2009-04-27 12:29:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2012-05-16 14:54:03 +04:00
|
|
|
* No support for bidirection commands yet.
|
2009-04-27 12:29:14 +04:00
|
|
|
*/
|
2014-05-22 12:22:42 +04:00
|
|
|
if (elem->out_num > 2 && elem->in_num > 3) {
|
2012-05-16 14:54:03 +04:00
|
|
|
status = VIRTIO_BLK_S_UNSUPP;
|
|
|
|
goto fail;
|
|
|
|
}
|
2009-04-27 12:29:14 +04:00
|
|
|
|
2012-05-16 14:54:03 +04:00
|
|
|
#ifdef __linux__
|
2009-04-27 12:29:14 +04:00
|
|
|
memset(&hdr, 0, sizeof(struct sg_io_hdr));
|
|
|
|
hdr.interface_id = 'S';
|
2014-05-22 12:22:42 +04:00
|
|
|
hdr.cmd_len = elem->out_sg[1].iov_len;
|
|
|
|
hdr.cmdp = elem->out_sg[1].iov_base;
|
2009-04-27 12:29:14 +04:00
|
|
|
hdr.dxfer_len = 0;
|
|
|
|
|
2014-05-22 12:22:42 +04:00
|
|
|
if (elem->out_num > 2) {
|
2009-04-27 12:29:14 +04:00
|
|
|
/*
|
|
|
|
* If there are more than the minimally required 2 output segments
|
|
|
|
* there is write payload starting from the third iovec.
|
|
|
|
*/
|
|
|
|
hdr.dxfer_direction = SG_DXFER_TO_DEV;
|
2014-05-22 12:22:42 +04:00
|
|
|
hdr.iovec_count = elem->out_num - 2;
|
2009-04-27 12:29:14 +04:00
|
|
|
|
|
|
|
for (i = 0; i < hdr.iovec_count; i++)
|
2014-05-22 12:22:42 +04:00
|
|
|
hdr.dxfer_len += elem->out_sg[i + 2].iov_len;
|
2009-04-27 12:29:14 +04:00
|
|
|
|
2014-05-22 12:22:42 +04:00
|
|
|
hdr.dxferp = elem->out_sg + 2;
|
2009-04-27 12:29:14 +04:00
|
|
|
|
2014-05-22 12:22:42 +04:00
|
|
|
} else if (elem->in_num > 3) {
|
2009-04-27 12:29:14 +04:00
|
|
|
/*
|
|
|
|
* If we have more than 3 input segments the guest wants to actually
|
|
|
|
* read data.
|
|
|
|
*/
|
|
|
|
hdr.dxfer_direction = SG_DXFER_FROM_DEV;
|
2014-05-22 12:22:42 +04:00
|
|
|
hdr.iovec_count = elem->in_num - 3;
|
2009-04-27 12:29:14 +04:00
|
|
|
for (i = 0; i < hdr.iovec_count; i++)
|
2014-05-22 12:22:42 +04:00
|
|
|
hdr.dxfer_len += elem->in_sg[i].iov_len;
|
2009-04-27 12:29:14 +04:00
|
|
|
|
2014-05-22 12:22:42 +04:00
|
|
|
hdr.dxferp = elem->in_sg;
|
2009-04-27 12:29:14 +04:00
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* Some SCSI commands don't actually transfer any data.
|
|
|
|
*/
|
|
|
|
hdr.dxfer_direction = SG_DXFER_NONE;
|
|
|
|
}
|
|
|
|
|
2014-05-22 12:22:42 +04:00
|
|
|
hdr.sbp = elem->in_sg[elem->in_num - 3].iov_base;
|
|
|
|
hdr.mx_sb_len = elem->in_sg[elem->in_num - 3].iov_len;
|
2009-04-27 12:29:14 +04:00
|
|
|
|
2014-05-22 12:22:42 +04:00
|
|
|
status = bdrv_ioctl(blk->bs, SG_IO, &hdr);
|
|
|
|
if (status) {
|
2009-04-27 12:29:14 +04:00
|
|
|
status = VIRTIO_BLK_S_UNSUPP;
|
2012-05-16 14:54:03 +04:00
|
|
|
goto fail;
|
2009-04-27 12:29:14 +04:00
|
|
|
}
|
|
|
|
|
2011-11-02 16:19:40 +04:00
|
|
|
/*
|
|
|
|
* From SCSI-Generic-HOWTO: "Some lower level drivers (e.g. ide-scsi)
|
|
|
|
* clear the masked_status field [hence status gets cleared too, see
|
|
|
|
* block/scsi_ioctl.c] even when a CHECK_CONDITION or COMMAND_TERMINATED
|
|
|
|
* status has occurred. However they do set DRIVER_SENSE in driver_status
|
|
|
|
* field. Also a (sb_len_wr > 0) indicates there is a sense buffer.
|
|
|
|
*/
|
|
|
|
if (hdr.status == 0 && hdr.sb_len_wr > 0) {
|
|
|
|
hdr.status = CHECK_CONDITION;
|
|
|
|
}
|
|
|
|
|
2014-06-24 21:43:44 +04:00
|
|
|
virtio_stl_p(vdev, &scsi->errors,
|
|
|
|
hdr.status | (hdr.msg_status << 8) |
|
|
|
|
(hdr.host_status << 16) | (hdr.driver_status << 24));
|
|
|
|
virtio_stl_p(vdev, &scsi->residual, hdr.resid);
|
|
|
|
virtio_stl_p(vdev, &scsi->sense_len, hdr.sb_len_wr);
|
|
|
|
virtio_stl_p(vdev, &scsi->data_len, hdr.dxfer_len);
|
2009-04-27 12:29:14 +04:00
|
|
|
|
2014-05-22 12:22:42 +04:00
|
|
|
return status;
|
2009-04-27 12:29:14 +04:00
|
|
|
#else
|
2012-05-16 14:54:03 +04:00
|
|
|
abort();
|
|
|
|
#endif
|
|
|
|
|
|
|
|
fail:
|
|
|
|
/* Just put anything nonzero so that the ioctl fails in the guest. */
|
2014-05-22 12:22:42 +04:00
|
|
|
if (scsi) {
|
2014-06-24 21:43:44 +04:00
|
|
|
virtio_stl_p(vdev, &scsi->errors, 255);
|
2014-05-22 12:22:42 +04:00
|
|
|
}
|
|
|
|
return status;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void virtio_blk_handle_scsi(VirtIOBlockReq *req)
|
|
|
|
{
|
|
|
|
int status;
|
|
|
|
|
2014-07-09 12:05:49 +04:00
|
|
|
status = virtio_blk_handle_scsi_req(req->dev, &req->elem);
|
2012-05-16 14:54:03 +04:00
|
|
|
virtio_blk_req_complete(req, status);
|
2014-06-11 08:11:43 +04:00
|
|
|
virtio_blk_free_request(req);
|
2009-04-27 12:29:14 +04:00
|
|
|
}
|
|
|
|
|
2014-06-17 10:32:07 +04:00
|
|
|
void virtio_submit_multiwrite(BlockDriverState *bs, MultiReqBuffer *mrb)
|
2009-01-22 22:52:25 +03:00
|
|
|
{
|
2009-09-09 19:53:38 +04:00
|
|
|
int i, ret;
|
|
|
|
|
2010-06-08 20:26:07 +04:00
|
|
|
if (!mrb->num_writes) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = bdrv_aio_multiwrite(bs, mrb->blkreq, mrb->num_writes);
|
2009-09-09 19:53:38 +04:00
|
|
|
if (ret != 0) {
|
2010-06-08 20:26:07 +04:00
|
|
|
for (i = 0; i < mrb->num_writes; i++) {
|
|
|
|
if (mrb->blkreq[i].error) {
|
|
|
|
virtio_blk_rw_complete(mrb->blkreq[i].opaque, -EIO);
|
2009-09-09 19:53:38 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2010-06-08 20:26:07 +04:00
|
|
|
|
|
|
|
mrb->num_writes = 0;
|
2009-09-09 19:53:38 +04:00
|
|
|
}
|
2009-08-13 18:49:56 +04:00
|
|
|
|
2010-06-08 20:26:07 +04:00
|
|
|
static void virtio_blk_handle_flush(VirtIOBlockReq *req, MultiReqBuffer *mrb)
|
2009-09-04 21:02:23 +04:00
|
|
|
{
|
2014-09-05 17:46:18 +04:00
|
|
|
block_acct_start(bdrv_get_stats(req->dev->bs), &req->acct, 0,
|
|
|
|
BLOCK_ACCT_FLUSH);
|
2011-08-25 10:26:01 +04:00
|
|
|
|
2010-05-19 14:40:09 +04:00
|
|
|
/*
|
|
|
|
* Make sure all outstanding writes are posted to the backing device.
|
|
|
|
*/
|
2010-06-08 20:26:07 +04:00
|
|
|
virtio_submit_multiwrite(req->dev->bs, mrb);
|
2011-11-30 12:12:30 +04:00
|
|
|
bdrv_aio_flush(req->dev->bs, virtio_blk_flush_complete, req);
|
2009-09-04 21:02:23 +04:00
|
|
|
}
|
|
|
|
|
2014-07-09 21:07:29 +04:00
|
|
|
static bool virtio_blk_sect_range_ok(VirtIOBlock *dev,
|
|
|
|
uint64_t sector, size_t size)
|
|
|
|
{
|
2014-07-09 21:07:31 +04:00
|
|
|
uint64_t nb_sectors = size >> BDRV_SECTOR_BITS;
|
|
|
|
uint64_t total_sectors;
|
|
|
|
|
2014-07-09 21:07:29 +04:00
|
|
|
if (sector & dev->sector_mask) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
if (size % dev->conf->logical_block_size) {
|
|
|
|
return false;
|
|
|
|
}
|
2014-07-09 21:07:31 +04:00
|
|
|
bdrv_get_geometry(dev->bs, &total_sectors);
|
|
|
|
if (sector > total_sectors || nb_sectors > total_sectors - sector) {
|
|
|
|
return false;
|
|
|
|
}
|
2014-07-09 21:07:29 +04:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2010-06-08 20:26:07 +04:00
|
|
|
static void virtio_blk_handle_write(VirtIOBlockReq *req, MultiReqBuffer *mrb)
|
2009-09-09 19:53:38 +04:00
|
|
|
{
|
2010-06-08 20:26:07 +04:00
|
|
|
BlockRequest *blkreq;
|
2011-01-25 13:55:14 +03:00
|
|
|
uint64_t sector;
|
2010-06-08 20:26:07 +04:00
|
|
|
|
2014-06-24 21:43:44 +04:00
|
|
|
sector = virtio_ldq_p(VIRTIO_DEVICE(req->dev), &req->out.sector);
|
2010-05-22 21:15:08 +04:00
|
|
|
|
2011-01-25 13:55:14 +03:00
|
|
|
trace_virtio_blk_handle_write(req, sector, req->qiov.size / 512);
|
|
|
|
|
2014-07-09 21:07:29 +04:00
|
|
|
if (!virtio_blk_sect_range_ok(req->dev, sector, req->qiov.size)) {
|
2014-07-09 21:07:30 +04:00
|
|
|
virtio_blk_req_complete(req, VIRTIO_BLK_S_IOERR);
|
|
|
|
virtio_blk_free_request(req);
|
2011-04-06 22:28:34 +04:00
|
|
|
return;
|
|
|
|
}
|
2010-03-04 16:20:17 +03:00
|
|
|
|
2014-09-05 17:46:18 +04:00
|
|
|
block_acct_start(bdrv_get_stats(req->dev->bs), &req->acct, req->qiov.size,
|
|
|
|
BLOCK_ACCT_WRITE);
|
2014-07-09 21:07:30 +04:00
|
|
|
|
2010-06-08 20:26:07 +04:00
|
|
|
if (mrb->num_writes == 32) {
|
|
|
|
virtio_submit_multiwrite(req->dev->bs, mrb);
|
2009-08-13 18:49:56 +04:00
|
|
|
}
|
2009-09-09 19:53:38 +04:00
|
|
|
|
2010-06-08 20:26:07 +04:00
|
|
|
blkreq = &mrb->blkreq[mrb->num_writes];
|
2011-01-25 13:55:14 +03:00
|
|
|
blkreq->sector = sector;
|
2010-06-08 20:26:07 +04:00
|
|
|
blkreq->nb_sectors = req->qiov.size / BDRV_SECTOR_SIZE;
|
|
|
|
blkreq->qiov = &req->qiov;
|
|
|
|
blkreq->cb = virtio_blk_rw_complete;
|
|
|
|
blkreq->opaque = req;
|
|
|
|
blkreq->error = 0;
|
2009-09-09 19:53:38 +04:00
|
|
|
|
2010-06-08 20:26:07 +04:00
|
|
|
mrb->num_writes++;
|
2009-03-28 20:46:14 +03:00
|
|
|
}
|
2009-01-22 22:52:25 +03:00
|
|
|
|
2009-03-28 20:46:14 +03:00
|
|
|
static void virtio_blk_handle_read(VirtIOBlockReq *req)
|
|
|
|
{
|
2011-01-25 13:55:14 +03:00
|
|
|
uint64_t sector;
|
|
|
|
|
2014-06-24 21:43:44 +04:00
|
|
|
sector = virtio_ldq_p(VIRTIO_DEVICE(req->dev), &req->out.sector);
|
2009-08-13 18:49:56 +04:00
|
|
|
|
2011-12-22 17:17:02 +04:00
|
|
|
trace_virtio_blk_handle_read(req, sector, req->qiov.size / 512);
|
|
|
|
|
2014-07-09 21:07:29 +04:00
|
|
|
if (!virtio_blk_sect_range_ok(req->dev, sector, req->qiov.size)) {
|
2014-07-09 21:07:30 +04:00
|
|
|
virtio_blk_req_complete(req, VIRTIO_BLK_S_IOERR);
|
|
|
|
virtio_blk_free_request(req);
|
2011-04-06 22:28:34 +04:00
|
|
|
return;
|
|
|
|
}
|
2014-07-09 21:07:30 +04:00
|
|
|
|
2014-09-05 17:46:18 +04:00
|
|
|
block_acct_start(bdrv_get_stats(req->dev->bs), &req->acct, req->qiov.size,
|
|
|
|
BLOCK_ACCT_READ);
|
2011-11-30 12:12:30 +04:00
|
|
|
bdrv_aio_readv(req->dev->bs, sector, &req->qiov,
|
|
|
|
req->qiov.size / BDRV_SECTOR_SIZE,
|
|
|
|
virtio_blk_rw_complete, req);
|
2009-01-22 22:52:25 +03:00
|
|
|
}
|
|
|
|
|
2014-06-17 10:32:07 +04:00
|
|
|
void virtio_blk_handle_request(VirtIOBlockReq *req, MultiReqBuffer *mrb)
|
2010-01-27 15:12:34 +03:00
|
|
|
{
|
2011-01-25 13:55:14 +03:00
|
|
|
uint32_t type;
|
2014-07-09 12:05:49 +04:00
|
|
|
struct iovec *in_iov = req->elem.in_sg;
|
|
|
|
struct iovec *iov = req->elem.out_sg;
|
|
|
|
unsigned in_num = req->elem.in_num;
|
|
|
|
unsigned out_num = req->elem.out_num;
|
2011-01-25 13:55:14 +03:00
|
|
|
|
2014-07-09 12:05:49 +04:00
|
|
|
if (req->elem.out_num < 1 || req->elem.in_num < 1) {
|
2010-11-15 23:44:35 +03:00
|
|
|
error_report("virtio-blk missing headers");
|
2010-01-27 15:12:34 +03:00
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
|
2014-06-11 08:11:48 +04:00
|
|
|
if (unlikely(iov_to_buf(iov, out_num, 0, &req->out,
|
|
|
|
sizeof(req->out)) != sizeof(req->out))) {
|
|
|
|
error_report("virtio-blk request outhdr too short");
|
|
|
|
exit(1);
|
|
|
|
}
|
2014-06-11 08:11:50 +04:00
|
|
|
|
2014-06-11 08:11:48 +04:00
|
|
|
iov_discard_front(&iov, &out_num, sizeof(req->out));
|
2014-06-11 08:11:50 +04:00
|
|
|
|
|
|
|
if (in_num < 1 ||
|
|
|
|
in_iov[in_num - 1].iov_len < sizeof(struct virtio_blk_inhdr)) {
|
|
|
|
error_report("virtio-blk request inhdr too short");
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
|
|
|
|
req->in = (void *)in_iov[in_num - 1].iov_base
|
|
|
|
+ in_iov[in_num - 1].iov_len
|
|
|
|
- sizeof(struct virtio_blk_inhdr);
|
|
|
|
iov_discard_back(in_iov, &in_num, sizeof(struct virtio_blk_inhdr));
|
2010-01-27 15:12:34 +03:00
|
|
|
|
2014-06-24 21:43:44 +04:00
|
|
|
type = virtio_ldl_p(VIRTIO_DEVICE(req->dev), &req->out.type);
|
2011-01-25 13:55:14 +03:00
|
|
|
|
|
|
|
if (type & VIRTIO_BLK_T_FLUSH) {
|
2010-06-08 20:26:07 +04:00
|
|
|
virtio_blk_handle_flush(req, mrb);
|
2011-01-25 13:55:14 +03:00
|
|
|
} else if (type & VIRTIO_BLK_T_SCSI_CMD) {
|
2010-01-27 15:12:34 +03:00
|
|
|
virtio_blk_handle_scsi(req);
|
2011-01-25 13:55:14 +03:00
|
|
|
} else if (type & VIRTIO_BLK_T_GET_ID) {
|
2010-07-02 21:44:25 +04:00
|
|
|
VirtIOBlock *s = req->dev;
|
|
|
|
|
2011-06-20 13:35:18 +04:00
|
|
|
/*
|
|
|
|
* NB: per existing s/n string convention the string is
|
|
|
|
* terminated by '\0' only when shorter than buffer.
|
|
|
|
*/
|
2014-08-12 15:41:51 +04:00
|
|
|
const char *serial = s->blk.serial ? s->blk.serial : "";
|
|
|
|
size_t size = MIN(strlen(serial) + 1,
|
|
|
|
MIN(iov_size(in_iov, in_num),
|
|
|
|
VIRTIO_BLK_ID_BYTES));
|
|
|
|
iov_from_buf(in_iov, in_num, 0, serial, size);
|
2010-07-02 21:44:25 +04:00
|
|
|
virtio_blk_req_complete(req, VIRTIO_BLK_S_OK);
|
2014-06-11 08:11:43 +04:00
|
|
|
virtio_blk_free_request(req);
|
2011-01-25 13:55:14 +03:00
|
|
|
} else if (type & VIRTIO_BLK_T_OUT) {
|
2014-08-12 15:41:51 +04:00
|
|
|
qemu_iovec_init_external(&req->qiov, iov, out_num);
|
2010-06-08 20:26:07 +04:00
|
|
|
virtio_blk_handle_write(req, mrb);
|
2012-12-13 11:03:43 +04:00
|
|
|
} else if (type == VIRTIO_BLK_T_IN || type == VIRTIO_BLK_T_BARRIER) {
|
|
|
|
/* VIRTIO_BLK_T_IN is 0, so we can't just & it. */
|
2014-08-12 15:41:51 +04:00
|
|
|
qemu_iovec_init_external(&req->qiov, in_iov, in_num);
|
2010-01-27 15:12:34 +03:00
|
|
|
virtio_blk_handle_read(req);
|
2012-12-13 11:03:43 +04:00
|
|
|
} else {
|
|
|
|
virtio_blk_req_complete(req, VIRTIO_BLK_S_UNSUPP);
|
2014-06-11 08:11:43 +04:00
|
|
|
virtio_blk_free_request(req);
|
2010-01-27 15:12:34 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-12-04 22:52:44 +03:00
|
|
|
static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq)
|
|
|
|
{
|
2013-03-18 20:37:27 +04:00
|
|
|
VirtIOBlock *s = VIRTIO_BLK(vdev);
|
2008-12-04 22:52:44 +03:00
|
|
|
VirtIOBlockReq *req;
|
2010-01-27 15:12:34 +03:00
|
|
|
MultiReqBuffer mrb = {
|
|
|
|
.num_writes = 0,
|
|
|
|
};
|
2008-12-04 22:52:44 +03:00
|
|
|
|
2012-11-14 18:45:38 +04:00
|
|
|
/* Some guests kick before setting VIRTIO_CONFIG_S_DRIVER_OK so start
|
|
|
|
* dataplane here instead of waiting for .set_status().
|
|
|
|
*/
|
|
|
|
if (s->dataplane) {
|
|
|
|
virtio_blk_data_plane_start(s->dataplane);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2008-12-04 22:52:44 +03:00
|
|
|
while ((req = virtio_blk_get_request(s))) {
|
2010-01-27 15:12:34 +03:00
|
|
|
virtio_blk_handle_request(req, &mrb);
|
2008-12-04 22:52:44 +03:00
|
|
|
}
|
2009-09-09 19:53:38 +04:00
|
|
|
|
2010-06-08 20:26:07 +04:00
|
|
|
virtio_submit_multiwrite(s->bs, &mrb);
|
2009-09-09 19:53:38 +04:00
|
|
|
|
2008-12-04 22:52:44 +03:00
|
|
|
/*
|
|
|
|
* FIXME: Want to check for completions before returning to guest mode,
|
|
|
|
* so cached reads and writes are reported as quickly as possible. But
|
|
|
|
* that should be done in the generic block layer.
|
|
|
|
*/
|
|
|
|
}
|
|
|
|
|
2009-07-28 22:33:41 +04:00
|
|
|
static void virtio_blk_dma_restart_bh(void *opaque)
|
2009-01-22 22:52:25 +03:00
|
|
|
{
|
|
|
|
VirtIOBlock *s = opaque;
|
|
|
|
VirtIOBlockReq *req = s->rq;
|
2010-01-27 15:12:35 +03:00
|
|
|
MultiReqBuffer mrb = {
|
|
|
|
.num_writes = 0,
|
|
|
|
};
|
2009-01-22 22:52:25 +03:00
|
|
|
|
2009-07-28 22:33:41 +04:00
|
|
|
qemu_bh_delete(s->bh);
|
|
|
|
s->bh = NULL;
|
2009-01-22 22:52:25 +03:00
|
|
|
|
|
|
|
s->rq = NULL;
|
|
|
|
|
|
|
|
while (req) {
|
2014-08-18 11:42:50 +04:00
|
|
|
VirtIOBlockReq *next = req->next;
|
2010-01-27 15:12:35 +03:00
|
|
|
virtio_blk_handle_request(req, &mrb);
|
2014-08-18 11:42:50 +04:00
|
|
|
req = next;
|
2009-01-22 22:52:25 +03:00
|
|
|
}
|
2010-01-27 15:12:35 +03:00
|
|
|
|
2010-06-08 20:26:07 +04:00
|
|
|
virtio_submit_multiwrite(s->bs, &mrb);
|
2009-01-22 22:52:25 +03:00
|
|
|
}
|
|
|
|
|
2011-07-29 21:26:33 +04:00
|
|
|
static void virtio_blk_dma_restart_cb(void *opaque, int running,
|
|
|
|
RunState state)
|
2009-07-28 22:33:41 +04:00
|
|
|
{
|
|
|
|
VirtIOBlock *s = opaque;
|
|
|
|
|
2012-11-14 18:45:38 +04:00
|
|
|
if (!running) {
|
2009-07-28 22:33:41 +04:00
|
|
|
return;
|
2012-11-14 18:45:38 +04:00
|
|
|
}
|
2009-07-28 22:33:41 +04:00
|
|
|
|
|
|
|
if (!s->bh) {
|
2014-06-17 10:32:08 +04:00
|
|
|
s->bh = aio_bh_new(bdrv_get_aio_context(s->blk.conf.bs),
|
|
|
|
virtio_blk_dma_restart_bh, s);
|
2009-07-28 22:33:41 +04:00
|
|
|
qemu_bh_schedule(s->bh);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-12-04 22:52:44 +03:00
|
|
|
static void virtio_blk_reset(VirtIODevice *vdev)
|
|
|
|
{
|
2013-03-18 20:37:27 +04:00
|
|
|
VirtIOBlock *s = VIRTIO_BLK(vdev);
|
2012-11-14 18:45:38 +04:00
|
|
|
|
|
|
|
if (s->dataplane) {
|
|
|
|
virtio_blk_data_plane_stop(s->dataplane);
|
|
|
|
}
|
|
|
|
|
2008-12-04 22:52:44 +03:00
|
|
|
/*
|
|
|
|
* This should cancel pending requests, but can't do nicely until there
|
|
|
|
* are per-device request lists.
|
|
|
|
*/
|
2011-11-30 16:23:43 +04:00
|
|
|
bdrv_drain_all();
|
virtio-blk: do not relay a previous driver's WCE configuration to the current
The following sequence happens:
- the SeaBIOS virtio-blk driver does not support the WCE feature, which
causes QEMU to disable writeback caching
- the Linux virtio-blk driver resets the device, finds WCE is available
but writeback caching is disabled; tells block layer to not send cache
flush commands
- the Linux virtio-blk driver sets the DRIVER_OK bit, which causes
writeback caching to be re-enabled, but the Linux virtio-blk driver does
not know of this side effect and cache flushes remain disabled
The bug is at the third step. If the guest does know about CONFIG_WCE,
QEMU should ignore the WCE feature's state. The guest will control the
cache mode solely using configuration space. This change makes Linux
do flushes correctly, but Linux will keep SeaBIOS's writethrough mode.
Hence, whenever the guest is reset, the cache mode of the disk should
be reset to whatever was specified in the "-drive" option. With this
change, the Linux virtio-blk driver finds that writeback caching is
enabled, and tells the block layer to send cache flush commands
appropriately.
Reported-by: Rusty Russell <rusty@au1.ibm.com
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2013-09-20 19:31:55 +04:00
|
|
|
bdrv_set_enable_write_cache(s->bs, s->original_wce);
|
2008-12-04 22:52:44 +03:00
|
|
|
}
|
|
|
|
|
2009-06-22 22:26:51 +04:00
|
|
|
/* coalesce internal state, copy to pci i/o region 0
|
|
|
|
*/
|
2008-12-04 22:52:44 +03:00
|
|
|
static void virtio_blk_update_config(VirtIODevice *vdev, uint8_t *config)
|
|
|
|
{
|
2013-03-18 20:37:27 +04:00
|
|
|
VirtIOBlock *s = VIRTIO_BLK(vdev);
|
2008-12-04 22:52:44 +03:00
|
|
|
struct virtio_blk_config blkcfg;
|
|
|
|
uint64_t capacity;
|
2011-11-18 19:31:59 +04:00
|
|
|
int blk_size = s->conf->logical_block_size;
|
2008-12-04 22:52:44 +03:00
|
|
|
|
|
|
|
bdrv_get_geometry(s->bs, &capacity);
|
2009-06-12 11:50:18 +04:00
|
|
|
memset(&blkcfg, 0, sizeof(blkcfg));
|
2014-06-24 21:43:44 +04:00
|
|
|
virtio_stq_p(vdev, &blkcfg.capacity, capacity);
|
|
|
|
virtio_stl_p(vdev, &blkcfg.seg_max, 128 - 2);
|
|
|
|
virtio_stw_p(vdev, &blkcfg.cylinders, s->conf->cyls);
|
|
|
|
virtio_stl_p(vdev, &blkcfg.blk_size, blk_size);
|
|
|
|
virtio_stw_p(vdev, &blkcfg.min_io_size, s->conf->min_io_size / blk_size);
|
|
|
|
virtio_stw_p(vdev, &blkcfg.opt_io_size, s->conf->opt_io_size / blk_size);
|
2012-07-10 13:12:43 +04:00
|
|
|
blkcfg.heads = s->conf->heads;
|
2012-05-24 15:22:55 +04:00
|
|
|
/*
|
|
|
|
* We must ensure that the block device capacity is a multiple of
|
2013-04-09 15:48:19 +04:00
|
|
|
* the logical block size. If that is not the case, let's use
|
2012-05-24 15:22:55 +04:00
|
|
|
* sector_mask to adopt the geometry to have a correct picture.
|
|
|
|
* For those devices where the capacity is ok for the given geometry
|
2013-04-09 15:48:19 +04:00
|
|
|
* we don't touch the sector value of the geometry, since some devices
|
2012-05-24 15:22:55 +04:00
|
|
|
* (like s390 dasd) need a specific value. Here the capacity is already
|
|
|
|
* cyls*heads*secs*blk_size and the sector value is not block size
|
|
|
|
* divided by 512 - instead it is the amount of blk_size blocks
|
|
|
|
* per track (cylinder).
|
|
|
|
*/
|
2012-07-10 13:12:43 +04:00
|
|
|
if (bdrv_getlength(s->bs) / s->conf->heads / s->conf->secs % blk_size) {
|
|
|
|
blkcfg.sectors = s->conf->secs & ~s->sector_mask;
|
2012-05-24 15:22:55 +04:00
|
|
|
} else {
|
2012-07-10 13:12:43 +04:00
|
|
|
blkcfg.sectors = s->conf->secs;
|
2012-05-24 15:22:55 +04:00
|
|
|
}
|
2009-06-13 17:20:25 +04:00
|
|
|
blkcfg.size_max = 0;
|
2010-02-11 01:37:25 +03:00
|
|
|
blkcfg.physical_block_exp = get_physical_block_exp(s->conf);
|
|
|
|
blkcfg.alignment_offset = 0;
|
2012-08-09 18:07:19 +04:00
|
|
|
blkcfg.wce = bdrv_enable_write_cache(s->bs);
|
2010-02-11 01:36:49 +03:00
|
|
|
memcpy(config, &blkcfg, sizeof(struct virtio_blk_config));
|
2008-12-04 22:52:44 +03:00
|
|
|
}
|
|
|
|
|
2012-08-09 18:07:19 +04:00
|
|
|
static void virtio_blk_set_config(VirtIODevice *vdev, const uint8_t *config)
|
|
|
|
{
|
2013-03-18 20:37:27 +04:00
|
|
|
VirtIOBlock *s = VIRTIO_BLK(vdev);
|
2012-08-09 18:07:19 +04:00
|
|
|
struct virtio_blk_config blkcfg;
|
|
|
|
|
|
|
|
memcpy(&blkcfg, config, sizeof(blkcfg));
|
2014-05-15 15:22:06 +04:00
|
|
|
|
|
|
|
aio_context_acquire(bdrv_get_aio_context(s->bs));
|
2012-08-09 18:07:19 +04:00
|
|
|
bdrv_set_enable_write_cache(s->bs, blkcfg.wce != 0);
|
2014-05-15 15:22:06 +04:00
|
|
|
aio_context_release(bdrv_get_aio_context(s->bs));
|
2012-08-09 18:07:19 +04:00
|
|
|
}
|
|
|
|
|
2010-01-10 14:52:53 +03:00
|
|
|
static uint32_t virtio_blk_get_features(VirtIODevice *vdev, uint32_t features)
|
2008-12-04 22:52:44 +03:00
|
|
|
{
|
2013-03-18 20:37:27 +04:00
|
|
|
VirtIOBlock *s = VIRTIO_BLK(vdev);
|
2009-04-27 12:29:14 +04:00
|
|
|
|
|
|
|
features |= (1 << VIRTIO_BLK_F_SEG_MAX);
|
|
|
|
features |= (1 << VIRTIO_BLK_F_GEOMETRY);
|
2010-02-11 01:37:25 +03:00
|
|
|
features |= (1 << VIRTIO_BLK_F_TOPOLOGY);
|
2010-03-04 16:20:17 +03:00
|
|
|
features |= (1 << VIRTIO_BLK_F_BLK_SIZE);
|
virtio-blk: always enable VIRTIO_BLK_F_SCSI
VIRTIO_BLK_F_SCSI is supposed to mean whether the host can *parse*
SCSI requests, not *execute* them. You could run QEMU with scsi=on
and a file-backed disk, and QEMU would fail all SCSI requests even
though it advertises VIRTIO_BLK_F_SCSI.
Because we need to do this to fix a migration compatibility problem
related to how QEMU is invoked by management, we must do this
unconditionally even on older machine types. This more or less assumes
that no one ever invoked QEMU with scsi=off.
Here is how testing goes:
- old QEMU, scsi=on -> new QEMU, scsi=on
- new QEMU, scsi=on -> old QEMU, scsi=on
- old QEMU, scsi=off -> new QEMU, scsi=on
- new QEMU, scsi=off -> old QEMU, scsi=on
ok (new QEMU has VIRTIO_BLK_F_SCSI, adding host features is fine)
- old QEMU, scsi=off -> new QEMU, scsi=off
ok (new QEMU has VIRTIO_BLK_F_SCSI, adding host features is fine)
- old QEMU, scsi=on -> new QEMU, scsi=off
ok, bug fixed
- new QEMU, scsi=on -> old QEMU, scsi=off
doesn't work (same as: old QEMU, scsi=on -> old QEMU, scsi=off)
- new QEMU, scsi=off -> old QEMU, scsi=off
broken by the patch
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2012-05-16 14:54:06 +04:00
|
|
|
features |= (1 << VIRTIO_BLK_F_SCSI);
|
2009-09-04 21:02:23 +04:00
|
|
|
|
2013-03-18 20:37:21 +04:00
|
|
|
if (s->blk.config_wce) {
|
2012-12-10 16:14:39 +04:00
|
|
|
features |= (1 << VIRTIO_BLK_F_CONFIG_WCE);
|
|
|
|
}
|
2009-09-04 21:02:23 +04:00
|
|
|
if (bdrv_enable_write_cache(s->bs))
|
2012-08-09 18:07:19 +04:00
|
|
|
features |= (1 << VIRTIO_BLK_F_WCE);
|
|
|
|
|
2009-10-29 12:42:11 +03:00
|
|
|
if (bdrv_is_read_only(s->bs))
|
|
|
|
features |= 1 << VIRTIO_BLK_F_RO;
|
2009-04-27 12:29:14 +04:00
|
|
|
|
|
|
|
return features;
|
2008-12-04 22:52:44 +03:00
|
|
|
}
|
|
|
|
|
2012-08-09 18:07:20 +04:00
|
|
|
static void virtio_blk_set_status(VirtIODevice *vdev, uint8_t status)
|
|
|
|
{
|
2013-03-18 20:37:27 +04:00
|
|
|
VirtIOBlock *s = VIRTIO_BLK(vdev);
|
2012-08-09 18:07:20 +04:00
|
|
|
uint32_t features;
|
|
|
|
|
2013-01-17 19:46:54 +04:00
|
|
|
if (s->dataplane && !(status & (VIRTIO_CONFIG_S_DRIVER |
|
|
|
|
VIRTIO_CONFIG_S_DRIVER_OK))) {
|
2012-11-14 18:45:38 +04:00
|
|
|
virtio_blk_data_plane_stop(s->dataplane);
|
|
|
|
}
|
|
|
|
|
2012-08-09 18:07:20 +04:00
|
|
|
if (!(status & VIRTIO_CONFIG_S_DRIVER_OK)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
features = vdev->guest_features;
|
virtio-blk: do not relay a previous driver's WCE configuration to the current
The following sequence happens:
- the SeaBIOS virtio-blk driver does not support the WCE feature, which
causes QEMU to disable writeback caching
- the Linux virtio-blk driver resets the device, finds WCE is available
but writeback caching is disabled; tells block layer to not send cache
flush commands
- the Linux virtio-blk driver sets the DRIVER_OK bit, which causes
writeback caching to be re-enabled, but the Linux virtio-blk driver does
not know of this side effect and cache flushes remain disabled
The bug is at the third step. If the guest does know about CONFIG_WCE,
QEMU should ignore the WCE feature's state. The guest will control the
cache mode solely using configuration space. This change makes Linux
do flushes correctly, but Linux will keep SeaBIOS's writethrough mode.
Hence, whenever the guest is reset, the cache mode of the disk should
be reset to whatever was specified in the "-drive" option. With this
change, the Linux virtio-blk driver finds that writeback caching is
enabled, and tells the block layer to send cache flush commands
appropriately.
Reported-by: Rusty Russell <rusty@au1.ibm.com
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2013-09-20 19:31:55 +04:00
|
|
|
|
|
|
|
/* A guest that supports VIRTIO_BLK_F_CONFIG_WCE must be able to send
|
|
|
|
* cache flushes. Thus, the "auto writethrough" behavior is never
|
|
|
|
* necessary for guests that support the VIRTIO_BLK_F_CONFIG_WCE feature.
|
|
|
|
* Leaving it enabled would break the following sequence:
|
|
|
|
*
|
|
|
|
* Guest started with "-drive cache=writethrough"
|
|
|
|
* Guest sets status to 0
|
|
|
|
* Guest sets DRIVER bit in status field
|
|
|
|
* Guest reads host features (WCE=0, CONFIG_WCE=1)
|
|
|
|
* Guest writes guest features (WCE=0, CONFIG_WCE=1)
|
|
|
|
* Guest writes 1 to the WCE configuration field (writeback mode)
|
|
|
|
* Guest sets DRIVER_OK bit in status field
|
|
|
|
*
|
|
|
|
* s->bs would erroneously be placed in writethrough mode.
|
|
|
|
*/
|
|
|
|
if (!(features & (1 << VIRTIO_BLK_F_CONFIG_WCE))) {
|
2014-05-15 15:22:06 +04:00
|
|
|
aio_context_acquire(bdrv_get_aio_context(s->bs));
|
|
|
|
bdrv_set_enable_write_cache(s->bs,
|
|
|
|
!!(features & (1 << VIRTIO_BLK_F_WCE)));
|
|
|
|
aio_context_release(bdrv_get_aio_context(s->bs));
|
virtio-blk: do not relay a previous driver's WCE configuration to the current
The following sequence happens:
- the SeaBIOS virtio-blk driver does not support the WCE feature, which
causes QEMU to disable writeback caching
- the Linux virtio-blk driver resets the device, finds WCE is available
but writeback caching is disabled; tells block layer to not send cache
flush commands
- the Linux virtio-blk driver sets the DRIVER_OK bit, which causes
writeback caching to be re-enabled, but the Linux virtio-blk driver does
not know of this side effect and cache flushes remain disabled
The bug is at the third step. If the guest does know about CONFIG_WCE,
QEMU should ignore the WCE feature's state. The guest will control the
cache mode solely using configuration space. This change makes Linux
do flushes correctly, but Linux will keep SeaBIOS's writethrough mode.
Hence, whenever the guest is reset, the cache mode of the disk should
be reset to whatever was specified in the "-drive" option. With this
change, the Linux virtio-blk driver finds that writeback caching is
enabled, and tells the block layer to send cache flush commands
appropriately.
Reported-by: Rusty Russell <rusty@au1.ibm.com
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2013-09-20 19:31:55 +04:00
|
|
|
}
|
2012-08-09 18:07:20 +04:00
|
|
|
}
|
|
|
|
|
2008-12-04 22:52:44 +03:00
|
|
|
static void virtio_blk_save(QEMUFile *f, void *opaque)
|
|
|
|
{
|
2014-06-24 21:19:23 +04:00
|
|
|
VirtIODevice *vdev = VIRTIO_DEVICE(opaque);
|
2009-01-22 22:52:25 +03:00
|
|
|
|
2013-03-18 20:37:27 +04:00
|
|
|
virtio_save(vdev, f);
|
2014-06-24 21:19:23 +04:00
|
|
|
}
|
2009-01-22 22:52:25 +03:00
|
|
|
|
2014-06-24 21:19:23 +04:00
|
|
|
static void virtio_blk_save_device(VirtIODevice *vdev, QEMUFile *f)
|
|
|
|
{
|
|
|
|
VirtIOBlock *s = VIRTIO_BLK(vdev);
|
|
|
|
VirtIOBlockReq *req = s->rq;
|
|
|
|
|
2009-01-22 22:52:25 +03:00
|
|
|
while (req) {
|
|
|
|
qemu_put_sbyte(f, 1);
|
2014-07-09 12:05:49 +04:00
|
|
|
qemu_put_buffer(f, (unsigned char *)&req->elem,
|
2014-06-11 08:11:43 +04:00
|
|
|
sizeof(VirtQueueElement));
|
2009-01-22 22:52:25 +03:00
|
|
|
req = req->next;
|
|
|
|
}
|
|
|
|
qemu_put_sbyte(f, 0);
|
2008-12-04 22:52:44 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static int virtio_blk_load(QEMUFile *f, void *opaque, int version_id)
|
|
|
|
{
|
|
|
|
VirtIOBlock *s = opaque;
|
2013-03-18 20:37:27 +04:00
|
|
|
VirtIODevice *vdev = VIRTIO_DEVICE(s);
|
2008-12-04 22:52:44 +03:00
|
|
|
|
2009-01-22 22:52:25 +03:00
|
|
|
if (version_id != 2)
|
2008-12-04 22:52:44 +03:00
|
|
|
return -EINVAL;
|
|
|
|
|
2014-06-24 21:19:23 +04:00
|
|
|
return virtio_load(vdev, f, version_id);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int virtio_blk_load_device(VirtIODevice *vdev, QEMUFile *f,
|
|
|
|
int version_id)
|
|
|
|
{
|
|
|
|
VirtIOBlock *s = VIRTIO_BLK(vdev);
|
2012-05-16 14:21:35 +04:00
|
|
|
|
2009-01-22 22:52:25 +03:00
|
|
|
while (qemu_get_sbyte(f)) {
|
|
|
|
VirtIOBlockReq *req = virtio_blk_alloc_request(s);
|
2014-07-09 12:05:49 +04:00
|
|
|
qemu_get_buffer(f, (unsigned char *)&req->elem,
|
2014-06-11 08:11:43 +04:00
|
|
|
sizeof(VirtQueueElement));
|
2009-01-22 22:52:25 +03:00
|
|
|
req->next = s->rq;
|
2010-06-21 12:50:01 +04:00
|
|
|
s->rq = req;
|
2010-08-03 18:57:02 +04:00
|
|
|
|
2014-07-09 12:05:49 +04:00
|
|
|
virtqueue_map_sg(req->elem.in_sg, req->elem.in_addr,
|
|
|
|
req->elem.in_num, 1);
|
|
|
|
virtqueue_map_sg(req->elem.out_sg, req->elem.out_addr,
|
|
|
|
req->elem.out_num, 0);
|
2009-01-22 22:52:25 +03:00
|
|
|
}
|
2008-12-04 22:52:44 +03:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-08-03 17:07:42 +04:00
|
|
|
static void virtio_blk_resize(void *opaque)
|
2011-01-24 15:32:51 +03:00
|
|
|
{
|
2013-03-18 20:37:27 +04:00
|
|
|
VirtIODevice *vdev = VIRTIO_DEVICE(opaque);
|
2011-01-24 15:32:51 +03:00
|
|
|
|
2013-03-18 20:37:27 +04:00
|
|
|
virtio_notify_config(vdev);
|
2011-01-24 15:32:51 +03:00
|
|
|
}
|
|
|
|
|
2011-08-03 17:07:41 +04:00
|
|
|
static const BlockDevOps virtio_block_ops = {
|
2011-08-03 17:07:42 +04:00
|
|
|
.resize_cb = virtio_blk_resize,
|
2011-08-03 17:07:41 +04:00
|
|
|
};
|
|
|
|
|
2013-07-29 17:01:59 +04:00
|
|
|
/* Disable dataplane thread during live migration since it does not
|
|
|
|
* update the dirty memory bitmap yet.
|
|
|
|
*/
|
|
|
|
static void virtio_blk_migration_state_changed(Notifier *notifier, void *data)
|
|
|
|
{
|
|
|
|
VirtIOBlock *s = container_of(notifier, VirtIOBlock,
|
|
|
|
migration_state_notifier);
|
|
|
|
MigrationState *mig = data;
|
2013-06-07 18:18:50 +04:00
|
|
|
Error *err = NULL;
|
2013-07-29 17:01:59 +04:00
|
|
|
|
|
|
|
if (migration_in_setup(mig)) {
|
|
|
|
if (!s->dataplane) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
virtio_blk_data_plane_destroy(s->dataplane);
|
|
|
|
s->dataplane = NULL;
|
|
|
|
} else if (migration_has_finished(mig) ||
|
|
|
|
migration_has_failed(mig)) {
|
|
|
|
if (s->dataplane) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
bdrv_drain_all(); /* complete in-flight non-dataplane requests */
|
|
|
|
virtio_blk_data_plane_create(VIRTIO_DEVICE(s), &s->blk,
|
2013-06-07 18:18:50 +04:00
|
|
|
&s->dataplane, &err);
|
|
|
|
if (err != NULL) {
|
|
|
|
error_report("%s", error_get_pretty(err));
|
|
|
|
error_free(err);
|
|
|
|
}
|
2013-07-29 17:01:59 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-07-30 03:35:08 +04:00
|
|
|
static void virtio_blk_device_realize(DeviceState *dev, Error **errp)
|
2013-03-18 20:37:22 +04:00
|
|
|
{
|
2013-07-30 03:35:08 +04:00
|
|
|
VirtIODevice *vdev = VIRTIO_DEVICE(dev);
|
2013-07-30 06:48:15 +04:00
|
|
|
VirtIOBlock *s = VIRTIO_BLK(dev);
|
2013-03-18 20:37:26 +04:00
|
|
|
VirtIOBlkConf *blk = &(s->blk);
|
2013-06-07 18:18:50 +04:00
|
|
|
Error *err = NULL;
|
2008-12-04 22:52:44 +03:00
|
|
|
static int virtio_blk_id;
|
2009-05-15 01:35:07 +04:00
|
|
|
|
2012-05-16 14:54:05 +04:00
|
|
|
if (!blk->conf.bs) {
|
2013-07-30 03:35:08 +04:00
|
|
|
error_setg(errp, "drive property not set");
|
|
|
|
return;
|
2010-07-06 16:37:43 +04:00
|
|
|
}
|
2012-05-16 14:54:05 +04:00
|
|
|
if (!bdrv_is_inserted(blk->conf.bs)) {
|
2013-07-30 03:35:08 +04:00
|
|
|
error_setg(errp, "Device needs media, but drive is empty");
|
|
|
|
return;
|
2010-07-06 16:37:44 +04:00
|
|
|
}
|
2010-07-06 16:37:43 +04:00
|
|
|
|
2012-07-11 17:08:37 +04:00
|
|
|
blkconf_serial(&blk->conf, &blk->serial);
|
virtio-blk: do not relay a previous driver's WCE configuration to the current
The following sequence happens:
- the SeaBIOS virtio-blk driver does not support the WCE feature, which
causes QEMU to disable writeback caching
- the Linux virtio-blk driver resets the device, finds WCE is available
but writeback caching is disabled; tells block layer to not send cache
flush commands
- the Linux virtio-blk driver sets the DRIVER_OK bit, which causes
writeback caching to be re-enabled, but the Linux virtio-blk driver does
not know of this side effect and cache flushes remain disabled
The bug is at the third step. If the guest does know about CONFIG_WCE,
QEMU should ignore the WCE feature's state. The guest will control the
cache mode solely using configuration space. This change makes Linux
do flushes correctly, but Linux will keep SeaBIOS's writethrough mode.
Hence, whenever the guest is reset, the cache mode of the disk should
be reset to whatever was specified in the "-drive" option. With this
change, the Linux virtio-blk driver finds that writeback caching is
enabled, and tells the block layer to send cache flush commands
appropriately.
Reported-by: Rusty Russell <rusty@au1.ibm.com
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2013-09-20 19:31:55 +04:00
|
|
|
s->original_wce = bdrv_enable_write_cache(blk->conf.bs);
|
2014-08-12 06:12:54 +04:00
|
|
|
blkconf_geometry(&blk->conf, NULL, 65535, 255, 255, &err);
|
|
|
|
if (err) {
|
|
|
|
error_propagate(errp, err);
|
2013-07-30 03:35:08 +04:00
|
|
|
return;
|
2012-07-11 17:08:39 +04:00
|
|
|
}
|
2011-06-20 13:35:18 +04:00
|
|
|
|
2013-03-18 20:37:26 +04:00
|
|
|
virtio_init(vdev, "virtio-blk", VIRTIO_ID_BLOCK,
|
|
|
|
sizeof(struct virtio_blk_config));
|
2008-12-04 22:52:44 +03:00
|
|
|
|
2012-05-16 14:54:05 +04:00
|
|
|
s->bs = blk->conf.bs;
|
|
|
|
s->conf = &blk->conf;
|
2009-01-22 22:52:25 +03:00
|
|
|
s->rq = NULL;
|
2010-05-27 18:20:33 +04:00
|
|
|
s->sector_mask = (s->conf->logical_block_size / BDRV_SECTOR_SIZE) - 1;
|
2012-07-10 13:12:43 +04:00
|
|
|
|
2013-03-18 20:37:26 +04:00
|
|
|
s->vq = virtio_add_queue(vdev, 128, virtio_blk_handle_output);
|
2014-06-17 10:32:06 +04:00
|
|
|
s->complete_request = virtio_blk_complete_request;
|
2013-06-07 18:18:50 +04:00
|
|
|
virtio_blk_data_plane_create(vdev, blk, &s->dataplane, &err);
|
|
|
|
if (err != NULL) {
|
2013-07-30 03:35:08 +04:00
|
|
|
error_propagate(errp, err);
|
2013-04-24 12:21:22 +04:00
|
|
|
virtio_cleanup(vdev);
|
2013-07-30 03:35:08 +04:00
|
|
|
return;
|
2012-11-14 18:45:38 +04:00
|
|
|
}
|
2013-07-29 17:01:59 +04:00
|
|
|
s->migration_state_notifier.notify = virtio_blk_migration_state_changed;
|
|
|
|
add_migration_state_change_notifier(&s->migration_state_notifier);
|
2008-12-04 22:52:44 +03:00
|
|
|
|
2013-02-22 17:37:10 +04:00
|
|
|
s->change = qemu_add_vm_change_state_handler(virtio_blk_dma_restart_cb, s);
|
2013-07-30 06:48:15 +04:00
|
|
|
register_savevm(dev, "virtio-blk", virtio_blk_id++, 2,
|
2008-12-04 22:52:44 +03:00
|
|
|
virtio_blk_save, virtio_blk_load, s);
|
2011-08-03 17:07:41 +04:00
|
|
|
bdrv_set_dev_ops(s->bs, &virtio_block_ops, s);
|
2011-11-29 14:35:47 +04:00
|
|
|
bdrv_set_guest_block_size(s->bs, s->conf->logical_block_size);
|
2008-12-04 22:52:44 +03:00
|
|
|
|
2011-09-27 00:43:51 +04:00
|
|
|
bdrv_iostatus_enable(s->bs);
|
2013-03-18 20:37:22 +04:00
|
|
|
}
|
|
|
|
|
2013-07-30 05:50:44 +04:00
|
|
|
static void virtio_blk_device_unrealize(DeviceState *dev, Error **errp)
|
2013-03-18 20:37:22 +04:00
|
|
|
{
|
2013-07-30 05:50:44 +04:00
|
|
|
VirtIODevice *vdev = VIRTIO_DEVICE(dev);
|
|
|
|
VirtIOBlock *s = VIRTIO_BLK(dev);
|
|
|
|
|
2013-07-29 17:01:59 +04:00
|
|
|
remove_migration_state_change_notifier(&s->migration_state_notifier);
|
2013-03-18 20:37:22 +04:00
|
|
|
virtio_blk_data_plane_destroy(s->dataplane);
|
|
|
|
s->dataplane = NULL;
|
|
|
|
qemu_del_vm_change_state_handler(s->change);
|
2013-07-30 05:50:44 +04:00
|
|
|
unregister_savevm(dev, "virtio-blk", s);
|
2013-03-18 20:37:22 +04:00
|
|
|
blockdev_mark_auto_del(s->bs);
|
2013-04-24 12:21:22 +04:00
|
|
|
virtio_cleanup(vdev);
|
2013-03-18 20:37:22 +04:00
|
|
|
}
|
|
|
|
|
2014-06-10 11:03:20 +04:00
|
|
|
static void virtio_blk_instance_init(Object *obj)
|
|
|
|
{
|
|
|
|
VirtIOBlock *s = VIRTIO_BLK(obj);
|
|
|
|
|
|
|
|
object_property_add_link(obj, "iothread", TYPE_IOTHREAD,
|
|
|
|
(Object **)&s->blk.iothread,
|
|
|
|
qdev_prop_allow_set_link_before_realize,
|
|
|
|
OBJ_PROP_LINK_UNREF_ON_RELEASE, NULL);
|
2014-10-07 12:00:30 +04:00
|
|
|
device_add_bootindex_property(obj, &s->blk.conf.bootindex,
|
|
|
|
"bootindex", "/disk@0,0",
|
|
|
|
DEVICE(obj), NULL);
|
2014-06-10 11:03:20 +04:00
|
|
|
}
|
|
|
|
|
2013-03-18 20:37:22 +04:00
|
|
|
static Property virtio_blk_properties[] = {
|
2014-06-18 13:58:36 +04:00
|
|
|
DEFINE_BLOCK_PROPERTIES(VirtIOBlock, blk.conf),
|
|
|
|
DEFINE_BLOCK_CHS_PROPERTIES(VirtIOBlock, blk.conf),
|
|
|
|
DEFINE_PROP_STRING("serial", VirtIOBlock, blk.serial),
|
|
|
|
DEFINE_PROP_BIT("config-wce", VirtIOBlock, blk.config_wce, 0, true),
|
|
|
|
#ifdef __linux__
|
|
|
|
DEFINE_PROP_BIT("scsi", VirtIOBlock, blk.scsi, 0, true),
|
|
|
|
#endif
|
|
|
|
DEFINE_PROP_BIT("x-data-plane", VirtIOBlock, blk.data_plane, 0, false),
|
2013-03-18 20:37:22 +04:00
|
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
|
|
};
|
|
|
|
|
|
|
|
static void virtio_blk_class_init(ObjectClass *klass, void *data)
|
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
|
|
VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass);
|
2013-07-30 03:35:08 +04:00
|
|
|
|
2013-03-18 20:37:22 +04:00
|
|
|
dc->props = virtio_blk_properties;
|
2013-07-29 18:17:45 +04:00
|
|
|
set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
|
2013-07-30 03:35:08 +04:00
|
|
|
vdc->realize = virtio_blk_device_realize;
|
2013-07-30 05:50:44 +04:00
|
|
|
vdc->unrealize = virtio_blk_device_unrealize;
|
2013-03-18 20:37:22 +04:00
|
|
|
vdc->get_config = virtio_blk_update_config;
|
|
|
|
vdc->set_config = virtio_blk_set_config;
|
|
|
|
vdc->get_features = virtio_blk_get_features;
|
|
|
|
vdc->set_status = virtio_blk_set_status;
|
|
|
|
vdc->reset = virtio_blk_reset;
|
2014-06-24 21:19:23 +04:00
|
|
|
vdc->save = virtio_blk_save_device;
|
|
|
|
vdc->load = virtio_blk_load_device;
|
2013-03-18 20:37:22 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static const TypeInfo virtio_device_info = {
|
|
|
|
.name = TYPE_VIRTIO_BLK,
|
|
|
|
.parent = TYPE_VIRTIO_DEVICE,
|
|
|
|
.instance_size = sizeof(VirtIOBlock),
|
2014-06-10 11:03:20 +04:00
|
|
|
.instance_init = virtio_blk_instance_init,
|
2013-03-18 20:37:22 +04:00
|
|
|
.class_init = virtio_blk_class_init,
|
|
|
|
};
|
|
|
|
|
|
|
|
static void virtio_register_types(void)
|
|
|
|
{
|
|
|
|
type_register_static(&virtio_device_info);
|
|
|
|
}
|
|
|
|
|
|
|
|
type_init(virtio_register_types)
|