qemu/include/hw/scsi/emulation.h

#ifndef HW_SCSI_EMULATION_H
#define HW_SCSI_EMULATION_H

typedef struct SCSIBlockLimits {
    bool wsnz;
    uint16_t min_io_size;
    uint32_t max_unmap_descr;
    uint32_t opt_io_size;
    uint32_t max_unmap_sectors;
    uint32_t unmap_sectors;
    uint32_t max_io_sectors;
} SCSIBlockLimits;

int scsi_emulate_block_limits(uint8_t *outbuf, const SCSIBlockLimits *bl);

#endif
scsi-generic: avoid invalid access to struct when emulating block limits Emulation of the block limits VPD page called back into scsi-disk.c, which however expected the request to be for a SCSIDiskState and accessed a scsi-generic device outside the bounds of its struct (namely to retrieve s->max_unmap_size and s->max_io_size). To avoid this, move the emulation code to a separate function that takes a new SCSIBlockLimits struct and marshals it into the VPD response format. Reported-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> 2018-10-23 01:43:51 +03:00			`#ifndef HW_SCSI_EMULATION_H`
Normalize header guard symbol definition. We commonly define the header guard symbol without an explicit value. Normalize the exceptions. Done with scripts/clean-header-guards.pl. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20190315145123.28030-8-armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> 2019-03-15 17:51:22 +03:00			`#define HW_SCSI_EMULATION_H`
scsi-generic: avoid invalid access to struct when emulating block limits Emulation of the block limits VPD page called back into scsi-disk.c, which however expected the request to be for a SCSIDiskState and accessed a scsi-generic device outside the bounds of its struct (namely to retrieve s->max_unmap_size and s->max_io_size). To avoid this, move the emulation code to a separate function that takes a new SCSIBlockLimits struct and marshals it into the VPD response format. Reported-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> 2018-10-23 01:43:51 +03:00
			`typedef struct SCSIBlockLimits {`
			`bool wsnz;`
			`uint16_t min_io_size;`
			`uint32_t max_unmap_descr;`
			`uint32_t opt_io_size;`
			`uint32_t max_unmap_sectors;`
			`uint32_t unmap_sectors;`
			`uint32_t max_io_sectors;`
			`} SCSIBlockLimits;`

			`int scsi_emulate_block_limits(uint8_t outbuf, const SCSIBlockLimits bl);`

			`#endif`