2019-03-07 17:58:38 +03:00
|
|
|
#!/usr/bin/env bash
|
2021-01-16 16:44:19 +03:00
|
|
|
# group: rw quick
|
2014-02-21 19:24:08 +04:00
|
|
|
#
|
|
|
|
|
# Test qemu-img command line parsing
|
|
|
|
|
#
|
|
|
|
|
# Copyright (C) 2014 Red Hat, Inc.
|
|
|
|
|
#
|
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
|
|
|
# it under the terms of the GNU General Public License as published by
|
|
|
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
|
|
|
# (at your option) any later version.
|
|
|
|
|
#
|
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
|
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
# GNU General Public License for more details.
|
|
|
|
|
#
|
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
|
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
#
|
|
|
|
|
|
|
|
|
|
# creator
|
|
|
|
|
owner=kwolf@redhat.com
|
|
|
|
|
|
|
|
|
|
seq=`basename $0`
|
|
|
|
|
echo "QA output created by $seq"
|
|
|
|
|
|
|
|
|
|
status=1 # failure is the default!
|
|
|
|
|
|
|
|
|
|
_cleanup()
|
|
|
|
|
{
|
|
|
|
|
_cleanup_test_img
|
|
|
|
|
}
|
|
|
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
|
|
|
|
|
|
# get standard environment, filters and checks
|
|
|
|
|
. ./common.rc
|
|
|
|
|
. ./common.filter
|
|
|
|
|
|
|
|
|
|
_supported_fmt qcow2
|
2014-10-20 15:47:11 +04:00
|
|
|
_supported_proto file nfs
|
2020-04-30 15:47:07 +03:00
|
|
|
_require_drivers bochs
|
2014-02-21 19:24:08 +04:00
|
|
|
|
2018-11-17 00:50:02 +03:00
|
|
|
run_qemu_img()
|
2014-02-21 19:24:08 +04:00
|
|
|
{
|
|
|
|
|
echo
|
|
|
|
|
echo Testing: "$@" | _filter_testdir
|
|
|
|
|
"$QEMU_IMG" "$@" 2>&1 | _filter_testdir
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
size=128M
|
|
|
|
|
|
|
|
|
|
echo
|
|
|
|
|
echo === create: Options specified more than once ===
|
|
|
|
|
|
|
|
|
|
# Last -f should win
|
|
|
|
|
run_qemu_img create -f foo -f $IMGFMT "$TEST_IMG" $size
|
2014-09-30 23:31:27 +04:00
|
|
|
_img_info
|
2014-02-21 19:24:08 +04:00
|
|
|
|
|
|
|
|
# Multiple -o should be merged
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o cluster_size=4k -o lazy_refcounts=on "$TEST_IMG" $size
|
2014-11-27 19:28:01 +03:00
|
|
|
_img_info --format-specific
|
2014-02-21 19:24:08 +04:00
|
|
|
|
|
|
|
|
# If the same -o key is specified more than once, the last one wins
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o cluster_size=4k -o lazy_refcounts=on -o cluster_size=8k "$TEST_IMG" $size
|
2014-11-27 19:28:01 +03:00
|
|
|
_img_info --format-specific
|
2014-02-21 19:24:08 +04:00
|
|
|
run_qemu_img create -f $IMGFMT -o cluster_size=4k,cluster_size=8k "$TEST_IMG" $size
|
2014-09-30 23:31:27 +04:00
|
|
|
_img_info
|
2014-02-21 19:24:08 +04:00
|
|
|
|
|
|
|
|
echo
|
|
|
|
|
echo === create: help for -o ===
|
|
|
|
|
|
|
|
|
|
# Adding the help option to a command without other -o options
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o help "$TEST_IMG" $size
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o \? "$TEST_IMG" $size
|
|
|
|
|
|
|
|
|
|
# Adding the help option to the same -o option
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o cluster_size=4k,help "$TEST_IMG" $size
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o cluster_size=4k,\? "$TEST_IMG" $size
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o help,cluster_size=4k "$TEST_IMG" $size
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o \?,cluster_size=4k "$TEST_IMG" $size
|
|
|
|
|
|
|
|
|
|
# Adding the help option to a separate -o option
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o cluster_size=4k -o help "$TEST_IMG" $size
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o cluster_size=4k -o \? "$TEST_IMG" $size
|
|
|
|
|
|
|
|
|
|
# Looks like a help option, but is part of the backing file name
|
iotests: Specify explicit backing format where sensible
There are many existing qcow2 images that specify a backing file but
no format. This has been the source of CVEs in the past, but has
become more prominent of a problem now that libvirt has switched to
-blockdev. With older -drive, at least the probing was always done by
qemu (so the only risk of a changed format between successive boots of
a guest was if qemu was upgraded and probed differently). But with
newer -blockdev, libvirt must specify a format; if libvirt guesses raw
where the image was formatted, this results in data corruption visible
to the guest; conversely, if libvirt guesses qcow2 where qemu was
using raw, this can result in potential security holes, so modern
libvirt instead refuses to use images without explicit backing format.
The change in libvirt to reject images without explicit backing format
has pointed out that a number of tools have been far too reliant on
probing in the past. It's time to set a better example in our own
iotests of properly setting this parameter.
iotest calls to create, rebase, and convert are all impacted to some
degree. It's a bit annoying that we are inconsistent on command line
- while all of those accept -o backing_file=...,backing_fmt=..., the
shortcuts are different: create and rebase have -b and -F, while
convert has -B but no -F. (amend has no shortcuts, but the previous
patch just deprecated the use of amend to change backing chains).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200706203954.341758-9-eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-07-06 23:39:52 +03:00
|
|
|
run_qemu_img create -f $IMGFMT -u -o backing_file="$TEST_IMG",,help \
|
|
|
|
|
-F $IMGFMT "$TEST_IMG" $size
|
|
|
|
|
run_qemu_img create -f $IMGFMT -u -o backing_file="$TEST_IMG",,\? \
|
|
|
|
|
-F $IMGFMT "$TEST_IMG" $size
|
2014-02-21 19:24:08 +04:00
|
|
|
|
|
|
|
|
# Try to trick qemu-img into creating escaped commas
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o backing_file="$TEST_IMG", -o help "$TEST_IMG" $size
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o backing_file="$TEST_IMG" -o ,help "$TEST_IMG" $size
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o backing_file="$TEST_IMG" -o ,, -o help "$TEST_IMG" $size
|
|
|
|
|
|
|
|
|
|
# Leave out everything that isn't needed
|
|
|
|
|
run_qemu_img create -f $IMGFMT -o help
|
|
|
|
|
run_qemu_img create -o help
|
|
|
|
|
|
2018-05-10 00:00:22 +03:00
|
|
|
# Try help option for a format that does not support creation
|
|
|
|
|
run_qemu_img create -f bochs -o help
|
|
|
|
|
|
2014-02-21 19:24:08 +04:00
|
|
|
echo
|
|
|
|
|
echo === convert: Options specified more than once ===
|
|
|
|
|
|
|
|
|
|
# We need a valid source image
|
|
|
|
|
run_qemu_img create -f $IMGFMT "$TEST_IMG" $size
|
|
|
|
|
|
|
|
|
|
# Last -f should win
|
|
|
|
|
run_qemu_img convert -f foo -f $IMGFMT "$TEST_IMG" "$TEST_IMG".base
|
2014-09-30 23:31:27 +04:00
|
|
|
TEST_IMG="${TEST_IMG}.base" _img_info
|
2014-02-21 19:24:08 +04:00
|
|
|
|
|
|
|
|
# Last -O should win
|
|
|
|
|
run_qemu_img convert -O foo -O $IMGFMT "$TEST_IMG" "$TEST_IMG".base
|
2014-09-30 23:31:27 +04:00
|
|
|
TEST_IMG="${TEST_IMG}.base" _img_info
|
2014-02-21 19:24:08 +04:00
|
|
|
|
|
|
|
|
# Multiple -o should be merged
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o cluster_size=4k -o lazy_refcounts=on "$TEST_IMG" "$TEST_IMG".base
|
2014-11-27 19:28:01 +03:00
|
|
|
TEST_IMG="${TEST_IMG}.base" _img_info --format-specific
|
2014-02-21 19:24:08 +04:00
|
|
|
|
|
|
|
|
# If the same -o key is specified more than once, the last one wins
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o cluster_size=4k -o lazy_refcounts=on -o cluster_size=8k "$TEST_IMG" "$TEST_IMG".base
|
2014-11-27 19:28:01 +03:00
|
|
|
TEST_IMG="${TEST_IMG}.base" _img_info --format-specific
|
2014-02-21 19:24:08 +04:00
|
|
|
run_qemu_img convert -O $IMGFMT -o cluster_size=4k,cluster_size=8k "$TEST_IMG" "$TEST_IMG".base
|
2014-09-30 23:31:27 +04:00
|
|
|
TEST_IMG="${TEST_IMG}.base" _img_info
|
2014-02-21 19:24:08 +04:00
|
|
|
|
|
|
|
|
echo
|
|
|
|
|
echo === convert: help for -o ===
|
|
|
|
|
|
|
|
|
|
# Adding the help option to a command without other -o options
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o help "$TEST_IMG" "$TEST_IMG".base
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o \? "$TEST_IMG" "$TEST_IMG".base
|
|
|
|
|
|
|
|
|
|
# Adding the help option to the same -o option
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o cluster_size=4k,help "$TEST_IMG" "$TEST_IMG".base
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o cluster_size=4k,\? "$TEST_IMG" "$TEST_IMG".base
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o help,cluster_size=4k "$TEST_IMG" "$TEST_IMG".base
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o \?,cluster_size=4k "$TEST_IMG" "$TEST_IMG".base
|
|
|
|
|
|
|
|
|
|
# Adding the help option to a separate -o option
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o cluster_size=4k -o help "$TEST_IMG" "$TEST_IMG".base
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o cluster_size=4k -o \? "$TEST_IMG" "$TEST_IMG".base
|
|
|
|
|
|
|
|
|
|
# Looks like a help option, but is part of the backing file name
|
iotests: Specify explicit backing format where sensible
There are many existing qcow2 images that specify a backing file but
no format. This has been the source of CVEs in the past, but has
become more prominent of a problem now that libvirt has switched to
-blockdev. With older -drive, at least the probing was always done by
qemu (so the only risk of a changed format between successive boots of
a guest was if qemu was upgraded and probed differently). But with
newer -blockdev, libvirt must specify a format; if libvirt guesses raw
where the image was formatted, this results in data corruption visible
to the guest; conversely, if libvirt guesses qcow2 where qemu was
using raw, this can result in potential security holes, so modern
libvirt instead refuses to use images without explicit backing format.
The change in libvirt to reject images without explicit backing format
has pointed out that a number of tools have been far too reliant on
probing in the past. It's time to set a better example in our own
iotests of properly setting this parameter.
iotest calls to create, rebase, and convert are all impacted to some
degree. It's a bit annoying that we are inconsistent on command line
- while all of those accept -o backing_file=...,backing_fmt=..., the
shortcuts are different: create and rebase have -b and -F, while
convert has -B but no -F. (amend has no shortcuts, but the previous
patch just deprecated the use of amend to change backing chains).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200706203954.341758-9-eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-07-06 23:39:52 +03:00
|
|
|
run_qemu_img convert -O $IMGFMT -o backing_fmt=$IMGFMT,backing_file="$TEST_IMG",,help "$TEST_IMG" "$TEST_IMG".base
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o backing_fmt=$IMGFMT,backing_file="$TEST_IMG",,\? "$TEST_IMG" "$TEST_IMG".base
|
2014-02-21 19:24:08 +04:00
|
|
|
|
|
|
|
|
# Try to trick qemu-img into creating escaped commas
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o backing_file="$TEST_IMG", -o help "$TEST_IMG" "$TEST_IMG".base
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o backing_file="$TEST_IMG" -o ,help "$TEST_IMG" "$TEST_IMG".base
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o backing_file="$TEST_IMG" -o ,, -o help "$TEST_IMG" "$TEST_IMG".base
|
|
|
|
|
|
|
|
|
|
# Leave out everything that isn't needed
|
|
|
|
|
run_qemu_img convert -O $IMGFMT -o help
|
|
|
|
|
run_qemu_img convert -o help
|
|
|
|
|
|
2018-05-10 00:00:22 +03:00
|
|
|
# Try help option for a format that does not support creation
|
|
|
|
|
run_qemu_img convert -O bochs -o help
|
|
|
|
|
|
2018-07-27 06:34:02 +03:00
|
|
|
echo
|
|
|
|
|
echo === convert: -C and other options ===
|
|
|
|
|
|
|
|
|
|
# Adding the help option to a command without other -o options
|
|
|
|
|
run_qemu_img convert -C -S 4k -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
|
|
|
|
|
run_qemu_img convert -C -S 8k -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
|
|
|
|
|
run_qemu_img convert -C -c -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
|
2019-05-07 23:35:08 +03:00
|
|
|
run_qemu_img convert -C --salvage -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
|
2018-07-27 06:34:02 +03:00
|
|
|
|
2014-02-21 19:24:08 +04:00
|
|
|
echo
|
|
|
|
|
echo === amend: Options specified more than once ===
|
|
|
|
|
|
|
|
|
|
# Last -f should win
|
|
|
|
|
run_qemu_img amend -f foo -f $IMGFMT -o lazy_refcounts=on "$TEST_IMG"
|
2014-11-27 19:28:01 +03:00
|
|
|
_img_info --format-specific
|
2014-02-21 19:24:08 +04:00
|
|
|
|
|
|
|
|
# Multiple -o should be merged
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o size=130M -o lazy_refcounts=off "$TEST_IMG"
|
2014-11-27 19:28:01 +03:00
|
|
|
_img_info --format-specific
|
2014-02-21 19:24:08 +04:00
|
|
|
|
|
|
|
|
# If the same -o key is specified more than once, the last one wins
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o size=8M -o lazy_refcounts=on -o size=132M "$TEST_IMG"
|
2014-11-27 19:28:01 +03:00
|
|
|
_img_info --format-specific
|
2014-02-21 19:24:08 +04:00
|
|
|
run_qemu_img amend -f $IMGFMT -o size=4M,size=148M "$TEST_IMG"
|
2014-09-30 23:31:27 +04:00
|
|
|
_img_info
|
2014-02-21 19:24:08 +04:00
|
|
|
|
|
|
|
|
echo
|
|
|
|
|
echo === amend: help for -o ===
|
|
|
|
|
|
|
|
|
|
# Adding the help option to a command without other -o options
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o help "$TEST_IMG"
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o \? "$TEST_IMG"
|
|
|
|
|
|
|
|
|
|
# Adding the help option to the same -o option
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o cluster_size=4k,help "$TEST_IMG"
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o cluster_size=4k,\? "$TEST_IMG"
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o help,cluster_size=4k "$TEST_IMG"
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o \?,cluster_size=4k "$TEST_IMG"
|
|
|
|
|
|
|
|
|
|
# Adding the help option to a separate -o option
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o cluster_size=4k -o help "$TEST_IMG"
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o cluster_size=4k -o \? "$TEST_IMG"
|
|
|
|
|
|
|
|
|
|
# Looks like a help option, but is part of the backing file name
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o backing_file="$TEST_IMG",,help "$TEST_IMG"
|
|
|
|
|
run_qemu_img rebase -u -b "" -f $IMGFMT "$TEST_IMG"
|
|
|
|
|
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o backing_file="$TEST_IMG",,\? "$TEST_IMG"
|
|
|
|
|
run_qemu_img rebase -u -b "" -f $IMGFMT "$TEST_IMG"
|
|
|
|
|
|
|
|
|
|
# Try to trick qemu-img into creating escaped commas
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o backing_file="$TEST_IMG", -o help "$TEST_IMG"
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o backing_file="$TEST_IMG" -o ,help "$TEST_IMG"
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o backing_file="$TEST_IMG" -o ,, -o help "$TEST_IMG"
|
|
|
|
|
|
|
|
|
|
# Leave out everything that isn't needed
|
|
|
|
|
run_qemu_img amend -f $IMGFMT -o help
|
2019-04-13 18:20:36 +03:00
|
|
|
|
|
|
|
|
# amend requires specifying either a format explicitly, or a file
|
|
|
|
|
# which it can probe
|
|
|
|
|
run_qemu_img amend -o help
|
2014-02-21 19:24:08 +04:00
|
|
|
|
2018-05-10 00:00:22 +03:00
|
|
|
# Try help option for a format that does not support amendment
|
|
|
|
|
run_qemu_img amend -f bochs -o help
|
|
|
|
|
|
2014-02-21 19:24:08 +04:00
|
|
|
# success, all done
|
|
|
|
|
echo "*** done"
|
|
|
|
|
rm -f $seq.full
|
|
|
|
|
status=0
|