2016-01-29 20:49:55 +03:00
|
|
|
#include "qemu/osdep.h"
|
2018-06-14 22:14:28 +03:00
|
|
|
#include "block/qdict.h" /* for qdict_extract_subqdict() */
|
2018-02-01 14:18:31 +03:00
|
|
|
#include "qapi/error.h"
|
2018-02-27 02:13:27 +03:00
|
|
|
#include "qapi/qapi-commands-misc.h"
|
2018-02-01 14:18:39 +03:00
|
|
|
#include "qapi/qmp/qdict.h"
|
2018-02-01 14:18:38 +03:00
|
|
|
#include "qapi/qmp/qlist.h"
|
2012-12-17 21:20:00 +04:00
|
|
|
#include "qemu/error-report.h"
|
|
|
|
#include "qemu/option.h"
|
|
|
|
#include "qemu/config-file.h"
|
2022-11-11 17:13:23 +03:00
|
|
|
#include "hw/boards.h"
|
2009-07-31 14:25:35 +04:00
|
|
|
|
2015-05-29 15:37:54 +03:00
|
|
|
static QemuOptsList *vm_config_groups[48];
|
2016-10-06 12:33:17 +03:00
|
|
|
static QemuOptsList *drive_config_groups[5];
|
2009-07-31 14:25:36 +04:00
|
|
|
|
2012-03-28 21:14:17 +04:00
|
|
|
static QemuOptsList *find_list(QemuOptsList **lists, const char *group,
|
|
|
|
Error **errp)
|
2009-10-14 12:39:25 +04:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2021-05-18 16:08:17 +03:00
|
|
|
qemu_load_module_for_opts(group);
|
2009-10-14 12:39:25 +04:00
|
|
|
for (i = 0; lists[i] != NULL; i++) {
|
|
|
|
if (strcmp(lists[i]->name, group) == 0)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (lists[i] == NULL) {
|
2014-03-22 03:42:26 +04:00
|
|
|
error_setg(errp, "There is no option group '%s'", group);
|
2009-10-14 12:39:25 +04:00
|
|
|
}
|
|
|
|
return lists[i];
|
|
|
|
}
|
|
|
|
|
2010-03-05 20:21:56 +03:00
|
|
|
QemuOptsList *qemu_find_opts(const char *group)
|
|
|
|
{
|
2012-03-28 21:14:17 +04:00
|
|
|
QemuOptsList *ret;
|
|
|
|
Error *local_err = NULL;
|
|
|
|
|
|
|
|
ret = find_list(vm_config_groups, group, &local_err);
|
2014-01-30 18:07:28 +04:00
|
|
|
if (local_err) {
|
2015-02-12 15:55:05 +03:00
|
|
|
error_report_err(local_err);
|
2012-03-28 21:14:17 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
2010-03-05 20:21:56 +03:00
|
|
|
}
|
|
|
|
|
2014-03-06 13:39:24 +04:00
|
|
|
QemuOpts *qemu_find_opts_singleton(const char *group)
|
|
|
|
{
|
|
|
|
QemuOptsList *list;
|
|
|
|
QemuOpts *opts;
|
|
|
|
|
|
|
|
list = qemu_find_opts(group);
|
|
|
|
assert(list);
|
|
|
|
opts = qemu_opts_find(list, NULL);
|
|
|
|
if (!opts) {
|
|
|
|
opts = qemu_opts_create(list, NULL, 0, &error_abort);
|
|
|
|
}
|
|
|
|
return opts;
|
|
|
|
}
|
|
|
|
|
2013-04-25 13:50:35 +04:00
|
|
|
static CommandLineParameterInfoList *query_option_descs(const QemuOptDesc *desc)
|
|
|
|
{
|
2020-11-13 04:13:37 +03:00
|
|
|
CommandLineParameterInfoList *param_list = NULL;
|
2013-04-25 13:50:35 +04:00
|
|
|
CommandLineParameterInfo *info;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; desc[i].name != NULL; i++) {
|
|
|
|
info = g_malloc0(sizeof(*info));
|
|
|
|
info->name = g_strdup(desc[i].name);
|
|
|
|
|
|
|
|
switch (desc[i].type) {
|
|
|
|
case QEMU_OPT_STRING:
|
|
|
|
info->type = COMMAND_LINE_PARAMETER_TYPE_STRING;
|
|
|
|
break;
|
|
|
|
case QEMU_OPT_BOOL:
|
|
|
|
info->type = COMMAND_LINE_PARAMETER_TYPE_BOOLEAN;
|
|
|
|
break;
|
|
|
|
case QEMU_OPT_NUMBER:
|
|
|
|
info->type = COMMAND_LINE_PARAMETER_TYPE_NUMBER;
|
|
|
|
break;
|
|
|
|
case QEMU_OPT_SIZE:
|
|
|
|
info->type = COMMAND_LINE_PARAMETER_TYPE_SIZE;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2022-11-04 19:06:59 +03:00
|
|
|
info->help = g_strdup(desc[i].help);
|
|
|
|
info->q_default = g_strdup(desc[i].def_value_str);
|
2013-04-25 13:50:35 +04:00
|
|
|
|
2020-11-13 04:13:37 +03:00
|
|
|
QAPI_LIST_PREPEND(param_list, info);
|
2013-04-25 13:50:35 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
return param_list;
|
|
|
|
}
|
|
|
|
|
2013-11-09 08:15:47 +04:00
|
|
|
/* remove repeated entry from the info list */
|
|
|
|
static void cleanup_infolist(CommandLineParameterInfoList *head)
|
|
|
|
{
|
|
|
|
CommandLineParameterInfoList *pre_entry, *cur, *del_entry;
|
|
|
|
|
|
|
|
cur = head;
|
|
|
|
while (cur->next) {
|
|
|
|
pre_entry = head;
|
|
|
|
while (pre_entry != cur->next) {
|
|
|
|
if (!strcmp(pre_entry->value->name, cur->next->value->name)) {
|
|
|
|
del_entry = cur->next;
|
|
|
|
cur->next = cur->next->next;
|
2018-01-04 19:05:18 +03:00
|
|
|
del_entry->next = NULL;
|
|
|
|
qapi_free_CommandLineParameterInfoList(del_entry);
|
2013-11-09 08:15:47 +04:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
pre_entry = pre_entry->next;
|
|
|
|
}
|
|
|
|
cur = cur->next;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* merge the description items of two parameter infolists */
|
|
|
|
static void connect_infolist(CommandLineParameterInfoList *head,
|
|
|
|
CommandLineParameterInfoList *new)
|
|
|
|
{
|
|
|
|
CommandLineParameterInfoList *cur;
|
|
|
|
|
|
|
|
cur = head;
|
|
|
|
while (cur->next) {
|
|
|
|
cur = cur->next;
|
|
|
|
}
|
|
|
|
cur->next = new;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* access all the local QemuOptsLists for drive option */
|
|
|
|
static CommandLineParameterInfoList *get_drive_infolist(void)
|
|
|
|
{
|
|
|
|
CommandLineParameterInfoList *head = NULL, *cur;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; drive_config_groups[i] != NULL; i++) {
|
|
|
|
if (!head) {
|
|
|
|
head = query_option_descs(drive_config_groups[i]->desc);
|
|
|
|
} else {
|
|
|
|
cur = query_option_descs(drive_config_groups[i]->desc);
|
|
|
|
connect_infolist(head, cur);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
cleanup_infolist(head);
|
|
|
|
|
|
|
|
return head;
|
|
|
|
}
|
|
|
|
|
2022-11-11 17:13:23 +03:00
|
|
|
static CommandLineParameterInfo *objprop_to_cmdline_prop(ObjectProperty *prop)
|
|
|
|
{
|
|
|
|
CommandLineParameterInfo *info;
|
|
|
|
|
|
|
|
info = g_malloc0(sizeof(*info));
|
|
|
|
info->name = g_strdup(prop->name);
|
|
|
|
|
|
|
|
if (g_str_equal(prop->type, "bool") || g_str_equal(prop->type, "OnOffAuto")) {
|
|
|
|
info->type = COMMAND_LINE_PARAMETER_TYPE_BOOLEAN;
|
|
|
|
} else if (g_str_equal(prop->type, "int")) {
|
|
|
|
info->type = COMMAND_LINE_PARAMETER_TYPE_NUMBER;
|
|
|
|
} else if (g_str_equal(prop->type, "size")) {
|
|
|
|
info->type = COMMAND_LINE_PARAMETER_TYPE_SIZE;
|
|
|
|
} else {
|
|
|
|
info->type = COMMAND_LINE_PARAMETER_TYPE_STRING;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (prop->description) {
|
|
|
|
info->help = g_strdup(prop->description);
|
|
|
|
}
|
|
|
|
|
|
|
|
return info;
|
|
|
|
}
|
|
|
|
|
|
|
|
static CommandLineParameterInfoList *query_all_machine_properties(void)
|
|
|
|
{
|
|
|
|
CommandLineParameterInfoList *params = NULL, *clpiter;
|
|
|
|
CommandLineParameterInfo *info;
|
|
|
|
GSList *machines, *curr_mach;
|
|
|
|
ObjectPropertyIterator op_iter;
|
|
|
|
ObjectProperty *prop;
|
|
|
|
bool is_new;
|
|
|
|
|
|
|
|
machines = object_class_get_list(TYPE_MACHINE, false);
|
|
|
|
assert(machines);
|
|
|
|
|
|
|
|
/* Loop over all machine classes */
|
|
|
|
for (curr_mach = machines; curr_mach; curr_mach = curr_mach->next) {
|
|
|
|
object_class_property_iter_init(&op_iter, curr_mach->data);
|
|
|
|
/* ... and over the properties of each machine: */
|
|
|
|
while ((prop = object_property_iter_next(&op_iter))) {
|
|
|
|
if (!prop->set) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
/*
|
|
|
|
* Check whether the property has already been put into the list
|
|
|
|
* (via another machine class)
|
|
|
|
*/
|
|
|
|
is_new = true;
|
|
|
|
for (clpiter = params; clpiter != NULL; clpiter = clpiter->next) {
|
|
|
|
if (g_str_equal(clpiter->value->name, prop->name)) {
|
|
|
|
is_new = false;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
/* If it hasn't been added before, add it now to the list */
|
|
|
|
if (is_new) {
|
|
|
|
info = objprop_to_cmdline_prop(prop);
|
|
|
|
QAPI_LIST_PREPEND(params, info);
|
|
|
|
}
|
|
|
|
}
|
2015-04-01 19:47:21 +03:00
|
|
|
}
|
2022-11-11 17:13:23 +03:00
|
|
|
|
|
|
|
g_slist_free(machines);
|
|
|
|
|
|
|
|
/* Add entry for the "type" parameter */
|
|
|
|
info = g_malloc0(sizeof(*info));
|
|
|
|
info->name = g_strdup("type");
|
|
|
|
info->type = COMMAND_LINE_PARAMETER_TYPE_STRING;
|
|
|
|
info->help = g_strdup("machine type");
|
|
|
|
QAPI_LIST_PREPEND(params, info);
|
|
|
|
|
|
|
|
return params;
|
|
|
|
}
|
2015-04-01 19:47:21 +03:00
|
|
|
|
2022-11-04 19:06:59 +03:00
|
|
|
CommandLineOptionInfoList *qmp_query_command_line_options(const char *option,
|
2013-04-25 13:50:35 +04:00
|
|
|
Error **errp)
|
|
|
|
{
|
2020-11-13 04:13:37 +03:00
|
|
|
CommandLineOptionInfoList *conf_list = NULL;
|
2013-04-25 13:50:35 +04:00
|
|
|
CommandLineOptionInfo *info;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; vm_config_groups[i] != NULL; i++) {
|
2022-11-04 19:06:59 +03:00
|
|
|
if (!option || !strcmp(option, vm_config_groups[i]->name)) {
|
2013-04-25 13:50:35 +04:00
|
|
|
info = g_malloc0(sizeof(*info));
|
|
|
|
info->option = g_strdup(vm_config_groups[i]->name);
|
2013-11-09 08:15:47 +04:00
|
|
|
if (!strcmp("drive", vm_config_groups[i]->name)) {
|
|
|
|
info->parameters = get_drive_infolist();
|
|
|
|
} else {
|
|
|
|
info->parameters =
|
|
|
|
query_option_descs(vm_config_groups[i]->desc);
|
|
|
|
}
|
2020-11-13 04:13:37 +03:00
|
|
|
QAPI_LIST_PREPEND(conf_list, info);
|
2013-04-25 13:50:35 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-11-04 19:06:59 +03:00
|
|
|
if (!option || !strcmp(option, "machine")) {
|
2021-07-21 18:10:55 +03:00
|
|
|
info = g_malloc0(sizeof(*info));
|
|
|
|
info->option = g_strdup("machine");
|
2022-11-11 17:13:23 +03:00
|
|
|
info->parameters = query_all_machine_properties();
|
2021-07-21 18:10:55 +03:00
|
|
|
QAPI_LIST_PREPEND(conf_list, info);
|
|
|
|
}
|
|
|
|
|
2013-04-25 13:50:35 +04:00
|
|
|
if (conf_list == NULL) {
|
|
|
|
error_setg(errp, "invalid option name: %s", option);
|
|
|
|
}
|
|
|
|
|
|
|
|
return conf_list;
|
|
|
|
}
|
|
|
|
|
2012-03-28 21:16:37 +04:00
|
|
|
QemuOptsList *qemu_find_opts_err(const char *group, Error **errp)
|
|
|
|
{
|
|
|
|
return find_list(vm_config_groups, group, errp);
|
|
|
|
}
|
|
|
|
|
2013-11-09 08:15:47 +04:00
|
|
|
void qemu_add_drive_opts(QemuOptsList *list)
|
|
|
|
{
|
|
|
|
int entries, i;
|
|
|
|
|
|
|
|
entries = ARRAY_SIZE(drive_config_groups);
|
|
|
|
entries--; /* keep list NULL terminated */
|
|
|
|
for (i = 0; i < entries; i++) {
|
|
|
|
if (drive_config_groups[i] == NULL) {
|
|
|
|
drive_config_groups[i] = list;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
fprintf(stderr, "ran out of space in drive_config_groups");
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
|
2010-08-20 15:52:00 +04:00
|
|
|
void qemu_add_opts(QemuOptsList *list)
|
|
|
|
{
|
|
|
|
int entries, i;
|
|
|
|
|
|
|
|
entries = ARRAY_SIZE(vm_config_groups);
|
|
|
|
entries--; /* keep list NULL terminated */
|
|
|
|
for (i = 0; i < entries; i++) {
|
|
|
|
if (vm_config_groups[i] == NULL) {
|
|
|
|
vm_config_groups[i] = list;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
fprintf(stderr, "ran out of space in vm_config_groups");
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
|
2017-10-04 05:50:42 +03:00
|
|
|
/* Returns number of config groups on success, -errno on error */
|
2021-05-24 13:57:50 +03:00
|
|
|
static int qemu_config_foreach(FILE *fp, QEMUConfigCB *cb, void *opaque,
|
|
|
|
const char *fname, Error **errp)
|
2009-10-14 12:39:27 +04:00
|
|
|
{
|
2022-11-21 11:50:51 +03:00
|
|
|
ERRP_GUARD();
|
2021-05-24 13:57:50 +03:00
|
|
|
char line[1024], prev_group[64], group[64], arg[64], value[1024];
|
2010-02-18 21:48:33 +03:00
|
|
|
Location loc;
|
2021-05-24 13:57:50 +03:00
|
|
|
QDict *qdict = NULL;
|
2017-10-04 05:50:42 +03:00
|
|
|
int res = -EINVAL, lno = 0;
|
|
|
|
int count = 0;
|
2009-10-14 12:39:27 +04:00
|
|
|
|
2010-02-18 21:48:33 +03:00
|
|
|
loc_push_none(&loc);
|
2009-10-14 12:39:27 +04:00
|
|
|
while (fgets(line, sizeof(line), fp) != NULL) {
|
2021-05-24 13:57:50 +03:00
|
|
|
++lno;
|
2009-10-14 12:39:27 +04:00
|
|
|
if (line[0] == '\n') {
|
|
|
|
/* skip empty lines */
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (line[0] == '#') {
|
|
|
|
/* comment */
|
|
|
|
continue;
|
|
|
|
}
|
2021-05-24 13:57:50 +03:00
|
|
|
if (line[0] == '[') {
|
|
|
|
QDict *prev = qdict;
|
|
|
|
if (sscanf(line, "[%63s \"%63[^\"]\"]", group, value) == 2) {
|
|
|
|
qdict = qdict_new();
|
|
|
|
qdict_put_str(qdict, "id", value);
|
|
|
|
count++;
|
|
|
|
} else if (sscanf(line, "[%63[^]]]", group) == 1) {
|
|
|
|
qdict = qdict_new();
|
|
|
|
count++;
|
2012-03-28 21:14:17 +04:00
|
|
|
}
|
2021-05-24 13:57:50 +03:00
|
|
|
if (qdict != prev) {
|
|
|
|
if (prev) {
|
2022-11-21 11:50:51 +03:00
|
|
|
cb(prev_group, prev, opaque, errp);
|
2021-05-24 13:57:50 +03:00
|
|
|
qobject_unref(prev);
|
2022-11-21 11:50:51 +03:00
|
|
|
if (*errp) {
|
2021-05-24 13:57:50 +03:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
strcpy(prev_group, group);
|
|
|
|
continue;
|
2012-03-28 21:14:17 +04:00
|
|
|
}
|
2009-10-14 12:39:27 +04:00
|
|
|
}
|
2021-05-24 13:57:50 +03:00
|
|
|
loc_set_file(fname, lno);
|
2015-04-08 20:57:31 +03:00
|
|
|
value[0] = '\0';
|
|
|
|
if (sscanf(line, " %63s = \"%1023[^\"]\"", arg, value) == 2 ||
|
|
|
|
sscanf(line, " %63s = \"\"", arg) == 1) {
|
2009-10-14 12:39:27 +04:00
|
|
|
/* arg = value */
|
2021-05-24 13:57:50 +03:00
|
|
|
if (qdict == NULL) {
|
2021-02-26 20:08:16 +03:00
|
|
|
error_setg(errp, "no group defined");
|
2010-02-18 21:48:33 +03:00
|
|
|
goto out;
|
2009-10-14 12:39:27 +04:00
|
|
|
}
|
2021-05-24 13:57:50 +03:00
|
|
|
qdict_put_str(qdict, arg, value);
|
2009-10-14 12:39:27 +04:00
|
|
|
continue;
|
|
|
|
}
|
2021-02-26 20:08:16 +03:00
|
|
|
error_setg(errp, "parse error");
|
2010-02-18 21:48:33 +03:00
|
|
|
goto out;
|
2009-10-14 12:39:27 +04:00
|
|
|
}
|
2010-02-18 21:56:01 +03:00
|
|
|
if (ferror(fp)) {
|
2021-02-26 20:08:16 +03:00
|
|
|
loc_pop(&loc);
|
|
|
|
error_setg_errno(errp, errno, "Cannot read config file");
|
2021-07-05 20:14:37 +03:00
|
|
|
goto out_no_loc;
|
2010-02-18 21:56:01 +03:00
|
|
|
}
|
2017-10-04 05:50:42 +03:00
|
|
|
res = count;
|
2021-05-24 13:57:50 +03:00
|
|
|
if (qdict) {
|
|
|
|
cb(group, qdict, opaque, errp);
|
|
|
|
}
|
2021-07-05 20:14:37 +03:00
|
|
|
out:
|
2010-02-18 21:48:33 +03:00
|
|
|
loc_pop(&loc);
|
2021-07-05 20:14:37 +03:00
|
|
|
out_no_loc:
|
2021-07-05 20:14:37 +03:00
|
|
|
qobject_unref(qdict);
|
2010-02-18 21:48:33 +03:00
|
|
|
return res;
|
2009-10-14 12:39:27 +04:00
|
|
|
}
|
2010-03-05 19:25:55 +03:00
|
|
|
|
2021-05-24 13:57:50 +03:00
|
|
|
void qemu_config_do_parse(const char *group, QDict *qdict, void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
QemuOptsList **lists = opaque;
|
|
|
|
QemuOptsList *list;
|
|
|
|
|
|
|
|
list = find_list(lists, group, errp);
|
|
|
|
if (!list) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2021-06-09 15:34:35 +03:00
|
|
|
qemu_opts_from_qdict(list, qdict, errp);
|
2021-05-24 13:57:50 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
int qemu_config_parse(FILE *fp, QemuOptsList **lists, const char *fname, Error **errp)
|
|
|
|
{
|
|
|
|
return qemu_config_foreach(fp, qemu_config_do_parse, lists, fname, errp);
|
|
|
|
}
|
|
|
|
|
|
|
|
int qemu_read_config_file(const char *filename, QEMUConfigCB *cb, Error **errp)
|
2010-03-05 19:25:55 +03:00
|
|
|
{
|
|
|
|
FILE *f = fopen(filename, "r");
|
2010-05-17 12:36:47 +04:00
|
|
|
int ret;
|
|
|
|
|
2010-03-05 19:25:55 +03:00
|
|
|
if (f == NULL) {
|
2021-02-26 20:08:16 +03:00
|
|
|
error_setg_file_open(errp, errno, filename);
|
2010-03-05 19:25:55 +03:00
|
|
|
return -errno;
|
|
|
|
}
|
|
|
|
|
2021-05-24 13:57:50 +03:00
|
|
|
ret = qemu_config_foreach(f, cb, vm_config_groups, filename, errp);
|
2010-03-05 19:25:55 +03:00
|
|
|
fclose(f);
|
2017-10-04 05:50:42 +03:00
|
|
|
return ret;
|
2010-03-05 19:25:55 +03:00
|
|
|
}
|
2013-12-20 22:28:05 +04:00
|
|
|
|
2022-11-21 11:50:50 +03:00
|
|
|
static bool config_parse_qdict_section(QDict *options, QemuOptsList *opts,
|
2013-12-20 22:28:05 +04:00
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
QemuOpts *subopts;
|
2022-11-21 11:50:50 +03:00
|
|
|
g_autoptr(QDict) subqdict = NULL;
|
|
|
|
g_autoptr(QList) list = NULL;
|
2013-12-20 22:28:05 +04:00
|
|
|
size_t orig_size, enum_size;
|
|
|
|
char *prefix;
|
|
|
|
|
|
|
|
prefix = g_strdup_printf("%s.", opts->name);
|
|
|
|
qdict_extract_subqdict(options, &subqdict, prefix);
|
|
|
|
g_free(prefix);
|
|
|
|
orig_size = qdict_size(subqdict);
|
|
|
|
if (!orig_size) {
|
2022-11-21 11:50:50 +03:00
|
|
|
return true;
|
2013-12-20 22:28:05 +04:00
|
|
|
}
|
|
|
|
|
2020-07-07 19:05:35 +03:00
|
|
|
subopts = qemu_opts_create(opts, NULL, 0, errp);
|
|
|
|
if (!subopts) {
|
2022-11-21 11:50:50 +03:00
|
|
|
return false;
|
2013-12-20 22:28:05 +04:00
|
|
|
}
|
|
|
|
|
error: Eliminate error_propagate() with Coccinelle, part 1
When all we do with an Error we receive into a local variable is
propagating to somewhere else, we can just as well receive it there
right away. Convert
if (!foo(..., &err)) {
...
error_propagate(errp, err);
...
return ...
}
to
if (!foo(..., errp)) {
...
...
return ...
}
where nothing else needs @err. Coccinelle script:
@rule1 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
binary operator op;
constant c1, c2;
symbol false;
@@
if (
(
- fun(args, &err, args2)
+ fun(args, errp, args2)
|
- !fun(args, &err, args2)
+ !fun(args, errp, args2)
|
- fun(args, &err, args2) op c1
+ fun(args, errp, args2) op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
)
}
@rule2 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
expression var;
binary operator op;
constant c1, c2;
symbol false;
@@
- var = fun(args, &err, args2);
+ var = fun(args, errp, args2);
... when != err
if (
(
var
|
!var
|
var op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
|
return var;
)
}
@depends on rule1 || rule2@
identifier err;
@@
- Error *err = NULL;
... when != err
Not exactly elegant, I'm afraid.
The "when != lbl:" is necessary to avoid transforming
if (fun(args, &err)) {
goto out
}
...
out:
error_propagate(errp, err);
even though other paths to label out still need the error_propagate().
For an actual example, see sclp_realize().
Without the "when strict", Coccinelle transforms vfio_msix_setup(),
incorrectly. I don't know what exactly "when strict" does, only that
it helps here.
The match of return is narrower than what I want, but I can't figure
out how to express "return where the operand doesn't use @err". For
an example where it's too narrow, see vfio_intx_enable().
Silently fails to convert hw/arm/armsse.c, because Coccinelle gets
confused by ARMSSE being used both as typedef and function-like macro
there. Converted manually.
Line breaks tidied up manually. One nested declaration of @local_err
deleted manually. Preexisting unwanted blank line dropped in
hw/riscv/sifive_e.c.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-35-armbru@redhat.com>
2020-07-07 19:06:02 +03:00
|
|
|
if (!qemu_opts_absorb_qdict(subopts, subqdict, errp)) {
|
2022-11-21 11:50:50 +03:00
|
|
|
return false;
|
2013-12-20 22:28:05 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
enum_size = qdict_size(subqdict);
|
|
|
|
if (enum_size < orig_size && enum_size) {
|
|
|
|
error_setg(errp, "Unknown option '%s' for [%s]",
|
|
|
|
qdict_first(subqdict)->key, opts->name);
|
2022-11-21 11:50:50 +03:00
|
|
|
return false;
|
2013-12-20 22:28:05 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
if (enum_size) {
|
|
|
|
/* Multiple, enumerated sections */
|
|
|
|
QListEntry *list_entry;
|
|
|
|
unsigned i = 0;
|
|
|
|
|
|
|
|
/* Not required anymore */
|
|
|
|
qemu_opts_del(subopts);
|
|
|
|
|
|
|
|
qdict_array_split(subqdict, &list);
|
|
|
|
if (qdict_size(subqdict)) {
|
|
|
|
error_setg(errp, "Unused option '%s' for [%s]",
|
|
|
|
qdict_first(subqdict)->key, opts->name);
|
2022-11-21 11:50:50 +03:00
|
|
|
return false;
|
2013-12-20 22:28:05 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
QLIST_FOREACH_ENTRY(list, list_entry) {
|
2018-02-24 18:40:29 +03:00
|
|
|
QDict *section = qobject_to(QDict, qlist_entry_obj(list_entry));
|
2013-12-20 22:28:05 +04:00
|
|
|
char *opt_name;
|
|
|
|
|
2014-02-21 22:11:39 +04:00
|
|
|
if (!section) {
|
|
|
|
error_setg(errp, "[%s] section (index %u) does not consist of "
|
|
|
|
"keys", opts->name, i);
|
2022-11-21 11:50:50 +03:00
|
|
|
return false;
|
2014-02-21 22:11:39 +04:00
|
|
|
}
|
|
|
|
|
2013-12-20 22:28:05 +04:00
|
|
|
opt_name = g_strdup_printf("%s.%u", opts->name, i++);
|
2020-07-07 19:05:35 +03:00
|
|
|
subopts = qemu_opts_create(opts, opt_name, 1, errp);
|
2013-12-20 22:28:05 +04:00
|
|
|
g_free(opt_name);
|
2020-07-07 19:05:35 +03:00
|
|
|
if (!subopts) {
|
2022-11-21 11:50:50 +03:00
|
|
|
return false;
|
2013-12-20 22:28:05 +04:00
|
|
|
}
|
|
|
|
|
error: Eliminate error_propagate() with Coccinelle, part 1
When all we do with an Error we receive into a local variable is
propagating to somewhere else, we can just as well receive it there
right away. Convert
if (!foo(..., &err)) {
...
error_propagate(errp, err);
...
return ...
}
to
if (!foo(..., errp)) {
...
...
return ...
}
where nothing else needs @err. Coccinelle script:
@rule1 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
binary operator op;
constant c1, c2;
symbol false;
@@
if (
(
- fun(args, &err, args2)
+ fun(args, errp, args2)
|
- !fun(args, &err, args2)
+ !fun(args, errp, args2)
|
- fun(args, &err, args2) op c1
+ fun(args, errp, args2) op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
)
}
@rule2 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
expression var;
binary operator op;
constant c1, c2;
symbol false;
@@
- var = fun(args, &err, args2);
+ var = fun(args, errp, args2);
... when != err
if (
(
var
|
!var
|
var op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
|
return var;
)
}
@depends on rule1 || rule2@
identifier err;
@@
- Error *err = NULL;
... when != err
Not exactly elegant, I'm afraid.
The "when != lbl:" is necessary to avoid transforming
if (fun(args, &err)) {
goto out
}
...
out:
error_propagate(errp, err);
even though other paths to label out still need the error_propagate().
For an actual example, see sclp_realize().
Without the "when strict", Coccinelle transforms vfio_msix_setup(),
incorrectly. I don't know what exactly "when strict" does, only that
it helps here.
The match of return is narrower than what I want, but I can't figure
out how to express "return where the operand doesn't use @err". For
an example where it's too narrow, see vfio_intx_enable().
Silently fails to convert hw/arm/armsse.c, because Coccinelle gets
confused by ARMSSE being used both as typedef and function-like macro
there. Converted manually.
Line breaks tidied up manually. One nested declaration of @local_err
deleted manually. Preexisting unwanted blank line dropped in
hw/riscv/sifive_e.c.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-35-armbru@redhat.com>
2020-07-07 19:06:02 +03:00
|
|
|
if (!qemu_opts_absorb_qdict(subopts, section, errp)) {
|
2013-12-20 22:28:05 +04:00
|
|
|
qemu_opts_del(subopts);
|
2022-11-21 11:50:50 +03:00
|
|
|
return false;
|
2013-12-20 22:28:05 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
if (qdict_size(section)) {
|
|
|
|
error_setg(errp, "[%s] section doesn't support the option '%s'",
|
|
|
|
opts->name, qdict_first(section)->key);
|
|
|
|
qemu_opts_del(subopts);
|
2022-11-21 11:50:50 +03:00
|
|
|
return false;
|
2013-12-20 22:28:05 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-11-21 11:50:50 +03:00
|
|
|
return true;
|
2013-12-20 22:28:05 +04:00
|
|
|
}
|
|
|
|
|
2022-11-21 11:50:50 +03:00
|
|
|
bool qemu_config_parse_qdict(QDict *options, QemuOptsList **lists,
|
2013-12-20 22:28:05 +04:00
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; lists[i]; i++) {
|
2022-11-21 11:50:50 +03:00
|
|
|
if (!config_parse_qdict_section(options, lists[i], errp)) {
|
|
|
|
return false;
|
2013-12-20 22:28:05 +04:00
|
|
|
}
|
|
|
|
}
|
2022-11-21 11:50:50 +03:00
|
|
|
|
|
|
|
return true;
|
2013-12-20 22:28:05 +04:00
|
|
|
}
|