2016-05-12 15:22:29 +03:00
|
|
|
/*
|
|
|
|
* SABRELITE Board System emulation.
|
|
|
|
*
|
|
|
|
* Copyright (c) 2015 Jean-Christophe Dubois <jcd@tribudubois.net>
|
|
|
|
*
|
|
|
|
* This code is licensed under the GPL, version 2 or later.
|
|
|
|
* See the file `COPYING' in the top level directory.
|
|
|
|
*
|
|
|
|
* It (partially) emulates a sabrelite board, with a Freescale
|
|
|
|
* i.MX6 SoC
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "qemu/osdep.h"
|
|
|
|
#include "qapi/error.h"
|
|
|
|
#include "hw/arm/fsl-imx6.h"
|
|
|
|
#include "hw/boards.h"
|
2019-08-12 08:23:51 +03:00
|
|
|
#include "hw/qdev-properties.h"
|
2016-05-12 15:22:29 +03:00
|
|
|
#include "sysemu/sysemu.h"
|
|
|
|
#include "qemu/error-report.h"
|
|
|
|
#include "sysemu/qtest.h"
|
|
|
|
|
|
|
|
static struct arm_boot_info sabrelite_binfo = {
|
|
|
|
/* DDR memory start */
|
|
|
|
.loader_start = FSL_IMX6_MMDC_ADDR,
|
|
|
|
/* No board ID, we boot from DT tree */
|
|
|
|
.board_id = -1,
|
|
|
|
};
|
|
|
|
|
|
|
|
/* No need to do any particular setup for secondary boot */
|
|
|
|
static void sabrelite_write_secondary(ARMCPU *cpu,
|
|
|
|
const struct arm_boot_info *info)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Secondary cores are reset through SRC device */
|
|
|
|
static void sabrelite_reset_secondary(ARMCPU *cpu,
|
|
|
|
const struct arm_boot_info *info)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sabrelite_init(MachineState *machine)
|
|
|
|
{
|
2020-02-19 19:09:02 +03:00
|
|
|
FslIMX6State *s;
|
2016-05-12 15:22:29 +03:00
|
|
|
|
|
|
|
/* Check the amount of memory is compatible with the SOC */
|
|
|
|
if (machine->ram_size > FSL_IMX6_MMDC_SIZE) {
|
|
|
|
error_report("RAM size " RAM_ADDR_FMT " above max supported (%08x)",
|
|
|
|
machine->ram_size, FSL_IMX6_MMDC_SIZE);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
|
2020-02-19 19:09:02 +03:00
|
|
|
s = FSL_IMX6(object_new(TYPE_FSL_IMX6));
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 18:29:22 +03:00
|
|
|
object_property_add_child(OBJECT(machine), "soc", OBJECT(s));
|
qdev: Convert bus-less devices to qdev_realize() with Coccinelle
All remaining conversions to qdev_realize() are for bus-less devices.
Coccinelle script:
// only correct for bus-less @dev!
@@
expression errp;
expression dev;
@@
- qdev_init_nofail(dev);
+ qdev_realize(dev, NULL, &error_fatal);
@ depends on !(file in "hw/core/qdev.c") && !(file in "hw/core/bus.c")@
expression errp;
expression dev;
symbol true;
@@
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize(DEVICE(dev), NULL, errp);
@ depends on !(file in "hw/core/qdev.c") && !(file in "hw/core/bus.c")@
expression errp;
expression dev;
symbol true;
@@
- object_property_set_bool(dev, true, "realized", errp);
+ qdev_realize(DEVICE(dev), NULL, errp);
Note that Coccinelle chokes on ARMSSE typedef vs. macro in
hw/arm/armsse.c. Worked around by temporarily renaming the macro for
the spatch run.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-57-armbru@redhat.com>
2020-06-10 08:32:45 +03:00
|
|
|
qdev_realize(DEVICE(s), NULL, &error_fatal);
|
2016-05-12 15:22:29 +03:00
|
|
|
|
|
|
|
memory_region_add_subregion(get_system_memory(), FSL_IMX6_MMDC_ADDR,
|
2020-02-19 19:09:02 +03:00
|
|
|
machine->ram);
|
2016-05-12 15:22:29 +03:00
|
|
|
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* TODO: Ideally we would expose the chip select and spi bus on the
|
|
|
|
* SoC object using alias properties; then we would not need to
|
|
|
|
* directly access the underlying spi device object.
|
|
|
|
*/
|
|
|
|
/* Add the sst25vf016b NOR FLASH memory to first SPI */
|
|
|
|
Object *spi_dev;
|
|
|
|
|
2020-02-19 19:09:02 +03:00
|
|
|
spi_dev = object_resolve_path_component(OBJECT(s), "spi1");
|
2016-05-12 15:22:29 +03:00
|
|
|
if (spi_dev) {
|
|
|
|
SSIBus *spi_bus;
|
|
|
|
|
|
|
|
spi_bus = (SSIBus *)qdev_get_child_bus(DEVICE(spi_dev), "spi");
|
|
|
|
if (spi_bus) {
|
|
|
|
DeviceState *flash_dev;
|
2016-07-04 15:06:37 +03:00
|
|
|
qemu_irq cs_line;
|
|
|
|
DriveInfo *dinfo = drive_get_next(IF_MTD);
|
|
|
|
|
ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle
Replace
dev = ssi_create_slave_no_init(bus, type_name);
...
qdev_init_nofail(dev);
by
dev = qdev_new(type_name);
...
qdev_realize_and_unref(dev, bus, &error_fatal);
Recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains
why.
@@
type SSIBus;
identifier bus;
expression dev, qbus, expr;
expression list args;
@@
- bus = (SSIBus *)qbus;
+ bus = qbus; // TODO fix up decl
...
- dev = ssi_create_slave_no_init(bus, args);
+ dev = qdev_new(args);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = ssi_create_slave_no_init(bus, args);
+ dev = qdev_new(args);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, BUS(bus), &error_fatal);
Bus declarations fixed up manually.
Cc: Alistair Francis <alistair@alistair23.me>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-24-armbru@redhat.com>
2020-06-10 08:32:12 +03:00
|
|
|
flash_dev = qdev_new("sst25vf016b");
|
2016-07-04 15:06:37 +03:00
|
|
|
if (dinfo) {
|
qdev: Make qdev_prop_set_drive() match the other helpers
qdev_prop_set_drive() can fail. None of the other qdev_prop_set_FOO()
can; they abort on error.
To clean up this inconsistency, rename qdev_prop_set_drive() to
qdev_prop_set_drive_err(), and create a qdev_prop_set_drive() that
aborts on error.
Coccinelle script to update callers:
@ depends on !(file in "hw/core/qdev-properties-system.c")@
expression dev, name, value;
symbol error_abort;
@@
- qdev_prop_set_drive(dev, name, value, &error_abort);
+ qdev_prop_set_drive(dev, name, value);
@@
expression dev, name, value, errp;
@@
- qdev_prop_set_drive(dev, name, value, errp);
+ qdev_prop_set_drive_err(dev, name, value, errp);
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200622094227.1271650-14-armbru@redhat.com>
2020-06-22 12:42:24 +03:00
|
|
|
qdev_prop_set_drive_err(flash_dev, "drive",
|
|
|
|
blk_by_legacy_dinfo(dinfo),
|
|
|
|
&error_fatal);
|
2016-05-12 15:22:29 +03:00
|
|
|
}
|
ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle
Replace
dev = ssi_create_slave_no_init(bus, type_name);
...
qdev_init_nofail(dev);
by
dev = qdev_new(type_name);
...
qdev_realize_and_unref(dev, bus, &error_fatal);
Recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains
why.
@@
type SSIBus;
identifier bus;
expression dev, qbus, expr;
expression list args;
@@
- bus = (SSIBus *)qbus;
+ bus = qbus; // TODO fix up decl
...
- dev = ssi_create_slave_no_init(bus, args);
+ dev = qdev_new(args);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = ssi_create_slave_no_init(bus, args);
+ dev = qdev_new(args);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, BUS(bus), &error_fatal);
Bus declarations fixed up manually.
Cc: Alistair Francis <alistair@alistair23.me>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-24-armbru@redhat.com>
2020-06-10 08:32:12 +03:00
|
|
|
qdev_realize_and_unref(flash_dev, BUS(spi_bus), &error_fatal);
|
2016-07-04 15:06:37 +03:00
|
|
|
|
|
|
|
cs_line = qdev_get_gpio_in_named(flash_dev, SSI_GPIO_CS, 0);
|
|
|
|
sysbus_connect_irq(SYS_BUS_DEVICE(spi_dev), 1, cs_line);
|
2016-05-12 15:22:29 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
sabrelite_binfo.ram_size = machine->ram_size;
|
2019-05-18 23:54:26 +03:00
|
|
|
sabrelite_binfo.nb_cpus = machine->smp.cpus;
|
2016-05-12 15:22:29 +03:00
|
|
|
sabrelite_binfo.secure_boot = true;
|
|
|
|
sabrelite_binfo.write_secondary_boot = sabrelite_write_secondary;
|
|
|
|
sabrelite_binfo.secondary_cpu_reset_hook = sabrelite_reset_secondary;
|
|
|
|
|
|
|
|
if (!qtest_enabled()) {
|
2020-02-19 19:09:02 +03:00
|
|
|
arm_load_kernel(&s->cpu[0], machine, &sabrelite_binfo);
|
2016-05-12 15:22:29 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sabrelite_machine_init(MachineClass *mc)
|
|
|
|
{
|
|
|
|
mc->desc = "Freescale i.MX6 Quad SABRE Lite Board (Cortex A9)";
|
|
|
|
mc->init = sabrelite_init;
|
|
|
|
mc->max_cpus = FSL_IMX6_NUM_CPUS;
|
2017-09-07 15:54:54 +03:00
|
|
|
mc->ignore_memory_transaction_failures = true;
|
2020-02-19 19:09:02 +03:00
|
|
|
mc->default_ram_id = "sabrelite.ram";
|
2016-05-12 15:22:29 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
DEFINE_MACHINE("sabrelite", sabrelite_machine_init)
|