qemu/tests/qapi-schema/features-if-invalid.json

# Cover feature with invalid 'if'
{ 'struct': 'Stru',
  'data': {},
  'features': [{'name': 'f', 'if': false }] }
tests/qapi-schema: Demonstrate insufficient 'if' checking Cover invalid 'if' in struct members, features, union and alternate branches. Four out of four are broken. Mark FIXME. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20190914153506.2151-6-armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> [Comment typo fixed] 2019-09-14 18:34:52 +03:00			`# Cover feature with invalid 'if'`
			`{ 'struct': 'Stru',`
			`'data': {},`
qapi: Remove null from schema language We represent the parse tree as OrderedDict. We fetch optional dict members with .get(). So far, so good. We represent null literals as None. .get() returns None both for "absent" and for "present, value is the null literal". Uh-oh. Test features-if-invalid exposes this bug: "'if': null" is misinterpreted as absent "if". We added null to the schema language to "allow [...] an explicit default value" (commit e53188ada5 "qapi: Allow true, false and null in schema json", v2.4.0). Hasn't happened; null is still unused except as generic invalid value in tests/. To fix, we'd have to replace .get() by something more careful, or represent null differently. Feasible, but we got more and bigger fish to fry right now. Remove the null literal from the schema language. Replace null in tests by another invalid value. Test features-if-invalid now behaves as it should. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20190914153506.2151-10-armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> 2019-09-14 18:34:56 +03:00			`'features': [{'name': 'f', 'if': false }] }`