2007-08-01 03:28:53 +04:00
|
|
|
/*
|
|
|
|
* Block driver for Parallels disk image format
|
|
|
|
*
|
|
|
|
* Copyright (c) 2007 Alex Beregszaszi
|
2015-04-28 10:46:46 +03:00
|
|
|
* Copyright (c) 2015 Denis V. Lunev <den@openvz.org>
|
2007-08-01 03:28:53 +04:00
|
|
|
*
|
2015-04-28 10:46:46 +03:00
|
|
|
* This code was originally based on comparing different disk images created
|
|
|
|
* by Parallels. Currently it is based on opened OpenVZ sources
|
|
|
|
* available at
|
|
|
|
* http://git.openvz.org/?p=ploop;a=summary
|
2007-08-01 03:28:53 +04:00
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
|
|
* in the Software without restriction, including without limitation the rights
|
|
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
|
|
* furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice shall be included in
|
|
|
|
* all copies or substantial portions of the Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
|
|
* THE SOFTWARE.
|
|
|
|
*/
|
2018-02-01 14:18:46 +03:00
|
|
|
|
2016-01-18 21:01:42 +03:00
|
|
|
#include "qemu/osdep.h"
|
2021-02-24 13:47:05 +03:00
|
|
|
#include "qemu/error-report.h"
|
include/qemu/osdep.h: Don't include qapi/error.h
Commit 57cb38b included qapi/error.h into qemu/osdep.h to get the
Error typedef. Since then, we've moved to include qemu/osdep.h
everywhere. Its file comment explains: "To avoid getting into
possible circular include dependencies, this file should not include
any other QEMU headers, with the exceptions of config-host.h,
compiler.h, os-posix.h and os-win32.h, all of which are doing a
similar job to this file and are under similar constraints."
qapi/error.h doesn't do a similar job, and it doesn't adhere to
similar constraints: it includes qapi-types.h. That's in excess of
100KiB of crap most .c files don't actually need.
Add the typedef to qemu/typedefs.h, and include that instead of
qapi/error.h. Include qapi/error.h in .c files that need it and don't
get it now. Include qapi-types.h in qom/object.h for uint16List.
Update scripts/clean-includes accordingly. Update it further to match
reality: replace config.h by config-target.h, add sysemu/os-posix.h,
sysemu/os-win32.h. Update the list of includes in the qemu/osdep.h
comment quoted above similarly.
This reduces the number of objects depending on qapi/error.h from "all
of them" to less than a third. Unfortunately, the number depending on
qapi-types.h shrinks only a little. More work is needed for that one.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
[Fix compilation without the spice devel packages. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2016-03-14 11:01:28 +03:00
|
|
|
#include "qapi/error.h"
|
2012-12-17 21:19:44 +04:00
|
|
|
#include "block/block_int.h"
|
2018-06-14 22:14:28 +03:00
|
|
|
#include "block/qdict.h"
|
2016-03-08 17:57:05 +03:00
|
|
|
#include "sysemu/block-backend.h"
|
2012-12-17 21:20:00 +04:00
|
|
|
#include "qemu/module.h"
|
2018-02-01 14:18:46 +03:00
|
|
|
#include "qemu/option.h"
|
2018-03-06 14:13:58 +03:00
|
|
|
#include "qapi/qmp/qdict.h"
|
|
|
|
#include "qapi/qobject-input-visitor.h"
|
|
|
|
#include "qapi/qapi-visit-block-core.h"
|
2016-03-15 19:22:36 +03:00
|
|
|
#include "qemu/bswap.h"
|
2015-04-28 10:46:57 +03:00
|
|
|
#include "qemu/bitmap.h"
|
2022-02-26 21:07:23 +03:00
|
|
|
#include "qemu/memalign.h"
|
2017-11-07 16:10:35 +03:00
|
|
|
#include "migration/blocker.h"
|
2018-01-12 12:01:20 +03:00
|
|
|
#include "parallels.h"
|
2007-08-01 03:28:53 +04:00
|
|
|
|
|
|
|
/**************************************************************/
|
|
|
|
|
|
|
|
#define HEADER_MAGIC "WithoutFreeSpace"
|
2014-07-28 20:23:55 +04:00
|
|
|
#define HEADER_MAGIC2 "WithouFreSpacExt"
|
2007-08-01 03:28:53 +04:00
|
|
|
#define HEADER_VERSION 2
|
2015-04-28 10:46:53 +03:00
|
|
|
#define HEADER_INUSE_MAGIC (0x746F6E59)
|
2016-07-27 20:08:20 +03:00
|
|
|
#define MAX_PARALLELS_IMAGE_FACTOR (1ull << 32)
|
2007-08-01 03:28:53 +04:00
|
|
|
|
2017-08-24 11:46:10 +03:00
|
|
|
static QEnumLookup prealloc_mode_lookup = {
|
|
|
|
.array = (const char *const[]) {
|
|
|
|
"falloc",
|
|
|
|
"truncate",
|
|
|
|
},
|
|
|
|
.size = PRL_PREALLOC_MODE__MAX
|
2015-04-28 10:46:58 +03:00
|
|
|
};
|
|
|
|
|
|
|
|
#define PARALLELS_OPT_PREALLOC_MODE "prealloc-mode"
|
|
|
|
#define PARALLELS_OPT_PREALLOC_SIZE "prealloc-size"
|
|
|
|
|
|
|
|
static QemuOptsList parallels_runtime_opts = {
|
|
|
|
.name = "parallels",
|
|
|
|
.head = QTAILQ_HEAD_INITIALIZER(parallels_runtime_opts.head),
|
|
|
|
.desc = {
|
|
|
|
{
|
|
|
|
.name = PARALLELS_OPT_PREALLOC_SIZE,
|
|
|
|
.type = QEMU_OPT_SIZE,
|
|
|
|
.help = "Preallocation size on image expansion",
|
2017-03-20 12:27:02 +03:00
|
|
|
.def_value_str = "128M",
|
2015-04-28 10:46:58 +03:00
|
|
|
},
|
|
|
|
{
|
|
|
|
.name = PARALLELS_OPT_PREALLOC_MODE,
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "Preallocation mode on image expansion "
|
|
|
|
"(allowed values: falloc, truncate)",
|
|
|
|
.def_value_str = "falloc",
|
|
|
|
},
|
|
|
|
{ /* end of list */ },
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2018-03-06 14:13:58 +03:00
|
|
|
static QemuOptsList parallels_create_opts = {
|
|
|
|
.name = "parallels-create-opts",
|
|
|
|
.head = QTAILQ_HEAD_INITIALIZER(parallels_create_opts.head),
|
|
|
|
.desc = {
|
|
|
|
{
|
|
|
|
.name = BLOCK_OPT_SIZE,
|
|
|
|
.type = QEMU_OPT_SIZE,
|
|
|
|
.help = "Virtual disk size",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.name = BLOCK_OPT_CLUSTER_SIZE,
|
|
|
|
.type = QEMU_OPT_SIZE,
|
|
|
|
.help = "Parallels image cluster size",
|
|
|
|
.def_value_str = stringify(DEFAULT_CLUSTER_SIZE),
|
|
|
|
},
|
|
|
|
{ /* end of list */ }
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2015-04-28 10:46:58 +03:00
|
|
|
|
2015-04-28 10:46:48 +03:00
|
|
|
static int64_t bat2sect(BDRVParallelsState *s, uint32_t idx)
|
|
|
|
{
|
2015-04-28 10:46:49 +03:00
|
|
|
return (uint64_t)le32_to_cpu(s->bat_bitmap[idx]) * s->off_multiplier;
|
2015-04-28 10:46:48 +03:00
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:56 +03:00
|
|
|
static uint32_t bat_entry_off(uint32_t idx)
|
|
|
|
{
|
|
|
|
return sizeof(ParallelsHeader) + sizeof(uint32_t) * idx;
|
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:36 +03:00
|
|
|
static int64_t seek_to_sector(BDRVParallelsState *s, int64_t sector_num)
|
2007-08-01 03:28:53 +04:00
|
|
|
{
|
2009-11-07 17:10:01 +03:00
|
|
|
uint32_t index, offset;
|
2007-08-01 03:28:53 +04:00
|
|
|
|
|
|
|
index = sector_num / s->tracks;
|
|
|
|
offset = sector_num % s->tracks;
|
|
|
|
|
2010-05-07 00:04:34 +04:00
|
|
|
/* not allocated */
|
2015-04-28 10:46:47 +03:00
|
|
|
if ((index >= s->bat_size) || (s->bat_bitmap[index] == 0)) {
|
2014-07-28 20:23:53 +04:00
|
|
|
return -1;
|
2015-04-28 10:46:47 +03:00
|
|
|
}
|
2015-04-28 10:46:48 +03:00
|
|
|
return bat2sect(s, index) + offset;
|
2007-08-01 03:28:53 +04:00
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:37 +03:00
|
|
|
static int cluster_remainder(BDRVParallelsState *s, int64_t sector_num,
|
|
|
|
int nb_sectors)
|
|
|
|
{
|
|
|
|
int ret = s->tracks - sector_num % s->tracks;
|
|
|
|
return MIN(nb_sectors, ret);
|
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:55 +03:00
|
|
|
static int64_t block_status(BDRVParallelsState *s, int64_t sector_num,
|
|
|
|
int nb_sectors, int *pnum)
|
|
|
|
{
|
|
|
|
int64_t start_off = -2, prev_end_off = -2;
|
|
|
|
|
|
|
|
*pnum = 0;
|
|
|
|
while (nb_sectors > 0 || start_off == -2) {
|
|
|
|
int64_t offset = seek_to_sector(s, sector_num);
|
|
|
|
int to_end;
|
|
|
|
|
|
|
|
if (start_off == -2) {
|
|
|
|
start_off = offset;
|
|
|
|
prev_end_off = offset;
|
|
|
|
} else if (offset != prev_end_off) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
to_end = cluster_remainder(s, sector_num, nb_sectors);
|
|
|
|
nb_sectors -= to_end;
|
|
|
|
sector_num += to_end;
|
|
|
|
*pnum += to_end;
|
|
|
|
|
|
|
|
if (offset > 0) {
|
|
|
|
prev_end_off += to_end;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return start_off;
|
|
|
|
}
|
|
|
|
|
2022-09-22 11:49:11 +03:00
|
|
|
static coroutine_fn int64_t allocate_clusters(BlockDriverState *bs,
|
|
|
|
int64_t sector_num,
|
|
|
|
int nb_sectors, int *pnum)
|
2015-04-28 10:46:42 +03:00
|
|
|
{
|
2020-04-28 23:29:03 +03:00
|
|
|
int ret = 0;
|
2015-04-28 10:46:42 +03:00
|
|
|
BDRVParallelsState *s = bs->opaque;
|
2017-08-04 18:10:12 +03:00
|
|
|
int64_t pos, space, idx, to_allocate, i, len;
|
2015-04-28 10:46:42 +03:00
|
|
|
|
2015-04-28 10:47:00 +03:00
|
|
|
pos = block_status(s, sector_num, nb_sectors, pnum);
|
|
|
|
if (pos > 0) {
|
|
|
|
return pos;
|
|
|
|
}
|
2015-04-28 10:46:42 +03:00
|
|
|
|
2015-04-28 10:47:00 +03:00
|
|
|
idx = sector_num / s->tracks;
|
2016-05-31 19:35:51 +03:00
|
|
|
to_allocate = DIV_ROUND_UP(sector_num + *pnum, s->tracks) - idx;
|
2017-03-31 20:05:12 +03:00
|
|
|
|
|
|
|
/* This function is called only by parallels_co_writev(), which will never
|
|
|
|
* pass a sector_num at or beyond the end of the image (because the block
|
|
|
|
* layer never passes such a sector_num to that function). Therefore, idx
|
|
|
|
* is always below s->bat_size.
|
|
|
|
* block_status() will limit *pnum so that sector_num + *pnum will not
|
|
|
|
* exceed the image end. Therefore, idx + to_allocate cannot exceed
|
|
|
|
* s->bat_size.
|
|
|
|
* Note that s->bat_size is an unsigned int, therefore idx + to_allocate
|
|
|
|
* will always fit into a uint32_t. */
|
|
|
|
assert(idx < s->bat_size && idx + to_allocate <= s->bat_size);
|
|
|
|
|
2015-04-28 10:47:00 +03:00
|
|
|
space = to_allocate * s->tracks;
|
2017-08-04 18:10:12 +03:00
|
|
|
len = bdrv_getlength(bs->file->bs);
|
|
|
|
if (len < 0) {
|
|
|
|
return len;
|
|
|
|
}
|
|
|
|
if (s->data_end + space > (len >> BDRV_SECTOR_BITS)) {
|
2015-04-28 10:47:00 +03:00
|
|
|
space += s->prealloc_size;
|
2020-04-28 23:29:03 +03:00
|
|
|
/*
|
|
|
|
* We require the expanded size to read back as zero. If the
|
|
|
|
* user permitted truncation, we try that; but if it fails, we
|
|
|
|
* force the safer-but-slower fallocate.
|
|
|
|
*/
|
|
|
|
if (s->prealloc_mode == PRL_PREALLOC_MODE_TRUNCATE) {
|
|
|
|
ret = bdrv_truncate(bs->file,
|
|
|
|
(s->data_end + space) << BDRV_SECTOR_BITS,
|
|
|
|
false, PREALLOC_MODE_OFF, BDRV_REQ_ZERO_WRITE,
|
|
|
|
NULL);
|
|
|
|
if (ret == -ENOTSUP) {
|
|
|
|
s->prealloc_mode = PRL_PREALLOC_MODE_FALLOCATE;
|
|
|
|
}
|
|
|
|
}
|
2015-04-28 10:46:59 +03:00
|
|
|
if (s->prealloc_mode == PRL_PREALLOC_MODE_FALLOCATE) {
|
2016-06-16 16:13:15 +03:00
|
|
|
ret = bdrv_pwrite_zeroes(bs->file,
|
2016-06-02 00:10:04 +03:00
|
|
|
s->data_end << BDRV_SECTOR_BITS,
|
|
|
|
space << BDRV_SECTOR_BITS, 0);
|
2015-04-28 10:46:59 +03:00
|
|
|
}
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
2015-04-28 10:46:42 +03:00
|
|
|
}
|
|
|
|
|
2018-01-12 12:01:22 +03:00
|
|
|
/* Try to read from backing to fill empty clusters
|
|
|
|
* FIXME: 1. previous write_zeroes may be redundant
|
|
|
|
* 2. most of data we read from backing will be rewritten by
|
|
|
|
* parallels_co_writev. On aligned-to-cluster write we do not need
|
|
|
|
* this read at all.
|
|
|
|
* 3. it would be good to combine write of data from backing and new
|
|
|
|
* data into one write call */
|
|
|
|
if (bs->backing) {
|
|
|
|
int64_t nb_cow_sectors = to_allocate * s->tracks;
|
|
|
|
int64_t nb_cow_bytes = nb_cow_sectors << BDRV_SECTOR_BITS;
|
2019-04-22 17:58:34 +03:00
|
|
|
void *buf = qemu_blockalign(bs, nb_cow_bytes);
|
2018-01-12 12:01:22 +03:00
|
|
|
|
2019-04-22 17:58:34 +03:00
|
|
|
ret = bdrv_co_pread(bs->backing, idx * s->tracks * BDRV_SECTOR_SIZE,
|
|
|
|
nb_cow_bytes, buf, 0);
|
2018-01-12 12:01:22 +03:00
|
|
|
if (ret < 0) {
|
2019-04-22 17:58:34 +03:00
|
|
|
qemu_vfree(buf);
|
2018-01-12 12:01:22 +03:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2022-07-14 16:28:00 +03:00
|
|
|
ret = bdrv_co_pwrite(bs->file, s->data_end * BDRV_SECTOR_SIZE,
|
|
|
|
nb_cow_bytes, buf, 0);
|
2019-04-22 17:58:34 +03:00
|
|
|
qemu_vfree(buf);
|
2018-01-12 12:01:22 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-04-28 10:47:00 +03:00
|
|
|
for (i = 0; i < to_allocate; i++) {
|
|
|
|
s->bat_bitmap[idx + i] = cpu_to_le32(s->data_end / s->off_multiplier);
|
|
|
|
s->data_end += s->tracks;
|
|
|
|
bitmap_set(s->bat_dirty_bmap,
|
2015-11-17 20:02:58 +03:00
|
|
|
bat_entry_off(idx + i) / s->bat_dirty_block, 1);
|
2015-04-28 10:47:00 +03:00
|
|
|
}
|
2015-04-28 10:46:57 +03:00
|
|
|
|
2015-04-28 10:47:00 +03:00
|
|
|
return bat2sect(s, idx) + sector_num % s->tracks;
|
2015-04-28 10:46:42 +03:00
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:57 +03:00
|
|
|
|
|
|
|
static coroutine_fn int parallels_co_flush_to_os(BlockDriverState *bs)
|
|
|
|
{
|
|
|
|
BDRVParallelsState *s = bs->opaque;
|
|
|
|
unsigned long size = DIV_ROUND_UP(s->header_size, s->bat_dirty_block);
|
|
|
|
unsigned long bit;
|
|
|
|
|
|
|
|
qemu_co_mutex_lock(&s->lock);
|
|
|
|
|
|
|
|
bit = find_first_bit(s->bat_dirty_bmap, size);
|
|
|
|
while (bit < size) {
|
|
|
|
uint32_t off = bit * s->bat_dirty_block;
|
|
|
|
uint32_t to_write = s->bat_dirty_block;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (off + to_write > s->header_size) {
|
|
|
|
to_write = s->header_size - off;
|
|
|
|
}
|
block: Change bdrv_{pread,pwrite,pwrite_sync}() param order
Swap 'buf' and 'bytes' around for consistency with
bdrv_co_{pread,pwrite}(), and in preparation to implement these
functions using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pread(child, offset, buf, bytes, flags)
+ bdrv_pread(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite(child, offset, buf, bytes, flags)
+ bdrv_pwrite(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite_sync(child, offset, buf, bytes, flags)
+ bdrv_pwrite_sync(child, offset, bytes, buf, flags)
Resulting overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20220609152744.3891847-3-afaria@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-06-09 18:27:36 +03:00
|
|
|
ret = bdrv_pwrite(bs->file, off, to_write, (uint8_t *)s->header + off,
|
block: Add a 'flags' param to bdrv_{pread,pwrite,pwrite_sync}()
For consistency with other I/O functions, and in preparation to
implement them using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression child, offset, buf, bytes; @@
- bdrv_pread(child, offset, buf, bytes)
+ bdrv_pread(child, offset, buf, bytes, 0)
@@ expression child, offset, buf, bytes; @@
- bdrv_pwrite(child, offset, buf, bytes)
+ bdrv_pwrite(child, offset, buf, bytes, 0)
@@ expression child, offset, buf, bytes; @@
- bdrv_pwrite_sync(child, offset, buf, bytes)
+ bdrv_pwrite_sync(child, offset, buf, bytes, 0)
Resulting overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20220609152744.3891847-2-afaria@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-06-09 18:27:35 +03:00
|
|
|
0);
|
2015-04-28 10:46:57 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
qemu_co_mutex_unlock(&s->lock);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
bit = find_next_bit(s->bat_dirty_bmap, size, bit + 1);
|
|
|
|
}
|
|
|
|
bitmap_zero(s->bat_dirty_bmap, size);
|
|
|
|
|
|
|
|
qemu_co_mutex_unlock(&s->lock);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2018-02-13 23:26:50 +03:00
|
|
|
static int coroutine_fn parallels_co_block_status(BlockDriverState *bs,
|
|
|
|
bool want_zero,
|
|
|
|
int64_t offset,
|
|
|
|
int64_t bytes,
|
|
|
|
int64_t *pnum,
|
|
|
|
int64_t *map,
|
|
|
|
BlockDriverState **file)
|
2015-04-28 10:46:38 +03:00
|
|
|
{
|
|
|
|
BDRVParallelsState *s = bs->opaque;
|
2018-02-13 23:26:50 +03:00
|
|
|
int count;
|
2015-04-28 10:46:38 +03:00
|
|
|
|
2018-02-13 23:26:50 +03:00
|
|
|
assert(QEMU_IS_ALIGNED(offset | bytes, BDRV_SECTOR_SIZE));
|
2015-04-28 10:46:38 +03:00
|
|
|
qemu_co_mutex_lock(&s->lock);
|
2018-02-13 23:26:50 +03:00
|
|
|
offset = block_status(s, offset >> BDRV_SECTOR_BITS,
|
|
|
|
bytes >> BDRV_SECTOR_BITS, &count);
|
2015-04-28 10:46:38 +03:00
|
|
|
qemu_co_mutex_unlock(&s->lock);
|
|
|
|
|
2018-02-13 23:26:50 +03:00
|
|
|
*pnum = count * BDRV_SECTOR_SIZE;
|
2015-04-28 10:46:38 +03:00
|
|
|
if (offset < 0) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-02-13 23:26:50 +03:00
|
|
|
*map = offset * BDRV_SECTOR_SIZE;
|
2016-01-26 06:58:53 +03:00
|
|
|
*file = bs->file->bs;
|
2018-02-13 23:26:50 +03:00
|
|
|
return BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID;
|
2015-04-28 10:46:38 +03:00
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:42 +03:00
|
|
|
static coroutine_fn int parallels_co_writev(BlockDriverState *bs,
|
2018-04-25 01:01:57 +03:00
|
|
|
int64_t sector_num, int nb_sectors,
|
|
|
|
QEMUIOVector *qiov, int flags)
|
2015-04-28 10:46:42 +03:00
|
|
|
{
|
|
|
|
BDRVParallelsState *s = bs->opaque;
|
|
|
|
uint64_t bytes_done = 0;
|
|
|
|
QEMUIOVector hd_qiov;
|
|
|
|
int ret = 0;
|
|
|
|
|
2018-04-25 01:01:57 +03:00
|
|
|
assert(!flags);
|
2015-04-28 10:46:42 +03:00
|
|
|
qemu_iovec_init(&hd_qiov, qiov->niov);
|
|
|
|
|
|
|
|
while (nb_sectors > 0) {
|
|
|
|
int64_t position;
|
|
|
|
int n, nbytes;
|
|
|
|
|
|
|
|
qemu_co_mutex_lock(&s->lock);
|
2015-04-28 10:47:00 +03:00
|
|
|
position = allocate_clusters(bs, sector_num, nb_sectors, &n);
|
2015-04-28 10:46:42 +03:00
|
|
|
qemu_co_mutex_unlock(&s->lock);
|
|
|
|
if (position < 0) {
|
|
|
|
ret = (int)position;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
nbytes = n << BDRV_SECTOR_BITS;
|
|
|
|
|
|
|
|
qemu_iovec_reset(&hd_qiov);
|
|
|
|
qemu_iovec_concat(&hd_qiov, qiov, bytes_done, nbytes);
|
|
|
|
|
2018-06-28 23:15:18 +03:00
|
|
|
ret = bdrv_co_pwritev(bs->file, position * BDRV_SECTOR_SIZE, nbytes,
|
|
|
|
&hd_qiov, 0);
|
2015-04-28 10:46:42 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
nb_sectors -= n;
|
|
|
|
sector_num += n;
|
|
|
|
bytes_done += nbytes;
|
|
|
|
}
|
|
|
|
|
|
|
|
qemu_iovec_destroy(&hd_qiov);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:39 +03:00
|
|
|
static coroutine_fn int parallels_co_readv(BlockDriverState *bs,
|
|
|
|
int64_t sector_num, int nb_sectors, QEMUIOVector *qiov)
|
2007-08-01 03:28:53 +04:00
|
|
|
{
|
2015-04-28 10:46:36 +03:00
|
|
|
BDRVParallelsState *s = bs->opaque;
|
2015-04-28 10:46:39 +03:00
|
|
|
uint64_t bytes_done = 0;
|
|
|
|
QEMUIOVector hd_qiov;
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
qemu_iovec_init(&hd_qiov, qiov->niov);
|
2015-04-28 10:46:36 +03:00
|
|
|
|
2007-08-01 03:28:53 +04:00
|
|
|
while (nb_sectors > 0) {
|
2015-04-28 10:46:39 +03:00
|
|
|
int64_t position;
|
|
|
|
int n, nbytes;
|
|
|
|
|
|
|
|
qemu_co_mutex_lock(&s->lock);
|
2015-04-28 10:46:55 +03:00
|
|
|
position = block_status(s, sector_num, nb_sectors, &n);
|
2015-04-28 10:46:39 +03:00
|
|
|
qemu_co_mutex_unlock(&s->lock);
|
|
|
|
|
|
|
|
nbytes = n << BDRV_SECTOR_BITS;
|
|
|
|
|
2018-01-12 12:01:22 +03:00
|
|
|
qemu_iovec_reset(&hd_qiov);
|
|
|
|
qemu_iovec_concat(&hd_qiov, qiov, bytes_done, nbytes);
|
|
|
|
|
2015-04-28 10:46:39 +03:00
|
|
|
if (position < 0) {
|
2018-01-12 12:01:22 +03:00
|
|
|
if (bs->backing) {
|
2018-06-28 23:15:18 +03:00
|
|
|
ret = bdrv_co_preadv(bs->backing, sector_num * BDRV_SECTOR_SIZE,
|
|
|
|
nbytes, &hd_qiov, 0);
|
2018-01-12 12:01:22 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
qemu_iovec_memset(&hd_qiov, 0, 0, nbytes);
|
|
|
|
}
|
2015-04-28 10:46:39 +03:00
|
|
|
} else {
|
2018-06-28 23:15:18 +03:00
|
|
|
ret = bdrv_co_preadv(bs->file, position * BDRV_SECTOR_SIZE, nbytes,
|
|
|
|
&hd_qiov, 0);
|
2015-04-28 10:46:36 +03:00
|
|
|
if (ret < 0) {
|
2015-04-28 10:46:39 +03:00
|
|
|
break;
|
2015-04-28 10:46:36 +03:00
|
|
|
}
|
2010-05-07 00:04:34 +04:00
|
|
|
}
|
2015-04-28 10:46:39 +03:00
|
|
|
|
2015-04-28 10:46:37 +03:00
|
|
|
nb_sectors -= n;
|
|
|
|
sector_num += n;
|
2015-04-28 10:46:39 +03:00
|
|
|
bytes_done += nbytes;
|
2007-08-01 03:28:53 +04:00
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:39 +03:00
|
|
|
qemu_iovec_destroy(&hd_qiov);
|
2011-10-20 15:16:22 +04:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:52 +03:00
|
|
|
|
2018-03-01 19:36:19 +03:00
|
|
|
static int coroutine_fn parallels_co_check(BlockDriverState *bs,
|
|
|
|
BdrvCheckResult *res,
|
|
|
|
BdrvCheckMode fix)
|
2015-04-28 10:46:52 +03:00
|
|
|
{
|
|
|
|
BDRVParallelsState *s = bs->opaque;
|
|
|
|
int64_t size, prev_off, high_off;
|
|
|
|
int ret;
|
|
|
|
uint32_t i;
|
|
|
|
bool flush_bat = false;
|
|
|
|
|
2015-06-16 15:19:22 +03:00
|
|
|
size = bdrv_getlength(bs->file->bs);
|
2015-04-28 10:46:52 +03:00
|
|
|
if (size < 0) {
|
|
|
|
res->check_errors++;
|
|
|
|
return size;
|
|
|
|
}
|
|
|
|
|
2018-03-01 19:36:19 +03:00
|
|
|
qemu_co_mutex_lock(&s->lock);
|
2015-04-28 10:46:53 +03:00
|
|
|
if (s->header_unclean) {
|
|
|
|
fprintf(stderr, "%s image was not closed correctly\n",
|
|
|
|
fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR");
|
|
|
|
res->corruptions++;
|
|
|
|
if (fix & BDRV_FIX_ERRORS) {
|
|
|
|
/* parallels_close will do the job right */
|
|
|
|
res->corruptions_fixed++;
|
|
|
|
s->header_unclean = false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:52 +03:00
|
|
|
res->bfi.total_clusters = s->bat_size;
|
|
|
|
res->bfi.compressed_clusters = 0; /* compression is not supported */
|
|
|
|
|
|
|
|
high_off = 0;
|
|
|
|
prev_off = 0;
|
|
|
|
for (i = 0; i < s->bat_size; i++) {
|
|
|
|
int64_t off = bat2sect(s, i) << BDRV_SECTOR_BITS;
|
|
|
|
if (off == 0) {
|
|
|
|
prev_off = 0;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* cluster outside the image */
|
|
|
|
if (off > size) {
|
|
|
|
fprintf(stderr, "%s cluster %u is outside image\n",
|
|
|
|
fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR", i);
|
|
|
|
res->corruptions++;
|
|
|
|
if (fix & BDRV_FIX_ERRORS) {
|
|
|
|
prev_off = 0;
|
|
|
|
s->bat_bitmap[i] = 0;
|
|
|
|
res->corruptions_fixed++;
|
|
|
|
flush_bat = true;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
res->bfi.allocated_clusters++;
|
|
|
|
if (off > high_off) {
|
|
|
|
high_off = off;
|
|
|
|
}
|
|
|
|
|
2021-02-24 13:47:04 +03:00
|
|
|
if (prev_off != 0 && (prev_off + s->cluster_size) != off) {
|
2015-04-28 10:46:52 +03:00
|
|
|
res->bfi.fragmented_clusters++;
|
|
|
|
}
|
|
|
|
prev_off = off;
|
|
|
|
}
|
|
|
|
|
2018-03-01 19:36:19 +03:00
|
|
|
ret = 0;
|
2015-04-28 10:46:52 +03:00
|
|
|
if (flush_bat) {
|
2022-06-09 18:27:43 +03:00
|
|
|
ret = bdrv_co_pwrite_sync(bs->file, 0, s->header_size, s->header, 0);
|
2015-04-28 10:46:52 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
res->check_errors++;
|
2018-03-01 19:36:19 +03:00
|
|
|
goto out;
|
2015-04-28 10:46:52 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-02-24 13:47:04 +03:00
|
|
|
res->image_end_offset = high_off + s->cluster_size;
|
2015-04-28 10:46:52 +03:00
|
|
|
if (size > res->image_end_offset) {
|
|
|
|
int64_t count;
|
2021-02-24 13:47:04 +03:00
|
|
|
count = DIV_ROUND_UP(size - res->image_end_offset, s->cluster_size);
|
2015-04-28 10:46:52 +03:00
|
|
|
fprintf(stderr, "%s space leaked at the end of the image %" PRId64 "\n",
|
|
|
|
fix & BDRV_FIX_LEAKS ? "Repairing" : "ERROR",
|
|
|
|
size - res->image_end_offset);
|
|
|
|
res->leaks += count;
|
|
|
|
if (fix & BDRV_FIX_LEAKS) {
|
2017-03-28 23:51:27 +03:00
|
|
|
Error *local_err = NULL;
|
2019-09-18 12:51:43 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* In order to really repair the image, we must shrink it.
|
|
|
|
* That means we have to pass exact=true.
|
|
|
|
*/
|
|
|
|
ret = bdrv_truncate(bs->file, res->image_end_offset, true,
|
2020-04-24 15:54:40 +03:00
|
|
|
PREALLOC_MODE_OFF, 0, &local_err);
|
2015-04-28 10:46:52 +03:00
|
|
|
if (ret < 0) {
|
2017-03-28 23:51:27 +03:00
|
|
|
error_report_err(local_err);
|
2015-04-28 10:46:52 +03:00
|
|
|
res->check_errors++;
|
2018-03-01 19:36:19 +03:00
|
|
|
goto out;
|
2015-04-28 10:46:52 +03:00
|
|
|
}
|
|
|
|
res->leaks_fixed += count;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-03-01 19:36:19 +03:00
|
|
|
out:
|
|
|
|
qemu_co_mutex_unlock(&s->lock);
|
|
|
|
return ret;
|
2015-04-28 10:46:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2018-03-06 14:13:58 +03:00
|
|
|
static int coroutine_fn parallels_co_create(BlockdevCreateOptions* opts,
|
|
|
|
Error **errp)
|
2015-04-28 10:46:44 +03:00
|
|
|
{
|
2018-03-06 14:13:58 +03:00
|
|
|
BlockdevCreateOptionsParallels *parallels_opts;
|
|
|
|
BlockDriverState *bs;
|
|
|
|
BlockBackend *blk;
|
2015-04-28 10:46:44 +03:00
|
|
|
int64_t total_size, cl_size;
|
2015-04-28 10:46:47 +03:00
|
|
|
uint32_t bat_entries, bat_sectors;
|
2015-04-28 10:46:44 +03:00
|
|
|
ParallelsHeader header;
|
2018-03-06 14:13:58 +03:00
|
|
|
uint8_t tmp[BDRV_SECTOR_SIZE];
|
2015-04-28 10:46:44 +03:00
|
|
|
int ret;
|
|
|
|
|
2018-03-06 14:13:58 +03:00
|
|
|
assert(opts->driver == BLOCKDEV_DRIVER_PARALLELS);
|
|
|
|
parallels_opts = &opts->u.parallels;
|
|
|
|
|
|
|
|
/* Sanity checks */
|
|
|
|
total_size = parallels_opts->size;
|
|
|
|
|
|
|
|
if (parallels_opts->has_cluster_size) {
|
|
|
|
cl_size = parallels_opts->cluster_size;
|
|
|
|
} else {
|
|
|
|
cl_size = DEFAULT_CLUSTER_SIZE;
|
|
|
|
}
|
|
|
|
|
2018-03-20 19:07:58 +03:00
|
|
|
/* XXX What is the real limit here? This is an insanely large maximum. */
|
|
|
|
if (cl_size >= INT64_MAX / MAX_PARALLELS_IMAGE_FACTOR) {
|
|
|
|
error_setg(errp, "Cluster size is too large");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
2016-07-27 20:08:20 +03:00
|
|
|
if (total_size >= MAX_PARALLELS_IMAGE_FACTOR * cl_size) {
|
2018-03-06 14:13:58 +03:00
|
|
|
error_setg(errp, "Image size is too large for this cluster size");
|
2016-07-27 20:08:20 +03:00
|
|
|
return -E2BIG;
|
|
|
|
}
|
2015-04-28 10:46:44 +03:00
|
|
|
|
2018-03-06 14:13:58 +03:00
|
|
|
if (!QEMU_IS_ALIGNED(total_size, BDRV_SECTOR_SIZE)) {
|
|
|
|
error_setg(errp, "Image size must be a multiple of 512 bytes");
|
|
|
|
return -EINVAL;
|
2015-04-28 10:46:44 +03:00
|
|
|
}
|
|
|
|
|
2018-03-06 14:13:58 +03:00
|
|
|
if (!QEMU_IS_ALIGNED(cl_size, BDRV_SECTOR_SIZE)) {
|
|
|
|
error_setg(errp, "Cluster size must be a multiple of 512 bytes");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Create BlockBackend to write to the image */
|
|
|
|
bs = bdrv_open_blockdev_ref(parallels_opts->file, errp);
|
|
|
|
if (bs == NULL) {
|
2016-03-08 17:57:05 +03:00
|
|
|
return -EIO;
|
2015-04-28 10:46:44 +03:00
|
|
|
}
|
2016-03-08 17:57:05 +03:00
|
|
|
|
2020-04-28 22:26:46 +03:00
|
|
|
blk = blk_new_with_bs(bs, BLK_PERM_WRITE | BLK_PERM_RESIZE, BLK_PERM_ALL,
|
|
|
|
errp);
|
|
|
|
if (!blk) {
|
|
|
|
ret = -EPERM;
|
2018-03-06 14:13:58 +03:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
blk_set_allow_write_beyond_eof(blk, true);
|
2016-03-08 17:57:05 +03:00
|
|
|
|
2018-03-06 14:13:58 +03:00
|
|
|
/* Create image format */
|
2015-04-28 10:46:47 +03:00
|
|
|
bat_entries = DIV_ROUND_UP(total_size, cl_size);
|
2015-04-28 10:46:56 +03:00
|
|
|
bat_sectors = DIV_ROUND_UP(bat_entry_off(bat_entries), cl_size);
|
2015-04-28 10:46:47 +03:00
|
|
|
bat_sectors = (bat_sectors * cl_size) >> BDRV_SECTOR_BITS;
|
2015-04-28 10:46:44 +03:00
|
|
|
|
|
|
|
memset(&header, 0, sizeof(header));
|
|
|
|
memcpy(header.magic, HEADER_MAGIC2, sizeof(header.magic));
|
|
|
|
header.version = cpu_to_le32(HEADER_VERSION);
|
|
|
|
/* don't care much about geometry, it is not used on image level */
|
2018-01-12 12:01:21 +03:00
|
|
|
header.heads = cpu_to_le32(HEADS_NUMBER);
|
|
|
|
header.cylinders = cpu_to_le32(total_size / BDRV_SECTOR_SIZE
|
|
|
|
/ HEADS_NUMBER / SEC_IN_CYL);
|
2015-04-28 10:46:44 +03:00
|
|
|
header.tracks = cpu_to_le32(cl_size >> BDRV_SECTOR_BITS);
|
2015-04-28 10:46:47 +03:00
|
|
|
header.bat_entries = cpu_to_le32(bat_entries);
|
2015-04-28 10:46:44 +03:00
|
|
|
header.nb_sectors = cpu_to_le64(DIV_ROUND_UP(total_size, BDRV_SECTOR_SIZE));
|
2015-04-28 10:46:47 +03:00
|
|
|
header.data_off = cpu_to_le32(bat_sectors);
|
2015-04-28 10:46:44 +03:00
|
|
|
|
|
|
|
/* write all the data */
|
|
|
|
memset(tmp, 0, sizeof(tmp));
|
|
|
|
memcpy(tmp, &header, sizeof(header));
|
|
|
|
|
block: Change blk_{pread,pwrite}() param order
Swap 'buf' and 'bytes' around for consistency with
blk_co_{pread,pwrite}(), and in preparation to implement these functions
using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression blk, offset, buf, bytes, flags; @@
- blk_pread(blk, offset, buf, bytes, flags)
+ blk_pread(blk, offset, bytes, buf, flags)
@@ expression blk, offset, buf, bytes, flags; @@
- blk_pwrite(blk, offset, buf, bytes, flags)
+ blk_pwrite(blk, offset, bytes, buf, flags)
It had no effect on hw/block/nand.c, presumably due to the #if, so that
file was updated manually.
Overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220705161527.1054072-4-afaria@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-07-05 19:15:11 +03:00
|
|
|
ret = blk_pwrite(blk, 0, BDRV_SECTOR_SIZE, tmp, 0);
|
2015-04-28 10:46:44 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
goto exit;
|
|
|
|
}
|
2018-03-06 14:13:58 +03:00
|
|
|
ret = blk_pwrite_zeroes(blk, BDRV_SECTOR_SIZE,
|
2016-05-25 01:25:20 +03:00
|
|
|
(bat_sectors - 1) << BDRV_SECTOR_BITS, 0);
|
2015-04-28 10:46:44 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
|
2018-03-06 14:13:58 +03:00
|
|
|
ret = 0;
|
|
|
|
out:
|
|
|
|
blk_unref(blk);
|
|
|
|
bdrv_unref(bs);
|
2015-04-28 10:46:44 +03:00
|
|
|
return ret;
|
|
|
|
|
|
|
|
exit:
|
|
|
|
error_setg_errno(errp, -ret, "Failed to create Parallels image");
|
2018-03-06 14:13:58 +03:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2020-03-26 04:12:17 +03:00
|
|
|
static int coroutine_fn parallels_co_create_opts(BlockDriver *drv,
|
|
|
|
const char *filename,
|
2018-03-06 14:13:58 +03:00
|
|
|
QemuOpts *opts,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
BlockdevCreateOptions *create_options = NULL;
|
|
|
|
BlockDriverState *bs = NULL;
|
2018-06-14 22:14:32 +03:00
|
|
|
QDict *qdict;
|
2018-03-06 14:13:58 +03:00
|
|
|
Visitor *v;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
static const QDictRenames opt_renames[] = {
|
|
|
|
{ BLOCK_OPT_CLUSTER_SIZE, "cluster-size" },
|
|
|
|
{ NULL, NULL },
|
|
|
|
};
|
|
|
|
|
|
|
|
/* Parse options and convert legacy syntax */
|
|
|
|
qdict = qemu_opts_to_qdict_filtered(opts, NULL, ¶llels_create_opts,
|
|
|
|
true);
|
|
|
|
|
|
|
|
if (!qdict_rename_keys(qdict, opt_renames, errp)) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Create and open the file (protocol layer) */
|
error: Eliminate error_propagate() with Coccinelle, part 1
When all we do with an Error we receive into a local variable is
propagating to somewhere else, we can just as well receive it there
right away. Convert
if (!foo(..., &err)) {
...
error_propagate(errp, err);
...
return ...
}
to
if (!foo(..., errp)) {
...
...
return ...
}
where nothing else needs @err. Coccinelle script:
@rule1 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
binary operator op;
constant c1, c2;
symbol false;
@@
if (
(
- fun(args, &err, args2)
+ fun(args, errp, args2)
|
- !fun(args, &err, args2)
+ !fun(args, errp, args2)
|
- fun(args, &err, args2) op c1
+ fun(args, errp, args2) op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
)
}
@rule2 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
expression var;
binary operator op;
constant c1, c2;
symbol false;
@@
- var = fun(args, &err, args2);
+ var = fun(args, errp, args2);
... when != err
if (
(
var
|
!var
|
var op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
|
return var;
)
}
@depends on rule1 || rule2@
identifier err;
@@
- Error *err = NULL;
... when != err
Not exactly elegant, I'm afraid.
The "when != lbl:" is necessary to avoid transforming
if (fun(args, &err)) {
goto out
}
...
out:
error_propagate(errp, err);
even though other paths to label out still need the error_propagate().
For an actual example, see sclp_realize().
Without the "when strict", Coccinelle transforms vfio_msix_setup(),
incorrectly. I don't know what exactly "when strict" does, only that
it helps here.
The match of return is narrower than what I want, but I can't figure
out how to express "return where the operand doesn't use @err". For
an example where it's too narrow, see vfio_intx_enable().
Silently fails to convert hw/arm/armsse.c, because Coccinelle gets
confused by ARMSSE being used both as typedef and function-like macro
there. Converted manually.
Line breaks tidied up manually. One nested declaration of @local_err
deleted manually. Preexisting unwanted blank line dropped in
hw/riscv/sifive_e.c.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-35-armbru@redhat.com>
2020-07-07 19:06:02 +03:00
|
|
|
ret = bdrv_create_file(filename, opts, errp);
|
2018-03-06 14:13:58 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
|
|
|
bs = bdrv_open(filename, NULL, NULL,
|
|
|
|
BDRV_O_RDWR | BDRV_O_RESIZE | BDRV_O_PROTOCOL, errp);
|
|
|
|
if (bs == NULL) {
|
|
|
|
ret = -EIO;
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Now get the QAPI type BlockdevCreateOptions */
|
|
|
|
qdict_put_str(qdict, "driver", "parallels");
|
|
|
|
qdict_put_str(qdict, "file", bs->node_name);
|
|
|
|
|
2018-06-14 22:14:33 +03:00
|
|
|
v = qobject_input_visitor_new_flat_confused(qdict, errp);
|
|
|
|
if (!v) {
|
2018-03-06 14:13:58 +03:00
|
|
|
ret = -EINVAL;
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
2020-07-07 19:06:07 +03:00
|
|
|
visit_type_BlockdevCreateOptions(v, NULL, &create_options, errp);
|
2018-03-06 14:13:58 +03:00
|
|
|
visit_free(v);
|
2020-07-07 19:06:07 +03:00
|
|
|
if (!create_options) {
|
2018-03-06 14:13:58 +03:00
|
|
|
ret = -EINVAL;
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Silently round up sizes */
|
|
|
|
create_options->u.parallels.size =
|
|
|
|
ROUND_UP(create_options->u.parallels.size, BDRV_SECTOR_SIZE);
|
|
|
|
create_options->u.parallels.cluster_size =
|
|
|
|
ROUND_UP(create_options->u.parallels.cluster_size, BDRV_SECTOR_SIZE);
|
|
|
|
|
|
|
|
/* Create the Parallels image (format layer) */
|
|
|
|
ret = parallels_co_create(create_options, errp);
|
|
|
|
if (ret < 0) {
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
done:
|
2018-04-19 18:01:43 +03:00
|
|
|
qobject_unref(qdict);
|
2018-03-06 14:13:58 +03:00
|
|
|
bdrv_unref(bs);
|
|
|
|
qapi_free_BlockdevCreateOptions(create_options);
|
|
|
|
return ret;
|
2015-04-28 10:46:44 +03:00
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:51 +03:00
|
|
|
|
|
|
|
static int parallels_probe(const uint8_t *buf, int buf_size,
|
|
|
|
const char *filename)
|
|
|
|
{
|
|
|
|
const ParallelsHeader *ph = (const void *)buf;
|
|
|
|
|
|
|
|
if (buf_size < sizeof(ParallelsHeader)) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if ((!memcmp(ph->magic, HEADER_MAGIC, 16) ||
|
|
|
|
!memcmp(ph->magic, HEADER_MAGIC2, 16)) &&
|
|
|
|
(le32_to_cpu(ph->version) == HEADER_VERSION)) {
|
|
|
|
return 100;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:53 +03:00
|
|
|
static int parallels_update_header(BlockDriverState *bs)
|
|
|
|
{
|
|
|
|
BDRVParallelsState *s = bs->opaque;
|
2015-06-16 15:19:22 +03:00
|
|
|
unsigned size = MAX(bdrv_opt_mem_align(bs->file->bs),
|
|
|
|
sizeof(ParallelsHeader));
|
2015-04-28 10:46:53 +03:00
|
|
|
|
|
|
|
if (size > s->header_size) {
|
|
|
|
size = s->header_size;
|
|
|
|
}
|
block: Change bdrv_{pread,pwrite,pwrite_sync}() param order
Swap 'buf' and 'bytes' around for consistency with
bdrv_co_{pread,pwrite}(), and in preparation to implement these
functions using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pread(child, offset, buf, bytes, flags)
+ bdrv_pread(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite(child, offset, buf, bytes, flags)
+ bdrv_pwrite(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite_sync(child, offset, buf, bytes, flags)
+ bdrv_pwrite_sync(child, offset, bytes, buf, flags)
Resulting overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20220609152744.3891847-3-afaria@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-06-09 18:27:36 +03:00
|
|
|
return bdrv_pwrite_sync(bs->file, 0, size, s->header, 0);
|
2015-04-28 10:46:53 +03:00
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:51 +03:00
|
|
|
static int parallels_open(BlockDriverState *bs, QDict *options, int flags,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
BDRVParallelsState *s = bs->opaque;
|
|
|
|
ParallelsHeader ph;
|
2015-04-28 10:46:59 +03:00
|
|
|
int ret, size, i;
|
2015-04-28 10:46:58 +03:00
|
|
|
QemuOpts *opts = NULL;
|
|
|
|
Error *local_err = NULL;
|
|
|
|
char *buf;
|
2015-04-28 10:46:51 +03:00
|
|
|
|
2020-05-13 14:05:35 +03:00
|
|
|
bs->file = bdrv_open_child(NULL, options, "file", bs, &child_of_bds,
|
|
|
|
BDRV_CHILD_IMAGE, false, errp);
|
2016-12-16 20:52:37 +03:00
|
|
|
if (!bs->file) {
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
block: Change bdrv_{pread,pwrite,pwrite_sync}() param order
Swap 'buf' and 'bytes' around for consistency with
bdrv_co_{pread,pwrite}(), and in preparation to implement these
functions using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pread(child, offset, buf, bytes, flags)
+ bdrv_pread(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite(child, offset, buf, bytes, flags)
+ bdrv_pwrite(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite_sync(child, offset, buf, bytes, flags)
+ bdrv_pwrite_sync(child, offset, bytes, buf, flags)
Resulting overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20220609152744.3891847-3-afaria@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-06-09 18:27:36 +03:00
|
|
|
ret = bdrv_pread(bs->file, 0, sizeof(ph), &ph, 0);
|
2015-04-28 10:46:51 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
bs->total_sectors = le64_to_cpu(ph.nb_sectors);
|
|
|
|
|
|
|
|
if (le32_to_cpu(ph.version) != HEADER_VERSION) {
|
|
|
|
goto fail_format;
|
|
|
|
}
|
|
|
|
if (!memcmp(ph.magic, HEADER_MAGIC, 16)) {
|
|
|
|
s->off_multiplier = 1;
|
|
|
|
bs->total_sectors = 0xffffffff & bs->total_sectors;
|
|
|
|
} else if (!memcmp(ph.magic, HEADER_MAGIC2, 16)) {
|
|
|
|
s->off_multiplier = le32_to_cpu(ph.tracks);
|
|
|
|
} else {
|
|
|
|
goto fail_format;
|
|
|
|
}
|
|
|
|
|
|
|
|
s->tracks = le32_to_cpu(ph.tracks);
|
|
|
|
if (s->tracks == 0) {
|
|
|
|
error_setg(errp, "Invalid image: Zero sectors per track");
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
if (s->tracks > INT32_MAX/513) {
|
|
|
|
error_setg(errp, "Invalid image: Too big cluster");
|
|
|
|
ret = -EFBIG;
|
|
|
|
goto fail;
|
|
|
|
}
|
2021-02-24 13:47:04 +03:00
|
|
|
s->cluster_size = s->tracks << BDRV_SECTOR_BITS;
|
2015-04-28 10:46:51 +03:00
|
|
|
|
|
|
|
s->bat_size = le32_to_cpu(ph.bat_entries);
|
|
|
|
if (s->bat_size > INT_MAX / sizeof(uint32_t)) {
|
|
|
|
error_setg(errp, "Catalog too large");
|
|
|
|
ret = -EFBIG;
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:56 +03:00
|
|
|
size = bat_entry_off(s->bat_size);
|
2015-06-16 15:19:22 +03:00
|
|
|
s->header_size = ROUND_UP(size, bdrv_opt_mem_align(bs->file->bs));
|
|
|
|
s->header = qemu_try_blockalign(bs->file->bs, s->header_size);
|
2015-04-28 10:46:51 +03:00
|
|
|
if (s->header == NULL) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto fail;
|
|
|
|
}
|
2015-04-28 10:46:59 +03:00
|
|
|
s->data_end = le32_to_cpu(ph.data_off);
|
|
|
|
if (s->data_end == 0) {
|
|
|
|
s->data_end = ROUND_UP(bat_entry_off(s->bat_size), BDRV_SECTOR_SIZE);
|
|
|
|
}
|
|
|
|
if (s->data_end < s->header_size) {
|
2015-04-28 10:46:51 +03:00
|
|
|
/* there is not enough unused space to fit to block align between BAT
|
|
|
|
and actual data. We can't avoid read-modify-write... */
|
|
|
|
s->header_size = size;
|
|
|
|
}
|
|
|
|
|
block: Change bdrv_{pread,pwrite,pwrite_sync}() param order
Swap 'buf' and 'bytes' around for consistency with
bdrv_co_{pread,pwrite}(), and in preparation to implement these
functions using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pread(child, offset, buf, bytes, flags)
+ bdrv_pread(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite(child, offset, buf, bytes, flags)
+ bdrv_pwrite(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite_sync(child, offset, buf, bytes, flags)
+ bdrv_pwrite_sync(child, offset, bytes, buf, flags)
Resulting overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20220609152744.3891847-3-afaria@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-06-09 18:27:36 +03:00
|
|
|
ret = bdrv_pread(bs->file, 0, s->header_size, s->header, 0);
|
2015-04-28 10:46:51 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
s->bat_bitmap = (uint32_t *)(s->header + 1);
|
|
|
|
|
2015-04-28 10:46:59 +03:00
|
|
|
for (i = 0; i < s->bat_size; i++) {
|
|
|
|
int64_t off = bat2sect(s, i);
|
|
|
|
if (off >= s->data_end) {
|
|
|
|
s->data_end = off + s->tracks;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:53 +03:00
|
|
|
if (le32_to_cpu(ph.inuse) == HEADER_INUSE_MAGIC) {
|
|
|
|
/* Image was not closed correctly. The check is mandatory */
|
|
|
|
s->header_unclean = true;
|
|
|
|
if ((flags & BDRV_O_RDWR) && !(flags & BDRV_O_CHECK)) {
|
|
|
|
error_setg(errp, "parallels: Image was not closed correctly; "
|
|
|
|
"cannot be opened read/write");
|
|
|
|
ret = -EACCES;
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-07-07 19:05:35 +03:00
|
|
|
opts = qemu_opts_create(¶llels_runtime_opts, NULL, 0, errp);
|
|
|
|
if (!opts) {
|
2015-04-28 10:46:58 +03:00
|
|
|
goto fail_options;
|
|
|
|
}
|
|
|
|
|
2020-07-07 19:06:05 +03:00
|
|
|
if (!qemu_opts_absorb_qdict(opts, options, errp)) {
|
2015-04-28 10:46:58 +03:00
|
|
|
goto fail_options;
|
|
|
|
}
|
|
|
|
|
|
|
|
s->prealloc_size =
|
|
|
|
qemu_opt_get_size_del(opts, PARALLELS_OPT_PREALLOC_SIZE, 0);
|
|
|
|
s->prealloc_size = MAX(s->tracks, s->prealloc_size >> BDRV_SECTOR_BITS);
|
|
|
|
buf = qemu_opt_get_del(opts, PARALLELS_OPT_PREALLOC_MODE);
|
2020-04-28 23:29:03 +03:00
|
|
|
/* prealloc_mode can be downgraded later during allocate_clusters */
|
2017-08-24 11:46:10 +03:00
|
|
|
s->prealloc_mode = qapi_enum_parse(&prealloc_mode_lookup, buf,
|
2017-08-24 11:45:57 +03:00
|
|
|
PRL_PREALLOC_MODE_FALLOCATE,
|
|
|
|
&local_err);
|
2015-04-28 10:46:58 +03:00
|
|
|
g_free(buf);
|
|
|
|
if (local_err != NULL) {
|
2020-07-07 19:06:06 +03:00
|
|
|
error_propagate(errp, local_err);
|
2015-04-28 10:46:58 +03:00
|
|
|
goto fail_options;
|
|
|
|
}
|
2017-03-27 17:38:08 +03:00
|
|
|
|
2021-02-24 13:47:05 +03:00
|
|
|
if (ph.ext_off) {
|
|
|
|
if (flags & BDRV_O_RDWR) {
|
|
|
|
/*
|
|
|
|
* It's unsafe to open image RW if there is an extension (as we
|
|
|
|
* don't support it). But parallels driver in QEMU historically
|
|
|
|
* ignores the extension, so print warning and don't care.
|
|
|
|
*/
|
|
|
|
warn_report("Format Extension ignored in RW mode");
|
|
|
|
} else {
|
|
|
|
ret = parallels_read_format_extension(
|
|
|
|
bs, le64_to_cpu(ph.ext_off) << BDRV_SECTOR_BITS, errp);
|
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-11-07 16:10:34 +03:00
|
|
|
if ((flags & BDRV_O_RDWR) && !(flags & BDRV_O_INACTIVE)) {
|
2015-04-28 10:46:53 +03:00
|
|
|
s->header->inuse = cpu_to_le32(HEADER_INUSE_MAGIC);
|
|
|
|
ret = parallels_update_header(bs);
|
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-03-23 18:57:22 +03:00
|
|
|
s->bat_dirty_block = 4 * qemu_real_host_page_size();
|
2015-04-28 10:46:57 +03:00
|
|
|
s->bat_dirty_bmap =
|
|
|
|
bitmap_new(DIV_ROUND_UP(s->header_size, s->bat_dirty_block));
|
|
|
|
|
2022-02-09 13:54:50 +03:00
|
|
|
/* Disable migration until bdrv_activate method is added */
|
2017-11-07 16:10:35 +03:00
|
|
|
error_setg(&s->migration_blocker, "The Parallels format used by node '%s' "
|
|
|
|
"does not support live migration",
|
|
|
|
bdrv_get_device_or_node_name(bs));
|
error: Avoid error_propagate() after migrate_add_blocker()
When migrate_add_blocker(blocker, &errp) is followed by
error_propagate(errp, err), we can often just as well do
migrate_add_blocker(..., errp).
Do that with this Coccinelle script:
@@
expression blocker, err, errp;
expression ret;
@@
- ret = migrate_add_blocker(blocker, &err);
- if (err) {
+ ret = migrate_add_blocker(blocker, errp);
+ if (ret < 0) {
... when != err;
- error_propagate(errp, err);
...
}
@@
expression blocker, err, errp;
@@
- migrate_add_blocker(blocker, &err);
- if (err) {
+ if (migrate_add_blocker(blocker, errp) < 0) {
... when != err;
- error_propagate(errp, err);
...
}
Double-check @err is not used afterwards. Dereferencing it would be
use after free, but checking whether it's null would be legitimate.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-43-armbru@redhat.com>
2020-07-07 19:06:10 +03:00
|
|
|
ret = migrate_add_blocker(s->migration_blocker, errp);
|
|
|
|
if (ret < 0) {
|
2017-11-07 16:10:35 +03:00
|
|
|
error_free(s->migration_blocker);
|
|
|
|
goto fail;
|
|
|
|
}
|
2015-04-28 10:46:51 +03:00
|
|
|
qemu_co_mutex_init(&s->lock);
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
fail_format:
|
|
|
|
error_setg(errp, "Image not in Parallels format");
|
2020-07-07 19:06:06 +03:00
|
|
|
fail_options:
|
2015-04-28 10:46:51 +03:00
|
|
|
ret = -EINVAL;
|
|
|
|
fail:
|
|
|
|
qemu_vfree(s->header);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2007-08-01 03:28:53 +04:00
|
|
|
static void parallels_close(BlockDriverState *bs)
|
|
|
|
{
|
|
|
|
BDRVParallelsState *s = bs->opaque;
|
2015-04-28 10:46:53 +03:00
|
|
|
|
2017-11-07 16:10:34 +03:00
|
|
|
if ((bs->open_flags & BDRV_O_RDWR) && !(bs->open_flags & BDRV_O_INACTIVE)) {
|
2015-04-28 10:46:53 +03:00
|
|
|
s->header->inuse = 0;
|
|
|
|
parallels_update_header(bs);
|
2019-09-18 12:51:43 +03:00
|
|
|
|
|
|
|
/* errors are ignored, so we might as well pass exact=true */
|
|
|
|
bdrv_truncate(bs->file, s->data_end << BDRV_SECTOR_BITS, true,
|
2020-04-24 15:54:40 +03:00
|
|
|
PREALLOC_MODE_OFF, 0, NULL);
|
2015-04-28 10:46:59 +03:00
|
|
|
}
|
|
|
|
|
2015-04-28 10:46:57 +03:00
|
|
|
g_free(s->bat_dirty_bmap);
|
2015-04-28 10:46:50 +03:00
|
|
|
qemu_vfree(s->header);
|
2017-11-07 16:10:35 +03:00
|
|
|
|
|
|
|
migrate_del_blocker(s->migration_blocker);
|
|
|
|
error_free(s->migration_blocker);
|
2007-08-01 03:28:53 +04:00
|
|
|
}
|
|
|
|
|
2009-05-10 02:03:42 +04:00
|
|
|
static BlockDriver bdrv_parallels = {
|
2009-03-08 01:00:29 +03:00
|
|
|
.format_name = "parallels",
|
|
|
|
.instance_size = sizeof(BDRVParallelsState),
|
|
|
|
.bdrv_probe = parallels_probe,
|
2010-05-07 00:04:50 +04:00
|
|
|
.bdrv_open = parallels_open,
|
2009-03-08 01:00:29 +03:00
|
|
|
.bdrv_close = parallels_close,
|
2020-05-13 14:05:39 +03:00
|
|
|
.bdrv_child_perm = bdrv_default_perms,
|
2018-02-13 23:26:50 +03:00
|
|
|
.bdrv_co_block_status = parallels_co_block_status,
|
2015-04-28 10:46:41 +03:00
|
|
|
.bdrv_has_zero_init = bdrv_has_zero_init_1,
|
2015-04-28 10:46:57 +03:00
|
|
|
.bdrv_co_flush_to_os = parallels_co_flush_to_os,
|
2015-04-28 10:46:39 +03:00
|
|
|
.bdrv_co_readv = parallels_co_readv,
|
2015-04-28 10:46:42 +03:00
|
|
|
.bdrv_co_writev = parallels_co_writev,
|
2020-05-13 14:05:12 +03:00
|
|
|
.is_format = true,
|
2018-01-12 12:01:22 +03:00
|
|
|
.supports_backing = true,
|
2018-03-06 14:13:58 +03:00
|
|
|
.bdrv_co_create = parallels_co_create,
|
2018-01-18 15:43:45 +03:00
|
|
|
.bdrv_co_create_opts = parallels_co_create_opts,
|
2018-03-01 19:36:19 +03:00
|
|
|
.bdrv_co_check = parallels_co_check,
|
2015-04-28 10:46:44 +03:00
|
|
|
.create_opts = ¶llels_create_opts,
|
2007-08-01 03:28:53 +04:00
|
|
|
};
|
2009-05-10 02:03:42 +04:00
|
|
|
|
|
|
|
static void bdrv_parallels_init(void)
|
|
|
|
{
|
|
|
|
bdrv_register(&bdrv_parallels);
|
|
|
|
}
|
|
|
|
|
|
|
|
block_init(bdrv_parallels_init);
|