2010-02-18 19:14:17 +03:00
|
|
|
/*
|
|
|
|
* Error reporting
|
|
|
|
*
|
|
|
|
* Copyright (C) 2010 Red Hat Inc.
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Markus Armbruster <armbru@redhat.com>,
|
|
|
|
*
|
|
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
|
|
* See the COPYING file in the top-level directory.
|
|
|
|
*/
|
|
|
|
|
2010-02-17 12:55:46 +03:00
|
|
|
#include <stdio.h>
|
2012-12-17 21:19:49 +04:00
|
|
|
#include "monitor/monitor.h"
|
2015-03-17 20:29:20 +03:00
|
|
|
#include "qemu/error-report.h"
|
2010-02-17 12:55:46 +03:00
|
|
|
|
2010-02-18 19:14:17 +03:00
|
|
|
/*
|
|
|
|
* Print to current monitor if we have one, else to stderr.
|
|
|
|
* TODO should return int, so callers can calculate width, but that
|
|
|
|
* requires surgery to monitor_vprintf(). Left for another day.
|
|
|
|
*/
|
|
|
|
void error_vprintf(const char *fmt, va_list ap)
|
2010-02-17 12:55:46 +03:00
|
|
|
{
|
2014-03-22 03:42:24 +04:00
|
|
|
if (cur_mon && !monitor_cur_is_qmp()) {
|
2010-02-18 19:14:17 +03:00
|
|
|
monitor_vprintf(cur_mon, fmt, ap);
|
error: Simplify error sink setup
qemu_error_sink can either point to a monitor or a file. In practice,
it always points to the current monitor if we have one, else to
stderr. Simply route errors to the current monitor or else to stderr,
and remove qemu_error_sink along with the functions to control it.
Actually, the old code switches the sink slightly later, in
handle_user_command() and handle_qmp_command(), than it gets switched
now, implicitly, by setting the current monitor in monitor_read() and
monitor_control_read(). Likewise, it switches back slightly earlier
(same places). Doesn't make a difference, because there are no calls
of qemu_error() in between.
2010-02-18 15:16:02 +03:00
|
|
|
} else {
|
2010-02-18 19:14:17 +03:00
|
|
|
vfprintf(stderr, fmt, ap);
|
2010-02-17 12:55:46 +03:00
|
|
|
}
|
2010-02-18 19:14:17 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Print to current monitor if we have one, else to stderr.
|
|
|
|
* TODO just like error_vprintf()
|
|
|
|
*/
|
|
|
|
void error_printf(const char *fmt, ...)
|
|
|
|
{
|
|
|
|
va_list ap;
|
|
|
|
|
|
|
|
va_start(ap, fmt);
|
|
|
|
error_vprintf(fmt, ap);
|
|
|
|
va_end(ap);
|
|
|
|
}
|
|
|
|
|
2010-02-19 12:30:05 +03:00
|
|
|
void error_printf_unless_qmp(const char *fmt, ...)
|
|
|
|
{
|
|
|
|
va_list ap;
|
|
|
|
|
|
|
|
if (!monitor_cur_is_qmp()) {
|
|
|
|
va_start(ap, fmt);
|
|
|
|
error_vprintf(fmt, ap);
|
|
|
|
va_end(ap);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-02-18 21:46:49 +03:00
|
|
|
static Location std_loc = {
|
|
|
|
.kind = LOC_NONE
|
|
|
|
};
|
|
|
|
static Location *cur_loc = &std_loc;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Push location saved in LOC onto the location stack, return it.
|
|
|
|
* The top of that stack is the current location.
|
|
|
|
* Needs a matching loc_pop().
|
|
|
|
*/
|
|
|
|
Location *loc_push_restore(Location *loc)
|
|
|
|
{
|
|
|
|
assert(!loc->prev);
|
|
|
|
loc->prev = cur_loc;
|
|
|
|
cur_loc = loc;
|
|
|
|
return loc;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Initialize *LOC to "nowhere", push it onto the location stack.
|
|
|
|
* The top of that stack is the current location.
|
|
|
|
* Needs a matching loc_pop().
|
|
|
|
* Return LOC.
|
|
|
|
*/
|
|
|
|
Location *loc_push_none(Location *loc)
|
|
|
|
{
|
|
|
|
loc->kind = LOC_NONE;
|
|
|
|
loc->prev = NULL;
|
|
|
|
return loc_push_restore(loc);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Pop the location stack.
|
|
|
|
* LOC must be the current location, i.e. the top of the stack.
|
|
|
|
*/
|
|
|
|
Location *loc_pop(Location *loc)
|
|
|
|
{
|
|
|
|
assert(cur_loc == loc && loc->prev);
|
|
|
|
cur_loc = loc->prev;
|
|
|
|
loc->prev = NULL;
|
|
|
|
return loc;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Save the current location in LOC, return LOC.
|
|
|
|
*/
|
|
|
|
Location *loc_save(Location *loc)
|
|
|
|
{
|
|
|
|
*loc = *cur_loc;
|
|
|
|
loc->prev = NULL;
|
|
|
|
return loc;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Change the current location to the one saved in LOC.
|
|
|
|
*/
|
|
|
|
void loc_restore(Location *loc)
|
|
|
|
{
|
|
|
|
Location *prev = cur_loc->prev;
|
|
|
|
assert(!loc->prev);
|
|
|
|
*cur_loc = *loc;
|
|
|
|
cur_loc->prev = prev;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Change the current location to "nowhere in particular".
|
|
|
|
*/
|
|
|
|
void loc_set_none(void)
|
|
|
|
{
|
|
|
|
cur_loc->kind = LOC_NONE;
|
|
|
|
}
|
|
|
|
|
2010-02-18 22:13:51 +03:00
|
|
|
/*
|
|
|
|
* Change the current location to argument ARGV[IDX..IDX+CNT-1].
|
|
|
|
*/
|
|
|
|
void loc_set_cmdline(char **argv, int idx, int cnt)
|
|
|
|
{
|
|
|
|
cur_loc->kind = LOC_CMDLINE;
|
|
|
|
cur_loc->num = cnt;
|
|
|
|
cur_loc->ptr = argv + idx;
|
|
|
|
}
|
|
|
|
|
2010-02-18 21:48:33 +03:00
|
|
|
/*
|
|
|
|
* Change the current location to file FNAME, line LNO.
|
|
|
|
*/
|
|
|
|
void loc_set_file(const char *fname, int lno)
|
|
|
|
{
|
|
|
|
assert (fname || cur_loc->kind == LOC_FILE);
|
|
|
|
cur_loc->kind = LOC_FILE;
|
|
|
|
cur_loc->num = lno;
|
|
|
|
if (fname) {
|
|
|
|
cur_loc->ptr = fname;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-02-24 16:37:14 +03:00
|
|
|
static const char *progname;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Set the program name for error_print_loc().
|
|
|
|
*/
|
|
|
|
void error_set_progname(const char *argv0)
|
|
|
|
{
|
|
|
|
const char *p = strrchr(argv0, '/');
|
|
|
|
progname = p ? p + 1 : argv0;
|
|
|
|
}
|
|
|
|
|
2011-12-13 05:22:57 +04:00
|
|
|
const char *error_get_progname(void)
|
|
|
|
{
|
|
|
|
return progname;
|
|
|
|
}
|
|
|
|
|
2010-02-18 21:46:49 +03:00
|
|
|
/*
|
|
|
|
* Print current location to current monitor if we have one, else to stderr.
|
|
|
|
*/
|
2014-03-22 03:42:22 +04:00
|
|
|
static void error_print_loc(void)
|
2010-02-18 21:46:49 +03:00
|
|
|
{
|
2010-02-24 16:37:14 +03:00
|
|
|
const char *sep = "";
|
2010-02-18 22:13:51 +03:00
|
|
|
int i;
|
|
|
|
const char *const *argp;
|
2010-02-24 16:37:14 +03:00
|
|
|
|
2010-03-22 12:29:03 +03:00
|
|
|
if (!cur_mon && progname) {
|
2010-02-24 16:37:14 +03:00
|
|
|
fprintf(stderr, "%s:", progname);
|
|
|
|
sep = " ";
|
|
|
|
}
|
2010-02-18 21:46:49 +03:00
|
|
|
switch (cur_loc->kind) {
|
2010-02-18 22:13:51 +03:00
|
|
|
case LOC_CMDLINE:
|
|
|
|
argp = cur_loc->ptr;
|
|
|
|
for (i = 0; i < cur_loc->num; i++) {
|
|
|
|
error_printf("%s%s", sep, argp[i]);
|
|
|
|
sep = " ";
|
|
|
|
}
|
|
|
|
error_printf(": ");
|
|
|
|
break;
|
2010-02-18 21:48:33 +03:00
|
|
|
case LOC_FILE:
|
|
|
|
error_printf("%s:", (const char *)cur_loc->ptr);
|
|
|
|
if (cur_loc->num) {
|
|
|
|
error_printf("%d:", cur_loc->num);
|
|
|
|
}
|
|
|
|
error_printf(" ");
|
|
|
|
break;
|
2010-02-24 16:37:14 +03:00
|
|
|
default:
|
2010-03-23 18:13:03 +03:00
|
|
|
error_printf("%s", sep);
|
2010-02-18 21:46:49 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-07-04 07:02:46 +04:00
|
|
|
bool enable_timestamp_msg;
|
2010-02-18 19:25:24 +03:00
|
|
|
/*
|
|
|
|
* Print an error message to current monitor if we have one, else to stderr.
|
2014-10-08 16:11:54 +04:00
|
|
|
* Format arguments like vsprintf(). The result should not contain
|
2011-06-22 16:03:54 +04:00
|
|
|
* newlines.
|
2010-02-18 21:46:49 +03:00
|
|
|
* Prepend the current location and append a newline.
|
qmp: Wean off qerror_report()
The traditional QMP command handler interface
int qmp_FOO(Monitor *mon, const QDict *params, QObject **ret_data);
doesn't provide for returning an Error object. Instead, the handler
is expected to stash it in the monitor with qerror_report().
When we rebased QMP on top of QAPI, we didn't change this interface.
Instead, commit 776574d introduced "middle mode" as a temporary aid
for converting existing QMP commands to QAPI one by one. More than
three years later, we're still using it.
Middle mode has two effects:
* Instead of the native input marshallers
static void qmp_marshal_input_FOO(QDict *, QObject **, Error **)
it generates input marshallers conforming to the traditional QMP
command handler interface.
* It suppresses generation of code to register them with
qmp_register_command()
This permits giving them internal linkage.
As long as we need qmp-commands.hx, we can't use the registry behind
qmp_register_command(), so the latter has to stay for now.
The former has to go to get rid of qerror_report(). Changing all QMP
commands to fit the QAPI mold in one go was impractical back when we
started, but by now there are just a few stragglers left:
do_qmp_capabilities(), qmp_qom_set(), qmp_qom_get(), qmp_object_add(),
qmp_netdev_add(), do_device_add().
Switch middle mode to generate native input marshallers, and adapt the
stragglers. Simplifies both the monitor code and the stragglers.
Rename do_qmp_capabilities() to qmp_capabilities(), and
do_device_add() to qmp_device_add, because that's how QMP command
handlers are named today.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
2015-03-13 19:25:50 +03:00
|
|
|
* It's wrong to call this in a QMP monitor. Use error_setg() there.
|
2010-02-18 19:25:24 +03:00
|
|
|
*/
|
2014-10-08 16:11:54 +04:00
|
|
|
void error_vreport(const char *fmt, va_list ap)
|
2010-02-18 19:14:17 +03:00
|
|
|
{
|
2013-07-04 07:02:46 +04:00
|
|
|
GTimeVal tv;
|
|
|
|
gchar *timestr;
|
|
|
|
|
2015-08-10 16:15:41 +03:00
|
|
|
if (enable_timestamp_msg && !cur_mon) {
|
2013-07-04 07:02:46 +04:00
|
|
|
g_get_current_time(&tv);
|
|
|
|
timestr = g_time_val_to_iso8601(&tv);
|
|
|
|
error_printf("%s ", timestr);
|
|
|
|
g_free(timestr);
|
|
|
|
}
|
2010-02-18 19:14:17 +03:00
|
|
|
|
2010-02-18 21:46:49 +03:00
|
|
|
error_print_loc();
|
2010-02-18 19:14:17 +03:00
|
|
|
error_vprintf(fmt, ap);
|
2010-02-18 19:25:24 +03:00
|
|
|
error_printf("\n");
|
2010-02-17 12:55:46 +03:00
|
|
|
}
|
2014-10-08 16:11:54 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Print an error message to current monitor if we have one, else to stderr.
|
|
|
|
* Format arguments like sprintf(). The result should not contain
|
|
|
|
* newlines.
|
|
|
|
* Prepend the current location and append a newline.
|
qmp: Wean off qerror_report()
The traditional QMP command handler interface
int qmp_FOO(Monitor *mon, const QDict *params, QObject **ret_data);
doesn't provide for returning an Error object. Instead, the handler
is expected to stash it in the monitor with qerror_report().
When we rebased QMP on top of QAPI, we didn't change this interface.
Instead, commit 776574d introduced "middle mode" as a temporary aid
for converting existing QMP commands to QAPI one by one. More than
three years later, we're still using it.
Middle mode has two effects:
* Instead of the native input marshallers
static void qmp_marshal_input_FOO(QDict *, QObject **, Error **)
it generates input marshallers conforming to the traditional QMP
command handler interface.
* It suppresses generation of code to register them with
qmp_register_command()
This permits giving them internal linkage.
As long as we need qmp-commands.hx, we can't use the registry behind
qmp_register_command(), so the latter has to stay for now.
The former has to go to get rid of qerror_report(). Changing all QMP
commands to fit the QAPI mold in one go was impractical back when we
started, but by now there are just a few stragglers left:
do_qmp_capabilities(), qmp_qom_set(), qmp_qom_get(), qmp_object_add(),
qmp_netdev_add(), do_device_add().
Switch middle mode to generate native input marshallers, and adapt the
stragglers. Simplifies both the monitor code and the stragglers.
Rename do_qmp_capabilities() to qmp_capabilities(), and
do_device_add() to qmp_device_add, because that's how QMP command
handlers are named today.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
2015-03-13 19:25:50 +03:00
|
|
|
* It's wrong to call this in a QMP monitor. Use error_setg() there.
|
2014-10-08 16:11:54 +04:00
|
|
|
*/
|
|
|
|
void error_report(const char *fmt, ...)
|
|
|
|
{
|
|
|
|
va_list ap;
|
|
|
|
|
|
|
|
va_start(ap, fmt);
|
|
|
|
error_vreport(fmt, ap);
|
|
|
|
va_end(ap);
|
|
|
|
}
|