2011-10-16 13:16:36 +04:00
|
|
|
/*
|
|
|
|
* APIC support - common bits of emulated and KVM kernel model
|
|
|
|
*
|
|
|
|
* Copyright (c) 2004-2005 Fabrice Bellard
|
|
|
|
* Copyright (c) 2011 Jan Kiszka, Siemens AG
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
2020-10-23 15:44:24 +03:00
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
2011-10-16 13:16:36 +04:00
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>
|
|
|
|
*/
|
2019-05-23 17:35:07 +03:00
|
|
|
|
2016-01-26 21:17:03 +03:00
|
|
|
#include "qemu/osdep.h"
|
2016-10-10 18:28:42 +03:00
|
|
|
#include "qemu/error-report.h"
|
2019-05-23 17:35:07 +03:00
|
|
|
#include "qemu/module.h"
|
include/qemu/osdep.h: Don't include qapi/error.h
Commit 57cb38b included qapi/error.h into qemu/osdep.h to get the
Error typedef. Since then, we've moved to include qemu/osdep.h
everywhere. Its file comment explains: "To avoid getting into
possible circular include dependencies, this file should not include
any other QEMU headers, with the exceptions of config-host.h,
compiler.h, os-posix.h and os-win32.h, all of which are doing a
similar job to this file and are under similar constraints."
qapi/error.h doesn't do a similar job, and it doesn't adhere to
similar constraints: it includes qapi-types.h. That's in excess of
100KiB of crap most .c files don't actually need.
Add the typedef to qemu/typedefs.h, and include that instead of
qapi/error.h. Include qapi/error.h in .c files that need it and don't
get it now. Include qapi-types.h in qom/object.h for uint16List.
Update scripts/clean-includes accordingly. Update it further to match
reality: replace config.h by config-target.h, add sysemu/os-posix.h,
sysemu/os-win32.h. Update the list of includes in the qemu/osdep.h
comment quoted above similarly.
This reduces the number of objects depending on qapi/error.h from "all
of them" to less than a third. Unfortunately, the number depending on
qapi-types.h shrinks only a little. More work is needed for that one.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
[Fix compilation without the spice devel packages. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2016-03-14 11:01:28 +03:00
|
|
|
#include "qapi/error.h"
|
2016-10-19 15:05:35 +03:00
|
|
|
#include "qapi/visitor.h"
|
2013-02-05 20:06:20 +04:00
|
|
|
#include "hw/i386/apic.h"
|
|
|
|
#include "hw/i386/apic_internal.h"
|
2023-01-10 12:53:48 +03:00
|
|
|
#include "hw/intc/kvm_irqcount.h"
|
2011-10-16 13:16:36 +04:00
|
|
|
#include "trace.h"
|
2020-10-28 13:22:23 +03:00
|
|
|
#include "hw/boards.h"
|
2012-12-17 21:20:04 +04:00
|
|
|
#include "sysemu/kvm.h"
|
2019-08-12 08:23:51 +03:00
|
|
|
#include "hw/qdev-properties.h"
|
2013-04-29 21:03:01 +04:00
|
|
|
#include "hw/sysbus.h"
|
2019-08-12 08:23:45 +03:00
|
|
|
#include "migration/vmstate.h"
|
2011-10-16 13:16:36 +04:00
|
|
|
|
2012-02-17 21:31:19 +04:00
|
|
|
bool apic_report_tpr_access;
|
2011-10-16 13:16:36 +04:00
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
void cpu_set_apic_base(DeviceState *dev, uint64_t val)
|
2011-10-16 13:16:36 +04:00
|
|
|
{
|
|
|
|
trace_cpu_set_apic_base(val);
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
if (dev) {
|
|
|
|
APICCommonState *s = APIC_COMMON(dev);
|
2012-01-24 23:12:29 +04:00
|
|
|
APICCommonClass *info = APIC_COMMON_GET_CLASS(s);
|
2016-10-19 15:05:37 +03:00
|
|
|
/* switching to x2APIC, reset possibly modified xAPIC ID */
|
|
|
|
if (!(s->apicbase & MSR_IA32_APICBASE_EXTD) &&
|
|
|
|
(val & MSR_IA32_APICBASE_EXTD)) {
|
|
|
|
s->id = s->initial_apic_id;
|
|
|
|
}
|
2011-10-16 13:16:36 +04:00
|
|
|
info->set_base(s, val);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
uint64_t cpu_get_apic_base(DeviceState *dev)
|
2011-10-16 13:16:36 +04:00
|
|
|
{
|
2013-11-05 14:16:02 +04:00
|
|
|
if (dev) {
|
|
|
|
APICCommonState *s = APIC_COMMON(dev);
|
2012-01-24 23:12:29 +04:00
|
|
|
trace_cpu_get_apic_base((uint64_t)s->apicbase);
|
|
|
|
return s->apicbase;
|
|
|
|
} else {
|
2012-07-23 17:22:27 +04:00
|
|
|
trace_cpu_get_apic_base(MSR_IA32_APICBASE_BSP);
|
|
|
|
return MSR_IA32_APICBASE_BSP;
|
2012-01-24 23:12:29 +04:00
|
|
|
}
|
2011-10-16 13:16:36 +04:00
|
|
|
}
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
void cpu_set_apic_tpr(DeviceState *dev, uint8_t val)
|
2011-10-16 13:16:36 +04:00
|
|
|
{
|
2012-01-24 23:12:29 +04:00
|
|
|
APICCommonState *s;
|
|
|
|
APICCommonClass *info;
|
2011-10-16 13:16:36 +04:00
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
if (!dev) {
|
2012-01-24 23:12:29 +04:00
|
|
|
return;
|
2011-10-16 13:16:36 +04:00
|
|
|
}
|
2012-01-24 23:12:29 +04:00
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
s = APIC_COMMON(dev);
|
2012-01-24 23:12:29 +04:00
|
|
|
info = APIC_COMMON_GET_CLASS(s);
|
|
|
|
|
|
|
|
info->set_tpr(s, val);
|
2011-10-16 13:16:36 +04:00
|
|
|
}
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
uint8_t cpu_get_apic_tpr(DeviceState *dev)
|
2012-02-17 21:31:19 +04:00
|
|
|
{
|
|
|
|
APICCommonState *s;
|
|
|
|
APICCommonClass *info;
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
if (!dev) {
|
2012-02-17 21:31:19 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
s = APIC_COMMON(dev);
|
2012-02-17 21:31:19 +04:00
|
|
|
info = APIC_COMMON_GET_CLASS(s);
|
|
|
|
|
|
|
|
return info->get_tpr(s);
|
|
|
|
}
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
void apic_enable_tpr_access_reporting(DeviceState *dev, bool enable)
|
2012-02-17 21:31:19 +04:00
|
|
|
{
|
2013-11-05 14:16:02 +04:00
|
|
|
APICCommonState *s = APIC_COMMON(dev);
|
2012-02-17 21:31:19 +04:00
|
|
|
APICCommonClass *info = APIC_COMMON_GET_CLASS(s);
|
|
|
|
|
|
|
|
apic_report_tpr_access = enable;
|
|
|
|
if (info->enable_tpr_reporting) {
|
|
|
|
info->enable_tpr_reporting(s, enable);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
void apic_enable_vapic(DeviceState *dev, hwaddr paddr)
|
2011-10-16 13:16:36 +04:00
|
|
|
{
|
2013-11-05 14:16:02 +04:00
|
|
|
APICCommonState *s = APIC_COMMON(dev);
|
2012-02-17 21:31:19 +04:00
|
|
|
APICCommonClass *info = APIC_COMMON_GET_CLASS(s);
|
2011-10-16 13:16:36 +04:00
|
|
|
|
2012-02-17 21:31:19 +04:00
|
|
|
s->vapic_paddr = paddr;
|
|
|
|
info->vapic_base_update(s);
|
2011-10-16 13:16:36 +04:00
|
|
|
}
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
void apic_handle_tpr_access_report(DeviceState *dev, target_ulong ip,
|
2012-02-17 21:31:17 +04:00
|
|
|
TPRAccess access)
|
|
|
|
{
|
2013-11-05 14:16:02 +04:00
|
|
|
APICCommonState *s = APIC_COMMON(dev);
|
2012-02-17 21:31:19 +04:00
|
|
|
|
2013-01-16 22:29:31 +04:00
|
|
|
vapic_report_tpr_access(s->vapic, CPU(s->cpu), ip, access);
|
2012-02-17 21:31:17 +04:00
|
|
|
}
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
void apic_deliver_nmi(DeviceState *dev)
|
2011-10-16 13:16:36 +04:00
|
|
|
{
|
2013-11-05 14:16:02 +04:00
|
|
|
APICCommonState *s = APIC_COMMON(dev);
|
2012-01-24 23:12:29 +04:00
|
|
|
APICCommonClass *info = APIC_COMMON_GET_CLASS(s);
|
2011-10-16 13:16:36 +04:00
|
|
|
|
|
|
|
info->external_nmi(s);
|
|
|
|
}
|
|
|
|
|
2011-10-16 14:19:12 +04:00
|
|
|
bool apic_next_timer(APICCommonState *s, int64_t current_time)
|
|
|
|
{
|
|
|
|
int64_t d;
|
|
|
|
|
|
|
|
/* We need to store the timer state separately to support APIC
|
|
|
|
* implementations that maintain a non-QEMU timer, e.g. inside the
|
|
|
|
* host kernel. This open-coded state allows us to migrate between
|
|
|
|
* both models. */
|
|
|
|
s->timer_expiry = -1;
|
|
|
|
|
|
|
|
if (s->lvt[APIC_LVT_TIMER] & APIC_LVT_MASKED) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
d = (current_time - s->initial_count_load_time) >> s->count_shift;
|
|
|
|
|
|
|
|
if (s->lvt[APIC_LVT_TIMER] & APIC_LVT_TIMER_PERIODIC) {
|
|
|
|
if (!s->initial_count) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
d = ((d / ((uint64_t)s->initial_count + 1)) + 1) *
|
|
|
|
((uint64_t)s->initial_count + 1);
|
|
|
|
} else {
|
|
|
|
if (d >= s->initial_count) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
d = (uint64_t)s->initial_count + 1;
|
|
|
|
}
|
|
|
|
s->next_time = s->initial_count_load_time + (d << s->count_shift);
|
|
|
|
s->timer_expiry = s->next_time;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2020-02-07 09:43:42 +03:00
|
|
|
uint32_t apic_get_current_count(APICCommonState *s)
|
|
|
|
{
|
|
|
|
int64_t d;
|
|
|
|
uint32_t val;
|
|
|
|
d = (qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) - s->initial_count_load_time) >>
|
|
|
|
s->count_shift;
|
|
|
|
if (s->lvt[APIC_LVT_TIMER] & APIC_LVT_TIMER_PERIODIC) {
|
|
|
|
/* periodic */
|
|
|
|
val = s->initial_count - (d % ((uint64_t)s->initial_count + 1));
|
|
|
|
} else {
|
|
|
|
if (d >= s->initial_count) {
|
|
|
|
val = 0;
|
|
|
|
} else {
|
|
|
|
val = s->initial_count - d;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return val;
|
|
|
|
}
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
void apic_init_reset(DeviceState *dev)
|
2011-10-16 13:16:36 +04:00
|
|
|
{
|
2015-01-20 13:07:09 +03:00
|
|
|
APICCommonState *s;
|
|
|
|
APICCommonClass *info;
|
2011-10-16 13:16:36 +04:00
|
|
|
int i;
|
|
|
|
|
2015-01-20 13:07:09 +03:00
|
|
|
if (!dev) {
|
2011-10-16 13:16:36 +04:00
|
|
|
return;
|
|
|
|
}
|
2015-01-20 13:07:09 +03:00
|
|
|
s = APIC_COMMON(dev);
|
2011-10-16 13:16:36 +04:00
|
|
|
s->tpr = 0;
|
|
|
|
s->spurious_vec = 0xff;
|
|
|
|
s->log_dest = 0;
|
|
|
|
s->dest_mode = 0xf;
|
|
|
|
memset(s->isr, 0, sizeof(s->isr));
|
|
|
|
memset(s->tmr, 0, sizeof(s->tmr));
|
|
|
|
memset(s->irr, 0, sizeof(s->irr));
|
|
|
|
for (i = 0; i < APIC_LVT_NB; i++) {
|
|
|
|
s->lvt[i] = APIC_LVT_MASKED;
|
|
|
|
}
|
|
|
|
s->esr = 0;
|
|
|
|
memset(s->icr, 0, sizeof(s->icr));
|
|
|
|
s->divide_conf = 0;
|
|
|
|
s->count_shift = 0;
|
|
|
|
s->initial_count = 0;
|
|
|
|
s->initial_count_load_time = 0;
|
|
|
|
s->next_time = 0;
|
2013-03-19 17:17:18 +04:00
|
|
|
s->wait_for_sipi = !cpu_is_bsp(s->cpu);
|
2011-10-16 13:16:36 +04:00
|
|
|
|
2011-10-16 14:19:12 +04:00
|
|
|
if (s->timer) {
|
2013-08-21 19:03:08 +04:00
|
|
|
timer_del(s->timer);
|
2011-10-16 14:19:12 +04:00
|
|
|
}
|
|
|
|
s->timer_expiry = -1;
|
2014-12-10 18:56:46 +03:00
|
|
|
|
2015-01-20 13:07:09 +03:00
|
|
|
info = APIC_COMMON_GET_CLASS(s);
|
2014-12-10 18:56:46 +03:00
|
|
|
if (info->reset) {
|
|
|
|
info->reset(s);
|
|
|
|
}
|
2011-10-16 13:16:36 +04:00
|
|
|
}
|
|
|
|
|
2015-04-02 02:58:36 +03:00
|
|
|
void apic_designate_bsp(DeviceState *dev, bool bsp)
|
2012-07-23 17:22:27 +04:00
|
|
|
{
|
2013-11-05 14:16:02 +04:00
|
|
|
if (dev == NULL) {
|
2012-07-23 17:22:27 +04:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
APICCommonState *s = APIC_COMMON(dev);
|
2015-04-02 02:58:36 +03:00
|
|
|
if (bsp) {
|
|
|
|
s->apicbase |= MSR_IA32_APICBASE_BSP;
|
|
|
|
} else {
|
|
|
|
s->apicbase &= ~MSR_IA32_APICBASE_BSP;
|
|
|
|
}
|
2012-07-23 17:22:27 +04:00
|
|
|
}
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
static void apic_reset_common(DeviceState *dev)
|
2011-10-16 13:16:36 +04:00
|
|
|
{
|
2013-11-05 14:16:02 +04:00
|
|
|
APICCommonState *s = APIC_COMMON(dev);
|
2012-02-17 21:31:19 +04:00
|
|
|
APICCommonClass *info = APIC_COMMON_GET_CLASS(s);
|
2015-04-07 16:53:52 +03:00
|
|
|
uint32_t bsp;
|
2011-10-16 13:16:36 +04:00
|
|
|
|
2015-04-07 16:53:52 +03:00
|
|
|
bsp = s->apicbase & MSR_IA32_APICBASE_BSP;
|
|
|
|
s->apicbase = APIC_DEFAULT_ADDRESS | bsp | MSR_IA32_APICBASE_ENABLE;
|
2016-10-19 15:05:36 +03:00
|
|
|
s->id = s->initial_apic_id;
|
2011-10-16 13:16:36 +04:00
|
|
|
|
2023-01-10 12:53:48 +03:00
|
|
|
kvm_reset_irq_delivered();
|
2017-01-31 14:40:54 +03:00
|
|
|
|
2012-02-17 21:31:19 +04:00
|
|
|
s->vapic_paddr = 0;
|
|
|
|
info->vapic_base_update(s);
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
apic_init_reset(dev);
|
2011-10-16 13:16:36 +04:00
|
|
|
}
|
|
|
|
|
2016-07-01 18:53:56 +03:00
|
|
|
static const VMStateDescription vmstate_apic_common;
|
|
|
|
|
2013-12-18 21:21:46 +04:00
|
|
|
static void apic_common_realize(DeviceState *dev, Error **errp)
|
2011-10-16 13:16:36 +04:00
|
|
|
{
|
2023-10-03 10:58:14 +03:00
|
|
|
ERRP_GUARD();
|
2012-01-24 23:12:29 +04:00
|
|
|
APICCommonState *s = APIC_COMMON(dev);
|
|
|
|
APICCommonClass *info;
|
2012-02-17 21:31:19 +04:00
|
|
|
static DeviceState *vapic;
|
apic: Use 32bit APIC ID for migration instance ID
Migration is silently broken now with x2apic config like this:
-smp 200,maxcpus=288,sockets=2,cores=72,threads=2 \
-device intel-iommu,intremap=on,eim=on
After migration, the guest kernel could hang at anything, due to
x2apic bit not migrated correctly in IA32_APIC_BASE on some vcpus, so
any operations related to x2apic could be broken then (e.g., RDMSR on
x2apic MSRs could fail because KVM would think that the vcpu hasn't
enabled x2apic at all).
The issue is that the x2apic bit was never applied correctly for vcpus
whose ID > 255 when migrate completes, and that's because when we
migrate APIC we use the APICCommonState.id as instance ID of the
migration stream, while that's too short for x2apic.
Let's use the newly introduced initial_apic_id for that.
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
2019-10-16 05:29:32 +03:00
|
|
|
uint32_t instance_id = s->initial_apic_id;
|
|
|
|
|
|
|
|
/* Normally initial APIC ID should be no more than hundreds */
|
|
|
|
assert(instance_id != VMSTATE_INSTANCE_ID_ANY);
|
2011-10-16 13:16:36 +04:00
|
|
|
|
2012-01-24 23:12:29 +04:00
|
|
|
info = APIC_COMMON_GET_CLASS(s);
|
2013-12-18 21:21:46 +04:00
|
|
|
info->realize(dev, errp);
|
2023-10-03 10:58:14 +03:00
|
|
|
if (*errp) {
|
|
|
|
return;
|
|
|
|
}
|
2012-02-17 21:31:19 +04:00
|
|
|
|
2012-08-14 15:43:12 +04:00
|
|
|
/* Note: We need at least 1M to map the VAPIC option ROM */
|
|
|
|
if (!vapic && s->vapic_control & VAPIC_ENABLE_MASK &&
|
2023-06-24 01:52:29 +03:00
|
|
|
current_machine->ram_size >= 1024 * 1024) {
|
2012-02-17 21:31:19 +04:00
|
|
|
vapic = sysbus_create_simple("kvmvapic", -1, NULL);
|
|
|
|
}
|
|
|
|
s->vapic = vapic;
|
|
|
|
if (apic_report_tpr_access && info->enable_tpr_reporting) {
|
|
|
|
info->enable_tpr_reporting(s, true);
|
|
|
|
}
|
|
|
|
|
2016-07-01 18:53:56 +03:00
|
|
|
if (s->legacy_instance_id) {
|
2019-10-16 05:29:30 +03:00
|
|
|
instance_id = VMSTATE_INSTANCE_ID_ANY;
|
2016-07-01 18:53:56 +03:00
|
|
|
}
|
|
|
|
vmstate_register_with_alias_id(NULL, instance_id, &vmstate_apic_common,
|
2017-02-02 15:59:54 +03:00
|
|
|
s, -1, 0, NULL);
|
2011-10-16 13:16:36 +04:00
|
|
|
}
|
|
|
|
|
qdev: Unrealize must not fail
Devices may have component devices and buses.
Device realization may fail. Realization is recursive: a device's
realize() method realizes its components, and device_set_realized()
realizes its buses (which should in turn realize the devices on that
bus, except bus_set_realized() doesn't implement that, yet).
When realization of a component or bus fails, we need to roll back:
unrealize everything we realized so far. If any of these unrealizes
failed, the device would be left in an inconsistent state. Must not
happen.
device_set_realized() lets it happen: it ignores errors in the roll
back code starting at label child_realize_fail.
Since realization is recursive, unrealization must be recursive, too.
But how could a partly failed unrealize be rolled back? We'd have to
re-realize, which can fail. This design is fundamentally broken.
device_set_realized() does not roll back at all. Instead, it keeps
unrealizing, ignoring further errors.
It can screw up even for a device with no buses: if the lone
dc->unrealize() fails, it still unregisters vmstate, and calls
listeners' unrealize() callback.
bus_set_realized() does not roll back either. Instead, it stops
unrealizing.
Fortunately, no unrealize method can fail, as we'll see below.
To fix the design error, drop parameter @errp from all the unrealize
methods.
Any unrealize method that uses @errp now needs an update. This leads
us to unrealize() methods that can fail. Merely passing it to another
unrealize method cannot cause failure, though. Here are the ones that
do other things with @errp:
* virtio_serial_device_unrealize()
Fails when qbus_set_hotplug_handler() fails, but still does all the
other work. On failure, the device would stay realized with its
resources completely gone. Oops. Can't happen, because
qbus_set_hotplug_handler() can't actually fail here. Pass
&error_abort to qbus_set_hotplug_handler() instead.
* hw/ppc/spapr_drc.c's unrealize()
Fails when object_property_del() fails, but all the other work is
already done. On failure, the device would stay realized with its
vmstate registration gone. Oops. Can't happen, because
object_property_del() can't actually fail here. Pass &error_abort
to object_property_del() instead.
* spapr_phb_unrealize()
Fails and bails out when remove_drcs() fails, but other work is
already done. On failure, the device would stay realized with some
of its resources gone. Oops. remove_drcs() fails only when
chassis_from_bus()'s object_property_get_uint() fails, and it can't
here. Pass &error_abort to remove_drcs() instead.
Therefore, no unrealize method can fail before this patch.
device_set_realized()'s recursive unrealization via bus uses
object_property_set_bool(). Can't drop @errp there, so pass
&error_abort.
We similarly unrealize with object_property_set_bool() elsewhere,
always ignoring errors. Pass &error_abort instead.
Several unrealize methods no longer handle errors from other unrealize
methods: virtio_9p_device_unrealize(),
virtio_input_device_unrealize(), scsi_qdev_unrealize(), ...
Much of the deleted error handling looks wrong anyway.
One unrealize methods no longer ignore such errors:
usb_ehci_pci_exit().
Several realize methods no longer ignore errors when rolling back:
v9fs_device_realize_common(), pci_qdev_unrealize(),
spapr_phb_realize(), usb_qdev_realize(), vfio_ccw_realize(),
virtio_device_realize().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-17-armbru@redhat.com>
2020-05-05 18:29:24 +03:00
|
|
|
static void apic_common_unrealize(DeviceState *dev)
|
2016-06-23 18:30:14 +03:00
|
|
|
{
|
|
|
|
APICCommonState *s = APIC_COMMON(dev);
|
|
|
|
APICCommonClass *info = APIC_COMMON_GET_CLASS(s);
|
|
|
|
|
2016-07-01 18:53:56 +03:00
|
|
|
vmstate_unregister(NULL, &vmstate_apic_common, s);
|
qdev: Unrealize must not fail
Devices may have component devices and buses.
Device realization may fail. Realization is recursive: a device's
realize() method realizes its components, and device_set_realized()
realizes its buses (which should in turn realize the devices on that
bus, except bus_set_realized() doesn't implement that, yet).
When realization of a component or bus fails, we need to roll back:
unrealize everything we realized so far. If any of these unrealizes
failed, the device would be left in an inconsistent state. Must not
happen.
device_set_realized() lets it happen: it ignores errors in the roll
back code starting at label child_realize_fail.
Since realization is recursive, unrealization must be recursive, too.
But how could a partly failed unrealize be rolled back? We'd have to
re-realize, which can fail. This design is fundamentally broken.
device_set_realized() does not roll back at all. Instead, it keeps
unrealizing, ignoring further errors.
It can screw up even for a device with no buses: if the lone
dc->unrealize() fails, it still unregisters vmstate, and calls
listeners' unrealize() callback.
bus_set_realized() does not roll back either. Instead, it stops
unrealizing.
Fortunately, no unrealize method can fail, as we'll see below.
To fix the design error, drop parameter @errp from all the unrealize
methods.
Any unrealize method that uses @errp now needs an update. This leads
us to unrealize() methods that can fail. Merely passing it to another
unrealize method cannot cause failure, though. Here are the ones that
do other things with @errp:
* virtio_serial_device_unrealize()
Fails when qbus_set_hotplug_handler() fails, but still does all the
other work. On failure, the device would stay realized with its
resources completely gone. Oops. Can't happen, because
qbus_set_hotplug_handler() can't actually fail here. Pass
&error_abort to qbus_set_hotplug_handler() instead.
* hw/ppc/spapr_drc.c's unrealize()
Fails when object_property_del() fails, but all the other work is
already done. On failure, the device would stay realized with its
vmstate registration gone. Oops. Can't happen, because
object_property_del() can't actually fail here. Pass &error_abort
to object_property_del() instead.
* spapr_phb_unrealize()
Fails and bails out when remove_drcs() fails, but other work is
already done. On failure, the device would stay realized with some
of its resources gone. Oops. remove_drcs() fails only when
chassis_from_bus()'s object_property_get_uint() fails, and it can't
here. Pass &error_abort to remove_drcs() instead.
Therefore, no unrealize method can fail before this patch.
device_set_realized()'s recursive unrealization via bus uses
object_property_set_bool(). Can't drop @errp there, so pass
&error_abort.
We similarly unrealize with object_property_set_bool() elsewhere,
always ignoring errors. Pass &error_abort instead.
Several unrealize methods no longer handle errors from other unrealize
methods: virtio_9p_device_unrealize(),
virtio_input_device_unrealize(), scsi_qdev_unrealize(), ...
Much of the deleted error handling looks wrong anyway.
One unrealize methods no longer ignore such errors:
usb_ehci_pci_exit().
Several realize methods no longer ignore errors when rolling back:
v9fs_device_realize_common(), pci_qdev_unrealize(),
spapr_phb_realize(), usb_qdev_realize(), vfio_ccw_realize(),
virtio_device_realize().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-17-armbru@redhat.com>
2020-05-05 18:29:24 +03:00
|
|
|
info->unrealize(dev);
|
2016-06-23 18:30:14 +03:00
|
|
|
|
|
|
|
if (apic_report_tpr_access && info->enable_tpr_reporting) {
|
|
|
|
info->enable_tpr_reporting(s, false);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-08-28 15:18:57 +04:00
|
|
|
static int apic_pre_load(void *opaque)
|
|
|
|
{
|
|
|
|
APICCommonState *s = APIC_COMMON(opaque);
|
|
|
|
|
|
|
|
/* The default is !cpu_is_bsp(s->cpu), but the common value is 0
|
|
|
|
* so that's what apic_common_sipi_needed checks for. Reset to
|
|
|
|
* the value that is assumed when the apic_sipi subsection is
|
|
|
|
* absent.
|
|
|
|
*/
|
|
|
|
s->wait_for_sipi = 0;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-09-25 14:29:12 +03:00
|
|
|
static int apic_dispatch_pre_save(void *opaque)
|
2012-02-17 21:31:19 +04:00
|
|
|
{
|
|
|
|
APICCommonState *s = APIC_COMMON(opaque);
|
|
|
|
APICCommonClass *info = APIC_COMMON_GET_CLASS(s);
|
|
|
|
|
|
|
|
if (info->pre_save) {
|
|
|
|
info->pre_save(s);
|
|
|
|
}
|
2017-09-25 14:29:12 +03:00
|
|
|
|
|
|
|
return 0;
|
2012-02-17 21:31:19 +04:00
|
|
|
}
|
|
|
|
|
2011-10-16 14:19:12 +04:00
|
|
|
static int apic_dispatch_post_load(void *opaque, int version_id)
|
|
|
|
{
|
2012-01-24 23:12:29 +04:00
|
|
|
APICCommonState *s = APIC_COMMON(opaque);
|
|
|
|
APICCommonClass *info = APIC_COMMON_GET_CLASS(s);
|
2011-10-16 14:19:12 +04:00
|
|
|
|
|
|
|
if (info->post_load) {
|
|
|
|
info->post_load(s);
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-08-28 15:18:57 +04:00
|
|
|
static bool apic_common_sipi_needed(void *opaque)
|
|
|
|
{
|
|
|
|
APICCommonState *s = APIC_COMMON(opaque);
|
|
|
|
return s->wait_for_sipi != 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const VMStateDescription vmstate_apic_common_sipi = {
|
|
|
|
.name = "apic_sipi",
|
|
|
|
.version_id = 1,
|
|
|
|
.minimum_version_id = 1,
|
2014-09-23 16:09:54 +04:00
|
|
|
.needed = apic_common_sipi_needed,
|
2014-08-28 15:18:57 +04:00
|
|
|
.fields = (VMStateField[]) {
|
|
|
|
VMSTATE_INT32(sipi_vector, APICCommonState),
|
|
|
|
VMSTATE_INT32(wait_for_sipi, APICCommonState),
|
|
|
|
VMSTATE_END_OF_LIST()
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2011-10-16 13:16:36 +04:00
|
|
|
static const VMStateDescription vmstate_apic_common = {
|
|
|
|
.name = "apic",
|
|
|
|
.version_id = 3,
|
|
|
|
.minimum_version_id = 3,
|
2014-08-28 15:18:57 +04:00
|
|
|
.pre_load = apic_pre_load,
|
2012-02-17 21:31:19 +04:00
|
|
|
.pre_save = apic_dispatch_pre_save,
|
2011-10-16 14:19:12 +04:00
|
|
|
.post_load = apic_dispatch_post_load,
|
2011-10-16 13:16:36 +04:00
|
|
|
.fields = (VMStateField[]) {
|
|
|
|
VMSTATE_UINT32(apicbase, APICCommonState),
|
|
|
|
VMSTATE_UINT8(id, APICCommonState),
|
|
|
|
VMSTATE_UINT8(arb_id, APICCommonState),
|
|
|
|
VMSTATE_UINT8(tpr, APICCommonState),
|
|
|
|
VMSTATE_UINT32(spurious_vec, APICCommonState),
|
|
|
|
VMSTATE_UINT8(log_dest, APICCommonState),
|
|
|
|
VMSTATE_UINT8(dest_mode, APICCommonState),
|
|
|
|
VMSTATE_UINT32_ARRAY(isr, APICCommonState, 8),
|
|
|
|
VMSTATE_UINT32_ARRAY(tmr, APICCommonState, 8),
|
|
|
|
VMSTATE_UINT32_ARRAY(irr, APICCommonState, 8),
|
|
|
|
VMSTATE_UINT32_ARRAY(lvt, APICCommonState, APIC_LVT_NB),
|
|
|
|
VMSTATE_UINT32(esr, APICCommonState),
|
|
|
|
VMSTATE_UINT32_ARRAY(icr, APICCommonState, 2),
|
|
|
|
VMSTATE_UINT32(divide_conf, APICCommonState),
|
|
|
|
VMSTATE_INT32(count_shift, APICCommonState),
|
|
|
|
VMSTATE_UINT32(initial_count, APICCommonState),
|
|
|
|
VMSTATE_INT64(initial_count_load_time, APICCommonState),
|
|
|
|
VMSTATE_INT64(next_time, APICCommonState),
|
2011-10-16 14:19:12 +04:00
|
|
|
VMSTATE_INT64(timer_expiry,
|
|
|
|
APICCommonState), /* open-coded timer state */
|
2011-10-16 13:16:36 +04:00
|
|
|
VMSTATE_END_OF_LIST()
|
2014-08-28 15:18:57 +04:00
|
|
|
},
|
2014-09-23 16:09:54 +04:00
|
|
|
.subsections = (const VMStateDescription*[]) {
|
|
|
|
&vmstate_apic_common_sipi,
|
|
|
|
NULL
|
2011-10-16 13:16:36 +04:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
static Property apic_properties_common[] = {
|
2014-05-05 18:52:51 +04:00
|
|
|
DEFINE_PROP_UINT8("version", APICCommonState, version, 0x14),
|
2012-02-17 21:31:19 +04:00
|
|
|
DEFINE_PROP_BIT("vapic", APICCommonState, vapic_control, VAPIC_ENABLE_BIT,
|
|
|
|
true),
|
2016-07-01 18:53:56 +03:00
|
|
|
DEFINE_PROP_BOOL("legacy-instance-id", APICCommonState, legacy_instance_id,
|
|
|
|
false),
|
2011-10-16 13:16:36 +04:00
|
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
|
|
};
|
|
|
|
|
2016-10-19 15:05:35 +03:00
|
|
|
static void apic_common_get_id(Object *obj, Visitor *v, const char *name,
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
APICCommonState *s = APIC_COMMON(obj);
|
2017-06-07 19:36:10 +03:00
|
|
|
uint32_t value;
|
2016-10-19 15:05:35 +03:00
|
|
|
|
|
|
|
value = s->apicbase & MSR_IA32_APICBASE_EXTD ? s->initial_apic_id : s->id;
|
2017-06-07 19:36:10 +03:00
|
|
|
visit_type_uint32(v, name, &value, errp);
|
2016-10-19 15:05:35 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static void apic_common_set_id(Object *obj, Visitor *v, const char *name,
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
APICCommonState *s = APIC_COMMON(obj);
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
2017-06-07 19:36:10 +03:00
|
|
|
uint32_t value;
|
2016-10-19 15:05:35 +03:00
|
|
|
|
|
|
|
if (dev->realized) {
|
|
|
|
qdev_prop_set_after_realize(dev, name, errp);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
error: Eliminate error_propagate() with Coccinelle, part 1
When all we do with an Error we receive into a local variable is
propagating to somewhere else, we can just as well receive it there
right away. Convert
if (!foo(..., &err)) {
...
error_propagate(errp, err);
...
return ...
}
to
if (!foo(..., errp)) {
...
...
return ...
}
where nothing else needs @err. Coccinelle script:
@rule1 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
binary operator op;
constant c1, c2;
symbol false;
@@
if (
(
- fun(args, &err, args2)
+ fun(args, errp, args2)
|
- !fun(args, &err, args2)
+ !fun(args, errp, args2)
|
- fun(args, &err, args2) op c1
+ fun(args, errp, args2) op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
)
}
@rule2 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
expression var;
binary operator op;
constant c1, c2;
symbol false;
@@
- var = fun(args, &err, args2);
+ var = fun(args, errp, args2);
... when != err
if (
(
var
|
!var
|
var op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
|
return var;
)
}
@depends on rule1 || rule2@
identifier err;
@@
- Error *err = NULL;
... when != err
Not exactly elegant, I'm afraid.
The "when != lbl:" is necessary to avoid transforming
if (fun(args, &err)) {
goto out
}
...
out:
error_propagate(errp, err);
even though other paths to label out still need the error_propagate().
For an actual example, see sclp_realize().
Without the "when strict", Coccinelle transforms vfio_msix_setup(),
incorrectly. I don't know what exactly "when strict" does, only that
it helps here.
The match of return is narrower than what I want, but I can't figure
out how to express "return where the operand doesn't use @err". For
an example where it's too narrow, see vfio_intx_enable().
Silently fails to convert hw/arm/armsse.c, because Coccinelle gets
confused by ARMSSE being used both as typedef and function-like macro
there. Converted manually.
Line breaks tidied up manually. One nested declaration of @local_err
deleted manually. Preexisting unwanted blank line dropped in
hw/riscv/sifive_e.c.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-35-armbru@redhat.com>
2020-07-07 19:06:02 +03:00
|
|
|
if (!visit_type_uint32(v, name, &value, errp)) {
|
2016-10-19 15:05:35 +03:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
s->initial_apic_id = value;
|
|
|
|
s->id = (uint8_t)value;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void apic_common_initfn(Object *obj)
|
|
|
|
{
|
|
|
|
APICCommonState *s = APIC_COMMON(obj);
|
|
|
|
|
|
|
|
s->id = s->initial_apic_id = -1;
|
2017-06-07 19:36:10 +03:00
|
|
|
object_property_add(obj, "id", "uint32",
|
2016-10-19 15:05:35 +03:00
|
|
|
apic_common_get_id,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 18:29:22 +03:00
|
|
|
apic_common_set_id, NULL, NULL);
|
2016-10-19 15:05:35 +03:00
|
|
|
}
|
|
|
|
|
2012-01-24 23:12:29 +04:00
|
|
|
static void apic_common_class_init(ObjectClass *klass, void *data)
|
|
|
|
{
|
2011-12-08 07:34:16 +04:00
|
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
2012-01-24 23:12:29 +04:00
|
|
|
|
2011-12-08 07:34:16 +04:00
|
|
|
dc->reset = apic_reset_common;
|
2020-01-10 18:30:32 +03:00
|
|
|
device_class_set_props(dc, apic_properties_common);
|
2015-09-16 12:19:14 +03:00
|
|
|
dc->realize = apic_common_realize;
|
2016-06-23 18:30:14 +03:00
|
|
|
dc->unrealize = apic_common_unrealize;
|
2013-11-28 20:26:57 +04:00
|
|
|
/*
|
|
|
|
* Reason: APIC and CPU need to be wired up by
|
|
|
|
* x86_cpu_apic_create()
|
|
|
|
*/
|
2017-05-03 23:35:44 +03:00
|
|
|
dc->user_creatable = false;
|
2012-01-24 23:12:29 +04:00
|
|
|
}
|
2011-10-16 13:16:36 +04:00
|
|
|
|
2013-01-10 19:19:07 +04:00
|
|
|
static const TypeInfo apic_common_type = {
|
2012-01-24 23:12:29 +04:00
|
|
|
.name = TYPE_APIC_COMMON,
|
2015-09-16 12:19:14 +03:00
|
|
|
.parent = TYPE_DEVICE,
|
2012-01-24 23:12:29 +04:00
|
|
|
.instance_size = sizeof(APICCommonState),
|
2016-10-19 15:05:35 +03:00
|
|
|
.instance_init = apic_common_initfn,
|
2012-01-24 23:12:29 +04:00
|
|
|
.class_size = sizeof(APICCommonClass),
|
|
|
|
.class_init = apic_common_class_init,
|
|
|
|
.abstract = true,
|
|
|
|
};
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
static void apic_common_register_types(void)
|
2012-01-24 23:12:29 +04:00
|
|
|
{
|
|
|
|
type_register_static(&apic_common_type);
|
|
|
|
}
|
|
|
|
|
2013-11-05 14:16:02 +04:00
|
|
|
type_init(apic_common_register_types)
|