2019-03-07 17:58:38 +03:00
|
|
|
#!/usr/bin/env bash
|
2021-01-16 16:44:19 +03:00
|
|
|
# group: rw
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
#
|
|
|
|
# Live snapshot tests
|
|
|
|
#
|
|
|
|
# This tests live snapshots of images on a running QEMU instance, using
|
|
|
|
# QMP commands. Both single disk snapshots, and transactional group
|
|
|
|
# snapshots are performed.
|
|
|
|
#
|
|
|
|
# Copyright (C) 2014 Red Hat, Inc.
|
2015-10-26 15:27:17 +03:00
|
|
|
# Copyright (C) 2015 Igalia, S.L.
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
#
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
|
|
# it under the terms of the GNU General Public License as published by
|
|
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
|
|
# (at your option) any later version.
|
|
|
|
#
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
# GNU General Public License for more details.
|
|
|
|
#
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
#
|
|
|
|
|
|
|
|
# creator
|
2022-03-22 20:42:12 +03:00
|
|
|
owner=codyprime@gmail.com
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
|
|
|
|
seq=`basename $0`
|
|
|
|
echo "QA output created by $seq"
|
|
|
|
|
|
|
|
status=1 # failure is the default!
|
|
|
|
|
|
|
|
snapshot_virt0="snapshot-v0.qcow2"
|
|
|
|
snapshot_virt1="snapshot-v1.qcow2"
|
|
|
|
|
2015-10-26 15:27:17 +03:00
|
|
|
SNAPSHOTS=10
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
|
|
|
|
_cleanup()
|
|
|
|
{
|
2014-04-30 18:55:09 +04:00
|
|
|
_cleanup_qemu
|
2020-02-24 20:16:31 +03:00
|
|
|
_cleanup_test_img
|
2015-10-26 15:27:17 +03:00
|
|
|
for i in $(seq 1 ${SNAPSHOTS})
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
do
|
2019-11-07 19:37:01 +03:00
|
|
|
_rm_test_img "${TEST_DIR}/${i}-${snapshot_virt0}"
|
|
|
|
_rm_test_img "${TEST_DIR}/${i}-${snapshot_virt1}"
|
|
|
|
done
|
|
|
|
for img in "${TEST_IMG}".{1,2,base}
|
|
|
|
do
|
|
|
|
_rm_test_img "$img"
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
done
|
|
|
|
|
|
|
|
}
|
|
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
|
|
|
|
# get standard environment, filters and checks
|
|
|
|
. ./common.rc
|
|
|
|
. ./common.filter
|
2014-04-30 18:55:09 +04:00
|
|
|
. ./common.qemu
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
|
|
|
|
_supported_fmt qcow2
|
|
|
|
_supported_proto file
|
|
|
|
|
|
|
|
|
|
|
|
# ${1}: unique identifier for the snapshot filename
|
2018-11-17 00:50:02 +03:00
|
|
|
create_single_snapshot()
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
{
|
|
|
|
cmd="{ 'execute': 'blockdev-snapshot-sync',
|
|
|
|
'arguments': { 'device': 'virtio0',
|
2015-11-03 13:32:36 +03:00
|
|
|
'snapshot-file':'${TEST_DIR}/${1}-${snapshot_virt0}',
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
'format': 'qcow2' } }"
|
2014-04-30 18:55:09 +04:00
|
|
|
_send_qemu_cmd $h "${cmd}" "return"
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
# ${1}: unique identifier for the snapshot filename
|
2018-11-17 00:50:02 +03:00
|
|
|
create_group_snapshot()
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
{
|
|
|
|
cmd="{ 'execute': 'transaction', 'arguments':
|
|
|
|
{'actions': [
|
|
|
|
{ 'type': 'blockdev-snapshot-sync', 'data' :
|
|
|
|
{ 'device': 'virtio0',
|
2015-11-03 13:32:36 +03:00
|
|
|
'snapshot-file': '${TEST_DIR}/${1}-${snapshot_virt0}' } },
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
{ 'type': 'blockdev-snapshot-sync', 'data' :
|
|
|
|
{ 'device': 'virtio1',
|
2015-11-03 13:32:36 +03:00
|
|
|
'snapshot-file': '${TEST_DIR}/${1}-${snapshot_virt1}' } } ]
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
} }"
|
|
|
|
|
2014-04-30 18:55:09 +04:00
|
|
|
_send_qemu_cmd $h "${cmd}" "return"
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
}
|
|
|
|
|
2015-10-26 15:27:17 +03:00
|
|
|
# ${1}: unique identifier for the snapshot filename
|
2017-05-02 19:35:45 +03:00
|
|
|
# ${2}: extra_params to the blockdev-add command
|
|
|
|
# ${3}: filename
|
2018-11-17 00:50:02 +03:00
|
|
|
do_blockdev_add()
|
2017-05-02 19:35:45 +03:00
|
|
|
{
|
|
|
|
cmd="{ 'execute': 'blockdev-add', 'arguments':
|
|
|
|
{ 'driver': 'qcow2', 'node-name': 'snap_${1}', ${2}
|
|
|
|
'file':
|
|
|
|
{ 'driver': 'file', 'filename': '${3}',
|
|
|
|
'node-name': 'file_${1}' } } }"
|
|
|
|
_send_qemu_cmd $h "${cmd}" "return"
|
|
|
|
}
|
|
|
|
|
|
|
|
# ${1}: unique identifier for the snapshot filename
|
2021-10-18 16:47:14 +03:00
|
|
|
create_snapshot_image()
|
2015-10-26 15:27:17 +03:00
|
|
|
{
|
|
|
|
base_image="${TEST_DIR}/$((${1}-1))-${snapshot_virt0}"
|
|
|
|
snapshot_file="${TEST_DIR}/${1}-${snapshot_virt0}"
|
iotests: Specify explicit backing format where sensible
There are many existing qcow2 images that specify a backing file but
no format. This has been the source of CVEs in the past, but has
become more prominent of a problem now that libvirt has switched to
-blockdev. With older -drive, at least the probing was always done by
qemu (so the only risk of a changed format between successive boots of
a guest was if qemu was upgraded and probed differently). But with
newer -blockdev, libvirt must specify a format; if libvirt guesses raw
where the image was formatted, this results in data corruption visible
to the guest; conversely, if libvirt guesses qcow2 where qemu was
using raw, this can result in potential security holes, so modern
libvirt instead refuses to use images without explicit backing format.
The change in libvirt to reject images without explicit backing format
has pointed out that a number of tools have been far too reliant on
probing in the past. It's time to set a better example in our own
iotests of properly setting this parameter.
iotest calls to create, rebase, and convert are all impacted to some
degree. It's a bit annoying that we are inconsistent on command line
- while all of those accept -o backing_file=...,backing_fmt=..., the
shortcuts are different: create and rebase have -b and -F, while
convert has -B but no -F. (amend has no shortcuts, but the previous
patch just deprecated the use of amend to change backing chains).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200706203954.341758-9-eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-07-06 23:39:52 +03:00
|
|
|
TEST_IMG=$snapshot_file _make_test_img -u -b "${base_image}" -F $IMGFMT "$size"
|
2021-10-18 16:47:14 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
# ${1}: unique identifier for the snapshot filename
|
|
|
|
add_snapshot_image()
|
|
|
|
{
|
|
|
|
snapshot_file="${TEST_DIR}/${1}-${snapshot_virt0}"
|
|
|
|
create_snapshot_image "$1"
|
block: Use JSON null instead of "" to disable backing file
BlockdevRef is an alternate of BlockdevOptions (inline definition) and
str (reference to an existing block device by name). BlockdevRef
value "" is special: "no block device should be referenced." It's
actually interpreted that way in just one place: optional member
@backing of COW formats. Semantics:
* Present means "use this block device" as backing storage
* Absent means "default to the one stored in the image"
* Except "" means "don't use backing storage at all"
The first two are perfectly normal: when the parameter is absent, it
defaults to an implied value, but the value's meaning is the same.
The third one overloads the parameter with a second meaning. The
overloading is *implicit*, i.e. it's not visible in the types. Works
here, because "" is not a value block device ID.
Pressing argument values the schema accepts, but are semantically
invalid, into service to mean "do something else entirely" is not
general, as suitable invalid values need not exist. I also find it
ugly.
To clean this up, we could add a separate flag argument to suppress
@backing, or add a distinct value to @backing. This commit implements
the latter: add JSON null to the values of @backing, deprecate "".
Because we're so close to the 2.10 freeze, implement it in the
stupidest way possible: have qmp_blockdev_add() rewrite null to ""
before anything else can see the null. Works, because BlockdevRef
occurs only within arguments of blockdev-add. The proper way to do it
would be rewriting "" to null, preferably in a cleaner way, but that
requires fixing up code to work with null. Add a TODO comment for
that.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
2017-07-18 09:54:00 +03:00
|
|
|
do_blockdev_add "$1" "'backing': null, " "${snapshot_file}"
|
2015-10-26 15:27:17 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
# ${1}: unique identifier for the snapshot filename
|
|
|
|
# ${2}: expected response, defaults to 'return'
|
2018-11-17 00:50:02 +03:00
|
|
|
blockdev_snapshot()
|
2015-10-26 15:27:17 +03:00
|
|
|
{
|
|
|
|
cmd="{ 'execute': 'blockdev-snapshot',
|
|
|
|
'arguments': { 'node': 'virtio0',
|
2015-11-03 13:32:36 +03:00
|
|
|
'overlay':'snap_${1}' } }"
|
2015-10-26 15:27:17 +03:00
|
|
|
_send_qemu_cmd $h "${cmd}" "${2:-return}"
|
|
|
|
}
|
|
|
|
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
size=128M
|
|
|
|
|
2019-11-07 19:37:02 +03:00
|
|
|
TEST_IMG="$TEST_IMG.1" _make_test_img $size
|
|
|
|
TEST_IMG="$TEST_IMG.2" _make_test_img $size
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
|
|
|
|
echo
|
|
|
|
echo === Running QEMU ===
|
|
|
|
echo
|
|
|
|
|
2014-04-30 18:55:09 +04:00
|
|
|
qemu_comm_method="qmp"
|
2015-10-26 15:27:17 +03:00
|
|
|
_launch_qemu -drive file="${TEST_IMG}.1",if=virtio -drive file="${TEST_IMG}.2",if=virtio
|
2014-04-30 18:55:09 +04:00
|
|
|
h=$QEMU_HANDLE
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
|
|
|
|
echo
|
|
|
|
echo === Sending capabilities ===
|
|
|
|
echo
|
|
|
|
|
2014-04-30 18:55:09 +04:00
|
|
|
_send_qemu_cmd $h "{ 'execute': 'qmp_capabilities' }" "return"
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
|
2015-10-26 15:27:17 +03:00
|
|
|
# Tests for the blockdev-snapshot-sync command
|
|
|
|
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
echo
|
|
|
|
echo === Create a single snapshot on virtio0 ===
|
|
|
|
echo
|
|
|
|
|
|
|
|
create_single_snapshot 1
|
|
|
|
|
|
|
|
|
|
|
|
echo
|
|
|
|
echo === Invalid command - missing device and nodename ===
|
|
|
|
echo
|
|
|
|
|
2014-04-30 18:55:09 +04:00
|
|
|
_send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot-sync',
|
2015-11-03 13:32:36 +03:00
|
|
|
'arguments': { 'snapshot-file':'${TEST_DIR}/1-${snapshot_virt0}',
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
'format': 'qcow2' } }" "error"
|
|
|
|
|
|
|
|
echo
|
|
|
|
echo === Invalid command - missing snapshot-file ===
|
|
|
|
echo
|
|
|
|
|
2014-04-30 18:55:09 +04:00
|
|
|
_send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot-sync',
|
|
|
|
'arguments': { 'device': 'virtio0',
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
'format': 'qcow2' } }" "error"
|
|
|
|
echo
|
|
|
|
echo
|
|
|
|
echo === Create several transactional group snapshots ===
|
|
|
|
echo
|
|
|
|
|
2015-10-26 15:27:17 +03:00
|
|
|
for i in $(seq 2 ${SNAPSHOTS})
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
do
|
|
|
|
create_group_snapshot ${i}
|
|
|
|
done
|
|
|
|
|
2015-10-26 15:27:17 +03:00
|
|
|
# Tests for the blockdev-snapshot command
|
|
|
|
|
|
|
|
echo
|
|
|
|
echo === Create a couple of snapshots using blockdev-snapshot ===
|
|
|
|
echo
|
|
|
|
|
|
|
|
SNAPSHOTS=$((${SNAPSHOTS}+1))
|
|
|
|
add_snapshot_image ${SNAPSHOTS}
|
|
|
|
blockdev_snapshot ${SNAPSHOTS}
|
|
|
|
|
|
|
|
SNAPSHOTS=$((${SNAPSHOTS}+1))
|
|
|
|
add_snapshot_image ${SNAPSHOTS}
|
|
|
|
blockdev_snapshot ${SNAPSHOTS}
|
|
|
|
|
2015-11-03 13:32:37 +03:00
|
|
|
echo
|
|
|
|
echo === Invalid command - cannot create a snapshot using a file BDS ===
|
|
|
|
echo
|
|
|
|
|
|
|
|
_send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot',
|
|
|
|
'arguments': { 'node':'virtio0',
|
|
|
|
'overlay':'file_${SNAPSHOTS}' }
|
|
|
|
}" "error"
|
|
|
|
|
2015-10-26 15:27:17 +03:00
|
|
|
echo
|
|
|
|
echo === Invalid command - snapshot node used as active layer ===
|
|
|
|
echo
|
|
|
|
|
|
|
|
blockdev_snapshot ${SNAPSHOTS} error
|
|
|
|
|
|
|
|
_send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot',
|
|
|
|
'arguments': { 'node':'virtio0',
|
|
|
|
'overlay':'virtio0' }
|
|
|
|
}" "error"
|
|
|
|
|
|
|
|
_send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot',
|
|
|
|
'arguments': { 'node':'virtio0',
|
|
|
|
'overlay':'virtio1' }
|
|
|
|
}" "error"
|
|
|
|
|
|
|
|
echo
|
|
|
|
echo === Invalid command - snapshot node used as backing hd ===
|
|
|
|
echo
|
|
|
|
|
|
|
|
blockdev_snapshot $((${SNAPSHOTS}-1)) error
|
|
|
|
|
|
|
|
echo
|
|
|
|
echo === Invalid command - snapshot node has a backing image ===
|
|
|
|
echo
|
|
|
|
|
|
|
|
SNAPSHOTS=$((${SNAPSHOTS}+1))
|
2017-05-02 19:35:45 +03:00
|
|
|
|
|
|
|
TEST_IMG="$TEST_IMG.base" _make_test_img "$size"
|
iotests: Specify explicit backing format where sensible
There are many existing qcow2 images that specify a backing file but
no format. This has been the source of CVEs in the past, but has
become more prominent of a problem now that libvirt has switched to
-blockdev. With older -drive, at least the probing was always done by
qemu (so the only risk of a changed format between successive boots of
a guest was if qemu was upgraded and probed differently). But with
newer -blockdev, libvirt must specify a format; if libvirt guesses raw
where the image was formatted, this results in data corruption visible
to the guest; conversely, if libvirt guesses qcow2 where qemu was
using raw, this can result in potential security holes, so modern
libvirt instead refuses to use images without explicit backing format.
The change in libvirt to reject images without explicit backing format
has pointed out that a number of tools have been far too reliant on
probing in the past. It's time to set a better example in our own
iotests of properly setting this parameter.
iotest calls to create, rebase, and convert are all impacted to some
degree. It's a bit annoying that we are inconsistent on command line
- while all of those accept -o backing_file=...,backing_fmt=..., the
shortcuts are different: create and rebase have -b and -F, while
convert has -B but no -F. (amend has no shortcuts, but the previous
patch just deprecated the use of amend to change backing chains).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200706203954.341758-9-eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-07-06 23:39:52 +03:00
|
|
|
_make_test_img -b "${TEST_IMG}.base" -F $IMGFMT "$size"
|
2017-05-02 19:35:45 +03:00
|
|
|
do_blockdev_add ${SNAPSHOTS} "" "${TEST_IMG}"
|
2015-10-26 15:27:17 +03:00
|
|
|
blockdev_snapshot ${SNAPSHOTS} error
|
|
|
|
|
2021-10-18 16:47:14 +03:00
|
|
|
echo
|
|
|
|
echo === Invalid command - creating loops ===
|
|
|
|
echo
|
|
|
|
|
|
|
|
SNAPSHOTS=$((${SNAPSHOTS}+1))
|
|
|
|
add_snapshot_image ${SNAPSHOTS}
|
|
|
|
|
|
|
|
_send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot',
|
|
|
|
'arguments': { 'node':'snap_${SNAPSHOTS}',
|
|
|
|
'overlay':'snap_${SNAPSHOTS}' }
|
|
|
|
}" "error"
|
|
|
|
|
|
|
|
SNAPSHOTS=$((${SNAPSHOTS}+1))
|
|
|
|
create_snapshot_image ${SNAPSHOTS}
|
|
|
|
do_blockdev_add ${SNAPSHOTS} "'backing': 'snap_$((${SNAPSHOTS}-1))', " \
|
|
|
|
"${TEST_DIR}/${SNAPSHOTS}-${snapshot_virt0}"
|
|
|
|
|
|
|
|
_send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot',
|
|
|
|
'arguments': { 'node':'snap_${SNAPSHOTS}',
|
|
|
|
'overlay':'snap_$((${SNAPSHOTS}-1))' }
|
|
|
|
}" "error"
|
|
|
|
|
2015-10-26 15:27:17 +03:00
|
|
|
echo
|
|
|
|
echo === Invalid command - The node does not exist ===
|
|
|
|
echo
|
|
|
|
|
|
|
|
blockdev_snapshot $((${SNAPSHOTS}+1)) error
|
|
|
|
|
|
|
|
_send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot',
|
|
|
|
'arguments': { 'node':'nodevice',
|
2015-11-03 13:32:36 +03:00
|
|
|
'overlay':'snap_${SNAPSHOTS}' }
|
2015-10-26 15:27:17 +03:00
|
|
|
}" "error"
|
|
|
|
|
block: qemu-iotests 085 - live snapshots tests
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'arguments':
{ 'device': 'virtio0', 'snapshot-file':'...',
'format': 'qcow2' } }"
Group snapshot:
{ 'execute': 'transaction', 'arguments':
{'actions': [
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio0', 'snapshot-file': '...' } },
{ 'type': 'blockdev-snapshot-sync', 'data' :
{ 'device': 'virtio1', 'snapshot-file': '...' } } ]
} }
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-01 06:08:11 +04:00
|
|
|
# success, all done
|
|
|
|
echo "*** done"
|
|
|
|
rm -f $seq.full
|
|
|
|
status=0
|