2003-11-13 04:46:15 +03:00
|
|
|
/*
|
|
|
|
* QEMU DMA emulation
|
2004-11-07 21:04:02 +03:00
|
|
|
*
|
|
|
|
* Copyright (c) 2003-2004 Vassili Karpov (malc)
|
|
|
|
*
|
2003-11-13 04:46:15 +03:00
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
|
|
* in the Software without restriction, including without limitation the rights
|
|
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
|
|
* furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice shall be included in
|
|
|
|
* all copies or substantial portions of the Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
|
|
* THE SOFTWARE.
|
|
|
|
*/
|
2019-05-23 17:35:07 +03:00
|
|
|
|
2016-01-26 21:17:03 +03:00
|
|
|
#include "qemu/osdep.h"
|
2013-02-05 20:06:20 +04:00
|
|
|
#include "hw/isa/isa.h"
|
2019-08-12 08:23:51 +03:00
|
|
|
#include "hw/qdev-properties.h"
|
2019-08-12 08:23:45 +03:00
|
|
|
#include "migration/vmstate.h"
|
2018-03-09 01:39:23 +03:00
|
|
|
#include "hw/dma/i8257.h"
|
isa: Convert uses of isa_create() with Coccinelle
Replace
dev = isa_create(bus, type_name);
...
qdev_init_nofail(dev);
by
dev = isa_new(type_name);
...
isa_realize_and_unref(dev, bus, &error_fatal);
Recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains
why.
Coccinelle script:
@@
expression dev, bus, expr;
expression list args;
expression d;
@@
- dev = isa_create(bus, args);
+ dev = isa_new(args);
(
d = &dev->qdev;
|
d = DEVICE(dev);
)
... when != dev = expr
- qdev_init_nofail(d);
+ isa_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = isa_create(bus, args);
+ dev = isa_new(args);
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ isa_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = DEVICE(isa_create(bus, args));
+ ISADevice *isa_dev; // TODO move
+ isa_dev = isa_new(args);
+ dev = DEVICE(isa_dev);
... when != dev = expr
- qdev_init_nofail(dev);
+ isa_realize_and_unref(isa_dev, bus, &error_fatal);
Missing #include "qapi/error.h" added manually, whitespace changes
minimized manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-20-armbru@redhat.com>
2020-06-10 08:32:08 +03:00
|
|
|
#include "qapi/error.h"
|
2012-12-17 21:20:00 +04:00
|
|
|
#include "qemu/main-loop.h"
|
2019-05-23 17:35:07 +03:00
|
|
|
#include "qemu/module.h"
|
2019-02-12 17:53:22 +03:00
|
|
|
#include "qemu/log.h"
|
2014-09-10 15:47:15 +04:00
|
|
|
#include "trace.h"
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
|
2004-11-07 21:04:02 +03:00
|
|
|
/* #define DEBUG_DMA */
|
2004-06-08 00:51:58 +04:00
|
|
|
|
2004-11-07 21:04:02 +03:00
|
|
|
#define dolog(...) fprintf (stderr, "dma: " __VA_ARGS__)
|
2003-11-13 04:46:15 +03:00
|
|
|
#ifdef DEBUG_DMA
|
|
|
|
#define linfo(...) fprintf (stderr, "dma: " __VA_ARGS__)
|
|
|
|
#define ldebug(...) fprintf (stderr, "dma: " __VA_ARGS__)
|
|
|
|
#else
|
|
|
|
#define linfo(...)
|
|
|
|
#define ldebug(...)
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#define ADDR 0
|
|
|
|
#define COUNT 1
|
|
|
|
|
|
|
|
enum {
|
2004-11-14 20:30:35 +03:00
|
|
|
CMD_MEMORY_TO_MEMORY = 0x01,
|
|
|
|
CMD_FIXED_ADDRESS = 0x02,
|
|
|
|
CMD_BLOCK_CONTROLLER = 0x04,
|
|
|
|
CMD_COMPRESSED_TIME = 0x08,
|
|
|
|
CMD_CYCLIC_PRIORITY = 0x10,
|
|
|
|
CMD_EXTENDED_WRITE = 0x20,
|
|
|
|
CMD_LOW_DREQ = 0x40,
|
|
|
|
CMD_LOW_DACK = 0x80,
|
|
|
|
CMD_NOT_SUPPORTED = CMD_MEMORY_TO_MEMORY | CMD_FIXED_ADDRESS
|
|
|
|
| CMD_COMPRESSED_TIME | CMD_CYCLIC_PRIORITY | CMD_EXTENDED_WRITE
|
|
|
|
| CMD_LOW_DREQ | CMD_LOW_DACK
|
2003-11-13 04:46:15 +03:00
|
|
|
|
|
|
|
};
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static void i8257_dma_run(void *opaque);
|
2008-10-31 20:25:56 +03:00
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static const int channels[8] = {-1, 2, 3, 1, -1, -1, -1, 0};
|
2004-04-07 02:43:01 +04:00
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static void i8257_write_page(void *opaque, uint32_t nport, uint32_t data)
|
2003-11-13 04:46:15 +03:00
|
|
|
{
|
2016-02-03 19:28:55 +03:00
|
|
|
I8257State *d = opaque;
|
2003-11-13 04:46:15 +03:00
|
|
|
int ichan;
|
|
|
|
|
2004-04-07 02:43:01 +04:00
|
|
|
ichan = channels[nport & 7];
|
2003-11-13 04:46:15 +03:00
|
|
|
if (-1 == ichan) {
|
2004-11-07 21:04:02 +03:00
|
|
|
dolog ("invalid channel %#x %#x\n", nport, data);
|
2003-11-13 04:46:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2004-04-07 02:43:01 +04:00
|
|
|
d->regs[ichan].page = data;
|
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static void i8257_write_pageh(void *opaque, uint32_t nport, uint32_t data)
|
2004-04-07 02:43:01 +04:00
|
|
|
{
|
2016-02-03 19:28:55 +03:00
|
|
|
I8257State *d = opaque;
|
2004-04-07 02:43:01 +04:00
|
|
|
int ichan;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2004-04-07 02:43:01 +04:00
|
|
|
ichan = channels[nport & 7];
|
2004-06-21 20:47:42 +04:00
|
|
|
if (-1 == ichan) {
|
2004-11-07 21:04:02 +03:00
|
|
|
dolog ("invalid channel %#x %#x\n", nport, data);
|
2004-06-21 20:47:42 +04:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
d->regs[ichan].pageh = data;
|
|
|
|
}
|
2004-04-07 02:43:01 +04:00
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static uint32_t i8257_read_page(void *opaque, uint32_t nport)
|
2004-06-21 20:47:42 +04:00
|
|
|
{
|
2016-02-03 19:28:55 +03:00
|
|
|
I8257State *d = opaque;
|
2004-06-21 20:47:42 +04:00
|
|
|
int ichan;
|
|
|
|
|
|
|
|
ichan = channels[nport & 7];
|
2004-04-07 02:43:01 +04:00
|
|
|
if (-1 == ichan) {
|
2004-11-07 21:04:02 +03:00
|
|
|
dolog ("invalid channel read %#x\n", nport);
|
2004-04-07 02:43:01 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
return d->regs[ichan].page;
|
2003-11-13 04:46:15 +03:00
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static uint32_t i8257_read_pageh(void *opaque, uint32_t nport)
|
2004-06-21 20:47:42 +04:00
|
|
|
{
|
2016-02-03 19:28:55 +03:00
|
|
|
I8257State *d = opaque;
|
2004-06-21 20:47:42 +04:00
|
|
|
int ichan;
|
|
|
|
|
|
|
|
ichan = channels[nport & 7];
|
|
|
|
if (-1 == ichan) {
|
2004-11-07 21:04:02 +03:00
|
|
|
dolog ("invalid channel read %#x\n", nport);
|
2004-06-21 20:47:42 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
return d->regs[ichan].pageh;
|
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static inline void i8257_init_chan(I8257State *d, int ichan)
|
2003-11-13 04:46:15 +03:00
|
|
|
{
|
2016-02-03 19:28:55 +03:00
|
|
|
I8257Regs *r;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2004-04-07 02:43:01 +04:00
|
|
|
r = d->regs + ichan;
|
2004-11-07 21:04:02 +03:00
|
|
|
r->now[ADDR] = r->base[ADDR] << d->dshift;
|
2003-11-13 04:46:15 +03:00
|
|
|
r->now[COUNT] = 0;
|
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static inline int i8257_getff(I8257State *d)
|
2003-11-13 04:46:15 +03:00
|
|
|
{
|
|
|
|
int ff;
|
|
|
|
|
2004-04-07 02:43:01 +04:00
|
|
|
ff = d->flip_flop;
|
|
|
|
d->flip_flop = !ff;
|
2003-11-13 04:46:15 +03:00
|
|
|
return ff;
|
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static uint64_t i8257_read_chan(void *opaque, hwaddr nport, unsigned size)
|
2003-11-13 04:46:15 +03:00
|
|
|
{
|
2016-02-03 19:28:55 +03:00
|
|
|
I8257State *d = opaque;
|
2004-11-07 21:04:02 +03:00
|
|
|
int ichan, nreg, iport, ff, val, dir;
|
2016-02-03 19:28:55 +03:00
|
|
|
I8257Regs *r;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2004-04-07 02:43:01 +04:00
|
|
|
iport = (nport >> d->dshift) & 0x0f;
|
|
|
|
ichan = iport >> 1;
|
|
|
|
nreg = iport & 1;
|
|
|
|
r = d->regs + ichan;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2004-11-07 21:04:02 +03:00
|
|
|
dir = ((r->mode >> 5) & 1) ? -1 : 1;
|
2016-02-03 19:28:56 +03:00
|
|
|
ff = i8257_getff(d);
|
2003-11-13 04:46:15 +03:00
|
|
|
if (nreg)
|
2004-04-07 02:43:01 +04:00
|
|
|
val = (r->base[COUNT] << d->dshift) - r->now[COUNT];
|
2003-11-13 04:46:15 +03:00
|
|
|
else
|
2004-11-07 21:04:02 +03:00
|
|
|
val = r->now[ADDR] + r->now[COUNT] * dir;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2004-11-07 21:04:02 +03:00
|
|
|
ldebug ("read_chan %#x -> %d\n", iport, val);
|
2004-04-07 02:43:01 +04:00
|
|
|
return (val >> (d->dshift + (ff << 3))) & 0xff;
|
2003-11-13 04:46:15 +03:00
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static void i8257_write_chan(void *opaque, hwaddr nport, uint64_t data,
|
|
|
|
unsigned int size)
|
2003-11-13 04:46:15 +03:00
|
|
|
{
|
2016-02-03 19:28:55 +03:00
|
|
|
I8257State *d = opaque;
|
2004-04-07 02:43:01 +04:00
|
|
|
int iport, ichan, nreg;
|
2016-02-03 19:28:55 +03:00
|
|
|
I8257Regs *r;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2004-04-07 02:43:01 +04:00
|
|
|
iport = (nport >> d->dshift) & 0x0f;
|
|
|
|
ichan = iport >> 1;
|
|
|
|
nreg = iport & 1;
|
|
|
|
r = d->regs + ichan;
|
2016-02-03 19:28:56 +03:00
|
|
|
if (i8257_getff(d)) {
|
2004-01-20 00:11:02 +03:00
|
|
|
r->base[nreg] = (r->base[nreg] & 0xff) | ((data << 8) & 0xff00);
|
2016-02-03 19:28:56 +03:00
|
|
|
i8257_init_chan(d, ichan);
|
2004-01-20 00:11:02 +03:00
|
|
|
} else {
|
|
|
|
r->base[nreg] = (r->base[nreg] & 0xff00) | (data & 0xff);
|
2003-11-13 04:46:15 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static void i8257_write_cont(void *opaque, hwaddr nport, uint64_t data,
|
|
|
|
unsigned int size)
|
2003-11-13 04:46:15 +03:00
|
|
|
{
|
2016-02-03 19:28:55 +03:00
|
|
|
I8257State *d = opaque;
|
2004-11-07 21:04:02 +03:00
|
|
|
int iport, ichan = 0;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2004-04-07 02:43:01 +04:00
|
|
|
iport = (nport >> d->dshift) & 0x0f;
|
2003-11-13 04:46:15 +03:00
|
|
|
switch (iport) {
|
2012-12-19 16:09:21 +04:00
|
|
|
case 0x00: /* command */
|
2004-04-12 23:07:27 +04:00
|
|
|
if ((data != 0) && (data & CMD_NOT_SUPPORTED)) {
|
2019-02-12 17:53:22 +03:00
|
|
|
qemu_log_mask(LOG_UNIMP, "%s: cmd 0x%02"PRIx64" not supported\n",
|
|
|
|
__func__, data);
|
2004-04-12 23:07:27 +04:00
|
|
|
return;
|
2003-11-13 04:46:15 +03:00
|
|
|
}
|
|
|
|
d->command = data;
|
|
|
|
break;
|
|
|
|
|
2012-12-19 16:09:21 +04:00
|
|
|
case 0x01:
|
2003-11-13 04:46:15 +03:00
|
|
|
ichan = data & 3;
|
|
|
|
if (data & 4) {
|
|
|
|
d->status |= 1 << (ichan + 4);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
d->status &= ~(1 << (ichan + 4));
|
|
|
|
}
|
|
|
|
d->status &= ~(1 << ichan);
|
2016-02-03 19:28:56 +03:00
|
|
|
i8257_dma_run(d);
|
2003-11-13 04:46:15 +03:00
|
|
|
break;
|
|
|
|
|
2012-12-19 16:09:21 +04:00
|
|
|
case 0x02: /* single mask */
|
2003-11-13 04:46:15 +03:00
|
|
|
if (data & 4)
|
|
|
|
d->mask |= 1 << (data & 3);
|
|
|
|
else
|
|
|
|
d->mask &= ~(1 << (data & 3));
|
2016-02-03 19:28:56 +03:00
|
|
|
i8257_dma_run(d);
|
2003-11-13 04:46:15 +03:00
|
|
|
break;
|
|
|
|
|
2012-12-19 16:09:21 +04:00
|
|
|
case 0x03: /* mode */
|
2003-11-13 04:46:15 +03:00
|
|
|
{
|
2004-01-05 03:05:50 +03:00
|
|
|
ichan = data & 3;
|
|
|
|
#ifdef DEBUG_DMA
|
2004-11-07 21:04:02 +03:00
|
|
|
{
|
|
|
|
int op, ai, dir, opmode;
|
2004-11-14 20:30:35 +03:00
|
|
|
op = (data >> 2) & 3;
|
|
|
|
ai = (data >> 4) & 1;
|
|
|
|
dir = (data >> 5) & 1;
|
|
|
|
opmode = (data >> 6) & 3;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2004-11-14 20:30:35 +03:00
|
|
|
linfo ("ichan %d, op %d, ai %d, dir %d, opmode %d\n",
|
|
|
|
ichan, op, ai, dir, opmode);
|
2004-11-07 21:04:02 +03:00
|
|
|
}
|
2003-11-13 04:46:15 +03:00
|
|
|
#endif
|
|
|
|
d->regs[ichan].mode = data;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2012-12-19 16:09:21 +04:00
|
|
|
case 0x04: /* clear flip flop */
|
2003-11-13 04:46:15 +03:00
|
|
|
d->flip_flop = 0;
|
|
|
|
break;
|
|
|
|
|
2012-12-19 16:09:21 +04:00
|
|
|
case 0x05: /* reset */
|
2003-11-13 04:46:15 +03:00
|
|
|
d->flip_flop = 0;
|
|
|
|
d->mask = ~0;
|
|
|
|
d->status = 0;
|
|
|
|
d->command = 0;
|
|
|
|
break;
|
|
|
|
|
2012-12-19 16:09:21 +04:00
|
|
|
case 0x06: /* clear mask for all channels */
|
2003-11-13 04:46:15 +03:00
|
|
|
d->mask = 0;
|
2016-02-03 19:28:56 +03:00
|
|
|
i8257_dma_run(d);
|
2003-11-13 04:46:15 +03:00
|
|
|
break;
|
|
|
|
|
2012-12-19 16:09:21 +04:00
|
|
|
case 0x07: /* write mask for all channels */
|
2003-11-13 04:46:15 +03:00
|
|
|
d->mask = data;
|
2016-02-03 19:28:56 +03:00
|
|
|
i8257_dma_run(d);
|
2003-11-13 04:46:15 +03:00
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
2004-11-07 21:04:02 +03:00
|
|
|
dolog ("unknown iport %#x\n", iport);
|
2004-04-12 23:07:27 +04:00
|
|
|
break;
|
2003-11-13 04:46:15 +03:00
|
|
|
}
|
|
|
|
|
2004-01-05 03:05:50 +03:00
|
|
|
#ifdef DEBUG_DMA
|
2003-11-13 04:46:15 +03:00
|
|
|
if (0xc != iport) {
|
2004-11-07 21:04:02 +03:00
|
|
|
linfo ("write_cont: nport %#06x, ichan % 2d, val %#06x\n",
|
2004-04-07 02:43:01 +04:00
|
|
|
nport, ichan, data);
|
2003-11-13 04:46:15 +03:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static uint64_t i8257_read_cont(void *opaque, hwaddr nport, unsigned size)
|
2004-04-07 02:43:01 +04:00
|
|
|
{
|
2016-02-03 19:28:55 +03:00
|
|
|
I8257State *d = opaque;
|
2004-04-07 02:43:01 +04:00
|
|
|
int iport, val;
|
2004-11-07 21:04:02 +03:00
|
|
|
|
2004-04-07 02:43:01 +04:00
|
|
|
iport = (nport >> d->dshift) & 0x0f;
|
|
|
|
switch (iport) {
|
2012-12-19 16:09:21 +04:00
|
|
|
case 0x00: /* status */
|
2004-04-07 02:43:01 +04:00
|
|
|
val = d->status;
|
|
|
|
d->status &= 0xf0;
|
|
|
|
break;
|
2012-12-19 16:09:21 +04:00
|
|
|
case 0x01: /* mask */
|
2004-04-07 02:43:01 +04:00
|
|
|
val = d->mask;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
val = 0;
|
|
|
|
break;
|
|
|
|
}
|
2004-11-07 21:04:02 +03:00
|
|
|
|
|
|
|
ldebug ("read_cont: nport %#06x, iport %#04x val %#x\n", nport, iport, val);
|
2004-04-07 02:43:01 +04:00
|
|
|
return val;
|
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:57 +03:00
|
|
|
static bool i8257_dma_has_autoinitialization(IsaDma *obj, int nchan)
|
2003-11-13 04:46:15 +03:00
|
|
|
{
|
2016-02-03 19:28:57 +03:00
|
|
|
I8257State *d = I8257(obj);
|
|
|
|
return (d->regs[nchan & 3].mode >> 4) & 1;
|
2003-11-13 04:46:15 +03:00
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:57 +03:00
|
|
|
static void i8257_dma_hold_DREQ(IsaDma *obj, int nchan)
|
2003-11-13 04:46:15 +03:00
|
|
|
{
|
2016-02-03 19:28:57 +03:00
|
|
|
I8257State *d = I8257(obj);
|
|
|
|
int ichan;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
|
|
|
ichan = nchan & 3;
|
2016-02-03 19:28:57 +03:00
|
|
|
d->status |= 1 << (ichan + 4);
|
|
|
|
i8257_dma_run(d);
|
2003-11-13 04:46:15 +03:00
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:57 +03:00
|
|
|
static void i8257_dma_release_DREQ(IsaDma *obj, int nchan)
|
2003-11-13 04:46:15 +03:00
|
|
|
{
|
2016-02-03 19:28:57 +03:00
|
|
|
I8257State *d = I8257(obj);
|
|
|
|
int ichan;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
|
|
|
ichan = nchan & 3;
|
2016-02-03 19:28:57 +03:00
|
|
|
d->status &= ~(1 << (ichan + 4));
|
|
|
|
i8257_dma_run(d);
|
2003-11-13 04:46:15 +03:00
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static void i8257_channel_run(I8257State *d, int ichan)
|
2003-11-13 04:46:15 +03:00
|
|
|
{
|
2016-02-03 19:28:56 +03:00
|
|
|
int ncont = d->dshift;
|
2003-11-13 04:46:15 +03:00
|
|
|
int n;
|
2016-02-03 19:28:56 +03:00
|
|
|
I8257Regs *r = &d->regs[ichan];
|
2004-11-07 21:04:02 +03:00
|
|
|
#ifdef DEBUG_DMA
|
|
|
|
int dir, opmode;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2004-11-07 21:04:02 +03:00
|
|
|
dir = (r->mode >> 5) & 1;
|
|
|
|
opmode = (r->mode >> 6) & 3;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2004-11-07 21:04:02 +03:00
|
|
|
if (dir) {
|
|
|
|
dolog ("DMA in address decrement mode\n");
|
|
|
|
}
|
|
|
|
if (opmode != 1) {
|
|
|
|
dolog ("DMA not in single mode select %#x\n", opmode);
|
|
|
|
}
|
|
|
|
#endif
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2004-11-07 21:04:02 +03:00
|
|
|
n = r->transfer_handler (r->opaque, ichan + (ncont << 2),
|
|
|
|
r->now[COUNT], (r->base[COUNT] + 1) << ncont);
|
|
|
|
r->now[COUNT] = n;
|
|
|
|
ldebug ("dma_pos %d size %d\n", n, (r->base[COUNT] + 1) << ncont);
|
2016-02-25 15:45:32 +03:00
|
|
|
if (n == (r->base[COUNT] + 1) << ncont) {
|
|
|
|
ldebug("transfer done\n");
|
|
|
|
d->status |= (1 << ichan);
|
|
|
|
}
|
2003-11-13 04:46:15 +03:00
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static void i8257_dma_run(void *opaque)
|
2003-11-13 04:46:15 +03:00
|
|
|
{
|
2016-02-03 19:28:56 +03:00
|
|
|
I8257State *d = opaque;
|
|
|
|
int ichan;
|
2008-10-31 20:25:56 +03:00
|
|
|
int rearm = 0;
|
2011-10-28 13:28:13 +04:00
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
if (d->running) {
|
2011-10-28 13:28:13 +04:00
|
|
|
rearm = 1;
|
|
|
|
goto out;
|
|
|
|
} else {
|
2016-02-03 19:28:56 +03:00
|
|
|
d->running = 1;
|
2011-10-28 13:28:13 +04:00
|
|
|
}
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
for (ichan = 0; ichan < 4; ichan++) {
|
|
|
|
int mask;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
mask = 1 << ichan;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
if ((0 == (d->mask & mask)) && (0 != (d->status & (mask << 4)))) {
|
|
|
|
i8257_channel_run(d, ichan);
|
|
|
|
rearm = 1;
|
2003-11-13 04:46:15 +03:00
|
|
|
}
|
|
|
|
}
|
2008-10-31 20:25:56 +03:00
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
d->running = 0;
|
2011-10-28 13:28:13 +04:00
|
|
|
out:
|
2015-02-16 16:08:22 +03:00
|
|
|
if (rearm) {
|
2016-02-03 19:28:56 +03:00
|
|
|
qemu_bh_schedule_idle(d->dma_bh);
|
|
|
|
d->dma_bh_scheduled = true;
|
2015-02-16 16:08:22 +03:00
|
|
|
}
|
2008-10-31 20:25:56 +03:00
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:57 +03:00
|
|
|
static void i8257_dma_register_channel(IsaDma *obj, int nchan,
|
2016-03-09 14:55:26 +03:00
|
|
|
IsaDmaTransferHandler transfer_handler,
|
2016-02-03 19:28:57 +03:00
|
|
|
void *opaque)
|
2003-11-13 04:46:15 +03:00
|
|
|
{
|
2016-02-03 19:28:57 +03:00
|
|
|
I8257State *d = I8257(obj);
|
2016-02-03 19:28:55 +03:00
|
|
|
I8257Regs *r;
|
2016-02-03 19:28:57 +03:00
|
|
|
int ichan;
|
2003-11-13 04:46:15 +03:00
|
|
|
|
|
|
|
ichan = nchan & 3;
|
|
|
|
|
2016-02-03 19:28:57 +03:00
|
|
|
r = d->regs + ichan;
|
2004-02-26 02:25:55 +03:00
|
|
|
r->transfer_handler = transfer_handler;
|
|
|
|
r->opaque = opaque;
|
|
|
|
}
|
|
|
|
|
2019-11-01 19:55:13 +03:00
|
|
|
static bool i8257_is_verify_transfer(I8257Regs *r)
|
|
|
|
{
|
|
|
|
return (r->mode & 0x0c) == 0;
|
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:57 +03:00
|
|
|
static int i8257_dma_read_memory(IsaDma *obj, int nchan, void *buf, int pos,
|
|
|
|
int len)
|
2004-11-07 21:04:02 +03:00
|
|
|
{
|
2016-02-03 19:28:57 +03:00
|
|
|
I8257State *d = I8257(obj);
|
|
|
|
I8257Regs *r = &d->regs[nchan & 3];
|
2012-10-23 14:30:10 +04:00
|
|
|
hwaddr addr = ((r->pageh & 0x7f) << 24) | (r->page << 16) | r->now[ADDR];
|
2004-11-07 21:04:02 +03:00
|
|
|
|
2019-11-01 19:55:13 +03:00
|
|
|
if (i8257_is_verify_transfer(r)) {
|
|
|
|
return len;
|
|
|
|
}
|
|
|
|
|
2004-11-07 21:04:02 +03:00
|
|
|
if (r->mode & 0x20) {
|
|
|
|
int i;
|
|
|
|
uint8_t *p = buf;
|
|
|
|
|
|
|
|
cpu_physical_memory_read (addr - pos - len, buf, len);
|
|
|
|
/* What about 16bit transfers? */
|
|
|
|
for (i = 0; i < len >> 1; i++) {
|
|
|
|
uint8_t b = p[len - i - 1];
|
|
|
|
p[i] = b;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else
|
|
|
|
cpu_physical_memory_read (addr + pos, buf, len);
|
|
|
|
|
|
|
|
return len;
|
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:57 +03:00
|
|
|
static int i8257_dma_write_memory(IsaDma *obj, int nchan, void *buf, int pos,
|
|
|
|
int len)
|
2004-11-07 21:04:02 +03:00
|
|
|
{
|
2016-02-03 19:28:57 +03:00
|
|
|
I8257State *s = I8257(obj);
|
|
|
|
I8257Regs *r = &s->regs[nchan & 3];
|
2012-10-23 14:30:10 +04:00
|
|
|
hwaddr addr = ((r->pageh & 0x7f) << 24) | (r->page << 16) | r->now[ADDR];
|
2004-11-07 21:04:02 +03:00
|
|
|
|
2019-11-01 19:55:13 +03:00
|
|
|
if (i8257_is_verify_transfer(r)) {
|
|
|
|
return len;
|
|
|
|
}
|
|
|
|
|
2004-11-07 21:04:02 +03:00
|
|
|
if (r->mode & 0x20) {
|
|
|
|
int i;
|
|
|
|
uint8_t *p = buf;
|
|
|
|
|
|
|
|
cpu_physical_memory_write (addr - pos - len, buf, len);
|
|
|
|
/* What about 16bit transfers? */
|
|
|
|
for (i = 0; i < len; i++) {
|
|
|
|
uint8_t b = p[len - i - 1];
|
|
|
|
p[i] = b;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else
|
|
|
|
cpu_physical_memory_write (addr + pos, buf, len);
|
|
|
|
|
|
|
|
return len;
|
|
|
|
}
|
|
|
|
|
2015-02-16 16:08:22 +03:00
|
|
|
/* request the emulator to transfer a new DMA memory block ASAP (even
|
|
|
|
* if the idle bottom half would not have exited the iothread yet).
|
|
|
|
*/
|
2016-02-03 19:28:57 +03:00
|
|
|
static void i8257_dma_schedule(IsaDma *obj)
|
2004-02-26 02:25:55 +03:00
|
|
|
{
|
2016-02-03 19:28:57 +03:00
|
|
|
I8257State *d = I8257(obj);
|
|
|
|
if (d->dma_bh_scheduled) {
|
2015-02-16 16:08:22 +03:00
|
|
|
qemu_notify_event();
|
|
|
|
}
|
2003-11-13 04:46:15 +03:00
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static void i8257_reset(DeviceState *dev)
|
2004-06-20 16:58:36 +04:00
|
|
|
{
|
2016-02-03 19:28:56 +03:00
|
|
|
I8257State *d = I8257(dev);
|
2016-02-03 19:28:56 +03:00
|
|
|
i8257_write_cont(d, (0x05 << d->dshift), 0, 1);
|
2004-06-20 16:58:36 +04:00
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static int i8257_phony_handler(void *opaque, int nchan, int dma_pos,
|
|
|
|
int dma_len)
|
2008-01-14 07:24:29 +03:00
|
|
|
{
|
2014-09-10 15:47:15 +04:00
|
|
|
trace_i8257_unregistered_dma(nchan, dma_pos, dma_len);
|
2008-01-14 07:24:29 +03:00
|
|
|
return dma_pos;
|
|
|
|
}
|
|
|
|
|
2012-09-19 15:50:09 +04:00
|
|
|
|
|
|
|
static const MemoryRegionOps channel_io_ops = {
|
2016-02-03 19:28:56 +03:00
|
|
|
.read = i8257_read_chan,
|
|
|
|
.write = i8257_write_chan,
|
2012-09-19 15:50:09 +04:00
|
|
|
.endianness = DEVICE_NATIVE_ENDIAN,
|
|
|
|
.impl = {
|
|
|
|
.min_access_size = 1,
|
|
|
|
.max_access_size = 1,
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
|
|
|
/* IOport from page_base */
|
|
|
|
static const MemoryRegionPortio page_portio_list[] = {
|
2016-02-03 19:28:56 +03:00
|
|
|
{ 0x01, 3, 1, .write = i8257_write_page, .read = i8257_read_page, },
|
|
|
|
{ 0x07, 1, 1, .write = i8257_write_page, .read = i8257_read_page, },
|
2012-09-19 15:50:09 +04:00
|
|
|
PORTIO_END_OF_LIST(),
|
|
|
|
};
|
|
|
|
|
|
|
|
/* IOport from pageh_base */
|
|
|
|
static const MemoryRegionPortio pageh_portio_list[] = {
|
2016-02-03 19:28:56 +03:00
|
|
|
{ 0x01, 3, 1, .write = i8257_write_pageh, .read = i8257_read_pageh, },
|
|
|
|
{ 0x07, 3, 1, .write = i8257_write_pageh, .read = i8257_read_pageh, },
|
2012-09-19 15:50:09 +04:00
|
|
|
PORTIO_END_OF_LIST(),
|
|
|
|
};
|
|
|
|
|
|
|
|
static const MemoryRegionOps cont_io_ops = {
|
2016-02-03 19:28:56 +03:00
|
|
|
.read = i8257_read_cont,
|
|
|
|
.write = i8257_write_cont,
|
2012-09-19 15:50:09 +04:00
|
|
|
.endianness = DEVICE_NATIVE_ENDIAN,
|
|
|
|
.impl = {
|
|
|
|
.min_access_size = 1,
|
|
|
|
.max_access_size = 1,
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2016-02-03 19:28:55 +03:00
|
|
|
static const VMStateDescription vmstate_i8257_regs = {
|
2009-09-10 05:04:39 +04:00
|
|
|
.name = "dma_regs",
|
|
|
|
.version_id = 1,
|
|
|
|
.minimum_version_id = 1,
|
2014-04-16 17:32:32 +04:00
|
|
|
.fields = (VMStateField[]) {
|
2016-02-03 19:28:55 +03:00
|
|
|
VMSTATE_INT32_ARRAY(now, I8257Regs, 2),
|
|
|
|
VMSTATE_UINT16_ARRAY(base, I8257Regs, 2),
|
|
|
|
VMSTATE_UINT8(mode, I8257Regs),
|
|
|
|
VMSTATE_UINT8(page, I8257Regs),
|
|
|
|
VMSTATE_UINT8(pageh, I8257Regs),
|
|
|
|
VMSTATE_UINT8(dack, I8257Regs),
|
|
|
|
VMSTATE_UINT8(eop, I8257Regs),
|
2009-09-10 05:04:39 +04:00
|
|
|
VMSTATE_END_OF_LIST()
|
2004-11-07 21:04:02 +03:00
|
|
|
}
|
2009-09-10 05:04:39 +04:00
|
|
|
};
|
2004-11-07 21:04:02 +03:00
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static int i8257_post_load(void *opaque, int version_id)
|
2004-11-07 21:04:02 +03:00
|
|
|
{
|
2016-02-03 19:28:56 +03:00
|
|
|
I8257State *d = opaque;
|
|
|
|
i8257_dma_run(d);
|
2008-10-31 20:25:56 +03:00
|
|
|
|
2004-11-07 21:04:02 +03:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static const VMStateDescription vmstate_i8257 = {
|
2009-09-10 05:04:39 +04:00
|
|
|
.name = "dma",
|
|
|
|
.version_id = 1,
|
|
|
|
.minimum_version_id = 1,
|
2016-02-03 19:28:56 +03:00
|
|
|
.post_load = i8257_post_load,
|
2014-04-16 17:32:32 +04:00
|
|
|
.fields = (VMStateField[]) {
|
2016-02-03 19:28:55 +03:00
|
|
|
VMSTATE_UINT8(command, I8257State),
|
|
|
|
VMSTATE_UINT8(mask, I8257State),
|
|
|
|
VMSTATE_UINT8(flip_flop, I8257State),
|
|
|
|
VMSTATE_INT32(dshift, I8257State),
|
2016-02-03 19:28:55 +03:00
|
|
|
VMSTATE_STRUCT_ARRAY(regs, I8257State, 4, 1, vmstate_i8257_regs,
|
|
|
|
I8257Regs),
|
2009-09-10 05:04:39 +04:00
|
|
|
VMSTATE_END_OF_LIST()
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static void i8257_realize(DeviceState *dev, Error **errp)
|
|
|
|
{
|
|
|
|
ISADevice *isa = ISA_DEVICE(dev);
|
|
|
|
I8257State *d = I8257(dev);
|
|
|
|
int i;
|
|
|
|
|
2020-02-22 20:12:37 +03:00
|
|
|
memory_region_init_io(&d->channel_io, OBJECT(dev), &channel_io_ops, d,
|
2016-02-03 19:28:56 +03:00
|
|
|
"dma-chan", 8 << d->dshift);
|
|
|
|
memory_region_add_subregion(isa_address_space_io(isa),
|
|
|
|
d->base, &d->channel_io);
|
|
|
|
|
2016-07-13 03:11:59 +03:00
|
|
|
isa_register_portio_list(isa, &d->portio_page,
|
|
|
|
d->page_base, page_portio_list, d,
|
2016-02-03 19:28:56 +03:00
|
|
|
"dma-page");
|
|
|
|
if (d->pageh_base >= 0) {
|
2016-07-13 03:11:59 +03:00
|
|
|
isa_register_portio_list(isa, &d->portio_pageh,
|
|
|
|
d->pageh_base, pageh_portio_list, d,
|
2016-02-03 19:28:56 +03:00
|
|
|
"dma-pageh");
|
|
|
|
}
|
|
|
|
|
|
|
|
memory_region_init_io(&d->cont_io, OBJECT(isa), &cont_io_ops, d,
|
|
|
|
"dma-cont", 8 << d->dshift);
|
|
|
|
memory_region_add_subregion(isa_address_space_io(isa),
|
|
|
|
d->base + (8 << d->dshift), &d->cont_io);
|
|
|
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(d->regs); ++i) {
|
|
|
|
d->regs[i].transfer_handler = i8257_phony_handler;
|
|
|
|
}
|
|
|
|
|
|
|
|
d->dma_bh = qemu_bh_new(i8257_dma_run, d);
|
|
|
|
}
|
|
|
|
|
|
|
|
static Property i8257_properties[] = {
|
|
|
|
DEFINE_PROP_INT32("base", I8257State, base, 0x00),
|
|
|
|
DEFINE_PROP_INT32("page-base", I8257State, page_base, 0x80),
|
|
|
|
DEFINE_PROP_INT32("pageh-base", I8257State, pageh_base, 0x480),
|
|
|
|
DEFINE_PROP_INT32("dshift", I8257State, dshift, 0),
|
|
|
|
DEFINE_PROP_END_OF_LIST()
|
|
|
|
};
|
|
|
|
|
|
|
|
static void i8257_class_init(ObjectClass *klass, void *data)
|
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
2016-02-03 19:28:57 +03:00
|
|
|
IsaDmaClass *idc = ISADMA_CLASS(klass);
|
2016-02-03 19:28:56 +03:00
|
|
|
|
|
|
|
dc->realize = i8257_realize;
|
|
|
|
dc->reset = i8257_reset;
|
|
|
|
dc->vmsd = &vmstate_i8257;
|
2020-01-10 18:30:32 +03:00
|
|
|
device_class_set_props(dc, i8257_properties);
|
2016-02-03 19:28:57 +03:00
|
|
|
|
|
|
|
idc->has_autoinitialization = i8257_dma_has_autoinitialization;
|
|
|
|
idc->read_memory = i8257_dma_read_memory;
|
|
|
|
idc->write_memory = i8257_dma_write_memory;
|
|
|
|
idc->hold_DREQ = i8257_dma_hold_DREQ;
|
|
|
|
idc->release_DREQ = i8257_dma_release_DREQ;
|
|
|
|
idc->schedule = i8257_dma_schedule;
|
|
|
|
idc->register_channel = i8257_dma_register_channel;
|
2016-08-31 19:15:51 +03:00
|
|
|
/* Reason: needs to be wired up by isa_bus_dma() to work */
|
2017-05-03 23:35:44 +03:00
|
|
|
dc->user_creatable = false;
|
2016-02-03 19:28:57 +03:00
|
|
|
}
|
|
|
|
|
2016-02-03 19:28:56 +03:00
|
|
|
static const TypeInfo i8257_info = {
|
|
|
|
.name = TYPE_I8257,
|
|
|
|
.parent = TYPE_ISA_DEVICE,
|
|
|
|
.instance_size = sizeof(I8257State),
|
|
|
|
.class_init = i8257_class_init,
|
2016-02-03 19:28:57 +03:00
|
|
|
.interfaces = (InterfaceInfo[]) {
|
|
|
|
{ TYPE_ISADMA },
|
|
|
|
{ }
|
|
|
|
}
|
2016-02-03 19:28:56 +03:00
|
|
|
};
|
|
|
|
|
|
|
|
static void i8257_register_types(void)
|
|
|
|
{
|
|
|
|
type_register_static(&i8257_info);
|
|
|
|
}
|
|
|
|
|
|
|
|
type_init(i8257_register_types)
|
|
|
|
|
2018-03-09 01:39:23 +03:00
|
|
|
void i8257_dma_init(ISABus *bus, bool high_page_enable)
|
2004-04-07 02:43:01 +04:00
|
|
|
{
|
2016-02-03 19:28:56 +03:00
|
|
|
ISADevice *isa1, *isa2;
|
|
|
|
DeviceState *d;
|
|
|
|
|
isa: Convert uses of isa_create() with Coccinelle
Replace
dev = isa_create(bus, type_name);
...
qdev_init_nofail(dev);
by
dev = isa_new(type_name);
...
isa_realize_and_unref(dev, bus, &error_fatal);
Recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains
why.
Coccinelle script:
@@
expression dev, bus, expr;
expression list args;
expression d;
@@
- dev = isa_create(bus, args);
+ dev = isa_new(args);
(
d = &dev->qdev;
|
d = DEVICE(dev);
)
... when != dev = expr
- qdev_init_nofail(d);
+ isa_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = isa_create(bus, args);
+ dev = isa_new(args);
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ isa_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = DEVICE(isa_create(bus, args));
+ ISADevice *isa_dev; // TODO move
+ isa_dev = isa_new(args);
+ dev = DEVICE(isa_dev);
... when != dev = expr
- qdev_init_nofail(dev);
+ isa_realize_and_unref(isa_dev, bus, &error_fatal);
Missing #include "qapi/error.h" added manually, whitespace changes
minimized manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-20-armbru@redhat.com>
2020-06-10 08:32:08 +03:00
|
|
|
isa1 = isa_new(TYPE_I8257);
|
2016-02-03 19:28:56 +03:00
|
|
|
d = DEVICE(isa1);
|
|
|
|
qdev_prop_set_int32(d, "base", 0x00);
|
|
|
|
qdev_prop_set_int32(d, "page-base", 0x80);
|
|
|
|
qdev_prop_set_int32(d, "pageh-base", high_page_enable ? 0x480 : -1);
|
|
|
|
qdev_prop_set_int32(d, "dshift", 0);
|
isa: Convert uses of isa_create() with Coccinelle
Replace
dev = isa_create(bus, type_name);
...
qdev_init_nofail(dev);
by
dev = isa_new(type_name);
...
isa_realize_and_unref(dev, bus, &error_fatal);
Recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains
why.
Coccinelle script:
@@
expression dev, bus, expr;
expression list args;
expression d;
@@
- dev = isa_create(bus, args);
+ dev = isa_new(args);
(
d = &dev->qdev;
|
d = DEVICE(dev);
)
... when != dev = expr
- qdev_init_nofail(d);
+ isa_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = isa_create(bus, args);
+ dev = isa_new(args);
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ isa_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = DEVICE(isa_create(bus, args));
+ ISADevice *isa_dev; // TODO move
+ isa_dev = isa_new(args);
+ dev = DEVICE(isa_dev);
... when != dev = expr
- qdev_init_nofail(dev);
+ isa_realize_and_unref(isa_dev, bus, &error_fatal);
Missing #include "qapi/error.h" added manually, whitespace changes
minimized manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-20-armbru@redhat.com>
2020-06-10 08:32:08 +03:00
|
|
|
isa_realize_and_unref(isa1, bus, &error_fatal);
|
2016-02-03 19:28:56 +03:00
|
|
|
|
isa: Convert uses of isa_create() with Coccinelle
Replace
dev = isa_create(bus, type_name);
...
qdev_init_nofail(dev);
by
dev = isa_new(type_name);
...
isa_realize_and_unref(dev, bus, &error_fatal);
Recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains
why.
Coccinelle script:
@@
expression dev, bus, expr;
expression list args;
expression d;
@@
- dev = isa_create(bus, args);
+ dev = isa_new(args);
(
d = &dev->qdev;
|
d = DEVICE(dev);
)
... when != dev = expr
- qdev_init_nofail(d);
+ isa_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = isa_create(bus, args);
+ dev = isa_new(args);
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ isa_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = DEVICE(isa_create(bus, args));
+ ISADevice *isa_dev; // TODO move
+ isa_dev = isa_new(args);
+ dev = DEVICE(isa_dev);
... when != dev = expr
- qdev_init_nofail(dev);
+ isa_realize_and_unref(isa_dev, bus, &error_fatal);
Missing #include "qapi/error.h" added manually, whitespace changes
minimized manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-20-armbru@redhat.com>
2020-06-10 08:32:08 +03:00
|
|
|
isa2 = isa_new(TYPE_I8257);
|
2016-02-03 19:28:56 +03:00
|
|
|
d = DEVICE(isa2);
|
|
|
|
qdev_prop_set_int32(d, "base", 0xc0);
|
|
|
|
qdev_prop_set_int32(d, "page-base", 0x88);
|
|
|
|
qdev_prop_set_int32(d, "pageh-base", high_page_enable ? 0x488 : -1);
|
|
|
|
qdev_prop_set_int32(d, "dshift", 1);
|
isa: Convert uses of isa_create() with Coccinelle
Replace
dev = isa_create(bus, type_name);
...
qdev_init_nofail(dev);
by
dev = isa_new(type_name);
...
isa_realize_and_unref(dev, bus, &error_fatal);
Recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains
why.
Coccinelle script:
@@
expression dev, bus, expr;
expression list args;
expression d;
@@
- dev = isa_create(bus, args);
+ dev = isa_new(args);
(
d = &dev->qdev;
|
d = DEVICE(dev);
)
... when != dev = expr
- qdev_init_nofail(d);
+ isa_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = isa_create(bus, args);
+ dev = isa_new(args);
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ isa_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = DEVICE(isa_create(bus, args));
+ ISADevice *isa_dev; // TODO move
+ isa_dev = isa_new(args);
+ dev = DEVICE(isa_dev);
... when != dev = expr
- qdev_init_nofail(dev);
+ isa_realize_and_unref(isa_dev, bus, &error_fatal);
Missing #include "qapi/error.h" added manually, whitespace changes
minimized manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-20-armbru@redhat.com>
2020-06-10 08:32:08 +03:00
|
|
|
isa_realize_and_unref(isa2, bus, &error_fatal);
|
2016-02-03 19:28:57 +03:00
|
|
|
|
|
|
|
isa_bus_dma(bus, ISADMA(isa1), ISADMA(isa2));
|
2003-11-13 04:46:15 +03:00
|
|
|
}
|