2015-04-28 16:27:52 +03:00
|
|
|
/*
|
|
|
|
* Block layer I/O functions
|
|
|
|
*
|
|
|
|
* Copyright (c) 2003 Fabrice Bellard
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
|
|
* in the Software without restriction, including without limitation the rights
|
|
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
|
|
* furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice shall be included in
|
|
|
|
* all copies or substantial portions of the Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
|
|
* THE SOFTWARE.
|
|
|
|
*/
|
|
|
|
|
2016-01-18 21:01:42 +03:00
|
|
|
#include "qemu/osdep.h"
|
2015-04-28 16:27:52 +03:00
|
|
|
#include "trace.h"
|
2015-10-19 18:53:21 +03:00
|
|
|
#include "sysemu/block-backend.h"
|
2018-02-16 19:50:12 +03:00
|
|
|
#include "block/aio-wait.h"
|
2015-04-28 16:27:52 +03:00
|
|
|
#include "block/blockjob.h"
|
2017-05-08 17:13:03 +03:00
|
|
|
#include "block/blockjob_int.h"
|
2015-04-28 16:27:52 +03:00
|
|
|
#include "block/block_int.h"
|
2020-09-24 21:54:10 +03:00
|
|
|
#include "block/coroutines.h"
|
2022-12-21 16:35:49 +03:00
|
|
|
#include "block/dirty-bitmap.h"
|
2021-05-06 12:06:14 +03:00
|
|
|
#include "block/write-threshold.h"
|
2016-03-20 20:16:19 +03:00
|
|
|
#include "qemu/cutils.h"
|
2022-02-26 21:07:23 +03:00
|
|
|
#include "qemu/memalign.h"
|
include/qemu/osdep.h: Don't include qapi/error.h
Commit 57cb38b included qapi/error.h into qemu/osdep.h to get the
Error typedef. Since then, we've moved to include qemu/osdep.h
everywhere. Its file comment explains: "To avoid getting into
possible circular include dependencies, this file should not include
any other QEMU headers, with the exceptions of config-host.h,
compiler.h, os-posix.h and os-win32.h, all of which are doing a
similar job to this file and are under similar constraints."
qapi/error.h doesn't do a similar job, and it doesn't adhere to
similar constraints: it includes qapi-types.h. That's in excess of
100KiB of crap most .c files don't actually need.
Add the typedef to qemu/typedefs.h, and include that instead of
qapi/error.h. Include qapi/error.h in .c files that need it and don't
get it now. Include qapi-types.h in qom/object.h for uint16List.
Update scripts/clean-includes accordingly. Update it further to match
reality: replace config.h by config-target.h, add sysemu/os-posix.h,
sysemu/os-win32.h. Update the list of includes in the qemu/osdep.h
comment quoted above similarly.
This reduces the number of objects depending on qapi/error.h from "all
of them" to less than a third. Unfortunately, the number depending on
qapi-types.h shrinks only a little. More work is needed for that one.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
[Fix compilation without the spice devel packages. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2016-03-14 11:01:28 +03:00
|
|
|
#include "qapi/error.h"
|
2015-03-17 20:29:20 +03:00
|
|
|
#include "qemu/error-report.h"
|
Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed. Touching it now
recompiles only some 1700 objects. For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
2019-08-12 08:23:50 +03:00
|
|
|
#include "qemu/main-loop.h"
|
2019-09-17 14:58:08 +03:00
|
|
|
#include "sysemu/replay.h"
|
2015-04-28 16:27:52 +03:00
|
|
|
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
/* Maximum bounce buffer for copy-on-read and write zeroes, in bytes */
|
|
|
|
#define MAX_BOUNCE_BUFFER (32768 << BDRV_SECTOR_BITS)
|
|
|
|
|
2023-09-29 17:51:41 +03:00
|
|
|
static void coroutine_fn GRAPH_RDLOCK
|
|
|
|
bdrv_parent_cb_resize(BlockDriverState *bs);
|
|
|
|
|
2016-06-02 00:10:03 +03:00
|
|
|
static int coroutine_fn bdrv_co_do_pwrite_zeroes(BlockDriverState *bs,
|
2020-12-11 21:39:28 +03:00
|
|
|
int64_t offset, int64_t bytes, BdrvRequestFlags flags);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2023-09-29 17:51:40 +03:00
|
|
|
static void GRAPH_RDLOCK
|
|
|
|
bdrv_parent_drained_begin(BlockDriverState *bs, BdrvChild *ignore)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2017-11-29 13:25:10 +03:00
|
|
|
BdrvChild *c, *next;
|
2023-09-29 17:51:40 +03:00
|
|
|
IO_OR_GS_CODE();
|
|
|
|
assert_bdrv_graph_readable();
|
2016-03-21 14:56:44 +03:00
|
|
|
|
2017-11-29 13:25:10 +03:00
|
|
|
QLIST_FOREACH_SAFE(c, &bs->parents, next_parent, next) {
|
2022-11-18 20:41:07 +03:00
|
|
|
if (c == ignore) {
|
2017-12-07 15:03:13 +03:00
|
|
|
continue;
|
|
|
|
}
|
2022-11-18 20:41:10 +03:00
|
|
|
bdrv_parent_drained_begin_single(c);
|
2016-04-07 19:33:33 +03:00
|
|
|
}
|
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2022-11-18 20:40:59 +03:00
|
|
|
void bdrv_parent_drained_end_single(BdrvChild *c)
|
block: Introduce BdrvChild.parent_quiesce_counter
Commit 5cb2737e925042e6c7cd3fb0b01313950b03cddf laid out why
bdrv_do_drained_end() must decrement the quiesce_counter after
bdrv_drain_invoke(). It did not give a very good reason why it has to
happen after bdrv_parent_drained_end(), instead only claiming symmetry
to bdrv_do_drained_begin().
It turns out that delaying it for so long is wrong.
Situation: We have an active commit job (i.e. a mirror job) from top to
base for the following graph:
filter
|
[file]
|
v
top --[backing]--> base
Now the VM is closed, which results in the job being cancelled and a
bdrv_drain_all() happening pretty much simultaneously.
Beginning the drain means the job is paused once whenever one of its
nodes is quiesced. This is reversed when the drain ends.
With how the code currently is, after base's drain ends (which means
that it will have unpaused the job once), its quiesce_counter remains at
1 while it goes to undrain its parents (bdrv_parent_drained_end()). For
some reason or another, undraining filter causes the job to be kicked
and enter mirror_exit_common(), where it proceeds to invoke
block_job_remove_all_bdrv().
Now base will be detached from the job. Because its quiesce_counter is
still 1, it will unpause the job once more. So in total, undraining
base will unpause the job twice. Eventually, this will lead to the
job's pause_count going negative -- well, it would, were there not an
assertion against this, which crashes qemu.
The general problem is that if in bdrv_parent_drained_end() we undrain
parent A, and then undrain parent B, which then leads to A detaching the
child, bdrv_replace_child_noperm() will undrain A as if we had not done
so yet; that is, one time too many.
It follows that we cannot decrement the quiesce_counter after invoking
bdrv_parent_drained_end().
Unfortunately, decrementing it before bdrv_parent_drained_end() would be
wrong, too. Imagine the above situation in reverse: Undraining A leads
to B detaching the child. If we had already decremented the
quiesce_counter by that point, bdrv_replace_child_noperm() would undrain
B one time too little; because it expects bdrv_parent_drained_end() to
issue this undrain. But bdrv_parent_drained_end() won't do that,
because B is no longer a parent.
Therefore, we have to do something else. This patch opts for
introducing a second quiesce_counter that counts how many times a
child's parent has been quiesced (though c->role->drained_*). With
that, bdrv_replace_child_noperm() just has to undrain the parent exactly
that many times when removing a child, and it will always be right.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2019-07-19 12:26:09 +03:00
|
|
|
{
|
2023-05-16 22:02:28 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
2022-11-18 20:40:59 +03:00
|
|
|
|
block: Call drain callbacks only once
We only need to call both the BlockDriver's callback and the parent
callbacks when going from undrained to drained or vice versa. A second
drain section doesn't make a difference for the driver or the parent,
they weren't supposed to send new requests before and after the second
drain.
One thing that gets in the way is the 'ignore_bds_parents' parameter in
bdrv_do_drained_begin_quiesce() and bdrv_do_drained_end(): It means that
bdrv_drain_all_begin() increases bs->quiesce_counter, but does not
quiesce the parent through BdrvChildClass callbacks. If an additional
drain section is started now, bs->quiesce_counter will be non-zero, but
we would still need to quiesce the parent through BdrvChildClass in
order to keep things consistent (and unquiesce it on the matching
bdrv_drained_end(), even though the counter would not reach 0 yet as
long as the bdrv_drain_all() section is still active).
Instead of keeping track of this, let's just get rid of the parameter.
It was introduced in commit 6cd5c9d7b2d as an optimisation so that
during bdrv_drain_all(), we wouldn't recursively drain all parents up to
the root for each node, resulting in quadratic complexity. As it happens,
calling the callbacks only once solves the same problem, so as of this
patch, we'll still have O(n) complexity and ignore_bds_parents is not
needed any more.
This patch only ignores the 'ignore_bds_parents' parameter. It will be
removed in a separate patch.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20221118174110.55183-12-kwolf@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2022-11-18 20:41:06 +03:00
|
|
|
assert(c->quiesced_parent);
|
|
|
|
c->quiesced_parent = false;
|
|
|
|
|
2020-05-13 14:05:13 +03:00
|
|
|
if (c->klass->drained_end) {
|
2022-11-18 20:40:59 +03:00
|
|
|
c->klass->drained_end(c);
|
block: Introduce BdrvChild.parent_quiesce_counter
Commit 5cb2737e925042e6c7cd3fb0b01313950b03cddf laid out why
bdrv_do_drained_end() must decrement the quiesce_counter after
bdrv_drain_invoke(). It did not give a very good reason why it has to
happen after bdrv_parent_drained_end(), instead only claiming symmetry
to bdrv_do_drained_begin().
It turns out that delaying it for so long is wrong.
Situation: We have an active commit job (i.e. a mirror job) from top to
base for the following graph:
filter
|
[file]
|
v
top --[backing]--> base
Now the VM is closed, which results in the job being cancelled and a
bdrv_drain_all() happening pretty much simultaneously.
Beginning the drain means the job is paused once whenever one of its
nodes is quiesced. This is reversed when the drain ends.
With how the code currently is, after base's drain ends (which means
that it will have unpaused the job once), its quiesce_counter remains at
1 while it goes to undrain its parents (bdrv_parent_drained_end()). For
some reason or another, undraining filter causes the job to be kicked
and enter mirror_exit_common(), where it proceeds to invoke
block_job_remove_all_bdrv().
Now base will be detached from the job. Because its quiesce_counter is
still 1, it will unpause the job once more. So in total, undraining
base will unpause the job twice. Eventually, this will lead to the
job's pause_count going negative -- well, it would, were there not an
assertion against this, which crashes qemu.
The general problem is that if in bdrv_parent_drained_end() we undrain
parent A, and then undrain parent B, which then leads to A detaching the
child, bdrv_replace_child_noperm() will undrain A as if we had not done
so yet; that is, one time too many.
It follows that we cannot decrement the quiesce_counter after invoking
bdrv_parent_drained_end().
Unfortunately, decrementing it before bdrv_parent_drained_end() would be
wrong, too. Imagine the above situation in reverse: Undraining A leads
to B detaching the child. If we had already decremented the
quiesce_counter by that point, bdrv_replace_child_noperm() would undrain
B one time too little; because it expects bdrv_parent_drained_end() to
issue this undrain. But bdrv_parent_drained_end() won't do that,
because B is no longer a parent.
Therefore, we have to do something else. This patch opts for
introducing a second quiesce_counter that counts how many times a
child's parent has been quiesced (though c->role->drained_*). With
that, bdrv_replace_child_noperm() just has to undrain the parent exactly
that many times when removing a child, and it will always be right.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2019-07-19 12:26:09 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-09-29 17:51:40 +03:00
|
|
|
static void GRAPH_RDLOCK
|
|
|
|
bdrv_parent_drained_end(BlockDriverState *bs, BdrvChild *ignore)
|
2016-04-07 19:33:33 +03:00
|
|
|
{
|
2019-07-19 12:26:16 +03:00
|
|
|
BdrvChild *c;
|
2023-09-29 17:51:40 +03:00
|
|
|
IO_OR_GS_CODE();
|
|
|
|
assert_bdrv_graph_readable();
|
2016-03-21 14:56:44 +03:00
|
|
|
|
2019-07-19 12:26:16 +03:00
|
|
|
QLIST_FOREACH(c, &bs->parents, next_parent) {
|
2022-11-18 20:41:07 +03:00
|
|
|
if (c == ignore) {
|
2017-12-07 15:03:13 +03:00
|
|
|
continue;
|
|
|
|
}
|
2022-11-18 20:40:59 +03:00
|
|
|
bdrv_parent_drained_end_single(c);
|
2016-03-21 14:56:44 +03:00
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2022-11-18 20:41:09 +03:00
|
|
|
bool bdrv_parent_drained_poll_single(BdrvChild *c)
|
2018-06-29 19:01:31 +03:00
|
|
|
{
|
2023-09-29 17:51:40 +03:00
|
|
|
IO_OR_GS_CODE();
|
|
|
|
|
2020-05-13 14:05:13 +03:00
|
|
|
if (c->klass->drained_poll) {
|
|
|
|
return c->klass->drained_poll(c);
|
2018-06-29 19:01:31 +03:00
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2023-09-29 17:51:40 +03:00
|
|
|
static bool GRAPH_RDLOCK
|
|
|
|
bdrv_parent_drained_poll(BlockDriverState *bs, BdrvChild *ignore,
|
|
|
|
bool ignore_bds_parents)
|
2018-03-22 16:11:20 +03:00
|
|
|
{
|
|
|
|
BdrvChild *c, *next;
|
|
|
|
bool busy = false;
|
2023-09-29 17:51:40 +03:00
|
|
|
IO_OR_GS_CODE();
|
|
|
|
assert_bdrv_graph_readable();
|
2018-03-22 16:11:20 +03:00
|
|
|
|
|
|
|
QLIST_FOREACH_SAFE(c, &bs->parents, next_parent, next) {
|
2020-05-13 14:05:13 +03:00
|
|
|
if (c == ignore || (ignore_bds_parents && c->klass->parent_is_bds)) {
|
2018-03-22 16:11:20 +03:00
|
|
|
continue;
|
|
|
|
}
|
2018-06-29 19:01:31 +03:00
|
|
|
busy |= bdrv_parent_drained_poll_single(c);
|
2018-03-22 16:11:20 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
return busy;
|
|
|
|
}
|
|
|
|
|
2022-11-18 20:41:10 +03:00
|
|
|
void bdrv_parent_drained_begin_single(BdrvChild *c)
|
2018-06-29 19:01:31 +03:00
|
|
|
{
|
2023-05-16 22:02:28 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
block: Call drain callbacks only once
We only need to call both the BlockDriver's callback and the parent
callbacks when going from undrained to drained or vice versa. A second
drain section doesn't make a difference for the driver or the parent,
they weren't supposed to send new requests before and after the second
drain.
One thing that gets in the way is the 'ignore_bds_parents' parameter in
bdrv_do_drained_begin_quiesce() and bdrv_do_drained_end(): It means that
bdrv_drain_all_begin() increases bs->quiesce_counter, but does not
quiesce the parent through BdrvChildClass callbacks. If an additional
drain section is started now, bs->quiesce_counter will be non-zero, but
we would still need to quiesce the parent through BdrvChildClass in
order to keep things consistent (and unquiesce it on the matching
bdrv_drained_end(), even though the counter would not reach 0 yet as
long as the bdrv_drain_all() section is still active).
Instead of keeping track of this, let's just get rid of the parameter.
It was introduced in commit 6cd5c9d7b2d as an optimisation so that
during bdrv_drain_all(), we wouldn't recursively drain all parents up to
the root for each node, resulting in quadratic complexity. As it happens,
calling the callbacks only once solves the same problem, so as of this
patch, we'll still have O(n) complexity and ignore_bds_parents is not
needed any more.
This patch only ignores the 'ignore_bds_parents' parameter. It will be
removed in a separate patch.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20221118174110.55183-12-kwolf@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2022-11-18 20:41:06 +03:00
|
|
|
|
|
|
|
assert(!c->quiesced_parent);
|
|
|
|
c->quiesced_parent = true;
|
|
|
|
|
2020-05-13 14:05:13 +03:00
|
|
|
if (c->klass->drained_begin) {
|
2023-09-29 17:51:40 +03:00
|
|
|
/* called with rdlock taken, but it doesn't really need it. */
|
2020-05-13 14:05:13 +03:00
|
|
|
c->klass->drained_begin(c);
|
2018-06-29 19:01:31 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-06-24 01:37:23 +03:00
|
|
|
static void bdrv_merge_limits(BlockLimits *dst, const BlockLimits *src)
|
|
|
|
{
|
2021-07-05 16:04:58 +03:00
|
|
|
dst->pdiscard_alignment = MAX(dst->pdiscard_alignment,
|
|
|
|
src->pdiscard_alignment);
|
2016-06-24 01:37:23 +03:00
|
|
|
dst->opt_transfer = MAX(dst->opt_transfer, src->opt_transfer);
|
|
|
|
dst->max_transfer = MIN_NON_ZERO(dst->max_transfer, src->max_transfer);
|
2021-06-03 11:34:23 +03:00
|
|
|
dst->max_hw_transfer = MIN_NON_ZERO(dst->max_hw_transfer,
|
|
|
|
src->max_hw_transfer);
|
2016-06-24 01:37:23 +03:00
|
|
|
dst->opt_mem_alignment = MAX(dst->opt_mem_alignment,
|
|
|
|
src->opt_mem_alignment);
|
|
|
|
dst->min_mem_alignment = MAX(dst->min_mem_alignment,
|
|
|
|
src->min_mem_alignment);
|
|
|
|
dst->max_iov = MIN_NON_ZERO(dst->max_iov, src->max_iov);
|
2021-09-23 16:04:36 +03:00
|
|
|
dst->max_hw_iov = MIN_NON_ZERO(dst->max_hw_iov, src->max_hw_iov);
|
2016-06-24 01:37:23 +03:00
|
|
|
}
|
|
|
|
|
2021-04-28 18:17:55 +03:00
|
|
|
typedef struct BdrvRefreshLimitsState {
|
|
|
|
BlockDriverState *bs;
|
|
|
|
BlockLimits old_bl;
|
|
|
|
} BdrvRefreshLimitsState;
|
|
|
|
|
|
|
|
static void bdrv_refresh_limits_abort(void *opaque)
|
|
|
|
{
|
|
|
|
BdrvRefreshLimitsState *s = opaque;
|
|
|
|
|
|
|
|
s->bs->bl = s->old_bl;
|
|
|
|
}
|
|
|
|
|
|
|
|
static TransactionActionDrv bdrv_refresh_limits_drv = {
|
|
|
|
.abort = bdrv_refresh_limits_abort,
|
|
|
|
.clean = g_free,
|
|
|
|
};
|
|
|
|
|
|
|
|
/* @tran is allowed to be NULL, in this case no rollback is possible. */
|
|
|
|
void bdrv_refresh_limits(BlockDriverState *bs, Transaction *tran, Error **errp)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2020-12-04 01:27:11 +03:00
|
|
|
ERRP_GUARD();
|
2015-04-28 16:27:52 +03:00
|
|
|
BlockDriver *drv = bs->drv;
|
2019-06-12 19:15:03 +03:00
|
|
|
BdrvChild *c;
|
|
|
|
bool have_limits;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2022-03-03 18:15:49 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
|
|
|
|
2021-04-28 18:17:55 +03:00
|
|
|
if (tran) {
|
|
|
|
BdrvRefreshLimitsState *s = g_new(BdrvRefreshLimitsState, 1);
|
|
|
|
*s = (BdrvRefreshLimitsState) {
|
|
|
|
.bs = bs,
|
|
|
|
.old_bl = bs->bl,
|
|
|
|
};
|
|
|
|
tran_add(tran, &bdrv_refresh_limits_drv, s);
|
|
|
|
}
|
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
memset(&bs->bl, 0, sizeof(bs->bl));
|
|
|
|
|
|
|
|
if (!drv) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2016-06-24 01:37:18 +03:00
|
|
|
/* Default alignment based on whether driver has byte interface */
|
block: Support byte-based aio callbacks
We are gradually moving away from sector-based interfaces, towards
byte-based. Add new sector-based aio callbacks for read and write,
to match the fact that bdrv_aio_pdiscard is already byte-based.
Ideally, drivers should be converted to use coroutine callbacks
rather than aio; but that is not quite as trivial (and if we were
to do that conversion, the null-aio driver would disappear), so for
the short term, converting the signature but keeping things with
aio is easier. However, we CAN declare that a driver that uses
the byte-based aio interfaces now defaults to byte-based
operations, and must explicitly provide a refresh_limits override
to stick with larger alignments (making the alignment issues more
obvious directly in the drivers touched in the next few patches).
Once all drivers are converted, the sector-based aio callbacks will
be removed; in the meantime, a FIXME comment is added due to a
slight inefficiency that will be touched up as part of that later
cleanup.
Simplify some instances of 'bs->drv' into 'drv' while touching this,
since the local variable already exists to reduce typing.
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2018-04-24 22:25:01 +03:00
|
|
|
bs->bl.request_alignment = (drv->bdrv_co_preadv ||
|
2019-06-04 19:15:06 +03:00
|
|
|
drv->bdrv_aio_preadv ||
|
|
|
|
drv->bdrv_co_preadv_part) ? 1 : 512;
|
2016-06-24 01:37:18 +03:00
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
/* Take some limits from the children as a default */
|
2019-06-12 19:15:03 +03:00
|
|
|
have_limits = false;
|
|
|
|
QLIST_FOREACH(c, &bs->children, next) {
|
|
|
|
if (c->role & (BDRV_CHILD_DATA | BDRV_CHILD_FILTERED | BDRV_CHILD_COW))
|
|
|
|
{
|
|
|
|
bdrv_merge_limits(&bs->bl, &c->bs->bl);
|
|
|
|
have_limits = true;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
2023-04-07 18:32:56 +03:00
|
|
|
|
|
|
|
if (c->role & BDRV_CHILD_FILTERED) {
|
|
|
|
bs->bl.has_variable_length |= c->bs->bl.has_variable_length;
|
|
|
|
}
|
2019-06-12 19:15:03 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!have_limits) {
|
2015-05-12 17:30:55 +03:00
|
|
|
bs->bl.min_mem_alignment = 512;
|
2022-03-23 18:57:22 +03:00
|
|
|
bs->bl.opt_mem_alignment = qemu_real_host_page_size();
|
2015-07-09 12:56:44 +03:00
|
|
|
|
|
|
|
/* Safe default since most protocols use readv()/writev()/etc */
|
|
|
|
bs->bl.max_iov = IOV_MAX;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Then let the driver override it */
|
|
|
|
if (drv->bdrv_refresh_limits) {
|
|
|
|
drv->bdrv_refresh_limits(bs, errp);
|
block: introduce BDRV_MAX_LENGTH
We are going to modify block layer to work with 64bit requests. And
first step is moving to int64_t type for both offset and bytes
arguments in all block request related functions.
It's mostly safe (when widening signed or unsigned int to int64_t), but
switching from uint64_t is questionable.
So, let's first establish the set of requests we want to work with.
First signed int64_t should be enough, as off_t is signed anyway. Then,
obviously offset + bytes should not overflow.
And most interesting: (offset + bytes) being aligned up should not
overflow as well. Aligned to what alignment? First thing that comes in
mind is bs->bl.request_alignment, as we align up request to this
alignment. But there is another thing: look at
bdrv_mark_request_serialising(). It aligns request up to some given
alignment. And this parameter may be bdrv_get_cluster_size(), which is
often a lot greater than bs->bl.request_alignment.
Note also, that bdrv_mark_request_serialising() uses signed int64_t for
calculations. So, actually, we already depend on some restrictions.
Happily, bdrv_get_cluster_size() returns int and
bs->bl.request_alignment has 32bit unsigned type, but defined to be a
power of 2 less than INT_MAX. So, we may establish, that INT_MAX is
absolute maximum for any kind of alignment that may occur with the
request.
Note, that bdrv_get_cluster_size() is not documented to return power
of 2, still bdrv_mark_request_serialising() behaves like it is.
Also, backup uses bdi.cluster_size and is not prepared to it not being
power of 2.
So, let's establish that Qemu supports only power-of-2 clusters and
alignments.
So, alignment can't be greater than 2^30.
Finally to be safe with calculations, to not calculate different
maximums for different nodes (depending on cluster size and
request_alignment), let's simply set QEMU_ALIGN_DOWN(INT64_MAX, 2^30)
as absolute maximum bytes length for Qemu. Actually, it's not much less
than INT64_MAX.
OK, then, let's apply it to block/io.
Let's consider all block/io entry points of offset/bytes:
4 bytes/offset interface functions: bdrv_co_preadv_part(),
bdrv_co_pwritev_part(), bdrv_co_copy_range_internal() and
bdrv_co_pdiscard() and we check them all with bdrv_check_request().
We also have one entry point with only offset: bdrv_co_truncate().
Check the offset.
And one public structure: BdrvTrackedRequest. Happily, it has only
three external users:
file-posix.c: adopted by this patch
write-threshold.c: only read fields
test-write-threshold.c: sets obviously small constant values
Better is to make the structure private and add corresponding
interfaces.. Still it's not obvious what kind of interface is needed
for file-posix.c. Let's keep it public but add corresponding
assertions.
After this patch we'll convert functions in block/io.c to int64_t bytes
and offset parameters. We can assume that offset/bytes pair always
satisfy new restrictions, and make
corresponding assertions where needed. If we reach some offset/bytes
point in block/io.c missing bdrv_check_request() it is considered a
bug. As well, if block/io.c modifies a offset/bytes request, expanding
it more then aligning up to request_alignment, it's a bug too.
For all io requests except for discard we keep for now old restriction
of 32bit request length.
iotest 206 output error message changed, as now test disk size is
larger than new limit. Add one more test case with new maximum disk
size to cover too-big-L1 case.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201203222713.13507-5-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-12-04 01:27:13 +03:00
|
|
|
if (*errp) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (bs->bl.request_alignment > BDRV_MAX_ALIGNMENT) {
|
|
|
|
error_setg(errp, "Driver requires too large request alignment");
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* The copy-on-read flag is actually a reference count so multiple users may
|
|
|
|
* use the feature without worrying about clobbering its previous state.
|
|
|
|
* Copy-on-read stays enabled until all users have called to disable it.
|
|
|
|
*/
|
|
|
|
void bdrv_enable_copy_on_read(BlockDriverState *bs)
|
|
|
|
{
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2020-09-23 13:56:46 +03:00
|
|
|
qatomic_inc(&bs->copy_on_read);
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
void bdrv_disable_copy_on_read(BlockDriverState *bs)
|
|
|
|
{
|
2020-09-23 13:56:46 +03:00
|
|
|
int old = qatomic_fetch_dec(&bs->copy_on_read);
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2017-06-05 15:38:50 +03:00
|
|
|
assert(old >= 1);
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2017-06-29 16:27:45 +03:00
|
|
|
typedef struct {
|
|
|
|
Coroutine *co;
|
|
|
|
BlockDriverState *bs;
|
|
|
|
bool done;
|
2017-09-23 14:14:09 +03:00
|
|
|
bool begin;
|
2018-03-23 14:40:41 +03:00
|
|
|
bool poll;
|
2017-12-07 15:03:13 +03:00
|
|
|
BdrvChild *parent;
|
2017-06-29 16:27:45 +03:00
|
|
|
} BdrvCoDrainData;
|
|
|
|
|
2018-03-22 12:57:14 +03:00
|
|
|
/* Returns true if BDRV_POLL_WHILE() should go into a blocking aio_poll() */
|
2022-11-18 20:41:05 +03:00
|
|
|
bool bdrv_drain_poll(BlockDriverState *bs, BdrvChild *ignore_parent,
|
|
|
|
bool ignore_bds_parents)
|
2018-03-22 16:11:20 +03:00
|
|
|
{
|
2023-05-16 22:02:28 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
2018-03-23 14:40:41 +03:00
|
|
|
|
2018-05-29 18:17:45 +03:00
|
|
|
if (bdrv_parent_drained_poll(bs, ignore_parent, ignore_bds_parents)) {
|
2018-03-22 16:11:20 +03:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2020-09-23 13:56:46 +03:00
|
|
|
if (qatomic_read(&bs->in_flight)) {
|
2018-03-23 14:40:41 +03:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
2018-03-22 16:11:20 +03:00
|
|
|
}
|
|
|
|
|
2022-11-18 20:41:05 +03:00
|
|
|
static bool bdrv_drain_poll_top_level(BlockDriverState *bs,
|
2018-03-22 16:11:20 +03:00
|
|
|
BdrvChild *ignore_parent)
|
2018-03-22 12:57:14 +03:00
|
|
|
{
|
2023-09-29 17:51:40 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
|
|
|
GRAPH_RDLOCK_GUARD_MAINLOOP();
|
|
|
|
|
2022-11-18 20:41:05 +03:00
|
|
|
return bdrv_drain_poll(bs, ignore_parent, false);
|
2018-03-22 12:57:14 +03:00
|
|
|
}
|
|
|
|
|
2022-11-18 20:41:05 +03:00
|
|
|
static void bdrv_do_drained_begin(BlockDriverState *bs, BdrvChild *parent,
|
2022-11-18 20:41:07 +03:00
|
|
|
bool poll);
|
|
|
|
static void bdrv_do_drained_end(BlockDriverState *bs, BdrvChild *parent);
|
2017-12-07 15:03:13 +03:00
|
|
|
|
2016-04-05 14:20:52 +03:00
|
|
|
static void bdrv_co_drain_bh_cb(void *opaque)
|
|
|
|
{
|
|
|
|
BdrvCoDrainData *data = opaque;
|
|
|
|
Coroutine *co = data->co;
|
2016-10-27 13:48:52 +03:00
|
|
|
BlockDriverState *bs = data->bs;
|
2016-04-05 14:20:52 +03:00
|
|
|
|
2018-04-10 17:07:55 +03:00
|
|
|
if (bs) {
|
|
|
|
bdrv_dec_in_flight(bs);
|
|
|
|
if (data->begin) {
|
2022-11-18 20:41:07 +03:00
|
|
|
bdrv_do_drained_begin(bs, data->parent, data->poll);
|
2018-04-10 17:07:55 +03:00
|
|
|
} else {
|
block: Do not poll in bdrv_do_drained_end()
We should never poll anywhere in bdrv_do_drained_end() (including its
recursive callees like bdrv_drain_invoke()), because it does not cope
well with graph changes. In fact, it has been written based on the
postulation that no graph changes will happen in it.
Instead, the callers that want to poll must poll, i.e. all currently
globally available wrappers: bdrv_drained_end(),
bdrv_subtree_drained_end(), bdrv_unapply_subtree_drain(), and
bdrv_drain_all_end(). Graph changes there do not matter.
They can poll simply by passing a pointer to a drained_end_counter and
wait until it reaches 0.
This patch also adds a non-polling global wrapper for
bdrv_do_drained_end() that takes a drained_end_counter pointer. We need
such a variant because now no function called anywhere from
bdrv_do_drained_end() must poll. This includes
BdrvChildRole.drained_end(), which already must not poll according to
its interface documentation, but bdrv_child_cb_drained_end() just
violates that by invoking bdrv_drained_end() (which does poll).
Therefore, BdrvChildRole.drained_end() must take a *drained_end_counter
parameter, which bdrv_child_cb_drained_end() can pass on to the new
bdrv_drained_end_no_poll() function.
Note that we now have a pattern of all drained_end-related functions
either polling or receiving a *drained_end_counter to let the caller
poll based on that.
A problem with a single poll loop is that when the drained section in
bdrv_set_aio_context_ignore() ends, some nodes in the subgraph may be in
the old contexts, while others are in the new context already. To let
the collective poll in bdrv_drained_end() work correctly, we must not
hold a lock to the old context, so that the old context can make
progress in case it is different from the current context.
(In the process, remove the comment saying that the current context is
always the old context, because it is wrong.)
In all other places, all nodes in a subtree must be in the same context,
so we can just poll that. The exception of course is
bdrv_drain_all_end(), but that always runs in the main context, so we
can just poll NULL (like bdrv_drain_all_begin() does).
Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2019-07-19 12:26:14 +03:00
|
|
|
assert(!data->poll);
|
2022-11-18 20:41:07 +03:00
|
|
|
bdrv_do_drained_end(bs, data->parent);
|
2018-04-10 17:07:55 +03:00
|
|
|
}
|
2017-09-23 14:14:09 +03:00
|
|
|
} else {
|
2018-04-10 17:07:55 +03:00
|
|
|
assert(data->begin);
|
|
|
|
bdrv_drain_all_begin();
|
2017-09-23 14:14:09 +03:00
|
|
|
}
|
|
|
|
|
2016-04-05 14:20:52 +03:00
|
|
|
data->done = true;
|
2017-02-13 16:52:31 +03:00
|
|
|
aio_co_wake(co);
|
2016-04-05 14:20:52 +03:00
|
|
|
}
|
|
|
|
|
2017-09-23 14:14:09 +03:00
|
|
|
static void coroutine_fn bdrv_co_yield_to_drain(BlockDriverState *bs,
|
2022-11-18 20:41:05 +03:00
|
|
|
bool begin,
|
2018-05-29 18:17:45 +03:00
|
|
|
BdrvChild *parent,
|
2022-11-18 20:40:59 +03:00
|
|
|
bool poll)
|
2016-04-05 14:20:52 +03:00
|
|
|
{
|
|
|
|
BdrvCoDrainData data;
|
2020-12-03 20:23:11 +03:00
|
|
|
Coroutine *self = qemu_coroutine_self();
|
2016-04-05 14:20:52 +03:00
|
|
|
|
|
|
|
/* Calling bdrv_drain() from a BH ensures the current coroutine yields and
|
2018-03-22 18:28:33 +03:00
|
|
|
* other coroutines run if they were queued by aio_co_enter(). */
|
2016-04-05 14:20:52 +03:00
|
|
|
|
|
|
|
assert(qemu_in_coroutine());
|
|
|
|
data = (BdrvCoDrainData) {
|
2020-12-03 20:23:11 +03:00
|
|
|
.co = self,
|
2016-04-05 14:20:52 +03:00
|
|
|
.bs = bs,
|
|
|
|
.done = false,
|
2017-09-23 14:14:09 +03:00
|
|
|
.begin = begin,
|
2017-12-07 15:03:13 +03:00
|
|
|
.parent = parent,
|
2018-03-23 14:40:41 +03:00
|
|
|
.poll = poll,
|
2016-04-05 14:20:52 +03:00
|
|
|
};
|
2019-07-19 12:26:11 +03:00
|
|
|
|
2018-04-10 17:07:55 +03:00
|
|
|
if (bs) {
|
|
|
|
bdrv_inc_in_flight(bs);
|
|
|
|
}
|
2020-12-03 20:23:11 +03:00
|
|
|
|
2023-05-16 22:02:28 +03:00
|
|
|
replay_bh_schedule_oneshot_event(qemu_get_aio_context(),
|
|
|
|
bdrv_co_drain_bh_cb, &data);
|
2016-04-05 14:20:52 +03:00
|
|
|
|
|
|
|
qemu_coroutine_yield();
|
|
|
|
/* If we are resumed from some other event (such as an aio completion or a
|
|
|
|
* timer callback), it is a bug in the caller that should be fixed. */
|
|
|
|
assert(data.done);
|
|
|
|
}
|
|
|
|
|
2022-11-18 20:41:08 +03:00
|
|
|
static void bdrv_do_drained_begin(BlockDriverState *bs, BdrvChild *parent,
|
|
|
|
bool poll)
|
2016-05-23 17:08:55 +03:00
|
|
|
{
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_OR_GS_CODE();
|
2022-11-18 20:41:08 +03:00
|
|
|
|
|
|
|
if (qemu_in_coroutine()) {
|
|
|
|
bdrv_co_yield_to_drain(bs, true, parent, poll);
|
|
|
|
return;
|
|
|
|
}
|
2016-10-27 13:48:53 +03:00
|
|
|
|
2023-05-16 22:02:28 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
|
|
|
|
2017-12-06 13:00:59 +03:00
|
|
|
/* Stop things in parent-to-child order */
|
2020-09-23 13:56:46 +03:00
|
|
|
if (qatomic_fetch_inc(&bs->quiesce_counter) == 0) {
|
2023-09-29 17:51:40 +03:00
|
|
|
GRAPH_RDLOCK_GUARD_MAINLOOP();
|
2022-11-18 20:41:07 +03:00
|
|
|
bdrv_parent_drained_begin(bs, parent);
|
block: Call drain callbacks only once
We only need to call both the BlockDriver's callback and the parent
callbacks when going from undrained to drained or vice versa. A second
drain section doesn't make a difference for the driver or the parent,
they weren't supposed to send new requests before and after the second
drain.
One thing that gets in the way is the 'ignore_bds_parents' parameter in
bdrv_do_drained_begin_quiesce() and bdrv_do_drained_end(): It means that
bdrv_drain_all_begin() increases bs->quiesce_counter, but does not
quiesce the parent through BdrvChildClass callbacks. If an additional
drain section is started now, bs->quiesce_counter will be non-zero, but
we would still need to quiesce the parent through BdrvChildClass in
order to keep things consistent (and unquiesce it on the matching
bdrv_drained_end(), even though the counter would not reach 0 yet as
long as the bdrv_drain_all() section is still active).
Instead of keeping track of this, let's just get rid of the parameter.
It was introduced in commit 6cd5c9d7b2d as an optimisation so that
during bdrv_drain_all(), we wouldn't recursively drain all parents up to
the root for each node, resulting in quadratic complexity. As it happens,
calling the callbacks only once solves the same problem, so as of this
patch, we'll still have O(n) complexity and ignore_bds_parents is not
needed any more.
This patch only ignores the 'ignore_bds_parents' parameter. It will be
removed in a separate patch.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20221118174110.55183-12-kwolf@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2022-11-18 20:41:06 +03:00
|
|
|
if (bs->drv && bs->drv->bdrv_drain_begin) {
|
|
|
|
bs->drv->bdrv_drain_begin(bs);
|
|
|
|
}
|
2022-11-18 20:41:00 +03:00
|
|
|
}
|
2018-03-22 16:35:58 +03:00
|
|
|
|
2018-03-23 14:40:41 +03:00
|
|
|
/*
|
|
|
|
* Wait for drained requests to finish.
|
|
|
|
*
|
|
|
|
* Calling BDRV_POLL_WHILE() only once for the top-level node is okay: The
|
|
|
|
* call is needed so things in this AioContext can make progress even
|
|
|
|
* though we don't return to the main AioContext loop - this automatically
|
|
|
|
* includes other nodes in the same AioContext and therefore all child
|
|
|
|
* nodes.
|
|
|
|
*/
|
|
|
|
if (poll) {
|
2022-11-18 20:41:05 +03:00
|
|
|
BDRV_POLL_WHILE(bs, bdrv_drain_poll_top_level(bs, parent));
|
2018-03-23 14:40:41 +03:00
|
|
|
}
|
2016-05-23 17:08:55 +03:00
|
|
|
}
|
|
|
|
|
2022-11-18 20:41:08 +03:00
|
|
|
void bdrv_do_drained_begin_quiesce(BlockDriverState *bs, BdrvChild *parent)
|
|
|
|
{
|
|
|
|
bdrv_do_drained_begin(bs, parent, false);
|
|
|
|
}
|
|
|
|
|
2023-04-12 12:23:00 +03:00
|
|
|
void coroutine_mixed_fn
|
|
|
|
bdrv_drained_begin(BlockDriverState *bs)
|
2017-12-07 15:03:13 +03:00
|
|
|
{
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_OR_GS_CODE();
|
2022-11-18 20:41:07 +03:00
|
|
|
bdrv_do_drained_begin(bs, NULL, true);
|
2017-12-07 15:03:13 +03:00
|
|
|
}
|
|
|
|
|
block: Do not poll in bdrv_do_drained_end()
We should never poll anywhere in bdrv_do_drained_end() (including its
recursive callees like bdrv_drain_invoke()), because it does not cope
well with graph changes. In fact, it has been written based on the
postulation that no graph changes will happen in it.
Instead, the callers that want to poll must poll, i.e. all currently
globally available wrappers: bdrv_drained_end(),
bdrv_subtree_drained_end(), bdrv_unapply_subtree_drain(), and
bdrv_drain_all_end(). Graph changes there do not matter.
They can poll simply by passing a pointer to a drained_end_counter and
wait until it reaches 0.
This patch also adds a non-polling global wrapper for
bdrv_do_drained_end() that takes a drained_end_counter pointer. We need
such a variant because now no function called anywhere from
bdrv_do_drained_end() must poll. This includes
BdrvChildRole.drained_end(), which already must not poll according to
its interface documentation, but bdrv_child_cb_drained_end() just
violates that by invoking bdrv_drained_end() (which does poll).
Therefore, BdrvChildRole.drained_end() must take a *drained_end_counter
parameter, which bdrv_child_cb_drained_end() can pass on to the new
bdrv_drained_end_no_poll() function.
Note that we now have a pattern of all drained_end-related functions
either polling or receiving a *drained_end_counter to let the caller
poll based on that.
A problem with a single poll loop is that when the drained section in
bdrv_set_aio_context_ignore() ends, some nodes in the subgraph may be in
the old contexts, while others are in the new context already. To let
the collective poll in bdrv_drained_end() work correctly, we must not
hold a lock to the old context, so that the old context can make
progress in case it is different from the current context.
(In the process, remove the comment saying that the current context is
always the old context, because it is wrong.)
In all other places, all nodes in a subtree must be in the same context,
so we can just poll that. The exception of course is
bdrv_drain_all_end(), but that always runs in the main context, so we
can just poll NULL (like bdrv_drain_all_begin() does).
Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2019-07-19 12:26:14 +03:00
|
|
|
/**
|
|
|
|
* This function does not poll, nor must any of its recursively called
|
2022-11-18 20:40:59 +03:00
|
|
|
* functions.
|
block: Do not poll in bdrv_do_drained_end()
We should never poll anywhere in bdrv_do_drained_end() (including its
recursive callees like bdrv_drain_invoke()), because it does not cope
well with graph changes. In fact, it has been written based on the
postulation that no graph changes will happen in it.
Instead, the callers that want to poll must poll, i.e. all currently
globally available wrappers: bdrv_drained_end(),
bdrv_subtree_drained_end(), bdrv_unapply_subtree_drain(), and
bdrv_drain_all_end(). Graph changes there do not matter.
They can poll simply by passing a pointer to a drained_end_counter and
wait until it reaches 0.
This patch also adds a non-polling global wrapper for
bdrv_do_drained_end() that takes a drained_end_counter pointer. We need
such a variant because now no function called anywhere from
bdrv_do_drained_end() must poll. This includes
BdrvChildRole.drained_end(), which already must not poll according to
its interface documentation, but bdrv_child_cb_drained_end() just
violates that by invoking bdrv_drained_end() (which does poll).
Therefore, BdrvChildRole.drained_end() must take a *drained_end_counter
parameter, which bdrv_child_cb_drained_end() can pass on to the new
bdrv_drained_end_no_poll() function.
Note that we now have a pattern of all drained_end-related functions
either polling or receiving a *drained_end_counter to let the caller
poll based on that.
A problem with a single poll loop is that when the drained section in
bdrv_set_aio_context_ignore() ends, some nodes in the subgraph may be in
the old contexts, while others are in the new context already. To let
the collective poll in bdrv_drained_end() work correctly, we must not
hold a lock to the old context, so that the old context can make
progress in case it is different from the current context.
(In the process, remove the comment saying that the current context is
always the old context, because it is wrong.)
In all other places, all nodes in a subtree must be in the same context,
so we can just poll that. The exception of course is
bdrv_drain_all_end(), but that always runs in the main context, so we
can just poll NULL (like bdrv_drain_all_begin() does).
Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2019-07-19 12:26:14 +03:00
|
|
|
*/
|
2022-11-18 20:41:07 +03:00
|
|
|
static void bdrv_do_drained_end(BlockDriverState *bs, BdrvChild *parent)
|
2016-05-23 17:08:55 +03:00
|
|
|
{
|
2017-12-13 20:14:18 +03:00
|
|
|
int old_quiesce_counter;
|
|
|
|
|
2023-05-16 22:02:28 +03:00
|
|
|
IO_OR_GS_CODE();
|
|
|
|
|
2017-09-23 14:14:09 +03:00
|
|
|
if (qemu_in_coroutine()) {
|
2022-11-18 20:41:07 +03:00
|
|
|
bdrv_co_yield_to_drain(bs, false, parent, false);
|
2017-09-23 14:14:09 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-29 17:51:40 +03:00
|
|
|
|
|
|
|
/* At this point, we should be always running in the main loop. */
|
|
|
|
GLOBAL_STATE_CODE();
|
2016-05-23 17:08:55 +03:00
|
|
|
assert(bs->quiesce_counter > 0);
|
2023-05-16 22:02:28 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
2016-05-23 17:08:55 +03:00
|
|
|
|
2017-12-06 13:00:59 +03:00
|
|
|
/* Re-enable things in child-to-parent order */
|
2020-09-23 13:56:46 +03:00
|
|
|
old_quiesce_counter = qatomic_fetch_dec(&bs->quiesce_counter);
|
2017-12-13 20:14:18 +03:00
|
|
|
if (old_quiesce_counter == 1) {
|
2023-09-29 17:51:40 +03:00
|
|
|
GRAPH_RDLOCK_GUARD_MAINLOOP();
|
block: Call drain callbacks only once
We only need to call both the BlockDriver's callback and the parent
callbacks when going from undrained to drained or vice versa. A second
drain section doesn't make a difference for the driver or the parent,
they weren't supposed to send new requests before and after the second
drain.
One thing that gets in the way is the 'ignore_bds_parents' parameter in
bdrv_do_drained_begin_quiesce() and bdrv_do_drained_end(): It means that
bdrv_drain_all_begin() increases bs->quiesce_counter, but does not
quiesce the parent through BdrvChildClass callbacks. If an additional
drain section is started now, bs->quiesce_counter will be non-zero, but
we would still need to quiesce the parent through BdrvChildClass in
order to keep things consistent (and unquiesce it on the matching
bdrv_drained_end(), even though the counter would not reach 0 yet as
long as the bdrv_drain_all() section is still active).
Instead of keeping track of this, let's just get rid of the parameter.
It was introduced in commit 6cd5c9d7b2d as an optimisation so that
during bdrv_drain_all(), we wouldn't recursively drain all parents up to
the root for each node, resulting in quadratic complexity. As it happens,
calling the callbacks only once solves the same problem, so as of this
patch, we'll still have O(n) complexity and ignore_bds_parents is not
needed any more.
This patch only ignores the 'ignore_bds_parents' parameter. It will be
removed in a separate patch.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20221118174110.55183-12-kwolf@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2022-11-18 20:41:06 +03:00
|
|
|
if (bs->drv && bs->drv->bdrv_drain_end) {
|
|
|
|
bs->drv->bdrv_drain_end(bs);
|
|
|
|
}
|
2022-11-18 20:41:07 +03:00
|
|
|
bdrv_parent_drained_end(bs, parent);
|
2017-12-13 20:14:18 +03:00
|
|
|
}
|
2016-05-23 17:08:55 +03:00
|
|
|
}
|
|
|
|
|
2017-12-07 15:03:13 +03:00
|
|
|
void bdrv_drained_end(BlockDriverState *bs)
|
|
|
|
{
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_OR_GS_CODE();
|
2022-11-18 20:41:07 +03:00
|
|
|
bdrv_do_drained_end(bs, NULL);
|
2017-12-18 18:05:48 +03:00
|
|
|
}
|
|
|
|
|
2016-04-07 19:33:32 +03:00
|
|
|
void bdrv_drain(BlockDriverState *bs)
|
|
|
|
{
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_OR_GS_CODE();
|
2016-05-23 17:08:55 +03:00
|
|
|
bdrv_drained_begin(bs);
|
|
|
|
bdrv_drained_end(bs);
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2017-12-14 13:25:16 +03:00
|
|
|
static void bdrv_drain_assert_idle(BlockDriverState *bs)
|
|
|
|
{
|
|
|
|
BdrvChild *child, *next;
|
2023-09-29 17:51:40 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
|
|
|
GRAPH_RDLOCK_GUARD_MAINLOOP();
|
2017-12-14 13:25:16 +03:00
|
|
|
|
2020-09-23 13:56:46 +03:00
|
|
|
assert(qatomic_read(&bs->in_flight) == 0);
|
2017-12-14 13:25:16 +03:00
|
|
|
QLIST_FOREACH_SAFE(child, &bs->children, next, next) {
|
|
|
|
bdrv_drain_assert_idle(child->bs);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-03-28 19:29:18 +03:00
|
|
|
unsigned int bdrv_drain_all_count = 0;
|
|
|
|
|
|
|
|
static bool bdrv_drain_all_poll(void)
|
|
|
|
{
|
|
|
|
BlockDriverState *bs = NULL;
|
|
|
|
bool result = false;
|
2023-09-29 17:51:40 +03:00
|
|
|
|
2022-03-03 18:15:49 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
2023-09-29 17:51:40 +03:00
|
|
|
GRAPH_RDLOCK_GUARD_MAINLOOP();
|
2018-03-28 19:29:18 +03:00
|
|
|
|
2023-12-05 21:20:03 +03:00
|
|
|
/*
|
|
|
|
* bdrv_drain_poll() can't make changes to the graph and we hold the BQL,
|
|
|
|
* so iterating bdrv_next_all_states() is safe.
|
|
|
|
*/
|
2018-03-28 19:29:18 +03:00
|
|
|
while ((bs = bdrv_next_all_states(bs))) {
|
2022-11-18 20:41:05 +03:00
|
|
|
result |= bdrv_drain_poll(bs, NULL, true);
|
2018-03-28 19:29:18 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
/*
|
|
|
|
* Wait for pending requests to complete across all BlockDriverStates
|
|
|
|
*
|
|
|
|
* This function does not flush data to disk, use bdrv_flush_all() for that
|
|
|
|
* after calling this function.
|
2016-10-28 10:08:02 +03:00
|
|
|
*
|
|
|
|
* This pauses all block jobs and disables external clients. It must
|
|
|
|
* be paired with bdrv_drain_all_end().
|
|
|
|
*
|
|
|
|
* NOTE: no new block jobs or BlockDriverStates can be created between
|
|
|
|
* the bdrv_drain_all_begin() and bdrv_drain_all_end() calls.
|
2015-04-28 16:27:52 +03:00
|
|
|
*/
|
2022-12-07 16:18:21 +03:00
|
|
|
void bdrv_drain_all_begin_nopoll(void)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2018-03-28 19:29:18 +03:00
|
|
|
BlockDriverState *bs = NULL;
|
2022-03-03 18:15:49 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2019-09-17 14:58:08 +03:00
|
|
|
/*
|
|
|
|
* bdrv queue is managed by record/replay,
|
|
|
|
* waiting for finishing the I/O requests may
|
|
|
|
* be infinite
|
|
|
|
*/
|
|
|
|
if (replay_events_enabled()) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2018-03-28 19:29:18 +03:00
|
|
|
/* AIO_WAIT_WHILE() with a NULL context can only be called from the main
|
|
|
|
* loop AioContext, so make sure we're in the main context. */
|
2017-12-15 11:33:21 +03:00
|
|
|
assert(qemu_get_current_aio_context() == qemu_get_aio_context());
|
2018-03-28 19:29:18 +03:00
|
|
|
assert(bdrv_drain_all_count < INT_MAX);
|
|
|
|
bdrv_drain_all_count++;
|
2017-12-15 11:33:21 +03:00
|
|
|
|
2018-03-28 19:29:18 +03:00
|
|
|
/* Quiesce all nodes, without polling in-flight requests yet. The graph
|
|
|
|
* cannot change during this loop. */
|
|
|
|
while ((bs = bdrv_next_all_states(bs))) {
|
2022-11-18 20:41:07 +03:00
|
|
|
bdrv_do_drained_begin(bs, NULL, false);
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
2022-12-07 16:18:21 +03:00
|
|
|
}
|
|
|
|
|
2023-04-12 12:23:00 +03:00
|
|
|
void coroutine_mixed_fn bdrv_drain_all_begin(void)
|
2022-12-07 16:18:21 +03:00
|
|
|
{
|
|
|
|
BlockDriverState *bs = NULL;
|
|
|
|
|
|
|
|
if (qemu_in_coroutine()) {
|
|
|
|
bdrv_co_yield_to_drain(NULL, true, NULL, true);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2022-12-20 20:46:38 +03:00
|
|
|
/*
|
|
|
|
* bdrv queue is managed by record/replay,
|
|
|
|
* waiting for finishing the I/O requests may
|
|
|
|
* be infinite
|
|
|
|
*/
|
|
|
|
if (replay_events_enabled()) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2022-12-07 16:18:21 +03:00
|
|
|
bdrv_drain_all_begin_nopoll();
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2018-03-28 19:29:18 +03:00
|
|
|
/* Now poll the in-flight requests */
|
2023-03-09 22:08:53 +03:00
|
|
|
AIO_WAIT_WHILE_UNLOCKED(NULL, bdrv_drain_all_poll());
|
2018-03-28 19:29:18 +03:00
|
|
|
|
|
|
|
while ((bs = bdrv_next_all_states(bs))) {
|
2017-12-14 13:25:16 +03:00
|
|
|
bdrv_drain_assert_idle(bs);
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
2016-10-28 10:08:02 +03:00
|
|
|
}
|
|
|
|
|
2020-10-23 18:01:10 +03:00
|
|
|
void bdrv_drain_all_end_quiesce(BlockDriverState *bs)
|
|
|
|
{
|
2022-03-03 18:15:57 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
2020-10-23 18:01:10 +03:00
|
|
|
|
|
|
|
g_assert(bs->quiesce_counter > 0);
|
|
|
|
g_assert(!bs->refcnt);
|
|
|
|
|
|
|
|
while (bs->quiesce_counter) {
|
2022-11-18 20:41:07 +03:00
|
|
|
bdrv_do_drained_end(bs, NULL);
|
2020-10-23 18:01:10 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-10-28 10:08:02 +03:00
|
|
|
void bdrv_drain_all_end(void)
|
|
|
|
{
|
2018-03-28 19:29:18 +03:00
|
|
|
BlockDriverState *bs = NULL;
|
2022-03-03 18:15:49 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
2016-10-28 10:08:02 +03:00
|
|
|
|
2019-09-17 14:58:08 +03:00
|
|
|
/*
|
|
|
|
* bdrv queue is managed by record/replay,
|
|
|
|
* waiting for finishing the I/O requests may
|
|
|
|
* be endless
|
|
|
|
*/
|
|
|
|
if (replay_events_enabled()) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2018-03-28 19:29:18 +03:00
|
|
|
while ((bs = bdrv_next_all_states(bs))) {
|
2022-11-18 20:41:07 +03:00
|
|
|
bdrv_do_drained_end(bs, NULL);
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
2018-03-28 19:29:18 +03:00
|
|
|
|
block: Do not poll in bdrv_do_drained_end()
We should never poll anywhere in bdrv_do_drained_end() (including its
recursive callees like bdrv_drain_invoke()), because it does not cope
well with graph changes. In fact, it has been written based on the
postulation that no graph changes will happen in it.
Instead, the callers that want to poll must poll, i.e. all currently
globally available wrappers: bdrv_drained_end(),
bdrv_subtree_drained_end(), bdrv_unapply_subtree_drain(), and
bdrv_drain_all_end(). Graph changes there do not matter.
They can poll simply by passing a pointer to a drained_end_counter and
wait until it reaches 0.
This patch also adds a non-polling global wrapper for
bdrv_do_drained_end() that takes a drained_end_counter pointer. We need
such a variant because now no function called anywhere from
bdrv_do_drained_end() must poll. This includes
BdrvChildRole.drained_end(), which already must not poll according to
its interface documentation, but bdrv_child_cb_drained_end() just
violates that by invoking bdrv_drained_end() (which does poll).
Therefore, BdrvChildRole.drained_end() must take a *drained_end_counter
parameter, which bdrv_child_cb_drained_end() can pass on to the new
bdrv_drained_end_no_poll() function.
Note that we now have a pattern of all drained_end-related functions
either polling or receiving a *drained_end_counter to let the caller
poll based on that.
A problem with a single poll loop is that when the drained section in
bdrv_set_aio_context_ignore() ends, some nodes in the subgraph may be in
the old contexts, while others are in the new context already. To let
the collective poll in bdrv_drained_end() work correctly, we must not
hold a lock to the old context, so that the old context can make
progress in case it is different from the current context.
(In the process, remove the comment saying that the current context is
always the old context, because it is wrong.)
In all other places, all nodes in a subtree must be in the same context,
so we can just poll that. The exception of course is
bdrv_drain_all_end(), but that always runs in the main context, so we
can just poll NULL (like bdrv_drain_all_begin() does).
Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2019-07-19 12:26:14 +03:00
|
|
|
assert(qemu_get_current_aio_context() == qemu_get_aio_context());
|
2018-03-28 19:29:18 +03:00
|
|
|
assert(bdrv_drain_all_count > 0);
|
|
|
|
bdrv_drain_all_count--;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2016-10-28 10:08:02 +03:00
|
|
|
void bdrv_drain_all(void)
|
|
|
|
{
|
2022-03-03 18:15:49 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
2016-10-28 10:08:02 +03:00
|
|
|
bdrv_drain_all_begin();
|
|
|
|
bdrv_drain_all_end();
|
|
|
|
}
|
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
/**
|
|
|
|
* Remove an active request from the tracked requests list
|
|
|
|
*
|
|
|
|
* This function should be called when a tracked request is completing.
|
|
|
|
*/
|
2022-04-27 16:08:30 +03:00
|
|
|
static void coroutine_fn tracked_request_end(BdrvTrackedRequest *req)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
|
|
|
if (req->serialising) {
|
2020-09-23 13:56:46 +03:00
|
|
|
qatomic_dec(&req->bs->serialising_in_flight);
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2023-08-08 18:58:52 +03:00
|
|
|
qemu_mutex_lock(&req->bs->reqs_lock);
|
2015-04-28 16:27:52 +03:00
|
|
|
QLIST_REMOVE(req, list);
|
2023-08-08 18:58:52 +03:00
|
|
|
qemu_mutex_unlock(&req->bs->reqs_lock);
|
2023-08-08 18:58:51 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* At this point qemu_co_queue_wait(&req->wait_queue, ...) won't be called
|
|
|
|
* anymore because the request has been removed from the list, so it's safe
|
|
|
|
* to restart the queue outside reqs_lock to minimize the critical section.
|
|
|
|
*/
|
2015-04-28 16:27:52 +03:00
|
|
|
qemu_co_queue_restart_all(&req->wait_queue);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Add an active request to the tracked requests list
|
|
|
|
*/
|
2022-09-22 11:49:00 +03:00
|
|
|
static void coroutine_fn tracked_request_begin(BdrvTrackedRequest *req,
|
|
|
|
BlockDriverState *bs,
|
|
|
|
int64_t offset,
|
|
|
|
int64_t bytes,
|
|
|
|
enum BdrvTrackedRequestType type)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2021-02-03 17:14:15 +03:00
|
|
|
bdrv_check_request(offset, bytes, &error_abort);
|
2018-07-10 09:31:18 +03:00
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
*req = (BdrvTrackedRequest){
|
|
|
|
.bs = bs,
|
|
|
|
.offset = offset,
|
|
|
|
.bytes = bytes,
|
2015-11-09 13:16:46 +03:00
|
|
|
.type = type,
|
2015-04-28 16:27:52 +03:00
|
|
|
.co = qemu_coroutine_self(),
|
|
|
|
.serialising = false,
|
|
|
|
.overlap_offset = offset,
|
|
|
|
.overlap_bytes = bytes,
|
|
|
|
};
|
|
|
|
|
|
|
|
qemu_co_queue_init(&req->wait_queue);
|
|
|
|
|
2023-08-08 18:58:52 +03:00
|
|
|
qemu_mutex_lock(&bs->reqs_lock);
|
2015-04-28 16:27:52 +03:00
|
|
|
QLIST_INSERT_HEAD(&bs->tracked_requests, req, list);
|
2023-08-08 18:58:52 +03:00
|
|
|
qemu_mutex_unlock(&bs->reqs_lock);
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2020-01-08 17:55:56 +03:00
|
|
|
static bool tracked_request_overlaps(BdrvTrackedRequest *req,
|
2021-02-03 17:14:15 +03:00
|
|
|
int64_t offset, int64_t bytes)
|
2020-01-08 17:55:56 +03:00
|
|
|
{
|
2021-02-03 17:14:15 +03:00
|
|
|
bdrv_check_request(offset, bytes, &error_abort);
|
|
|
|
|
2020-01-08 17:55:56 +03:00
|
|
|
/* aaaa bbbb */
|
|
|
|
if (offset >= req->overlap_offset + req->overlap_bytes) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
/* bbbb aaaa */
|
|
|
|
if (req->overlap_offset >= offset + bytes) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2020-10-21 17:58:41 +03:00
|
|
|
/* Called with self->bs->reqs_lock held */
|
2022-09-22 11:49:00 +03:00
|
|
|
static coroutine_fn BdrvTrackedRequest *
|
2020-10-21 17:58:41 +03:00
|
|
|
bdrv_find_conflicting_request(BdrvTrackedRequest *self)
|
|
|
|
{
|
|
|
|
BdrvTrackedRequest *req;
|
|
|
|
|
|
|
|
QLIST_FOREACH(req, &self->bs->tracked_requests, list) {
|
|
|
|
if (req == self || (!req->serialising && !self->serialising)) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (tracked_request_overlaps(req, self->overlap_offset,
|
|
|
|
self->overlap_bytes))
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* Hitting this means there was a reentrant request, for
|
|
|
|
* example, a block driver issuing nested requests. This must
|
|
|
|
* never happen since it means deadlock.
|
|
|
|
*/
|
|
|
|
assert(qemu_coroutine_self() != req->co);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the request is already (indirectly) waiting for us, or
|
|
|
|
* will wait for us as soon as it wakes up, then just go on
|
|
|
|
* (instead of producing a deadlock in the former case).
|
|
|
|
*/
|
|
|
|
if (!req->waiting_for) {
|
|
|
|
return req;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2020-10-21 17:58:42 +03:00
|
|
|
/* Called with self->bs->reqs_lock held */
|
2022-08-17 11:37:36 +03:00
|
|
|
static void coroutine_fn
|
2020-10-21 17:58:42 +03:00
|
|
|
bdrv_wait_serialising_requests_locked(BdrvTrackedRequest *self)
|
2020-01-08 17:55:56 +03:00
|
|
|
{
|
|
|
|
BdrvTrackedRequest *req;
|
|
|
|
|
2020-10-21 17:58:41 +03:00
|
|
|
while ((req = bdrv_find_conflicting_request(self))) {
|
|
|
|
self->waiting_for = req;
|
2020-10-21 17:58:42 +03:00
|
|
|
qemu_co_queue_wait(&req->wait_queue, &self->bs->reqs_lock);
|
2020-10-21 17:58:41 +03:00
|
|
|
self->waiting_for = NULL;
|
|
|
|
}
|
2020-01-08 17:55:56 +03:00
|
|
|
}
|
|
|
|
|
2020-10-21 17:58:43 +03:00
|
|
|
/* Called with req->bs->reqs_lock held */
|
|
|
|
static void tracked_request_set_serialising(BdrvTrackedRequest *req,
|
|
|
|
uint64_t align)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
|
|
|
int64_t overlap_offset = req->offset & ~(align - 1);
|
2021-02-03 17:14:15 +03:00
|
|
|
int64_t overlap_bytes =
|
|
|
|
ROUND_UP(req->offset + req->bytes, align) - overlap_offset;
|
|
|
|
|
|
|
|
bdrv_check_request(req->offset, req->bytes, &error_abort);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
|
|
|
if (!req->serialising) {
|
2020-09-23 13:56:46 +03:00
|
|
|
qatomic_inc(&req->bs->serialising_in_flight);
|
2015-04-28 16:27:52 +03:00
|
|
|
req->serialising = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
req->overlap_offset = MIN(req->overlap_offset, overlap_offset);
|
|
|
|
req->overlap_bytes = MAX(req->overlap_bytes, overlap_bytes);
|
2018-07-09 19:37:18 +03:00
|
|
|
}
|
|
|
|
|
2019-11-01 18:25:09 +03:00
|
|
|
/**
|
|
|
|
* Return the tracked request on @bs for the current coroutine, or
|
|
|
|
* NULL if there is none.
|
|
|
|
*/
|
|
|
|
BdrvTrackedRequest *coroutine_fn bdrv_co_get_self_request(BlockDriverState *bs)
|
|
|
|
{
|
|
|
|
BdrvTrackedRequest *req;
|
|
|
|
Coroutine *self = qemu_coroutine_self();
|
2022-03-03 18:15:58 +03:00
|
|
|
IO_CODE();
|
2019-11-01 18:25:09 +03:00
|
|
|
|
|
|
|
QLIST_FOREACH(req, &bs->tracked_requests, list) {
|
|
|
|
if (req->co == self) {
|
|
|
|
return req;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2016-06-02 12:41:52 +03:00
|
|
|
/**
|
2023-07-11 20:25:52 +03:00
|
|
|
* Round a region to subcluster (if supported) or cluster boundaries
|
2016-06-02 12:41:52 +03:00
|
|
|
*/
|
2023-05-04 14:57:44 +03:00
|
|
|
void coroutine_fn GRAPH_RDLOCK
|
2023-07-11 20:25:52 +03:00
|
|
|
bdrv_round_to_subclusters(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
|
|
|
int64_t *align_offset, int64_t *align_bytes)
|
2016-06-02 12:41:52 +03:00
|
|
|
{
|
|
|
|
BlockDriverInfo bdi;
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2023-07-11 20:25:52 +03:00
|
|
|
if (bdrv_co_get_info(bs, &bdi) < 0 || bdi.subcluster_size == 0) {
|
|
|
|
*align_offset = offset;
|
|
|
|
*align_bytes = bytes;
|
2016-06-02 12:41:52 +03:00
|
|
|
} else {
|
2023-07-11 20:25:52 +03:00
|
|
|
int64_t c = bdi.subcluster_size;
|
|
|
|
*align_offset = QEMU_ALIGN_DOWN(offset, c);
|
|
|
|
*align_bytes = QEMU_ALIGN_UP(offset - *align_offset + bytes, c);
|
2016-06-02 12:41:52 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-05-04 14:57:44 +03:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK bdrv_get_cluster_size(BlockDriverState *bs)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
|
|
|
BlockDriverInfo bdi;
|
|
|
|
int ret;
|
|
|
|
|
2023-01-13 23:42:08 +03:00
|
|
|
ret = bdrv_co_get_info(bs, &bdi);
|
2015-04-28 16:27:52 +03:00
|
|
|
if (ret < 0 || bdi.cluster_size == 0) {
|
2016-06-24 01:37:24 +03:00
|
|
|
return bs->bl.request_alignment;
|
2015-04-28 16:27:52 +03:00
|
|
|
} else {
|
|
|
|
return bdi.cluster_size;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-10-27 13:48:52 +03:00
|
|
|
void bdrv_inc_in_flight(BlockDriverState *bs)
|
|
|
|
{
|
2022-03-03 18:15:58 +03:00
|
|
|
IO_CODE();
|
2020-09-23 13:56:46 +03:00
|
|
|
qatomic_inc(&bs->in_flight);
|
2016-10-27 13:48:52 +03:00
|
|
|
}
|
|
|
|
|
2016-10-27 13:49:05 +03:00
|
|
|
void bdrv_wakeup(BlockDriverState *bs)
|
|
|
|
{
|
2022-03-03 18:15:58 +03:00
|
|
|
IO_CODE();
|
2018-09-18 18:09:16 +03:00
|
|
|
aio_wait_kick();
|
2016-10-27 13:49:05 +03:00
|
|
|
}
|
|
|
|
|
2016-10-27 13:48:52 +03:00
|
|
|
void bdrv_dec_in_flight(BlockDriverState *bs)
|
|
|
|
{
|
2022-03-03 18:15:58 +03:00
|
|
|
IO_CODE();
|
2020-09-23 13:56:46 +03:00
|
|
|
qatomic_dec(&bs->in_flight);
|
2016-10-27 13:49:05 +03:00
|
|
|
bdrv_wakeup(bs);
|
2016-10-27 13:48:52 +03:00
|
|
|
}
|
|
|
|
|
2022-08-17 11:37:36 +03:00
|
|
|
static void coroutine_fn
|
|
|
|
bdrv_wait_serialising_requests(BdrvTrackedRequest *self)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
|
|
|
BlockDriverState *bs = self->bs;
|
|
|
|
|
2020-09-23 13:56:46 +03:00
|
|
|
if (!qatomic_read(&bs->serialising_in_flight)) {
|
2022-08-17 11:37:36 +03:00
|
|
|
return;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2023-08-08 18:58:52 +03:00
|
|
|
qemu_mutex_lock(&bs->reqs_lock);
|
2022-08-17 11:37:36 +03:00
|
|
|
bdrv_wait_serialising_requests_locked(self);
|
2023-08-08 18:58:52 +03:00
|
|
|
qemu_mutex_unlock(&bs->reqs_lock);
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2022-08-17 11:37:36 +03:00
|
|
|
void coroutine_fn bdrv_make_request_serialising(BdrvTrackedRequest *req,
|
2020-10-21 17:58:43 +03:00
|
|
|
uint64_t align)
|
|
|
|
{
|
2022-03-03 18:15:58 +03:00
|
|
|
IO_CODE();
|
2020-10-21 17:58:43 +03:00
|
|
|
|
2023-08-08 18:58:52 +03:00
|
|
|
qemu_mutex_lock(&req->bs->reqs_lock);
|
2020-10-21 17:58:43 +03:00
|
|
|
|
|
|
|
tracked_request_set_serialising(req, align);
|
2022-08-17 11:37:36 +03:00
|
|
|
bdrv_wait_serialising_requests_locked(req);
|
2020-10-21 17:58:43 +03:00
|
|
|
|
2023-08-08 18:58:52 +03:00
|
|
|
qemu_mutex_unlock(&req->bs->reqs_lock);
|
2020-10-21 17:58:43 +03:00
|
|
|
}
|
|
|
|
|
2021-09-03 13:27:58 +03:00
|
|
|
int bdrv_check_qiov_request(int64_t offset, int64_t bytes,
|
|
|
|
QEMUIOVector *qiov, size_t qiov_offset,
|
|
|
|
Error **errp)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2020-12-11 21:39:25 +03:00
|
|
|
/*
|
|
|
|
* Check generic offset/bytes correctness
|
|
|
|
*/
|
|
|
|
|
2020-12-11 21:39:19 +03:00
|
|
|
if (offset < 0) {
|
|
|
|
error_setg(errp, "offset is negative: %" PRIi64, offset);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (bytes < 0) {
|
|
|
|
error_setg(errp, "bytes is negative: %" PRIi64, bytes);
|
2015-04-28 16:27:52 +03:00
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
block: introduce BDRV_MAX_LENGTH
We are going to modify block layer to work with 64bit requests. And
first step is moving to int64_t type for both offset and bytes
arguments in all block request related functions.
It's mostly safe (when widening signed or unsigned int to int64_t), but
switching from uint64_t is questionable.
So, let's first establish the set of requests we want to work with.
First signed int64_t should be enough, as off_t is signed anyway. Then,
obviously offset + bytes should not overflow.
And most interesting: (offset + bytes) being aligned up should not
overflow as well. Aligned to what alignment? First thing that comes in
mind is bs->bl.request_alignment, as we align up request to this
alignment. But there is another thing: look at
bdrv_mark_request_serialising(). It aligns request up to some given
alignment. And this parameter may be bdrv_get_cluster_size(), which is
often a lot greater than bs->bl.request_alignment.
Note also, that bdrv_mark_request_serialising() uses signed int64_t for
calculations. So, actually, we already depend on some restrictions.
Happily, bdrv_get_cluster_size() returns int and
bs->bl.request_alignment has 32bit unsigned type, but defined to be a
power of 2 less than INT_MAX. So, we may establish, that INT_MAX is
absolute maximum for any kind of alignment that may occur with the
request.
Note, that bdrv_get_cluster_size() is not documented to return power
of 2, still bdrv_mark_request_serialising() behaves like it is.
Also, backup uses bdi.cluster_size and is not prepared to it not being
power of 2.
So, let's establish that Qemu supports only power-of-2 clusters and
alignments.
So, alignment can't be greater than 2^30.
Finally to be safe with calculations, to not calculate different
maximums for different nodes (depending on cluster size and
request_alignment), let's simply set QEMU_ALIGN_DOWN(INT64_MAX, 2^30)
as absolute maximum bytes length for Qemu. Actually, it's not much less
than INT64_MAX.
OK, then, let's apply it to block/io.
Let's consider all block/io entry points of offset/bytes:
4 bytes/offset interface functions: bdrv_co_preadv_part(),
bdrv_co_pwritev_part(), bdrv_co_copy_range_internal() and
bdrv_co_pdiscard() and we check them all with bdrv_check_request().
We also have one entry point with only offset: bdrv_co_truncate().
Check the offset.
And one public structure: BdrvTrackedRequest. Happily, it has only
three external users:
file-posix.c: adopted by this patch
write-threshold.c: only read fields
test-write-threshold.c: sets obviously small constant values
Better is to make the structure private and add corresponding
interfaces.. Still it's not obvious what kind of interface is needed
for file-posix.c. Let's keep it public but add corresponding
assertions.
After this patch we'll convert functions in block/io.c to int64_t bytes
and offset parameters. We can assume that offset/bytes pair always
satisfy new restrictions, and make
corresponding assertions where needed. If we reach some offset/bytes
point in block/io.c missing bdrv_check_request() it is considered a
bug. As well, if block/io.c modifies a offset/bytes request, expanding
it more then aligning up to request_alignment, it's a bug too.
For all io requests except for discard we keep for now old restriction
of 32bit request length.
iotest 206 output error message changed, as now test disk size is
larger than new limit. Add one more test case with new maximum disk
size to cover too-big-L1 case.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201203222713.13507-5-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-12-04 01:27:13 +03:00
|
|
|
if (bytes > BDRV_MAX_LENGTH) {
|
2020-12-11 21:39:19 +03:00
|
|
|
error_setg(errp, "bytes(%" PRIi64 ") exceeds maximum(%" PRIi64 ")",
|
|
|
|
bytes, BDRV_MAX_LENGTH);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (offset > BDRV_MAX_LENGTH) {
|
|
|
|
error_setg(errp, "offset(%" PRIi64 ") exceeds maximum(%" PRIi64 ")",
|
|
|
|
offset, BDRV_MAX_LENGTH);
|
block: introduce BDRV_MAX_LENGTH
We are going to modify block layer to work with 64bit requests. And
first step is moving to int64_t type for both offset and bytes
arguments in all block request related functions.
It's mostly safe (when widening signed or unsigned int to int64_t), but
switching from uint64_t is questionable.
So, let's first establish the set of requests we want to work with.
First signed int64_t should be enough, as off_t is signed anyway. Then,
obviously offset + bytes should not overflow.
And most interesting: (offset + bytes) being aligned up should not
overflow as well. Aligned to what alignment? First thing that comes in
mind is bs->bl.request_alignment, as we align up request to this
alignment. But there is another thing: look at
bdrv_mark_request_serialising(). It aligns request up to some given
alignment. And this parameter may be bdrv_get_cluster_size(), which is
often a lot greater than bs->bl.request_alignment.
Note also, that bdrv_mark_request_serialising() uses signed int64_t for
calculations. So, actually, we already depend on some restrictions.
Happily, bdrv_get_cluster_size() returns int and
bs->bl.request_alignment has 32bit unsigned type, but defined to be a
power of 2 less than INT_MAX. So, we may establish, that INT_MAX is
absolute maximum for any kind of alignment that may occur with the
request.
Note, that bdrv_get_cluster_size() is not documented to return power
of 2, still bdrv_mark_request_serialising() behaves like it is.
Also, backup uses bdi.cluster_size and is not prepared to it not being
power of 2.
So, let's establish that Qemu supports only power-of-2 clusters and
alignments.
So, alignment can't be greater than 2^30.
Finally to be safe with calculations, to not calculate different
maximums for different nodes (depending on cluster size and
request_alignment), let's simply set QEMU_ALIGN_DOWN(INT64_MAX, 2^30)
as absolute maximum bytes length for Qemu. Actually, it's not much less
than INT64_MAX.
OK, then, let's apply it to block/io.
Let's consider all block/io entry points of offset/bytes:
4 bytes/offset interface functions: bdrv_co_preadv_part(),
bdrv_co_pwritev_part(), bdrv_co_copy_range_internal() and
bdrv_co_pdiscard() and we check them all with bdrv_check_request().
We also have one entry point with only offset: bdrv_co_truncate().
Check the offset.
And one public structure: BdrvTrackedRequest. Happily, it has only
three external users:
file-posix.c: adopted by this patch
write-threshold.c: only read fields
test-write-threshold.c: sets obviously small constant values
Better is to make the structure private and add corresponding
interfaces.. Still it's not obvious what kind of interface is needed
for file-posix.c. Let's keep it public but add corresponding
assertions.
After this patch we'll convert functions in block/io.c to int64_t bytes
and offset parameters. We can assume that offset/bytes pair always
satisfy new restrictions, and make
corresponding assertions where needed. If we reach some offset/bytes
point in block/io.c missing bdrv_check_request() it is considered a
bug. As well, if block/io.c modifies a offset/bytes request, expanding
it more then aligning up to request_alignment, it's a bug too.
For all io requests except for discard we keep for now old restriction
of 32bit request length.
iotest 206 output error message changed, as now test disk size is
larger than new limit. Add one more test case with new maximum disk
size to cover too-big-L1 case.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201203222713.13507-5-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-12-04 01:27:13 +03:00
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (offset > BDRV_MAX_LENGTH - bytes) {
|
2020-12-11 21:39:19 +03:00
|
|
|
error_setg(errp, "sum of offset(%" PRIi64 ") and bytes(%" PRIi64 ") "
|
|
|
|
"exceeds maximum(%" PRIi64 ")", offset, bytes,
|
|
|
|
BDRV_MAX_LENGTH);
|
block: introduce BDRV_MAX_LENGTH
We are going to modify block layer to work with 64bit requests. And
first step is moving to int64_t type for both offset and bytes
arguments in all block request related functions.
It's mostly safe (when widening signed or unsigned int to int64_t), but
switching from uint64_t is questionable.
So, let's first establish the set of requests we want to work with.
First signed int64_t should be enough, as off_t is signed anyway. Then,
obviously offset + bytes should not overflow.
And most interesting: (offset + bytes) being aligned up should not
overflow as well. Aligned to what alignment? First thing that comes in
mind is bs->bl.request_alignment, as we align up request to this
alignment. But there is another thing: look at
bdrv_mark_request_serialising(). It aligns request up to some given
alignment. And this parameter may be bdrv_get_cluster_size(), which is
often a lot greater than bs->bl.request_alignment.
Note also, that bdrv_mark_request_serialising() uses signed int64_t for
calculations. So, actually, we already depend on some restrictions.
Happily, bdrv_get_cluster_size() returns int and
bs->bl.request_alignment has 32bit unsigned type, but defined to be a
power of 2 less than INT_MAX. So, we may establish, that INT_MAX is
absolute maximum for any kind of alignment that may occur with the
request.
Note, that bdrv_get_cluster_size() is not documented to return power
of 2, still bdrv_mark_request_serialising() behaves like it is.
Also, backup uses bdi.cluster_size and is not prepared to it not being
power of 2.
So, let's establish that Qemu supports only power-of-2 clusters and
alignments.
So, alignment can't be greater than 2^30.
Finally to be safe with calculations, to not calculate different
maximums for different nodes (depending on cluster size and
request_alignment), let's simply set QEMU_ALIGN_DOWN(INT64_MAX, 2^30)
as absolute maximum bytes length for Qemu. Actually, it's not much less
than INT64_MAX.
OK, then, let's apply it to block/io.
Let's consider all block/io entry points of offset/bytes:
4 bytes/offset interface functions: bdrv_co_preadv_part(),
bdrv_co_pwritev_part(), bdrv_co_copy_range_internal() and
bdrv_co_pdiscard() and we check them all with bdrv_check_request().
We also have one entry point with only offset: bdrv_co_truncate().
Check the offset.
And one public structure: BdrvTrackedRequest. Happily, it has only
three external users:
file-posix.c: adopted by this patch
write-threshold.c: only read fields
test-write-threshold.c: sets obviously small constant values
Better is to make the structure private and add corresponding
interfaces.. Still it's not obvious what kind of interface is needed
for file-posix.c. Let's keep it public but add corresponding
assertions.
After this patch we'll convert functions in block/io.c to int64_t bytes
and offset parameters. We can assume that offset/bytes pair always
satisfy new restrictions, and make
corresponding assertions where needed. If we reach some offset/bytes
point in block/io.c missing bdrv_check_request() it is considered a
bug. As well, if block/io.c modifies a offset/bytes request, expanding
it more then aligning up to request_alignment, it's a bug too.
For all io requests except for discard we keep for now old restriction
of 32bit request length.
iotest 206 output error message changed, as now test disk size is
larger than new limit. Add one more test case with new maximum disk
size to cover too-big-L1 case.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201203222713.13507-5-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-12-04 01:27:13 +03:00
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
2020-12-11 21:39:25 +03:00
|
|
|
if (!qiov) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Check qiov and qiov_offset
|
|
|
|
*/
|
|
|
|
|
|
|
|
if (qiov_offset > qiov->size) {
|
|
|
|
error_setg(errp, "qiov_offset(%zu) overflow io vector size(%zu)",
|
|
|
|
qiov_offset, qiov->size);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (bytes > qiov->size - qiov_offset) {
|
|
|
|
error_setg(errp, "bytes(%" PRIi64 ") + qiov_offset(%zu) overflow io "
|
|
|
|
"vector size(%zu)", bytes, qiov_offset, qiov->size);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
block: introduce BDRV_MAX_LENGTH
We are going to modify block layer to work with 64bit requests. And
first step is moving to int64_t type for both offset and bytes
arguments in all block request related functions.
It's mostly safe (when widening signed or unsigned int to int64_t), but
switching from uint64_t is questionable.
So, let's first establish the set of requests we want to work with.
First signed int64_t should be enough, as off_t is signed anyway. Then,
obviously offset + bytes should not overflow.
And most interesting: (offset + bytes) being aligned up should not
overflow as well. Aligned to what alignment? First thing that comes in
mind is bs->bl.request_alignment, as we align up request to this
alignment. But there is another thing: look at
bdrv_mark_request_serialising(). It aligns request up to some given
alignment. And this parameter may be bdrv_get_cluster_size(), which is
often a lot greater than bs->bl.request_alignment.
Note also, that bdrv_mark_request_serialising() uses signed int64_t for
calculations. So, actually, we already depend on some restrictions.
Happily, bdrv_get_cluster_size() returns int and
bs->bl.request_alignment has 32bit unsigned type, but defined to be a
power of 2 less than INT_MAX. So, we may establish, that INT_MAX is
absolute maximum for any kind of alignment that may occur with the
request.
Note, that bdrv_get_cluster_size() is not documented to return power
of 2, still bdrv_mark_request_serialising() behaves like it is.
Also, backup uses bdi.cluster_size and is not prepared to it not being
power of 2.
So, let's establish that Qemu supports only power-of-2 clusters and
alignments.
So, alignment can't be greater than 2^30.
Finally to be safe with calculations, to not calculate different
maximums for different nodes (depending on cluster size and
request_alignment), let's simply set QEMU_ALIGN_DOWN(INT64_MAX, 2^30)
as absolute maximum bytes length for Qemu. Actually, it's not much less
than INT64_MAX.
OK, then, let's apply it to block/io.
Let's consider all block/io entry points of offset/bytes:
4 bytes/offset interface functions: bdrv_co_preadv_part(),
bdrv_co_pwritev_part(), bdrv_co_copy_range_internal() and
bdrv_co_pdiscard() and we check them all with bdrv_check_request().
We also have one entry point with only offset: bdrv_co_truncate().
Check the offset.
And one public structure: BdrvTrackedRequest. Happily, it has only
three external users:
file-posix.c: adopted by this patch
write-threshold.c: only read fields
test-write-threshold.c: sets obviously small constant values
Better is to make the structure private and add corresponding
interfaces.. Still it's not obvious what kind of interface is needed
for file-posix.c. Let's keep it public but add corresponding
assertions.
After this patch we'll convert functions in block/io.c to int64_t bytes
and offset parameters. We can assume that offset/bytes pair always
satisfy new restrictions, and make
corresponding assertions where needed. If we reach some offset/bytes
point in block/io.c missing bdrv_check_request() it is considered a
bug. As well, if block/io.c modifies a offset/bytes request, expanding
it more then aligning up to request_alignment, it's a bug too.
For all io requests except for discard we keep for now old restriction
of 32bit request length.
iotest 206 output error message changed, as now test disk size is
larger than new limit. Add one more test case with new maximum disk
size to cover too-big-L1 case.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201203222713.13507-5-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-12-04 01:27:13 +03:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-12-11 21:39:25 +03:00
|
|
|
int bdrv_check_request(int64_t offset, int64_t bytes, Error **errp)
|
|
|
|
{
|
|
|
|
return bdrv_check_qiov_request(offset, bytes, NULL, 0, errp);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int bdrv_check_request32(int64_t offset, int64_t bytes,
|
|
|
|
QEMUIOVector *qiov, size_t qiov_offset)
|
block: introduce BDRV_MAX_LENGTH
We are going to modify block layer to work with 64bit requests. And
first step is moving to int64_t type for both offset and bytes
arguments in all block request related functions.
It's mostly safe (when widening signed or unsigned int to int64_t), but
switching from uint64_t is questionable.
So, let's first establish the set of requests we want to work with.
First signed int64_t should be enough, as off_t is signed anyway. Then,
obviously offset + bytes should not overflow.
And most interesting: (offset + bytes) being aligned up should not
overflow as well. Aligned to what alignment? First thing that comes in
mind is bs->bl.request_alignment, as we align up request to this
alignment. But there is another thing: look at
bdrv_mark_request_serialising(). It aligns request up to some given
alignment. And this parameter may be bdrv_get_cluster_size(), which is
often a lot greater than bs->bl.request_alignment.
Note also, that bdrv_mark_request_serialising() uses signed int64_t for
calculations. So, actually, we already depend on some restrictions.
Happily, bdrv_get_cluster_size() returns int and
bs->bl.request_alignment has 32bit unsigned type, but defined to be a
power of 2 less than INT_MAX. So, we may establish, that INT_MAX is
absolute maximum for any kind of alignment that may occur with the
request.
Note, that bdrv_get_cluster_size() is not documented to return power
of 2, still bdrv_mark_request_serialising() behaves like it is.
Also, backup uses bdi.cluster_size and is not prepared to it not being
power of 2.
So, let's establish that Qemu supports only power-of-2 clusters and
alignments.
So, alignment can't be greater than 2^30.
Finally to be safe with calculations, to not calculate different
maximums for different nodes (depending on cluster size and
request_alignment), let's simply set QEMU_ALIGN_DOWN(INT64_MAX, 2^30)
as absolute maximum bytes length for Qemu. Actually, it's not much less
than INT64_MAX.
OK, then, let's apply it to block/io.
Let's consider all block/io entry points of offset/bytes:
4 bytes/offset interface functions: bdrv_co_preadv_part(),
bdrv_co_pwritev_part(), bdrv_co_copy_range_internal() and
bdrv_co_pdiscard() and we check them all with bdrv_check_request().
We also have one entry point with only offset: bdrv_co_truncate().
Check the offset.
And one public structure: BdrvTrackedRequest. Happily, it has only
three external users:
file-posix.c: adopted by this patch
write-threshold.c: only read fields
test-write-threshold.c: sets obviously small constant values
Better is to make the structure private and add corresponding
interfaces.. Still it's not obvious what kind of interface is needed
for file-posix.c. Let's keep it public but add corresponding
assertions.
After this patch we'll convert functions in block/io.c to int64_t bytes
and offset parameters. We can assume that offset/bytes pair always
satisfy new restrictions, and make
corresponding assertions where needed. If we reach some offset/bytes
point in block/io.c missing bdrv_check_request() it is considered a
bug. As well, if block/io.c modifies a offset/bytes request, expanding
it more then aligning up to request_alignment, it's a bug too.
For all io requests except for discard we keep for now old restriction
of 32bit request length.
iotest 206 output error message changed, as now test disk size is
larger than new limit. Add one more test case with new maximum disk
size to cover too-big-L1 case.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201203222713.13507-5-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-12-04 01:27:13 +03:00
|
|
|
{
|
2020-12-11 21:39:25 +03:00
|
|
|
int ret = bdrv_check_qiov_request(offset, bytes, qiov, qiov_offset, NULL);
|
block: introduce BDRV_MAX_LENGTH
We are going to modify block layer to work with 64bit requests. And
first step is moving to int64_t type for both offset and bytes
arguments in all block request related functions.
It's mostly safe (when widening signed or unsigned int to int64_t), but
switching from uint64_t is questionable.
So, let's first establish the set of requests we want to work with.
First signed int64_t should be enough, as off_t is signed anyway. Then,
obviously offset + bytes should not overflow.
And most interesting: (offset + bytes) being aligned up should not
overflow as well. Aligned to what alignment? First thing that comes in
mind is bs->bl.request_alignment, as we align up request to this
alignment. But there is another thing: look at
bdrv_mark_request_serialising(). It aligns request up to some given
alignment. And this parameter may be bdrv_get_cluster_size(), which is
often a lot greater than bs->bl.request_alignment.
Note also, that bdrv_mark_request_serialising() uses signed int64_t for
calculations. So, actually, we already depend on some restrictions.
Happily, bdrv_get_cluster_size() returns int and
bs->bl.request_alignment has 32bit unsigned type, but defined to be a
power of 2 less than INT_MAX. So, we may establish, that INT_MAX is
absolute maximum for any kind of alignment that may occur with the
request.
Note, that bdrv_get_cluster_size() is not documented to return power
of 2, still bdrv_mark_request_serialising() behaves like it is.
Also, backup uses bdi.cluster_size and is not prepared to it not being
power of 2.
So, let's establish that Qemu supports only power-of-2 clusters and
alignments.
So, alignment can't be greater than 2^30.
Finally to be safe with calculations, to not calculate different
maximums for different nodes (depending on cluster size and
request_alignment), let's simply set QEMU_ALIGN_DOWN(INT64_MAX, 2^30)
as absolute maximum bytes length for Qemu. Actually, it's not much less
than INT64_MAX.
OK, then, let's apply it to block/io.
Let's consider all block/io entry points of offset/bytes:
4 bytes/offset interface functions: bdrv_co_preadv_part(),
bdrv_co_pwritev_part(), bdrv_co_copy_range_internal() and
bdrv_co_pdiscard() and we check them all with bdrv_check_request().
We also have one entry point with only offset: bdrv_co_truncate().
Check the offset.
And one public structure: BdrvTrackedRequest. Happily, it has only
three external users:
file-posix.c: adopted by this patch
write-threshold.c: only read fields
test-write-threshold.c: sets obviously small constant values
Better is to make the structure private and add corresponding
interfaces.. Still it's not obvious what kind of interface is needed
for file-posix.c. Let's keep it public but add corresponding
assertions.
After this patch we'll convert functions in block/io.c to int64_t bytes
and offset parameters. We can assume that offset/bytes pair always
satisfy new restrictions, and make
corresponding assertions where needed. If we reach some offset/bytes
point in block/io.c missing bdrv_check_request() it is considered a
bug. As well, if block/io.c modifies a offset/bytes request, expanding
it more then aligning up to request_alignment, it's a bug too.
For all io requests except for discard we keep for now old restriction
of 32bit request length.
iotest 206 output error message changed, as now test disk size is
larger than new limit. Add one more test case with new maximum disk
size to cover too-big-L1 case.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201203222713.13507-5-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-12-04 01:27:13 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (bytes > BDRV_REQUEST_MAX_BYTES) {
|
2015-04-28 16:27:52 +03:00
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2016-06-02 00:10:04 +03:00
|
|
|
* Completely zero out a block device with the help of bdrv_pwrite_zeroes.
|
2015-04-28 16:27:52 +03:00
|
|
|
* The operation is sped up by checking the block status and only writing
|
|
|
|
* zeroes to the device if they currently do not return zeroes. Optional
|
2016-06-02 00:10:04 +03:00
|
|
|
* flags are passed through to bdrv_pwrite_zeroes (e.g. BDRV_REQ_MAY_UNMAP,
|
block: Honor BDRV_REQ_FUA during write_zeroes
The block layer has a couple of cases where it can lose
Force Unit Access semantics when writing a large block of
zeroes, such that the request returns before the zeroes
have been guaranteed to land on underlying media.
SCSI does not support FUA during WRITESAME(10/16); FUA is only
supported if it falls back to WRITE(10/16). But where the
underlying device is new enough to not need a fallback, it
means that any upper layer request with FUA semantics was
silently ignoring BDRV_REQ_FUA.
Conversely, NBD has situations where it can support FUA but not
ZERO_WRITE; when that happens, the generic block layer fallback
to bdrv_driver_pwritev() (or the older bdrv_co_writev() in qemu
2.6) was losing the FUA flag.
The problem of losing flags unrelated to ZERO_WRITE has been
latent in bdrv_co_do_write_zeroes() since commit aa7bfbff, but
back then, it did not matter because there was no FUA flag. It
became observable when commit 93f5e6d8 paved the way for flags
that can impact correctness, when we should have been using
bdrv_co_writev_flags() with modified flags. Compare to commit
9eeb6dd, which got flag manipulation right in
bdrv_co_do_zero_pwritev().
Symptoms: I tested with qemu-io with default writethrough cache
(which is supposed to use FUA semantics on every write), and
targetted an NBD client connected to a server that intentionally
did not advertise NBD_FLAG_SEND_FUA. When doing 'write 0 512',
the NBD client sent two operations (NBD_CMD_WRITE then
NBD_CMD_FLUSH) to get the fallback FUA semantics; but when doing
'write -z 0 512', the NBD client sent only NBD_CMD_WRITE.
The fix is do to a cleanup bdrv_co_flush() at the end of the
operation if any step in the middle relied on a BDS that does
not natively support FUA for that step (note that we don't
need to flush after every operation, if the operation is broken
into chunks based on bounce-buffer sizing). Each BDS gains a
new flag .supported_zero_flags, which parallels the use of
.supported_write_flags but only when accessing a zero write
operation (the flags MUST be different, because of SCSI having
different semantics based on WRITE vs. WRITESAME; and also
because BDRV_REQ_MAY_UNMAP only makes sense on zero writes).
Also fix some documentation to describe -ENOTSUP semantics,
particularly since iscsi depends on those semantics.
Down the road, we may want to add a driver where its
.bdrv_co_pwritev() honors all three of BDRV_REQ_FUA,
BDRV_REQ_ZERO_WRITE, and BDRV_REQ_MAY_UNMAP, and advertise
this via bs->supported_write_flags for blocks opened by that
driver; such a driver should NOT supply .bdrv_co_write_zeroes
nor .supported_zero_flags. But none of the drivers touched
in this patch want to do that (the act of writing zeroes is
different enough from normal writes to deserve a second
callback).
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2016-05-04 01:39:07 +03:00
|
|
|
* BDRV_REQ_FUA).
|
2015-04-28 16:27:52 +03:00
|
|
|
*
|
2020-04-29 00:38:07 +03:00
|
|
|
* Returns < 0 on error, 0 on success. For error codes see bdrv_pwrite().
|
2015-04-28 16:27:52 +03:00
|
|
|
*/
|
2016-06-16 16:13:15 +03:00
|
|
|
int bdrv_make_zero(BdrvChild *child, BdrvRequestFlags flags)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
block: Convert bdrv_get_block_status() to bytes
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end of an unaligned file that can do byte-based access.
Changing the name of the function from bdrv_get_block_status() to
bdrv_block_status() ensures that the compiler enforces that all
callers are updated. For now, the io.c layer still assert()s that
all callers are sector-aligned, but that can be relaxed when a later
patch implements byte-based block status in the drivers.
There was an inherent limitation in returning the offset via the
return value: we only have room for BDRV_BLOCK_OFFSET_MASK bits, which
means an offset can only be mapped for sector-aligned queries (or,
if we declare that non-aligned input is at the same relative position
modulo 512 of the answer), so the new interface also changes things to
return the offset via output through a parameter by reference rather
than mashed into the return value. We'll have some glue code that
munges between the two styles until we finish converting all uses.
For the most part this patch is just the addition of scaling at the
callers followed by inverse scaling at bdrv_block_status(), coupled
with the tweak in calling convention. But some code, particularly
bdrv_is_allocated(), gets a lot simpler because it no longer has to
mess with sectors.
For ease of review, bdrv_get_block_status_above() will be tackled
separately.
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:03 +03:00
|
|
|
int ret;
|
|
|
|
int64_t target_size, bytes, offset = 0;
|
2016-06-16 16:13:15 +03:00
|
|
|
BlockDriverState *bs = child->bs;
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2017-10-12 06:47:01 +03:00
|
|
|
target_size = bdrv_getlength(bs);
|
|
|
|
if (target_size < 0) {
|
|
|
|
return target_size;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
for (;;) {
|
2017-10-12 06:47:01 +03:00
|
|
|
bytes = MIN(target_size - offset, BDRV_REQUEST_MAX_BYTES);
|
|
|
|
if (bytes <= 0) {
|
2015-04-28 16:27:52 +03:00
|
|
|
return 0;
|
|
|
|
}
|
block: Convert bdrv_get_block_status() to bytes
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end of an unaligned file that can do byte-based access.
Changing the name of the function from bdrv_get_block_status() to
bdrv_block_status() ensures that the compiler enforces that all
callers are updated. For now, the io.c layer still assert()s that
all callers are sector-aligned, but that can be relaxed when a later
patch implements byte-based block status in the drivers.
There was an inherent limitation in returning the offset via the
return value: we only have room for BDRV_BLOCK_OFFSET_MASK bits, which
means an offset can only be mapped for sector-aligned queries (or,
if we declare that non-aligned input is at the same relative position
modulo 512 of the answer), so the new interface also changes things to
return the offset via output through a parameter by reference rather
than mashed into the return value. We'll have some glue code that
munges between the two styles until we finish converting all uses.
For the most part this patch is just the addition of scaling at the
callers followed by inverse scaling at bdrv_block_status(), coupled
with the tweak in calling convention. But some code, particularly
bdrv_is_allocated(), gets a lot simpler because it no longer has to
mess with sectors.
For ease of review, bdrv_get_block_status_above() will be tackled
separately.
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:03 +03:00
|
|
|
ret = bdrv_block_status(bs, offset, bytes, &bytes, NULL, NULL);
|
2015-04-28 16:27:52 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
if (ret & BDRV_BLOCK_ZERO) {
|
block: Convert bdrv_get_block_status() to bytes
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end of an unaligned file that can do byte-based access.
Changing the name of the function from bdrv_get_block_status() to
bdrv_block_status() ensures that the compiler enforces that all
callers are updated. For now, the io.c layer still assert()s that
all callers are sector-aligned, but that can be relaxed when a later
patch implements byte-based block status in the drivers.
There was an inherent limitation in returning the offset via the
return value: we only have room for BDRV_BLOCK_OFFSET_MASK bits, which
means an offset can only be mapped for sector-aligned queries (or,
if we declare that non-aligned input is at the same relative position
modulo 512 of the answer), so the new interface also changes things to
return the offset via output through a parameter by reference rather
than mashed into the return value. We'll have some glue code that
munges between the two styles until we finish converting all uses.
For the most part this patch is just the addition of scaling at the
callers followed by inverse scaling at bdrv_block_status(), coupled
with the tweak in calling convention. But some code, particularly
bdrv_is_allocated(), gets a lot simpler because it no longer has to
mess with sectors.
For ease of review, bdrv_get_block_status_above() will be tackled
separately.
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:03 +03:00
|
|
|
offset += bytes;
|
2015-04-28 16:27:52 +03:00
|
|
|
continue;
|
|
|
|
}
|
block: Convert bdrv_get_block_status() to bytes
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end of an unaligned file that can do byte-based access.
Changing the name of the function from bdrv_get_block_status() to
bdrv_block_status() ensures that the compiler enforces that all
callers are updated. For now, the io.c layer still assert()s that
all callers are sector-aligned, but that can be relaxed when a later
patch implements byte-based block status in the drivers.
There was an inherent limitation in returning the offset via the
return value: we only have room for BDRV_BLOCK_OFFSET_MASK bits, which
means an offset can only be mapped for sector-aligned queries (or,
if we declare that non-aligned input is at the same relative position
modulo 512 of the answer), so the new interface also changes things to
return the offset via output through a parameter by reference rather
than mashed into the return value. We'll have some glue code that
munges between the two styles until we finish converting all uses.
For the most part this patch is just the addition of scaling at the
callers followed by inverse scaling at bdrv_block_status(), coupled
with the tweak in calling convention. But some code, particularly
bdrv_is_allocated(), gets a lot simpler because it no longer has to
mess with sectors.
For ease of review, bdrv_get_block_status_above() will be tackled
separately.
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:03 +03:00
|
|
|
ret = bdrv_pwrite_zeroes(child, offset, bytes, flags);
|
2015-04-28 16:27:52 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
block: Convert bdrv_get_block_status() to bytes
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end of an unaligned file that can do byte-based access.
Changing the name of the function from bdrv_get_block_status() to
bdrv_block_status() ensures that the compiler enforces that all
callers are updated. For now, the io.c layer still assert()s that
all callers are sector-aligned, but that can be relaxed when a later
patch implements byte-based block status in the drivers.
There was an inherent limitation in returning the offset via the
return value: we only have room for BDRV_BLOCK_OFFSET_MASK bits, which
means an offset can only be mapped for sector-aligned queries (or,
if we declare that non-aligned input is at the same relative position
modulo 512 of the answer), so the new interface also changes things to
return the offset via output through a parameter by reference rather
than mashed into the return value. We'll have some glue code that
munges between the two styles until we finish converting all uses.
For the most part this patch is just the addition of scaling at the
callers followed by inverse scaling at bdrv_block_status(), coupled
with the tweak in calling convention. But some code, particularly
bdrv_is_allocated(), gets a lot simpler because it no longer has to
mess with sectors.
For ease of review, bdrv_get_block_status_above() will be tackled
separately.
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:03 +03:00
|
|
|
offset += bytes;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Writes to the file and ensures that no writes are reordered across this
|
|
|
|
* request (acts as a barrier)
|
|
|
|
*
|
|
|
|
* Returns 0 on success, -errno in error cases.
|
|
|
|
*/
|
2022-06-09 18:27:42 +03:00
|
|
|
int coroutine_fn bdrv_co_pwrite_sync(BdrvChild *child, int64_t offset,
|
|
|
|
int64_t bytes, const void *buf,
|
|
|
|
BdrvRequestFlags flags)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
|
|
|
int ret;
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2023-02-03 18:21:51 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2023-02-03 18:21:46 +03:00
|
|
|
|
2022-06-09 18:27:42 +03:00
|
|
|
ret = bdrv_co_pwrite(child, offset, bytes, buf, flags);
|
2015-04-28 16:27:52 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2022-06-09 18:27:42 +03:00
|
|
|
ret = bdrv_co_flush(child->bs);
|
2016-03-04 16:16:51 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-04-25 15:13:12 +03:00
|
|
|
typedef struct CoroutineIOCompletion {
|
|
|
|
Coroutine *coroutine;
|
|
|
|
int ret;
|
|
|
|
} CoroutineIOCompletion;
|
|
|
|
|
|
|
|
static void bdrv_co_io_em_complete(void *opaque, int ret)
|
|
|
|
{
|
|
|
|
CoroutineIOCompletion *co = opaque;
|
|
|
|
|
|
|
|
co->ret = ret;
|
2017-02-13 16:52:32 +03:00
|
|
|
aio_co_wake(co->coroutine);
|
2016-04-25 15:13:12 +03:00
|
|
|
}
|
|
|
|
|
2023-02-03 18:21:49 +03:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
bdrv_driver_preadv(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
|
|
|
QEMUIOVector *qiov, size_t qiov_offset, int flags)
|
2016-04-25 12:46:41 +03:00
|
|
|
{
|
|
|
|
BlockDriver *drv = bs->drv;
|
2016-04-25 12:25:18 +03:00
|
|
|
int64_t sector_num;
|
|
|
|
unsigned int nb_sectors;
|
2019-06-04 19:15:06 +03:00
|
|
|
QEMUIOVector local_qiov;
|
|
|
|
int ret;
|
2023-02-03 18:21:50 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2016-04-25 12:25:18 +03:00
|
|
|
|
2020-12-11 21:39:27 +03:00
|
|
|
bdrv_check_qiov_request(offset, bytes, qiov, qiov_offset, &error_abort);
|
2022-10-13 21:59:01 +03:00
|
|
|
assert(!(flags & ~bs->supported_read_flags));
|
2016-06-13 21:56:35 +03:00
|
|
|
|
2017-11-10 23:31:09 +03:00
|
|
|
if (!drv) {
|
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
|
2019-06-04 19:15:06 +03:00
|
|
|
if (drv->bdrv_co_preadv_part) {
|
|
|
|
return drv->bdrv_co_preadv_part(bs, offset, bytes, qiov, qiov_offset,
|
|
|
|
flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (qiov_offset > 0 || bytes != qiov->size) {
|
|
|
|
qemu_iovec_init_slice(&local_qiov, qiov, qiov_offset, bytes);
|
|
|
|
qiov = &local_qiov;
|
|
|
|
}
|
|
|
|
|
2016-04-25 12:25:18 +03:00
|
|
|
if (drv->bdrv_co_preadv) {
|
2019-06-04 19:15:06 +03:00
|
|
|
ret = drv->bdrv_co_preadv(bs, offset, bytes, qiov, flags);
|
|
|
|
goto out;
|
2016-04-25 12:25:18 +03:00
|
|
|
}
|
|
|
|
|
2018-04-24 22:25:06 +03:00
|
|
|
if (drv->bdrv_aio_preadv) {
|
2016-04-25 15:13:12 +03:00
|
|
|
BlockAIOCB *acb;
|
|
|
|
CoroutineIOCompletion co = {
|
|
|
|
.coroutine = qemu_coroutine_self(),
|
|
|
|
};
|
|
|
|
|
2018-04-24 22:25:06 +03:00
|
|
|
acb = drv->bdrv_aio_preadv(bs, offset, bytes, qiov, flags,
|
|
|
|
bdrv_co_io_em_complete, &co);
|
2016-04-25 15:13:12 +03:00
|
|
|
if (acb == NULL) {
|
2019-06-04 19:15:06 +03:00
|
|
|
ret = -EIO;
|
|
|
|
goto out;
|
2016-04-25 15:13:12 +03:00
|
|
|
} else {
|
|
|
|
qemu_coroutine_yield();
|
2019-06-04 19:15:06 +03:00
|
|
|
ret = co.ret;
|
|
|
|
goto out;
|
2016-04-25 15:13:12 +03:00
|
|
|
}
|
|
|
|
}
|
2018-04-24 22:25:06 +03:00
|
|
|
|
|
|
|
sector_num = offset >> BDRV_SECTOR_BITS;
|
|
|
|
nb_sectors = bytes >> BDRV_SECTOR_BITS;
|
|
|
|
|
2019-08-27 21:59:12 +03:00
|
|
|
assert(QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE));
|
|
|
|
assert(QEMU_IS_ALIGNED(bytes, BDRV_SECTOR_SIZE));
|
2019-05-14 16:57:35 +03:00
|
|
|
assert(bytes <= BDRV_REQUEST_MAX_BYTES);
|
2018-04-24 22:25:06 +03:00
|
|
|
assert(drv->bdrv_co_readv);
|
|
|
|
|
2019-06-04 19:15:06 +03:00
|
|
|
ret = drv->bdrv_co_readv(bs, sector_num, nb_sectors, qiov);
|
|
|
|
|
|
|
|
out:
|
|
|
|
if (qiov == &local_qiov) {
|
|
|
|
qemu_iovec_destroy(&local_qiov);
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
2016-04-25 12:46:41 +03:00
|
|
|
}
|
|
|
|
|
2023-02-03 18:21:49 +03:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
bdrv_driver_pwritev(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
|
|
|
QEMUIOVector *qiov, size_t qiov_offset,
|
|
|
|
BdrvRequestFlags flags)
|
2016-04-25 13:13:39 +03:00
|
|
|
{
|
|
|
|
BlockDriver *drv = bs->drv;
|
2022-10-13 21:59:01 +03:00
|
|
|
bool emulate_fua = false;
|
2016-04-25 12:25:18 +03:00
|
|
|
int64_t sector_num;
|
|
|
|
unsigned int nb_sectors;
|
2019-06-04 19:15:06 +03:00
|
|
|
QEMUIOVector local_qiov;
|
2016-04-25 13:13:39 +03:00
|
|
|
int ret;
|
2023-02-03 18:21:50 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2016-04-25 13:13:39 +03:00
|
|
|
|
2020-12-11 21:39:27 +03:00
|
|
|
bdrv_check_qiov_request(offset, bytes, qiov, qiov_offset, &error_abort);
|
2016-06-13 21:56:35 +03:00
|
|
|
|
2017-11-10 23:31:09 +03:00
|
|
|
if (!drv) {
|
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
|
2022-10-13 21:59:01 +03:00
|
|
|
if ((flags & BDRV_REQ_FUA) &&
|
|
|
|
(~bs->supported_write_flags & BDRV_REQ_FUA)) {
|
|
|
|
flags &= ~BDRV_REQ_FUA;
|
|
|
|
emulate_fua = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
flags &= bs->supported_write_flags;
|
|
|
|
|
2019-06-04 19:15:06 +03:00
|
|
|
if (drv->bdrv_co_pwritev_part) {
|
|
|
|
ret = drv->bdrv_co_pwritev_part(bs, offset, bytes, qiov, qiov_offset,
|
2022-10-13 21:59:01 +03:00
|
|
|
flags);
|
2019-06-04 19:15:06 +03:00
|
|
|
goto emulate_flags;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (qiov_offset > 0 || bytes != qiov->size) {
|
|
|
|
qemu_iovec_init_slice(&local_qiov, qiov, qiov_offset, bytes);
|
|
|
|
qiov = &local_qiov;
|
|
|
|
}
|
|
|
|
|
2016-04-25 12:25:18 +03:00
|
|
|
if (drv->bdrv_co_pwritev) {
|
2022-10-13 21:59:01 +03:00
|
|
|
ret = drv->bdrv_co_pwritev(bs, offset, bytes, qiov, flags);
|
2016-04-25 12:25:18 +03:00
|
|
|
goto emulate_flags;
|
|
|
|
}
|
|
|
|
|
2018-04-24 22:25:06 +03:00
|
|
|
if (drv->bdrv_aio_pwritev) {
|
2016-04-25 15:13:12 +03:00
|
|
|
BlockAIOCB *acb;
|
|
|
|
CoroutineIOCompletion co = {
|
|
|
|
.coroutine = qemu_coroutine_self(),
|
|
|
|
};
|
|
|
|
|
2022-10-13 21:59:01 +03:00
|
|
|
acb = drv->bdrv_aio_pwritev(bs, offset, bytes, qiov, flags,
|
2018-04-24 22:25:06 +03:00
|
|
|
bdrv_co_io_em_complete, &co);
|
2016-04-25 15:13:12 +03:00
|
|
|
if (acb == NULL) {
|
2016-04-25 12:25:18 +03:00
|
|
|
ret = -EIO;
|
2016-04-25 15:13:12 +03:00
|
|
|
} else {
|
|
|
|
qemu_coroutine_yield();
|
2016-04-25 12:25:18 +03:00
|
|
|
ret = co.ret;
|
2016-04-25 15:13:12 +03:00
|
|
|
}
|
2018-04-24 22:25:06 +03:00
|
|
|
goto emulate_flags;
|
|
|
|
}
|
|
|
|
|
|
|
|
sector_num = offset >> BDRV_SECTOR_BITS;
|
|
|
|
nb_sectors = bytes >> BDRV_SECTOR_BITS;
|
|
|
|
|
2019-08-27 21:59:12 +03:00
|
|
|
assert(QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE));
|
|
|
|
assert(QEMU_IS_ALIGNED(bytes, BDRV_SECTOR_SIZE));
|
2019-05-14 16:57:35 +03:00
|
|
|
assert(bytes <= BDRV_REQUEST_MAX_BYTES);
|
2018-04-24 22:25:06 +03:00
|
|
|
|
2018-04-25 01:01:57 +03:00
|
|
|
assert(drv->bdrv_co_writev);
|
2022-10-13 21:59:01 +03:00
|
|
|
ret = drv->bdrv_co_writev(bs, sector_num, nb_sectors, qiov, flags);
|
2016-04-25 13:13:39 +03:00
|
|
|
|
2016-04-25 12:25:18 +03:00
|
|
|
emulate_flags:
|
2022-10-13 21:59:01 +03:00
|
|
|
if (ret == 0 && emulate_fua) {
|
2016-04-25 13:13:39 +03:00
|
|
|
ret = bdrv_co_flush(bs);
|
|
|
|
}
|
|
|
|
|
2019-06-04 19:15:06 +03:00
|
|
|
if (qiov == &local_qiov) {
|
|
|
|
qemu_iovec_destroy(&local_qiov);
|
|
|
|
}
|
|
|
|
|
2016-04-25 13:13:39 +03:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2023-02-03 18:21:49 +03:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
2020-12-11 21:39:27 +03:00
|
|
|
bdrv_driver_pwritev_compressed(BlockDriverState *bs, int64_t offset,
|
|
|
|
int64_t bytes, QEMUIOVector *qiov,
|
2019-06-04 19:15:06 +03:00
|
|
|
size_t qiov_offset)
|
2016-07-22 11:17:42 +03:00
|
|
|
{
|
|
|
|
BlockDriver *drv = bs->drv;
|
2019-06-04 19:15:06 +03:00
|
|
|
QEMUIOVector local_qiov;
|
|
|
|
int ret;
|
2023-02-03 18:21:50 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2016-07-22 11:17:42 +03:00
|
|
|
|
2020-12-11 21:39:27 +03:00
|
|
|
bdrv_check_qiov_request(offset, bytes, qiov, qiov_offset, &error_abort);
|
|
|
|
|
2017-11-10 23:31:09 +03:00
|
|
|
if (!drv) {
|
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
|
2019-06-04 19:15:06 +03:00
|
|
|
if (!block_driver_can_compress(drv)) {
|
2016-07-22 11:17:42 +03:00
|
|
|
return -ENOTSUP;
|
|
|
|
}
|
|
|
|
|
2019-06-04 19:15:06 +03:00
|
|
|
if (drv->bdrv_co_pwritev_compressed_part) {
|
|
|
|
return drv->bdrv_co_pwritev_compressed_part(bs, offset, bytes,
|
|
|
|
qiov, qiov_offset);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (qiov_offset == 0) {
|
|
|
|
return drv->bdrv_co_pwritev_compressed(bs, offset, bytes, qiov);
|
|
|
|
}
|
|
|
|
|
|
|
|
qemu_iovec_init_slice(&local_qiov, qiov, qiov_offset, bytes);
|
|
|
|
ret = drv->bdrv_co_pwritev_compressed(bs, offset, bytes, &local_qiov);
|
|
|
|
qemu_iovec_destroy(&local_qiov);
|
|
|
|
|
|
|
|
return ret;
|
2016-07-22 11:17:42 +03:00
|
|
|
}
|
|
|
|
|
2023-02-03 18:21:49 +03:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
bdrv_co_do_copy_on_readv(BdrvChild *child, int64_t offset, int64_t bytes,
|
|
|
|
QEMUIOVector *qiov, size_t qiov_offset, int flags)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2017-02-09 17:58:43 +03:00
|
|
|
BlockDriverState *bs = child->bs;
|
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
/* Perform I/O through a temporary buffer so that users who scribble over
|
|
|
|
* their read buffer while the operation is in progress do not end up
|
|
|
|
* modifying the image file. This is critical for zero-copy guest I/O
|
|
|
|
* where anything might happen inside guest memory.
|
|
|
|
*/
|
2019-06-04 19:15:08 +03:00
|
|
|
void *bounce_buffer = NULL;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
|
|
|
BlockDriver *drv = bs->drv;
|
2023-07-11 20:25:52 +03:00
|
|
|
int64_t align_offset;
|
|
|
|
int64_t align_bytes;
|
2020-12-11 21:39:30 +03:00
|
|
|
int64_t skip_bytes;
|
2015-04-28 16:27:52 +03:00
|
|
|
int ret;
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
int max_transfer = MIN_NON_ZERO(bs->bl.max_transfer,
|
|
|
|
BDRV_REQUEST_MAX_BYTES);
|
2020-12-11 21:39:30 +03:00
|
|
|
int64_t progress = 0;
|
2019-10-01 20:48:26 +03:00
|
|
|
bool skip_write;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2020-12-11 21:39:30 +03:00
|
|
|
bdrv_check_qiov_request(offset, bytes, qiov, qiov_offset, &error_abort);
|
|
|
|
|
2017-11-10 23:31:09 +03:00
|
|
|
if (!drv) {
|
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
|
2019-10-01 20:48:26 +03:00
|
|
|
/*
|
|
|
|
* Do not write anything when the BDS is inactive. That is not
|
|
|
|
* allowed, and it would not help.
|
|
|
|
*/
|
|
|
|
skip_write = (bs->open_flags & BDRV_O_INACTIVE);
|
|
|
|
|
2017-04-07 13:29:05 +03:00
|
|
|
/* FIXME We cannot require callers to have write permissions when all they
|
|
|
|
* are doing is a read request. If we did things right, write permissions
|
|
|
|
* would be obtained anyway, but internally by the copy-on-read code. As
|
2017-09-28 22:13:25 +03:00
|
|
|
* long as it is implemented here rather than in a separate filter driver,
|
2017-04-07 13:29:05 +03:00
|
|
|
* the copy-on-read code doesn't have its own BdrvChild, however, for which
|
|
|
|
* it could request permissions. Therefore we have to bypass the permission
|
|
|
|
* system for the moment. */
|
|
|
|
// assert(child->perm & (BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE));
|
2017-02-09 18:49:53 +03:00
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
/* Cover entire cluster so no additional backing file I/O is required when
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
* allocating cluster in the image file. Note that this value may exceed
|
|
|
|
* BDRV_REQUEST_MAX_BYTES (even when the original read did not), which
|
|
|
|
* is one reason we loop rather than doing it all at once.
|
2015-04-28 16:27:52 +03:00
|
|
|
*/
|
2023-07-11 20:25:52 +03:00
|
|
|
bdrv_round_to_subclusters(bs, offset, bytes, &align_offset, &align_bytes);
|
|
|
|
skip_bytes = offset - align_offset;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2016-06-02 12:41:52 +03:00
|
|
|
trace_bdrv_co_do_copy_on_readv(bs, offset, bytes,
|
2023-07-11 20:25:52 +03:00
|
|
|
align_offset, align_bytes);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2023-07-11 20:25:52 +03:00
|
|
|
while (align_bytes) {
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
int64_t pnum;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2019-10-01 20:48:26 +03:00
|
|
|
if (skip_write) {
|
|
|
|
ret = 1; /* "already allocated", so nothing will be copied */
|
2023-07-11 20:25:52 +03:00
|
|
|
pnum = MIN(align_bytes, max_transfer);
|
2019-10-01 20:48:26 +03:00
|
|
|
} else {
|
2023-09-04 13:03:06 +03:00
|
|
|
ret = bdrv_co_is_allocated(bs, align_offset,
|
|
|
|
MIN(align_bytes, max_transfer), &pnum);
|
2019-10-01 20:48:26 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
/*
|
|
|
|
* Safe to treat errors in querying allocation as if
|
|
|
|
* unallocated; we'll probably fail again soon on the
|
|
|
|
* read, but at least that will set a decent errno.
|
|
|
|
*/
|
2023-07-11 20:25:52 +03:00
|
|
|
pnum = MIN(align_bytes, max_transfer);
|
2019-10-01 20:48:26 +03:00
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2019-10-01 20:48:26 +03:00
|
|
|
/* Stop at EOF if the image ends in the middle of the cluster */
|
|
|
|
if (ret == 0 && pnum == 0) {
|
|
|
|
assert(progress >= bytes);
|
|
|
|
break;
|
|
|
|
}
|
2018-07-06 19:41:07 +03:00
|
|
|
|
2019-10-01 20:48:26 +03:00
|
|
|
assert(skip_bytes < pnum);
|
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
if (ret <= 0) {
|
2019-06-04 19:15:07 +03:00
|
|
|
QEMUIOVector local_qiov;
|
|
|
|
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
/* Must copy-on-read; use the bounce buffer */
|
2019-02-18 17:09:11 +03:00
|
|
|
pnum = MIN(pnum, MAX_BOUNCE_BUFFER);
|
2019-06-04 19:15:08 +03:00
|
|
|
if (!bounce_buffer) {
|
2023-07-11 20:25:52 +03:00
|
|
|
int64_t max_we_need = MAX(pnum, align_bytes - pnum);
|
2019-06-04 19:15:08 +03:00
|
|
|
int64_t max_allowed = MIN(max_transfer, MAX_BOUNCE_BUFFER);
|
|
|
|
int64_t bounce_buffer_len = MIN(max_we_need, max_allowed);
|
|
|
|
|
|
|
|
bounce_buffer = qemu_try_blockalign(bs, bounce_buffer_len);
|
|
|
|
if (!bounce_buffer) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
}
|
2019-02-18 17:09:11 +03:00
|
|
|
qemu_iovec_init_buf(&local_qiov, bounce_buffer, pnum);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2023-07-11 20:25:52 +03:00
|
|
|
ret = bdrv_driver_preadv(bs, align_offset, pnum,
|
2019-06-04 19:15:06 +03:00
|
|
|
&local_qiov, 0, 0);
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2023-01-13 23:42:11 +03:00
|
|
|
bdrv_co_debug_event(bs, BLKDBG_COR_WRITE);
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
if (drv->bdrv_co_pwrite_zeroes &&
|
|
|
|
buffer_is_zero(bounce_buffer, pnum)) {
|
|
|
|
/* FIXME: Should we (perhaps conditionally) be setting
|
|
|
|
* BDRV_REQ_MAY_UNMAP, if it will allow for a sparser copy
|
|
|
|
* that still correctly reads as zero? */
|
2023-07-11 20:25:52 +03:00
|
|
|
ret = bdrv_co_do_pwrite_zeroes(bs, align_offset, pnum,
|
2018-04-21 16:29:24 +03:00
|
|
|
BDRV_REQ_WRITE_UNCHANGED);
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
} else {
|
|
|
|
/* This does not change the data on the disk, it is not
|
|
|
|
* necessary to flush even in cache=writethrough mode.
|
|
|
|
*/
|
2023-07-11 20:25:52 +03:00
|
|
|
ret = bdrv_driver_pwritev(bs, align_offset, pnum,
|
2019-06-04 19:15:06 +03:00
|
|
|
&local_qiov, 0,
|
2018-04-21 16:29:24 +03:00
|
|
|
BDRV_REQ_WRITE_UNCHANGED);
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (ret < 0) {
|
|
|
|
/* It might be okay to ignore write errors for guest
|
|
|
|
* requests. If this is a deliberate copy-on-read
|
|
|
|
* then we don't want to ignore the error. Simply
|
|
|
|
* report it in all cases.
|
|
|
|
*/
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2019-07-25 13:05:48 +03:00
|
|
|
if (!(flags & BDRV_REQ_PREFETCH)) {
|
2019-06-04 19:15:07 +03:00
|
|
|
qemu_iovec_from_buf(qiov, qiov_offset + progress,
|
|
|
|
bounce_buffer + skip_bytes,
|
2020-03-12 11:19:49 +03:00
|
|
|
MIN(pnum - skip_bytes, bytes - progress));
|
2019-07-25 13:05:48 +03:00
|
|
|
}
|
|
|
|
} else if (!(flags & BDRV_REQ_PREFETCH)) {
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
/* Read directly into the destination */
|
2019-06-04 19:15:07 +03:00
|
|
|
ret = bdrv_driver_preadv(bs, offset + progress,
|
|
|
|
MIN(pnum - skip_bytes, bytes - progress),
|
|
|
|
qiov, qiov_offset + progress, 0);
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-07-11 20:25:52 +03:00
|
|
|
align_offset += pnum;
|
|
|
|
align_bytes -= pnum;
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
progress += pnum - skip_bytes;
|
|
|
|
skip_bytes = 0;
|
|
|
|
}
|
|
|
|
ret = 0;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
|
|
|
err:
|
|
|
|
qemu_vfree(bounce_buffer);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Forwards an already correctly aligned request to the BlockDriver. This
|
2016-07-15 21:31:59 +03:00
|
|
|
* handles copy on read, zeroing after EOF, and fragmentation of large
|
|
|
|
* reads; any other features must be implemented by the caller.
|
2015-04-28 16:27:52 +03:00
|
|
|
*/
|
2023-02-03 18:21:49 +03:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
bdrv_aligned_preadv(BdrvChild *child, BdrvTrackedRequest *req,
|
|
|
|
int64_t offset, int64_t bytes, int64_t align,
|
|
|
|
QEMUIOVector *qiov, size_t qiov_offset, int flags)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2017-02-09 17:58:43 +03:00
|
|
|
BlockDriverState *bs = child->bs;
|
2016-06-01 18:13:47 +03:00
|
|
|
int64_t total_bytes, max_bytes;
|
2016-07-15 21:31:59 +03:00
|
|
|
int ret = 0;
|
2020-12-11 21:39:31 +03:00
|
|
|
int64_t bytes_remaining = bytes;
|
2016-07-15 21:31:59 +03:00
|
|
|
int max_transfer;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2020-12-11 21:39:31 +03:00
|
|
|
bdrv_check_qiov_request(offset, bytes, qiov, qiov_offset, &error_abort);
|
2016-06-03 17:17:28 +03:00
|
|
|
assert(is_power_of_2(align));
|
|
|
|
assert((offset & (align - 1)) == 0);
|
|
|
|
assert((bytes & (align - 1)) == 0);
|
2016-03-21 17:11:42 +03:00
|
|
|
assert((bs->open_flags & BDRV_O_NO_IO) == 0);
|
2016-07-15 21:31:59 +03:00
|
|
|
max_transfer = QEMU_ALIGN_DOWN(MIN_NON_ZERO(bs->bl.max_transfer, INT_MAX),
|
|
|
|
align);
|
2016-06-24 01:37:06 +03:00
|
|
|
|
2022-10-13 21:59:01 +03:00
|
|
|
/*
|
|
|
|
* TODO: We would need a per-BDS .supported_read_flags and
|
2016-06-24 01:37:06 +03:00
|
|
|
* potential fallback support, if we ever implement any read flags
|
|
|
|
* to pass through to drivers. For now, there aren't any
|
2022-10-13 21:59:01 +03:00
|
|
|
* passthrough flags except the BDRV_REQ_REGISTERED_BUF optimization hint.
|
|
|
|
*/
|
|
|
|
assert(!(flags & ~(BDRV_REQ_COPY_ON_READ | BDRV_REQ_PREFETCH |
|
|
|
|
BDRV_REQ_REGISTERED_BUF)));
|
2015-04-28 16:27:52 +03:00
|
|
|
|
|
|
|
/* Handle Copy on Read and associated serialisation */
|
|
|
|
if (flags & BDRV_REQ_COPY_ON_READ) {
|
|
|
|
/* If we touch the same cluster it counts as an overlap. This
|
|
|
|
* guarantees that allocating writes will be serialized and not race
|
|
|
|
* with each other for the same cluster. For example, in copy-on-read
|
|
|
|
* it ensures that the CoR read and write operations are atomic and
|
|
|
|
* guest writes cannot interleave between them. */
|
2020-10-21 17:58:43 +03:00
|
|
|
bdrv_make_request_serialising(req, bdrv_get_cluster_size(bs));
|
2020-01-08 17:55:55 +03:00
|
|
|
} else {
|
|
|
|
bdrv_wait_serialising_requests(req);
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (flags & BDRV_REQ_COPY_ON_READ) {
|
block: Make bdrv_is_allocated() byte-based
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end of an unaligned file that can do byte-based access.
Changing the signature of the function to use int64_t *pnum ensures
that the compiler enforces that all callers are updated. For now,
the io.c layer still assert()s that all callers are sector-aligned
on input and that *pnum is sector-aligned on return to the caller,
but that can be relaxed when a later patch implements byte-based
block status. Therefore, this code adds usages like
DIV_ROUND_UP(,BDRV_SECTOR_SIZE) to callers that still want aligned
values, where the call might reasonbly give non-aligned results
in the future; on the other hand, no rounding is needed for callers
that should just continue to work with byte alignment.
For the most part this patch is just the addition of scaling at the
callers followed by inverse scaling at bdrv_is_allocated(). But
some code, particularly bdrv_commit(), gets a lot simpler because it
no longer has to mess with sectors; also, it is now possible to pass
NULL if the caller does not care how much of the image is allocated
beyond the initial offset. Leave comments where we can further
simplify once a later patch eliminates the need for sector-aligned
requests through bdrv_is_allocated().
For ease of review, bdrv_is_allocated_above() will be tackled
separately.
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-07-07 15:44:57 +03:00
|
|
|
int64_t pnum;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2020-12-16 09:16:57 +03:00
|
|
|
/* The flag BDRV_REQ_COPY_ON_READ has reached its addressee */
|
|
|
|
flags &= ~BDRV_REQ_COPY_ON_READ;
|
|
|
|
|
2023-09-04 13:03:06 +03:00
|
|
|
ret = bdrv_co_is_allocated(bs, offset, bytes, &pnum);
|
2015-04-28 16:27:52 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2017-10-12 06:47:18 +03:00
|
|
|
if (!ret || pnum != bytes) {
|
2019-06-04 19:15:09 +03:00
|
|
|
ret = bdrv_co_do_copy_on_readv(child, offset, bytes,
|
|
|
|
qiov, qiov_offset, flags);
|
2019-07-25 13:05:48 +03:00
|
|
|
goto out;
|
|
|
|
} else if (flags & BDRV_REQ_PREFETCH) {
|
2015-04-28 16:27:52 +03:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-07-15 21:31:59 +03:00
|
|
|
/* Forward the request to the BlockDriver, possibly fragmenting it */
|
2023-06-01 14:51:44 +03:00
|
|
|
total_bytes = bdrv_co_getlength(bs);
|
2016-06-01 18:13:47 +03:00
|
|
|
if (total_bytes < 0) {
|
|
|
|
ret = total_bytes;
|
|
|
|
goto out;
|
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2022-10-13 21:59:01 +03:00
|
|
|
assert(!(flags & ~(bs->supported_read_flags | BDRV_REQ_REGISTERED_BUF)));
|
2020-12-16 09:16:57 +03:00
|
|
|
|
2016-06-01 18:13:47 +03:00
|
|
|
max_bytes = ROUND_UP(MAX(0, total_bytes - offset), align);
|
2016-07-15 21:31:59 +03:00
|
|
|
if (bytes <= max_bytes && bytes <= max_transfer) {
|
2020-12-16 09:16:57 +03:00
|
|
|
ret = bdrv_driver_preadv(bs, offset, bytes, qiov, qiov_offset, flags);
|
2016-07-15 21:31:59 +03:00
|
|
|
goto out;
|
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2016-07-15 21:31:59 +03:00
|
|
|
while (bytes_remaining) {
|
2020-12-11 21:39:31 +03:00
|
|
|
int64_t num;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2016-07-15 21:31:59 +03:00
|
|
|
if (max_bytes) {
|
|
|
|
num = MIN(bytes_remaining, MIN(max_bytes, max_transfer));
|
|
|
|
assert(num);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2016-07-15 21:31:59 +03:00
|
|
|
ret = bdrv_driver_preadv(bs, offset + bytes - bytes_remaining,
|
2020-07-28 15:08:04 +03:00
|
|
|
num, qiov,
|
2020-12-16 09:16:57 +03:00
|
|
|
qiov_offset + bytes - bytes_remaining,
|
|
|
|
flags);
|
2016-07-15 21:31:59 +03:00
|
|
|
max_bytes -= num;
|
|
|
|
} else {
|
|
|
|
num = bytes_remaining;
|
2020-07-28 15:08:04 +03:00
|
|
|
ret = qemu_iovec_memset(qiov, qiov_offset + bytes - bytes_remaining,
|
|
|
|
0, bytes_remaining);
|
2016-07-15 21:31:59 +03:00
|
|
|
}
|
|
|
|
if (ret < 0) {
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
bytes_remaining -= num;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
out:
|
2016-07-15 21:31:59 +03:00
|
|
|
return ret < 0 ? ret : 0;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2019-06-04 19:15:05 +03:00
|
|
|
* Request padding
|
|
|
|
*
|
|
|
|
* |<---- align ----->| |<----- align ---->|
|
|
|
|
* |<- head ->|<------------- bytes ------------->|<-- tail -->|
|
|
|
|
* | | | | | |
|
|
|
|
* -*----------$-------*-------- ... --------*-----$------------*---
|
|
|
|
* | | | | | |
|
|
|
|
* | offset | | end |
|
|
|
|
* ALIGN_DOWN(offset) ALIGN_UP(offset) ALIGN_DOWN(end) ALIGN_UP(end)
|
|
|
|
* [buf ... ) [tail_buf )
|
|
|
|
*
|
|
|
|
* @buf is an aligned allocation needed to store @head and @tail paddings. @head
|
|
|
|
* is placed at the beginning of @buf and @tail at the @end.
|
|
|
|
*
|
|
|
|
* @tail_buf is a pointer to sub-buffer, corresponding to align-sized chunk
|
|
|
|
* around tail, if tail exists.
|
|
|
|
*
|
|
|
|
* @merge_reads is true for small requests,
|
|
|
|
* if @buf_len == @head + bytes + @tail. In this case it is possible that both
|
|
|
|
* head and tail exist but @buf_len == align and @tail_buf == @buf.
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
*
|
|
|
|
* @write is true for write requests, false for read requests.
|
|
|
|
*
|
|
|
|
* If padding makes the vector too long (exceeding IOV_MAX), then we need to
|
|
|
|
* merge existing vector elements into a single one. @collapse_bounce_buf acts
|
|
|
|
* as the bounce buffer in such cases. @pre_collapse_qiov has the pre-collapse
|
|
|
|
* I/O vector elements so for read requests, the data can be copied back after
|
|
|
|
* the read is done.
|
2019-06-04 19:15:05 +03:00
|
|
|
*/
|
|
|
|
typedef struct BdrvRequestPadding {
|
|
|
|
uint8_t *buf;
|
|
|
|
size_t buf_len;
|
|
|
|
uint8_t *tail_buf;
|
|
|
|
size_t head;
|
|
|
|
size_t tail;
|
|
|
|
bool merge_reads;
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
bool write;
|
2019-06-04 19:15:05 +03:00
|
|
|
QEMUIOVector local_qiov;
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
|
|
|
|
uint8_t *collapse_bounce_buf;
|
|
|
|
size_t collapse_len;
|
|
|
|
QEMUIOVector pre_collapse_qiov;
|
2019-06-04 19:15:05 +03:00
|
|
|
} BdrvRequestPadding;
|
|
|
|
|
|
|
|
static bool bdrv_init_padding(BlockDriverState *bs,
|
|
|
|
int64_t offset, int64_t bytes,
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
bool write,
|
2019-06-04 19:15:05 +03:00
|
|
|
BdrvRequestPadding *pad)
|
|
|
|
{
|
2020-12-11 21:39:21 +03:00
|
|
|
int64_t align = bs->bl.request_alignment;
|
|
|
|
int64_t sum;
|
|
|
|
|
|
|
|
bdrv_check_request(offset, bytes, &error_abort);
|
|
|
|
assert(align <= INT_MAX); /* documented in block/block_int.h */
|
|
|
|
assert(align <= SIZE_MAX / 2); /* so we can allocate the buffer */
|
2019-06-04 19:15:05 +03:00
|
|
|
|
|
|
|
memset(pad, 0, sizeof(*pad));
|
|
|
|
|
|
|
|
pad->head = offset & (align - 1);
|
|
|
|
pad->tail = ((offset + bytes) & (align - 1));
|
|
|
|
if (pad->tail) {
|
|
|
|
pad->tail = align - pad->tail;
|
|
|
|
}
|
|
|
|
|
2020-02-06 19:42:45 +03:00
|
|
|
if (!pad->head && !pad->tail) {
|
2019-06-04 19:15:05 +03:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2020-02-06 19:42:45 +03:00
|
|
|
assert(bytes); /* Nothing good in aligning zero-length requests */
|
|
|
|
|
2019-06-04 19:15:05 +03:00
|
|
|
sum = pad->head + bytes + pad->tail;
|
|
|
|
pad->buf_len = (sum > align && pad->head && pad->tail) ? 2 * align : align;
|
|
|
|
pad->buf = qemu_blockalign(bs, pad->buf_len);
|
|
|
|
pad->merge_reads = sum == pad->buf_len;
|
|
|
|
if (pad->tail) {
|
|
|
|
pad->tail_buf = pad->buf + pad->buf_len - align;
|
|
|
|
}
|
|
|
|
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
pad->write = write;
|
|
|
|
|
2019-06-04 19:15:05 +03:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2023-02-03 18:21:49 +03:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
bdrv_padding_rmw_read(BdrvChild *child, BdrvTrackedRequest *req,
|
|
|
|
BdrvRequestPadding *pad, bool zero_middle)
|
2019-06-04 19:15:05 +03:00
|
|
|
{
|
|
|
|
QEMUIOVector local_qiov;
|
|
|
|
BlockDriverState *bs = child->bs;
|
|
|
|
uint64_t align = bs->bl.request_alignment;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
assert(req->serialising && pad->buf);
|
|
|
|
|
|
|
|
if (pad->head || pad->merge_reads) {
|
2020-12-11 21:39:31 +03:00
|
|
|
int64_t bytes = pad->merge_reads ? pad->buf_len : align;
|
2019-06-04 19:15:05 +03:00
|
|
|
|
|
|
|
qemu_iovec_init_buf(&local_qiov, pad->buf, bytes);
|
|
|
|
|
|
|
|
if (pad->head) {
|
2023-01-13 23:42:11 +03:00
|
|
|
bdrv_co_debug_event(bs, BLKDBG_PWRITEV_RMW_HEAD);
|
2019-06-04 19:15:05 +03:00
|
|
|
}
|
|
|
|
if (pad->merge_reads && pad->tail) {
|
2023-01-13 23:42:11 +03:00
|
|
|
bdrv_co_debug_event(bs, BLKDBG_PWRITEV_RMW_TAIL);
|
2019-06-04 19:15:05 +03:00
|
|
|
}
|
|
|
|
ret = bdrv_aligned_preadv(child, req, req->overlap_offset, bytes,
|
2019-06-04 19:15:09 +03:00
|
|
|
align, &local_qiov, 0, 0);
|
2019-06-04 19:15:05 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
if (pad->head) {
|
2023-01-13 23:42:11 +03:00
|
|
|
bdrv_co_debug_event(bs, BLKDBG_PWRITEV_RMW_AFTER_HEAD);
|
2019-06-04 19:15:05 +03:00
|
|
|
}
|
|
|
|
if (pad->merge_reads && pad->tail) {
|
2023-01-13 23:42:11 +03:00
|
|
|
bdrv_co_debug_event(bs, BLKDBG_PWRITEV_RMW_AFTER_TAIL);
|
2019-06-04 19:15:05 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (pad->merge_reads) {
|
|
|
|
goto zero_mem;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (pad->tail) {
|
|
|
|
qemu_iovec_init_buf(&local_qiov, pad->tail_buf, align);
|
|
|
|
|
2023-01-13 23:42:11 +03:00
|
|
|
bdrv_co_debug_event(bs, BLKDBG_PWRITEV_RMW_TAIL);
|
2019-06-04 19:15:05 +03:00
|
|
|
ret = bdrv_aligned_preadv(
|
|
|
|
child, req,
|
|
|
|
req->overlap_offset + req->overlap_bytes - align,
|
2019-06-04 19:15:09 +03:00
|
|
|
align, align, &local_qiov, 0, 0);
|
2019-06-04 19:15:05 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
2023-01-13 23:42:11 +03:00
|
|
|
bdrv_co_debug_event(bs, BLKDBG_PWRITEV_RMW_AFTER_TAIL);
|
2019-06-04 19:15:05 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
zero_mem:
|
|
|
|
if (zero_middle) {
|
|
|
|
memset(pad->buf + pad->head, 0, pad->buf_len - pad->head - pad->tail);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
/**
|
|
|
|
* Free *pad's associated buffers, and perform any necessary finalization steps.
|
|
|
|
*/
|
|
|
|
static void bdrv_padding_finalize(BdrvRequestPadding *pad)
|
2019-06-04 19:15:05 +03:00
|
|
|
{
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
if (pad->collapse_bounce_buf) {
|
|
|
|
if (!pad->write) {
|
|
|
|
/*
|
|
|
|
* If padding required elements in the vector to be collapsed into a
|
|
|
|
* bounce buffer, copy the bounce buffer content back
|
|
|
|
*/
|
|
|
|
qemu_iovec_from_buf(&pad->pre_collapse_qiov, 0,
|
|
|
|
pad->collapse_bounce_buf, pad->collapse_len);
|
|
|
|
}
|
|
|
|
qemu_vfree(pad->collapse_bounce_buf);
|
|
|
|
qemu_iovec_destroy(&pad->pre_collapse_qiov);
|
|
|
|
}
|
2019-06-04 19:15:05 +03:00
|
|
|
if (pad->buf) {
|
|
|
|
qemu_vfree(pad->buf);
|
|
|
|
qemu_iovec_destroy(&pad->local_qiov);
|
|
|
|
}
|
2020-12-11 21:39:23 +03:00
|
|
|
memset(pad, 0, sizeof(*pad));
|
2019-06-04 19:15:05 +03:00
|
|
|
}
|
|
|
|
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
/*
|
|
|
|
* Create pad->local_qiov by wrapping @iov in the padding head and tail, while
|
|
|
|
* ensuring that the resulting vector will not exceed IOV_MAX elements.
|
|
|
|
*
|
|
|
|
* To ensure this, when necessary, the first two or three elements of @iov are
|
|
|
|
* merged into pad->collapse_bounce_buf and replaced by a reference to that
|
|
|
|
* bounce buffer in pad->local_qiov.
|
|
|
|
*
|
|
|
|
* After performing a read request, the data from the bounce buffer must be
|
|
|
|
* copied back into pad->pre_collapse_qiov (e.g. by bdrv_padding_finalize()).
|
|
|
|
*/
|
|
|
|
static int bdrv_create_padded_qiov(BlockDriverState *bs,
|
|
|
|
BdrvRequestPadding *pad,
|
|
|
|
struct iovec *iov, int niov,
|
|
|
|
size_t iov_offset, size_t bytes)
|
|
|
|
{
|
|
|
|
int padded_niov, surplus_count, collapse_count;
|
|
|
|
|
|
|
|
/* Assert this invariant */
|
|
|
|
assert(niov <= IOV_MAX);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Cannot pad if resulting length would exceed SIZE_MAX. Returning an error
|
|
|
|
* to the guest is not ideal, but there is little else we can do. At least
|
|
|
|
* this will practically never happen on 64-bit systems.
|
|
|
|
*/
|
|
|
|
if (SIZE_MAX - pad->head < bytes ||
|
|
|
|
SIZE_MAX - pad->head - bytes < pad->tail)
|
|
|
|
{
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Length of the resulting IOV if we just concatenated everything */
|
|
|
|
padded_niov = !!pad->head + niov + !!pad->tail;
|
|
|
|
|
|
|
|
qemu_iovec_init(&pad->local_qiov, MIN(padded_niov, IOV_MAX));
|
|
|
|
|
|
|
|
if (pad->head) {
|
|
|
|
qemu_iovec_add(&pad->local_qiov, pad->buf, pad->head);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If padded_niov > IOV_MAX, we cannot just concatenate everything.
|
|
|
|
* Instead, merge the first two or three elements of @iov to reduce the
|
|
|
|
* number of vector elements as necessary.
|
|
|
|
*/
|
|
|
|
if (padded_niov > IOV_MAX) {
|
|
|
|
/*
|
|
|
|
* Only head and tail can have lead to the number of entries exceeding
|
|
|
|
* IOV_MAX, so we can exceed it by the head and tail at most. We need
|
|
|
|
* to reduce the number of elements by `surplus_count`, so we merge that
|
|
|
|
* many elements plus one into one element.
|
|
|
|
*/
|
|
|
|
surplus_count = padded_niov - IOV_MAX;
|
|
|
|
assert(surplus_count <= !!pad->head + !!pad->tail);
|
|
|
|
collapse_count = surplus_count + 1;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Move the elements to collapse into `pad->pre_collapse_qiov`, then
|
|
|
|
* advance `iov` (and associated variables) by those elements.
|
|
|
|
*/
|
|
|
|
qemu_iovec_init(&pad->pre_collapse_qiov, collapse_count);
|
|
|
|
qemu_iovec_concat_iov(&pad->pre_collapse_qiov, iov,
|
|
|
|
collapse_count, iov_offset, SIZE_MAX);
|
|
|
|
iov += collapse_count;
|
|
|
|
iov_offset = 0;
|
|
|
|
niov -= collapse_count;
|
|
|
|
bytes -= pad->pre_collapse_qiov.size;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Construct the bounce buffer to match the length of the to-collapse
|
|
|
|
* vector elements, and for write requests, initialize it with the data
|
|
|
|
* from those elements. Then add it to `pad->local_qiov`.
|
|
|
|
*/
|
|
|
|
pad->collapse_len = pad->pre_collapse_qiov.size;
|
|
|
|
pad->collapse_bounce_buf = qemu_blockalign(bs, pad->collapse_len);
|
|
|
|
if (pad->write) {
|
|
|
|
qemu_iovec_to_buf(&pad->pre_collapse_qiov, 0,
|
|
|
|
pad->collapse_bounce_buf, pad->collapse_len);
|
|
|
|
}
|
|
|
|
qemu_iovec_add(&pad->local_qiov,
|
|
|
|
pad->collapse_bounce_buf, pad->collapse_len);
|
|
|
|
}
|
|
|
|
|
|
|
|
qemu_iovec_concat_iov(&pad->local_qiov, iov, niov, iov_offset, bytes);
|
|
|
|
|
|
|
|
if (pad->tail) {
|
|
|
|
qemu_iovec_add(&pad->local_qiov,
|
|
|
|
pad->buf + pad->buf_len - pad->tail, pad->tail);
|
|
|
|
}
|
|
|
|
|
|
|
|
assert(pad->local_qiov.niov == MIN(padded_niov, IOV_MAX));
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-06-04 19:15:05 +03:00
|
|
|
/*
|
|
|
|
* bdrv_pad_request
|
|
|
|
*
|
|
|
|
* Exchange request parameters with padded request if needed. Don't include RMW
|
|
|
|
* read of padding, bdrv_padding_rmw_read() should be called separately if
|
|
|
|
* needed.
|
|
|
|
*
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
* @write is true for write requests, false for read requests.
|
|
|
|
*
|
2020-12-11 21:39:23 +03:00
|
|
|
* Request parameters (@qiov, &qiov_offset, &offset, &bytes) are in-out:
|
|
|
|
* - on function start they represent original request
|
|
|
|
* - on failure or when padding is not needed they are unchanged
|
|
|
|
* - on success when padding is needed they represent padded request
|
2015-04-28 16:27:52 +03:00
|
|
|
*/
|
2020-12-11 21:39:23 +03:00
|
|
|
static int bdrv_pad_request(BlockDriverState *bs,
|
|
|
|
QEMUIOVector **qiov, size_t *qiov_offset,
|
block/io: support int64_t bytes in bdrv_co_p{read,write}v_part()
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibility for signed return type (where negative value means
error).
So, prepare bdrv_co_preadv_part() and bdrv_co_pwritev_part() and their
remaining dependencies now.
bdrv_pad_request() is updated simultaneously, as pointer to bytes passed
to it both from bdrv_co_pwritev_part() and bdrv_co_preadv_part().
So, all callers of bdrv_pad_request() are updated to pass 64bit bytes.
bdrv_pad_request() is already good for 64bit requests, add
corresponding assertion.
Look at bdrv_co_preadv_part() and bdrv_co_pwritev_part().
Type is widening, so callers are safe. Let's look inside the functions.
In bdrv_co_preadv_part() and bdrv_aligned_pwritev() we only pass bytes
to other already int64_t interfaces (and some obviously safe
calculations), it's OK.
In bdrv_co_do_zero_pwritev() aligned_bytes may become large now, still
it's passed to bdrv_aligned_pwritev which supports int64_t bytes.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201211183934.169161-15-vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
2020-12-11 21:39:32 +03:00
|
|
|
int64_t *offset, int64_t *bytes,
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
bool write,
|
2022-10-13 21:59:01 +03:00
|
|
|
BdrvRequestPadding *pad, bool *padded,
|
|
|
|
BdrvRequestFlags *flags)
|
2019-06-04 19:15:05 +03:00
|
|
|
{
|
2020-12-11 21:39:20 +03:00
|
|
|
int ret;
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
struct iovec *sliced_iov;
|
|
|
|
int sliced_niov;
|
|
|
|
size_t sliced_head, sliced_tail;
|
2020-12-11 21:39:20 +03:00
|
|
|
|
block: Fix pad_request's request restriction
bdrv_pad_request() relies on requests' lengths not to exceed SIZE_MAX,
which bdrv_check_qiov_request() does not guarantee.
bdrv_check_request32() however will guarantee this, and both of
bdrv_pad_request()'s callers (bdrv_co_preadv_part() and
bdrv_co_pwritev_part()) already run it before calling
bdrv_pad_request(). Therefore, bdrv_pad_request() can safely call
bdrv_check_request32() without expecting error, too.
In effect, this patch will not change guest-visible behavior. It is a
clean-up to tighten a condition to match what is guaranteed by our
callers, and which exists purely to show clearly why the subsequent
assertion (`assert(*bytes <= SIZE_MAX)`) is always true.
Note there is a difference between the interfaces of
bdrv_check_qiov_request() and bdrv_check_request32(): The former takes
an errp, the latter does not, so we can no longer just pass
&error_abort. Instead, we need to check the returned value. While we
do expect success (because the callers have already run this function),
an assert(ret == 0) is not much simpler than just to return an error if
it occurs, so let us handle errors by returning them up the stack now.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-id: 20230714085938.202730-1-hreitz@redhat.com
Fixes: 18743311b829cafc1737a5f20bc3248d5f91ee2a
("block: Collapse padded I/O vecs exceeding IOV_MAX")
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2023-07-14 11:59:38 +03:00
|
|
|
/* Should have been checked by the caller already */
|
|
|
|
ret = bdrv_check_request32(*offset, *bytes, *qiov, *qiov_offset);
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
block/io: support int64_t bytes in bdrv_co_p{read,write}v_part()
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibility for signed return type (where negative value means
error).
So, prepare bdrv_co_preadv_part() and bdrv_co_pwritev_part() and their
remaining dependencies now.
bdrv_pad_request() is updated simultaneously, as pointer to bytes passed
to it both from bdrv_co_pwritev_part() and bdrv_co_preadv_part().
So, all callers of bdrv_pad_request() are updated to pass 64bit bytes.
bdrv_pad_request() is already good for 64bit requests, add
corresponding assertion.
Look at bdrv_co_preadv_part() and bdrv_co_pwritev_part().
Type is widening, so callers are safe. Let's look inside the functions.
In bdrv_co_preadv_part() and bdrv_aligned_pwritev() we only pass bytes
to other already int64_t interfaces (and some obviously safe
calculations), it's OK.
In bdrv_co_do_zero_pwritev() aligned_bytes may become large now, still
it's passed to bdrv_aligned_pwritev which supports int64_t bytes.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201211183934.169161-15-vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
2020-12-11 21:39:32 +03:00
|
|
|
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
if (!bdrv_init_padding(bs, *offset, *bytes, write, pad)) {
|
2020-12-11 21:39:23 +03:00
|
|
|
if (padded) {
|
|
|
|
*padded = false;
|
|
|
|
}
|
|
|
|
return 0;
|
2019-06-04 19:15:05 +03:00
|
|
|
}
|
|
|
|
|
block/io: accept NULL qiov in bdrv_pad_request
Some operations, e.g. block-stream, perform reads while discarding the
results (only copy-on-read matters). In this case, they will pass NULL
as the target QEMUIOVector, which will however trip bdrv_pad_request,
since it wants to extend its passed vector. In particular, this is the
case for the blk_co_preadv() call in stream_populate().
If there is no qiov, no operation can be done with it, but the bytes
and offset still need to be updated, so the subsequent aligned read
will actually be aligned and not run into an assertion failure.
In particular, this can happen when the request alignment of the top
node is larger than the allocated part of the bottom node, in which
case padding becomes necessary. For example:
> ./qemu-img create /tmp/backing.qcow2 -f qcow2 64M -o cluster_size=32768
> ./qemu-io -c "write -P42 0x0 0x1" /tmp/backing.qcow2
> ./qemu-img create /tmp/top.qcow2 -f qcow2 64M -b /tmp/backing.qcow2 -F qcow2
> ./qemu-system-x86_64 --qmp stdio \
> --blockdev qcow2,node-name=node0,file.driver=file,file.filename=/tmp/top.qcow2 \
> <<EOF
> {"execute": "qmp_capabilities"}
> {"execute": "blockdev-add", "arguments": { "driver": "compress", "file": "node0", "node-name": "node1" } }
> {"execute": "block-stream", "arguments": { "job-id": "stream0", "device": "node1" } }
> EOF
Originally-by: Stefan Reiter <s.reiter@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
[FE: do update bytes and offset in any case
add reproducer to commit message]
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Message-ID: <20240322095009.346989-2-f.ebner@proxmox.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2024-03-22 12:50:06 +03:00
|
|
|
/*
|
|
|
|
* For prefetching in stream_populate(), no qiov is passed along, because
|
|
|
|
* only copy-on-read matters.
|
|
|
|
*/
|
2024-03-27 22:27:50 +03:00
|
|
|
if (*qiov) {
|
block/io: accept NULL qiov in bdrv_pad_request
Some operations, e.g. block-stream, perform reads while discarding the
results (only copy-on-read matters). In this case, they will pass NULL
as the target QEMUIOVector, which will however trip bdrv_pad_request,
since it wants to extend its passed vector. In particular, this is the
case for the blk_co_preadv() call in stream_populate().
If there is no qiov, no operation can be done with it, but the bytes
and offset still need to be updated, so the subsequent aligned read
will actually be aligned and not run into an assertion failure.
In particular, this can happen when the request alignment of the top
node is larger than the allocated part of the bottom node, in which
case padding becomes necessary. For example:
> ./qemu-img create /tmp/backing.qcow2 -f qcow2 64M -o cluster_size=32768
> ./qemu-io -c "write -P42 0x0 0x1" /tmp/backing.qcow2
> ./qemu-img create /tmp/top.qcow2 -f qcow2 64M -b /tmp/backing.qcow2 -F qcow2
> ./qemu-system-x86_64 --qmp stdio \
> --blockdev qcow2,node-name=node0,file.driver=file,file.filename=/tmp/top.qcow2 \
> <<EOF
> {"execute": "qmp_capabilities"}
> {"execute": "blockdev-add", "arguments": { "driver": "compress", "file": "node0", "node-name": "node1" } }
> {"execute": "block-stream", "arguments": { "job-id": "stream0", "device": "node1" } }
> EOF
Originally-by: Stefan Reiter <s.reiter@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
[FE: do update bytes and offset in any case
add reproducer to commit message]
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Message-ID: <20240322095009.346989-2-f.ebner@proxmox.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2024-03-22 12:50:06 +03:00
|
|
|
sliced_iov = qemu_iovec_slice(*qiov, *qiov_offset, *bytes,
|
|
|
|
&sliced_head, &sliced_tail,
|
|
|
|
&sliced_niov);
|
|
|
|
|
|
|
|
/* Guaranteed by bdrv_check_request32() */
|
|
|
|
assert(*bytes <= SIZE_MAX);
|
|
|
|
ret = bdrv_create_padded_qiov(bs, pad, sliced_iov, sliced_niov,
|
|
|
|
sliced_head, *bytes);
|
|
|
|
if (ret < 0) {
|
|
|
|
bdrv_padding_finalize(pad);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
*qiov = &pad->local_qiov;
|
|
|
|
*qiov_offset = 0;
|
2020-12-11 21:39:23 +03:00
|
|
|
}
|
block/io: accept NULL qiov in bdrv_pad_request
Some operations, e.g. block-stream, perform reads while discarding the
results (only copy-on-read matters). In this case, they will pass NULL
as the target QEMUIOVector, which will however trip bdrv_pad_request,
since it wants to extend its passed vector. In particular, this is the
case for the blk_co_preadv() call in stream_populate().
If there is no qiov, no operation can be done with it, but the bytes
and offset still need to be updated, so the subsequent aligned read
will actually be aligned and not run into an assertion failure.
In particular, this can happen when the request alignment of the top
node is larger than the allocated part of the bottom node, in which
case padding becomes necessary. For example:
> ./qemu-img create /tmp/backing.qcow2 -f qcow2 64M -o cluster_size=32768
> ./qemu-io -c "write -P42 0x0 0x1" /tmp/backing.qcow2
> ./qemu-img create /tmp/top.qcow2 -f qcow2 64M -b /tmp/backing.qcow2 -F qcow2
> ./qemu-system-x86_64 --qmp stdio \
> --blockdev qcow2,node-name=node0,file.driver=file,file.filename=/tmp/top.qcow2 \
> <<EOF
> {"execute": "qmp_capabilities"}
> {"execute": "blockdev-add", "arguments": { "driver": "compress", "file": "node0", "node-name": "node1" } }
> {"execute": "block-stream", "arguments": { "job-id": "stream0", "device": "node1" } }
> EOF
Originally-by: Stefan Reiter <s.reiter@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
[FE: do update bytes and offset in any case
add reproducer to commit message]
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Message-ID: <20240322095009.346989-2-f.ebner@proxmox.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2024-03-22 12:50:06 +03:00
|
|
|
|
2019-06-04 19:15:05 +03:00
|
|
|
*bytes += pad->head + pad->tail;
|
|
|
|
*offset -= pad->head;
|
2020-12-11 21:39:23 +03:00
|
|
|
if (padded) {
|
|
|
|
*padded = true;
|
|
|
|
}
|
2022-10-13 21:59:01 +03:00
|
|
|
if (flags) {
|
|
|
|
/* Can't use optimization hint with bounce buffer */
|
|
|
|
*flags &= ~BDRV_REQ_REGISTERED_BUF;
|
|
|
|
}
|
2019-06-04 19:15:05 +03:00
|
|
|
|
2020-12-11 21:39:23 +03:00
|
|
|
return 0;
|
2019-06-04 19:15:05 +03:00
|
|
|
}
|
|
|
|
|
2016-06-20 22:31:46 +03:00
|
|
|
int coroutine_fn bdrv_co_preadv(BdrvChild *child,
|
2020-12-11 21:39:33 +03:00
|
|
|
int64_t offset, int64_t bytes, QEMUIOVector *qiov,
|
2015-04-28 16:27:52 +03:00
|
|
|
BdrvRequestFlags flags)
|
2019-06-04 19:15:11 +03:00
|
|
|
{
|
2022-03-03 18:15:58 +03:00
|
|
|
IO_CODE();
|
2019-06-04 19:15:11 +03:00
|
|
|
return bdrv_co_preadv_part(child, offset, bytes, qiov, 0, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
int coroutine_fn bdrv_co_preadv_part(BdrvChild *child,
|
block/io: support int64_t bytes in bdrv_co_p{read,write}v_part()
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibility for signed return type (where negative value means
error).
So, prepare bdrv_co_preadv_part() and bdrv_co_pwritev_part() and their
remaining dependencies now.
bdrv_pad_request() is updated simultaneously, as pointer to bytes passed
to it both from bdrv_co_pwritev_part() and bdrv_co_preadv_part().
So, all callers of bdrv_pad_request() are updated to pass 64bit bytes.
bdrv_pad_request() is already good for 64bit requests, add
corresponding assertion.
Look at bdrv_co_preadv_part() and bdrv_co_pwritev_part().
Type is widening, so callers are safe. Let's look inside the functions.
In bdrv_co_preadv_part() and bdrv_aligned_pwritev() we only pass bytes
to other already int64_t interfaces (and some obviously safe
calculations), it's OK.
In bdrv_co_do_zero_pwritev() aligned_bytes may become large now, still
it's passed to bdrv_aligned_pwritev which supports int64_t bytes.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201211183934.169161-15-vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
2020-12-11 21:39:32 +03:00
|
|
|
int64_t offset, int64_t bytes,
|
2019-06-04 19:15:11 +03:00
|
|
|
QEMUIOVector *qiov, size_t qiov_offset,
|
|
|
|
BdrvRequestFlags flags)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2016-06-20 22:31:46 +03:00
|
|
|
BlockDriverState *bs = child->bs;
|
2015-04-28 16:27:52 +03:00
|
|
|
BdrvTrackedRequest req;
|
2019-06-04 19:15:05 +03:00
|
|
|
BdrvRequestPadding pad;
|
2015-04-28 16:27:52 +03:00
|
|
|
int ret;
|
2022-03-03 18:15:58 +03:00
|
|
|
IO_CODE();
|
2015-04-28 16:27:52 +03:00
|
|
|
|
block/io: support int64_t bytes in bdrv_co_p{read,write}v_part()
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibility for signed return type (where negative value means
error).
So, prepare bdrv_co_preadv_part() and bdrv_co_pwritev_part() and their
remaining dependencies now.
bdrv_pad_request() is updated simultaneously, as pointer to bytes passed
to it both from bdrv_co_pwritev_part() and bdrv_co_preadv_part().
So, all callers of bdrv_pad_request() are updated to pass 64bit bytes.
bdrv_pad_request() is already good for 64bit requests, add
corresponding assertion.
Look at bdrv_co_preadv_part() and bdrv_co_pwritev_part().
Type is widening, so callers are safe. Let's look inside the functions.
In bdrv_co_preadv_part() and bdrv_aligned_pwritev() we only pass bytes
to other already int64_t interfaces (and some obviously safe
calculations), it's OK.
In bdrv_co_do_zero_pwritev() aligned_bytes may become large now, still
it's passed to bdrv_aligned_pwritev which supports int64_t bytes.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201211183934.169161-15-vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
2020-12-11 21:39:32 +03:00
|
|
|
trace_bdrv_co_preadv_part(bs, offset, bytes, flags);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2023-01-13 23:42:02 +03:00
|
|
|
if (!bdrv_co_is_inserted(bs)) {
|
2020-12-04 01:27:12 +03:00
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
|
2020-12-11 21:39:25 +03:00
|
|
|
ret = bdrv_check_request32(offset, bytes, qiov, qiov_offset);
|
2015-04-28 16:27:52 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2020-02-06 19:42:45 +03:00
|
|
|
if (bytes == 0 && !QEMU_IS_ALIGNED(offset, bs->bl.request_alignment)) {
|
|
|
|
/*
|
|
|
|
* Aligning zero request is nonsense. Even if driver has special meaning
|
|
|
|
* of zero-length (like qcow2_co_pwritev_compressed_part), we can't pass
|
|
|
|
* it to driver due to request_alignment.
|
|
|
|
*
|
|
|
|
* Still, no reason to return an error if someone do unaligned
|
|
|
|
* zero-length read occasionally.
|
|
|
|
*/
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-10-27 13:48:52 +03:00
|
|
|
bdrv_inc_in_flight(bs);
|
|
|
|
|
2015-09-08 06:28:32 +03:00
|
|
|
/* Don't do copy-on-read if we read data before write operation */
|
2020-09-23 13:56:46 +03:00
|
|
|
if (qatomic_read(&bs->copy_on_read)) {
|
2015-04-28 16:27:52 +03:00
|
|
|
flags |= BDRV_REQ_COPY_ON_READ;
|
|
|
|
}
|
|
|
|
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
ret = bdrv_pad_request(bs, &qiov, &qiov_offset, &offset, &bytes, false,
|
|
|
|
&pad, NULL, &flags);
|
2020-12-11 21:39:23 +03:00
|
|
|
if (ret < 0) {
|
2021-07-27 18:49:23 +03:00
|
|
|
goto fail;
|
2020-12-11 21:39:23 +03:00
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2015-11-09 13:16:46 +03:00
|
|
|
tracked_request_begin(&req, bs, offset, bytes, BDRV_TRACKED_READ);
|
2019-06-04 19:15:05 +03:00
|
|
|
ret = bdrv_aligned_preadv(child, &req, offset, bytes,
|
|
|
|
bs->bl.request_alignment,
|
2019-06-04 19:15:11 +03:00
|
|
|
qiov, qiov_offset, flags);
|
2015-04-28 16:27:52 +03:00
|
|
|
tracked_request_end(&req);
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
bdrv_padding_finalize(&pad);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2021-07-27 18:49:23 +03:00
|
|
|
fail:
|
|
|
|
bdrv_dec_in_flight(bs);
|
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2023-02-03 18:21:52 +03:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
bdrv_co_do_pwrite_zeroes(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
|
|
|
BdrvRequestFlags flags)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
|
|
|
BlockDriver *drv = bs->drv;
|
|
|
|
QEMUIOVector qiov;
|
2019-02-18 17:09:11 +03:00
|
|
|
void *buf = NULL;
|
2015-04-28 16:27:52 +03:00
|
|
|
int ret = 0;
|
block: Honor BDRV_REQ_FUA during write_zeroes
The block layer has a couple of cases where it can lose
Force Unit Access semantics when writing a large block of
zeroes, such that the request returns before the zeroes
have been guaranteed to land on underlying media.
SCSI does not support FUA during WRITESAME(10/16); FUA is only
supported if it falls back to WRITE(10/16). But where the
underlying device is new enough to not need a fallback, it
means that any upper layer request with FUA semantics was
silently ignoring BDRV_REQ_FUA.
Conversely, NBD has situations where it can support FUA but not
ZERO_WRITE; when that happens, the generic block layer fallback
to bdrv_driver_pwritev() (or the older bdrv_co_writev() in qemu
2.6) was losing the FUA flag.
The problem of losing flags unrelated to ZERO_WRITE has been
latent in bdrv_co_do_write_zeroes() since commit aa7bfbff, but
back then, it did not matter because there was no FUA flag. It
became observable when commit 93f5e6d8 paved the way for flags
that can impact correctness, when we should have been using
bdrv_co_writev_flags() with modified flags. Compare to commit
9eeb6dd, which got flag manipulation right in
bdrv_co_do_zero_pwritev().
Symptoms: I tested with qemu-io with default writethrough cache
(which is supposed to use FUA semantics on every write), and
targetted an NBD client connected to a server that intentionally
did not advertise NBD_FLAG_SEND_FUA. When doing 'write 0 512',
the NBD client sent two operations (NBD_CMD_WRITE then
NBD_CMD_FLUSH) to get the fallback FUA semantics; but when doing
'write -z 0 512', the NBD client sent only NBD_CMD_WRITE.
The fix is do to a cleanup bdrv_co_flush() at the end of the
operation if any step in the middle relied on a BDS that does
not natively support FUA for that step (note that we don't
need to flush after every operation, if the operation is broken
into chunks based on bounce-buffer sizing). Each BDS gains a
new flag .supported_zero_flags, which parallels the use of
.supported_write_flags but only when accessing a zero write
operation (the flags MUST be different, because of SCSI having
different semantics based on WRITE vs. WRITESAME; and also
because BDRV_REQ_MAY_UNMAP only makes sense on zero writes).
Also fix some documentation to describe -ENOTSUP semantics,
particularly since iscsi depends on those semantics.
Down the road, we may want to add a driver where its
.bdrv_co_pwritev() honors all three of BDRV_REQ_FUA,
BDRV_REQ_ZERO_WRITE, and BDRV_REQ_MAY_UNMAP, and advertise
this via bs->supported_write_flags for blocks opened by that
driver; such a driver should NOT supply .bdrv_co_write_zeroes
nor .supported_zero_flags. But none of the drivers touched
in this patch want to do that (the act of writing zeroes is
different enough from normal writes to deserve a second
callback).
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2016-05-04 01:39:07 +03:00
|
|
|
bool need_flush = false;
|
2016-05-26 06:48:45 +03:00
|
|
|
int head = 0;
|
|
|
|
int tail = 0;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2021-09-03 13:28:04 +03:00
|
|
|
int64_t max_write_zeroes = MIN_NON_ZERO(bs->bl.max_pwrite_zeroes,
|
|
|
|
INT64_MAX);
|
2016-06-24 01:37:24 +03:00
|
|
|
int alignment = MAX(bs->bl.pwrite_zeroes_alignment,
|
|
|
|
bs->bl.request_alignment);
|
block: Perform copy-on-read in loop
Improve our braindead copy-on-read implementation. Pre-patch,
we have multiple issues:
- we create a bounce buffer and perform a write for the entire
request, even if the active image already has 99% of the
clusters occupied, and really only needs to copy-on-read the
remaining 1% of the clusters
- our bounce buffer was as large as the read request, and can
needlessly exhaust our memory by using double the memory of
the request size (the original request plus our bounce buffer),
rather than a capped maximum overhead beyond the original
- if a driver has a max_transfer limit, we are bypassing the
normal code in bdrv_aligned_preadv() that fragments to that
limit, and instead attempt to read the entire buffer from the
driver in one go, which some drivers may assert on
- a client can request a large request of nearly 2G such that
rounding the request out to cluster boundaries results in a
byte count larger than 2G. While this cannot exceed 32 bits,
it DOES have some follow-on problems:
-- the call to bdrv_driver_pread() can assert for exceeding
BDRV_REQUEST_MAX_BYTES, if the driver is old and lacks
.bdrv_co_preadv
-- if the buffer is all zeroes, the subsequent call to
bdrv_co_do_pwrite_zeroes is a no-op due to a negative size,
which means we did not actually copy on read
Fix all of these issues by breaking up the action into a loop,
where each iteration is capped to sane limits. Also, querying
the allocation status allows us to optimize: when data is
already present in the active layer, we don't need to bounce.
Note that the code has a telling comment that copy-on-read
should probably be a filter driver rather than a bolt-on hack
in io.c; but that remains a task for another day.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-05 22:02:47 +03:00
|
|
|
int max_transfer = MIN_NON_ZERO(bs->bl.max_transfer, MAX_BOUNCE_BUFFER);
|
2016-06-02 00:10:03 +03:00
|
|
|
|
2023-02-03 18:21:48 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2020-12-11 21:39:28 +03:00
|
|
|
bdrv_check_request(offset, bytes, &error_abort);
|
|
|
|
|
2017-11-10 23:31:09 +03:00
|
|
|
if (!drv) {
|
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
|
2019-03-22 15:38:43 +03:00
|
|
|
if ((flags & ~bs->supported_zero_flags) & BDRV_REQ_NO_FALLBACK) {
|
|
|
|
return -ENOTSUP;
|
|
|
|
}
|
|
|
|
|
2022-10-13 21:59:01 +03:00
|
|
|
/* By definition there is no user buffer so this flag doesn't make sense */
|
|
|
|
if (flags & BDRV_REQ_REGISTERED_BUF) {
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2024-06-28 23:20:58 +03:00
|
|
|
/* If opened with discard=off we should never unmap. */
|
|
|
|
if (!(bs->open_flags & BDRV_O_UNMAP)) {
|
|
|
|
flags &= ~BDRV_REQ_MAY_UNMAP;
|
|
|
|
}
|
|
|
|
|
block: block-status cache for data regions
As we have attempted before
(https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06451.html,
"file-posix: Cache lseek result for data regions";
https://lists.nongnu.org/archive/html/qemu-block/2021-02/msg00934.html,
"file-posix: Cache next hole"), this patch seeks to reduce the number of
SEEK_DATA/HOLE operations the file-posix driver has to perform. The
main difference is that this time it is implemented as part of the
general block layer code.
The problem we face is that on some filesystems or in some
circumstances, SEEK_DATA/HOLE is unreasonably slow. Given the
implementation is outside of qemu, there is little we can do about its
performance.
We have already introduced the want_zero parameter to
bdrv_co_block_status() to reduce the number of SEEK_DATA/HOLE calls
unless we really want zero information; but sometimes we do want that
information, because for files that consist largely of zero areas,
special-casing those areas can give large performance boosts. So the
real problem is with files that consist largely of data, so that
inquiring the block status does not gain us much performance, but where
such an inquiry itself takes a lot of time.
To address this, we want to cache data regions. Most of the time, when
bad performance is reported, it is in places where the image is iterated
over from start to end (qemu-img convert or the mirror job), so a simple
yet effective solution is to cache only the current data region.
(Note that only caching data regions but not zero regions means that
returning false information from the cache is not catastrophic: Treating
zeroes as data is fine. While we try to invalidate the cache on zero
writes and discards, such incongruences may still occur when there are
other processes writing to the image.)
We only use the cache for nodes without children (i.e. protocol nodes),
because that is where the problem is: Drivers that rely on block-status
implementations outside of qemu (e.g. SEEK_DATA/HOLE).
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/307
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20210812084148.14458-3-hreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
[hreitz: Added `local_file == bs` assertion, as suggested by Vladimir]
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2021-08-12 11:41:44 +03:00
|
|
|
/* Invalidate the cached block-status data range if this write overlaps */
|
|
|
|
bdrv_bsc_invalidate_range(bs, offset, bytes);
|
|
|
|
|
2016-07-21 22:34:48 +03:00
|
|
|
assert(alignment % bs->bl.request_alignment == 0);
|
|
|
|
head = offset % alignment;
|
2017-06-09 13:18:08 +03:00
|
|
|
tail = (offset + bytes) % alignment;
|
2016-07-21 22:34:48 +03:00
|
|
|
max_write_zeroes = QEMU_ALIGN_DOWN(max_write_zeroes, alignment);
|
|
|
|
assert(max_write_zeroes >= bs->bl.request_alignment);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2017-06-09 13:18:08 +03:00
|
|
|
while (bytes > 0 && !ret) {
|
2020-12-11 21:39:28 +03:00
|
|
|
int64_t num = bytes;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
|
|
|
/* Align request. Block drivers can expect the "bulk" of the request
|
2016-05-26 06:48:45 +03:00
|
|
|
* to be aligned, and that unaligned requests do not cross cluster
|
|
|
|
* boundaries.
|
2015-04-28 16:27:52 +03:00
|
|
|
*/
|
2016-05-26 06:48:45 +03:00
|
|
|
if (head) {
|
2016-11-17 23:13:56 +03:00
|
|
|
/* Make a small request up to the first aligned sector. For
|
|
|
|
* convenience, limit this request to max_transfer even if
|
|
|
|
* we don't need to fall back to writes. */
|
2017-06-09 13:18:08 +03:00
|
|
|
num = MIN(MIN(bytes, max_transfer), alignment - head);
|
2016-11-17 23:13:56 +03:00
|
|
|
head = (head + num) % alignment;
|
|
|
|
assert(num < max_write_zeroes);
|
2016-06-02 00:10:03 +03:00
|
|
|
} else if (tail && num > alignment) {
|
2016-05-26 06:48:45 +03:00
|
|
|
/* Shorten the request to the last aligned sector. */
|
|
|
|
num -= tail;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/* limit request size */
|
|
|
|
if (num > max_write_zeroes) {
|
|
|
|
num = max_write_zeroes;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = -ENOTSUP;
|
|
|
|
/* First try the efficient write zeroes operation */
|
2016-06-02 00:10:03 +03:00
|
|
|
if (drv->bdrv_co_pwrite_zeroes) {
|
|
|
|
ret = drv->bdrv_co_pwrite_zeroes(bs, offset, num,
|
|
|
|
flags & bs->supported_zero_flags);
|
|
|
|
if (ret != -ENOTSUP && (flags & BDRV_REQ_FUA) &&
|
|
|
|
!(bs->supported_zero_flags & BDRV_REQ_FUA)) {
|
|
|
|
need_flush = true;
|
|
|
|
}
|
block: Honor BDRV_REQ_FUA during write_zeroes
The block layer has a couple of cases where it can lose
Force Unit Access semantics when writing a large block of
zeroes, such that the request returns before the zeroes
have been guaranteed to land on underlying media.
SCSI does not support FUA during WRITESAME(10/16); FUA is only
supported if it falls back to WRITE(10/16). But where the
underlying device is new enough to not need a fallback, it
means that any upper layer request with FUA semantics was
silently ignoring BDRV_REQ_FUA.
Conversely, NBD has situations where it can support FUA but not
ZERO_WRITE; when that happens, the generic block layer fallback
to bdrv_driver_pwritev() (or the older bdrv_co_writev() in qemu
2.6) was losing the FUA flag.
The problem of losing flags unrelated to ZERO_WRITE has been
latent in bdrv_co_do_write_zeroes() since commit aa7bfbff, but
back then, it did not matter because there was no FUA flag. It
became observable when commit 93f5e6d8 paved the way for flags
that can impact correctness, when we should have been using
bdrv_co_writev_flags() with modified flags. Compare to commit
9eeb6dd, which got flag manipulation right in
bdrv_co_do_zero_pwritev().
Symptoms: I tested with qemu-io with default writethrough cache
(which is supposed to use FUA semantics on every write), and
targetted an NBD client connected to a server that intentionally
did not advertise NBD_FLAG_SEND_FUA. When doing 'write 0 512',
the NBD client sent two operations (NBD_CMD_WRITE then
NBD_CMD_FLUSH) to get the fallback FUA semantics; but when doing
'write -z 0 512', the NBD client sent only NBD_CMD_WRITE.
The fix is do to a cleanup bdrv_co_flush() at the end of the
operation if any step in the middle relied on a BDS that does
not natively support FUA for that step (note that we don't
need to flush after every operation, if the operation is broken
into chunks based on bounce-buffer sizing). Each BDS gains a
new flag .supported_zero_flags, which parallels the use of
.supported_write_flags but only when accessing a zero write
operation (the flags MUST be different, because of SCSI having
different semantics based on WRITE vs. WRITESAME; and also
because BDRV_REQ_MAY_UNMAP only makes sense on zero writes).
Also fix some documentation to describe -ENOTSUP semantics,
particularly since iscsi depends on those semantics.
Down the road, we may want to add a driver where its
.bdrv_co_pwritev() honors all three of BDRV_REQ_FUA,
BDRV_REQ_ZERO_WRITE, and BDRV_REQ_MAY_UNMAP, and advertise
this via bs->supported_write_flags for blocks opened by that
driver; such a driver should NOT supply .bdrv_co_write_zeroes
nor .supported_zero_flags. But none of the drivers touched
in this patch want to do that (the act of writing zeroes is
different enough from normal writes to deserve a second
callback).
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2016-05-04 01:39:07 +03:00
|
|
|
} else {
|
|
|
|
assert(!bs->supported_zero_flags);
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2019-08-27 16:52:53 +03:00
|
|
|
if (ret == -ENOTSUP && !(flags & BDRV_REQ_NO_FALLBACK)) {
|
2015-04-28 16:27:52 +03:00
|
|
|
/* Fall back to bounce buffer if write zeroes is unsupported */
|
block: Honor BDRV_REQ_FUA during write_zeroes
The block layer has a couple of cases where it can lose
Force Unit Access semantics when writing a large block of
zeroes, such that the request returns before the zeroes
have been guaranteed to land on underlying media.
SCSI does not support FUA during WRITESAME(10/16); FUA is only
supported if it falls back to WRITE(10/16). But where the
underlying device is new enough to not need a fallback, it
means that any upper layer request with FUA semantics was
silently ignoring BDRV_REQ_FUA.
Conversely, NBD has situations where it can support FUA but not
ZERO_WRITE; when that happens, the generic block layer fallback
to bdrv_driver_pwritev() (or the older bdrv_co_writev() in qemu
2.6) was losing the FUA flag.
The problem of losing flags unrelated to ZERO_WRITE has been
latent in bdrv_co_do_write_zeroes() since commit aa7bfbff, but
back then, it did not matter because there was no FUA flag. It
became observable when commit 93f5e6d8 paved the way for flags
that can impact correctness, when we should have been using
bdrv_co_writev_flags() with modified flags. Compare to commit
9eeb6dd, which got flag manipulation right in
bdrv_co_do_zero_pwritev().
Symptoms: I tested with qemu-io with default writethrough cache
(which is supposed to use FUA semantics on every write), and
targetted an NBD client connected to a server that intentionally
did not advertise NBD_FLAG_SEND_FUA. When doing 'write 0 512',
the NBD client sent two operations (NBD_CMD_WRITE then
NBD_CMD_FLUSH) to get the fallback FUA semantics; but when doing
'write -z 0 512', the NBD client sent only NBD_CMD_WRITE.
The fix is do to a cleanup bdrv_co_flush() at the end of the
operation if any step in the middle relied on a BDS that does
not natively support FUA for that step (note that we don't
need to flush after every operation, if the operation is broken
into chunks based on bounce-buffer sizing). Each BDS gains a
new flag .supported_zero_flags, which parallels the use of
.supported_write_flags but only when accessing a zero write
operation (the flags MUST be different, because of SCSI having
different semantics based on WRITE vs. WRITESAME; and also
because BDRV_REQ_MAY_UNMAP only makes sense on zero writes).
Also fix some documentation to describe -ENOTSUP semantics,
particularly since iscsi depends on those semantics.
Down the road, we may want to add a driver where its
.bdrv_co_pwritev() honors all three of BDRV_REQ_FUA,
BDRV_REQ_ZERO_WRITE, and BDRV_REQ_MAY_UNMAP, and advertise
this via bs->supported_write_flags for blocks opened by that
driver; such a driver should NOT supply .bdrv_co_write_zeroes
nor .supported_zero_flags. But none of the drivers touched
in this patch want to do that (the act of writing zeroes is
different enough from normal writes to deserve a second
callback).
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2016-05-04 01:39:07 +03:00
|
|
|
BdrvRequestFlags write_flags = flags & ~BDRV_REQ_ZERO_WRITE;
|
|
|
|
|
|
|
|
if ((flags & BDRV_REQ_FUA) &&
|
|
|
|
!(bs->supported_write_flags & BDRV_REQ_FUA)) {
|
|
|
|
/* No need for bdrv_driver_pwrite() to do a fallback
|
|
|
|
* flush on each chunk; use just one at the end */
|
|
|
|
write_flags &= ~BDRV_REQ_FUA;
|
|
|
|
need_flush = true;
|
|
|
|
}
|
2016-06-24 01:37:19 +03:00
|
|
|
num = MIN(num, max_transfer);
|
2019-02-18 17:09:11 +03:00
|
|
|
if (buf == NULL) {
|
|
|
|
buf = qemu_try_blockalign0(bs, num);
|
|
|
|
if (buf == NULL) {
|
2015-04-28 16:27:52 +03:00
|
|
|
ret = -ENOMEM;
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
2019-02-18 17:09:11 +03:00
|
|
|
qemu_iovec_init_buf(&qiov, buf, num);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2019-06-04 19:15:06 +03:00
|
|
|
ret = bdrv_driver_pwritev(bs, offset, num, &qiov, 0, write_flags);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
|
|
|
/* Keep bounce buffer around if it is big enough for all
|
|
|
|
* all future requests.
|
|
|
|
*/
|
2016-06-24 01:37:19 +03:00
|
|
|
if (num < max_transfer) {
|
2019-02-18 17:09:11 +03:00
|
|
|
qemu_vfree(buf);
|
|
|
|
buf = NULL;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-06-02 00:10:03 +03:00
|
|
|
offset += num;
|
2017-06-09 13:18:08 +03:00
|
|
|
bytes -= num;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
fail:
|
block: Honor BDRV_REQ_FUA during write_zeroes
The block layer has a couple of cases where it can lose
Force Unit Access semantics when writing a large block of
zeroes, such that the request returns before the zeroes
have been guaranteed to land on underlying media.
SCSI does not support FUA during WRITESAME(10/16); FUA is only
supported if it falls back to WRITE(10/16). But where the
underlying device is new enough to not need a fallback, it
means that any upper layer request with FUA semantics was
silently ignoring BDRV_REQ_FUA.
Conversely, NBD has situations where it can support FUA but not
ZERO_WRITE; when that happens, the generic block layer fallback
to bdrv_driver_pwritev() (or the older bdrv_co_writev() in qemu
2.6) was losing the FUA flag.
The problem of losing flags unrelated to ZERO_WRITE has been
latent in bdrv_co_do_write_zeroes() since commit aa7bfbff, but
back then, it did not matter because there was no FUA flag. It
became observable when commit 93f5e6d8 paved the way for flags
that can impact correctness, when we should have been using
bdrv_co_writev_flags() with modified flags. Compare to commit
9eeb6dd, which got flag manipulation right in
bdrv_co_do_zero_pwritev().
Symptoms: I tested with qemu-io with default writethrough cache
(which is supposed to use FUA semantics on every write), and
targetted an NBD client connected to a server that intentionally
did not advertise NBD_FLAG_SEND_FUA. When doing 'write 0 512',
the NBD client sent two operations (NBD_CMD_WRITE then
NBD_CMD_FLUSH) to get the fallback FUA semantics; but when doing
'write -z 0 512', the NBD client sent only NBD_CMD_WRITE.
The fix is do to a cleanup bdrv_co_flush() at the end of the
operation if any step in the middle relied on a BDS that does
not natively support FUA for that step (note that we don't
need to flush after every operation, if the operation is broken
into chunks based on bounce-buffer sizing). Each BDS gains a
new flag .supported_zero_flags, which parallels the use of
.supported_write_flags but only when accessing a zero write
operation (the flags MUST be different, because of SCSI having
different semantics based on WRITE vs. WRITESAME; and also
because BDRV_REQ_MAY_UNMAP only makes sense on zero writes).
Also fix some documentation to describe -ENOTSUP semantics,
particularly since iscsi depends on those semantics.
Down the road, we may want to add a driver where its
.bdrv_co_pwritev() honors all three of BDRV_REQ_FUA,
BDRV_REQ_ZERO_WRITE, and BDRV_REQ_MAY_UNMAP, and advertise
this via bs->supported_write_flags for blocks opened by that
driver; such a driver should NOT supply .bdrv_co_write_zeroes
nor .supported_zero_flags. But none of the drivers touched
in this patch want to do that (the act of writing zeroes is
different enough from normal writes to deserve a second
callback).
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2016-05-04 01:39:07 +03:00
|
|
|
if (ret == 0 && need_flush) {
|
|
|
|
ret = bdrv_co_flush(bs);
|
|
|
|
}
|
2019-02-18 17:09:11 +03:00
|
|
|
qemu_vfree(buf);
|
2015-04-28 16:27:52 +03:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2023-05-04 14:57:44 +03:00
|
|
|
static inline int coroutine_fn GRAPH_RDLOCK
|
2020-12-11 21:39:29 +03:00
|
|
|
bdrv_co_write_req_prepare(BdrvChild *child, int64_t offset, int64_t bytes,
|
2018-07-10 09:31:19 +03:00
|
|
|
BdrvTrackedRequest *req, int flags)
|
|
|
|
{
|
|
|
|
BlockDriverState *bs = child->bs;
|
2020-12-11 21:39:29 +03:00
|
|
|
|
|
|
|
bdrv_check_request(offset, bytes, &error_abort);
|
2018-07-10 09:31:19 +03:00
|
|
|
|
2021-05-27 18:40:54 +03:00
|
|
|
if (bdrv_is_read_only(bs)) {
|
2018-07-10 09:31:19 +03:00
|
|
|
return -EPERM;
|
|
|
|
}
|
|
|
|
|
|
|
|
assert(!(bs->open_flags & BDRV_O_INACTIVE));
|
|
|
|
assert((bs->open_flags & BDRV_O_NO_IO) == 0);
|
|
|
|
assert(!(flags & ~BDRV_REQ_MASK));
|
2020-10-21 17:58:44 +03:00
|
|
|
assert(!((flags & BDRV_REQ_NO_WAIT) && !(flags & BDRV_REQ_SERIALISING)));
|
2018-07-10 09:31:19 +03:00
|
|
|
|
|
|
|
if (flags & BDRV_REQ_SERIALISING) {
|
2020-10-21 17:58:44 +03:00
|
|
|
QEMU_LOCK_GUARD(&bs->reqs_lock);
|
|
|
|
|
|
|
|
tracked_request_set_serialising(req, bdrv_get_cluster_size(bs));
|
|
|
|
|
|
|
|
if ((flags & BDRV_REQ_NO_WAIT) && bdrv_find_conflicting_request(req)) {
|
|
|
|
return -EBUSY;
|
|
|
|
}
|
|
|
|
|
|
|
|
bdrv_wait_serialising_requests_locked(req);
|
2020-01-08 17:55:55 +03:00
|
|
|
} else {
|
|
|
|
bdrv_wait_serialising_requests(req);
|
2018-07-10 09:31:19 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
assert(req->overlap_offset <= offset);
|
|
|
|
assert(offset + bytes <= req->overlap_offset + req->overlap_bytes);
|
2020-12-11 21:39:29 +03:00
|
|
|
assert(offset + bytes <= bs->total_sectors * BDRV_SECTOR_SIZE ||
|
|
|
|
child->perm & BLK_PERM_RESIZE);
|
2018-07-10 09:31:19 +03:00
|
|
|
|
2018-07-10 09:31:24 +03:00
|
|
|
switch (req->type) {
|
|
|
|
case BDRV_TRACKED_WRITE:
|
|
|
|
case BDRV_TRACKED_DISCARD:
|
|
|
|
if (flags & BDRV_REQ_WRITE_UNCHANGED) {
|
|
|
|
assert(child->perm & (BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE));
|
|
|
|
} else {
|
|
|
|
assert(child->perm & BLK_PERM_WRITE);
|
|
|
|
}
|
2021-05-06 12:06:14 +03:00
|
|
|
bdrv_write_threshold_check_write(bs, offset, bytes);
|
|
|
|
return 0;
|
2018-07-10 09:31:24 +03:00
|
|
|
case BDRV_TRACKED_TRUNCATE:
|
|
|
|
assert(child->perm & BLK_PERM_RESIZE);
|
|
|
|
return 0;
|
|
|
|
default:
|
|
|
|
abort();
|
2018-07-10 09:31:19 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-09-29 17:51:41 +03:00
|
|
|
static inline void coroutine_fn GRAPH_RDLOCK
|
2020-12-11 21:39:29 +03:00
|
|
|
bdrv_co_write_req_finish(BdrvChild *child, int64_t offset, int64_t bytes,
|
2018-07-10 09:31:19 +03:00
|
|
|
BdrvTrackedRequest *req, int ret)
|
|
|
|
{
|
|
|
|
int64_t end_sector = DIV_ROUND_UP(offset + bytes, BDRV_SECTOR_SIZE);
|
|
|
|
BlockDriverState *bs = child->bs;
|
|
|
|
|
2020-12-11 21:39:29 +03:00
|
|
|
bdrv_check_request(offset, bytes, &error_abort);
|
|
|
|
|
2020-09-23 13:56:46 +03:00
|
|
|
qatomic_inc(&bs->write_gen);
|
2018-07-10 09:31:19 +03:00
|
|
|
|
2018-07-10 09:31:21 +03:00
|
|
|
/*
|
|
|
|
* Discard cannot extend the image, but in error handling cases, such as
|
|
|
|
* when reverting a qcow2 cluster allocation, the discarded range can pass
|
|
|
|
* the end of image file, so we cannot assert about BDRV_TRACKED_DISCARD
|
|
|
|
* here. Instead, just skip it, since semantically a discard request
|
|
|
|
* beyond EOF cannot expand the image anyway.
|
|
|
|
*/
|
2018-07-10 09:31:20 +03:00
|
|
|
if (ret == 0 &&
|
2018-07-10 09:31:24 +03:00
|
|
|
(req->type == BDRV_TRACKED_TRUNCATE ||
|
|
|
|
end_sector > bs->total_sectors) &&
|
|
|
|
req->type != BDRV_TRACKED_DISCARD) {
|
2018-07-10 09:31:20 +03:00
|
|
|
bs->total_sectors = end_sector;
|
|
|
|
bdrv_parent_cb_resize(bs);
|
|
|
|
bdrv_dirty_bitmap_truncate(bs, end_sector << BDRV_SECTOR_BITS);
|
2018-07-10 09:31:19 +03:00
|
|
|
}
|
2018-07-10 09:31:21 +03:00
|
|
|
if (req->bytes) {
|
|
|
|
switch (req->type) {
|
|
|
|
case BDRV_TRACKED_WRITE:
|
|
|
|
stat64_max(&bs->wr_highest_offset, offset + bytes);
|
|
|
|
/* fall through, to set dirty bits */
|
|
|
|
case BDRV_TRACKED_DISCARD:
|
|
|
|
bdrv_set_dirty(bs, offset, bytes);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2018-07-10 09:31:19 +03:00
|
|
|
}
|
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
/*
|
block: Fragment writes to max transfer length
Drivers should be able to rely on the block layer honoring the
max transfer length, rather than needing to return -EINVAL
(iscsi) or manually fragment things (nbd). We already fragment
write zeroes at the block layer; this patch adds the fragmentation
for normal writes, after requests have been aligned (fragmenting
before alignment would lead to multiple unaligned requests, rather
than just the head and tail).
When fragmenting a large request where FUA was requested, but
where we know that FUA is implemented by flushing all requests
rather than the given request, then we can still get by with
only one flush. Note, however, that we need a followup patch
to the raw format driver to avoid a regression in the number of
flushes actually issued.
The return value was previously nebulous on success (sometimes
zero, sometimes the length written); since we never have a short
write, and since fragmenting may store yet another positive
value in 'ret', change the function to always return 0 on success,
matching what we do in bdrv_aligned_preadv().
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 1468607524-19021-4-git-send-email-eblake@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2016-07-15 21:32:01 +03:00
|
|
|
* Forwards an already correctly aligned write request to the BlockDriver,
|
|
|
|
* after possibly fragmenting it.
|
2015-04-28 16:27:52 +03:00
|
|
|
*/
|
2023-02-03 18:21:49 +03:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
bdrv_aligned_pwritev(BdrvChild *child, BdrvTrackedRequest *req,
|
|
|
|
int64_t offset, int64_t bytes, int64_t align,
|
|
|
|
QEMUIOVector *qiov, size_t qiov_offset,
|
|
|
|
BdrvRequestFlags flags)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2017-02-09 17:58:43 +03:00
|
|
|
BlockDriverState *bs = child->bs;
|
2015-04-28 16:27:52 +03:00
|
|
|
BlockDriver *drv = bs->drv;
|
|
|
|
int ret;
|
|
|
|
|
2020-12-11 21:39:29 +03:00
|
|
|
int64_t bytes_remaining = bytes;
|
block: Fragment writes to max transfer length
Drivers should be able to rely on the block layer honoring the
max transfer length, rather than needing to return -EINVAL
(iscsi) or manually fragment things (nbd). We already fragment
write zeroes at the block layer; this patch adds the fragmentation
for normal writes, after requests have been aligned (fragmenting
before alignment would lead to multiple unaligned requests, rather
than just the head and tail).
When fragmenting a large request where FUA was requested, but
where we know that FUA is implemented by flushing all requests
rather than the given request, then we can still get by with
only one flush. Note, however, that we need a followup patch
to the raw format driver to avoid a regression in the number of
flushes actually issued.
The return value was previously nebulous on success (sometimes
zero, sometimes the length written); since we never have a short
write, and since fragmenting may store yet another positive
value in 'ret', change the function to always return 0 on success,
matching what we do in bdrv_aligned_preadv().
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 1468607524-19021-4-git-send-email-eblake@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2016-07-15 21:32:01 +03:00
|
|
|
int max_transfer;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2020-12-11 21:39:29 +03:00
|
|
|
bdrv_check_qiov_request(offset, bytes, qiov, qiov_offset, &error_abort);
|
|
|
|
|
2017-11-10 23:31:09 +03:00
|
|
|
if (!drv) {
|
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
|
2017-06-28 15:05:10 +03:00
|
|
|
if (bdrv_has_readonly_bitmaps(bs)) {
|
|
|
|
return -EPERM;
|
|
|
|
}
|
|
|
|
|
2016-06-24 01:37:05 +03:00
|
|
|
assert(is_power_of_2(align));
|
|
|
|
assert((offset & (align - 1)) == 0);
|
|
|
|
assert((bytes & (align - 1)) == 0);
|
block: Fragment writes to max transfer length
Drivers should be able to rely on the block layer honoring the
max transfer length, rather than needing to return -EINVAL
(iscsi) or manually fragment things (nbd). We already fragment
write zeroes at the block layer; this patch adds the fragmentation
for normal writes, after requests have been aligned (fragmenting
before alignment would lead to multiple unaligned requests, rather
than just the head and tail).
When fragmenting a large request where FUA was requested, but
where we know that FUA is implemented by flushing all requests
rather than the given request, then we can still get by with
only one flush. Note, however, that we need a followup patch
to the raw format driver to avoid a regression in the number of
flushes actually issued.
The return value was previously nebulous on success (sometimes
zero, sometimes the length written); since we never have a short
write, and since fragmenting may store yet another positive
value in 'ret', change the function to always return 0 on success,
matching what we do in bdrv_aligned_preadv().
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 1468607524-19021-4-git-send-email-eblake@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2016-07-15 21:32:01 +03:00
|
|
|
max_transfer = QEMU_ALIGN_DOWN(MIN_NON_ZERO(bs->bl.max_transfer, INT_MAX),
|
|
|
|
align);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2018-07-10 09:31:19 +03:00
|
|
|
ret = bdrv_co_write_req_prepare(child, offset, bytes, req, flags);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
|
|
|
if (!ret && bs->detect_zeroes != BLOCKDEV_DETECT_ZEROES_OPTIONS_OFF &&
|
2016-06-02 00:10:13 +03:00
|
|
|
!(flags & BDRV_REQ_ZERO_WRITE) && drv->bdrv_co_pwrite_zeroes &&
|
2019-06-04 19:15:10 +03:00
|
|
|
qemu_iovec_is_zero(qiov, qiov_offset, bytes)) {
|
2015-04-28 16:27:52 +03:00
|
|
|
flags |= BDRV_REQ_ZERO_WRITE;
|
|
|
|
if (bs->detect_zeroes == BLOCKDEV_DETECT_ZEROES_OPTIONS_UNMAP) {
|
|
|
|
flags |= BDRV_REQ_MAY_UNMAP;
|
|
|
|
}
|
2023-02-07 23:37:16 +03:00
|
|
|
|
|
|
|
/* Can't use optimization hint with bufferless zero write */
|
|
|
|
flags &= ~BDRV_REQ_REGISTERED_BUF;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (ret < 0) {
|
|
|
|
/* Do nothing, write notifier decided to fail this request */
|
|
|
|
} else if (flags & BDRV_REQ_ZERO_WRITE) {
|
2023-01-13 23:42:11 +03:00
|
|
|
bdrv_co_debug_event(bs, BLKDBG_PWRITEV_ZERO);
|
2016-06-03 19:42:51 +03:00
|
|
|
ret = bdrv_co_do_pwrite_zeroes(bs, offset, bytes, flags);
|
2016-07-22 11:17:49 +03:00
|
|
|
} else if (flags & BDRV_REQ_WRITE_COMPRESSED) {
|
2019-06-04 19:15:10 +03:00
|
|
|
ret = bdrv_driver_pwritev_compressed(bs, offset, bytes,
|
|
|
|
qiov, qiov_offset);
|
block: Fragment writes to max transfer length
Drivers should be able to rely on the block layer honoring the
max transfer length, rather than needing to return -EINVAL
(iscsi) or manually fragment things (nbd). We already fragment
write zeroes at the block layer; this patch adds the fragmentation
for normal writes, after requests have been aligned (fragmenting
before alignment would lead to multiple unaligned requests, rather
than just the head and tail).
When fragmenting a large request where FUA was requested, but
where we know that FUA is implemented by flushing all requests
rather than the given request, then we can still get by with
only one flush. Note, however, that we need a followup patch
to the raw format driver to avoid a regression in the number of
flushes actually issued.
The return value was previously nebulous on success (sometimes
zero, sometimes the length written); since we never have a short
write, and since fragmenting may store yet another positive
value in 'ret', change the function to always return 0 on success,
matching what we do in bdrv_aligned_preadv().
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 1468607524-19021-4-git-send-email-eblake@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2016-07-15 21:32:01 +03:00
|
|
|
} else if (bytes <= max_transfer) {
|
2023-01-13 23:42:11 +03:00
|
|
|
bdrv_co_debug_event(bs, BLKDBG_PWRITEV);
|
2019-06-04 19:15:10 +03:00
|
|
|
ret = bdrv_driver_pwritev(bs, offset, bytes, qiov, qiov_offset, flags);
|
block: Fragment writes to max transfer length
Drivers should be able to rely on the block layer honoring the
max transfer length, rather than needing to return -EINVAL
(iscsi) or manually fragment things (nbd). We already fragment
write zeroes at the block layer; this patch adds the fragmentation
for normal writes, after requests have been aligned (fragmenting
before alignment would lead to multiple unaligned requests, rather
than just the head and tail).
When fragmenting a large request where FUA was requested, but
where we know that FUA is implemented by flushing all requests
rather than the given request, then we can still get by with
only one flush. Note, however, that we need a followup patch
to the raw format driver to avoid a regression in the number of
flushes actually issued.
The return value was previously nebulous on success (sometimes
zero, sometimes the length written); since we never have a short
write, and since fragmenting may store yet another positive
value in 'ret', change the function to always return 0 on success,
matching what we do in bdrv_aligned_preadv().
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 1468607524-19021-4-git-send-email-eblake@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2016-07-15 21:32:01 +03:00
|
|
|
} else {
|
2023-01-13 23:42:11 +03:00
|
|
|
bdrv_co_debug_event(bs, BLKDBG_PWRITEV);
|
block: Fragment writes to max transfer length
Drivers should be able to rely on the block layer honoring the
max transfer length, rather than needing to return -EINVAL
(iscsi) or manually fragment things (nbd). We already fragment
write zeroes at the block layer; this patch adds the fragmentation
for normal writes, after requests have been aligned (fragmenting
before alignment would lead to multiple unaligned requests, rather
than just the head and tail).
When fragmenting a large request where FUA was requested, but
where we know that FUA is implemented by flushing all requests
rather than the given request, then we can still get by with
only one flush. Note, however, that we need a followup patch
to the raw format driver to avoid a regression in the number of
flushes actually issued.
The return value was previously nebulous on success (sometimes
zero, sometimes the length written); since we never have a short
write, and since fragmenting may store yet another positive
value in 'ret', change the function to always return 0 on success,
matching what we do in bdrv_aligned_preadv().
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 1468607524-19021-4-git-send-email-eblake@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2016-07-15 21:32:01 +03:00
|
|
|
while (bytes_remaining) {
|
|
|
|
int num = MIN(bytes_remaining, max_transfer);
|
|
|
|
int local_flags = flags;
|
|
|
|
|
|
|
|
assert(num);
|
|
|
|
if (num < bytes_remaining && (flags & BDRV_REQ_FUA) &&
|
|
|
|
!(bs->supported_write_flags & BDRV_REQ_FUA)) {
|
|
|
|
/* If FUA is going to be emulated by flush, we only
|
|
|
|
* need to flush on the last iteration */
|
|
|
|
local_flags &= ~BDRV_REQ_FUA;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = bdrv_driver_pwritev(bs, offset + bytes - bytes_remaining,
|
2020-07-28 15:08:04 +03:00
|
|
|
num, qiov,
|
|
|
|
qiov_offset + bytes - bytes_remaining,
|
2019-06-04 19:15:10 +03:00
|
|
|
local_flags);
|
block: Fragment writes to max transfer length
Drivers should be able to rely on the block layer honoring the
max transfer length, rather than needing to return -EINVAL
(iscsi) or manually fragment things (nbd). We already fragment
write zeroes at the block layer; this patch adds the fragmentation
for normal writes, after requests have been aligned (fragmenting
before alignment would lead to multiple unaligned requests, rather
than just the head and tail).
When fragmenting a large request where FUA was requested, but
where we know that FUA is implemented by flushing all requests
rather than the given request, then we can still get by with
only one flush. Note, however, that we need a followup patch
to the raw format driver to avoid a regression in the number of
flushes actually issued.
The return value was previously nebulous on success (sometimes
zero, sometimes the length written); since we never have a short
write, and since fragmenting may store yet another positive
value in 'ret', change the function to always return 0 on success,
matching what we do in bdrv_aligned_preadv().
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 1468607524-19021-4-git-send-email-eblake@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2016-07-15 21:32:01 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
bytes_remaining -= num;
|
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
2023-01-13 23:42:11 +03:00
|
|
|
bdrv_co_debug_event(bs, BLKDBG_PWRITEV_DONE);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
|
|
|
if (ret >= 0) {
|
block: Fragment writes to max transfer length
Drivers should be able to rely on the block layer honoring the
max transfer length, rather than needing to return -EINVAL
(iscsi) or manually fragment things (nbd). We already fragment
write zeroes at the block layer; this patch adds the fragmentation
for normal writes, after requests have been aligned (fragmenting
before alignment would lead to multiple unaligned requests, rather
than just the head and tail).
When fragmenting a large request where FUA was requested, but
where we know that FUA is implemented by flushing all requests
rather than the given request, then we can still get by with
only one flush. Note, however, that we need a followup patch
to the raw format driver to avoid a regression in the number of
flushes actually issued.
The return value was previously nebulous on success (sometimes
zero, sometimes the length written); since we never have a short
write, and since fragmenting may store yet another positive
value in 'ret', change the function to always return 0 on success,
matching what we do in bdrv_aligned_preadv().
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 1468607524-19021-4-git-send-email-eblake@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2016-07-15 21:32:01 +03:00
|
|
|
ret = 0;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
2018-07-10 09:31:19 +03:00
|
|
|
bdrv_co_write_req_finish(child, offset, bytes, req, ret);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2023-02-03 18:21:49 +03:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
bdrv_co_do_zero_pwritev(BdrvChild *child, int64_t offset, int64_t bytes,
|
|
|
|
BdrvRequestFlags flags, BdrvTrackedRequest *req)
|
2015-05-13 16:12:00 +03:00
|
|
|
{
|
2017-02-09 17:58:43 +03:00
|
|
|
BlockDriverState *bs = child->bs;
|
2015-05-13 16:12:00 +03:00
|
|
|
QEMUIOVector local_qiov;
|
2016-06-24 01:37:24 +03:00
|
|
|
uint64_t align = bs->bl.request_alignment;
|
2015-05-13 16:12:00 +03:00
|
|
|
int ret = 0;
|
2019-06-04 19:15:05 +03:00
|
|
|
bool padding;
|
|
|
|
BdrvRequestPadding pad;
|
2015-05-13 16:12:00 +03:00
|
|
|
|
2022-10-13 21:59:01 +03:00
|
|
|
/* This flag doesn't make sense for padding or zero writes */
|
|
|
|
flags &= ~BDRV_REQ_REGISTERED_BUF;
|
|
|
|
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
padding = bdrv_init_padding(bs, offset, bytes, true, &pad);
|
2019-06-04 19:15:05 +03:00
|
|
|
if (padding) {
|
2022-02-15 15:16:09 +03:00
|
|
|
assert(!(flags & BDRV_REQ_NO_WAIT));
|
2020-10-21 17:58:43 +03:00
|
|
|
bdrv_make_request_serialising(req, align);
|
2015-05-13 16:12:00 +03:00
|
|
|
|
2019-06-04 19:15:05 +03:00
|
|
|
bdrv_padding_rmw_read(child, req, &pad, true);
|
|
|
|
|
|
|
|
if (pad.head || pad.merge_reads) {
|
|
|
|
int64_t aligned_offset = offset & ~(align - 1);
|
|
|
|
int64_t write_bytes = pad.merge_reads ? pad.buf_len : align;
|
|
|
|
|
|
|
|
qemu_iovec_init_buf(&local_qiov, pad.buf, write_bytes);
|
|
|
|
ret = bdrv_aligned_pwritev(child, req, aligned_offset, write_bytes,
|
2019-06-04 19:15:10 +03:00
|
|
|
align, &local_qiov, 0,
|
2019-06-04 19:15:05 +03:00
|
|
|
flags & ~BDRV_REQ_ZERO_WRITE);
|
|
|
|
if (ret < 0 || pad.merge_reads) {
|
|
|
|
/* Error or all work is done */
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
offset += write_bytes - pad.head;
|
|
|
|
bytes -= write_bytes - pad.head;
|
2015-05-13 16:12:00 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
assert(!bytes || (offset & (align - 1)) == 0);
|
|
|
|
if (bytes >= align) {
|
|
|
|
/* Write the aligned part in the middle. */
|
2020-12-11 21:39:29 +03:00
|
|
|
int64_t aligned_bytes = bytes & ~(align - 1);
|
2017-02-09 17:58:43 +03:00
|
|
|
ret = bdrv_aligned_pwritev(child, req, offset, aligned_bytes, align,
|
2019-06-04 19:15:10 +03:00
|
|
|
NULL, 0, flags);
|
2015-05-13 16:12:00 +03:00
|
|
|
if (ret < 0) {
|
2019-06-04 19:15:05 +03:00
|
|
|
goto out;
|
2015-05-13 16:12:00 +03:00
|
|
|
}
|
|
|
|
bytes -= aligned_bytes;
|
|
|
|
offset += aligned_bytes;
|
|
|
|
}
|
|
|
|
|
|
|
|
assert(!bytes || (offset & (align - 1)) == 0);
|
|
|
|
if (bytes) {
|
2019-06-04 19:15:05 +03:00
|
|
|
assert(align == pad.tail + bytes);
|
2015-05-13 16:12:00 +03:00
|
|
|
|
2019-06-04 19:15:05 +03:00
|
|
|
qemu_iovec_init_buf(&local_qiov, pad.tail_buf, align);
|
2017-02-09 17:58:43 +03:00
|
|
|
ret = bdrv_aligned_pwritev(child, req, offset, align, align,
|
2019-06-04 19:15:10 +03:00
|
|
|
&local_qiov, 0,
|
|
|
|
flags & ~BDRV_REQ_ZERO_WRITE);
|
2015-05-13 16:12:00 +03:00
|
|
|
}
|
|
|
|
|
2019-06-04 19:15:05 +03:00
|
|
|
out:
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
bdrv_padding_finalize(&pad);
|
2019-06-04 19:15:05 +03:00
|
|
|
|
|
|
|
return ret;
|
2015-05-13 16:12:00 +03:00
|
|
|
}
|
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
/*
|
|
|
|
* Handle a write request in coroutine context
|
|
|
|
*/
|
2016-06-20 22:31:46 +03:00
|
|
|
int coroutine_fn bdrv_co_pwritev(BdrvChild *child,
|
2020-12-11 21:39:33 +03:00
|
|
|
int64_t offset, int64_t bytes, QEMUIOVector *qiov,
|
2015-04-28 16:27:52 +03:00
|
|
|
BdrvRequestFlags flags)
|
2019-06-04 19:15:11 +03:00
|
|
|
{
|
2022-03-03 18:15:58 +03:00
|
|
|
IO_CODE();
|
2019-06-04 19:15:11 +03:00
|
|
|
return bdrv_co_pwritev_part(child, offset, bytes, qiov, 0, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
int coroutine_fn bdrv_co_pwritev_part(BdrvChild *child,
|
block/io: support int64_t bytes in bdrv_co_p{read,write}v_part()
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibility for signed return type (where negative value means
error).
So, prepare bdrv_co_preadv_part() and bdrv_co_pwritev_part() and their
remaining dependencies now.
bdrv_pad_request() is updated simultaneously, as pointer to bytes passed
to it both from bdrv_co_pwritev_part() and bdrv_co_preadv_part().
So, all callers of bdrv_pad_request() are updated to pass 64bit bytes.
bdrv_pad_request() is already good for 64bit requests, add
corresponding assertion.
Look at bdrv_co_preadv_part() and bdrv_co_pwritev_part().
Type is widening, so callers are safe. Let's look inside the functions.
In bdrv_co_preadv_part() and bdrv_aligned_pwritev() we only pass bytes
to other already int64_t interfaces (and some obviously safe
calculations), it's OK.
In bdrv_co_do_zero_pwritev() aligned_bytes may become large now, still
it's passed to bdrv_aligned_pwritev which supports int64_t bytes.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201211183934.169161-15-vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
2020-12-11 21:39:32 +03:00
|
|
|
int64_t offset, int64_t bytes, QEMUIOVector *qiov, size_t qiov_offset,
|
2019-06-04 19:15:11 +03:00
|
|
|
BdrvRequestFlags flags)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2016-06-20 22:31:46 +03:00
|
|
|
BlockDriverState *bs = child->bs;
|
2015-04-28 16:27:52 +03:00
|
|
|
BdrvTrackedRequest req;
|
2016-06-24 01:37:24 +03:00
|
|
|
uint64_t align = bs->bl.request_alignment;
|
2019-06-04 19:15:05 +03:00
|
|
|
BdrvRequestPadding pad;
|
2015-04-28 16:27:52 +03:00
|
|
|
int ret;
|
2020-12-11 21:39:22 +03:00
|
|
|
bool padded = false;
|
2022-03-03 18:15:58 +03:00
|
|
|
IO_CODE();
|
2015-04-28 16:27:52 +03:00
|
|
|
|
block/io: support int64_t bytes in bdrv_co_p{read,write}v_part()
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibility for signed return type (where negative value means
error).
So, prepare bdrv_co_preadv_part() and bdrv_co_pwritev_part() and their
remaining dependencies now.
bdrv_pad_request() is updated simultaneously, as pointer to bytes passed
to it both from bdrv_co_pwritev_part() and bdrv_co_preadv_part().
So, all callers of bdrv_pad_request() are updated to pass 64bit bytes.
bdrv_pad_request() is already good for 64bit requests, add
corresponding assertion.
Look at bdrv_co_preadv_part() and bdrv_co_pwritev_part().
Type is widening, so callers are safe. Let's look inside the functions.
In bdrv_co_preadv_part() and bdrv_aligned_pwritev() we only pass bytes
to other already int64_t interfaces (and some obviously safe
calculations), it's OK.
In bdrv_co_do_zero_pwritev() aligned_bytes may become large now, still
it's passed to bdrv_aligned_pwritev which supports int64_t bytes.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201211183934.169161-15-vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
2020-12-11 21:39:32 +03:00
|
|
|
trace_bdrv_co_pwritev_part(child->bs, offset, bytes, flags);
|
2017-08-04 13:50:36 +03:00
|
|
|
|
2023-01-13 23:42:02 +03:00
|
|
|
if (!bdrv_co_is_inserted(bs)) {
|
2015-04-28 16:27:52 +03:00
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
|
2021-09-03 13:28:04 +03:00
|
|
|
if (flags & BDRV_REQ_ZERO_WRITE) {
|
|
|
|
ret = bdrv_check_qiov_request(offset, bytes, qiov, qiov_offset, NULL);
|
|
|
|
} else {
|
|
|
|
ret = bdrv_check_request32(offset, bytes, qiov, qiov_offset);
|
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2019-10-14 11:15:45 +03:00
|
|
|
/* If the request is misaligned then we can't make it efficient */
|
|
|
|
if ((flags & BDRV_REQ_NO_FALLBACK) &&
|
|
|
|
!QEMU_IS_ALIGNED(offset | bytes, align))
|
|
|
|
{
|
|
|
|
return -ENOTSUP;
|
|
|
|
}
|
|
|
|
|
2020-02-06 19:42:45 +03:00
|
|
|
if (bytes == 0 && !QEMU_IS_ALIGNED(offset, bs->bl.request_alignment)) {
|
|
|
|
/*
|
|
|
|
* Aligning zero request is nonsense. Even if driver has special meaning
|
|
|
|
* of zero-length (like qcow2_co_pwritev_compressed_part), we can't pass
|
|
|
|
* it to driver due to request_alignment.
|
|
|
|
*
|
|
|
|
* Still, no reason to return an error if someone do unaligned
|
|
|
|
* zero-length write occasionally.
|
|
|
|
*/
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-12-11 21:39:22 +03:00
|
|
|
if (!(flags & BDRV_REQ_ZERO_WRITE)) {
|
|
|
|
/*
|
|
|
|
* Pad request for following read-modify-write cycle.
|
|
|
|
* bdrv_co_do_zero_pwritev() does aligning by itself, so, we do
|
|
|
|
* alignment only if there is no ZERO flag.
|
|
|
|
*/
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
ret = bdrv_pad_request(bs, &qiov, &qiov_offset, &offset, &bytes, true,
|
|
|
|
&pad, &padded, &flags);
|
2020-12-11 21:39:23 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
2020-12-11 21:39:22 +03:00
|
|
|
}
|
|
|
|
|
2016-10-27 13:48:52 +03:00
|
|
|
bdrv_inc_in_flight(bs);
|
2015-11-09 13:16:46 +03:00
|
|
|
tracked_request_begin(&req, bs, offset, bytes, BDRV_TRACKED_WRITE);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2018-02-14 19:09:20 +03:00
|
|
|
if (flags & BDRV_REQ_ZERO_WRITE) {
|
2020-12-11 21:39:22 +03:00
|
|
|
assert(!padded);
|
2017-02-09 17:58:43 +03:00
|
|
|
ret = bdrv_co_do_zero_pwritev(child, offset, bytes, flags, &req);
|
2015-05-13 16:12:00 +03:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2020-12-11 21:39:22 +03:00
|
|
|
if (padded) {
|
|
|
|
/*
|
|
|
|
* Request was unaligned to request_alignment and therefore
|
|
|
|
* padded. We are going to do read-modify-write, and must
|
|
|
|
* serialize the request to prevent interactions of the
|
|
|
|
* widened region with other transactions.
|
|
|
|
*/
|
2022-02-15 15:16:09 +03:00
|
|
|
assert(!(flags & BDRV_REQ_NO_WAIT));
|
2020-10-21 17:58:43 +03:00
|
|
|
bdrv_make_request_serialising(&req, align);
|
2019-06-04 19:15:05 +03:00
|
|
|
bdrv_padding_rmw_read(child, &req, &pad, false);
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2017-02-09 17:58:43 +03:00
|
|
|
ret = bdrv_aligned_pwritev(child, &req, offset, bytes, align,
|
2019-06-04 19:15:11 +03:00
|
|
|
qiov, qiov_offset, flags);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
block: Collapse padded I/O vecs exceeding IOV_MAX
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O vectors up to IOV_MAX (1024) in length, but
with this padding, the vector can exceed that limit. As of
4c002cef0e9abe7135d7916c51abce47f7fc1ee2 ("util/iov: make
qemu_iovec_init_extended() honest"), we refuse to pad vectors beyond the
limit, instead returning an error to the guest.
To the guest, this appears as a random I/O error. We should not return
an I/O error to the guest when it issued a perfectly valid request.
Before 4c002cef0e9abe7135d7916c51abce47f7fc1ee2, we just made the vector
longer than IOV_MAX, which generally seems to work (because the guest
assumes a smaller alignment than we really have, file-posix's
raw_co_prw() will generally see bdrv_qiov_is_aligned() return false, and
so emulate the request, so that the IOV_MAX does not matter). However,
that does not seem exactly great.
I see two ways to fix this problem:
1. We split such long requests into two requests.
2. We join some elements of the vector into new buffers to make it
shorter.
I am wary of (1), because it seems like it may have unintended side
effects.
(2) on the other hand seems relatively simple to implement, with
hopefully few side effects, so this patch does that.
To do this, the use of qemu_iovec_init_extended() in bdrv_pad_request()
is effectively replaced by the new function bdrv_create_padded_qiov(),
which not only wraps the request IOV with padding head/tail, but also
ensures that the resulting vector will not have more than IOV_MAX
elements. Putting that functionality into qemu_iovec_init_extended() is
infeasible because it requires allocating a bounce buffer; doing so
would require many more parameters (buffer alignment, how to initialize
the buffer, and out parameters like the buffer, its length, and the
original elements), which is not reasonable.
Conversely, it is not difficult to move qemu_iovec_init_extended()'s
functionality into bdrv_create_padded_qiov() by using public
qemu_iovec_* functions, so that is what this patch does.
Because bdrv_pad_request() was the only "serious" user of
qemu_iovec_init_extended(), the next patch will remove the latter
function, so the functionality is not implemented twice.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2141964
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-3-hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
2023-04-11 20:34:16 +03:00
|
|
|
bdrv_padding_finalize(&pad);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2015-05-13 16:12:00 +03:00
|
|
|
out:
|
|
|
|
tracked_request_end(&req);
|
2016-10-27 13:48:52 +03:00
|
|
|
bdrv_dec_in_flight(bs);
|
2019-06-04 19:15:05 +03:00
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2016-06-20 22:31:46 +03:00
|
|
|
int coroutine_fn bdrv_co_pwrite_zeroes(BdrvChild *child, int64_t offset,
|
2020-12-11 21:39:33 +03:00
|
|
|
int64_t bytes, BdrvRequestFlags flags)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2017-06-09 13:18:08 +03:00
|
|
|
trace_bdrv_co_pwrite_zeroes(child->bs, offset, bytes, flags);
|
2023-02-03 18:21:48 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2017-06-09 13:18:08 +03:00
|
|
|
return bdrv_co_pwritev(child, offset, bytes, NULL,
|
2016-06-02 00:10:04 +03:00
|
|
|
BDRV_REQ_ZERO_WRITE | flags);
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2016-09-23 04:45:50 +03:00
|
|
|
/*
|
|
|
|
* Flush ALL BDSes regardless of if they are reachable via a BlkBackend or not.
|
|
|
|
*/
|
|
|
|
int bdrv_flush_all(void)
|
|
|
|
{
|
|
|
|
BdrvNextIterator it;
|
|
|
|
BlockDriverState *bs = NULL;
|
|
|
|
int result = 0;
|
|
|
|
|
2022-03-03 18:15:49 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
2023-09-29 17:51:39 +03:00
|
|
|
GRAPH_RDLOCK_GUARD_MAINLOOP();
|
2022-03-03 18:15:49 +03:00
|
|
|
|
2019-09-17 14:58:08 +03:00
|
|
|
/*
|
|
|
|
* bdrv queue is managed by record/replay,
|
|
|
|
* creating new flush request for stopping
|
|
|
|
* the VM may break the determinism
|
|
|
|
*/
|
|
|
|
if (replay_events_enabled()) {
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2016-09-23 04:45:50 +03:00
|
|
|
for (bs = bdrv_first(&it); bs; bs = bdrv_next(&it)) {
|
2023-12-05 21:20:03 +03:00
|
|
|
int ret = bdrv_flush(bs);
|
2016-09-23 04:45:50 +03:00
|
|
|
if (ret < 0 && !result) {
|
|
|
|
result = ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
/*
|
|
|
|
* Returns the allocation status of the specified sectors.
|
|
|
|
* Drivers not implementing the functionality are assumed to not support
|
|
|
|
* backing files, hence all their sectors are reported as allocated.
|
|
|
|
*
|
block: Add .bdrv_co_block_status() callback
We are gradually moving away from sector-based interfaces, towards
byte-based. Now that the block layer exposes byte-based allocation,
it's time to tackle the drivers. Add a new callback that operates
on as small as byte boundaries. Subsequent patches will then update
individual drivers, then finally remove .bdrv_co_get_block_status().
The new code also passes through the 'want_zero' hint, which will
allow subsequent patches to further optimize callers that only care
about how much of the image is allocated (want_zero is false),
rather than full details about runs of zeroes and which offsets the
allocation actually maps to (want_zero is true). As part of this
effort, fix another part of the documentation: the claim in commit
4c41cb4 that BDRV_BLOCK_ALLOCATED is short for 'DATA || ZERO' is a
lie at the block layer (see commit e88ae2264), even though it is
how the bit is computed from the driver layer. After all, there
are intentionally cases where we return ZERO but not ALLOCATED at
the block layer, when we know that a read sees zero because the
backing file is too short. Note that the driver interface is thus
slightly different than the public interface with regards to which
bits will be set, and what guarantees are provided on input.
We also add an assertion that any driver using the new callback will
make progress (the only time pnum will be 0 is if the block layer
already handled an out-of-bounds request, or if there is an error);
the old driver interface did not provide this guarantee, which
could lead to some inf-loops in drastic corner-case failures.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2018-02-13 23:26:41 +03:00
|
|
|
* If 'want_zero' is true, the caller is querying for mapping
|
|
|
|
* purposes, with a focus on valid BDRV_BLOCK_OFFSET_VALID, _DATA, and
|
|
|
|
* _ZERO where possible; otherwise, the result favors larger 'pnum',
|
|
|
|
* with a focus on accurate BDRV_BLOCK_ALLOCATED.
|
block: Add flag to avoid wasted work in bdrv_is_allocated()
Not all callers care about which BDS owns the mapping for a given
range of the file, or where the zeroes lie within that mapping. In
particular, bdrv_is_allocated() cares more about finding the
largest run of allocated data from the guest perspective, whether
or not that data is consecutive from the host perspective, and
whether or not the data reads as zero. Therefore, doing subsequent
refinements such as checking how much of the format-layer
allocation also satisfies BDRV_BLOCK_ZERO at the protocol layer is
wasted work - in the best case, it just costs extra CPU cycles
during a single bdrv_is_allocated(), but in the worst case, it
results in a smaller *pnum, and forces callers to iterate through
more status probes when visiting the entire file for even more
extra CPU cycles.
This patch only optimizes the block layer (no behavior change when
want_zero is true, but skip unnecessary effort when it is false).
Then when subsequent patches tweak the driver callback to be
byte-based, we can also pass this hint through to the driver.
Tweak BdrvCoGetBlockStatusData to declare arguments in parameter
order, rather than mixing things up (minimizing padding is not
necessary here).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:46:58 +03:00
|
|
|
*
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
* If 'offset' is beyond the end of the disk image the return value is
|
2017-05-05 05:14:59 +03:00
|
|
|
* BDRV_BLOCK_EOF and 'pnum' is set to 0.
|
2015-04-28 16:27:52 +03:00
|
|
|
*
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
* 'bytes' is the max value 'pnum' should be set to. If bytes goes
|
2017-05-05 05:14:59 +03:00
|
|
|
* beyond the end of the disk image it will be clamped; if 'pnum' is set to
|
|
|
|
* the end of the image, then the returned value will include BDRV_BLOCK_EOF.
|
2016-01-26 06:58:48 +03:00
|
|
|
*
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
* 'pnum' is set to the number of bytes (including and immediately
|
|
|
|
* following the specified offset) that are easily known to be in the
|
|
|
|
* same allocated/unallocated state. Note that a second call starting
|
|
|
|
* at the original offset plus returned pnum may have the same status.
|
|
|
|
* The returned value is non-zero on success except at end-of-file.
|
|
|
|
*
|
|
|
|
* Returns negative errno on failure. Otherwise, if the
|
|
|
|
* BDRV_BLOCK_OFFSET_VALID bit is set, 'map' and 'file' (if non-NULL) are
|
|
|
|
* set to the host mapping and BDS corresponding to the guest offset.
|
2015-04-28 16:27:52 +03:00
|
|
|
*/
|
2023-02-03 18:21:43 +03:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
2023-09-04 13:03:03 +03:00
|
|
|
bdrv_co_do_block_status(BlockDriverState *bs, bool want_zero,
|
|
|
|
int64_t offset, int64_t bytes,
|
|
|
|
int64_t *pnum, int64_t *map, BlockDriverState **file)
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
{
|
|
|
|
int64_t total_size;
|
|
|
|
int64_t n; /* bytes */
|
2017-10-12 06:47:17 +03:00
|
|
|
int ret;
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
int64_t local_map = 0;
|
2017-10-12 06:46:57 +03:00
|
|
|
BlockDriverState *local_file = NULL;
|
2017-10-12 06:47:17 +03:00
|
|
|
int64_t aligned_offset, aligned_bytes;
|
|
|
|
uint32_t align;
|
2019-02-13 20:05:23 +03:00
|
|
|
bool has_filtered_child;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2017-10-12 06:46:57 +03:00
|
|
|
assert(pnum);
|
2023-02-03 18:21:43 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2017-10-12 06:46:57 +03:00
|
|
|
*pnum = 0;
|
2023-06-01 14:51:44 +03:00
|
|
|
total_size = bdrv_co_getlength(bs);
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
if (total_size < 0) {
|
|
|
|
ret = total_size;
|
2017-10-12 06:46:57 +03:00
|
|
|
goto early_out;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
if (offset >= total_size) {
|
2017-10-12 06:46:57 +03:00
|
|
|
ret = BDRV_BLOCK_EOF;
|
|
|
|
goto early_out;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
if (!bytes) {
|
2017-10-12 06:46:57 +03:00
|
|
|
ret = 0;
|
|
|
|
goto early_out;
|
2017-10-05 22:02:44 +03:00
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
n = total_size - offset;
|
|
|
|
if (n < bytes) {
|
|
|
|
bytes = n;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2023-06-01 14:51:44 +03:00
|
|
|
/* Must be non-NULL or bdrv_co_getlength() would have failed */
|
2017-11-10 23:31:09 +03:00
|
|
|
assert(bs->drv);
|
2019-02-13 20:05:23 +03:00
|
|
|
has_filtered_child = bdrv_filter_child(bs);
|
|
|
|
if (!bs->drv->bdrv_co_block_status && !has_filtered_child) {
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
*pnum = bytes;
|
2015-04-28 16:27:52 +03:00
|
|
|
ret = BDRV_BLOCK_DATA | BDRV_BLOCK_ALLOCATED;
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
if (offset + bytes == total_size) {
|
2017-05-05 05:14:59 +03:00
|
|
|
ret |= BDRV_BLOCK_EOF;
|
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
if (bs->drv->protocol_name) {
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
ret |= BDRV_BLOCK_OFFSET_VALID;
|
|
|
|
local_map = offset;
|
2017-10-12 06:46:57 +03:00
|
|
|
local_file = bs;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
2017-10-12 06:46:57 +03:00
|
|
|
goto early_out;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2016-10-27 13:48:52 +03:00
|
|
|
bdrv_inc_in_flight(bs);
|
2017-10-12 06:47:17 +03:00
|
|
|
|
|
|
|
/* Round out to request_alignment boundaries */
|
block: Add .bdrv_co_block_status() callback
We are gradually moving away from sector-based interfaces, towards
byte-based. Now that the block layer exposes byte-based allocation,
it's time to tackle the drivers. Add a new callback that operates
on as small as byte boundaries. Subsequent patches will then update
individual drivers, then finally remove .bdrv_co_get_block_status().
The new code also passes through the 'want_zero' hint, which will
allow subsequent patches to further optimize callers that only care
about how much of the image is allocated (want_zero is false),
rather than full details about runs of zeroes and which offsets the
allocation actually maps to (want_zero is true). As part of this
effort, fix another part of the documentation: the claim in commit
4c41cb4 that BDRV_BLOCK_ALLOCATED is short for 'DATA || ZERO' is a
lie at the block layer (see commit e88ae2264), even though it is
how the bit is computed from the driver layer. After all, there
are intentionally cases where we return ZERO but not ALLOCATED at
the block layer, when we know that a read sees zero because the
backing file is too short. Note that the driver interface is thus
slightly different than the public interface with regards to which
bits will be set, and what guarantees are provided on input.
We also add an assertion that any driver using the new callback will
make progress (the only time pnum will be 0 is if the block layer
already handled an out-of-bounds request, or if there is an error);
the old driver interface did not provide this guarantee, which
could lead to some inf-loops in drastic corner-case failures.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2018-02-13 23:26:41 +03:00
|
|
|
align = bs->bl.request_alignment;
|
2017-10-12 06:47:17 +03:00
|
|
|
aligned_offset = QEMU_ALIGN_DOWN(offset, align);
|
|
|
|
aligned_bytes = ROUND_UP(offset + bytes, align) - aligned_offset;
|
|
|
|
|
2019-02-13 20:05:23 +03:00
|
|
|
if (bs->drv->bdrv_co_block_status) {
|
block: block-status cache for data regions
As we have attempted before
(https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06451.html,
"file-posix: Cache lseek result for data regions";
https://lists.nongnu.org/archive/html/qemu-block/2021-02/msg00934.html,
"file-posix: Cache next hole"), this patch seeks to reduce the number of
SEEK_DATA/HOLE operations the file-posix driver has to perform. The
main difference is that this time it is implemented as part of the
general block layer code.
The problem we face is that on some filesystems or in some
circumstances, SEEK_DATA/HOLE is unreasonably slow. Given the
implementation is outside of qemu, there is little we can do about its
performance.
We have already introduced the want_zero parameter to
bdrv_co_block_status() to reduce the number of SEEK_DATA/HOLE calls
unless we really want zero information; but sometimes we do want that
information, because for files that consist largely of zero areas,
special-casing those areas can give large performance boosts. So the
real problem is with files that consist largely of data, so that
inquiring the block status does not gain us much performance, but where
such an inquiry itself takes a lot of time.
To address this, we want to cache data regions. Most of the time, when
bad performance is reported, it is in places where the image is iterated
over from start to end (qemu-img convert or the mirror job), so a simple
yet effective solution is to cache only the current data region.
(Note that only caching data regions but not zero regions means that
returning false information from the cache is not catastrophic: Treating
zeroes as data is fine. While we try to invalidate the cache on zero
writes and discards, such incongruences may still occur when there are
other processes writing to the image.)
We only use the cache for nodes without children (i.e. protocol nodes),
because that is where the problem is: Drivers that rely on block-status
implementations outside of qemu (e.g. SEEK_DATA/HOLE).
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/307
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20210812084148.14458-3-hreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
[hreitz: Added `local_file == bs` assertion, as suggested by Vladimir]
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2021-08-12 11:41:44 +03:00
|
|
|
/*
|
|
|
|
* Use the block-status cache only for protocol nodes: Format
|
|
|
|
* drivers are generally quick to inquire the status, but protocol
|
|
|
|
* drivers often need to get information from outside of qemu, so
|
|
|
|
* we do not have control over the actual implementation. There
|
|
|
|
* have been cases where inquiring the status took an unreasonably
|
|
|
|
* long time, and we can do nothing in qemu to fix it.
|
|
|
|
* This is especially problematic for images with large data areas,
|
|
|
|
* because finding the few holes in them and giving them special
|
|
|
|
* treatment does not gain much performance. Therefore, we try to
|
|
|
|
* cache the last-identified data region.
|
|
|
|
*
|
|
|
|
* Second, limiting ourselves to protocol nodes allows us to assume
|
|
|
|
* the block status for data regions to be DATA | OFFSET_VALID, and
|
|
|
|
* that the host offset is the same as the guest offset.
|
|
|
|
*
|
|
|
|
* Note that it is possible that external writers zero parts of
|
|
|
|
* the cached regions without the cache being invalidated, and so
|
|
|
|
* we may report zeroes as data. This is not catastrophic,
|
|
|
|
* however, because reporting zeroes as data is fine.
|
|
|
|
*/
|
|
|
|
if (QLIST_EMPTY(&bs->children) &&
|
|
|
|
bdrv_bsc_is_data(bs, aligned_offset, pnum))
|
|
|
|
{
|
|
|
|
ret = BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID;
|
|
|
|
local_file = bs;
|
|
|
|
local_map = aligned_offset;
|
|
|
|
} else {
|
|
|
|
ret = bs->drv->bdrv_co_block_status(bs, want_zero, aligned_offset,
|
|
|
|
aligned_bytes, pnum, &local_map,
|
|
|
|
&local_file);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Note that checking QLIST_EMPTY(&bs->children) is also done when
|
|
|
|
* the cache is queried above. Technically, we do not need to check
|
|
|
|
* it here; the worst that can happen is that we fill the cache for
|
|
|
|
* non-protocol nodes, and then it is never used. However, filling
|
|
|
|
* the cache requires an RCU update, so double check here to avoid
|
|
|
|
* such an update if possible.
|
2022-01-18 19:59:59 +03:00
|
|
|
*
|
|
|
|
* Check want_zero, because we only want to update the cache when we
|
|
|
|
* have accurate information about what is zero and what is data.
|
block: block-status cache for data regions
As we have attempted before
(https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06451.html,
"file-posix: Cache lseek result for data regions";
https://lists.nongnu.org/archive/html/qemu-block/2021-02/msg00934.html,
"file-posix: Cache next hole"), this patch seeks to reduce the number of
SEEK_DATA/HOLE operations the file-posix driver has to perform. The
main difference is that this time it is implemented as part of the
general block layer code.
The problem we face is that on some filesystems or in some
circumstances, SEEK_DATA/HOLE is unreasonably slow. Given the
implementation is outside of qemu, there is little we can do about its
performance.
We have already introduced the want_zero parameter to
bdrv_co_block_status() to reduce the number of SEEK_DATA/HOLE calls
unless we really want zero information; but sometimes we do want that
information, because for files that consist largely of zero areas,
special-casing those areas can give large performance boosts. So the
real problem is with files that consist largely of data, so that
inquiring the block status does not gain us much performance, but where
such an inquiry itself takes a lot of time.
To address this, we want to cache data regions. Most of the time, when
bad performance is reported, it is in places where the image is iterated
over from start to end (qemu-img convert or the mirror job), so a simple
yet effective solution is to cache only the current data region.
(Note that only caching data regions but not zero regions means that
returning false information from the cache is not catastrophic: Treating
zeroes as data is fine. While we try to invalidate the cache on zero
writes and discards, such incongruences may still occur when there are
other processes writing to the image.)
We only use the cache for nodes without children (i.e. protocol nodes),
because that is where the problem is: Drivers that rely on block-status
implementations outside of qemu (e.g. SEEK_DATA/HOLE).
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/307
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20210812084148.14458-3-hreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
[hreitz: Added `local_file == bs` assertion, as suggested by Vladimir]
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2021-08-12 11:41:44 +03:00
|
|
|
*/
|
2022-01-18 19:59:59 +03:00
|
|
|
if (want_zero &&
|
|
|
|
ret == (BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID) &&
|
block: block-status cache for data regions
As we have attempted before
(https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06451.html,
"file-posix: Cache lseek result for data regions";
https://lists.nongnu.org/archive/html/qemu-block/2021-02/msg00934.html,
"file-posix: Cache next hole"), this patch seeks to reduce the number of
SEEK_DATA/HOLE operations the file-posix driver has to perform. The
main difference is that this time it is implemented as part of the
general block layer code.
The problem we face is that on some filesystems or in some
circumstances, SEEK_DATA/HOLE is unreasonably slow. Given the
implementation is outside of qemu, there is little we can do about its
performance.
We have already introduced the want_zero parameter to
bdrv_co_block_status() to reduce the number of SEEK_DATA/HOLE calls
unless we really want zero information; but sometimes we do want that
information, because for files that consist largely of zero areas,
special-casing those areas can give large performance boosts. So the
real problem is with files that consist largely of data, so that
inquiring the block status does not gain us much performance, but where
such an inquiry itself takes a lot of time.
To address this, we want to cache data regions. Most of the time, when
bad performance is reported, it is in places where the image is iterated
over from start to end (qemu-img convert or the mirror job), so a simple
yet effective solution is to cache only the current data region.
(Note that only caching data regions but not zero regions means that
returning false information from the cache is not catastrophic: Treating
zeroes as data is fine. While we try to invalidate the cache on zero
writes and discards, such incongruences may still occur when there are
other processes writing to the image.)
We only use the cache for nodes without children (i.e. protocol nodes),
because that is where the problem is: Drivers that rely on block-status
implementations outside of qemu (e.g. SEEK_DATA/HOLE).
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/307
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20210812084148.14458-3-hreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
[hreitz: Added `local_file == bs` assertion, as suggested by Vladimir]
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2021-08-12 11:41:44 +03:00
|
|
|
QLIST_EMPTY(&bs->children))
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* When a protocol driver reports BLOCK_OFFSET_VALID, the
|
|
|
|
* returned local_map value must be the same as the offset we
|
|
|
|
* have passed (aligned_offset), and local_bs must be the node
|
|
|
|
* itself.
|
|
|
|
* Assert this, because we follow this rule when reading from
|
|
|
|
* the cache (see the `local_file = bs` and
|
|
|
|
* `local_map = aligned_offset` assignments above), and the
|
|
|
|
* result the cache delivers must be the same as the driver
|
|
|
|
* would deliver.
|
|
|
|
*/
|
|
|
|
assert(local_file == bs);
|
|
|
|
assert(local_map == aligned_offset);
|
|
|
|
bdrv_bsc_fill(bs, aligned_offset, *pnum);
|
|
|
|
}
|
|
|
|
}
|
2019-02-13 20:05:23 +03:00
|
|
|
} else {
|
|
|
|
/* Default code for filters */
|
|
|
|
|
|
|
|
local_file = bdrv_filter_bs(bs);
|
|
|
|
assert(local_file);
|
|
|
|
|
|
|
|
*pnum = aligned_bytes;
|
|
|
|
local_map = aligned_offset;
|
|
|
|
ret = BDRV_BLOCK_RAW | BDRV_BLOCK_OFFSET_VALID;
|
|
|
|
}
|
2018-02-13 23:27:01 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
*pnum = 0;
|
|
|
|
goto out;
|
2017-10-12 06:47:17 +03:00
|
|
|
}
|
|
|
|
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
/*
|
2018-02-13 23:27:01 +03:00
|
|
|
* The driver's result must be a non-zero multiple of request_alignment.
|
2017-10-12 06:47:17 +03:00
|
|
|
* Clamp pnum and adjust map to original request.
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
*/
|
2018-02-13 23:27:01 +03:00
|
|
|
assert(*pnum && QEMU_IS_ALIGNED(*pnum, align) &&
|
|
|
|
align > offset - aligned_offset);
|
block: avoid recursive block_status call if possible
drv_co_block_status digs bs->file for additional, more accurate search
for hole inside region, reported as DATA by bs since 5daa74a6ebc.
This accuracy is not free: assume we have qcow2 disk. Actually, qcow2
knows, where are holes and where is data. But every block_status
request calls lseek additionally. Assume a big disk, full of
data, in any iterative copying block job (or img convert) we'll call
lseek(HOLE) on every iteration, and each of these lseeks will have to
iterate through all metadata up to the end of file. It's obviously
ineffective behavior. And for many scenarios we don't need this lseek
at all.
However, lseek is needed when we have metadata-preallocated image.
So, let's detect metadata-preallocation case and don't dig qcow2's
protocol file in other cases.
The idea is to compare allocation size in POV of filesystem with
allocations size in POV of Qcow2 (by refcounts). If allocation in fs is
significantly lower, consider it as metadata-preallocation case.
102 iotest changed, as our detector can't detect shrinked file as
metadata-preallocation, which don't seem to be wrong, as with metadata
preallocation we always have valid file length.
Two other iotests have a slight change in their QMP output sequence:
Active 'block-commit' returns earlier because the job coroutine yields
earlier on a blocking operation. This operation is loading the refcount
blocks in qcow2_detect_metadata_preallocation().
Suggested-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2019-04-08 19:26:17 +03:00
|
|
|
if (ret & BDRV_BLOCK_RECURSE) {
|
|
|
|
assert(ret & BDRV_BLOCK_DATA);
|
|
|
|
assert(ret & BDRV_BLOCK_OFFSET_VALID);
|
|
|
|
assert(!(ret & BDRV_BLOCK_ZERO));
|
|
|
|
}
|
|
|
|
|
2017-10-12 06:47:17 +03:00
|
|
|
*pnum -= offset - aligned_offset;
|
|
|
|
if (*pnum > bytes) {
|
|
|
|
*pnum = bytes;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
if (ret & BDRV_BLOCK_OFFSET_VALID) {
|
2017-10-12 06:47:17 +03:00
|
|
|
local_map += offset - aligned_offset;
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
|
|
|
|
if (ret & BDRV_BLOCK_RAW) {
|
2017-10-12 06:46:57 +03:00
|
|
|
assert(ret & BDRV_BLOCK_OFFSET_VALID && local_file);
|
2023-09-04 13:03:03 +03:00
|
|
|
ret = bdrv_co_do_block_status(local_file, want_zero, local_map,
|
|
|
|
*pnum, pnum, &local_map, &local_file);
|
2016-10-27 13:48:52 +03:00
|
|
|
goto out;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (ret & (BDRV_BLOCK_DATA | BDRV_BLOCK_ZERO)) {
|
|
|
|
ret |= BDRV_BLOCK_ALLOCATED;
|
2020-10-26 19:58:26 +03:00
|
|
|
} else if (bs->drv->supports_backing) {
|
2019-06-12 18:59:07 +03:00
|
|
|
BlockDriverState *cow_bs = bdrv_cow_bs(bs);
|
|
|
|
|
2020-10-26 19:58:26 +03:00
|
|
|
if (!cow_bs) {
|
|
|
|
ret |= BDRV_BLOCK_ZERO;
|
|
|
|
} else if (want_zero) {
|
2023-06-01 14:51:44 +03:00
|
|
|
int64_t size2 = bdrv_co_getlength(cow_bs);
|
block: Add flag to avoid wasted work in bdrv_is_allocated()
Not all callers care about which BDS owns the mapping for a given
range of the file, or where the zeroes lie within that mapping. In
particular, bdrv_is_allocated() cares more about finding the
largest run of allocated data from the guest perspective, whether
or not that data is consecutive from the host perspective, and
whether or not the data reads as zero. Therefore, doing subsequent
refinements such as checking how much of the format-layer
allocation also satisfies BDRV_BLOCK_ZERO at the protocol layer is
wasted work - in the best case, it just costs extra CPU cycles
during a single bdrv_is_allocated(), but in the worst case, it
results in a smaller *pnum, and forces callers to iterate through
more status probes when visiting the entire file for even more
extra CPU cycles.
This patch only optimizes the block layer (no behavior change when
want_zero is true, but skip unnecessary effort when it is false).
Then when subsequent patches tweak the driver callback to be
byte-based, we can also pass this hint through to the driver.
Tweak BdrvCoGetBlockStatusData to declare arguments in parameter
order, rather than mixing things up (minimizing padding is not
necessary here).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:46:58 +03:00
|
|
|
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
if (size2 >= 0 && offset >= size2) {
|
2015-04-28 16:27:52 +03:00
|
|
|
ret |= BDRV_BLOCK_ZERO;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
block: avoid recursive block_status call if possible
drv_co_block_status digs bs->file for additional, more accurate search
for hole inside region, reported as DATA by bs since 5daa74a6ebc.
This accuracy is not free: assume we have qcow2 disk. Actually, qcow2
knows, where are holes and where is data. But every block_status
request calls lseek additionally. Assume a big disk, full of
data, in any iterative copying block job (or img convert) we'll call
lseek(HOLE) on every iteration, and each of these lseeks will have to
iterate through all metadata up to the end of file. It's obviously
ineffective behavior. And for many scenarios we don't need this lseek
at all.
However, lseek is needed when we have metadata-preallocated image.
So, let's detect metadata-preallocation case and don't dig qcow2's
protocol file in other cases.
The idea is to compare allocation size in POV of filesystem with
allocations size in POV of Qcow2 (by refcounts). If allocation in fs is
significantly lower, consider it as metadata-preallocation case.
102 iotest changed, as our detector can't detect shrinked file as
metadata-preallocation, which don't seem to be wrong, as with metadata
preallocation we always have valid file length.
Two other iotests have a slight change in their QMP output sequence:
Active 'block-commit' returns earlier because the job coroutine yields
earlier on a blocking operation. This operation is loading the refcount
blocks in qcow2_detect_metadata_preallocation().
Suggested-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2019-04-08 19:26:17 +03:00
|
|
|
if (want_zero && ret & BDRV_BLOCK_RECURSE &&
|
|
|
|
local_file && local_file != bs &&
|
2015-04-28 16:27:52 +03:00
|
|
|
(ret & BDRV_BLOCK_DATA) && !(ret & BDRV_BLOCK_ZERO) &&
|
|
|
|
(ret & BDRV_BLOCK_OFFSET_VALID)) {
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
int64_t file_pnum;
|
|
|
|
int ret2;
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2023-09-04 13:03:03 +03:00
|
|
|
ret2 = bdrv_co_do_block_status(local_file, want_zero, local_map,
|
|
|
|
*pnum, &file_pnum, NULL, NULL);
|
2015-04-28 16:27:52 +03:00
|
|
|
if (ret2 >= 0) {
|
|
|
|
/* Ignore errors. This is just providing extra information, it
|
|
|
|
* is useful but not necessary.
|
|
|
|
*/
|
block: Exploit BDRV_BLOCK_EOF for larger zero blocks
When we have a BDS with unallocated clusters, but asking the status
of its underlying bs->file or backing layer encounters an end-of-file
condition, we know that the rest of the unallocated area will read as
zeroes. However, pre-patch, this required two separate calls to
bdrv_get_block_status(), as the first call stops at the point where
the underlying file ends. Thanks to BDRV_BLOCK_EOF, we can now widen
the results of the primary status if the secondary status already
includes BDRV_BLOCK_ZERO.
In turn, this fixes a TODO mentioned in iotest 154, where we can now
see that all sectors in a partial cluster at the end of a file read
as zero when coupling the shorter backing file's status along with our
knowledge that the remaining sectors came from an unallocated cluster.
Also, note that the loop in bdrv_co_get_block_status_above() had an
inefficent exit: in cases where the active layer sets BDRV_BLOCK_ZERO
but does NOT set BDRV_BLOCK_ALLOCATED (namely, where we know we read
zeroes merely because our unallocated clusters lie beyond the backing
file's shorter length), we still ended up probing the backing layer
even though we already had a good answer.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20170505021500.19315-3-eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
2017-05-05 05:15:00 +03:00
|
|
|
if (ret2 & BDRV_BLOCK_EOF &&
|
|
|
|
(!file_pnum || ret2 & BDRV_BLOCK_ZERO)) {
|
|
|
|
/*
|
|
|
|
* It is valid for the format block driver to read
|
|
|
|
* beyond the end of the underlying file's current
|
|
|
|
* size; such areas read as zero.
|
|
|
|
*/
|
2015-04-28 16:27:52 +03:00
|
|
|
ret |= BDRV_BLOCK_ZERO;
|
|
|
|
} else {
|
|
|
|
/* Limit request to the range reported by the protocol driver */
|
|
|
|
*pnum = file_pnum;
|
|
|
|
ret |= (ret2 & BDRV_BLOCK_ZERO);
|
|
|
|
}
|
|
|
|
}
|
block/io: clear BDRV_BLOCK_RECURSE flag after recursing in bdrv_co_block_status
Using fleecing backup like in [0] on a qcow2 image (with metadata
preallocation) can lead to the following assertion failure:
> bdrv_co_do_block_status: Assertion `!(ret & BDRV_BLOCK_ZERO)' failed.
In the reproducer [0], it happens because the BDRV_BLOCK_RECURSE flag
will be set by the qcow2 driver, so the caller will recursively check
the file child. Then the BDRV_BLOCK_ZERO set too. Later up the call
chain, in bdrv_co_do_block_status() for the snapshot-access driver,
the assertion failure will happen, because both flags are set.
To fix it, clear the recurse flag after the recursive check was done.
In detail:
> #0 qcow2_co_block_status
Returns 0x45 = BDRV_BLOCK_RECURSE | BDRV_BLOCK_DATA |
BDRV_BLOCK_OFFSET_VALID.
> #1 bdrv_co_do_block_status
Because of the data flag, bdrv_co_do_block_status() will now also set
BDRV_BLOCK_ALLOCATED. Because of the recurse flag,
bdrv_co_do_block_status() for the bdrv_file child will be called,
which returns 0x16 = BDRV_BLOCK_ALLOCATED | BDRV_BLOCK_OFFSET_VALID |
BDRV_BLOCK_ZERO. Now the return value inherits the zero flag.
Returns 0x57 = BDRV_BLOCK_RECURSE | BDRV_BLOCK_DATA |
BDRV_BLOCK_OFFSET_VALID | BDRV_BLOCK_ALLOCATED | BDRV_BLOCK_ZERO.
> #2 bdrv_co_common_block_status_above
> #3 bdrv_co_block_status_above
> #4 bdrv_co_block_status
> #5 cbw_co_snapshot_block_status
> #6 bdrv_co_snapshot_block_status
> #7 snapshot_access_co_block_status
> #8 bdrv_co_do_block_status
Return value is propagated all the way up to here, where the assertion
failure happens, because BDRV_BLOCK_RECURSE and BDRV_BLOCK_ZERO are
both set.
> #9 bdrv_co_common_block_status_above
> #10 bdrv_co_block_status_above
> #11 block_copy_block_status
> #12 block_copy_dirty_clusters
> #13 block_copy_common
> #14 block_copy_async_co_entry
> #15 coroutine_trampoline
[0]:
> #!/bin/bash
> rm /tmp/disk.qcow2
> ./qemu-img create /tmp/disk.qcow2 -o preallocation=metadata -f qcow2 1G
> ./qemu-img create /tmp/fleecing.qcow2 -f qcow2 1G
> ./qemu-img create /tmp/backup.qcow2 -f qcow2 1G
> ./qemu-system-x86_64 --qmp stdio \
> --blockdev qcow2,node-name=node0,file.driver=file,file.filename=/tmp/disk.qcow2 \
> --blockdev qcow2,node-name=node1,file.driver=file,file.filename=/tmp/fleecing.qcow2 \
> --blockdev qcow2,node-name=node2,file.driver=file,file.filename=/tmp/backup.qcow2 \
> <<EOF
> {"execute": "qmp_capabilities"}
> {"execute": "blockdev-add", "arguments": { "driver": "copy-before-write", "file": "node0", "target": "node1", "node-name": "node3" } }
> {"execute": "blockdev-add", "arguments": { "driver": "snapshot-access", "file": "node3", "node-name": "snap0" } }
> {"execute": "blockdev-backup", "arguments": { "device": "snap0", "target": "node1", "sync": "full", "job-id": "backup0" } }
> EOF
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-id: 20240116154839.401030-1-f.ebner@proxmox.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2024-01-16 18:48:39 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Now that the recursive search was done, clear the flag. Otherwise,
|
|
|
|
* with more complicated block graphs like snapshot-access ->
|
|
|
|
* copy-before-write -> qcow2, where the return value will be propagated
|
|
|
|
* further up to a parent bdrv_co_do_block_status() call, both the
|
|
|
|
* BDRV_BLOCK_RECURSE and BDRV_BLOCK_ZERO flags would be set, which is
|
|
|
|
* not allowed.
|
|
|
|
*/
|
|
|
|
ret &= ~BDRV_BLOCK_RECURSE;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2016-10-27 13:48:52 +03:00
|
|
|
out:
|
|
|
|
bdrv_dec_in_flight(bs);
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
if (ret >= 0 && offset + *pnum == total_size) {
|
2017-05-05 05:14:59 +03:00
|
|
|
ret |= BDRV_BLOCK_EOF;
|
|
|
|
}
|
2017-10-12 06:46:57 +03:00
|
|
|
early_out:
|
|
|
|
if (file) {
|
|
|
|
*file = local_file;
|
|
|
|
}
|
block: Switch bdrv_co_get_block_status() to byte-based
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compiler enforce that we catch all uses. For now, we
assert that callers and the return value still use aligned data,
but ultimately, this will be the function where we hand off to a
byte-based driver callback, and will eventually need to add logic
to ensure we round calls according to the driver's
request_alignment then touch up the result handed back to the
caller, to start permitting a caller to pass unaligned offsets.
Note that we are now prepared to accepts 'bytes' larger than INT_MAX;
this is okay as long as we clamp things internally before violating
any 32-bit limits, and makes no difference to how a client will
use the information (clients looping over the entire file must
already be prepared for consecutive calls to return the same status,
as drivers are already free to return shorter-than-maximal status
due to any other convenient split points, such as when the L2 table
crosses cluster boundaries in qcow2).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:47:04 +03:00
|
|
|
if (map) {
|
|
|
|
*map = local_map;
|
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2020-09-24 21:54:10 +03:00
|
|
|
int coroutine_fn
|
2020-09-24 21:54:09 +03:00
|
|
|
bdrv_co_common_block_status_above(BlockDriverState *bs,
|
|
|
|
BlockDriverState *base,
|
2020-09-24 22:40:00 +03:00
|
|
|
bool include_base,
|
2020-09-24 21:54:09 +03:00
|
|
|
bool want_zero,
|
|
|
|
int64_t offset,
|
|
|
|
int64_t bytes,
|
|
|
|
int64_t *pnum,
|
|
|
|
int64_t *map,
|
2020-10-27 08:05:53 +03:00
|
|
|
BlockDriverState **file,
|
|
|
|
int *depth)
|
2015-06-08 08:56:07 +03:00
|
|
|
{
|
2020-09-24 22:39:59 +03:00
|
|
|
int ret;
|
2015-06-08 08:56:07 +03:00
|
|
|
BlockDriverState *p;
|
2020-09-24 22:39:59 +03:00
|
|
|
int64_t eof = 0;
|
2020-10-27 08:05:53 +03:00
|
|
|
int dummy;
|
2022-03-03 18:16:09 +03:00
|
|
|
IO_CODE();
|
2015-06-08 08:56:07 +03:00
|
|
|
|
2020-09-24 22:40:00 +03:00
|
|
|
assert(!include_base || base); /* Can't include NULL base */
|
2023-02-03 18:21:43 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2020-09-24 22:39:59 +03:00
|
|
|
|
2020-10-27 08:05:53 +03:00
|
|
|
if (!depth) {
|
|
|
|
depth = &dummy;
|
|
|
|
}
|
|
|
|
*depth = 0;
|
|
|
|
|
2020-09-24 22:40:01 +03:00
|
|
|
if (!include_base && bs == base) {
|
|
|
|
*pnum = bytes;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2023-09-04 13:03:03 +03:00
|
|
|
ret = bdrv_co_do_block_status(bs, want_zero, offset, bytes, pnum,
|
|
|
|
map, file);
|
2020-10-27 08:05:53 +03:00
|
|
|
++*depth;
|
2020-09-24 22:40:00 +03:00
|
|
|
if (ret < 0 || *pnum == 0 || ret & BDRV_BLOCK_ALLOCATED || bs == base) {
|
2020-09-24 22:39:59 +03:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ret & BDRV_BLOCK_EOF) {
|
|
|
|
eof = offset + *pnum;
|
|
|
|
}
|
|
|
|
|
|
|
|
assert(*pnum <= bytes);
|
|
|
|
bytes = *pnum;
|
|
|
|
|
2020-09-24 22:40:00 +03:00
|
|
|
for (p = bdrv_filter_or_cow_bs(bs); include_base || p != base;
|
2020-09-24 22:39:59 +03:00
|
|
|
p = bdrv_filter_or_cow_bs(p))
|
|
|
|
{
|
2023-09-04 13:03:03 +03:00
|
|
|
ret = bdrv_co_do_block_status(p, want_zero, offset, bytes, pnum,
|
|
|
|
map, file);
|
2020-10-27 08:05:53 +03:00
|
|
|
++*depth;
|
block: Exploit BDRV_BLOCK_EOF for larger zero blocks
When we have a BDS with unallocated clusters, but asking the status
of its underlying bs->file or backing layer encounters an end-of-file
condition, we know that the rest of the unallocated area will read as
zeroes. However, pre-patch, this required two separate calls to
bdrv_get_block_status(), as the first call stops at the point where
the underlying file ends. Thanks to BDRV_BLOCK_EOF, we can now widen
the results of the primary status if the secondary status already
includes BDRV_BLOCK_ZERO.
In turn, this fixes a TODO mentioned in iotest 154, where we can now
see that all sectors in a partial cluster at the end of a file read
as zero when coupling the shorter backing file's status along with our
knowledge that the remaining sectors came from an unallocated cluster.
Also, note that the loop in bdrv_co_get_block_status_above() had an
inefficent exit: in cases where the active layer sets BDRV_BLOCK_ZERO
but does NOT set BDRV_BLOCK_ALLOCATED (namely, where we know we read
zeroes merely because our unallocated clusters lie beyond the backing
file's shorter length), we still ended up probing the backing layer
even though we already had a good answer.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20170505021500.19315-3-eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
2017-05-05 05:15:00 +03:00
|
|
|
if (ret < 0) {
|
2020-09-24 22:39:59 +03:00
|
|
|
return ret;
|
block: Exploit BDRV_BLOCK_EOF for larger zero blocks
When we have a BDS with unallocated clusters, but asking the status
of its underlying bs->file or backing layer encounters an end-of-file
condition, we know that the rest of the unallocated area will read as
zeroes. However, pre-patch, this required two separate calls to
bdrv_get_block_status(), as the first call stops at the point where
the underlying file ends. Thanks to BDRV_BLOCK_EOF, we can now widen
the results of the primary status if the secondary status already
includes BDRV_BLOCK_ZERO.
In turn, this fixes a TODO mentioned in iotest 154, where we can now
see that all sectors in a partial cluster at the end of a file read
as zero when coupling the shorter backing file's status along with our
knowledge that the remaining sectors came from an unallocated cluster.
Also, note that the loop in bdrv_co_get_block_status_above() had an
inefficent exit: in cases where the active layer sets BDRV_BLOCK_ZERO
but does NOT set BDRV_BLOCK_ALLOCATED (namely, where we know we read
zeroes merely because our unallocated clusters lie beyond the backing
file's shorter length), we still ended up probing the backing layer
even though we already had a good answer.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20170505021500.19315-3-eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
2017-05-05 05:15:00 +03:00
|
|
|
}
|
2020-09-24 22:39:59 +03:00
|
|
|
if (*pnum == 0) {
|
block: Exploit BDRV_BLOCK_EOF for larger zero blocks
When we have a BDS with unallocated clusters, but asking the status
of its underlying bs->file or backing layer encounters an end-of-file
condition, we know that the rest of the unallocated area will read as
zeroes. However, pre-patch, this required two separate calls to
bdrv_get_block_status(), as the first call stops at the point where
the underlying file ends. Thanks to BDRV_BLOCK_EOF, we can now widen
the results of the primary status if the secondary status already
includes BDRV_BLOCK_ZERO.
In turn, this fixes a TODO mentioned in iotest 154, where we can now
see that all sectors in a partial cluster at the end of a file read
as zero when coupling the shorter backing file's status along with our
knowledge that the remaining sectors came from an unallocated cluster.
Also, note that the loop in bdrv_co_get_block_status_above() had an
inefficent exit: in cases where the active layer sets BDRV_BLOCK_ZERO
but does NOT set BDRV_BLOCK_ALLOCATED (namely, where we know we read
zeroes merely because our unallocated clusters lie beyond the backing
file's shorter length), we still ended up probing the backing layer
even though we already had a good answer.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20170505021500.19315-3-eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
2017-05-05 05:15:00 +03:00
|
|
|
/*
|
2020-09-24 22:39:59 +03:00
|
|
|
* The top layer deferred to this layer, and because this layer is
|
|
|
|
* short, any zeroes that we synthesize beyond EOF behave as if they
|
|
|
|
* were allocated at this layer.
|
|
|
|
*
|
|
|
|
* We don't include BDRV_BLOCK_EOF into ret, as upper layer may be
|
|
|
|
* larger. We'll add BDRV_BLOCK_EOF if needed at function end, see
|
|
|
|
* below.
|
block: Exploit BDRV_BLOCK_EOF for larger zero blocks
When we have a BDS with unallocated clusters, but asking the status
of its underlying bs->file or backing layer encounters an end-of-file
condition, we know that the rest of the unallocated area will read as
zeroes. However, pre-patch, this required two separate calls to
bdrv_get_block_status(), as the first call stops at the point where
the underlying file ends. Thanks to BDRV_BLOCK_EOF, we can now widen
the results of the primary status if the secondary status already
includes BDRV_BLOCK_ZERO.
In turn, this fixes a TODO mentioned in iotest 154, where we can now
see that all sectors in a partial cluster at the end of a file read
as zero when coupling the shorter backing file's status along with our
knowledge that the remaining sectors came from an unallocated cluster.
Also, note that the loop in bdrv_co_get_block_status_above() had an
inefficent exit: in cases where the active layer sets BDRV_BLOCK_ZERO
but does NOT set BDRV_BLOCK_ALLOCATED (namely, where we know we read
zeroes merely because our unallocated clusters lie beyond the backing
file's shorter length), we still ended up probing the backing layer
even though we already had a good answer.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20170505021500.19315-3-eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
2017-05-05 05:15:00 +03:00
|
|
|
*/
|
2020-09-24 22:39:59 +03:00
|
|
|
assert(ret & BDRV_BLOCK_EOF);
|
2017-10-12 06:47:07 +03:00
|
|
|
*pnum = bytes;
|
2020-09-24 22:39:59 +03:00
|
|
|
if (file) {
|
|
|
|
*file = p;
|
|
|
|
}
|
|
|
|
ret = BDRV_BLOCK_ZERO | BDRV_BLOCK_ALLOCATED;
|
|
|
|
break;
|
block: Exploit BDRV_BLOCK_EOF for larger zero blocks
When we have a BDS with unallocated clusters, but asking the status
of its underlying bs->file or backing layer encounters an end-of-file
condition, we know that the rest of the unallocated area will read as
zeroes. However, pre-patch, this required two separate calls to
bdrv_get_block_status(), as the first call stops at the point where
the underlying file ends. Thanks to BDRV_BLOCK_EOF, we can now widen
the results of the primary status if the secondary status already
includes BDRV_BLOCK_ZERO.
In turn, this fixes a TODO mentioned in iotest 154, where we can now
see that all sectors in a partial cluster at the end of a file read
as zero when coupling the shorter backing file's status along with our
knowledge that the remaining sectors came from an unallocated cluster.
Also, note that the loop in bdrv_co_get_block_status_above() had an
inefficent exit: in cases where the active layer sets BDRV_BLOCK_ZERO
but does NOT set BDRV_BLOCK_ALLOCATED (namely, where we know we read
zeroes merely because our unallocated clusters lie beyond the backing
file's shorter length), we still ended up probing the backing layer
even though we already had a good answer.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20170505021500.19315-3-eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
2017-05-05 05:15:00 +03:00
|
|
|
}
|
2020-09-24 22:39:59 +03:00
|
|
|
if (ret & BDRV_BLOCK_ALLOCATED) {
|
|
|
|
/*
|
|
|
|
* We've found the node and the status, we must break.
|
|
|
|
*
|
|
|
|
* Drop BDRV_BLOCK_EOF, as it's not for upper layer, which may be
|
|
|
|
* larger. We'll add BDRV_BLOCK_EOF if needed at function end, see
|
|
|
|
* below.
|
|
|
|
*/
|
|
|
|
ret &= ~BDRV_BLOCK_EOF;
|
2015-06-08 08:56:07 +03:00
|
|
|
break;
|
|
|
|
}
|
2020-09-24 22:39:59 +03:00
|
|
|
|
2020-09-24 22:40:00 +03:00
|
|
|
if (p == base) {
|
|
|
|
assert(include_base);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2020-09-24 22:39:59 +03:00
|
|
|
/*
|
|
|
|
* OK, [offset, offset + *pnum) region is unallocated on this layer,
|
|
|
|
* let's continue the diving.
|
|
|
|
*/
|
|
|
|
assert(*pnum <= bytes);
|
|
|
|
bytes = *pnum;
|
2015-06-08 08:56:07 +03:00
|
|
|
}
|
2020-09-24 22:39:59 +03:00
|
|
|
|
|
|
|
if (offset + *pnum == eof) {
|
|
|
|
ret |= BDRV_BLOCK_EOF;
|
|
|
|
}
|
|
|
|
|
2015-06-08 08:56:07 +03:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2022-11-28 17:23:24 +03:00
|
|
|
int coroutine_fn bdrv_co_block_status_above(BlockDriverState *bs,
|
|
|
|
BlockDriverState *base,
|
|
|
|
int64_t offset, int64_t bytes,
|
|
|
|
int64_t *pnum, int64_t *map,
|
|
|
|
BlockDriverState **file)
|
|
|
|
{
|
|
|
|
IO_CODE();
|
|
|
|
return bdrv_co_common_block_status_above(bs, base, false, true, offset,
|
|
|
|
bytes, pnum, map, file, NULL);
|
|
|
|
}
|
|
|
|
|
2023-09-04 13:03:04 +03:00
|
|
|
int coroutine_fn bdrv_co_block_status(BlockDriverState *bs, int64_t offset,
|
|
|
|
int64_t bytes, int64_t *pnum,
|
|
|
|
int64_t *map, BlockDriverState **file)
|
block: Add flag to avoid wasted work in bdrv_is_allocated()
Not all callers care about which BDS owns the mapping for a given
range of the file, or where the zeroes lie within that mapping. In
particular, bdrv_is_allocated() cares more about finding the
largest run of allocated data from the guest perspective, whether
or not that data is consecutive from the host perspective, and
whether or not the data reads as zero. Therefore, doing subsequent
refinements such as checking how much of the format-layer
allocation also satisfies BDRV_BLOCK_ZERO at the protocol layer is
wasted work - in the best case, it just costs extra CPU cycles
during a single bdrv_is_allocated(), but in the worst case, it
results in a smaller *pnum, and forces callers to iterate through
more status probes when visiting the entire file for even more
extra CPU cycles.
This patch only optimizes the block layer (no behavior change when
want_zero is true, but skip unnecessary effort when it is false).
Then when subsequent patches tweak the driver callback to be
byte-based, we can also pass this hint through to the driver.
Tweak BdrvCoGetBlockStatusData to declare arguments in parameter
order, rather than mixing things up (minimizing padding is not
necessary here).
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 06:46:58 +03:00
|
|
|
{
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2023-09-04 13:03:04 +03:00
|
|
|
return bdrv_co_block_status_above(bs, bdrv_filter_or_cow_bs(bs),
|
|
|
|
offset, bytes, pnum, map, file);
|
2015-06-08 08:56:07 +03:00
|
|
|
}
|
|
|
|
|
2020-10-26 19:58:27 +03:00
|
|
|
/*
|
|
|
|
* Check @bs (and its backing chain) to see if the range defined
|
|
|
|
* by @offset and @bytes is known to read as zeroes.
|
|
|
|
* Return 1 if that is the case, 0 otherwise and -errno on error.
|
|
|
|
* This test is meant to be fast rather than accurate so returning 0
|
|
|
|
* does not guarantee non-zero data.
|
|
|
|
*/
|
|
|
|
int coroutine_fn bdrv_co_is_zero_fast(BlockDriverState *bs, int64_t offset,
|
|
|
|
int64_t bytes)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
int64_t pnum = bytes;
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2020-10-26 19:58:27 +03:00
|
|
|
|
|
|
|
if (!bytes) {
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2022-10-13 15:37:02 +03:00
|
|
|
ret = bdrv_co_common_block_status_above(bs, NULL, false, false, offset,
|
|
|
|
bytes, &pnum, NULL, NULL, NULL);
|
2020-10-26 19:58:27 +03:00
|
|
|
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
return (pnum == bytes) && (ret & BDRV_BLOCK_ZERO);
|
|
|
|
}
|
|
|
|
|
2022-11-28 17:23:24 +03:00
|
|
|
int coroutine_fn bdrv_co_is_allocated(BlockDriverState *bs, int64_t offset,
|
|
|
|
int64_t bytes, int64_t *pnum)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
int64_t dummy;
|
|
|
|
IO_CODE();
|
|
|
|
|
|
|
|
ret = bdrv_co_common_block_status_above(bs, bs, true, false, offset,
|
|
|
|
bytes, pnum ? pnum : &dummy, NULL,
|
|
|
|
NULL, NULL);
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
return !!(ret & BDRV_BLOCK_ALLOCATED);
|
|
|
|
}
|
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
/*
|
|
|
|
* Given an image chain: ... -> [BASE] -> [INTER1] -> [INTER2] -> [TOP]
|
|
|
|
*
|
2020-10-27 08:05:53 +03:00
|
|
|
* Return a positive depth if (a prefix of) the given range is allocated
|
|
|
|
* in any image between BASE and TOP (BASE is only included if include_base
|
|
|
|
* is set). Depth 1 is TOP, 2 is the first backing layer, and so forth.
|
2019-05-29 20:56:14 +03:00
|
|
|
* BASE can be NULL to check if the given offset is allocated in any
|
|
|
|
* image of the chain. Return 0 otherwise, or negative errno on
|
|
|
|
* failure.
|
2015-04-28 16:27:52 +03:00
|
|
|
*
|
block: Make bdrv_is_allocated_above() byte-based
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end of an unaligned file that can do byte-based access.
Changing the signature of the function to use int64_t *pnum ensures
that the compiler enforces that all callers are updated. For now,
the io.c layer still assert()s that all callers are sector-aligned,
but that can be relaxed when a later patch implements byte-based
block status. Therefore, for the most part this patch is just the
addition of scaling at the callers followed by inverse scaling at
bdrv_is_allocated(). But some code, particularly stream_run(),
gets a lot simpler because it no longer has to mess with sectors.
Leave comments where we can further simplify by switching to
byte-based iterations, once later patches eliminate the need for
sector-aligned operations.
For ease of review, bdrv_is_allocated() was tackled separately.
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-07-07 15:44:59 +03:00
|
|
|
* 'pnum' is set to the number of bytes (including and immediately
|
|
|
|
* following the specified offset) that are known to be in the same
|
|
|
|
* allocated/unallocated state. Note that a subsequent call starting
|
|
|
|
* at 'offset + *pnum' may return the same allocation status (in other
|
|
|
|
* words, the result is not necessarily the maximum possible range);
|
|
|
|
* but 'pnum' will only be 0 when end of file is reached.
|
2015-04-28 16:27:52 +03:00
|
|
|
*/
|
2023-09-04 13:03:05 +03:00
|
|
|
int coroutine_fn bdrv_co_is_allocated_above(BlockDriverState *bs,
|
|
|
|
BlockDriverState *base,
|
|
|
|
bool include_base, int64_t offset,
|
|
|
|
int64_t bytes, int64_t *pnum)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2020-10-27 08:05:53 +03:00
|
|
|
int depth;
|
2022-11-28 17:23:24 +03:00
|
|
|
int ret;
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2022-11-28 17:23:24 +03:00
|
|
|
|
2023-09-04 13:03:05 +03:00
|
|
|
ret = bdrv_co_common_block_status_above(bs, base, include_base, false,
|
|
|
|
offset, bytes, pnum, NULL, NULL,
|
|
|
|
&depth);
|
2020-09-24 22:40:02 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2020-10-27 08:05:53 +03:00
|
|
|
if (ret & BDRV_BLOCK_ALLOCATED) {
|
|
|
|
return depth;
|
|
|
|
}
|
|
|
|
return 0;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2020-09-24 21:54:10 +03:00
|
|
|
int coroutine_fn
|
2020-09-24 21:54:14 +03:00
|
|
|
bdrv_co_readv_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, int64_t pos)
|
2016-06-09 17:24:44 +03:00
|
|
|
{
|
|
|
|
BlockDriver *drv = bs->drv;
|
2019-06-12 19:17:06 +03:00
|
|
|
BlockDriverState *child_bs = bdrv_primary_bs(bs);
|
2021-09-03 13:27:57 +03:00
|
|
|
int ret;
|
2022-03-03 18:16:09 +03:00
|
|
|
IO_CODE();
|
2022-12-07 16:18:38 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2021-09-03 13:27:57 +03:00
|
|
|
|
|
|
|
ret = bdrv_check_qiov_request(pos, qiov->size, qiov, 0, NULL);
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
2017-05-22 16:57:01 +03:00
|
|
|
|
2020-09-24 21:54:14 +03:00
|
|
|
if (!drv) {
|
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
|
2017-05-22 16:57:01 +03:00
|
|
|
bdrv_inc_in_flight(bs);
|
2016-06-09 17:24:44 +03:00
|
|
|
|
2023-01-13 23:42:12 +03:00
|
|
|
if (drv->bdrv_co_load_vmstate) {
|
|
|
|
ret = drv->bdrv_co_load_vmstate(bs, qiov, pos);
|
2019-06-12 19:17:06 +03:00
|
|
|
} else if (child_bs) {
|
2020-09-24 21:54:14 +03:00
|
|
|
ret = bdrv_co_readv_vmstate(child_bs, qiov, pos);
|
2021-09-03 13:27:57 +03:00
|
|
|
} else {
|
|
|
|
ret = -ENOTSUP;
|
2016-06-09 17:24:44 +03:00
|
|
|
}
|
|
|
|
|
2017-05-22 16:57:01 +03:00
|
|
|
bdrv_dec_in_flight(bs);
|
2020-09-24 21:54:14 +03:00
|
|
|
|
2017-05-22 16:57:01 +03:00
|
|
|
return ret;
|
2016-06-09 17:24:44 +03:00
|
|
|
}
|
|
|
|
|
2020-09-24 21:54:14 +03:00
|
|
|
int coroutine_fn
|
|
|
|
bdrv_co_writev_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, int64_t pos)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2020-09-24 21:54:14 +03:00
|
|
|
BlockDriver *drv = bs->drv;
|
|
|
|
BlockDriverState *child_bs = bdrv_primary_bs(bs);
|
2021-09-03 13:27:57 +03:00
|
|
|
int ret;
|
2022-03-03 18:16:09 +03:00
|
|
|
IO_CODE();
|
2022-12-07 16:18:38 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2021-09-03 13:27:57 +03:00
|
|
|
|
|
|
|
ret = bdrv_check_qiov_request(pos, qiov->size, qiov, 0, NULL);
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2020-09-24 21:54:14 +03:00
|
|
|
if (!drv) {
|
|
|
|
return -ENOMEDIUM;
|
2016-06-10 18:57:26 +03:00
|
|
|
}
|
|
|
|
|
2020-09-24 21:54:14 +03:00
|
|
|
bdrv_inc_in_flight(bs);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2023-01-13 23:42:12 +03:00
|
|
|
if (drv->bdrv_co_save_vmstate) {
|
|
|
|
ret = drv->bdrv_co_save_vmstate(bs, qiov, pos);
|
2020-09-24 21:54:14 +03:00
|
|
|
} else if (child_bs) {
|
|
|
|
ret = bdrv_co_writev_vmstate(child_bs, qiov, pos);
|
2021-09-03 13:27:57 +03:00
|
|
|
} else {
|
|
|
|
ret = -ENOTSUP;
|
2020-09-24 21:54:14 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
bdrv_dec_in_flight(bs);
|
|
|
|
|
|
|
|
return ret;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2020-09-24 21:54:14 +03:00
|
|
|
int bdrv_save_vmstate(BlockDriverState *bs, const uint8_t *buf,
|
2015-04-28 16:27:52 +03:00
|
|
|
int64_t pos, int size)
|
2016-06-09 17:50:16 +03:00
|
|
|
{
|
2019-02-18 17:09:11 +03:00
|
|
|
QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, size);
|
2020-09-24 21:54:14 +03:00
|
|
|
int ret = bdrv_writev_vmstate(bs, &qiov, pos);
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2016-06-10 18:57:26 +03:00
|
|
|
|
2020-09-24 21:54:14 +03:00
|
|
|
return ret < 0 ? ret : size;
|
2016-06-09 17:50:16 +03:00
|
|
|
}
|
|
|
|
|
2020-09-24 21:54:14 +03:00
|
|
|
int bdrv_load_vmstate(BlockDriverState *bs, uint8_t *buf,
|
|
|
|
int64_t pos, int size)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2020-09-24 21:54:14 +03:00
|
|
|
QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, size);
|
|
|
|
int ret = bdrv_readv_vmstate(bs, &qiov, pos);
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2020-09-24 21:54:14 +03:00
|
|
|
|
|
|
|
return ret < 0 ? ret : size;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**************************************************************/
|
|
|
|
/* async I/Os */
|
|
|
|
|
2023-09-13 02:10:33 +03:00
|
|
|
/**
|
|
|
|
* Synchronously cancels an acb. Must be called with the BQL held and the acb
|
|
|
|
* must be processed with the BQL held too (IOThreads are not allowed).
|
|
|
|
*
|
|
|
|
* Use bdrv_aio_cancel_async() instead when possible.
|
|
|
|
*/
|
2015-04-28 16:27:52 +03:00
|
|
|
void bdrv_aio_cancel(BlockAIOCB *acb)
|
|
|
|
{
|
2023-09-13 02:10:33 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
2015-04-28 16:27:52 +03:00
|
|
|
qemu_aio_ref(acb);
|
|
|
|
bdrv_aio_cancel_async(acb);
|
2023-09-13 02:10:33 +03:00
|
|
|
AIO_WAIT_WHILE_UNLOCKED(NULL, acb->refcnt > 1);
|
2015-04-28 16:27:52 +03:00
|
|
|
qemu_aio_unref(acb);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Async version of aio cancel. The caller is not blocked if the acb implements
|
|
|
|
* cancel_async, otherwise we do nothing and let the request normally complete.
|
|
|
|
* In either case the completion callback must be called. */
|
|
|
|
void bdrv_aio_cancel_async(BlockAIOCB *acb)
|
|
|
|
{
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2015-04-28 16:27:52 +03:00
|
|
|
if (acb->aiocb_info->cancel_async) {
|
|
|
|
acb->aiocb_info->cancel_async(acb);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**************************************************************/
|
|
|
|
/* Coroutine block device emulation */
|
|
|
|
|
|
|
|
int coroutine_fn bdrv_co_flush(BlockDriverState *bs)
|
|
|
|
{
|
2019-06-12 19:18:05 +03:00
|
|
|
BdrvChild *primary_child = bdrv_primary_child(bs);
|
|
|
|
BdrvChild *child;
|
2017-04-10 16:00:50 +03:00
|
|
|
int current_gen;
|
|
|
|
int ret = 0;
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2017-04-10 16:00:50 +03:00
|
|
|
|
2023-02-03 18:21:46 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2017-04-10 16:00:50 +03:00
|
|
|
bdrv_inc_in_flight(bs);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2023-01-13 23:42:02 +03:00
|
|
|
if (!bdrv_co_is_inserted(bs) || bdrv_is_read_only(bs) ||
|
2015-06-23 13:44:57 +03:00
|
|
|
bdrv_is_sg(bs)) {
|
2017-04-10 16:00:50 +03:00
|
|
|
goto early_exit;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2023-08-08 18:58:52 +03:00
|
|
|
qemu_mutex_lock(&bs->reqs_lock);
|
2020-09-23 13:56:46 +03:00
|
|
|
current_gen = qatomic_read(&bs->write_gen);
|
2016-07-18 22:39:52 +03:00
|
|
|
|
|
|
|
/* Wait until any previous flushes are completed */
|
2016-10-27 13:48:52 +03:00
|
|
|
while (bs->active_flush_req) {
|
2017-06-05 15:39:02 +03:00
|
|
|
qemu_co_queue_wait(&bs->flush_queue, &bs->reqs_lock);
|
2016-07-18 22:39:52 +03:00
|
|
|
}
|
|
|
|
|
2017-06-05 15:39:02 +03:00
|
|
|
/* Flushes reach this point in nondecreasing current_gen order. */
|
2016-10-27 13:48:52 +03:00
|
|
|
bs->active_flush_req = true;
|
2023-08-08 18:58:52 +03:00
|
|
|
qemu_mutex_unlock(&bs->reqs_lock);
|
2016-07-18 22:39:52 +03:00
|
|
|
|
2016-03-14 10:44:53 +03:00
|
|
|
/* Write back all layers by calling one driver function */
|
|
|
|
if (bs->drv->bdrv_co_flush) {
|
|
|
|
ret = bs->drv->bdrv_co_flush(bs);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
/* Write back cached data to the OS even with cache=unsafe */
|
2023-06-01 14:51:45 +03:00
|
|
|
BLKDBG_CO_EVENT(primary_child, BLKDBG_FLUSH_TO_OS);
|
2015-04-28 16:27:52 +03:00
|
|
|
if (bs->drv->bdrv_co_flush_to_os) {
|
|
|
|
ret = bs->drv->bdrv_co_flush_to_os(bs);
|
|
|
|
if (ret < 0) {
|
2015-11-09 13:16:47 +03:00
|
|
|
goto out;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* But don't actually force it to the disk with cache=unsafe */
|
|
|
|
if (bs->open_flags & BDRV_O_NO_FLUSH) {
|
2019-06-12 19:18:05 +03:00
|
|
|
goto flush_children;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2016-07-18 22:39:52 +03:00
|
|
|
/* Check if we really need to flush anything */
|
|
|
|
if (bs->flushed_gen == current_gen) {
|
2019-06-12 19:18:05 +03:00
|
|
|
goto flush_children;
|
2016-07-18 22:39:52 +03:00
|
|
|
}
|
|
|
|
|
2023-06-01 14:51:45 +03:00
|
|
|
BLKDBG_CO_EVENT(primary_child, BLKDBG_FLUSH_TO_DISK);
|
2017-11-10 23:31:09 +03:00
|
|
|
if (!bs->drv) {
|
|
|
|
/* bs->drv->bdrv_co_flush() might have ejected the BDS
|
|
|
|
* (even in case of apparent success) */
|
|
|
|
ret = -ENOMEDIUM;
|
|
|
|
goto out;
|
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
if (bs->drv->bdrv_co_flush_to_disk) {
|
|
|
|
ret = bs->drv->bdrv_co_flush_to_disk(bs);
|
|
|
|
} else if (bs->drv->bdrv_aio_flush) {
|
|
|
|
BlockAIOCB *acb;
|
|
|
|
CoroutineIOCompletion co = {
|
|
|
|
.coroutine = qemu_coroutine_self(),
|
|
|
|
};
|
|
|
|
|
|
|
|
acb = bs->drv->bdrv_aio_flush(bs, bdrv_co_io_em_complete, &co);
|
|
|
|
if (acb == NULL) {
|
|
|
|
ret = -EIO;
|
|
|
|
} else {
|
|
|
|
qemu_coroutine_yield();
|
|
|
|
ret = co.ret;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* Some block drivers always operate in either writethrough or unsafe
|
|
|
|
* mode and don't support bdrv_flush therefore. Usually qemu doesn't
|
|
|
|
* know how the server works (because the behaviour is hardcoded or
|
|
|
|
* depends on server-side configuration), so we can't ensure that
|
|
|
|
* everything is safe on disk. Returning an error doesn't work because
|
|
|
|
* that would break guests even if the server operates in writethrough
|
|
|
|
* mode.
|
|
|
|
*
|
|
|
|
* Let's hope the user knows what he's doing.
|
|
|
|
*/
|
|
|
|
ret = 0;
|
|
|
|
}
|
2016-07-18 22:39:52 +03:00
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
if (ret < 0) {
|
2015-11-09 13:16:47 +03:00
|
|
|
goto out;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Now flush the underlying protocol. It will also have BDRV_O_NO_FLUSH
|
|
|
|
* in the case of cache=unsafe, so there are no useless flushes.
|
|
|
|
*/
|
2019-06-12 19:18:05 +03:00
|
|
|
flush_children:
|
|
|
|
ret = 0;
|
|
|
|
QLIST_FOREACH(child, &bs->children, next) {
|
|
|
|
if (child->perm & (BLK_PERM_WRITE | BLK_PERM_WRITE_UNCHANGED)) {
|
|
|
|
int this_child_ret = bdrv_co_flush(child->bs);
|
|
|
|
if (!ret) {
|
|
|
|
ret = this_child_ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-11-09 13:16:47 +03:00
|
|
|
out:
|
2016-07-18 22:39:52 +03:00
|
|
|
/* Notify any pending flushes that we have completed */
|
2016-11-05 02:03:15 +03:00
|
|
|
if (ret == 0) {
|
|
|
|
bs->flushed_gen = current_gen;
|
|
|
|
}
|
2017-06-05 15:39:02 +03:00
|
|
|
|
2023-08-08 18:58:52 +03:00
|
|
|
qemu_mutex_lock(&bs->reqs_lock);
|
2016-10-27 13:48:52 +03:00
|
|
|
bs->active_flush_req = false;
|
2016-08-17 21:06:54 +03:00
|
|
|
/* Return value is ignored - it's ok if wait queue is empty */
|
|
|
|
qemu_co_queue_next(&bs->flush_queue);
|
2023-08-08 18:58:52 +03:00
|
|
|
qemu_mutex_unlock(&bs->reqs_lock);
|
2016-07-18 22:39:52 +03:00
|
|
|
|
2017-04-10 16:00:50 +03:00
|
|
|
early_exit:
|
2016-10-27 13:48:52 +03:00
|
|
|
bdrv_dec_in_flight(bs);
|
2015-11-09 13:16:47 +03:00
|
|
|
return ret;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2019-04-23 15:57:05 +03:00
|
|
|
int coroutine_fn bdrv_co_pdiscard(BdrvChild *child, int64_t offset,
|
|
|
|
int64_t bytes)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
2015-11-09 13:16:48 +03:00
|
|
|
BdrvTrackedRequest req;
|
2021-09-03 13:28:05 +03:00
|
|
|
int ret;
|
|
|
|
int64_t max_pdiscard;
|
block: Pass unaligned discard requests to drivers
Discard is advisory, so rounding the requests to alignment
boundaries is never semantically wrong from the data that
the guest sees. But at least the Dell Equallogic iSCSI SANs
has an interesting property that its advertised discard
alignment is 15M, yet documents that discarding a sequence
of 1M slices will eventually result in the 15M page being
marked as discarded, and it is possible to observe which
pages have been discarded.
Between commits 9f1963b and b8d0a980, we converted the block
layer to a byte-based interface that ultimately ignores any
unaligned head or tail based on the driver's advertised
discard granularity, which means that qemu 2.7 refuses to
pass any discard request smaller than 15M down to the Dell
Equallogic hardware. This is a slight regression in behavior
compared to earlier qemu, where a guest executing discards
in power-of-2 chunks used to be able to get every page
discarded, but is now left with various pages still allocated
because the guest requests did not align with the hardware's
15M pages.
Since the SCSI specification says nothing about a minimum
discard granularity, and only documents the preferred
alignment, it is best if the block layer gives the driver
every bit of information about discard requests, rather than
rounding it to alignment boundaries early.
Rework the block layer discard algorithm to mirror the write
zero algorithm: always peel off any unaligned head or tail
and manage that in isolation, then do the bulk of the request
on an aligned boundary. The fallback when the driver returns
-ENOTSUP for an unaligned request is to silently ignore that
portion of the discard request; but for devices that can pass
the partial request all the way down to hardware, this can
result in the hardware coalescing requests and discarding
aligned pages after all.
Reported by: Peter Lieven <pl@kamp.de>
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2016-11-17 23:13:58 +03:00
|
|
|
int head, tail, align;
|
2018-07-10 09:31:17 +03:00
|
|
|
BlockDriverState *bs = child->bs;
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2023-02-03 18:21:47 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2023-01-13 23:42:02 +03:00
|
|
|
if (!bs || !bs->drv || !bdrv_co_is_inserted(bs)) {
|
2015-04-28 16:27:52 +03:00
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
|
2017-06-28 15:05:10 +03:00
|
|
|
if (bdrv_has_readonly_bitmaps(bs)) {
|
|
|
|
return -EPERM;
|
|
|
|
}
|
|
|
|
|
2020-12-11 21:39:19 +03:00
|
|
|
ret = bdrv_check_request(offset, bytes, NULL);
|
block: introduce BDRV_MAX_LENGTH
We are going to modify block layer to work with 64bit requests. And
first step is moving to int64_t type for both offset and bytes
arguments in all block request related functions.
It's mostly safe (when widening signed or unsigned int to int64_t), but
switching from uint64_t is questionable.
So, let's first establish the set of requests we want to work with.
First signed int64_t should be enough, as off_t is signed anyway. Then,
obviously offset + bytes should not overflow.
And most interesting: (offset + bytes) being aligned up should not
overflow as well. Aligned to what alignment? First thing that comes in
mind is bs->bl.request_alignment, as we align up request to this
alignment. But there is another thing: look at
bdrv_mark_request_serialising(). It aligns request up to some given
alignment. And this parameter may be bdrv_get_cluster_size(), which is
often a lot greater than bs->bl.request_alignment.
Note also, that bdrv_mark_request_serialising() uses signed int64_t for
calculations. So, actually, we already depend on some restrictions.
Happily, bdrv_get_cluster_size() returns int and
bs->bl.request_alignment has 32bit unsigned type, but defined to be a
power of 2 less than INT_MAX. So, we may establish, that INT_MAX is
absolute maximum for any kind of alignment that may occur with the
request.
Note, that bdrv_get_cluster_size() is not documented to return power
of 2, still bdrv_mark_request_serialising() behaves like it is.
Also, backup uses bdi.cluster_size and is not prepared to it not being
power of 2.
So, let's establish that Qemu supports only power-of-2 clusters and
alignments.
So, alignment can't be greater than 2^30.
Finally to be safe with calculations, to not calculate different
maximums for different nodes (depending on cluster size and
request_alignment), let's simply set QEMU_ALIGN_DOWN(INT64_MAX, 2^30)
as absolute maximum bytes length for Qemu. Actually, it's not much less
than INT64_MAX.
OK, then, let's apply it to block/io.
Let's consider all block/io entry points of offset/bytes:
4 bytes/offset interface functions: bdrv_co_preadv_part(),
bdrv_co_pwritev_part(), bdrv_co_copy_range_internal() and
bdrv_co_pdiscard() and we check them all with bdrv_check_request().
We also have one entry point with only offset: bdrv_co_truncate().
Check the offset.
And one public structure: BdrvTrackedRequest. Happily, it has only
three external users:
file-posix.c: adopted by this patch
write-threshold.c: only read fields
test-write-threshold.c: sets obviously small constant values
Better is to make the structure private and add corresponding
interfaces.. Still it's not obvious what kind of interface is needed
for file-posix.c. Let's keep it public but add corresponding
assertions.
After this patch we'll convert functions in block/io.c to int64_t bytes
and offset parameters. We can assume that offset/bytes pair always
satisfy new restrictions, and make
corresponding assertions where needed. If we reach some offset/bytes
point in block/io.c missing bdrv_check_request() it is considered a
bug. As well, if block/io.c modifies a offset/bytes request, expanding
it more then aligning up to request_alignment, it's a bug too.
For all io requests except for discard we keep for now old restriction
of 32bit request length.
iotest 206 output error message changed, as now test disk size is
larger than new limit. Add one more test case with new maximum disk
size to cover too-big-L1 case.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201203222713.13507-5-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-12-04 01:27:13 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Do nothing if disabled. */
|
|
|
|
if (!(bs->open_flags & BDRV_O_UNMAP)) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-07-16 02:23:06 +03:00
|
|
|
if (!bs->drv->bdrv_co_pdiscard && !bs->drv->bdrv_aio_pdiscard) {
|
2015-04-28 16:27:52 +03:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
block: block-status cache for data regions
As we have attempted before
(https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06451.html,
"file-posix: Cache lseek result for data regions";
https://lists.nongnu.org/archive/html/qemu-block/2021-02/msg00934.html,
"file-posix: Cache next hole"), this patch seeks to reduce the number of
SEEK_DATA/HOLE operations the file-posix driver has to perform. The
main difference is that this time it is implemented as part of the
general block layer code.
The problem we face is that on some filesystems or in some
circumstances, SEEK_DATA/HOLE is unreasonably slow. Given the
implementation is outside of qemu, there is little we can do about its
performance.
We have already introduced the want_zero parameter to
bdrv_co_block_status() to reduce the number of SEEK_DATA/HOLE calls
unless we really want zero information; but sometimes we do want that
information, because for files that consist largely of zero areas,
special-casing those areas can give large performance boosts. So the
real problem is with files that consist largely of data, so that
inquiring the block status does not gain us much performance, but where
such an inquiry itself takes a lot of time.
To address this, we want to cache data regions. Most of the time, when
bad performance is reported, it is in places where the image is iterated
over from start to end (qemu-img convert or the mirror job), so a simple
yet effective solution is to cache only the current data region.
(Note that only caching data regions but not zero regions means that
returning false information from the cache is not catastrophic: Treating
zeroes as data is fine. While we try to invalidate the cache on zero
writes and discards, such incongruences may still occur when there are
other processes writing to the image.)
We only use the cache for nodes without children (i.e. protocol nodes),
because that is where the problem is: Drivers that rely on block-status
implementations outside of qemu (e.g. SEEK_DATA/HOLE).
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/307
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20210812084148.14458-3-hreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
[hreitz: Added `local_file == bs` assertion, as suggested by Vladimir]
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2021-08-12 11:41:44 +03:00
|
|
|
/* Invalidate the cached block-status data range if this discard overlaps */
|
|
|
|
bdrv_bsc_invalidate_range(bs, offset, bytes);
|
|
|
|
|
block: Pass unaligned discard requests to drivers
Discard is advisory, so rounding the requests to alignment
boundaries is never semantically wrong from the data that
the guest sees. But at least the Dell Equallogic iSCSI SANs
has an interesting property that its advertised discard
alignment is 15M, yet documents that discarding a sequence
of 1M slices will eventually result in the 15M page being
marked as discarded, and it is possible to observe which
pages have been discarded.
Between commits 9f1963b and b8d0a980, we converted the block
layer to a byte-based interface that ultimately ignores any
unaligned head or tail based on the driver's advertised
discard granularity, which means that qemu 2.7 refuses to
pass any discard request smaller than 15M down to the Dell
Equallogic hardware. This is a slight regression in behavior
compared to earlier qemu, where a guest executing discards
in power-of-2 chunks used to be able to get every page
discarded, but is now left with various pages still allocated
because the guest requests did not align with the hardware's
15M pages.
Since the SCSI specification says nothing about a minimum
discard granularity, and only documents the preferred
alignment, it is best if the block layer gives the driver
every bit of information about discard requests, rather than
rounding it to alignment boundaries early.
Rework the block layer discard algorithm to mirror the write
zero algorithm: always peel off any unaligned head or tail
and manage that in isolation, then do the bulk of the request
on an aligned boundary. The fallback when the driver returns
-ENOTSUP for an unaligned request is to silently ignore that
portion of the discard request; but for devices that can pass
the partial request all the way down to hardware, this can
result in the hardware coalescing requests and discarding
aligned pages after all.
Reported by: Peter Lieven <pl@kamp.de>
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2016-11-17 23:13:58 +03:00
|
|
|
/* Discard is advisory, but some devices track and coalesce
|
|
|
|
* unaligned requests, so we must pass everything down rather than
|
|
|
|
* round here. Still, most devices will just silently ignore
|
|
|
|
* unaligned requests (by returning -ENOTSUP), so we must fragment
|
|
|
|
* the request accordingly. */
|
2016-07-16 02:23:06 +03:00
|
|
|
align = MAX(bs->bl.pdiscard_alignment, bs->bl.request_alignment);
|
2016-07-21 22:34:48 +03:00
|
|
|
assert(align % bs->bl.request_alignment == 0);
|
|
|
|
head = offset % align;
|
2017-06-09 13:18:08 +03:00
|
|
|
tail = (offset + bytes) % align;
|
2016-07-16 02:22:50 +03:00
|
|
|
|
2016-10-27 13:48:52 +03:00
|
|
|
bdrv_inc_in_flight(bs);
|
2017-06-09 13:18:08 +03:00
|
|
|
tracked_request_begin(&req, bs, offset, bytes, BDRV_TRACKED_DISCARD);
|
2015-06-08 08:56:10 +03:00
|
|
|
|
2018-07-10 09:31:21 +03:00
|
|
|
ret = bdrv_co_write_req_prepare(child, offset, bytes, &req, 0);
|
2016-06-16 19:09:41 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2021-09-03 13:28:07 +03:00
|
|
|
max_pdiscard = QEMU_ALIGN_DOWN(MIN_NON_ZERO(bs->bl.max_pdiscard, INT64_MAX),
|
2016-07-16 02:22:50 +03:00
|
|
|
align);
|
block: Pass unaligned discard requests to drivers
Discard is advisory, so rounding the requests to alignment
boundaries is never semantically wrong from the data that
the guest sees. But at least the Dell Equallogic iSCSI SANs
has an interesting property that its advertised discard
alignment is 15M, yet documents that discarding a sequence
of 1M slices will eventually result in the 15M page being
marked as discarded, and it is possible to observe which
pages have been discarded.
Between commits 9f1963b and b8d0a980, we converted the block
layer to a byte-based interface that ultimately ignores any
unaligned head or tail based on the driver's advertised
discard granularity, which means that qemu 2.7 refuses to
pass any discard request smaller than 15M down to the Dell
Equallogic hardware. This is a slight regression in behavior
compared to earlier qemu, where a guest executing discards
in power-of-2 chunks used to be able to get every page
discarded, but is now left with various pages still allocated
because the guest requests did not align with the hardware's
15M pages.
Since the SCSI specification says nothing about a minimum
discard granularity, and only documents the preferred
alignment, it is best if the block layer gives the driver
every bit of information about discard requests, rather than
rounding it to alignment boundaries early.
Rework the block layer discard algorithm to mirror the write
zero algorithm: always peel off any unaligned head or tail
and manage that in isolation, then do the bulk of the request
on an aligned boundary. The fallback when the driver returns
-ENOTSUP for an unaligned request is to silently ignore that
portion of the discard request; but for devices that can pass
the partial request all the way down to hardware, this can
result in the hardware coalescing requests and discarding
aligned pages after all.
Reported by: Peter Lieven <pl@kamp.de>
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2016-11-17 23:13:58 +03:00
|
|
|
assert(max_pdiscard >= bs->bl.request_alignment);
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2017-06-09 13:18:08 +03:00
|
|
|
while (bytes > 0) {
|
2019-04-23 15:57:05 +03:00
|
|
|
int64_t num = bytes;
|
block: Pass unaligned discard requests to drivers
Discard is advisory, so rounding the requests to alignment
boundaries is never semantically wrong from the data that
the guest sees. But at least the Dell Equallogic iSCSI SANs
has an interesting property that its advertised discard
alignment is 15M, yet documents that discarding a sequence
of 1M slices will eventually result in the 15M page being
marked as discarded, and it is possible to observe which
pages have been discarded.
Between commits 9f1963b and b8d0a980, we converted the block
layer to a byte-based interface that ultimately ignores any
unaligned head or tail based on the driver's advertised
discard granularity, which means that qemu 2.7 refuses to
pass any discard request smaller than 15M down to the Dell
Equallogic hardware. This is a slight regression in behavior
compared to earlier qemu, where a guest executing discards
in power-of-2 chunks used to be able to get every page
discarded, but is now left with various pages still allocated
because the guest requests did not align with the hardware's
15M pages.
Since the SCSI specification says nothing about a minimum
discard granularity, and only documents the preferred
alignment, it is best if the block layer gives the driver
every bit of information about discard requests, rather than
rounding it to alignment boundaries early.
Rework the block layer discard algorithm to mirror the write
zero algorithm: always peel off any unaligned head or tail
and manage that in isolation, then do the bulk of the request
on an aligned boundary. The fallback when the driver returns
-ENOTSUP for an unaligned request is to silently ignore that
portion of the discard request; but for devices that can pass
the partial request all the way down to hardware, this can
result in the hardware coalescing requests and discarding
aligned pages after all.
Reported by: Peter Lieven <pl@kamp.de>
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2016-11-17 23:13:58 +03:00
|
|
|
|
|
|
|
if (head) {
|
|
|
|
/* Make small requests to get to alignment boundaries. */
|
2017-06-09 13:18:08 +03:00
|
|
|
num = MIN(bytes, align - head);
|
block: Pass unaligned discard requests to drivers
Discard is advisory, so rounding the requests to alignment
boundaries is never semantically wrong from the data that
the guest sees. But at least the Dell Equallogic iSCSI SANs
has an interesting property that its advertised discard
alignment is 15M, yet documents that discarding a sequence
of 1M slices will eventually result in the 15M page being
marked as discarded, and it is possible to observe which
pages have been discarded.
Between commits 9f1963b and b8d0a980, we converted the block
layer to a byte-based interface that ultimately ignores any
unaligned head or tail based on the driver's advertised
discard granularity, which means that qemu 2.7 refuses to
pass any discard request smaller than 15M down to the Dell
Equallogic hardware. This is a slight regression in behavior
compared to earlier qemu, where a guest executing discards
in power-of-2 chunks used to be able to get every page
discarded, but is now left with various pages still allocated
because the guest requests did not align with the hardware's
15M pages.
Since the SCSI specification says nothing about a minimum
discard granularity, and only documents the preferred
alignment, it is best if the block layer gives the driver
every bit of information about discard requests, rather than
rounding it to alignment boundaries early.
Rework the block layer discard algorithm to mirror the write
zero algorithm: always peel off any unaligned head or tail
and manage that in isolation, then do the bulk of the request
on an aligned boundary. The fallback when the driver returns
-ENOTSUP for an unaligned request is to silently ignore that
portion of the discard request; but for devices that can pass
the partial request all the way down to hardware, this can
result in the hardware coalescing requests and discarding
aligned pages after all.
Reported by: Peter Lieven <pl@kamp.de>
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2016-11-17 23:13:58 +03:00
|
|
|
if (!QEMU_IS_ALIGNED(num, bs->bl.request_alignment)) {
|
|
|
|
num %= bs->bl.request_alignment;
|
|
|
|
}
|
|
|
|
head = (head + num) % align;
|
|
|
|
assert(num < max_pdiscard);
|
|
|
|
} else if (tail) {
|
|
|
|
if (num > align) {
|
|
|
|
/* Shorten the request to the last aligned cluster. */
|
|
|
|
num -= tail;
|
|
|
|
} else if (!QEMU_IS_ALIGNED(tail, bs->bl.request_alignment) &&
|
|
|
|
tail > bs->bl.request_alignment) {
|
|
|
|
tail %= bs->bl.request_alignment;
|
|
|
|
num -= tail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
/* limit request size */
|
|
|
|
if (num > max_pdiscard) {
|
|
|
|
num = max_pdiscard;
|
|
|
|
}
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2017-11-10 23:31:09 +03:00
|
|
|
if (!bs->drv) {
|
|
|
|
ret = -ENOMEDIUM;
|
|
|
|
goto out;
|
|
|
|
}
|
2016-07-16 02:22:58 +03:00
|
|
|
if (bs->drv->bdrv_co_pdiscard) {
|
|
|
|
ret = bs->drv->bdrv_co_pdiscard(bs, offset, num);
|
2015-04-28 16:27:52 +03:00
|
|
|
} else {
|
|
|
|
BlockAIOCB *acb;
|
|
|
|
CoroutineIOCompletion co = {
|
|
|
|
.coroutine = qemu_coroutine_self(),
|
|
|
|
};
|
|
|
|
|
2016-07-16 02:22:57 +03:00
|
|
|
acb = bs->drv->bdrv_aio_pdiscard(bs, offset, num,
|
|
|
|
bdrv_co_io_em_complete, &co);
|
2015-04-28 16:27:52 +03:00
|
|
|
if (acb == NULL) {
|
2015-11-09 13:16:48 +03:00
|
|
|
ret = -EIO;
|
|
|
|
goto out;
|
2015-04-28 16:27:52 +03:00
|
|
|
} else {
|
|
|
|
qemu_coroutine_yield();
|
|
|
|
ret = co.ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (ret && ret != -ENOTSUP) {
|
2015-11-09 13:16:48 +03:00
|
|
|
goto out;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2016-07-16 02:22:50 +03:00
|
|
|
offset += num;
|
2017-06-09 13:18:08 +03:00
|
|
|
bytes -= num;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
2015-11-09 13:16:48 +03:00
|
|
|
ret = 0;
|
|
|
|
out:
|
2018-07-10 09:31:21 +03:00
|
|
|
bdrv_co_write_req_finish(child, req.offset, req.bytes, &req, ret);
|
2015-11-09 13:16:48 +03:00
|
|
|
tracked_request_end(&req);
|
2016-10-27 13:48:52 +03:00
|
|
|
bdrv_dec_in_flight(bs);
|
2015-11-09 13:16:48 +03:00
|
|
|
return ret;
|
2015-04-28 16:27:52 +03:00
|
|
|
}
|
|
|
|
|
2022-09-22 11:49:00 +03:00
|
|
|
int coroutine_fn bdrv_co_ioctl(BlockDriverState *bs, int req, void *buf)
|
2015-04-28 16:27:52 +03:00
|
|
|
{
|
|
|
|
BlockDriver *drv = bs->drv;
|
2015-11-09 13:16:51 +03:00
|
|
|
CoroutineIOCompletion co = {
|
|
|
|
.coroutine = qemu_coroutine_self(),
|
|
|
|
};
|
|
|
|
BlockAIOCB *acb;
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2023-02-03 18:21:44 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2015-04-28 16:27:52 +03:00
|
|
|
|
2016-10-27 13:48:52 +03:00
|
|
|
bdrv_inc_in_flight(bs);
|
2016-10-20 16:07:27 +03:00
|
|
|
if (!drv || (!drv->bdrv_aio_ioctl && !drv->bdrv_co_ioctl)) {
|
2015-11-09 13:16:51 +03:00
|
|
|
co.ret = -ENOTSUP;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2016-10-20 16:07:27 +03:00
|
|
|
if (drv->bdrv_co_ioctl) {
|
|
|
|
co.ret = drv->bdrv_co_ioctl(bs, req, buf);
|
|
|
|
} else {
|
|
|
|
acb = drv->bdrv_aio_ioctl(bs, req, buf, bdrv_co_io_em_complete, &co);
|
|
|
|
if (!acb) {
|
|
|
|
co.ret = -ENOTSUP;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
qemu_coroutine_yield();
|
2015-11-09 13:16:51 +03:00
|
|
|
}
|
|
|
|
out:
|
2016-10-27 13:48:52 +03:00
|
|
|
bdrv_dec_in_flight(bs);
|
2015-11-09 13:16:51 +03:00
|
|
|
return co.ret;
|
|
|
|
}
|
|
|
|
|
block/block-backend: add block layer APIs resembling Linux ZonedBlockDevice ioctls
Add zoned device option to host_device BlockDriver. It will be presented only
for zoned host block devices. By adding zone management operations to the
host_block_device BlockDriver, users can use the new block layer APIs
including Report Zone and four zone management operations
(open, close, finish, reset, reset_all).
Qemu-io uses the new APIs to perform zoned storage commands of the device:
zone_report(zrp), zone_open(zo), zone_close(zc), zone_reset(zrs),
zone_finish(zf).
For example, to test zone_report, use following command:
$ ./build/qemu-io --image-opts -n driver=host_device, filename=/dev/nullb0
-c "zrp offset nr_zones"
Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230508045533.175575-4-faithilikerun@gmail.com
Message-id: 20230324090605.28361-4-faithilikerun@gmail.com
[Adjust commit message prefix as suggested by Philippe Mathieu-Daudé
<philmd@linaro.org> and remove spurious ret = -errno in
raw_co_zone_mgmt().
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2023-05-08 07:55:28 +03:00
|
|
|
int coroutine_fn bdrv_co_zone_report(BlockDriverState *bs, int64_t offset,
|
|
|
|
unsigned int *nr_zones,
|
|
|
|
BlockZoneDescriptor *zones)
|
|
|
|
{
|
|
|
|
BlockDriver *drv = bs->drv;
|
|
|
|
CoroutineIOCompletion co = {
|
|
|
|
.coroutine = qemu_coroutine_self(),
|
|
|
|
};
|
|
|
|
IO_CODE();
|
|
|
|
|
|
|
|
bdrv_inc_in_flight(bs);
|
|
|
|
if (!drv || !drv->bdrv_co_zone_report || bs->bl.zoned == BLK_Z_NONE) {
|
|
|
|
co.ret = -ENOTSUP;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
co.ret = drv->bdrv_co_zone_report(bs, offset, nr_zones, zones);
|
|
|
|
out:
|
|
|
|
bdrv_dec_in_flight(bs);
|
|
|
|
return co.ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
int coroutine_fn bdrv_co_zone_mgmt(BlockDriverState *bs, BlockZoneOp op,
|
|
|
|
int64_t offset, int64_t len)
|
|
|
|
{
|
|
|
|
BlockDriver *drv = bs->drv;
|
|
|
|
CoroutineIOCompletion co = {
|
|
|
|
.coroutine = qemu_coroutine_self(),
|
|
|
|
};
|
|
|
|
IO_CODE();
|
|
|
|
|
|
|
|
bdrv_inc_in_flight(bs);
|
|
|
|
if (!drv || !drv->bdrv_co_zone_mgmt || bs->bl.zoned == BLK_Z_NONE) {
|
|
|
|
co.ret = -ENOTSUP;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
co.ret = drv->bdrv_co_zone_mgmt(bs, op, offset, len);
|
|
|
|
out:
|
|
|
|
bdrv_dec_in_flight(bs);
|
|
|
|
return co.ret;
|
|
|
|
}
|
|
|
|
|
2023-05-08 08:15:08 +03:00
|
|
|
int coroutine_fn bdrv_co_zone_append(BlockDriverState *bs, int64_t *offset,
|
|
|
|
QEMUIOVector *qiov,
|
|
|
|
BdrvRequestFlags flags)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
BlockDriver *drv = bs->drv;
|
|
|
|
CoroutineIOCompletion co = {
|
|
|
|
.coroutine = qemu_coroutine_self(),
|
|
|
|
};
|
|
|
|
IO_CODE();
|
|
|
|
|
|
|
|
ret = bdrv_check_qiov_request(*offset, qiov->size, qiov, 0, NULL);
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
bdrv_inc_in_flight(bs);
|
|
|
|
if (!drv || !drv->bdrv_co_zone_append || bs->bl.zoned == BLK_Z_NONE) {
|
|
|
|
co.ret = -ENOTSUP;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
co.ret = drv->bdrv_co_zone_append(bs, offset, qiov, flags);
|
|
|
|
out:
|
|
|
|
bdrv_dec_in_flight(bs);
|
|
|
|
return co.ret;
|
|
|
|
}
|
|
|
|
|
2015-04-28 16:27:52 +03:00
|
|
|
void *qemu_blockalign(BlockDriverState *bs, size_t size)
|
|
|
|
{
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2015-04-28 16:27:52 +03:00
|
|
|
return qemu_memalign(bdrv_opt_mem_align(bs), size);
|
|
|
|
}
|
|
|
|
|
|
|
|
void *qemu_blockalign0(BlockDriverState *bs, size_t size)
|
|
|
|
{
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2015-04-28 16:27:52 +03:00
|
|
|
return memset(qemu_blockalign(bs, size), 0, size);
|
|
|
|
}
|
|
|
|
|
|
|
|
void *qemu_try_blockalign(BlockDriverState *bs, size_t size)
|
|
|
|
{
|
|
|
|
size_t align = bdrv_opt_mem_align(bs);
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2015-04-28 16:27:52 +03:00
|
|
|
|
|
|
|
/* Ensure that NULL is never returned on success */
|
|
|
|
assert(align > 0);
|
|
|
|
if (size == 0) {
|
|
|
|
size = align;
|
|
|
|
}
|
|
|
|
|
|
|
|
return qemu_try_memalign(align, size);
|
|
|
|
}
|
|
|
|
|
|
|
|
void *qemu_try_blockalign0(BlockDriverState *bs, size_t size)
|
|
|
|
{
|
|
|
|
void *mem = qemu_try_blockalign(bs, size);
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2015-04-28 16:27:52 +03:00
|
|
|
|
|
|
|
if (mem) {
|
|
|
|
memset(mem, 0, size);
|
|
|
|
}
|
|
|
|
|
|
|
|
return mem;
|
|
|
|
}
|
|
|
|
|
2022-10-13 21:59:02 +03:00
|
|
|
/* Helper that undoes bdrv_register_buf() when it fails partway through */
|
2023-02-03 18:21:59 +03:00
|
|
|
static void GRAPH_RDLOCK
|
|
|
|
bdrv_register_buf_rollback(BlockDriverState *bs, void *host, size_t size,
|
|
|
|
BdrvChild *final_child)
|
2022-10-13 21:59:02 +03:00
|
|
|
{
|
|
|
|
BdrvChild *child;
|
|
|
|
|
2023-02-03 18:21:59 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
|
|
|
assert_bdrv_graph_readable();
|
|
|
|
|
2022-10-13 21:59:02 +03:00
|
|
|
QLIST_FOREACH(child, &bs->children, next) {
|
|
|
|
if (child == final_child) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
bdrv_unregister_buf(child->bs, host, size);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (bs->drv && bs->drv->bdrv_unregister_buf) {
|
|
|
|
bs->drv->bdrv_unregister_buf(bs, host, size);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
bool bdrv_register_buf(BlockDriverState *bs, void *host, size_t size,
|
|
|
|
Error **errp)
|
2018-01-16 09:08:56 +03:00
|
|
|
{
|
|
|
|
BdrvChild *child;
|
|
|
|
|
2022-03-03 18:15:49 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
2023-02-03 18:21:59 +03:00
|
|
|
GRAPH_RDLOCK_GUARD_MAINLOOP();
|
|
|
|
|
2018-01-16 09:08:56 +03:00
|
|
|
if (bs->drv && bs->drv->bdrv_register_buf) {
|
2022-10-13 21:59:02 +03:00
|
|
|
if (!bs->drv->bdrv_register_buf(bs, host, size, errp)) {
|
|
|
|
return false;
|
|
|
|
}
|
2018-01-16 09:08:56 +03:00
|
|
|
}
|
|
|
|
QLIST_FOREACH(child, &bs->children, next) {
|
2022-10-13 21:59:02 +03:00
|
|
|
if (!bdrv_register_buf(child->bs, host, size, errp)) {
|
|
|
|
bdrv_register_buf_rollback(bs, host, size, child);
|
|
|
|
return false;
|
|
|
|
}
|
2018-01-16 09:08:56 +03:00
|
|
|
}
|
2022-10-13 21:59:02 +03:00
|
|
|
return true;
|
2018-01-16 09:08:56 +03:00
|
|
|
}
|
|
|
|
|
2022-10-13 21:58:59 +03:00
|
|
|
void bdrv_unregister_buf(BlockDriverState *bs, void *host, size_t size)
|
2018-01-16 09:08:56 +03:00
|
|
|
{
|
|
|
|
BdrvChild *child;
|
|
|
|
|
2022-03-03 18:15:49 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
2023-02-03 18:21:59 +03:00
|
|
|
GRAPH_RDLOCK_GUARD_MAINLOOP();
|
|
|
|
|
2018-01-16 09:08:56 +03:00
|
|
|
if (bs->drv && bs->drv->bdrv_unregister_buf) {
|
2022-10-13 21:58:59 +03:00
|
|
|
bs->drv->bdrv_unregister_buf(bs, host, size);
|
2018-01-16 09:08:56 +03:00
|
|
|
}
|
|
|
|
QLIST_FOREACH(child, &bs->children, next) {
|
2022-10-13 21:58:59 +03:00
|
|
|
bdrv_unregister_buf(child->bs, host, size);
|
2018-01-16 09:08:56 +03:00
|
|
|
}
|
|
|
|
}
|
2018-06-01 12:26:39 +03:00
|
|
|
|
2023-02-03 18:21:48 +03:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK bdrv_co_copy_range_internal(
|
2020-12-11 21:39:34 +03:00
|
|
|
BdrvChild *src, int64_t src_offset, BdrvChild *dst,
|
|
|
|
int64_t dst_offset, int64_t bytes,
|
2018-07-09 19:37:17 +03:00
|
|
|
BdrvRequestFlags read_flags, BdrvRequestFlags write_flags,
|
|
|
|
bool recurse_src)
|
2018-06-01 12:26:39 +03:00
|
|
|
{
|
2018-07-09 19:37:16 +03:00
|
|
|
BdrvTrackedRequest req;
|
2018-06-01 12:26:39 +03:00
|
|
|
int ret;
|
2023-02-03 18:21:53 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2018-06-01 12:26:39 +03:00
|
|
|
|
2019-03-22 15:38:43 +03:00
|
|
|
/* TODO We can support BDRV_REQ_NO_FALLBACK here */
|
|
|
|
assert(!(read_flags & BDRV_REQ_NO_FALLBACK));
|
|
|
|
assert(!(write_flags & BDRV_REQ_NO_FALLBACK));
|
2022-02-15 15:16:09 +03:00
|
|
|
assert(!(read_flags & BDRV_REQ_NO_WAIT));
|
|
|
|
assert(!(write_flags & BDRV_REQ_NO_WAIT));
|
2019-03-22 15:38:43 +03:00
|
|
|
|
2023-01-13 23:42:02 +03:00
|
|
|
if (!dst || !dst->bs || !bdrv_co_is_inserted(dst->bs)) {
|
2018-06-01 12:26:39 +03:00
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
2020-12-11 21:39:25 +03:00
|
|
|
ret = bdrv_check_request32(dst_offset, bytes, NULL, 0);
|
2018-06-01 12:26:39 +03:00
|
|
|
if (ret) {
|
|
|
|
return ret;
|
|
|
|
}
|
2018-07-09 19:37:17 +03:00
|
|
|
if (write_flags & BDRV_REQ_ZERO_WRITE) {
|
|
|
|
return bdrv_co_pwrite_zeroes(dst, dst_offset, bytes, write_flags);
|
2018-06-01 12:26:39 +03:00
|
|
|
}
|
|
|
|
|
2023-01-13 23:42:02 +03:00
|
|
|
if (!src || !src->bs || !bdrv_co_is_inserted(src->bs)) {
|
2018-07-03 05:37:56 +03:00
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
2020-12-11 21:39:25 +03:00
|
|
|
ret = bdrv_check_request32(src_offset, bytes, NULL, 0);
|
2018-07-03 05:37:56 +03:00
|
|
|
if (ret) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2018-06-01 12:26:39 +03:00
|
|
|
if (!src->bs->drv->bdrv_co_copy_range_from
|
|
|
|
|| !dst->bs->drv->bdrv_co_copy_range_to
|
|
|
|
|| src->bs->encrypted || dst->bs->encrypted) {
|
|
|
|
return -ENOTSUP;
|
|
|
|
}
|
2018-06-27 06:57:52 +03:00
|
|
|
|
2018-06-01 12:26:39 +03:00
|
|
|
if (recurse_src) {
|
2018-07-09 19:37:16 +03:00
|
|
|
bdrv_inc_in_flight(src->bs);
|
|
|
|
tracked_request_begin(&req, src->bs, src_offset, bytes,
|
|
|
|
BDRV_TRACKED_READ);
|
|
|
|
|
2018-07-09 19:37:18 +03:00
|
|
|
/* BDRV_REQ_SERIALISING is only for write operation */
|
|
|
|
assert(!(read_flags & BDRV_REQ_SERIALISING));
|
2020-01-08 17:55:54 +03:00
|
|
|
bdrv_wait_serialising_requests(&req);
|
2018-07-09 19:37:16 +03:00
|
|
|
|
2018-06-27 06:57:52 +03:00
|
|
|
ret = src->bs->drv->bdrv_co_copy_range_from(src->bs,
|
|
|
|
src, src_offset,
|
|
|
|
dst, dst_offset,
|
2018-07-09 19:37:17 +03:00
|
|
|
bytes,
|
|
|
|
read_flags, write_flags);
|
2018-07-09 19:37:16 +03:00
|
|
|
|
|
|
|
tracked_request_end(&req);
|
|
|
|
bdrv_dec_in_flight(src->bs);
|
2018-06-01 12:26:39 +03:00
|
|
|
} else {
|
2018-07-09 19:37:16 +03:00
|
|
|
bdrv_inc_in_flight(dst->bs);
|
|
|
|
tracked_request_begin(&req, dst->bs, dst_offset, bytes,
|
|
|
|
BDRV_TRACKED_WRITE);
|
2018-07-10 09:31:22 +03:00
|
|
|
ret = bdrv_co_write_req_prepare(dst, dst_offset, bytes, &req,
|
|
|
|
write_flags);
|
|
|
|
if (!ret) {
|
|
|
|
ret = dst->bs->drv->bdrv_co_copy_range_to(dst->bs,
|
|
|
|
src, src_offset,
|
|
|
|
dst, dst_offset,
|
|
|
|
bytes,
|
|
|
|
read_flags, write_flags);
|
|
|
|
}
|
|
|
|
bdrv_co_write_req_finish(dst, dst_offset, bytes, &req, ret);
|
2018-07-09 19:37:16 +03:00
|
|
|
tracked_request_end(&req);
|
|
|
|
bdrv_dec_in_flight(dst->bs);
|
2018-06-01 12:26:39 +03:00
|
|
|
}
|
2018-07-09 19:37:16 +03:00
|
|
|
|
2018-06-27 06:57:52 +03:00
|
|
|
return ret;
|
2018-06-01 12:26:39 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Copy range from @src to @dst.
|
|
|
|
*
|
|
|
|
* See the comment of bdrv_co_copy_range for the parameter and return value
|
|
|
|
* semantics. */
|
2020-12-11 21:39:34 +03:00
|
|
|
int coroutine_fn bdrv_co_copy_range_from(BdrvChild *src, int64_t src_offset,
|
|
|
|
BdrvChild *dst, int64_t dst_offset,
|
|
|
|
int64_t bytes,
|
2018-07-09 19:37:17 +03:00
|
|
|
BdrvRequestFlags read_flags,
|
|
|
|
BdrvRequestFlags write_flags)
|
2018-06-01 12:26:39 +03:00
|
|
|
{
|
2022-03-03 18:15:58 +03:00
|
|
|
IO_CODE();
|
2023-02-03 18:21:53 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2018-07-10 09:31:16 +03:00
|
|
|
trace_bdrv_co_copy_range_from(src, src_offset, dst, dst_offset, bytes,
|
|
|
|
read_flags, write_flags);
|
2018-06-01 12:26:39 +03:00
|
|
|
return bdrv_co_copy_range_internal(src, src_offset, dst, dst_offset,
|
2018-07-09 19:37:17 +03:00
|
|
|
bytes, read_flags, write_flags, true);
|
2018-06-01 12:26:39 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Copy range from @src to @dst.
|
|
|
|
*
|
|
|
|
* See the comment of bdrv_co_copy_range for the parameter and return value
|
|
|
|
* semantics. */
|
2020-12-11 21:39:34 +03:00
|
|
|
int coroutine_fn bdrv_co_copy_range_to(BdrvChild *src, int64_t src_offset,
|
|
|
|
BdrvChild *dst, int64_t dst_offset,
|
|
|
|
int64_t bytes,
|
2018-07-09 19:37:17 +03:00
|
|
|
BdrvRequestFlags read_flags,
|
|
|
|
BdrvRequestFlags write_flags)
|
2018-06-01 12:26:39 +03:00
|
|
|
{
|
2022-03-03 18:15:58 +03:00
|
|
|
IO_CODE();
|
2023-02-03 18:21:53 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2018-07-10 09:31:16 +03:00
|
|
|
trace_bdrv_co_copy_range_to(src, src_offset, dst, dst_offset, bytes,
|
|
|
|
read_flags, write_flags);
|
2018-06-01 12:26:39 +03:00
|
|
|
return bdrv_co_copy_range_internal(src, src_offset, dst, dst_offset,
|
2018-07-09 19:37:17 +03:00
|
|
|
bytes, read_flags, write_flags, false);
|
2018-06-01 12:26:39 +03:00
|
|
|
}
|
|
|
|
|
2020-12-11 21:39:34 +03:00
|
|
|
int coroutine_fn bdrv_co_copy_range(BdrvChild *src, int64_t src_offset,
|
|
|
|
BdrvChild *dst, int64_t dst_offset,
|
|
|
|
int64_t bytes, BdrvRequestFlags read_flags,
|
2018-07-09 19:37:17 +03:00
|
|
|
BdrvRequestFlags write_flags)
|
2018-06-01 12:26:39 +03:00
|
|
|
{
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2023-02-03 18:21:53 +03:00
|
|
|
assert_bdrv_graph_readable();
|
|
|
|
|
2018-06-27 06:57:52 +03:00
|
|
|
return bdrv_co_copy_range_from(src, src_offset,
|
|
|
|
dst, dst_offset,
|
2018-07-09 19:37:17 +03:00
|
|
|
bytes, read_flags, write_flags);
|
2018-06-01 12:26:39 +03:00
|
|
|
}
|
2018-06-26 14:55:20 +03:00
|
|
|
|
2023-09-29 17:51:41 +03:00
|
|
|
static void coroutine_fn GRAPH_RDLOCK
|
|
|
|
bdrv_parent_cb_resize(BlockDriverState *bs)
|
2018-06-26 14:55:20 +03:00
|
|
|
{
|
|
|
|
BdrvChild *c;
|
2023-09-29 17:51:41 +03:00
|
|
|
|
|
|
|
assert_bdrv_graph_readable();
|
|
|
|
|
2018-06-26 14:55:20 +03:00
|
|
|
QLIST_FOREACH(c, &bs->parents, next_parent) {
|
2020-05-13 14:05:13 +03:00
|
|
|
if (c->klass->resize) {
|
|
|
|
c->klass->resize(c);
|
2018-06-26 14:55:20 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Truncate file to 'offset' bytes (needed only for file protocols)
|
2019-09-18 12:51:40 +03:00
|
|
|
*
|
|
|
|
* If 'exact' is true, the file must be resized to exactly the given
|
|
|
|
* 'offset'. Otherwise, it is sufficient for the node to be at least
|
|
|
|
* 'offset' bytes in length.
|
2018-06-26 14:55:20 +03:00
|
|
|
*/
|
2019-09-18 12:51:40 +03:00
|
|
|
int coroutine_fn bdrv_co_truncate(BdrvChild *child, int64_t offset, bool exact,
|
2020-04-24 15:54:40 +03:00
|
|
|
PreallocMode prealloc, BdrvRequestFlags flags,
|
|
|
|
Error **errp)
|
2018-06-26 14:55:20 +03:00
|
|
|
{
|
|
|
|
BlockDriverState *bs = child->bs;
|
2020-06-18 18:39:28 +03:00
|
|
|
BdrvChild *filtered, *backing;
|
2018-06-26 14:55:20 +03:00
|
|
|
BlockDriver *drv = bs->drv;
|
2018-06-26 15:23:23 +03:00
|
|
|
BdrvTrackedRequest req;
|
|
|
|
int64_t old_size, new_bytes;
|
2018-06-26 14:55:20 +03:00
|
|
|
int ret;
|
2022-03-03 18:15:50 +03:00
|
|
|
IO_CODE();
|
2023-02-03 18:21:42 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2018-06-26 14:55:20 +03:00
|
|
|
|
|
|
|
/* if bs->drv == NULL, bs is closed, so there's nothing to do here */
|
|
|
|
if (!drv) {
|
|
|
|
error_setg(errp, "No medium inserted");
|
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
if (offset < 0) {
|
|
|
|
error_setg(errp, "Image size cannot be negative");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2020-12-11 21:39:19 +03:00
|
|
|
ret = bdrv_check_request(offset, 0, errp);
|
block: introduce BDRV_MAX_LENGTH
We are going to modify block layer to work with 64bit requests. And
first step is moving to int64_t type for both offset and bytes
arguments in all block request related functions.
It's mostly safe (when widening signed or unsigned int to int64_t), but
switching from uint64_t is questionable.
So, let's first establish the set of requests we want to work with.
First signed int64_t should be enough, as off_t is signed anyway. Then,
obviously offset + bytes should not overflow.
And most interesting: (offset + bytes) being aligned up should not
overflow as well. Aligned to what alignment? First thing that comes in
mind is bs->bl.request_alignment, as we align up request to this
alignment. But there is another thing: look at
bdrv_mark_request_serialising(). It aligns request up to some given
alignment. And this parameter may be bdrv_get_cluster_size(), which is
often a lot greater than bs->bl.request_alignment.
Note also, that bdrv_mark_request_serialising() uses signed int64_t for
calculations. So, actually, we already depend on some restrictions.
Happily, bdrv_get_cluster_size() returns int and
bs->bl.request_alignment has 32bit unsigned type, but defined to be a
power of 2 less than INT_MAX. So, we may establish, that INT_MAX is
absolute maximum for any kind of alignment that may occur with the
request.
Note, that bdrv_get_cluster_size() is not documented to return power
of 2, still bdrv_mark_request_serialising() behaves like it is.
Also, backup uses bdi.cluster_size and is not prepared to it not being
power of 2.
So, let's establish that Qemu supports only power-of-2 clusters and
alignments.
So, alignment can't be greater than 2^30.
Finally to be safe with calculations, to not calculate different
maximums for different nodes (depending on cluster size and
request_alignment), let's simply set QEMU_ALIGN_DOWN(INT64_MAX, 2^30)
as absolute maximum bytes length for Qemu. Actually, it's not much less
than INT64_MAX.
OK, then, let's apply it to block/io.
Let's consider all block/io entry points of offset/bytes:
4 bytes/offset interface functions: bdrv_co_preadv_part(),
bdrv_co_pwritev_part(), bdrv_co_copy_range_internal() and
bdrv_co_pdiscard() and we check them all with bdrv_check_request().
We also have one entry point with only offset: bdrv_co_truncate().
Check the offset.
And one public structure: BdrvTrackedRequest. Happily, it has only
three external users:
file-posix.c: adopted by this patch
write-threshold.c: only read fields
test-write-threshold.c: sets obviously small constant values
Better is to make the structure private and add corresponding
interfaces.. Still it's not obvious what kind of interface is needed
for file-posix.c. Let's keep it public but add corresponding
assertions.
After this patch we'll convert functions in block/io.c to int64_t bytes
and offset parameters. We can assume that offset/bytes pair always
satisfy new restrictions, and make
corresponding assertions where needed. If we reach some offset/bytes
point in block/io.c missing bdrv_check_request() it is considered a
bug. As well, if block/io.c modifies a offset/bytes request, expanding
it more then aligning up to request_alignment, it's a bug too.
For all io requests except for discard we keep for now old restriction
of 32bit request length.
iotest 206 output error message changed, as now test disk size is
larger than new limit. Add one more test case with new maximum disk
size to cover too-big-L1 case.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201203222713.13507-5-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-12-04 01:27:13 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2023-06-01 14:51:44 +03:00
|
|
|
old_size = bdrv_co_getlength(bs);
|
2018-06-26 15:23:23 +03:00
|
|
|
if (old_size < 0) {
|
|
|
|
error_setg_errno(errp, -old_size, "Failed to get old image size");
|
|
|
|
return old_size;
|
|
|
|
}
|
|
|
|
|
2021-06-09 19:30:34 +03:00
|
|
|
if (bdrv_is_read_only(bs)) {
|
|
|
|
error_setg(errp, "Image is read-only");
|
|
|
|
return -EACCES;
|
|
|
|
}
|
|
|
|
|
2018-06-26 15:23:23 +03:00
|
|
|
if (offset > old_size) {
|
|
|
|
new_bytes = offset - old_size;
|
|
|
|
} else {
|
|
|
|
new_bytes = 0;
|
|
|
|
}
|
|
|
|
|
2018-06-26 14:55:20 +03:00
|
|
|
bdrv_inc_in_flight(bs);
|
2018-07-10 09:31:23 +03:00
|
|
|
tracked_request_begin(&req, bs, offset - new_bytes, new_bytes,
|
|
|
|
BDRV_TRACKED_TRUNCATE);
|
2018-06-26 15:23:23 +03:00
|
|
|
|
|
|
|
/* If we are growing the image and potentially using preallocation for the
|
|
|
|
* new area, we need to make sure that no write requests are made to it
|
|
|
|
* concurrently or they might be overwritten by preallocation. */
|
|
|
|
if (new_bytes) {
|
2020-10-21 17:58:43 +03:00
|
|
|
bdrv_make_request_serialising(&req, 1);
|
2018-07-10 09:31:24 +03:00
|
|
|
}
|
|
|
|
ret = bdrv_co_write_req_prepare(child, offset - new_bytes, new_bytes, &req,
|
|
|
|
0);
|
|
|
|
if (ret < 0) {
|
|
|
|
error_setg_errno(errp, -ret,
|
|
|
|
"Failed to prepare request for truncation");
|
|
|
|
goto out;
|
2018-06-26 15:23:23 +03:00
|
|
|
}
|
2018-06-26 14:55:20 +03:00
|
|
|
|
2019-06-12 18:03:38 +03:00
|
|
|
filtered = bdrv_filter_child(bs);
|
2020-06-18 18:39:28 +03:00
|
|
|
backing = bdrv_cow_child(bs);
|
2019-06-12 18:03:38 +03:00
|
|
|
|
2020-04-24 15:54:45 +03:00
|
|
|
/*
|
|
|
|
* If the image has a backing file that is large enough that it would
|
|
|
|
* provide data for the new area, we cannot leave it unallocated because
|
|
|
|
* then the backing file content would become visible. Instead, zero-fill
|
|
|
|
* the new area.
|
|
|
|
*
|
|
|
|
* Note that if the image has a backing file, but was opened without the
|
|
|
|
* backing file, taking care of keeping things consistent with that backing
|
|
|
|
* file is the user's responsibility.
|
|
|
|
*/
|
2020-06-18 18:39:28 +03:00
|
|
|
if (new_bytes && backing) {
|
2020-04-24 15:54:45 +03:00
|
|
|
int64_t backing_len;
|
|
|
|
|
2023-01-13 23:42:06 +03:00
|
|
|
backing_len = bdrv_co_getlength(backing->bs);
|
2020-04-24 15:54:45 +03:00
|
|
|
if (backing_len < 0) {
|
|
|
|
ret = backing_len;
|
|
|
|
error_setg_errno(errp, -ret, "Could not get backing file size");
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (backing_len > old_size) {
|
|
|
|
flags |= BDRV_REQ_ZERO_WRITE;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-09-18 12:51:37 +03:00
|
|
|
if (drv->bdrv_co_truncate) {
|
2020-04-24 15:54:39 +03:00
|
|
|
if (flags & ~bs->supported_truncate_flags) {
|
|
|
|
error_setg(errp, "Block driver does not support requested flags");
|
|
|
|
ret = -ENOTSUP;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
ret = drv->bdrv_co_truncate(bs, offset, exact, prealloc, flags, errp);
|
2019-06-12 18:03:38 +03:00
|
|
|
} else if (filtered) {
|
|
|
|
ret = bdrv_co_truncate(filtered, offset, exact, prealloc, flags, errp);
|
2019-09-18 12:51:37 +03:00
|
|
|
} else {
|
2018-06-26 14:55:20 +03:00
|
|
|
error_setg(errp, "Image format driver does not support resize");
|
|
|
|
ret = -ENOTSUP;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
if (ret < 0) {
|
|
|
|
goto out;
|
|
|
|
}
|
2019-09-18 12:51:37 +03:00
|
|
|
|
2023-01-13 23:42:06 +03:00
|
|
|
ret = bdrv_co_refresh_total_sectors(bs, offset >> BDRV_SECTOR_BITS);
|
2018-06-26 14:55:20 +03:00
|
|
|
if (ret < 0) {
|
|
|
|
error_setg_errno(errp, -ret, "Could not refresh total sector count");
|
|
|
|
} else {
|
|
|
|
offset = bs->total_sectors * BDRV_SECTOR_SIZE;
|
|
|
|
}
|
2023-01-13 23:42:03 +03:00
|
|
|
/*
|
|
|
|
* It's possible that truncation succeeded but bdrv_refresh_total_sectors
|
2018-07-10 09:31:24 +03:00
|
|
|
* failed, but the latter doesn't affect how we should finish the request.
|
2023-01-13 23:42:03 +03:00
|
|
|
* Pass 0 as the last parameter so that dirty bitmaps etc. are handled.
|
|
|
|
*/
|
2018-07-10 09:31:24 +03:00
|
|
|
bdrv_co_write_req_finish(child, offset - new_bytes, new_bytes, &req, 0);
|
2018-06-26 14:55:20 +03:00
|
|
|
|
|
|
|
out:
|
2018-06-26 15:23:23 +03:00
|
|
|
tracked_request_end(&req);
|
2018-06-26 14:55:20 +03:00
|
|
|
bdrv_dec_in_flight(bs);
|
2018-06-26 15:23:23 +03:00
|
|
|
|
2018-06-26 14:55:20 +03:00
|
|
|
return ret;
|
|
|
|
}
|
2021-02-05 19:37:11 +03:00
|
|
|
|
|
|
|
void bdrv_cancel_in_flight(BlockDriverState *bs)
|
|
|
|
{
|
2022-03-03 18:15:49 +03:00
|
|
|
GLOBAL_STATE_CODE();
|
2023-10-27 18:53:29 +03:00
|
|
|
GRAPH_RDLOCK_GUARD_MAINLOOP();
|
|
|
|
|
2021-02-05 19:37:11 +03:00
|
|
|
if (!bs || !bs->drv) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (bs->drv->bdrv_cancel_in_flight) {
|
|
|
|
bs->drv->bdrv_cancel_in_flight(bs);
|
|
|
|
}
|
|
|
|
}
|
2022-03-03 22:43:43 +03:00
|
|
|
|
|
|
|
int coroutine_fn
|
|
|
|
bdrv_co_preadv_snapshot(BdrvChild *child, int64_t offset, int64_t bytes,
|
|
|
|
QEMUIOVector *qiov, size_t qiov_offset)
|
|
|
|
{
|
|
|
|
BlockDriverState *bs = child->bs;
|
|
|
|
BlockDriver *drv = bs->drv;
|
|
|
|
int ret;
|
|
|
|
IO_CODE();
|
2023-02-03 18:21:54 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2022-03-03 22:43:43 +03:00
|
|
|
|
|
|
|
if (!drv) {
|
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!drv->bdrv_co_preadv_snapshot) {
|
|
|
|
return -ENOTSUP;
|
|
|
|
}
|
|
|
|
|
|
|
|
bdrv_inc_in_flight(bs);
|
|
|
|
ret = drv->bdrv_co_preadv_snapshot(bs, offset, bytes, qiov, qiov_offset);
|
|
|
|
bdrv_dec_in_flight(bs);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
int coroutine_fn
|
|
|
|
bdrv_co_snapshot_block_status(BlockDriverState *bs,
|
|
|
|
bool want_zero, int64_t offset, int64_t bytes,
|
|
|
|
int64_t *pnum, int64_t *map,
|
|
|
|
BlockDriverState **file)
|
|
|
|
{
|
|
|
|
BlockDriver *drv = bs->drv;
|
|
|
|
int ret;
|
|
|
|
IO_CODE();
|
2023-02-03 18:21:54 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2022-03-03 22:43:43 +03:00
|
|
|
|
|
|
|
if (!drv) {
|
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!drv->bdrv_co_snapshot_block_status) {
|
|
|
|
return -ENOTSUP;
|
|
|
|
}
|
|
|
|
|
|
|
|
bdrv_inc_in_flight(bs);
|
|
|
|
ret = drv->bdrv_co_snapshot_block_status(bs, want_zero, offset, bytes,
|
|
|
|
pnum, map, file);
|
|
|
|
bdrv_dec_in_flight(bs);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
int coroutine_fn
|
|
|
|
bdrv_co_pdiscard_snapshot(BlockDriverState *bs, int64_t offset, int64_t bytes)
|
|
|
|
{
|
|
|
|
BlockDriver *drv = bs->drv;
|
|
|
|
int ret;
|
|
|
|
IO_CODE();
|
2023-02-03 18:21:47 +03:00
|
|
|
assert_bdrv_graph_readable();
|
2022-03-03 22:43:43 +03:00
|
|
|
|
|
|
|
if (!drv) {
|
|
|
|
return -ENOMEDIUM;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!drv->bdrv_co_pdiscard_snapshot) {
|
|
|
|
return -ENOTSUP;
|
|
|
|
}
|
|
|
|
|
|
|
|
bdrv_inc_in_flight(bs);
|
|
|
|
ret = drv->bdrv_co_pdiscard_snapshot(bs, offset, bytes);
|
|
|
|
bdrv_dec_in_flight(bs);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|