mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
postgres/src/backend/utils/adt
History
Tom Lane ddc8893179 Fix miserable coding in pg_stat_get_activity(). 
Commit dd1a3bccc replaced a test on whether a subroutine returned a
null pointer with a test on whether &pointer->backendStatus was null.
This accidentally failed to fail, at least on common compilers, because
backendStatus is the first field in the struct; but it was surely trouble
waiting to happen.  Commit f91feba87 then messed things up further,
changing the logic to

	local_beentry = pgstat_fetch_stat_local_beentry(curr_backend);
	if (!local_beentry)
		continue;
	beentry = &local_beentry->backendStatus;
	if (!beentry)
	{

where the second "if" is now dead code, so that the intended behavior of
printing a row with "<backend information not available>" cannot occur.

I suspect this is all moot because pgstat_fetch_stat_local_beentry
will never actually return null in this function's usage, but it's still
very poor coding.  Repair back to 9.4 where the original problem was
introduced.
2016-09-10 13:49:04 -04:00
..
acl.c
Message style improvements
2016-07-25 22:07:44 -04:00
amutils.c
Suppress compiler warnings in non-cassert builds.
2016-08-23 23:21:10 -04:00
array_expanded.c
Add macros to make AllocSetContextCreate() calls simpler and safer.
2016-08-27 17:50:38 -04:00
array_selfuncs.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
array_typanalyze.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
array_userfuncs.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
arrayfuncs.c
Add macros to make AllocSetContextCreate() calls simpler and safer.
2016-08-27 17:50:38 -04:00
arrayutils.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
ascii.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
bool.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
cash.c
Collection of typo fixes.
2015-05-20 16:56:22 +03:00
char.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
date.c
Improve parsetree representation of special functions such as CURRENT_DATE.
2016-08-16 20:33:01 -04:00
datetime.c
Don't require dynamic timezone abbreviations to match underlying time zone.
2016-09-02 17:30:02 -04:00
datum.c
pgindent run for 9.6
2016-06-09 18:02:36 -04:00
dbsize.c
Suppress -Wunused-result warning for strtol().
2016-08-16 16:14:16 -04:00
domains.c
Avoid reporting "cache lookup failed" for some user-reachable cases.
2016-09-09 09:20:34 -04:00
encode.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
enum.c
Relax transactional restrictions on ALTER TYPE ... ADD VALUE.
2016-09-05 12:59:55 -04:00
expandeddatum.c
Inline the easy cases in MakeExpandedObjectReadOnly().
2016-06-03 18:34:05 -04:00
float.c
Fix GiST index build for NaN values in geometric types.
2016-07-14 18:45:59 -04:00
format_type.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
formatting.c
Fix several one-byte buffer over-reads in to_number
2016-08-08 11:12:59 -04:00
genfile.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
geo_ops.c
Fix crash in close_ps() for NaN input coordinates.
2016-07-16 14:42:37 -04:00
geo_selfuncs.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
geo_spgist.c
pgindent run for 9.6
2016-06-09 18:02:36 -04:00
inet_cidr_ntop.c
pgindent run for 9.4
2014-05-06 12:12:18 -04:00
inet_net_pton.c
Fix validation of overly-long IPv6 addresses.
2016-06-16 17:16:32 -04:00
int8.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
int.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
json.c
Fix typos.
2016-03-15 18:06:11 -04:00
jsonb_gin.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
jsonb_op.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
jsonb_util.c
pgindent run for 9.6
2016-06-09 18:02:36 -04:00
jsonb.c
Final pgindent + perltidy run for 9.6.
2016-08-15 13:42:51 -04:00
jsonfuncs.c
Add macros to make AllocSetContextCreate() calls simpler and safer.
2016-08-27 17:50:38 -04:00
levenshtein.c
Remove new coupling between NAMEDATALEN and MAX_LEVENSHTEIN_STRLEN.
2016-01-22 11:53:06 -05:00
like_match.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
like.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
lockfuncs.c
Provide much better wait information in pg_stat_activity.
2016-03-10 12:44:09 -05:00
mac.c
Allow input format xxxx-xxxx-xxxx for macaddr type
2014-10-21 16:16:39 -04:00
Makefile
Create an SP-GiST opclass for inet/cidr.
2016-08-23 15:16:30 -04:00
misc.c
Adjust spellings of forms of "cancel"
2016-07-14 22:48:26 -04:00
nabstime.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
name.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
network_gist.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
network_selfuncs.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
network_spgist.c
Fix network_spgist.c build failures from missing AF_INET definition.
2016-08-23 16:25:35 -04:00
network.c
Move code shared between libpq and backend from backend/libpq/ to common/.
2016-09-02 13:49:59 +03:00
numeric.c
Fix multiple bugs in numeric_poly_deserialize().
2016-09-03 14:18:55 -04:00
numutils.c
Use PG_INT32_MIN instead of reiterating the constant.
2016-04-13 07:54:45 -04:00
oid.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
oracle_compat.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
orderedsetaggs.c
Reuse abbreviated keys in ordered [set] aggregates.
2016-02-17 15:40:00 +05:30
pg_locale.c
Avoid multiple free_struct_lconv() calls on same data.
2016-02-28 23:39:20 -05:00
pg_lsn.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
pg_upgrade_support.c
In pg_dump, include pg_catalog and extension ACLs, if changed
2016-04-06 21:45:32 -04:00
pgstatfuncs.c
Fix miserable coding in pg_stat_get_activity().
2016-09-10 13:49:04 -04:00
pseudotypes.c
Restructure index access method API to hide most of it at the C level.
2016-01-17 19:36:59 -05:00
quote.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
rangetypes_gist.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
rangetypes_selfuncs.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
rangetypes_spgist.c
pgindent run for 9.6
2016-06-09 18:02:36 -04:00
rangetypes_typanalyze.c
Fix misestimation of n_distinct for a nearly-unique column with many nulls.
2016-08-07 18:52:02 -04:00
rangetypes.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
regexp.c
Implement regexp_match(), a simplified alternative to regexp_matches().
2016-08-17 18:33:01 -04:00
regproc.c
Make the to_reg*() functions accept text not cstring.
2016-01-05 13:02:43 -05:00
ri_triggers.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
rowtypes.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
ruleutils.c
Improve parsetree representation of special functions such as CURRENT_DATE.
2016-08-16 20:33:01 -04:00
selfuncs.c
Fix misestimation of n_distinct for a nearly-unique column with many nulls.
2016-08-07 18:52:02 -04:00
tid.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
timestamp.c
Improve parsetree representation of special functions such as CURRENT_DATE.
2016-08-16 20:33:01 -04:00
trigfuncs.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
tsginidx.c
Do not fallback to AND for FTS phrase operator.
2016-06-27 20:47:32 +03:00
tsgistidx.c
Do not fallback to AND for FTS phrase operator.
2016-06-27 20:47:32 +03:00
tsquery_cleanup.c
Final pgindent + perltidy run for 9.6.
2016-08-15 13:42:51 -04:00
tsquery_gist.c
Create stub functions to support pg_upgrade of old contrib/tsearch2.
2016-03-02 17:37:54 -05:00
tsquery_op.c
pgindent run for 9.6
2016-06-09 18:02:36 -04:00
tsquery_rewrite.c
Widen query numbers-of-tuples-processed counters to uint64.
2016-03-12 16:05:29 -05:00
tsquery_util.c
Phrase full text search.
2016-04-07 18:44:18 +03:00
tsquery.c
Fix typos
2016-08-16 14:52:29 -04:00
tsrank.c
Do not fallback to AND for FTS phrase operator.
2016-06-27 20:47:32 +03:00
tsvector_op.c
Make array_to_tsvector() sort and de-duplicate the given strings.
2016-08-05 16:09:06 -04:00
tsvector_parser.c
Phrase full text search.
2016-04-07 18:44:18 +03:00
tsvector.c
Rename comparePos() to compareWordEntryPos()
2016-04-08 12:04:15 +03:00
txid.c
Add txid_current_ifassigned().
2016-08-23 10:30:52 -04:00
uuid.c
pgindent run for 9.6
2016-06-09 18:02:36 -04:00
varbit.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
varchar.c
Extend sortsupport for text to more opclasses.
2016-02-03 14:29:53 -05:00
varlena.c
Move code shared between libpq and backend from backend/libpq/ to common/.
2016-09-02 13:49:59 +03:00
version.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
windowfuncs.c
Fix typos.
2016-03-15 18:06:11 -04:00
xid.c
Update copyright for 2016
2016-01-02 13:33:40 -05:00
xml.c
Add macros to make AllocSetContextCreate() calls simpler and safer.
2016-08-27 17:50:38 -04:00