mirror of https://github.com/postgres/postgres
ff720a597c
The planner has to special-case indexes on boolean columns, because what we need for an indexscan on such a column is a qual of the shape of "boolvar = pseudoconstant". For plain bool constants, previous simplification will have reduced this to "boolvar" or "NOT boolvar", and we have to reverse that if we want to make an indexqual. There is existing code to do so, but it only fires when the index's opfamily is BOOL_BTREE_FAM_OID or BOOL_HASH_FAM_OID. Thus extension AMs, or extension opclasses such as contrib/btree_gin, are out in the cold. The reason for hard-wiring the set of relevant opfamilies was mostly to avoid a catalog lookup in a hot code path. We can improve matters while not taking much of a performance hit by relying on the hard-wired set when the opfamily OID is visibly built-in, and only checking the catalogs when dealing with an extension opfamily. While here, rename IsBooleanOpfamily to IsBuiltinBooleanOpfamily to remind future users of that macro of its limitations. At some point we might want to make indxpath.c's improved version of the test globally accessible, but it's not presently needed elsewhere. Zongliang Quan and Tom Lane Discussion: https://postgr.es/m/f293b91d-1d46-d386-b6bb-4b06ff5c667b@yeah.net |
||
|---|---|---|
| .. | ||
| bit.out | ||
| bool.out | ||
| bpchar.out | ||
| bytea.out | ||
| char.out | ||
| cidr.out | ||
| date.out | ||
| enum.out | ||
| float4.out | ||
| float8.out | ||
| inet.out | ||
| install_btree_gin.out | ||
| int2.out | ||
| int4.out | ||
| int8.out | ||
| interval.out | ||
| macaddr.out | ||
| macaddr8.out | ||
| money.out | ||
| name.out | ||
| numeric.out | ||
| oid.out | ||
| text.out | ||
| time.out | ||
| timestamp.out | ||
| timestamptz.out | ||
| timetz.out | ||
| uuid.out | ||
| varbit.out | ||
| varchar.out | ||