c788115b5e
The data types that contrib/pageinspect's bt_metap() function were declared to return as OUT arguments were wrong in some cases. In particular, the oldest_xact column (a TransactionId/xid field) was declared integer/int4 within the pageinspect extension's sql file. This led to errors when an oldest_xact value that exceeded 2^31-1 was encountered. We cannot fix the declaration on Postgres 11 or 12. All we can do is ameliorate the problem. Use "%d" instead of "%u" to format the output of the oldest_xact value. This makes the C code match the declaration, suppressing unhelpful error messages that might otherwise make bt_metap() totally unusable. A bogus negative oldest_xact value will be displayed instead of raising an error. This commit addresses the same issue as master branch commit 691e8b2e18, which actually fixed the problem. Backpatch to the 11 and 12 branches only, since they are the only branches (other than master) that have oldest_xact. All of the other problematic columns already display bogus output for out of range values. Reported-By: Victor Yegorov Bug: #16285 Discussion: https://postgr.es/m/20200309223557.aip5n6ewln4ixbbi@alap3.anarazel.de Backpatch: 11 and 12 only
The PostgreSQL contrib tree
---------------------------
This subtree contains porting tools, analysis utilities, and plug-in
features that are not part of the core PostgreSQL system, mainly
because they address a limited audience or are too experimental to be
part of the main source tree. This does not preclude their
usefulness.
User documentation for each module appears in the main SGML
documentation.
When building from the source distribution, these modules are not
built automatically, unless you build the "world" target. You can
also build and install them all by running "make all" and "make
install" in this directory; or to build and install just one selected
module, do the same in that module's subdirectory.
Some directories supply new user-defined functions, operators, or
types. To make use of one of these modules, after you have installed
the code you need to register the new SQL objects in the database
system by executing a CREATE EXTENSION command. In a fresh database,
you can simply do
CREATE EXTENSION module_name;
See the PostgreSQL documentation for more information about this
procedure.