postgres/contrib/postgres_fdw
Fujii Masao a84f95ffdd Avoid using ambiguous word "non-negative" in error messages.
The error messages using the word "non-negative" are confusing
because it's ambiguous about whether it accepts zero or not.
This commit improves those error messages by replacing it with
less ambiguous word like "greater than zero" or
"greater than or equal to zero".

Also this commit added the note about the word "non-negative" to
the error message style guide, to help writing the new error messages.

When postgres_fdw option fetch_size was set to zero, previously
the error message "fetch_size requires a non-negative integer value"
was reported. This error message was outright buggy. Therefore
back-patch to all supported versions where such buggy error message
could be thrown.

Reported-by: Hou Zhijie
Author: Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi, Fujii Masao
Discussion: https://postgr.es/m/OS0PR01MB5716415335A06B489F1B3A8194569@OS0PR01MB5716.jpnprd01.prod.outlook.com
2021-07-28 01:25:53 +09:00
..
expected Avoid doing catalog lookups in postgres_fdw's conversion_error_callback. 2021-07-06 12:36:13 -04:00
sql Avoid doing catalog lookups in postgres_fdw's conversion_error_callback. 2021-07-06 12:36:13 -04:00
.gitignore
Makefile Prevent accidental linking of system-supplied copies of libpq.so etc. 2018-07-09 17:23:31 -04:00
connection.c postgres_fdw: Fix connection leak. 2020-12-28 20:00:15 +09:00
deparse.c In postgres_fdw, don't try to ship MULTIEXPR updates to remote server. 2020-01-26 14:31:08 -05:00
option.c Avoid using ambiguous word "non-negative" in error messages. 2021-07-28 01:25:53 +09:00
postgres_fdw--1.0.sql
postgres_fdw.c Avoid doing catalog lookups in postgres_fdw's conversion_error_callback. 2021-07-06 12:36:13 -04:00
postgres_fdw.control
postgres_fdw.h Avoid postgres_fdw crash for a targetlist entry that's just a Param. 2019-04-27 13:15:55 -04:00
shippable.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00