4dbdb82513
ff9618e82a introduced has_partition_ancestor_privs(), which is used to check whether a user has MAINTAIN on any partition ancestors. This involves syscache lookups, and presently this function does not take any relation locks, so it is likely subject to the same kind of cache lookup failures that were fixed by 19de0ab23c. To fix this problem, this commit partially reverts ff9618e82a. Specifically, it removes the partition-related changes, including the has_partition_ancestor_privs() function mentioned above. This means that MAINTAIN on a partitioned table is no longer sufficient to perform maintenance commands on its partitions. This is more like how privileges for maintenance commands work on supported versions. Privileges are checked for each partition, so a command that flows down to all partitions might refuse to process them (e.g., if the current user doesn't have MAINTAIN on the partition). In passing, adjust a few related comments and error messages, and add a test for the privilege checks for CLUSTER on a partitioned table. Reviewed-by: Michael Paquier, Jeff Davis Discussion: https://postgr.es/m/20230613211246.GA219055%40nathanxps13
109 lines
3.5 KiB
C
109 lines
3.5 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* tablecmds.h
|
|
* prototypes for tablecmds.c.
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2023, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/commands/tablecmds.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef TABLECMDS_H
|
|
#define TABLECMDS_H
|
|
|
|
#include "access/htup.h"
|
|
#include "catalog/dependency.h"
|
|
#include "catalog/objectaddress.h"
|
|
#include "nodes/parsenodes.h"
|
|
#include "storage/lock.h"
|
|
#include "utils/relcache.h"
|
|
|
|
struct AlterTableUtilityContext; /* avoid including tcop/utility.h here */
|
|
|
|
|
|
extern ObjectAddress DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,
|
|
ObjectAddress *typaddress, const char *queryString);
|
|
|
|
extern void RemoveRelations(DropStmt *drop);
|
|
|
|
extern Oid AlterTableLookupRelation(AlterTableStmt *stmt, LOCKMODE lockmode);
|
|
|
|
extern void AlterTable(AlterTableStmt *stmt, LOCKMODE lockmode,
|
|
struct AlterTableUtilityContext *context);
|
|
|
|
extern LOCKMODE AlterTableGetLockLevel(List *cmds);
|
|
|
|
extern void ATExecChangeOwner(Oid relationOid, Oid newOwnerId, bool recursing, LOCKMODE lockmode);
|
|
|
|
extern void AlterTableInternal(Oid relid, List *cmds, bool recurse);
|
|
|
|
extern Oid AlterTableMoveAll(AlterTableMoveAllStmt *stmt);
|
|
|
|
extern ObjectAddress AlterTableNamespace(AlterObjectSchemaStmt *stmt,
|
|
Oid *oldschema);
|
|
|
|
extern void AlterTableNamespaceInternal(Relation rel, Oid oldNspOid,
|
|
Oid nspOid, ObjectAddresses *objsMoved);
|
|
|
|
extern void AlterRelationNamespaceInternal(Relation classRel, Oid relOid,
|
|
Oid oldNspOid, Oid newNspOid,
|
|
bool hasDependEntry,
|
|
ObjectAddresses *objsMoved);
|
|
|
|
extern void CheckTableNotInUse(Relation rel, const char *stmt);
|
|
|
|
extern void ExecuteTruncate(TruncateStmt *stmt);
|
|
extern void ExecuteTruncateGuts(List *explicit_rels,
|
|
List *relids,
|
|
List *relids_logged,
|
|
DropBehavior behavior,
|
|
bool restart_seqs,
|
|
bool run_as_table_owner);
|
|
|
|
extern void SetRelationHasSubclass(Oid relationId, bool relhassubclass);
|
|
|
|
extern bool CheckRelationTableSpaceMove(Relation rel, Oid newTableSpaceId);
|
|
extern void SetRelationTableSpace(Relation rel, Oid newTableSpaceId,
|
|
RelFileNumber newRelFilenumber);
|
|
|
|
extern ObjectAddress renameatt(RenameStmt *stmt);
|
|
|
|
extern ObjectAddress RenameConstraint(RenameStmt *stmt);
|
|
|
|
extern ObjectAddress RenameRelation(RenameStmt *stmt);
|
|
|
|
extern void RenameRelationInternal(Oid myrelid,
|
|
const char *newrelname, bool is_internal,
|
|
bool is_index);
|
|
|
|
extern void ResetRelRewrite(Oid myrelid);
|
|
|
|
extern void find_composite_type_dependencies(Oid typeOid,
|
|
Relation origRelation,
|
|
const char *origTypeName);
|
|
|
|
extern void check_of_type(HeapTuple typetuple);
|
|
|
|
extern void register_on_commit_action(Oid relid, OnCommitAction action);
|
|
extern void remove_on_commit_action(Oid relid);
|
|
|
|
extern void PreCommit_on_commit_actions(void);
|
|
extern void AtEOXact_on_commit_actions(bool isCommit);
|
|
extern void AtEOSubXact_on_commit_actions(bool isCommit,
|
|
SubTransactionId mySubid,
|
|
SubTransactionId parentSubid);
|
|
|
|
extern void RangeVarCallbackMaintainsTable(const RangeVar *relation,
|
|
Oid relId, Oid oldRelId,
|
|
void *arg);
|
|
|
|
extern void RangeVarCallbackOwnsRelation(const RangeVar *relation,
|
|
Oid relId, Oid oldRelId, void *arg);
|
|
extern bool PartConstraintImpliedByRelConstraint(Relation scanrel,
|
|
List *partConstraint);
|
|
|
|
#endif /* TABLECMDS_H */
|