
Change assorted places in our Perl code that did things like system("prog $path/file"); to do it more like system('prog', "$path/file"); which is safe against spaces and other special characters in the path variable. The latter was already the prevailing style, but a few bits of code hadn't gotten this memo. Back-patch to 9.4 as relevant. Michael Paquier, Kyotaro Horiguchi Discussion: <20160704.160213.111134711.horiguchi.kyotaro@lab.ntt.co.jp>
574 lines
14 KiB
Perl
574 lines
14 KiB
Perl
# -*-perl-*- hey - emacs - this is a perl file
|
|
|
|
# src/tools/msvc/vcregress.pl
|
|
|
|
use strict;
|
|
|
|
our $config;
|
|
|
|
use Cwd;
|
|
use File::Basename;
|
|
use File::Copy;
|
|
use File::Find ();
|
|
|
|
use Install qw(Install);
|
|
|
|
my $startdir = getcwd();
|
|
|
|
chdir "../../.." if (-d "../../../src/tools/msvc");
|
|
|
|
my $topdir = getcwd();
|
|
my $tmp_installdir = "$topdir/tmp_install";
|
|
|
|
require 'src/tools/msvc/config_default.pl';
|
|
require 'src/tools/msvc/config.pl' if (-f 'src/tools/msvc/config.pl');
|
|
|
|
# buildenv.pl is for specifying the build environment settings
|
|
# it should contain lines like:
|
|
# $ENV{PATH} = "c:/path/to/bison/bin;$ENV{PATH}";
|
|
|
|
if (-e "src/tools/msvc/buildenv.pl")
|
|
{
|
|
require "src/tools/msvc/buildenv.pl";
|
|
}
|
|
|
|
my $what = shift || "";
|
|
if ($what =~
|
|
/^(check|installcheck|plcheck|contribcheck|modulescheck|ecpgcheck|isolationcheck|upgradecheck|bincheck|recoverycheck)$/i
|
|
)
|
|
{
|
|
$what = uc $what;
|
|
}
|
|
else
|
|
{
|
|
usage();
|
|
}
|
|
|
|
# use a capital C here because config.pl has $config
|
|
my $Config = -e "release/postgres/postgres.exe" ? "Release" : "Debug";
|
|
|
|
copy("$Config/refint/refint.dll", "src/test/regress");
|
|
copy("$Config/autoinc/autoinc.dll", "src/test/regress");
|
|
copy("$Config/regress/regress.dll", "src/test/regress");
|
|
copy("$Config/dummy_seclabel/dummy_seclabel.dll", "src/test/regress");
|
|
|
|
$ENV{PATH} = "$topdir/$Config/libpq;$ENV{PATH}";
|
|
|
|
my $schedule = shift;
|
|
unless ($schedule)
|
|
{
|
|
$schedule = "serial";
|
|
$schedule = "parallel" if ($what eq 'CHECK' || $what =~ /PARALLEL/);
|
|
}
|
|
|
|
if ($ENV{PERL5LIB})
|
|
{
|
|
$ENV{PERL5LIB} = "$topdir/src/tools/msvc;$ENV{PERL5LIB}";
|
|
}
|
|
else
|
|
{
|
|
$ENV{PERL5LIB} = "$topdir/src/tools/msvc";
|
|
}
|
|
|
|
my $maxconn = "";
|
|
$maxconn = "--max_connections=$ENV{MAX_CONNECTIONS}"
|
|
if $ENV{MAX_CONNECTIONS};
|
|
|
|
my $temp_config = "";
|
|
$temp_config = "--temp-config=\"$ENV{TEMP_CONFIG}\""
|
|
if $ENV{TEMP_CONFIG};
|
|
|
|
chdir "src/test/regress";
|
|
|
|
my %command = (
|
|
CHECK => \&check,
|
|
PLCHECK => \&plcheck,
|
|
INSTALLCHECK => \&installcheck,
|
|
ECPGCHECK => \&ecpgcheck,
|
|
CONTRIBCHECK => \&contribcheck,
|
|
MODULESCHECK => \&modulescheck,
|
|
ISOLATIONCHECK => \&isolationcheck,
|
|
BINCHECK => \&bincheck,
|
|
RECOVERYCHECK => \&recoverycheck,
|
|
UPGRADECHECK => \&upgradecheck,);
|
|
|
|
my $proc = $command{$what};
|
|
|
|
exit 3 unless $proc;
|
|
|
|
&$proc();
|
|
|
|
exit 0;
|
|
|
|
########################################################################
|
|
|
|
sub installcheck
|
|
{
|
|
my @args = (
|
|
"../../../$Config/pg_regress/pg_regress",
|
|
"--dlpath=.",
|
|
"--bindir=../../../$Config/psql",
|
|
"--schedule=${schedule}_schedule",
|
|
"--encoding=SQL_ASCII",
|
|
"--no-locale");
|
|
push(@args, $maxconn) if $maxconn;
|
|
system(@args);
|
|
my $status = $? >> 8;
|
|
exit $status if $status;
|
|
}
|
|
|
|
sub check
|
|
{
|
|
InstallTemp();
|
|
chdir "${topdir}/src/test/regress";
|
|
my @args = (
|
|
"../../../$Config/pg_regress/pg_regress",
|
|
"--dlpath=.",
|
|
"--bindir=",
|
|
"--schedule=${schedule}_schedule",
|
|
"--encoding=SQL_ASCII",
|
|
"--no-locale",
|
|
"--temp-instance=./tmp_check");
|
|
push(@args, $maxconn) if $maxconn;
|
|
push(@args, $temp_config) if $temp_config;
|
|
system(@args);
|
|
my $status = $? >> 8;
|
|
exit $status if $status;
|
|
}
|
|
|
|
sub ecpgcheck
|
|
{
|
|
chdir $startdir;
|
|
system("msbuild ecpg_regression.proj /p:config=$Config");
|
|
my $status = $? >> 8;
|
|
exit $status if $status;
|
|
InstallTemp();
|
|
chdir "$topdir/src/interfaces/ecpg/test";
|
|
$schedule = "ecpg";
|
|
my @args = (
|
|
"../../../../$Config/pg_regress_ecpg/pg_regress_ecpg",
|
|
"--bindir=",
|
|
"--dbname=regress1,connectdb",
|
|
"--create-role=connectuser,connectdb",
|
|
"--schedule=${schedule}_schedule",
|
|
"--encoding=SQL_ASCII",
|
|
"--no-locale",
|
|
"--temp-instance=./tmp_chk");
|
|
push(@args, $maxconn) if $maxconn;
|
|
system(@args);
|
|
$status = $? >> 8;
|
|
exit $status if $status;
|
|
}
|
|
|
|
sub isolationcheck
|
|
{
|
|
chdir "../isolation";
|
|
copy("../../../$Config/isolationtester/isolationtester.exe",
|
|
"../../../$Config/pg_isolation_regress");
|
|
my @args = (
|
|
"../../../$Config/pg_isolation_regress/pg_isolation_regress",
|
|
"--bindir=../../../$Config/psql",
|
|
"--inputdir=.",
|
|
"--schedule=./isolation_schedule");
|
|
push(@args, $maxconn) if $maxconn;
|
|
system(@args);
|
|
my $status = $? >> 8;
|
|
exit $status if $status;
|
|
}
|
|
|
|
sub tap_check
|
|
{
|
|
die "Tap tests not enabled in configuration"
|
|
unless $config->{tap_tests};
|
|
|
|
my $dir = shift;
|
|
chdir $dir;
|
|
|
|
my @args = ("prove", "--verbose", "t/*.pl");
|
|
|
|
# adjust the environment for just this test
|
|
local %ENV = %ENV;
|
|
$ENV{PERL5LIB} = "$topdir/src/test/perl;$ENV{PERL5LIB}";
|
|
$ENV{PG_REGRESS} = "$topdir/$Config/pg_regress/pg_regress";
|
|
|
|
$ENV{TESTDIR} = "$dir";
|
|
|
|
system(@args);
|
|
my $status = $? >> 8;
|
|
return $status;
|
|
}
|
|
|
|
sub bincheck
|
|
{
|
|
InstallTemp();
|
|
|
|
my $mstat = 0;
|
|
|
|
# Find out all the existing TAP tests by looking for t/ directories
|
|
# in the tree.
|
|
my @bin_dirs = glob("$topdir/src/bin/*");
|
|
|
|
# Process each test
|
|
foreach my $dir (@bin_dirs)
|
|
{
|
|
next unless -d "$dir/t";
|
|
my $status = tap_check($dir);
|
|
$mstat ||= $status;
|
|
}
|
|
exit $mstat if $mstat;
|
|
}
|
|
|
|
sub plcheck
|
|
{
|
|
chdir "../../pl";
|
|
|
|
foreach my $pl (glob("*"))
|
|
{
|
|
next unless -d "$pl/sql" && -d "$pl/expected";
|
|
my $lang = $pl eq 'tcl' ? 'pltcl' : $pl;
|
|
if ($lang eq 'plpython')
|
|
{
|
|
next unless -d "../../$Config/plpython2";
|
|
$lang = 'plpythonu';
|
|
}
|
|
else
|
|
{
|
|
next unless -d "../../$Config/$lang";
|
|
}
|
|
my @lang_args = ("--load-extension=$lang");
|
|
chdir $pl;
|
|
my @tests = fetchTests();
|
|
if ($lang eq 'plperl')
|
|
{
|
|
|
|
# run both trusted and untrusted perl tests
|
|
push(@lang_args, "--load-extension=plperlu");
|
|
|
|
# assume we're using this perl to built postgres
|
|
# test if we can run two interpreters in one backend, and if so
|
|
# run the trusted/untrusted interaction tests
|
|
use Config;
|
|
if ($Config{usemultiplicity} eq 'define')
|
|
{
|
|
push(@tests, 'plperl_plperlu');
|
|
}
|
|
}
|
|
print
|
|
"============================================================\n";
|
|
print "Checking $lang\n";
|
|
my @args = (
|
|
"../../../$Config/pg_regress/pg_regress",
|
|
"--bindir=../../../$Config/psql",
|
|
"--dbname=pl_regression", @lang_args, @tests);
|
|
system(@args);
|
|
my $status = $? >> 8;
|
|
exit $status if $status;
|
|
chdir "..";
|
|
}
|
|
|
|
chdir "../../..";
|
|
}
|
|
|
|
sub subdircheck
|
|
{
|
|
my $subdir = shift;
|
|
my $module = shift;
|
|
|
|
if ( !-d "$module/sql"
|
|
|| !-d "$module/expected"
|
|
|| (!-f "$module/GNUmakefile" && !-f "$module/Makefile"))
|
|
{
|
|
return;
|
|
}
|
|
|
|
chdir $module;
|
|
my @tests = fetchTests();
|
|
my @opts = fetchRegressOpts();
|
|
|
|
# Add some options for transform modules, see their respective
|
|
# Makefile for more details regarding Python-version specific
|
|
# dependencies.
|
|
if ( $module eq "hstore_plpython"
|
|
|| $module eq "ltree_plpython")
|
|
{
|
|
die "Python not enabled in configuration"
|
|
if !defined($config->{python});
|
|
|
|
# Attempt to get python version and location.
|
|
# Assume python.exe in specified dir.
|
|
my $pythonprog = "import sys;" . "print(str(sys.version_info[0]))";
|
|
my $prefixcmd = $config->{python} . "\\python -c \"$pythonprog\"";
|
|
my $pyver = `$prefixcmd`;
|
|
die "Could not query for python version!\n" if $?;
|
|
chomp($pyver);
|
|
if ($pyver eq "2")
|
|
{
|
|
push @opts, "--load-extension=plpythonu";
|
|
push @opts, '--load-extension=' . $module . 'u';
|
|
}
|
|
else
|
|
{
|
|
|
|
# disable tests on python3 for now.
|
|
chdir "..";
|
|
return;
|
|
}
|
|
}
|
|
|
|
|
|
print "============================================================\n";
|
|
print "Checking $module\n";
|
|
my @args = (
|
|
"$topdir/$Config/pg_regress/pg_regress",
|
|
"--bindir=${topdir}/${Config}/psql",
|
|
"--dbname=contrib_regression", @opts, @tests);
|
|
system(@args);
|
|
chdir "..";
|
|
}
|
|
|
|
sub contribcheck
|
|
{
|
|
chdir "../../../contrib";
|
|
my $mstat = 0;
|
|
foreach my $module (glob("*"))
|
|
{
|
|
|
|
# these configuration-based exclusions must match Install.pm
|
|
next if ($module eq "uuid-ossp" && !defined($config->{uuid}));
|
|
next if ($module eq "sslinfo" && !defined($config->{openssl}));
|
|
next if ($module eq "xml2" && !defined($config->{xml}));
|
|
next if ($module eq "hstore_plperl" && !defined($config->{perl}));
|
|
next if ($module eq "hstore_plpython" && !defined($config->{python}));
|
|
next if ($module eq "ltree_plpython" && !defined($config->{python}));
|
|
next if ($module eq "sepgsql");
|
|
|
|
subdircheck("$topdir/contrib", $module);
|
|
my $status = $? >> 8;
|
|
$mstat ||= $status;
|
|
}
|
|
exit $mstat if $mstat;
|
|
}
|
|
|
|
sub modulescheck
|
|
{
|
|
chdir "../../../src/test/modules";
|
|
my $mstat = 0;
|
|
foreach my $module (glob("*"))
|
|
{
|
|
subdircheck("$topdir/src/test/modules", $module);
|
|
my $status = $? >> 8;
|
|
$mstat ||= $status;
|
|
}
|
|
exit $mstat if $mstat;
|
|
}
|
|
|
|
sub recoverycheck
|
|
{
|
|
InstallTemp();
|
|
|
|
my $mstat = 0;
|
|
my $dir = "$topdir/src/test/recovery";
|
|
my $status = tap_check($dir);
|
|
exit $status if $status;
|
|
}
|
|
|
|
# Run "initdb", then reconfigure authentication.
|
|
sub standard_initdb
|
|
{
|
|
return (
|
|
system('initdb', '-N') == 0 and system(
|
|
"$topdir/$Config/pg_regress/pg_regress", '--config-auth',
|
|
$ENV{PGDATA}) == 0);
|
|
}
|
|
|
|
sub upgradecheck
|
|
{
|
|
my $status;
|
|
my $cwd = getcwd();
|
|
|
|
# Much of this comes from the pg_upgrade test.sh script,
|
|
# but it only covers the --install case, and not the case
|
|
# where the old and new source or bin dirs are different.
|
|
# i.e. only this version to this version check. That's
|
|
# what pg_upgrade's "make check" does.
|
|
|
|
$ENV{PGHOST} = 'localhost';
|
|
$ENV{PGPORT} ||= 50432;
|
|
my $tmp_root = "$topdir/src/bin/pg_upgrade/tmp_check";
|
|
(mkdir $tmp_root || die $!) unless -d $tmp_root;
|
|
my $upg_tmp_install = "$tmp_root/install"; # unshared temp install
|
|
print "Setting up temp install\n\n";
|
|
Install($upg_tmp_install, "all", $config);
|
|
|
|
# Install does a chdir, so change back after that
|
|
chdir $cwd;
|
|
my ($bindir, $libdir, $oldsrc, $newsrc) =
|
|
("$upg_tmp_install/bin", "$upg_tmp_install/lib", $topdir, $topdir);
|
|
$ENV{PATH} = "$bindir;$ENV{PATH}";
|
|
my $data = "$tmp_root/data";
|
|
$ENV{PGDATA} = "$data.old";
|
|
my $logdir = "$topdir/src/bin/pg_upgrade/log";
|
|
(mkdir $logdir || die $!) unless -d $logdir;
|
|
print "\nRunning initdb on old cluster\n\n";
|
|
standard_initdb() or exit 1;
|
|
print "\nStarting old cluster\n\n";
|
|
my @args = ('pg_ctl', 'start', '-l', "$logdir/postmaster1.log", '-w');
|
|
system(@args) == 0 or exit 1;
|
|
print "\nSetting up data for upgrading\n\n";
|
|
installcheck();
|
|
|
|
# now we can chdir into the source dir
|
|
chdir "$topdir/src/bin/pg_upgrade";
|
|
print "\nDumping old cluster\n\n";
|
|
@args = ('pg_dumpall', '-f', "$tmp_root/dump1.sql");
|
|
system(@args) == 0 or exit 1;
|
|
print "\nStopping old cluster\n\n";
|
|
system("pg_ctl -m fast stop") == 0 or exit 1;
|
|
$ENV{PGDATA} = "$data";
|
|
print "\nSetting up new cluster\n\n";
|
|
standard_initdb() or exit 1;
|
|
print "\nRunning pg_upgrade\n\n";
|
|
@args = ('pg_upgrade', '-d', "$data.old", '-D', $data, '-b', $bindir,
|
|
'-B', $bindir);
|
|
system(@args) == 0 or exit 1;
|
|
print "\nStarting new cluster\n\n";
|
|
@args = ('pg_ctl', '-l', "$logdir/postmaster2.log", '-w', 'start');
|
|
system(@args) == 0 or exit 1;
|
|
print "\nSetting up stats on new cluster\n\n";
|
|
system(".\\analyze_new_cluster.bat") == 0 or exit 1;
|
|
print "\nDumping new cluster\n\n";
|
|
@args = ('pg_dumpall', '-f', "$tmp_root/dump2.sql");
|
|
system(@args) == 0 or exit 1;
|
|
print "\nStopping new cluster\n\n";
|
|
system("pg_ctl -m fast stop") == 0 or exit 1;
|
|
print "\nDeleting old cluster\n\n";
|
|
system(".\\delete_old_cluster.bat") == 0 or exit 1;
|
|
print "\nComparing old and new cluster dumps\n\n";
|
|
|
|
@args = ('diff', '-q', "$tmp_root/dump1.sql", "$tmp_root/dump2.sql");
|
|
system(@args);
|
|
$status = $?;
|
|
if (!$status)
|
|
{
|
|
print "PASSED\n";
|
|
}
|
|
else
|
|
{
|
|
print "dumps not identical!\n";
|
|
exit(1);
|
|
}
|
|
}
|
|
|
|
sub fetchRegressOpts
|
|
{
|
|
my $handle;
|
|
open($handle, "<GNUmakefile")
|
|
|| open($handle, "<Makefile")
|
|
|| die "Could not open Makefile";
|
|
local ($/) = undef;
|
|
my $m = <$handle>;
|
|
close($handle);
|
|
my @opts;
|
|
|
|
$m =~ s{\\\r?\n}{}g;
|
|
if ($m =~ /^\s*REGRESS_OPTS\s*\+?=(.*)/m)
|
|
{
|
|
|
|
# Substitute known Makefile variables, then ignore options that retain
|
|
# an unhandled variable reference. Ignore anything that isn't an
|
|
# option starting with "--".
|
|
@opts = grep {
|
|
s/\Q$(top_builddir)\E/\"$topdir\"/;
|
|
$_ !~ /\$\(/ && $_ =~ /^--/
|
|
} split(/\s+/, $1);
|
|
}
|
|
if ($m =~ /^\s*ENCODING\s*=\s*(\S+)/m)
|
|
{
|
|
push @opts, "--encoding=$1";
|
|
}
|
|
if ($m =~ /^\s*NO_LOCALE\s*=\s*\S+/m)
|
|
{
|
|
push @opts, "--no-locale";
|
|
}
|
|
return @opts;
|
|
}
|
|
|
|
sub fetchTests
|
|
{
|
|
|
|
my $handle;
|
|
open($handle, "<GNUmakefile")
|
|
|| open($handle, "<Makefile")
|
|
|| die "Could not open Makefile";
|
|
local ($/) = undef;
|
|
my $m = <$handle>;
|
|
close($handle);
|
|
my $t = "";
|
|
|
|
$m =~ s{\\\r?\n}{}g;
|
|
if ($m =~ /^REGRESS\s*=\s*(.*)$/gm)
|
|
{
|
|
$t = $1;
|
|
$t =~ s/\s+/ /g;
|
|
|
|
if ($m =~ /contrib\/pgcrypto/)
|
|
{
|
|
|
|
# pgcrypto is special since the tests depend on the
|
|
# configuration of the build
|
|
|
|
my $cftests =
|
|
$config->{openssl}
|
|
? GetTests("OSSL_TESTS", $m)
|
|
: GetTests("INT_TESTS", $m);
|
|
my $pgptests =
|
|
$config->{zlib}
|
|
? GetTests("ZLIB_TST", $m)
|
|
: GetTests("ZLIB_OFF_TST", $m);
|
|
$t =~ s/\$\(CF_TESTS\)/$cftests/;
|
|
$t =~ s/\$\(CF_PGP_TESTS\)/$pgptests/;
|
|
}
|
|
}
|
|
|
|
return split(/\s+/, $t);
|
|
}
|
|
|
|
sub GetTests
|
|
{
|
|
my $testname = shift;
|
|
my $m = shift;
|
|
if ($m =~ /^$testname\s*=\s*(.*)$/gm)
|
|
{
|
|
return $1;
|
|
}
|
|
return "";
|
|
}
|
|
|
|
sub InstallTemp
|
|
{
|
|
print "Setting up temp install\n\n";
|
|
Install("$tmp_installdir", "all", $config);
|
|
$ENV{PATH} = "$tmp_installdir/bin;$ENV{PATH}";
|
|
}
|
|
|
|
sub usage
|
|
{
|
|
print STDERR
|
|
"Usage: vcregress.pl <mode> [ <schedule> ]\n\n",
|
|
"Options for <mode>:\n",
|
|
" bincheck run tests of utilities in src/bin/\n",
|
|
" check deploy instance and run regression tests on it\n",
|
|
" contribcheck run tests of modules in contrib/\n",
|
|
" ecpgcheck run regression tests of ECPG\n",
|
|
" installcheck run regression tests on existing instance\n",
|
|
" isolationcheck run isolation tests\n",
|
|
" modulescheck run tests of modules in src/test/modules/\n",
|
|
" plcheck run tests of PL languages\n",
|
|
" recoverycheck run recovery test suite\n",
|
|
" upgradecheck run tests of pg_upgrade\n",
|
|
"\nOptions for <schedule>:\n",
|
|
" serial serial mode\n",
|
|
" parallel parallel mode\n";
|
|
exit(1);
|
|
}
|