postgres/contrib/tablefunc
Michael Paquier d61a361d1a Remove all traces of tuplestore_donestoring() in the C code
This routine is a no-op since dd04e95 from 2003, with a macro kept
around for compatibility purposes.  This has led to the same code
patterns being copy-pasted around for no effect, sometimes in confusing
ways like in pg_logical_slot_get_changes_guts() from logical.c where the
code was actually incorrect.

This issue has been discussed on two different threads recently, so
rather than living with this legacy, remove any uses of this routine in
the C code to simplify things.  The compatibility macro is kept to avoid
breaking any out-of-core modules that depend on it.

Reported-by: Tatsuhito Kasahara, Justin Pryzby
Author: Tatsuhito Kasahara
Discussion: https://postgr.es/m/20211217200419.GQ17618@telsasoft.com
Discussion: https://postgr.es/m/CAP0=ZVJeeYfAeRfmzqAF2Lumdiv4S4FewyBnZd4DPTrsSQKJKw@mail.gmail.com
2022-02-17 09:52:02 +09:00
..
data Have crosstab variants treat NULL rowid as a category in its own right, 2007-11-10 05:00:41 +00:00
expected tablefunc: Reject negative number of tuples passed to normal_rand() 2020-11-25 15:30:18 +01:00
sql tablefunc: Reject negative number of tuples passed to normal_rand() 2020-11-25 15:30:18 +01:00
.gitignore Support "make check" in contrib 2011-04-25 22:27:11 +03:00
Makefile Remove support for upgrading extensions from "unpackaged" state. 2020-02-19 16:59:14 -05:00
tablefunc--1.0.sql Throw a useful error message if an extension script file is fed to psql. 2011-10-12 15:45:03 -04:00
tablefunc.c Remove all traces of tuplestore_donestoring() in the C code 2022-02-17 09:52:02 +09:00
tablefunc.control Mark some contrib modules as "trusted". 2020-02-13 15:02:35 -05:00
tablefunc.h Update copyright for 2022 2022-01-07 19:04:57 -05:00