mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix off-by-one bug in XactLogCommitRecord

Browse Source 
Commit 1eb6d6527aae introduced zeroed alignment bytes in the GID field
of commit/abort WAL records.  Fixup commit cf5a1890592b later changed
that representation into a regular cstring with a single terminating
zero byte, but it also introduced an off-by-one mistake.  Fix that.

Author: Nikhil Sontakke
Reported-by: Nikhil Sontakke
Discussion: https://postgr.es/m/CAMGcDxey6dG1DP34_tJMoWPcp5sPJUAL4K5CayUUXLQSx2GQpA@mail.gmail.com
This commit is contained in:
Alvaro Herrera 2018-06-15 15:00:41 -04:00
parent dad8bed04a
commit ff03112bdc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/access/transam/xact.c
View File

@ -5365,7 +5365,7 @@ XactLogCommitRecord(TimestampTz commit_time,
{ {
XLogRegisterData((char *) (&xl_twophase), sizeof(xl_xact_twophase)); XLogRegisterData((char *) (&xl_twophase), sizeof(xl_xact_twophase));
if (xl_xinfo.xinfo & XACT_XINFO_HAS_GID) if (xl_xinfo.xinfo & XACT_XINFO_HAS_GID)
XLogRegisterData((char *) twophase_gid, strlen(twophase_gid)); XLogRegisterData((char *) twophase_gid, strlen(twophase_gid) + 1);
} }
if (xl_xinfo.xinfo & XACT_XINFO_HAS_ORIGIN) if (xl_xinfo.xinfo & XACT_XINFO_HAS_ORIGIN)