mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix NULL handling in multi-batch Parallel Hash Left Join.

Browse Source 
NULL keys in left joins were skipped when building batch files.
Repair, by making the keep_nulls argument to ExecHashGetHashValue()
depend on whether this is a left outer join, as we do in other
paths.

Bug #15475.  Thinko in 1804284042e.  Back-patch to 11.

Reported-by: Paul Schaap
Diagnosed-by: Andrew Gierth
Dicussion: https://postgr.es/m/15475-11a7a783fed72a36%40postgresql.org
This commit is contained in:
Thomas Munro 2018-11-03 11:08:03 +13:00
parent ca49b5ca5a
commit fd6449aa38
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/executor/nodeHashjoin.c
View File

@ -1395,7 +1395,7 @@ ExecParallelHashJoinPartitionOuter(HashJoinState *hjstate)
if (ExecHashGetHashValue(hashtable, econtext, if (ExecHashGetHashValue(hashtable, econtext,
hjstate->hj_OuterHashKeys, hjstate->hj_OuterHashKeys,
true, /* outer tuple */ true, /* outer tuple */
false, /* outer join, currently unsupported */ HJ_FILL_OUTER(hjstate),
&hashvalue)) &hashvalue))
{ {
int batchno; int batchno;