mirrors
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove redundant incomplete split assertion. 

The fastpath insert optimization's incomplete split flag Assert() is
redundant.  We'll reach the more general Assert() within
_bt_findinsertloc() in all cases. (Besides, Assert()'ing that the
rightmost page doesn't have the flag set never made much sense.)
This commit is contained in:
Peter Geoghegan 2020-01-05 17:42:13 -08:00
parent 8c081a2f4e
commit fc31001123
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/access/nbtree/nbtinsert.c
View File

@ -179,11 +179,6 @@ top:
PageGetMaxOffsetNumber(page) >= P_FIRSTDATAKEY(lpageop) && PageGetMaxOffsetNumber(page) >= P_FIRSTDATAKEY(lpageop) &&
_bt_compare(rel, itup_key, page, P_FIRSTDATAKEY(lpageop)) > 0) _bt_compare(rel, itup_key, page, P_FIRSTDATAKEY(lpageop)) > 0)
{ {
/*
* The right-most block should never have an incomplete split.
* But be paranoid and check for it anyway.
*/
Assert(!P_INCOMPLETE_SPLIT(lpageop));
fastpath = true; fastpath = true;
} }
else else