mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Be a bit less cavalier with both the code and the comment for UNKNOWN fix.

Browse Source
This commit is contained in:
Tom Lane 2010-08-19 17:31:56 +00:00
parent 075abb1787
commit f958310a85
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/pl/plpgsql/src/pl_exec.c
View File

@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.244.2.8 2010/08/19 16:54:51 heikki Exp $
* $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.244.2.9 2010/08/19 17:31:56 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -5431,14 +5431,16 @@ exec_eval_using_params(PLpgSQL_execstate *estate, List *params)
if (ppd->types[i] == UNKNOWNOID)
{
/*
* Treat 'unknown' parameters as text, that's what most people
* would expect. The backend can coerce unknown constants in a
* more intelligent way, but not unknown Params.
* Treat 'unknown' parameters as text, since that's what most
* people would expect. SPI_execute_with_args can coerce unknown
* constants in a more intelligent way, but not unknown Params.
* This code also takes care of copying into the right context.
* Note we assume 'unknown' has the representation of C-string.
*/
ppd->types[i] = TEXTOID;
if (!isnull)
{
ppd->values[i] = CStringGetTextDatum((char *) ppd->values[i]);
ppd->values[i] = CStringGetTextDatum(DatumGetCString(ppd->values[i]));
ppd->freevals[i] = true;
}
}