mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't add bailout adjustment for non-strict deserialize calls.

Browse Source 
When building aggregate expression steps, strict checks need a bailout
jump for when a null value is encountered, so there is a list of steps
that require later adjustment. Adding entries to that list for steps
that aren't actually strict would be harmless, except that there is an
Assert which catches them. This leads to spurious errors on asserts
builds, for data sets that trigger parallel aggregation of an
aggregate with a non-strict deserialization function (no such
aggregates exist in the core system).

Repair by not adding the adjustment entry when it's not needed.

Backpatch back to 11 where the code was introduced.

Per a report from Darafei (Komzpa) of the PostGIS project; analysis
and patch by me.

Discussion: https://postgr.es/m/87mty7peb3.fsf@news-spur.riddles.org.uk
This commit is contained in:
Andrew Gierth 2021-01-28 10:53:10 +00:00
parent fdd405c63f
commit f7f2a28d43
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/executor/execExpr.c
View File

@ -2950,8 +2950,10 @@ ExecBuildAggTrans(AggState *aggstate, AggStatePerPhase phase,
scratch.resnull = &trans_fcinfo->argnull[argno + 1];
ExprEvalPushStep(state, &scratch);
adjust_bailout = lappend_int(adjust_bailout,
state->steps_len - 1);
/* don't add an adjustment unless the function is strict */
if (pertrans->deserialfn.fn_strict)
adjust_bailout = lappend_int(adjust_bailout,
state->steps_len - 1);
/* restore normal settings of scratch fields */
scratch.resvalue = &state->resvalue;