mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix up outdated comments

Browse Source 
The existing comments in load_relcache_init_file() were not flexible
when new entries were added at the end, so they ended up a bit wrong.
Simplify the comments to avoid this issue.
This commit is contained in:
Peter Eisentraut 2023-02-06 22:39:48 +01:00
parent cad5692051
commit f5da3d85b9
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/backend/utils/cache/relcache.c vendored
View File

@ -6141,7 +6141,7 @@ load_relcache_init_file(bool shared)
if (rel->rd_isnailed) if (rel->rd_isnailed)
nailed_indexes++; nailed_indexes++;
/* next, read the pg_index tuple */ /* read the pg_index tuple */
if (fread(&len, 1, sizeof(len), fp) != sizeof(len)) if (fread(&len, 1, sizeof(len), fp) != sizeof(len))
goto read_failed; goto read_failed;
@ -6172,7 +6172,7 @@ load_relcache_init_file(bool shared)
*/ */
InitIndexAmRoutine(rel); InitIndexAmRoutine(rel);
/* next, read the vector of opfamily OIDs */ /* read the vector of opfamily OIDs */
if (fread(&len, 1, sizeof(len), fp) != sizeof(len)) if (fread(&len, 1, sizeof(len), fp) != sizeof(len))
goto read_failed; goto read_failed;
@ -6182,7 +6182,7 @@ load_relcache_init_file(bool shared)
rel->rd_opfamily = opfamily; rel->rd_opfamily = opfamily;
/* next, read the vector of opcintype OIDs */ /* read the vector of opcintype OIDs */
if (fread(&len, 1, sizeof(len), fp) != sizeof(len)) if (fread(&len, 1, sizeof(len), fp) != sizeof(len))
goto read_failed; goto read_failed;
@ -6192,7 +6192,7 @@ load_relcache_init_file(bool shared)
rel->rd_opcintype = opcintype; rel->rd_opcintype = opcintype;
/* next, read the vector of support procedure OIDs */ /* read the vector of support procedure OIDs */
if (fread(&len, 1, sizeof(len), fp) != sizeof(len)) if (fread(&len, 1, sizeof(len), fp) != sizeof(len))
goto read_failed; goto read_failed;
support = (RegProcedure *) MemoryContextAlloc(indexcxt, len); support = (RegProcedure *) MemoryContextAlloc(indexcxt, len);
@ -6201,7 +6201,7 @@ load_relcache_init_file(bool shared)
rel->rd_support = support; rel->rd_support = support;
/* next, read the vector of collation OIDs */ /* read the vector of collation OIDs */
if (fread(&len, 1, sizeof(len), fp) != sizeof(len)) if (fread(&len, 1, sizeof(len), fp) != sizeof(len))
goto read_failed; goto read_failed;
@ -6211,7 +6211,7 @@ load_relcache_init_file(bool shared)
rel->rd_indcollation = indcollation; rel->rd_indcollation = indcollation;
/* finally, read the vector of indoption values */ /* read the vector of indoption values */
if (fread(&len, 1, sizeof(len), fp) != sizeof(len)) if (fread(&len, 1, sizeof(len), fp) != sizeof(len))
goto read_failed; goto read_failed;
@ -6221,7 +6221,7 @@ load_relcache_init_file(bool shared)
rel->rd_indoption = indoption; rel->rd_indoption = indoption;
/* finally, read the vector of opcoptions values */ /* read the vector of opcoptions values */
rel->rd_opcoptions = (bytea **) rel->rd_opcoptions = (bytea **)
MemoryContextAllocZero(indexcxt, sizeof(*rel->rd_opcoptions) * relform->relnatts); MemoryContextAllocZero(indexcxt, sizeof(*rel->rd_opcoptions) * relform->relnatts);