From f0ca378d4c139eda99ef14998115c1674dac3fc5 Mon Sep 17 00:00:00 2001 From: Peter Geoghegan Date: Wed, 15 Apr 2020 15:47:26 -0700 Subject: [PATCH] Slightly simplify nbtree split point choice loop. Spotted during post-commit review of the nbtree deduplication commit (commit 0d861bbb). --- src/backend/access/nbtree/nbtsplitloc.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/backend/access/nbtree/nbtsplitloc.c b/src/backend/access/nbtree/nbtsplitloc.c index 5f0d0be3c2..c850cd807c 100644 --- a/src/backend/access/nbtree/nbtsplitloc.c +++ b/src/backend/access/nbtree/nbtsplitloc.c @@ -820,18 +820,14 @@ _bt_bestsplitloc(FindSplitData *state, int perfectpenalty, penalty = _bt_split_penalty(state, state->splits + i); - if (penalty <= perfectpenalty) - { - bestpenalty = penalty; - lowsplit = i; - break; - } - if (penalty < bestpenalty) { bestpenalty = penalty; lowsplit = i; } + + if (penalty <= perfectpenalty) + break; } final = &state->splits[lowsplit];