mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix connection leak in dblink when dblink_connect() or dblink_connect_u()

Browse Source 
end with "duplicate connection name" errors.

Backported to release 7.4.
This commit is contained in:
Itagaki Takahiro 2010-06-09 00:56:25 +00:00
parent 3b530d90d5
commit effcafeaa1
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
contrib/dblink/dblink.c
View File

@ -8,7 +8,7 @@
* Darko Prenosil <Darko.Prenosil@finteh.hr>
* Shridhar Daithankar <shridhar_daithankar@persistent.co.in>
*
* $PostgreSQL: pgsql/contrib/dblink/dblink.c,v 1.82.2.3 2010/06/03 09:40:17 itagaki Exp $
* $PostgreSQL: pgsql/contrib/dblink/dblink.c,v 1.82.2.4 2010/06/09 00:56:25 itagaki Exp $
* Copyright (c) 2001-2009, PostgreSQL Global Development Group
* ALL RIGHTS RESERVED;
*
@ -2275,9 +2275,14 @@ createNewConnection(const char *name, remoteConn *rconn)
HASH_ENTER, &found);
if (found)
{
PQfinish(rconn->conn);
pfree(rconn);
ereport(ERROR,
(errcode(ERRCODE_DUPLICATE_OBJECT),
errmsg("duplicate connection name")));
}
hentry->rconn = rconn;
strlcpy(hentry->name, name, sizeof(hentry->name));