mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Restore setting of _USE_32BIT_TIME_T to 32 bit MSVC builds.

Browse Source 
This was removed in commit cd00406774,
we're not quite sure why, but there have been reports of crashes due
to AS Perl being built with it when we are not, and it certainly
seems like the right thing to do. There is still some uncertainty
as to why it sometimes fails and sometimes doesn't.

Original patch from Owais Khani, substantially reworked and
extended by Andrew Dunstan.
This commit is contained in:
Andrew Dunstan 2012-08-31 20:38:37 -04:00
parent c97a547a4a
commit ef58b87df2
2 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/tools/msvc/MSBuildProject.pm
View File

@ -61,16 +61,22 @@ EOF
print $f <<EOF;
</PropertyGroup>
EOF
# We have to use this flag on 32 bit targets because the 32bit perls
# are built with it and sometimes crash if we don't.
my $use_32bit_time_t =
$self->{platform} eq 'Win32' ? '_USE_32BIT_TIME_T;' : '';
$self->WriteItemDefinitionGroup(
$f, 'Debug',
{ defs => '_DEBUG;DEBUG=1;',
{ defs => "_DEBUG;DEBUG=1;$use_32bit_time_t",
opt => 'Disabled',
strpool => 'false',
runtime => 'MultiThreadedDebugDLL' });
$self->WriteItemDefinitionGroup(
$f,
'Release',
{ defs => '',
{ defs => "$use_32bit_time_t",
opt => 'Full',
strpool => 'true',
runtime => 'MultiThreadedDLL' });

11
src/tools/msvc/VCBuildProject.pm
View File

@ -32,9 +32,16 @@ sub WriteHeader
<Platforms><Platform Name="$self->{platform}"/></Platforms>
<Configurations>
EOF
# We have to use this flag on 32 bit targets because the 32bit perls
# are built with it and sometimes crash if we don't.
my $use_32bit_time_t =
$self->{platform} eq 'Win32' ? '_USE_32BIT_TIME_T;' : '';
$self->WriteConfiguration(
$f, 'Debug',
{ defs => '_DEBUG;DEBUG=1;',
{ defs => "_DEBUG;DEBUG=1;$use_32bit_time_t",
wholeopt => 0,
opt => 0,
strpool => 'false',
@ -42,7 +49,7 @@ EOF
$self->WriteConfiguration(
$f,
'Release',
{ defs => '',
{ defs => "$use_32bit_time_t",
wholeopt => 0,
opt => 3,
strpool => 'true',