From ef48a0573bf0fc5c7e23f077788a055aad9f5e9e Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 9 Sep 2019 10:30:22 +0200 Subject: [PATCH] Improve new AND CHAIN tests Tweak the tests so that we're not just testing the default setting of transaction_read_only. Reported-by: fn ln --- src/test/regress/expected/transactions.out | 4 ++-- src/test/regress/sql/transactions.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/expected/transactions.out b/src/test/regress/expected/transactions.out index 213de4be6b..1b03310029 100644 --- a/src/test/regress/expected/transactions.out +++ b/src/test/regress/expected/transactions.out @@ -940,7 +940,7 @@ ERROR: RELEASE SAVEPOINT can only be used in transaction blocks -- but this is OK, because the BEGIN converts it to a regular xact SELECT 1\; BEGIN\; SAVEPOINT sp\; ROLLBACK TO SAVEPOINT sp\; COMMIT; -- Tests for AND CHAIN in implicit transaction blocks -SET TRANSACTION READ WRITE\; COMMIT AND CHAIN; -- error +SET TRANSACTION READ ONLY\; COMMIT AND CHAIN; -- error ERROR: COMMIT AND CHAIN can only be used in transaction blocks SHOW transaction_read_only; transaction_read_only @@ -948,7 +948,7 @@ SHOW transaction_read_only; off (1 row) -SET TRANSACTION READ WRITE\; ROLLBACK AND CHAIN; -- error +SET TRANSACTION READ ONLY\; ROLLBACK AND CHAIN; -- error ERROR: ROLLBACK AND CHAIN can only be used in transaction blocks SHOW transaction_read_only; transaction_read_only diff --git a/src/test/regress/sql/transactions.sql b/src/test/regress/sql/transactions.sql index ba96f0f36f..bf1016489d 100644 --- a/src/test/regress/sql/transactions.sql +++ b/src/test/regress/sql/transactions.sql @@ -542,10 +542,10 @@ SELECT 1\; BEGIN\; SAVEPOINT sp\; ROLLBACK TO SAVEPOINT sp\; COMMIT; -- Tests for AND CHAIN in implicit transaction blocks -SET TRANSACTION READ WRITE\; COMMIT AND CHAIN; -- error +SET TRANSACTION READ ONLY\; COMMIT AND CHAIN; -- error SHOW transaction_read_only; -SET TRANSACTION READ WRITE\; ROLLBACK AND CHAIN; -- error +SET TRANSACTION READ ONLY\; ROLLBACK AND CHAIN; -- error SHOW transaction_read_only; CREATE TABLE abc (a int);