mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid memcpy() with same source and destination in pgstat_recv_replslot.

Browse Source 
Same type of issue as in commit 53d4f5fef and earlier fixes; also
found by apparently-more-picky-than-the-buildfarm valgrind testing.
This one is an oversight in commit 986816750.  Since that's new in
HEAD, no need for a back-patch.
This commit is contained in:
Tom Lane 2020-12-20 12:38:32 -05:00
parent 11072e8693
commit ed6329cfa9
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/postmaster/pgstat.c
View File

@ -6916,15 +6916,15 @@ pgstat_recv_replslot(PgStat_MsgReplSlot *msg, int len)
return; return;
/* it must be a valid replication slot index */ /* it must be a valid replication slot index */
Assert(idx >= 0 && idx < max_replication_slots); Assert(idx < nReplSlotStats);
if (msg->m_drop) if (msg->m_drop)
{ {
/* Remove the replication slot statistics with the given name */ /* Remove the replication slot statistics with the given name */
memcpy(&replSlotStats[idx], &replSlotStats[nReplSlotStats - 1], if (idx < nReplSlotStats - 1)
sizeof(PgStat_ReplSlotStats)); memcpy(&replSlotStats[idx], &replSlotStats[nReplSlotStats - 1],
sizeof(PgStat_ReplSlotStats));
nReplSlotStats--; nReplSlotStats--;
Assert(nReplSlotStats >= 0);
} }
else else
{ {