From ec678692f6d0a8b05b86ca08e96b51e4063cba32 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Wed, 17 Jul 2024 11:50:36 +0900 Subject: [PATCH] Make write of pgstats file durable at shutdown This switches the pgstats write code to use durable_rename() rather than rename(). This ensures that the stats file's data is durable when the statistics are written, which is something only happening at shutdown now with the checkpointer doing the job. This could cause the statistics to be lost even after PostgreSQL is shut down, should a host failure happen, for example. Suggested-by: Konstantin Knizhnik Reviewed-by: Bertrand Drouvot Discussion: https://postgr.es/m/ZpDQTZ0cAz0WEbh7@paquier.xyz --- src/backend/utils/activity/pgstat.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/backend/utils/activity/pgstat.c b/src/backend/utils/activity/pgstat.c index ed7baa6e04..2e22bf2707 100644 --- a/src/backend/utils/activity/pgstat.c +++ b/src/backend/utils/activity/pgstat.c @@ -1478,12 +1478,9 @@ pgstat_write_statsfile(void) tmpfile))); unlink(tmpfile); } - else if (rename(tmpfile, statfile) < 0) + else if (durable_rename(tmpfile, statfile, LOG) < 0) { - ereport(LOG, - (errcode_for_file_access(), - errmsg("could not rename temporary statistics file \"%s\" to \"%s\": %m", - tmpfile, statfile))); + /* durable_rename already emitted log message */ unlink(tmpfile); } }