mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update some incorrect comments about xlog records.

Browse Source 
The comments claim that certain pieces of data are part of the main
WAL record data when in reality they are part of the data for
block 0. Repair.

Bertrand Drouvot, reviewed by Amit Kapila. Originally reported by me.

Discussion: http://postgr.es/m/80db7836-4415-d54a-64c3-66b88b1430e7@gmail.com
This commit is contained in:
Robert Haas 2023-03-03 12:52:04 -05:00
parent b6a0d469ca
commit ebd551f586
3 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/include/access/gistxlog.h
View File

@ -52,9 +52,7 @@ typedef struct gistxlogDelete
TransactionId snapshotConflictHorizon; TransactionId snapshotConflictHorizon;
uint16 ntodelete; /* number of deleted offsets */ uint16 ntodelete; /* number of deleted offsets */
/* /* TODELETE OFFSET NUMBER ARRAY FOLLOWS */
* In payload of blk 0 : todelete OffsetNumbers
*/
} gistxlogDelete; } gistxlogDelete;
#define SizeOfGistxlogDelete (offsetof(gistxlogDelete, ntodelete) + sizeof(uint16)) #define SizeOfGistxlogDelete (offsetof(gistxlogDelete, ntodelete) + sizeof(uint16))

5
src/include/access/heapam_xlog.h
View File

@ -345,8 +345,9 @@ typedef struct xl_heap_freeze_page
TransactionId snapshotConflictHorizon; TransactionId snapshotConflictHorizon;
uint16 nplans; uint16 nplans;
/* FREEZE PLANS FOLLOW */ /*
/* OFFSET NUMBER ARRAY FOLLOWS */ * In payload of blk 0 : FREEZE PLANS and OFFSET NUMBER ARRAY
*/
} xl_heap_freeze_page; } xl_heap_freeze_page;
#define SizeOfHeapFreezePage (offsetof(xl_heap_freeze_page, nplans) + sizeof(uint16)) #define SizeOfHeapFreezePage (offsetof(xl_heap_freeze_page, nplans) + sizeof(uint16))

10
src/include/access/nbtxlog.h
View File

@ -236,9 +236,13 @@ typedef struct xl_btree_delete
uint16 ndeleted; uint16 ndeleted;
uint16 nupdated; uint16 nupdated;
/* DELETED TARGET OFFSET NUMBERS FOLLOW */ /*----
/* UPDATED TARGET OFFSET NUMBERS FOLLOW */ * In payload of blk 0 :
/* UPDATED TUPLES METADATA (xl_btree_update) ARRAY FOLLOWS */ * - DELETED TARGET OFFSET NUMBERS
* - UPDATED TARGET OFFSET NUMBERS
* - UPDATED TUPLES METADATA (xl_btree_update) ARRAY
*----
*/
} xl_btree_delete; } xl_btree_delete;
#define SizeOfBtreeDelete (offsetof(xl_btree_delete, nupdated) + sizeof(uint16)) #define SizeOfBtreeDelete (offsetof(xl_btree_delete, nupdated) + sizeof(uint16))